[00:43:19] cstone: sorry, pulled afk by kid care [00:43:54] so we seem to set it to completed when we file one automatically [00:44:06] i just wanted the manual ones to look like the automatic ones [00:44:15] and 'completed' seems to make sense conceptually [01:32:27] Ah sorry ejegg bad phrasing oh my part it's scheduled when I tested it [01:32:32] I think it should be completed too [01:32:38] But it defaults to scheduled [02:07:36] ah i see [02:10:49] scheduled activites are red too [02:12:26] question on our listener endpoints since its not soaptimes anymore what should it look like when you just go to it? [02:14:07] hmm, let's see! [02:14:37] Just looks like this: {"notificationResponse": "[accepted]"} [02:14:53] (for Adyen) [02:15:33] hmm mine is 500ing locally but maybe something I broke then [02:15:41] (03PS6) 10Ejegg: Set default subject for upgrade decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037088 (https://phabricator.wikimedia.org/T362087) [02:16:07] ok, ^^^ seems to save it as Completed [02:16:14] ok, let me try locally - that was on prod [02:16:46] just was trying to get adyens test endpoint to work [02:17:06] huh yeah, locally I just see a whitescreen at https://paymentsipntest5.wmcloud.org/adyen [02:17:09] lemme see if there's a log [02:17:28] smashpig didnt have anything helpful in its log [02:17:30] Last chance error handler fired. (2) foreach() argument must be of type array|object, null given @ /srv/smashpig/PaymentProviders/Adyen/AdyenRestListener.php:33 [02:18:01] right, we could guard against that being empty [02:18:09] ooh you saw that in the syslog? [02:18:25] yah [02:18:52] ooh now it does it for me maybe I got an ipn at the same time last time then hah [02:19:15] (03PS1) 10Ejegg: Guard against empty POST in Adyen listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1046806 [02:21:53] ejegg: what is that live endpoint you just hit i can never remember it [02:23:05] (03CR) 10Cstone: [C:03+2] Guard against empty POST in Adyen listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1046806 (owner: 10Ejegg) [02:23:33] (03Merged) 10jenkins-bot: Guard against empty POST in Adyen listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1046806 (owner: 10Ejegg) [02:23:35] cstone: payments-listener.wikimedia.org/ [02:24:14] thanks! [02:25:28] on the smashpig page now [02:25:42] ah that's a good place for it [02:25:44] thank you [02:25:45] finally tolerable to be outside today at 8:30pm [02:26:27] oh jeez. the heat hits here tomorrow [02:26:58] good luck [02:27:11] we had 8% humidty today so lucked out there [02:38:51] supposed to be like 50% humidity and 93 degrees tomorrow here [02:39:00] k, gonna head to bed. [02:45:03] (03CR) 10Cstone: [C:03+2] "thanks looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037088 (https://phabricator.wikimedia.org/T362087) (owner: 10Ejegg) [02:45:19] (03Abandoned) 10Ejegg: Update soapinject script to work with python3 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/922881 (owner: 10Ejegg) [03:07:16] (03Merged) 10jenkins-bot: Set default subject for upgrade decline activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037088 (https://phabricator.wikimedia.org/T362087) (owner: 10Ejegg) [04:01:35] (03CR) 10Cstone: [C:03+2] "farewell!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037863 (https://phabricator.wikimedia.org/T263621) (owner: 10Ejegg) [04:02:00] (03Merged) 10jenkins-bot: Fully delete all WSDL/SOAP stuff from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037863 (https://phabricator.wikimedia.org/T263621) (owner: 10Ejegg) [05:15:46] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: kevinToldMeToCallThis(), 06Fundraising-Backlog: Add expiration period of 12 months to the 'Recurring Upgrade Declined' activity type in Civi - https://phabricator.wikimedia.org/T363433#9902052 (10MSuijkerbuijk_WMF) Thanks [06:48:40] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_40) - 10https://gerrit.wikimedia.org/r/1046847 (owner: 10L10n-bot) [13:18:13] 06Fundraising-Backlog, 10FR-donorservices: Civi Tag sync with Acoustic - feature request - https://phabricator.wikimedia.org/T366212#9903244 (10SHust) I created the following tags based on known + two upcoming campaigns: {F55436256} [13:32:57] wooo hoooo bye bye WSDL [13:42:21] 06Fundraising-Backlog, 10Wikimedia-Portals: Update donation links on Portal to use wmf_ parameters - https://phabricator.wikimedia.org/T367358#9903358 (10Pcoombe) 05Open→03Resolved [13:46:00] (03PS3) 10Ejegg: Better missing token flow for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039230 (https://phabricator.wikimedia.org/T365884) [13:49:17] (03PS6) 10Ejegg: DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) [13:49:17] (03PS1) 10Ejegg: WIP ProcessCaptureRequestJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) [13:49:42] (03CR) 10CI reject: [V:04-1] WIP ProcessCaptureRequestJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [14:13:26] (03PS2) 10Ejegg: ProcessCaptureRequestJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) [16:21:59] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Coworker - send fail mail when a queue aborts - https://phabricator.wikimedia.org/T349751#9904113 (10Ejegg) We seem to be getting these already! @Eileenmcnaughton can this be closed, or is there more to do? [16:23:53] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make requested changes to CiviProxy pull request - https://phabricator.wikimedia.org/T346451#9904128 (10Ejegg) 05Open→03Resolved a:03Ejegg Changes have been made, and the pull request was just accepted! [16:24:25] fr-tech systopia accepted the CiviProxy pull request! https://github.com/systopia/CiviProxy/pull/67 [16:27:26] ooh, i just saw an email from Amazon that suggests their old API EOL is extended till March 31 [16:27:40] so maybe we could turn that back on if they would only re-activate their proxy [16:27:50] anyway, off to get some lunch [16:30:05] support was a black hole when trying to understand the proxy was down. [16:45:33] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog: Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360#9904202 (10Dbrant) My (totally unbiased) preference would be option 2: use the `id` value from the existing campaign structure.... [16:53:33] nuu linux machine froze itself while it was asleep [16:54:58] cstone: sometimes mine boots up from sleep(?) and then firefox takes all the ram so I wake up to/open my laptop to "sorry, firefox was killed". /me shrug [16:55:36] (boots up in the middle of the night, I think) [17:08:24] ejegg|food: I did lean on them a bit in Hamburg :-) [17:09:02] hah. thanks, eileen! [17:09:29] nothing like a captive audience [17:28:02] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the work and updates. There are a few minor follow-ups, but none worthy of holding this up. Nice work!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [17:28:32] (03Merged) 10jenkins-bot: Gravy create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1037776 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [18:23:46] (03PS1) 10Jgleeson: Remove GravyPaymentResponseFactory::fromRawResponse() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047157 (https://phabricator.wikimedia.org/T364506) [18:24:09] (03CR) 10CI reject: [V:04-1] Remove GravyPaymentResponseFactory::fromRawResponse() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047157 (https://phabricator.wikimedia.org/T364506) (owner: 10Jgleeson) [18:30:30] (03PS2) 10Jgleeson: Remove GravyPaymentResponseFactory::fromRawResponse() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047157 (https://phabricator.wikimedia.org/T364506) [18:51:06] (03PS1) 10Jgleeson: Extract out Gravy amount transformation to function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047159 (https://phabricator.wikimedia.org/T364506) [19:00:16] (03PS18) 10Jgleeson: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [19:00:43] (03CR) 10CI reject: [V:04-1] Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [19:02:09] (03PS19) 10Jgleeson: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [19:02:36] (03CR) 10CI reject: [V:04-1] Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [19:03:13] (03PS20) 10Jgleeson: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [19:48:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Already cancelled paypals are getting cancelled again - https://phabricator.wikimedia.org/T367623#9904949 (10Cstone) 05Resolved→03Open [19:48:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Already cancelled paypals are getting cancelled again - https://phabricator.wikimedia.org/T367623#9904950 (10Cstone) a:05Ejegg→03Cstone [20:52:14] (03CR) 10Jgleeson: [C:03+2] "Working great for me! thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042453 (https://phabricator.wikimedia.org/T341247) (owner: 10Cstone) [20:52:34] Thanks jgleeson ! [20:52:42] np! [20:59:18] (03PS11) 10Jgleeson: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [20:59:49] (03CR) 10CI reject: [V:04-1] Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [21:05:24] (03PS12) 10Jgleeson: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [21:08:52] (03PS1) 10Jgleeson: Minor casing fix to Gravy API param. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047179 (https://phabricator.wikimedia.org/T367112) [21:13:46] (03Merged) 10jenkins-bot: Switch cancel_reason field to dropdown [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1042453 (https://phabricator.wikimedia.org/T341247) (owner: 10Cstone) [21:27:53] (03PS3) 10Jgleeson: Add script to safely checkout smashpig patch to payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1046738 (https://phabricator.wikimedia.org/T367798) [21:29:00] (03PS4) 10Jgleeson: Add script to safely checkout smashpig patch to payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1046738 (https://phabricator.wikimedia.org/T367798) [21:51:01] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Webhook Processing - https://phabricator.wikimedia.org/T367807#9905361 (10AKanji-WMF) [21:51:02] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: alter field name on SEPA form - https://phabricator.wikimedia.org/T367906#9905360 (10AKanji-WMF) [21:51:04] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 07payments-orchestration: Gravy - Recurring payment flow from DonationInterface - https://phabricator.wikimedia.org/T367578#9905363 (10AKanji-WMF) [21:51:05] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#9905365 (10AKanji-WMF) [21:51:07] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review: Fundraising-dev: Add script to safely checkout smashpig patch to payments composer package directory - https://phabricator.wikimedia.org/T367798#9905362 (10AKanji-WMF) [21:51:08] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy backend approve payment - https://phabricator.wikimedia.org/T367112#9905364 (10AKanji-WMF) [21:51:10] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#9905366 (10AKanji-WMF) [21:51:12] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Update RML donors to have status of non-donor in CiviCRM - https://phabricator.wikimedia.org/T365534#9905368 (10AKanji-WMF) [21:51:16] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356#9905367 (10AKanji-WMF) [21:51:20] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Move a bunch of code out of wmf_civicrm.module - https://phabricator.wikimedia.org/T365415#9905370 (10AKanji-WMF) [21:51:24] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Consolidate error handling in queues - https://phabricator.wikimedia.org/T365418#9905369 (10AKanji-WMF) [21:51:28] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#9905371 (10AKanji-WMF) [21:51:32] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy frontend createPayment - https://phabricator.wikimedia.org/T364508#9905373 (10AKanji-WMF) [21:51:36] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: On import, widen the existing contact lookup to include subset & reversed - https://phabricator.wikimedia.org/T365216#9905372 (10AKanji-WMF) [21:51:40] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy backend createPayment - https://phabricator.wikimedia.org/T364506#9905374 (10AKanji-WMF) [21:51:44] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10FR-Civi-Dedupe: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#9905377 (10AKanji-WMF) [21:51:48] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#9905376 (10AKanji-WMF) [21:51:52] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Paypal Giving Fund donations added to Civi under incorrect CID - https://phabricator.wikimedia.org/T363768#9905375 (10AKanji-WMF) [21:51:56] 14Fundraising Sprint: hammertime($touch_this=false), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, and 3 others: Allow DR to manually add a "Recurring Upgrade Declined" activity - https://phabricator.wikimedia.org/T362087#9905378 (10AKanji-WMF) [21:52:00] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: ACH on PaymentsWiki - Form Changes - https://phabricator.wikimedia.org/T360825#9905381 (10AKanji-WMF) [21:52:04] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review: Add activies when recurring donation starts and leaves autorescue flow - https://phabricator.wikimedia.org/T361256#9905379 (10AKanji-WMF) [21:52:08] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, and 2 others: Revisit old PayPal bugs, delete code if no longer needed - https://phabricator.wikimedia.org/T355448#9905383 (10AKanji-WMF) [21:52:12] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: ask Civi to use PayPal's API when canceling recurrings due to chargebacks - https://phabricator.wikimedia.org/T361243#9905380 (10AKanji-WMF) [21:52:16] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog: Create links to incorporate ACH into Banners and Emails - https://phabricator.wikimedia.org/T360124#9905382 (10AKanji-WMF) [21:52:20] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Unnecessary deduple conflicts on language - https://phabricator.wikimedia.org/T298169#9905386 (10AKanji-WMF) [21:52:24] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Year end update for donor segments & statuses - https://phabricator.wikimedia.org/T344216#9905384 (10AKanji-WMF) [21:52:28] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9905385 (10AKanji-WMF) [21:52:37] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Spike - do practice Civi standalone installs locally to get our heads around it - https://phabricator.wikimedia.org/T276395#9905387 (10AKanji-WMF) [21:52:41] 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Move wmf_audit logic into wmf-civicrm Civi extension - https://phabricator.wikimedia.org/T270675#9905388 (10AKanji-WMF) [21:52:47] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#9905390 (10AKanji-WMF) [22:09:08] it's almost like he's screaming it here in the channel (Leroy, that is)