[00:09:05] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: LeeroyJenkinsssss(), 06Fundraising-Backlog, 13Patch-For-Review: Add activies when recurring donation starts and leaves autorescue flow - https://phabricator.wikimedia.org/T361256#9912214 (10Cstone) [00:10:29] (03CR) 10Cstone: "thanks for looking at this Dami!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [00:44:33] (03PS1) 10Ejegg: Restore the cancellation activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048145 (https://phabricator.wikimedia.org/T367451) [01:21:55] (03CR) 10Jdlrobson: [C:04-1] "We talked about this - we can only determine when the showing of a banner starts." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1016759 (https://phabricator.wikimedia.org/T361680) (owner: 10Jdlrobson) [01:33:44] 06Fundraising-Backlog, 10FR-donorservices: Sepa oddity - https://phabricator.wikimedia.org/T368080#9912395 (10Cstone) @SHust on the test refunds, how were they done? I don't see the refund type in Adyen's console compared to the tests I did with cid=63848894 Also our notification from Adyen for R2FW695VNKFJ8X... [01:34:41] hah ejegg we lost the activity? I thought it had been there then just thought I remembered wrong when it was gone [02:23:37] (03PS1) 10Ejegg: Clear out rescue_reference on cancel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048172 (https://phabricator.wikimedia.org/T367451) [02:49:39] (03PS1) 10Ejegg: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048180 (https://phabricator.wikimedia.org/T364913) [02:50:07] cstone: so if you use API3 (or the UI form) it creates the activity [02:50:16] but if you use API4 it doesn't [02:50:45] and I wanted to update that to use just one API4 call [02:50:56] so I had to recreate the activity code [02:51:20] i thought maybe the series of small patches would be easier to read, but I could squash them together if you prefer [02:52:12] I'mma self-merge that patch to restore the snooze date [02:52:23] (03CR) 10Ejegg: [C:03+2] Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048180 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [02:52:31] small patches is good [02:52:40] :) [02:53:03] k, I gotta get to bed. It just rained + thundered here and finally cooled down a bit. [02:53:10] See ya tomorrow! [02:53:45] arrrr [02:53:59] wait, i want to get that fix up before the weekend + offsite [02:54:16] I mean the custom data restore, not the other one [02:54:33] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048181 [02:54:36] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048181 (owner: 10Ejegg) [02:55:11] so that's just the custom data restore (same code as was up before this morning's deploy) plus dami's patch to revert the special handling on the dlocal audit [02:55:17] I think it should be totally safe [02:55:23] (03CR) 10Ejegg: [V:03+2 C:03+2] Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048180 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [03:03:05] (03CR) 10Ejegg: [V:03+2 C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048181 (owner: 10Ejegg) [03:04:39] !log fundraising civicrm upgraded from 2e1db811 to 8a0b5bea [03:04:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:12:55] (03CR) 10Ejegg: "Looking pretty good, but we might be able to avoid those constants" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [03:14:12] thanks ejegg I was following your other example nice that there's a more straightforward way [04:39:02] (03CR) 10Cstone: Add acitives for recurring failure and autorescue (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [04:40:28] (03PS10) 10Cstone: Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) [13:30:00] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#9913431 (10CDenes_WMF) Ok interesting. I'll check in with Caitlin Virtue as to if this is an intentional donor behavior. As I was always under the imp... [13:32:08] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048075 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [13:45:42] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048076 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [13:48:29] 06Fundraising-Backlog: Give RLewis access to https://civicrm.wikimedia.org/admin/config/large_donation/configure - https://phabricator.wikimedia.org/T368152 (10jgleeson) 03NEW [13:59:15] (03Merged) 10jenkins-bot: Re-do cancellation backfill also blanking rescue_reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048075 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [14:06:16] (03Merged) 10jenkins-bot: Try/catch around ContributionRecur post hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048076 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [14:29:34] thanks for the CR jgleeson|skrun ! [14:38:33] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048482 [14:39:58] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048482 (owner: 10Ejegg) [14:41:06] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1048482 (owner: 10Ejegg) [14:47:42] (03PS1) 10Ejegg: Update devDependency wdio to match MW core [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1048484 [14:50:39] eileen: I think ^^^ should pull in the new ws [14:50:56] (03CR) 10CI reject: [V:04-1] Update devDependency wdio to match MW core [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1048484 (owner: 10Ejegg) [14:52:29] oh i need to check in the updated lock file [14:52:53] (03PS2) 10Ejegg: Update devDependency wdio to match MW core [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1048484 [15:01:41] !log fundraising civicrm upgraded from 8a0b5bea to 13a13f3a [15:01:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:12:59] dang, it's still logging errors but at least with that try/catch it's not failmailing [15:13:42] so is that '' not working to blank it out? [15:14:27] huh, seems to be empty string now [15:15:31] i am so puzzled [15:15:51] i am assuming the post hook runs after the db write - is that a bad assumption? [15:16:18] 'This hook is called after a db write on some core objects.' [15:17:09] hmmmmmm [15:17:17] trying again locally [15:25:01] ahhhh the post event fires BEFORE the custom values are stored [15:25:03] welllll [15:25:18] can I get at the values that are ABOUT to be stored in the custom value table? [15:28:29] also maybe we should queue up the API call rather than holding up a DB commit while we do a network transaction [15:34:37] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks cstone, +1'ing to make room for ejegg's review of the response to his comments." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [15:45:46] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048078 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [15:46:03] thanks jgleeson [15:46:06] np [15:46:31] took me about 20 minutes to get xdebug working with unit tests, again, to step through it [15:46:32] I think I'm going to need a follow-up, since I realized the post hook is actually fired before the custom field db row is written :P [15:46:45] ahhh xdebug... [15:46:59] some days it works some days it doesn't [15:47:06] did you need to comment out the bits in the php bootstrap to make it run? [15:47:14] or you have a different trick, don't you? [15:47:38] I tend to use https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/969950?usp=dashboard [15:47:40] no this time the idekey wasn't working so I just enabled start_with_request [15:47:46] ah [15:47:51] it _should_ have worked but then I gave up [15:48:02] yeah, i just flip start_with_request manually on and off [15:48:13] yeah that usually fixes things for me too [15:48:58] re:eval trick. yeah I use the same thing [15:49:14] good to have that as a patch. I think I have a git stash doing something similar [15:54:43] ahh maybe we can just move the hook to postCommit! [16:05:33] (03PS1) 10Ejegg: Move cancelRecurAutoRescue to postCommit hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048502 (https://phabricator.wikimedia.org/T367451) [16:08:01] (03Merged) 10jenkins-bot: importSubscriptionCancel uses single API4 call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048078 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [16:29:20] 06Fundraising-Backlog, 10FR-donorservices: Sepa oddity - https://phabricator.wikimedia.org/T368080#9913916 (10SHust) @Cstone, I can only assume that Rakhi or Salvatore refunded the test transactions. I'll reach out to them on Slack and let you know! [16:29:31] 06Fundraising-Backlog: Annual Recurring as Post-Payment Option - https://phabricator.wikimedia.org/T368155#9913917 (10MSuijkerbuijk_WMF) @Ejegg Yes, we will test the variant that Sam prepped in that link, removing the option to give a different monthly amount. Thanks [16:59:36] 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9914018 (10KHaggard) @Eileenmcnaughton Yes those last two are new fields because we're going to start building out a directmail program soon. I agree that the priority would b... [17:50:15] (03CR) 10Ejegg: "Looks like it should work pretty well! Found some nits to pick with spacing, and wondering if we can de-duplicate some of the activity con" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [18:05:20] ejegg: I think we would want autorescue people to get two activies, just from a stats standpoint? then we could get all failures, and then if they are are in the autorescue flow we would have that data point too [18:08:01] cstone yep, two activities sounds good. [18:08:25] I just figured if we already have the failed payment details in the first activity, we could put different details in the autorescue one [18:08:48] ah okay I was struggling to fill both fields hah instead of just duplicating both but maybe thats fine [18:11:11] eh, ok, no biggie [18:11:24] maybe just the spacing and the throw? [18:11:41] yeah I want to test it too I didn't rerun it fully after changing the activity name last night [18:13:12] from waht i saw the subject was what shows up in the activites UI and then the details only shows up if you click into the activity [18:13:36] would not having the reason the payment failed tied to the autorescue be helpful there? or i can just duplicate like I did for the first one? [18:14:31] cstone: ah I guess so [18:14:40] like we could put the rescue reference in the details too its just in the subject [18:15:40] let me see what subjects are looking like for other activities [18:15:47] i had the idea they maybe should be simpler [18:15:50] but let me check [18:16:34] ok, I see, a lot do have specific amounts in the subject [18:16:42] theres UI space there some already go to two lines too [18:16:56] i was thining most helpful for DR or us looking at a record there [18:16:59] thinking* [18:17:50] k, i'm convinced, more info in the subject is good. [18:18:04] I'm waffling on the renaming, I think damis suggestion is good but then the rest of our code everywhere already calls it autorescue [18:18:06] what do you think there? [18:18:12] autorescue vs processor retry [18:18:43] ah right [18:18:54] yeah, I guess we tried to be generic at the smashpig layer [18:19:04] but in Civi we're using 'rescue' a lot [18:19:15] hmmm [18:20:15] ok im back in favor of processor retry [18:20:31] yeah, i might make a case for processor retry since this is supposedly generic smashpig extension [18:20:36] and not one of our wmf ones [18:45:17] (03PS7) 10Ejegg: DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) [18:45:17] (03PS3) 10Ejegg: ProcessCaptureRequestJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) [18:45:17] (03PS1) 10Ejegg: RecurringContractJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048545 [18:45:44] is there some nice way to delete an activity [18:45:53] like the civi option value part [18:46:01] oh let's see [18:46:44] is it available in https://wmff.localhost:32353/civicrm/admin/options/ ? [18:47:28] hmm those look like a completely different set of activites? [18:47:29] ah most of the activity types don't have the delete button [18:47:45] cstone click the 'activity type' group [18:47:57] but then anything marked 'reserved' won't have the delete button [18:48:06] I'd just use sql or the api [18:48:41] ok no worries I just messed up deleting one locally now have broken failed activity but I already tested that one so its fine [18:48:53] in sql you'd need to look in the civicrm_option_value table [18:49:53] yeah I deleted it there and its causing issues it must be somewhere else too [18:50:10] our error response being possible different formats is annoying [18:53:35] (03PS11) 10Cstone: Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) [18:54:32] ok I think thats in a good state ejegg [19:00:15] (03PS12) 10Cstone: Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) [19:00:16] (03CR) 10Ejegg: [C:03+2] Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [19:04:09] (03CR) 10Cstone: [C:03+2] Restore the cancellation activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048145 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [19:26:32] (03Merged) 10jenkins-bot: Add acitives for recurring failure and autorescue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037204 (https://phabricator.wikimedia.org/T361256) (owner: 10Cstone) [19:26:34] (03Merged) 10jenkins-bot: Restore the cancellation activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1048145 (https://phabricator.wikimedia.org/T367451) (owner: 10Ejegg) [19:41:19] ejegg: how were you testing your autorescue stuff locally just hacking in the data? [19:41:30] yep yep [19:41:47] oh i asked that and my car just drove by THEY WASHED IT EVEN haha [19:41:54] ok cool ejegg [19:42:02] ooh nice, free wash! [19:42:10] yeah it was in a pretty sad state [19:42:16] in pollen season that's a pretty nice value [19:42:20] but any rain here is dirt rain and it just get dirtier [19:42:23] so i dont even bother haha [19:44:26] oh we can turn off that ingenico job runner [19:44:33] hmmmm... [19:44:37] i was going to say probably made we abandoned its endpoints? [19:44:46] yeah. i was just seeing that. i could revert the change if we don't want to do it now. [19:44:55] i was just pulling down the puppet code. [19:45:06] easy for me to revert and we can pick it up next week. there is no rush on it. [19:45:07] I think out contract is up anyway, isn't it? [19:45:13] I'mma just stop that job [19:45:25] yeah. i'm more concerned about creating churn before a travel weekend. [19:45:48] hah I'm just going to delete ingenico*.yaml [19:46:07] yeah its been rip for a while [19:46:19] ok cool. thanks and sorry for the scramble. [19:46:34] everyone likes deleting things [19:46:39] :) [19:47:01] theres a car outside now that says lost boys on the back in giant katakana haha [19:47:18] nobody stole THEIR nerd stickers.... [19:47:26] LOL [19:49:11] im thinking about maybe getting the rat sticker here https://www.reddit.com/media?url=https%3A%2F%2Fi.redd.it%2Fl5jzj2e5p27c1.jpeg as a replacement well see [20:19:10] 06Fundraising-Backlog, 10FR-donorservices: Sepa oddity - https://phabricator.wikimedia.org/T368080#9914362 (10RKumar_WMF) Apologies for any confusion. 207079947.1, 207079770.1 and 207079547.1 were test transactions and none of them were refunded. I was traveling on Wed hence could not refund them. Now, I see t... [20:34:18] as in this lost boys? https://en.wikipedia.org/wiki/The_Lost_Boys [20:36:16] I assume anilk [21:00:21] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 10Web-Team-Backlog (Needs Prioritization (Tech)): CentralNotice should catch banner errors and log them to its own channel - https://phabricator.wikimedia.org/T361680#9914468 (10Jdlrobson) @phuedx this may not be possible with... [21:01:16] 06Fundraising-Backlog: Annual Recurring as Post-Payment Option - https://phabricator.wikimedia.org/T368155#9914469 (10Ejegg) @MSuijkerbuijk_WMF so we need to support both variants being live at the same time, one with an annual option and one with a different amount option? [21:12:56] (03PS2) 10Ejegg: RecurringContractJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048545 (https://phabricator.wikimedia.org/T366367) [21:12:57] (03PS1) 10Ejegg: RecordCaptureJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048569 (https://phabricator.wikimedia.org/T366367) [21:14:43] (03PS1) 10Ejegg: Delete RunnableJob abstract class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048570 [21:18:30] (03PS2) 10Ejegg: Delete RunnableJob abstract class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048570 (https://phabricator.wikimedia.org/T366367) [21:33:20] (03CR) 10Eileen: [C:03+2] Update devDependency wdio to match MW core [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1048484 (owner: 10Ejegg) [21:35:32] 14Fundraising Spring - anybodyKnowWhatThisDoes(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Smashpig, 10Recurring-Donations: Cancel auto-rescue at Adyen when donor cancels recurring donation in Civi - https://phabricator.wikimedia.org/T351338#9914507 (10Dwisehaupt) Deployed firewal... [21:45:16] (03Merged) 10jenkins-bot: Update devDependency wdio to match MW core [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1048484 (owner: 10Ejegg) [21:57:08] 06Fundraising-Backlog, 10fundraising-tech-ops, 13Patch-For-Review: Remove references to worldline / ingenico / globalcollect from puppet - https://phabricator.wikimedia.org/T368114#9914545 (10Dwisehaupt) Puppet config removed. ` [frack::puppet] 44fc84024 Remove all the ingenico/globalcollect/worldline bits... [22:05:50] 06Fundraising-Backlog, 10fundraising-tech-ops, 13Patch-For-Review: Remove references to worldline / ingenico / globalcollect from puppet - https://phabricator.wikimedia.org/T368114#9914567 (10Dwisehaupt) PFW cleanup handled in T368178 [23:11:01] 10fundraising-tech-ops: Fundraising access request for tburrington - https://phabricator.wikimedia.org/T368097#9914655 (10Dwisehaupt) [23:20:51] 10fundraising-tech-ops: Fundraising access request for tburrington - https://phabricator.wikimedia.org/T368097#9914672 (10Dwisehaupt) Account setup complete. User account created and added to the proper groups. SSH pubkey added. Yubikey pubkey added. Account and config pushed out and puppet runs completed. Email...