[01:21:44] so I think if I get this pushed out https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/1053072 Katie can do her mapping which is the 'now thing' [02:11:47] ejegg|food: if you get back can you look at ^^ [03:06:02] hey ejegg - did you see ^^ [03:06:35] just reviewing now eileen [03:08:36] (03CR) 10Ejegg: [C:03+2] Add extra fields to export mapping [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1053072 (https://phabricator.wikimedia.org/T366529) (owner: 10Eileen) [03:08:41] looks good! [03:09:36] (03Merged) 10jenkins-bot: Add extra fields to export mapping [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1053072 (https://phabricator.wikimedia.org/T366529) (owner: 10Eileen) [03:16:49] ejegg: cool - I'm on the fence about the follow on so no need to worry about that one for now [03:17:13] part of the problem is the queries are so slow right now due to the segment update being recent [03:18:28] (03PS3) 10Eileen: Remove some good ideas [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051482 (https://phabricator.wikimedia.org/T365415) [03:18:36] (03CR) 10Ejegg: "RIP good ideas" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051482 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [03:18:45] I'm a bit confused though - it looks like we missed the cron window & the job does not look disabled - but I also don't see an output file for it [03:19:43] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1053089 [03:19:54] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1053089 (owner: 10Eileen) [03:20:23] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1053089 (owner: 10Eileen) [03:22:00] !log tools upgraded from 95f10b20 to 94bac5c6 [03:22:01] hope the rest of your day goes well eileen! [03:22:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:22:11] night [03:31:03] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9967992 (10Eileenmcnaughton) OK - I've deployed the code and kicked off the `silverpop_daily` job manually to push up the new file. Note that... [04:29:27] (03PS3) 10Eileen: Civi-stock 5.76-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052815 (https://phabricator.wikimedia.org/T368999) [04:29:27] (03PS1) 10Eileen: Port upgrade fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053091 (https://phabricator.wikimedia.org/T368999) [04:38:08] (03CR) 10Eileen: [C:03+2] Fix handling of timestamp in date custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1046722 (owner: 10Ejegg) [04:40:30] (03PS2) 10Eileen: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053053 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [04:40:30] (03PS1) 10Eileen: Port hook fix on recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053092 (https://phabricator.wikimedia.org/T367451) [05:01:00] (03Merged) 10jenkins-bot: Fix handling of timestamp in date custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1046722 (owner: 10Ejegg) [10:21:20] (03PS1) 10Jgleeson: make payments-smashpig-restore.sh only update vendor. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053273 [11:15:07] (03CR) 10Jgleeson: [C:04-1] "This is looking close. I left a few questions and tidy up requests. I'm also running into the 'Missing fields from billing data: billing.a" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [11:50:47] thanks for the CR jgleeson, I'd update the patches now [11:51:06] np damilare|brb [11:51:34] for the error, it should be fixed on the latest smashpig patch [12:11:53] ohh the erorr is because you're most likely using jwales@example.com, whose record was created with no line 2. So everything it's referenced, it errors out. [12:12:37] Testing with a new email should pass [12:13:18] however, this begs the question of if we want to update an existing record on every donation attempt. [12:14:20] I hope Gr4vy doesn't change a field like this in production [12:21:21] ah I see [12:21:30] jimmy is corrupted [12:28:36] lol yepp [12:29:09] :) [12:47:30] (03PS24) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [12:48:20] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the review, made the recommended changes and responded to some comments inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [12:48:33] thanks damilare will check it out shortly [12:49:25] (03CR) 10CI reject: [V:04-1] Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [12:49:34] thanks [13:55:46] (03PS23) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [13:56:07] (03PS18) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [14:03:29] damilare: https://phabricator.wikimedia.org/F56333213 [14:03:37] so.many.things [14:04:43] and that's the simplified/cutdown version [14:05:09] I deliberately left out monthly convert, recurring and some of the intermediate layers to make it easier to follow [14:05:30] but it should serve as a good base to add those [14:06:20] yh that'd be between the "capture" layer and "push to queuse" layer [14:06:39] if only they could abstract the donor creation/retrieval part from us... that'd make it look much like the Adyen flow [14:07:27] I guess once we get used to it it will be fine [14:08:09] ahh would it make any difference if we indicate that the session id is added to the SecureFields form... Like load "SecureFIelds with sessionId" [14:08:11] yep [14:10:12] yeah that makes sense. I'm gonna put this into ready for review shortly so feel free to go over it and validate it to your understanding [14:15:37] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 07Epic, 07payments-orchestration: Add Gravy UML Diagrams - https://phabricator.wikimedia.org/T369105#9969509 (10jgleeson) **Gravy Secure Fields Card Payment Sequence Diagram** **Note**: a lot is going on here, so I deliberately left a bunch of things o... [14:18:01] (03PS24) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [14:19:06] (03PS25) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [14:20:10] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the CR, I've made the recommended changes." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [14:20:40] (03PS19) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [14:21:10] have you changed something in the frontend patch damilare @_@ [14:21:16] that would impact the diagram [14:21:18] ha [14:21:48] no, just the changes you recommended. [14:22:18] ah gotcha [14:24:54] (03PS25) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [14:26:57] (03CR) 10CI reject: [V:04-1] Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [14:32:51] (03PS20) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [14:35:21] (03PS21) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [14:37:24] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 07Epic, 07payments-orchestration: Add Gravy UML Diagrams - https://phabricator.wikimedia.org/T369105#9969623 (10jgleeson) [14:37:43] (03PS26) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [14:37:55] fr-tech we have a wikitech gravy docs page https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/Gravy [14:37:56] (03PS22) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [14:39:36] one thing that diagram needs is step numbers [14:39:55] we added them to the dlocal india recurring diagrams and it made it much easier to discuss [14:40:00] and reference [14:42:18] awesome, +1 to the step [14:43:49] (03PS27) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [14:49:32] (03CR) 10Damilare Adedoyin: [C:03+2] Delete RunnableJob abstract class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1048570 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:12:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Email: Civi to Acoustic Export: Job "MASTER SUPPRESSION LIST" failing. - https://phabricator.wikimedia.org/T369457#9970224 (10Damilare) p:05Unbreak!→03Triage [16:29:05] 10fundraising-tech-ops, 10DNS, 06serviceops, 06SRE, and 2 others: redirect benefactors.wikimedia.org (was: Cleanup unused DNS subdomains) - https://phabricator.wikimedia.org/T367012#9970327 (10Dzahn) Thanks Clément! I was about to make a subtask and rename this again but you already took it on. It's apprec... [16:47:49] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9970475 (10KHaggard) Got it, thank you @Eileenmcnaughton For that payment method one, I wonder if we can group the methods generally? Maybe Eve... [16:50:16] (03CR) 10Ejegg: Add donor creation request (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [16:57:57] (03PS4) 10Eileen: Remove some good ideas [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051482 (https://phabricator.wikimedia.org/T365415) [16:57:59] (03CR) 10Ejegg: [C:03+2] Remove some good ideas [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051482 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [16:58:44] (03PS28) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [17:00:34] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the CR, made the recommended change." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (owner: 10Damilare Adedoyin) [17:00:42] (03PS23) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [17:19:46] (03Merged) 10jenkins-bot: Remove some good ideas [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051482 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [18:03:08] (03CR) 10Jgleeson: [C:03+2] "Thanks for the update. Working great for me once I got the gr4vy/gr4vy-php libary running through that setup hack. We should keep that in " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) (owner: 10Damilare Adedoyin) [18:10:19] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9970799 (10KHaggard) Actually @Eileenmcnaughton I just noticed that some fields are missing from the civi file I mapped with. It was missing th... [18:24:31] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 07payments-orchestration: Add Gravy UML Diagrams - https://phabricator.wikimedia.org/T369105#9970835 (10jgleeson) [18:57:21] 06Fundraising-Backlog, 10FR-donorservices: Donation charged after cancellation and missed by the autocancelation - https://phabricator.wikimedia.org/T369748 (10SHust) 03NEW [19:08:03] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360#9970946 (10Tsevener) Update from previous comment: Ideally we would also like to... [21:07:24] 06Fundraising-Backlog, 10FR-donorservices: Donation charged after cancellation and missed by the autocancelation - https://phabricator.wikimedia.org/T369748#9971401 (10Ejegg) Hi @SHust , sorry, that was a recurring contribution I had set as cancelled with a batch update. The cancellation activity is missing b... [21:32:25] (03PS2) 10Eileen: WIP Add AutoRescue Cancel test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052843 [21:46:51] 06Fundraising-Backlog, 10FR-Email: Export last payment method to Acoustic - https://phabricator.wikimedia.org/T369765 (10Eileenmcnaughton) 03NEW [21:48:15] 06Fundraising-Backlog, 10FR-Email: Export `both_funds_latest_donation_source` to Acoustic - https://phabricator.wikimedia.org/T369766 (10Eileenmcnaughton) 03NEW [21:49:25] 06Fundraising-Backlog, 10FR-Email: Export both_funds_has_given_on_email to Acoustic - https://phabricator.wikimedia.org/T369767 (10Eileenmcnaughton) 03NEW [21:52:33] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971558 (10Eileenmcnaughton) a:03Eileenmcnaughton @KHaggard I have created new sub-phabs for the 3 fields that we have not yet figured out ho... [21:52:46] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971560 (10Eileenmcnaughton) [21:54:09] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9971564 (10Eileenmcnaughton) Elliott deployed the latest fix yesterday so this should be sorted [21:55:13] ugh, can't seem to launch civi container again [21:55:15] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9971565 (10Eileenmcnaughton) @JMando this should be there now - I did a re-fetch from Acoustic going back a year or more [21:55:36] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971566 (10KHaggard) Thanks @Eileenmcnaughton - I have the jobs deactivated in Acoustic so that I can manually run the big file if we're still... [21:55:39] thought i got past my docker woes yesterday with that open files limit [21:56:14] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9971568 (10Eileenmcnaughton) a:03Eileenmcnaughton [21:56:20] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9971569 (10Eileenmcnaughton) [21:57:31] (03PS5) 10Eileen: Stop setting names to anonymouse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037205 (https://phabricator.wikimedia.org/T366231) [21:57:45] ok, huh, limit is still 1 billion plus inside the civi container [21:57:58] 1 billion open files? [21:58:25] ahhhh it's not using the common-settings [21:58:35] cstone yeah, kind of ridiculous limit [21:58:53] not sure why debian decided to override the containerd defaults to basically infinite [21:59:00] supposedly for performance reasons [21:59:08] but it breaks rsyslog in containers [22:00:00] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971577 (10Eileenmcnaughton) @KHaggard ah - the big file cos we don't have all the highest native amounts & grandparents pushed up - yeah OK I... [22:02:21] ejegg: did we come up with a parameterised way to regenerate the whole DB for silverpop export? I feel like we finally did [22:03:53] let me see, i think so [22:04:33] oh - we don't need to calculate any fields - just re-do the view as it's all in the view [22:05:02] config.offset_in_days or with a --days command-line parameter [22:05:23] ok - I think I can skip it though & just regenerate the final view [22:05:28] temporarily [22:05:40] cos the new fields are coming from already-calculated-stuff [22:05:55] ok [22:08:16] (03PS1) 10Ejegg: More fixes for rsyslogd breaking in containers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053389 [22:12:31] ugh, i mistyped 'y' to reclone donutwiki [22:12:39] nuu [22:12:41] there goes 5 min or more [22:19:21] eesh, mobilefrontend repo is huge [22:21:18] (03CR) 10Cstone: [C:03+2] "sorry for the super delayed actual +2!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037205 (https://phabricator.wikimedia.org/T366231) (owner: 10Eileen) [22:21:43] cstone: thanks [22:22:11] also - just looking at https://phabricator.wikimedia.org/T270675 - we should probably make some progress on it before gravy implements another one to migrate :-) [22:22:43] did we finish moving all the variables over or do I still have a wip somewhere [22:23:05] i think there are still a few drupal vars [22:24:36] it looks like we migrated adyen, braintree but not Amazon, FundraiseUp [22:25:18] & not the setting wmf_audit_log_archive_dir [22:38:09] (03PS1) 10Eileen: Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) [22:40:41] (03PS2) 10Eileen: Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) [22:44:26] (03PS1) 10Eileen: Remove functional function duplication [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053393 (https://phabricator.wikimedia.org/T270675) [22:44:31] (03Merged) 10jenkins-bot: Stop setting names to anonymouse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1037205 (https://phabricator.wikimedia.org/T366231) (owner: 10Eileen) [22:47:29] (03PS4) 10Eileen: Civi-stock 5.76-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052815 (https://phabricator.wikimedia.org/T368999) [22:47:33] (03CR) 10Ejegg: [C:03+2] Civi-stock 5.76-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052815 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [22:48:02] eileen: do you want to take this out of WIP? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1052823/1 [22:48:11] or should I rebase the others around it? [22:51:25] (03PS2) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [22:54:45] (03CR) 10CI reject: [V:04-1] Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:55:18] cstone would you mind reviewing this one? It's similar to the previous patch, just applying the limits to more containers: https://gerrit.wikimedia.org/r/1053389 [22:58:09] (03PS3) 10Eileen: Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) [22:58:09] (03PS2) 10Eileen: Remove functional function duplication [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053393 (https://phabricator.wikimedia.org/T270675) [22:59:04] (03CR) 10CI reject: [V:04-1] Remove functional function duplication [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053393 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:02:53] ejegg: that query one should not be in the current chain [23:03:03] oh ok [23:03:40] (03PS2) 10Eileen: Port upgrade fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053091 (https://phabricator.wikimedia.org/T368999) [23:03:41] it does work but not quite as well as I'd hoped so I'm gonna play a little longer - also it's not merged upstream yet [23:03:45] (03CR) 10Ejegg: [C:03+2] Port upgrade fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053091 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [23:03:54] (03PS3) 10Eileen: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053053 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [23:04:00] (03CR) 10Ejegg: [C:03+2] Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053053 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [23:05:56] eileen: so in your hook fix, when you delete the Hook::post calls from the add function, how does that post hook get called? [23:06:07] Ah it's in writeRecord [23:06:11] yep [23:06:11] nvm [23:06:30] I could have just re-orded in `add` - but that wouldn't be standardising [23:06:46] I mean it would - in that the order would be more standard but you know what I mean [23:10:43] (03Merged) 10jenkins-bot: Civi-stock 5.76-beta [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052815 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [23:11:22] (03PS2) 10Eileen: Port hook fix on recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053092 (https://phabricator.wikimedia.org/T367451) [23:11:29] (03CR) 10Ejegg: [C:03+2] Port hook fix on recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053092 (https://phabricator.wikimedia.org/T367451) (owner: 10Eileen) [23:12:23] (03CR) 10CI reject: [V:04-1] Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:13:03] (03CR) 10CI reject: [V:04-1] Remove functional function duplication [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053393 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:24:39] 06Fundraising-Backlog, 10fundraising-tech-ops: Remove references to worldline / ingenico / globalcollect from puppet - https://phabricator.wikimedia.org/T368114#9971768 (10Dwisehaupt) 05Open→03Resolved All the globalcollect/ingenico/worldline bits have been removed from puppet. Closing. [23:25:45] (03PS4) 10Eileen: Finish moving the directory settings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053391 (https://phabricator.wikimedia.org/T270675) [23:26:39] (03Merged) 10jenkins-bot: Port upgrade fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053091 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [23:27:00] (03PS3) 10Eileen: Remove functional function duplication [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053393 (https://phabricator.wikimedia.org/T270675) [23:28:22] (03Merged) 10jenkins-bot: Restore custom data for email on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053053 (https://phabricator.wikimedia.org/T364913) (owner: 10Ejegg) [23:34:15] (03Merged) 10jenkins-bot: Port hook fix on recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053092 (https://phabricator.wikimedia.org/T367451) (owner: 10Eileen) [23:36:06] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053396 [23:36:23] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053396 (owner: 10Eileen) [23:37:03] just flagging that I've merged the CiviCRM point version upgrade to master in prep for the deploy in 2.5 hours so don't deploy anything else before then.... [23:37:10] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053396 (owner: 10Eileen) [23:42:21] 10fundraising-tech-ops, 10DNS, 06serviceops, 06SRE, 06Traffic: redirect benefactors.wikimedia.org (was: Cleanup unused DNS subdomains) - https://phabricator.wikimedia.org/T367012#9971801 (10Dzahn) [23:46:03] 10fundraising-tech-ops, 10DNS, 06serviceops, 06SRE, 06Traffic: redirect benefactors.wikimedia.org (was: Cleanup unused DNS subdomains) - https://phabricator.wikimedia.org/T367012#9971806 (10Dzahn) Thanks to Clement and Reuven for the redirect change and deploying it. benefactors redirects now. @Pppery... [23:49:12] 10fundraising-tech-ops, 10DNS, 06serviceops, 06SRE, 06Traffic: Cleanup DNS subdomains displaying wikimedia.org homepage when they shouldn't - https://phabricator.wikimedia.org/T367012#9971809 (10Pppery) 05Open→03Resolved [23:55:40] OK so this finishes the settings we started moving https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1053391 [23:57:26] but there is still a question on audit xx_log_search_past_days xx_test_mode settings along with wmf_audit_log_archive_dir - presumably we didn't include the latter in our first round because it is not per-processor & the first 2 cos we maybe hadn't decided what to do?