[00:03:19] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971819 (10Eileenmcnaughton) @KHaggard ok - new file pushed up 30,800,433 rows [00:04:44] cstone: so https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1053391 finishes the part we started on audit settings - but per above there are a few settings left after that [00:09:32] 06Fundraising-Backlog: Epic: Support retrieval of page and banner view data for FR Analytics - https://phabricator.wikimedia.org/T369773 (10AKanji-WMF) 03NEW [00:10:45] 06Fundraising-Backlog: Epic: Support retrieval of page and banner view data for FR Analytics - https://phabricator.wikimedia.org/T369773#9971834 (10AKanji-WMF) [00:10:47] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Donate Wiki Support Page Pageviews - https://phabricator.wikimedia.org/T367460#9971835 (10AKanji-WMF) [00:10:48] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Querying druid.pageviews_daily and druid.pageviews_hourly in FR-Analytics Superset - https://phabricator.wikimedia.org/T367458#9971836 (10AKanji-WMF) [00:10:50] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Data-Engineering-Icebox: Bring Banner History data into Fundraising infrastructure - https://phabricator.wikimedia.org/T253050#9971837 (10AKanji-WMF) [00:10:50] 06Fundraising-Backlog, 10fundraising-tech-ops: Investigate pulling in page view data to the fr-tech version of superset - https://phabricator.wikimedia.org/T252049#9971838 (10AKanji-WMF) [00:11:28] 06Fundraising-Backlog: Epic: Support retrieval of page and banner view data for FR Analytics - https://phabricator.wikimedia.org/T369773#9971839 (10AKanji-WMF) a:03Dwisehaupt [00:15:35] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971841 (10KHaggard) @Eileenmcnaughton thanks! Is it on the FTP now? I just attempted to run the Acoustic jobs and they're saying there's no fi... [00:21:46] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971858 (10Eileenmcnaughton) I thought it was but now I'm questioning myself - just pushing up (again?) now [00:42:10] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Switch Acoustic mapping to use the API to define the columns - https://phabricator.wikimedia.org/T368470#9971872 (10Eileenmcnaughton) We discussed this just now - since we didn't use this method to add the fields this time... [00:42:14] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Switch Acoustic mapping to use the API to define the columns - https://phabricator.wikimedia.org/T368470#9971873 (10Eileenmcnaughton) [00:43:00] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9971874 (10Eileenmcnaughton) OK - try again now [00:53:11] 06Fundraising-Backlog: Native (inapp) donations are switching country and donor_country - https://phabricator.wikimedia.org/T369775 (10Cstone) 03NEW [01:39:59] (03PS1) 10Cstone: WIP: Switch donor_country and country for submitpayment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053406 (https://phabricator.wikimedia.org/T369775) [01:48:13] (03PS1) 10Cstone: Add Euro countries back for sepa [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053407 (https://phabricator.wikimedia.org/T368570) [01:52:01] I'm gonna stop process control now in prep for the upgrade in 9 mins [01:54:05] !log config revision changed from 840e6b90 to e02c3a85 [01:54:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:59:16] thanks eileen. got absorbed in the columbia/uruguay match [02:02:11] no worries - jobs should be stopped so let me know when I should push out the code [02:03:44] the recurring_smashpig_charge job is still rolling. but you can probably push the code while it finishes [02:04:28] I can't recall what that one touches [02:05:22] i'll see how long usually takes to finish. [02:06:22] hmmm... [02:06:31] it's capped at 27 minutes [02:06:35] we should probably kill the job. it'll run for another 15 mins. [02:07:21] looks like it kicks off with extended runs starting the new day UTC [02:07:21] hi folks! [02:07:29] hey ejegg [02:07:38] or we could wait. which ever. [02:07:39] so is it worse to kill it or push out while it runs [02:08:01] only downside to waiting is it taking longer for us to do the work. [02:08:02] Hmm, I think it should have all the classes loaded [02:08:14] ok- so should be OK to push out while it runs [02:08:19] since it's one long process [02:08:24] that doesn't kick off others [02:08:52] !log civicrm upgraded from a03085ff to 1e2fcba3 [02:08:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:09:25] Colombia just beat Uruguay to make it to the Copa America finals. Much more action packed than the England-Netherlands game earlier today :) [02:10:06] argh - there is an error in my updates to the mailing job script - guess they got skipped when I re-tested [02:10:06] ejegg: yeah, it was definitely a good day for football/soccer. sunday should hopefully be good too. [02:10:27] lemme tail the log for that charge job just in case [02:10:38] oh shoot eileen i just eyeballed that one :( [02:12:16] (03PS1) 10Eileen: Fix missing table reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053409 [02:12:56] (03CR) 10Ejegg: [C:03+2] Fix missing table reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053409 (owner: 10Eileen) [02:13:16] thanks [02:13:39] I'm gonna force it through quicker [02:13:51] (03CR) 10Eileen: [V:03+2] Fix missing table reference [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053409 (owner: 10Eileen) [02:14:46] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053410 [02:14:55] (03CR) 10Eileen: [V:03+2 C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053410 (owner: 10Eileen) [02:16:41] * greg-g waves [02:17:09] PROBLEM - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [02:17:34] it finished that time [02:17:41] that's me preemptively stopping replication. i'll ack in icinga. [02:18:03] ACKNOWLEDGEMENT - check_mysql on frdb2001 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt maint work. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [02:18:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [02:18:22] ok, recurring charge job just finished with no problems too [02:18:35] ACKNOWLEDGEMENT - check_mysql on frdb1004 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) Dwisehaupt maint work. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [02:20:16] (03PS1) 10Eileen: Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053411 (https://phabricator.wikimedia.org/T368999) [02:20:45] running that one locally... [02:20:49] trigger update is ^^ [02:20:58] looking. [02:21:07] I thought we might have dropped civicrm_participant.cart_id too but don't seem to have [02:23:49] I'm tempted to drop it manually just to be rid of it [02:23:55] looks good to me from a 'will upload and able to track' stance. [02:28:19] (03PS1) 10Eileen: Manually remove event cart triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053413 (https://phabricator.wikimedia.org/T368999) [02:28:37] it looks like the cart tables didn't drop - I just hacked em out in a follow up - then we can drop the tables [02:29:22] that looks good too. [02:29:49] (my reviews being solely on looking well formed from an import standpoint) [02:32:03] seems OK - I'm gonna push up one more - just to hack out cart_id - then we can clean up those tables [02:32:59] (03PS1) 10Eileen: Manually hack out cart_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053415 (https://phabricator.wikimedia.org/T368999) [02:33:19] dwisehaupt: if that one seems well formed too can you +2 them all [02:37:30] (03CR) 10Dwisehaupt: [C:03+2] Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053411 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:37:33] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Trigger update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053411 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:37:55] (03CR) 10Dwisehaupt: [C:03+2] Manually remove event cart triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053413 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:37:57] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Manually remove event cart triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053413 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:38:06] (03CR) 10Dwisehaupt: [C:03+2] Manually hack out cart_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053415 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:38:08] (03CR) 10Dwisehaupt: [V:03+2 C:03+2] Manually hack out cart_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053415 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:38:23] (03PS1) 10Eileen: Try again to remove event_cart tables, now triggers are gone [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053416 (https://phabricator.wikimedia.org/T368999) [02:38:43] ejegg: if you are still about can you +2 that last one & I'll see if I can kill those tables [02:38:50] sure, let me take a look [02:38:56] ok. i think i them in the right order. [02:39:01] did them even. [02:39:37] dwisehaupt: all good :-) [02:40:51] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053417 [02:41:02] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053417 (owner: 10Eileen) [02:43:40] hmm - I think we disabled logging on civicrm_mailing - which might have made sense when we were not using civimail - will log a phab [02:43:50] ok eileen - that one does fail on dev [02:44:04] ejegg: that upgrade script? [02:44:19] yeah, no table civicrm_events_in_carts [02:44:45] oh maybe because I did a very recent rebuild ? [02:45:35] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: re-add triggers on civicrm_mailing - https://phabricator.wikimedia.org/T369782 (10Eileenmcnaughton) 03NEW [02:46:38] (03PS1) 10Eileen: Stop stopping logging on civicrm_mailing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053418 (https://phabricator.wikimedia.org/T369782) [02:46:58] ejegg: yeah that makes sense [02:48:11] !log civicrm upgraded from a17496a2 to 2d1a0aad [02:48:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:48:20] dwisehaupt: that new trigger script is pushed out [02:48:33] thanks. i'll do the sync. [02:49:35] we could possibly merge this & do the trigger dance - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1053418 - but that is long-standing & I think it's probably better to resolve the event cart stuff first & have that follow at 'any point in time' [02:50:18] eileen: I'll C+2 that upgrade script for now and maybe we can put a short circuit in later if other folks get a fail too [02:50:25] ejegg: sounds good [02:50:26] (03CR) 10Ejegg: [C:03+2] Try again to remove event_cart tables, now triggers are gone [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053416 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [02:51:12] trigger diff looks good. feel free to check anything you need. [02:56:55] I think we are good - we can re=enable jobs I think [02:58:04] turning em on [02:58:11] cool. i'll restart replication. [02:58:46] !log config revision changed from e02c3a85 to 540f27e6 [02:58:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:02:09] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 3048567 Threads: 4 Questions: 105838406 Slow queries: 1373 Opens: 5624 Open tables: 941 Queries per second avg: 34.717 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [03:02:49] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out why we have civicrm_mailing_job records with a status of running - https://phabricator.wikimedia.org/T369783 (10Eileenmcnaughton) 03NEW [03:03:15] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 2271948 Threads: 4 Questions: 64877363 Slow queries: 1029 Opens: 5477 Open tables: 929 Queries per second avg: 28.555 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [03:04:55] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053419 [03:05:07] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053419 (owner: 10Eileen) [03:08:38] !log civicrm upgraded from 2d1a0aad to 04cb9083 [03:08:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:15:48] (03PS2) 10Eileen: Decommission wmf_civicrm_get_default_location_type_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051492 (https://phabricator.wikimedia.org/T365415) [03:15:51] (03CR) 10Ejegg: [C:03+2] Decommission wmf_civicrm_get_default_location_type_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051492 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [03:17:07] (03PS1) 10Eileen: Further tweaks on cart destruction [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053420 (https://phabricator.wikimedia.org/T368999) [03:17:15] ejegg: not quite - lets try ^^ [03:18:03] (03CR) 10Ejegg: [V:03+2 C:03+2] Further tweaks on cart destruction [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053420 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [03:18:14] instamerged :) [03:18:49] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053421 [03:19:00] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1053421 (owner: 10Eileen) [03:19:06] thanks! [03:20:25] !log civicrm upgraded from 04cb9083 to 3287ced0 [03:20:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:26:20] (03PS1) 10Eileen: Regenerate triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053422 (https://phabricator.wikimedia.org/T368999) [03:27:03] ejegg: the tables / field dropped & the trigger regen ^^ looks like it is all well sorted [03:27:10] great! [03:27:30] anything else to do tonight / this afternoon ? [03:27:51] ejegg: nah - maybe +2 that last one so it's all merged [03:28:08] (03CR) 10Ejegg: [C:03+2] Regenerate triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1053422 (https://phabricator.wikimedia.org/T368999) (owner: 10Eileen) [03:30:36] k, gonna head to bed. see ya! [03:40:50] (03CR) 10Ejegg: [C:03+2] Add Euro countries back for sepa [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053407 (https://phabricator.wikimedia.org/T368570) (owner: 10Cstone) [03:42:34] (03Merged) 10jenkins-bot: Add Euro countries back for sepa [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053407 (https://phabricator.wikimedia.org/T368570) (owner: 10Cstone) [03:56:21] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: CiviCRM point version upgrade (from Wed 3 July) - https://phabricator.wikimedia.org/T368999#9972108 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [03:56:30] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: CiviCRM point version upgrade (from Wed 3 July) - https://phabricator.wikimedia.org/T368999#9972110 (10Eileenmcnaughton) [04:34:52] (03Merged) 10jenkins-bot: Decommission wmf_civicrm_get_default_location_type_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051492 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [04:36:43] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Email: New columns to add to Civi DatabaseUpdate export in July - https://phabricator.wikimedia.org/T366529#9972127 (10KHaggard) Thanks @Eileenmcnaughton ! Awesome ok they're processing now, might take a bit. I'll update my tomorrow morning :) [07:33:31] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053562 (owner: 10L10n-bot) [08:02:55] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053562 (owner: 10L10n-bot) [13:08:36] (03PS2) 10Jgleeson: Minor casing fix to Gravy API param. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047179 (https://phabricator.wikimedia.org/T367112) [13:10:40] (03Abandoned) 10Jgleeson: Minor casing fix to Gravy API param. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047179 (https://phabricator.wikimedia.org/T367112) (owner: 10Jgleeson) [13:14:12] (03PS1) 10Jgleeson: Minor casing fix to Gravy API param. (take 2) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053688 (https://phabricator.wikimedia.org/T367112) [14:28:06] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 13Patch-For-Review, 10Wikipedia-iOS-App-Backlog (iOS Release FY2023-24): Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360#9973673 (10Tsevener) Update: Per @Cstone **banner** parameter can accept whatever... [14:45:46] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic - request to store click data in mailing stats - https://phabricator.wikimedia.org/T344383#9973798 (10JMando) Awesome! I see them now! I added it to the teams dashboard and asked that they QA it. Will comment here... [14:47:04] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1053704 [14:47:14] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1053704 (owner: 10Ejegg) [15:25:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1053704 (owner: 10Ejegg) [16:13:24] !log payments-wiki upgraded from 4e48059a to c8edeb8e [16:13:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:58:27] (03CR) 10Damilare Adedoyin: "LGTM thanks for pushing this up." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053688 (https://phabricator.wikimedia.org/T367112) (owner: 10Jgleeson) [17:01:09] (03CR) 10Damilare Adedoyin: [C:03+2] Minor casing fix to Gravy API param. (take 2) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053688 (https://phabricator.wikimedia.org/T367112) (owner: 10Jgleeson) [17:01:38] (03Merged) 10jenkins-bot: Minor casing fix to Gravy API param. (take 2) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053688 (https://phabricator.wikimedia.org/T367112) (owner: 10Jgleeson) [17:01:51] dwisehaupt: I like the fact that because you had a shirt and jumper on, you felt the need to tell us why you were dressed so smart/casual on a video call ha [17:02:12] damilare: ^ [17:02:34] I guess that's a good indication of how casual we are in general :) [17:02:55] thanks for the review! [17:03:23] ahh, yep definitely felt odd [17:03:29] lol [17:03:34] ejegg: wanna pull the gravy tickets your reviewing into being reviewed so i can pick the bones on the others? [17:04:17] i broke my trend this last offsite. i usually wear button up shirts every day since i never get to wear them otherwise. went with wacky t-shirt designs instead. [17:04:34] ah nice dwisehaupt. makes sense [17:04:53] although the latest shirt was the winner for me, once we got home and you explained what it was [17:06:50] (03PS29) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 [17:09:57] ok jgleeson, so far I'm just reviewing the backend ones [17:10:27] (03PS24) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [17:11:01] ejegg: https://phabricator.wikimedia.org/T367112 and https://phabricator.wikimedia.org/T364506 ? [17:14:27] (03PS25) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [17:16:10] rebase done [17:17:34] thanks damilare [17:31:18] jgleeson: ah i see the createPayment one is pending deploy now. I'll move on to the approve payment [17:32:30] cool [17:32:47] oh wait, the createBuyer patch is still in review. That's the one I'll start with [17:32:57] so I'll just move that ticket back to in review [17:33:09] and move the approvepayment one back to 'ready for review' [17:34:14] all the patches on this ticket got merged i think. is there one not tagged? https://phabricator.wikimedia.org/T364506 [17:34:27] damilare: ^ [17:35:14] I thought we had another ticket somewhere for creating the buyer/contact [17:36:22] no same ticket [17:36:23] ah this one I see https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1041627 [17:36:28] it's not tagged to the ticket [17:36:48] (no bug ID in the cmt) [17:36:52] ohh I'd add that [17:37:18] (03PS30) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) [17:37:24] ty! [17:38:48] fr-tech does anyone else keep getting spam from airtable to their work accounts? [17:45:37] jgleeson: yeah, it was noted on slack at some point recently. possible related to some back end auth work that was done that triggered something on the airtable side. [17:50:00] (03PS2) 10Ejegg: WIP edit email custom data inline [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1039782 (https://phabricator.wikimedia.org/T366356) [18:02:43] oh right. thanks dwisehaupt [18:24:57] yep same here jgleeson [18:51:14] (03CR) 10Ejegg: "Looking pretty good. Just need to import logger in one class." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [18:55:50] (03PS1) 10Ejegg: Make base provider abstract, remove stubs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053764 [18:59:48] ty ejegg [18:59:57] damilare: check out step 10 https://phabricator.wikimedia.org/F56360505 [19:00:07] does that capture what you mentioned yesterday [19:01:22] yep thats it jgleeson [19:01:28] awesome [19:02:58] turns out that it's a good way to learn how something works, by trying to draw how it works as you learn how it works [19:11:20] (03PS31) 10Damilare Adedoyin: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) [19:12:21] (03PS26) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [19:12:52] (03PS2) 10Ejegg: Make base provider abstract, remove stubs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053764 [19:13:33] (03CR) 10Damilare Adedoyin: [C:03+2] Make base provider abstract, remove stubs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053764 (owner: 10Ejegg) [19:14:27] (03CR) 10Damilare Adedoyin: "Thanks for the CR ejegg" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [19:15:47] 06Fundraising-Backlog, 10FR-donorservices: Donation charged after cancellation and missed by the autocancelation - https://phabricator.wikimedia.org/T369748#9974885 (10SHust) @Ejegg, thanks for looking into this! I can confirm that it is beneficial for DR to have Civi automatically cancel recurring donations a... [19:38:01] (03PS1) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [19:38:33] (03CR) 10CI reject: [V:04-1] Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 (owner: 10Ejegg) [19:39:53] (03PS2) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [19:46:21] (03CR) 10Ejegg: [C:03+2] Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [19:50:39] (03Merged) 10jenkins-bot: Add donor creation request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1041627 (https://phabricator.wikimedia.org/T364506) (owner: 10Damilare Adedoyin) [19:50:40] (03Merged) 10jenkins-bot: Make base provider abstract, remove stubs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053764 (owner: 10Ejegg) [19:57:02] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test out, maybe implement new scheduled communication functionality - https://phabricator.wikimedia.org/T369109#9974985 (10Ejegg) We tested this a bit in tech talk yesterday and Eileen posted some feedback upstream: https:/... [20:00:09] (03PS2) 10Eileen: Remove obsolete call to legacy function from test set up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051495 (https://phabricator.wikimedia.org/T365415) [20:00:13] (03CR) 10Ejegg: [C:03+2] Remove obsolete call to legacy function from test set up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051495 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:01:03] (03PS2) 10Eileen: Move wmf_civicrm_get_direct_mail_field_option_id to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051496 (https://phabricator.wikimedia.org/T365415) [20:01:06] (03CR) 10Ejegg: [C:03+2] Move wmf_civicrm_get_direct_mail_field_option_id to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051496 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:01:31] (03PS2) 10Eileen: Fold function into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051497 (https://phabricator.wikimedia.org/T365415) [20:01:33] (03CR) 10Ejegg: [C:03+2] Fold function into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051497 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:12:13] (03PS27) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [20:13:48] (03CR) 10Ejegg: [C:04-1] "Looks pretty good, I think the amount just needs to be converted" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [20:16:33] (03CR) 10Ejegg: [V:03+2 C:03+2] More fixes for rsyslogd breaking in containers [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053389 (owner: 10Ejegg) [20:24:19] hey - did anyone re-enable silverpop - looks like we can now [20:25:58] (03Merged) 10jenkins-bot: Remove obsolete call to legacy function from test set up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051495 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:26:00] (03Merged) 10jenkins-bot: Move wmf_civicrm_get_direct_mail_field_option_id to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051496 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:26:01] (03Merged) 10jenkins-bot: Fold function into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051497 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:26:28] !log config revision changed from 540f27e6 to c25da839 renable silverpop_daily [20:26:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:35:58] (03PS4) 10Eileen: Split & move update email function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051472 (https://phabricator.wikimedia.org/T365415) [20:36:01] (03CR) 10Ejegg: [C:03+2] Split & move update email function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051472 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:41:55] (03PS3) 10Eileen: Fix function to use apiv4, removes one old function call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051477 (https://phabricator.wikimedia.org/T365415) [20:41:57] (03CR) 10Ejegg: [C:03+2] Fix function to use apiv4, removes one old function call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051477 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:49:49] (03PS28) 10Damilare Adedoyin: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) [20:53:34] 03Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#9975172 (10Cstone) @AMJohnson these changes have been made and are live now 1. The field is now requi... [20:55:43] (03CR) 10Damilare Adedoyin: "Thanks ejegg, good catch. Fixed!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [20:56:39] (03CR) 10Ejegg: [C:03+2] Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [20:57:34] thanks ejegg [20:59:39] (03Merged) 10jenkins-bot: Split & move update email function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051472 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [21:05:34] (03Merged) 10jenkins-bot: Fix function to use apiv4, removes one old function call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051477 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [21:05:34] (03Merged) 10jenkins-bot: Gravy approve payment request, mapping, and response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1043745 (https://phabricator.wikimedia.org/T367112) (owner: 10Damilare Adedoyin) [21:06:18] 06Fundraising-Backlog: Scoping: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#9975201 (10AKanji-WMF) Surfacing some questions/thoughts from Slack from @cstone * For instant payments - we would want to check that they didn't make a recurring between the first email and the seco... [21:08:40] (03PS3) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [21:09:00] (03CR) 10CI reject: [V:04-1] Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 (owner: 10Ejegg) [21:13:43] (03PS1) 10Ejegg: Rename validator methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 [21:14:01] oops, need to fix that v-1 first [21:14:05] (03CR) 10CI reject: [V:04-1] Rename validator methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 (owner: 10Ejegg) [21:20:39] (03PS2) 10Ejegg: Rename validator methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 [21:20:40] (03PS4) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [21:21:07] (03CR) 10CI reject: [V:04-1] Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 (owner: 10Ejegg) [21:22:37] (03PS5) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [21:32:05] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.8.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053792 [21:42:31] (03PS6) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [21:50:20] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.8.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053792 (owner: 10Damilare Adedoyin) [21:52:10] (03Merged) 10jenkins-bot: Update smashpig to v0.8.11 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1053792 (owner: 10Damilare Adedoyin) [21:52:24] (03PS26) 10Damilare Adedoyin: Create gravy special page and load components [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040198 (https://phabricator.wikimedia.org/T364508) [23:20:03] (03open) 10dwisehaupt: Upgrade civi to 5.75.0 - bookworm [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/9 [23:21:52] (03close) 10dwisehaupt: Upgrade civi to 5.75.0 - bookworm [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/9 [23:34:20] (03open) 10dwisehaupt: Upgrade civi to 5.75.0 - bookworm [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/10