[00:08:16] (03PS1) 10Eileen: Phpunit printer option 1 CodeDudgeon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054958 [00:09:45] (03PS2) 10Eileen: Phpunit printer option 1 CodeDudgeon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054958 [00:09:45] (03PS1) 10Eileen: Phpunit printer option 2 Tap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054959 [00:15:47] (03PS1) 10Eileen: Phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054962 [00:21:21] (03PS1) 10Eileen: Phpunit printer option 4 DiabloMedia [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054963 [00:29:09] (03PS1) 10Eileen: Phpunit printer option Sempro [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054965 [01:49:56] oh shoot, thanks eileen and cstone - I'll let DR know... [02:27:00] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review, 07Unplanned-Sprint-Work: Remove Bitpay import, possibly stripe - https://phabricator.wikimedia.org/T364784#9993330 (10AKanji-WMF) [04:39:12] (03PS1) 10Eileen: Remove very-slow System.flush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054970 (https://phabricator.wikimedia.org/T370371) [05:04:01] (03PS1) 10Eileen: Experimental addition of test listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [05:10:33] (03PS3) 10Eileen: Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) [05:24:01] (03CR) 10CI reject: [V:04-1] Experimental addition of test listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [05:26:01] (03CR) 10CI reject: [V:04-1] Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [06:19:12] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1054999 (owner: 10L10n-bot) [13:51:34] (03CR) 10Jgleeson: "We already had a patch for this one here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1053916 but I'll abandon it as this " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053070 (owner: 10Ejegg) [13:52:46] (03PS3) 10Jgleeson: Add Gravy credit card test URLs [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053916 [13:52:46] (03PS1) 10Jgleeson: Update scripts/civicrm-drush.sh to take arguments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1055227 [13:54:02] (03PS2) 10Jgleeson: make payments-smashpig-restore.sh only update vendor. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053273 [13:54:30] (03Abandoned) 10Jgleeson: Add Gravy credit card test URLs [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053916 (owner: 10Jgleeson) [13:57:40] (03PS1) 10Jgleeson: Add Gravy to payment processors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055229 [13:59:24] (03PS2) 10Jgleeson: Update scripts/civicrm-drush.sh to take arguments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1055227 [13:59:36] (03PS3) 10Jgleeson: Update scripts/civicrm-drush.sh to take arguments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1055227 [13:59:42] (03PS3) 10Jgleeson: make payments-smashpig-restore.sh only update vendor. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053273 [14:14:33] (03PS1) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [14:14:54] (03CR) 10CI reject: [V:04-1] Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [14:51:12] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#9995059 (10AMJohnson) Sorry late to this thread. Not sure if this is helpful but we provide a link to the endowment donation form on the Japanese way... [14:55:31] (03PS1) 10Damilare Adedoyin: Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) [14:57:30] (03CR) 10CI reject: [V:04-1] Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [14:59:23] (03PS2) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [14:59:46] (03CR) 10CI reject: [V:04-1] Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [15:00:48] (03PS3) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [15:02:08] (03PS2) 10Damilare Adedoyin: Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) [15:29:20] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07Epic, 07payments-orchestration: Map Gr4vy AVS and CVV risk scores on Smashpig - https://phabricator.wikimedia.org/T369161#9995343 (10Damilare) a:03Damilare [15:31:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from... - https://phabricator.wikimedia.org/T366742#9995358 [15:36:02] (03PS3) 10Jforrester: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1052668 (https://phabricator.wikimedia.org/T287405) [15:39:16] (03CR) 10Lucas Werkmeister (WMDE): [C:03+1] "In addition to the bugs listed in the commit message, this is also expected to fix T366742. (+1ing since I’m not sure what the rules for +" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1052668 (https://phabricator.wikimedia.org/T287405) (owner: 10Jforrester) [16:02:45] jgleeson: anilk around for standup [16:02:47] ? [16:11:55] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install fransw200[1-3].frack.codfw.wmnet - https://phabricator.wikimedia.org/T367800#9995545 (10Jhancock.wm) a:03Jhancock.wm [16:12:05] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw: Q1:rack/setup/install frqueue2003, pay-lb2001, pay-lb2002 - https://phabricator.wikimedia.org/T369566#9995553 (10Jhancock.wm) [16:18:15] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [16:23:15] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [16:24:49] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 13Patch-For-Review: Figure out if we can make the queue delay graph better with audit import lag - https://phabricator.wikimedia.org/T342812#9995627 (10Ejegg) [16:27:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Donation charged after cancellation and missed by the autocancelation - https://phabricator.wikimedia.org/T369748#9995643 (10Ejegg) p:05Triage→03Medium [16:42:39] 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#9995702 (10AMJohnson) Just adding in a recent example we came across today. Donor in Zendesk ticket #1500890 / CID 3... [16:44:20] (03CR) 10Wfan: [C:03+2] "Similar to Bitpay, LGTM~" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054662 (https://phabricator.wikimedia.org/T364784) (owner: 10Eileen) [17:09:22] (03Merged) 10jenkins-bot: Remove Stripe import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054662 (https://phabricator.wikimedia.org/T364784) (owner: 10Eileen) [18:38:00] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install fransc2001 - https://phabricator.wikimedia.org/T367816#9996286 (10Papaul) ` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] - member ge-0/0/15; - member ge-1/0/15; [edit interfaces interface-ran... [19:05:03] 06Fundraising-Backlog, 10fundraising-tech-ops: Rename fundraise-up audit directory to fundraiseup - https://phabricator.wikimedia.org/T370307#9996419 (10Dwisehaupt) 05Open→03Resolved Confirmed with cstone that nothing more is needed for this portion. [19:10:50] 06Fundraising-Backlog: Building Fidelity import - issue with addressee column - https://phabricator.wikimedia.org/T370469 (10MDemosWMF) 03NEW [20:16:38] (03PS6) 10Wfan: Alter holder name to "Account Holder Name" for sepa form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1048895 (https://phabricator.wikimedia.org/T367906) [20:16:40] (03CR) 10Ejegg: [C:03+2] Alter holder name to "Account Holder Name" for sepa form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1048895 (https://phabricator.wikimedia.org/T367906) (owner: 10Wfan) [20:18:28] (03Merged) 10jenkins-bot: Alter holder name to "Account Holder Name" for sepa form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1048895 (https://phabricator.wikimedia.org/T367906) (owner: 10Wfan) [20:33:09] (03PS6) 10Wfan: ACH on PaymentsWiki - Form Changes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) [20:35:26] (03PS7) 10Wfan: ACH on PaymentsWiki - Form Changes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) [20:36:26] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review, 07Unplanned-Sprint-Work: Investigate test issue with tests running out of time - https://phabricator.wikimedia.org/T370371#9996826 (10AKanji-WMF) [20:47:32] (03PS2) 10Wfan: Do not pass billingAddress for ach [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1052790 (https://phabricator.wikimedia.org/T360825) [20:47:33] (03CR) 10Ejegg: [C:03+2] Do not pass billingAddress for ach [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1052790 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [20:48:01] (03Merged) 10jenkins-bot: Do not pass billingAddress for ach [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1052790 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [20:48:14] Thanks ejegg for the review:) [20:48:20] :) [20:50:03] (03PS3) 10Ejegg: Rename validator methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 [20:50:03] (03PS7) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [20:50:57] wfan: do you have a chance to look at those? ^^ [20:51:17] Sure [20:52:01] So the validators were originally written to return true when valid, and throw an exception when not valid. [20:52:17] then dami changed the logic to just rely on the exception and not the return value [20:52:39] so it makes more sense to remove the return value and change the names of the functions [20:52:49] (that's the more trivial patch) [20:53:23] oh I see, validators patch make sense to me [20:53:24] the other one, the inMinorUnits function, will be important for when we start using Gravy in anywhere with non-decimal currencies (e.g. JPY) [20:53:51] they want the minor units just like Adyen, so we should probably calculate that with shared logic [20:54:52] 06Fundraising-Backlog, 10fundraising-tech-ops, 07Epic, 07payments-orchestration: Network configuration for Gravy integration - https://phabricator.wikimedia.org/T370319#9996868 (10Dwisehaupt) IP addresses from gr4vy. API: * 34.36.3.1 * 34.149.116.58 Webhook server: * 34.83.124.27 [20:56:50] (03CR) 10Wfan: [C:03+2] "tested, and the updated name fit the logic, which looks good to me~" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 (owner: 10Ejegg) [20:57:05] (03CR) 10Jgleeson: Rename validator methods (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 (owner: 10Ejegg) [20:57:16] (03Merged) 10jenkins-bot: Rename validator methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053787 (owner: 10Ejegg) [20:57:28] ejegg: I just left some feedback on that patch [20:57:40] ah, validate sounds good too [20:57:55] I suggeted using validate just to tie it in with the class [20:58:00] yep yep, makes sense [20:58:06] ty [20:58:49] even checkFields could be switched and made private [20:58:52] ahh, I had just used 'check' to match the existing 'checkFields' function [20:58:59] right, could be private [20:59:14] 06Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Deduper Issue - https://phabricator.wikimedia.org/T363958#9996875 (10AKanji-WMF) @SHust reports this may have resurfaced, she'll report back w/o July 29 [20:59:18] or protected, since there could potentially be multiple validators in that namespace [20:59:56] yeah good point [21:00:46] wfan I'll put that other rename patch over the top of the inMinorUnits one, in case you're already looking at that [21:01:55] ok, but seems like gravy required us to send in cent for all currency, and the old adyen is checking for isFractionalCurrency, is gravy currency all falls into this category? [21:02:31] Gravy says to send in the smallest units for the currency [21:02:40] in many currencies that is 'cent' == 1/100 [21:02:49] but in JPY there is no smaller unit [21:03:06] so JPY should not get multiplied [21:03:20] oh nevermind, i see [21:05:17] could we add " Gravy requires amounts to be sent over in cents. @see https://docs.gr4vy.com/reference/transactions/new-transaction" to that shared logic [21:05:24] then it's easier to understand in the future [21:06:57] How about I put that comment in the Gravy-specific code where we call the RoundingHelper function? [21:07:19] hmm (RawData) New Checkout Session response "Could not resolve host: api.sandbox.wikimedia.gr4vy.app" [21:07:26] Suer, even better~ [21:07:51] ejegg: btw, this is the frontend patch to remove address from ach form https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1052824 [21:11:05] (03PS8) 10Ejegg: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 [21:12:25] (03CR) 10Wfan: [C:03+2] "Thanks for the update, looks good to use a shared function :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 (owner: 10Ejegg) [21:12:52] (03Merged) 10jenkins-bot: Generalize the inMinorUnits function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1053775 (owner: 10Ejegg) [21:13:35] (03PS1) 10Ejegg: Re-rename check* functions to validate [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055298 [21:17:50] jgleeson: ^^^ is for you [21:19:20] thank you! that's LGTM but I'll let wfan take a peek too [21:20:20] (03CR) 10Wfan: [C:03+2] "LGTM haha" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055298 (owner: 10Ejegg) [21:20:42] Thanks jgleeson for let me take another peek haha [21:20:46] (03Merged) 10jenkins-bot: Re-rename check* functions to validate [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055298 (owner: 10Ejegg) [21:21:00] fr-tech, is anyone with gravy set up able to load up the payments form? I'm getting timeouts/unresolvable errors hitting the API [21:21:13] np wfan ! [21:21:24] I've pinged them on Slack [21:21:34] although it might just be at my end [21:23:40] 06Fundraising-Backlog, 10fundraising-tech-ops, 07Epic, 07payments-orchestration: Network configuration for Gravy integration - https://phabricator.wikimedia.org/T370319#9996924 (10Dwisehaupt) Iptables rules updated and applied to civicrm, payments, and payments_listener role for the API addresses. The frde... [21:25:07] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install fransc2001 - https://phabricator.wikimedia.org/T367816#9996928 (10Papaul) [21:26:31] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install fransc2001 - https://phabricator.wikimedia.org/T367816#9996930 (10Papaul) a:05Papaul→03Dwisehaupt @Dwisehaupt switch port setup and DNS entries done. All yours [21:29:29] looks like this significantly speeds up the unit tests https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1054970 (it's in the middle of patches it can be rebased from but currently demos a different console output) [21:29:54] nice find eileen [21:30:19] (03CR) 10Jgleeson: [C:03+2] "need for speed!!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054970 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [21:30:32] (03PS2) 10Eileen: Remove very-slow System.flush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054970 (https://phabricator.wikimedia.org/T370371) [21:33:04] eileen: did you see we added a script a while back to reset the civicrm db to it's fresh-install state? [21:33:06] jack@debian:~/fundraising-dev$ ./scripts/db/restore-civicrm.sh [21:33:08] **** Restoring CiviCRM WMFF databases from backup [21:33:10] Restoring CiviCRM database... [21:33:12] Restoring Drupal database... [21:33:14] Restoring WMFF Test database... [21:33:16] *** CiviCRM WMFF databases restored. [21:33:18] it comes in handy after running all tests [21:33:25] cool - does it cool buildkit? [21:33:50] nice eileen [21:33:51] so it just restores the db dumps taken after a successful build [21:34:10] s/so/no/ [21:34:16] i'll try that gravy sandbox form jgleeson [21:34:43] did people look at the various console outputs - eg https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-bullseye/1633/console [21:35:28] or https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-bullseye/1631/console [21:36:12] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install fransc2001 - https://phabricator.wikimedia.org/T367816#9996966 (10Dwisehaupt) Thanks. [21:37:03] - both of those highlight the geocoder test slowness [21:37:23] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Civi x Acoustic Database QA Flags - https://phabricator.wikimedia.org/T369957#9996967 (10KHaggard) 05Open→03Resolved a:03KHaggard Everyone has wrapped up QA and everything looks great! Thank you :) Resolving this now [21:40:23] thanks for setting those up eileen! [21:41:13] I think there are 2 that I like - one is prettier but does progress within class. The other does progress against overall test total [21:41:17] I guess I like the 'tap' one that prints the actual test fn names [21:41:33] not very pretty but makes it easy to search the code [21:42:12] The MediaWiki tests have a decent output with just the slow tests called out at the end [21:42:23] Let me see how they do that [21:44:19] [21:45:20] dev-dependency johnkary/phpunit-speedtrap [21:45:31] I'll set that up for a comparison [21:48:15] eileen: when testing out the unit test updates locally. I'm getting a ton of test failures. How do they perform for you on wmff ? [21:49:00] this is on a fresh install [21:49:04] I just rebuilt to check [21:49:12] jgleeson: ie you are getting fails with those printers? they were good for me as long as you don't grab this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1054971/1 [21:49:44] hmm, local test fails for me too, mostly due to passing null to substr [21:49:55] deprecation warnings causing fails I think? [21:50:06] but I'm getting those without those printers [21:50:07] yeah ejegg [21:50:22] maybe we should turn off warnings/deprecation on cli [21:50:50] I think we can shim them into the xdebug config to test [21:51:28] ohh i was just testing with a different test listener [21:51:35] (the one used in the MW tests) [21:52:40] https://phabricator.wikimedia.org/F56513126 [21:53:18] I guess "a ton" was a slight exaggeration [21:53:22] just visually I like 3 but i see what elliott means with names but maybe if we know to squish the spaces? [21:54:23] jgleeson: you are running php 8.x? [21:54:52] ah yeah, we have 8.x on the dev images now [21:55:01] so... let me just null-coalesce that to '' [21:55:08] and see if I can get the tests passing [21:55:08] yeah 8.2 [21:55:53] jgleeson: yeah - so that is stricter - you could cast to string there - as long as it is valid for it to be NULL - otherwise we should fix the test data so prod stays noisy if it is null [21:56:58] 06Fundraising-Backlog, 10fundraising-tech-ops, 07Epic, 07payments-orchestration: Network configuration for Gravy integration - https://phabricator.wikimedia.org/T370319#9997019 (10Dwisehaupt) [21:59:00] 06Fundraising-Backlog, 10fundraising-tech-ops, 07Epic, 07payments-orchestration: Network configuration for Gravy integration - https://phabricator.wikimedia.org/T370319#9997023 (10Dwisehaupt) PFW changes added to the repo and pushed to the PFWs for application Network task tracked in T370481. [21:59:35] ah ok so we just need to do some php 8 tweaks [22:02:18] (03PS1) 10Ejegg: Null-coalesce trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055300 [22:02:42] (03PS1) 10Ejegg: Try a different listener for slow tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055301 [22:07:32] 06Fundraising-Backlog: Citibank international import mapping - issue with default fields + contribution source currency/amount - https://phabricator.wikimedia.org/T370483 (10MDemosWMF) 03NEW [22:08:32] (03CR) 10Cstone: [C:03+2] "thanks! looks good" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054678 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:10:07] the 'TypeError : mysqli_real_escape_string(): Argument #2 ($string) must be of type string, array given [22:10:15] one looks tricky [22:10:26] looks like we're sending in mysql IN options as arrays [22:10:39] e.g. ->addWhere('first_name', 'IN', ['Testy', 'Donald']) [22:14:26] oh no that's completely wrong [22:14:46] it looks like this is something to do with the tearDown data arrays [22:14:59] $this->ids['Contact'] [22:15:20] it's an array with a single value with a key called default [22:16:01] oh it's an INT [22:16:08] and it wants a string [22:16:10] picky [22:24:27] ejegg: that gravy timeout bug was my local docker [22:24:32] a restart fixed it [22:33:22] (03Merged) 10jenkins-bot: Use setting for wmf_audit_directory_payments_log [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054678 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:44:45] (03PS1) 10Jgleeson: Update tearDown in tests to work with PHP 8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055304 [23:11:25] (03CR) 10Ejegg: "Good catch! But can we fix it in a way that still lets us clean up multiple records?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055304 (owner: 10Jgleeson) [23:14:32] (03CR) 10Wfan: [C:03+2] "nice update for the float conversion, LGTM~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [23:15:39] (03PS3) 10Eileen: Load the message object in the parent function & pass around [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051483 (https://phabricator.wikimedia.org/T365415) [23:15:50] (03CR) 10Ejegg: [C:03+2] Load the message object in the parent function & pass around [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051483 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [23:17:46] (03Merged) 10jenkins-bot: Remove very-slow System.flush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054970 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [23:31:08] (03CR) 10Ejegg: "Mostly looks good, but I haven't smoke tested yet. Looks like the edit to DonationData isn't needed though." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [23:31:34] ugh, gerrit changed my inline comment to [Object object] [23:34:26] (03Merged) 10jenkins-bot: Load the message object in the parent function & pass around [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051483 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [23:41:03] cripes, we have like 6 i18n messages for the postal code field name [23:41:17] desperately need to clean up some messages [23:57:18] (03PS8) 10Wfan: ACH on PaymentsWiki - Form Changes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) [23:58:15] (03PS9) 10Wfan: ACH on PaymentsWiki - Form Changes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825)