[00:25:48] (03CR) 10Ejegg: "Looks pretty good! Just a couple of inline questions." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [00:46:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Japan Email Campaign Records - Incorrect utm_campaign Causing Duplicate Records - https://phabricator.wikimedia.org/T364515#9997402 (10Cstone) This got lost without a tag for a bit. I rechecked them all today and updated ~50 more records to the right utm_... [01:49:11] (03PS3) 10Eileen: Move retrieval of PaymentToken data to the message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) [01:52:37] (03CR) 10Eileen: Move retrieval of PaymentToken data to the message class (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [01:54:13] (03CR) 10Eileen: "Hmm - I kinda feel like tracking down why we have put a string in what should be an array - just gonna try to trap that" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055304 (owner: 10Jgleeson) [01:56:55] (03PS1) 10Eileen: Fix use of = where it should be IN (an array) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055315 [01:56:55] (03PS1) 10Eileen: Try to find why this is not always an array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055316 [01:57:39] (03CR) 10Eileen: "OK - so this should catch any instances - although it might be the patch before it that is really needed?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055304 (owner: 10Jgleeson) [02:02:01] ejegg: I can tweak that payment token patch furher if you want but am inclined to leave as is [02:02:22] (03PS2) 10Eileen: Remove audit settings form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054693 (https://phabricator.wikimedia.org/T270675) [02:02:47] (03PS4) 10Eileen: Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) [02:03:33] (03PS2) 10Eileen: move function to audit processor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054694 (https://phabricator.wikimedia.org/T270675) [02:04:42] (03CR) 10Eileen: [C:03+2] Null-coalesce trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055300 (owner: 10Ejegg) [02:07:25] dang on those event listeners every on one them has some feature I like - I ef like the listing of slow ones at the end in your one ejegg - but I also like being able to see what test is up to cos when it falls over without completing we can identify where it got to [02:07:28] (03PS6) 10Cstone: Add activity after completed proccessor retry (autorescue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052833 [02:12:25] (03CR) 10CI reject: [V:04-1] Add activity after completed proccessor retry (autorescue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052833 (owner: 10Cstone) [02:12:36] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1055317 [02:18:46] (03CR) 10CI reject: [V:04-1] Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:20:42] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1055317 (owner: 10Eileen) [02:21:54] (03PS7) 10Cstone: Add activity after completed proccessor retry (autorescue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052833 [02:22:29] hmm it didnt like value = 175 even though i don't see it in the tbale [02:22:49] (03PS5) 10Eileen: Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) [02:23:42] cstone: grumpy isn't it [02:24:03] yeah I know 180 works I'm trying 176 and seeing haha [02:24:05] (03Merged) 10jenkins-bot: Null-coalesce trxn_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055300 (owner: 10Ejegg) [02:24:25] lol [02:24:38] also cstone I think we can merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1054693 now [02:25:17] (& this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1054694) [02:26:00] does the first one remove it from the drupal UI too [02:26:04] - although they might conflict [02:26:07] (03CR) 10CI reject: [V:04-1] Add activity after completed proccessor retry (autorescue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1052833 (owner: 10Cstone) [02:26:09] yeah it should [02:26:27] the first one is just getting rid of that form [02:26:35] do I need to reload or something to make it go away it is mad when I click on any menu options [02:26:39] but i still see the menu [02:32:23] (03PS3) 10Eileen: Remove audit settings form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054693 (https://phabricator.wikimedia.org/T270675) [02:32:37] cstone: I needed to kill the entry in info.xml too ^^ [02:33:16] (03CR) 10Eileen: "ok - looks like it was the previous patch that needed changing" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055316 (owner: 10Eileen) [02:34:53] eileen: should info.xml have been added to that patch? [02:39:12] im confusing extensions and modules [02:40:46] (03CR) 10Cstone: [C:03+2] Fix use of = where it should be IN (an array) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055315 (owner: 10Eileen) [02:41:13] cstone: that menu link comes from the info.xml [02:42:32] yeah i was thinking each module had one but its each extension that has one [02:45:11] eileen: do we maybe want to leave some timing in around that token lookup? [02:45:52] i just have the nagging idea that it'll be doing extra DB lookups [02:46:04] I guess now that we added an index on the token value it's not much time [02:46:10] hmm - it might do - it's a very cheap get [02:47:49] (03CR) 10Ejegg: [V:03+2 C:03+2] Add Gravy library and dependencies [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/1054379 (owner: 10Ejegg) [02:49:59] (03PS2) 10Cstone: Pass through reason to refund queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1054404 (https://phabricator.wikimedia.org/T366769) [02:50:02] (03CR) 10Ejegg: [C:03+2] Pass through reason to refund queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1054404 (https://phabricator.wikimedia.org/T366769) (owner: 10Cstone) [02:50:06] !log civicrm upgraded from 384fe444 to a9ef8ab9 [02:50:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:00:10] (03Merged) 10jenkins-bot: Fix use of = where it should be IN (an array) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055315 (owner: 10Eileen) [03:00:10] (03Merged) 10jenkins-bot: Pass through reason to refund queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1054404 (https://phabricator.wikimedia.org/T366769) (owner: 10Cstone) [04:30:33] (03PS4) 10Eileen: Remove audit settings form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054693 (https://phabricator.wikimedia.org/T270675) [04:30:33] (03PS3) 10Eileen: move function to audit processor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054694 (https://phabricator.wikimedia.org/T270675) [04:30:33] (03PS6) 10Eileen: Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) [04:30:34] (03PS4) 10Eileen: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) [04:51:28] (03CR) 10CI reject: [V:04-1] Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:01:04] (03PS5) 10Eileen: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) [10:05:34] (03CR) 10Jgleeson: [V:03+2 C:03+2] Update scripts/civicrm-drush.sh to take arguments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1055227 (owner: 10Jgleeson) [10:05:53] (03CR) 10Jgleeson: [V:03+2 C:03+2] make payments-smashpig-restore.sh only update vendor. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1053273 (owner: 10Jgleeson) [10:07:30] (03CR) 10Jgleeson: "Ok that first patch has me curious. I agree. Let's try to figure out the root cause." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055316 (owner: 10Eileen) [10:13:31] 03Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Add Gravy UML Diagrams - https://phabricator.wikimedia.org/T369105#9997973 (10jgleeson) This is ready for review again. [10:16:24] Dayforce scheduled matinenance... great [10:17:54] I guess i could be worse, I could be using Windows [10:17:58] it* [10:53:29] the year of linux [10:56:23] :D [11:08:02] (03PS1) 10Damilare Adedoyin: Update docs for Adyen error mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055413 [12:05:04] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [12:05:38] (03Merged) 10jenkins-bot: DownloadReportJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1039897 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [12:09:27] (03CR) 10Jgleeson: ProcessCaptureRequestJob implements Runnable (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [12:13:41] (03CR) 10Jgleeson: [C:03+2] "We do the test update later. this LGTM." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [12:14:09] (03Merged) 10jenkins-bot: ProcessCaptureRequestJob implements Runnable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1047088 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [12:39:42] have a good weekend damilare ! [12:42:28] o// [12:43:54] (03PS1) 10Damilare Adedoyin: WIP: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) [12:44:24] (03CR) 10CI reject: [V:04-1] WIP: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) (owner: 10Damilare Adedoyin) [13:48:17] (03PS2) 10Damilare Adedoyin: WIP: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) [13:48:33] (03PS3) 10Damilare Adedoyin: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) [13:49:06] (03CR) 10CI reject: [V:04-1] Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) (owner: 10Damilare Adedoyin) [13:49:55] (03PS4) 10Damilare Adedoyin: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) [13:50:33] 03Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Webhook Processing - https://phabricator.wikimedia.org/T367807#9998527 (10Damilare) a:03Damilare [14:57:02] (03PS5) 10Damilare Adedoyin: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) [14:57:44] jgleeson|away: it wasn't a scheduled maintenance, dayforce is effect by the crowdstrike outage :) [14:58:03] good thing it's not payday [14:58:18] (03CR) 10Ejegg: [C:03+2] "This looks great! And the fact that we could add this functionality with some config and very few lines of code (plus tests) makes me feel" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) (owner: 10Damilare Adedoyin) [14:58:45] (03Merged) 10jenkins-bot: Map Gr4vy avs and cvv response code to risk scores. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055430 (https://phabricator.wikimedia.org/T369161) (owner: 10Damilare Adedoyin) [14:59:34] oh jeez... who'd have thunk adding complexity to a system to make it more robust could instead make it more failure-prone? [15:00:50] * greg-g looks at k8s [15:01:16] (03PS4) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [15:01:35] (03PS5) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [15:02:14] lol... "Try rebooting your computer 15 times, Microsoft suggests" -- https://news.sky.com/story/outages-latest-airports-business-and-broadcasters-experiencing-issues-worldwide-13180821?postid=7995600#liveblog-body [15:02:14] thanks for the reviews ejegg [15:02:27] thanks for the code, damilare :) [15:02:49] this is where I like the easy rollback-ability of fedora silverblue [15:03:16] who was counting the number of reboots? [15:03:21] (or nixos or the other container or atomic change OSs out there) [15:03:36] * ejegg hopes Migración Colombia isn't running crowdstrike - got my visa pickup appointment in 1 hr [15:05:14] hah, of course. It's just Win10 right? [15:05:30] hopefully they still run NT or 2000 :P [15:05:47] ohhhh it's really all Win10 installs affected??? [15:05:58] Jeez.. I hadn't read the whole article [15:06:00] not all, just those that use crowdstrike, afaiui [15:06:10] * greg-g re-reads the wikipedia article [15:07:07] cf: https://en.wikipedia.org/wiki/2024_CrowdStrike_incident [15:08:06] yeah, users of crowdstrike on windows. I don't know where I got the win10 thing from, probably misinformation on social media [15:08:19] (or it's just not confirmed on the wp article) [15:09:48] well, Avianca seems to still be flying - our friends from Bogotá just landed and will be able to come to my wife's birthday [15:13:29] whew [15:13:56] I saw an unverified picture of a hand written boarding pass in, I think, India? [17:27:39] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install franio200[1-3] - https://phabricator.wikimedia.org/T367819#9999216 (10Jhancock.wm) franio2001 eth0 <-> FASW-C8A eth-0/0/25 eth1 <-> FASW-C8B eth-1/0/25 franio2002 eth0 <-> FASW-C8A eth-0/0/26 eth1 <-> FASW-C8B eth-1/0/26 franio20... [18:53:06] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install franio200[1-3] - https://phabricator.wikimedia.org/T367819#9999368 (10Papaul) ` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] - member ge-0/0/25; - member ge-0/0/26; - member ge-0/0/27; -... [19:37:57] (03CR) 10Ejegg: [C:03+2] "Looks good! I guess we will get translated versions of the image later?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [19:39:52] (03Merged) 10jenkins-bot: ACH on PaymentsWiki - Form Changes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [20:00:08] 06Fundraising-Backlog, 10FR-email-preferences: Create WMF-hosted unsubscribe page - https://phabricator.wikimedia.org/T127401#9999515 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF For all intents and purposes our new preference centre will address the issues listed in the description. Closing. Not... [20:00:58] 14fundraising sprint Roller Toaster, 14fundraising sprint Screaming Goats Yelling Zoo, 14Fundraising Sprint Technical debt house of horrors, 06Fundraising-Backlog, and 2 others: Add 3 email preference fields to civi - https://phabricator.wikimedia.org/T278858#9999522 (10AKanji-WMF) 05Open→03Resolved... [20:18:24] 06Fundraising-Backlog: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#9999558 (10AKanji-WMF) [20:18:29] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), and 5 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#9999559 (10AKanji-WMF) [20:24:59] (03CR) 10Ejegg: "Looks like it should work for now, but I'm wary of moving too much out of handleCreatedPayment before we implement 3d secure with Gravy. h" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) (owner: 10Damilare Adedoyin) [20:39:15] (03CR) 10Ejegg: [C:03+2] Remove audit settings form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054693 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [20:40:16] (03CR) 10Ejegg: [C:03+2] move function to audit processor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054694 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [20:44:09] (03CR) 10Ejegg: [C:03+2] Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [20:50:25] (03PS5) 10Umherirrender: Use namespaced CLDR classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040758 [20:50:40] (03CR) 10Ejegg: [C:03+2] Use namespaced CLDR classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040758 (owner: 10Umherirrender) [20:51:55] (03CR) 10Ejegg: [V:03+2] build: Updating braces to 3.0.3 [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1043453 (owner: 10Libraryupgrader) [20:52:21] (03CR) 10Ejegg: [V:03+2] build: Updating braces to 3.0.3 [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1043455 (owner: 10Libraryupgrader) [20:52:28] (03CR) 10Ejegg: [V:03+2] build: Updating braces to 3.0.3 [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1043456 (owner: 10Libraryupgrader) [20:54:19] (03Merged) 10jenkins-bot: Use namespaced CLDR classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1040758 (owner: 10Umherirrender) [20:58:26] (03Merged) 10jenkins-bot: Remove audit settings form [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054693 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:01:00] (03Merged) 10jenkins-bot: move function to audit processor class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054694 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:01:53] (03CR) 10Cstone: [C:03+2] "looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054929 (https://phabricator.wikimedia.org/T342812) (owner: 10Ejegg) [21:02:25] (03Merged) 10jenkins-bot: Call wmf_echo via the class function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054695 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:23:01] (03Merged) 10jenkins-bot: Only log TY ages for donations from front-end [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054929 (https://phabricator.wikimedia.org/T342812) (owner: 10Ejegg)