[05:50:54] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1054999 (owner: 10L10n-bot) [11:33:21] (03CR) 10Pcoombe: [C:03+2] "Oops, thanks for spotting I missed that!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055522 (https://phabricator.wikimedia.org/T370576) (owner: 10Majavah) [11:35:17] (03PS1) 10Amire80: Improve grammar and punctucation in recently-added messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055898 [12:10:59] (03Merged) 10jenkins-bot: Remove reference to non-existent message directory [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055522 (https://phabricator.wikimedia.org/T370576) (owner: 10Majavah) [13:22:41] (03PS8) 10Damilare Adedoyin: Add recurring payment token to data sent to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) [13:35:39] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install franio200[1-3] - https://phabricator.wikimedia.org/T367819#10002299 (10Papaul) [13:37:33] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install franio200[1-3] - https://phabricator.wikimedia.org/T367819#10002304 (10Papaul) a:05Papaul→03Dwisehaupt @Dwisehaupt all your's [13:37:35] (03CR) 10Damilare Adedoyin: "thanks ejegg for the review, I've added the update to handleCreatePayment as recommended." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) (owner: 10Damilare Adedoyin) [14:31:11] 06Fundraising-Backlog: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642 (10MDemosWMF) 03NEW [15:35:44] (03Merged) 10jenkins-bot: Simplify country look up in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051493 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [15:40:38] (03Merged) 10jenkins-bot: Add Gravy to payment processors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055229 (owner: 10Jgleeson) [15:43:21] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install franio200[1-3] - https://phabricator.wikimedia.org/T367819#10003134 (10Dwisehaupt) Thanks! [15:43:50] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.43-notes (1.43.0-wmf.15; 2024-07-23): DonationInterface references a non-existent translation directory - https://phabricator.wikimedia.org/T370576#10003142 (10Pcoombe) 05Open→03Resolved a:03taavi [15:44:45] (03PS1) 10Damilare Adedoyin: Import 'BaseAdyenCheckoutTestCase' in AdyenFormLoadTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055969 [15:46:38] (03CR) 10CI reject: [V:04-1] Import 'BaseAdyenCheckoutTestCase' in AdyenFormLoadTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055969 (owner: 10Damilare Adedoyin) [15:47:48] (03Abandoned) 10Damilare Adedoyin: Import 'BaseAdyenCheckoutTestCase' in AdyenFormLoadTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055969 (owner: 10Damilare Adedoyin) [16:10:00] (03CR) 10Wfan: "Confirmed from Evelyn, since ACH is US only so no need to translate. Thanks Elliott for the review~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1052824 (https://phabricator.wikimedia.org/T360825) (owner: 10Wfan) [16:20:09] (03PS7) 10Damilare Adedoyin: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) [16:20:12] (03CR) 10Ejegg: [C:03+2] Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [16:25:18] (03Merged) 10jenkins-bot: Setup monthly convert decline function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055236 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [16:33:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#10003539 (10AKanji-WMF) [16:37:36] 03Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Add Gravy UML Diagrams - https://phabricator.wikimedia.org/T369105#10003568 (10AnnWF) >>! In T369105#9987352, @jgleeson wrote: >>>! In T369105#9975592, @AnnWF wrote: >> Do we want to add the ste... [16:38:48] (03PS3) 10Damilare Adedoyin: Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) [16:44:14] (03PS9) 10Damilare Adedoyin: Add recurring payment token to data sent to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) [16:44:22] (03CR) 10Ejegg: [C:03+2] Add recurring payment token to data sent to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) (owner: 10Damilare Adedoyin) [16:46:12] (03Merged) 10jenkins-bot: Add recurring payment token to data sent to queue [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1047493 (https://phabricator.wikimedia.org/T367578) (owner: 10Damilare Adedoyin) [16:52:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#10003647 (10Ejegg) For a few years now, we have been running a daily job that mark... [16:55:30] (03PS4) 10Damilare Adedoyin: Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) [16:55:51] 06Fundraising-Backlog: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10003664 (10CaitVirtue) @RKumar_WMF I'm especially interested in/concerned about the PAN number requirement for large donations. Can you share more ab... [16:55:58] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [16:58:05] (03Merged) 10jenkins-bot: Enable monthly convert modal on the frontend [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055246 (https://phabricator.wikimedia.org/T367579) (owner: 10Damilare Adedoyin) [17:21:09] (03PS1) 10Damilare Adedoyin: WIP: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [17:21:47] (03CR) 10CI reject: [V:04-1] WIP: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) (owner: 10Damilare Adedoyin) [17:50:45] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Cloud-VPS (Debian Buster Deprecation): Upgrade centralnotice-staging to get off debian buster - https://phabricator.wikimedia.org/T360949#10004015 (10Andrew) I shut down this VM due to lack of response here [18:07:05] (03PS1) 10Ejegg: WIP annual recurring option for monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055987 (https://phabricator.wikimedia.org/T368155) [18:09:06] (03CR) 10CI reject: [V:04-1] WIP annual recurring option for monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055987 (https://phabricator.wikimedia.org/T368155) (owner: 10Ejegg) [18:22:27] (03PS2) 10Ejegg: WIP annual recurring option for monthly convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1055987 (https://phabricator.wikimedia.org/T368155) [18:31:36] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1055994 [18:31:41] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1055994 (owner: 10Ejegg) [18:32:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1055994 (owner: 10Ejegg) [18:36:10] !log civicrm upgraded from a9ef8ab9 to 4247715d [18:36:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:03:39] 06Fundraising-Backlog: Gravy treat buyer email address case sensitive - https://phabricator.wikimedia.org/T370700 (10AnnWF) 03NEW [19:20:34] yay ejgeg|food re https://phabricator.wikimedia.org/T368155 [19:25:54] just in progress still anilk ! [19:30:54] why is this comptuers clock wrong haha [19:43:31] 14Fundraising Sprint: meow(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Test out, maybe implement new scheduled communication functionality - https://phabricator.wikimedia.org/T369109#10004525 (10XenoRyet) [19:45:54] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Civi-Dedupe: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#10004542 (10XenoRyet) [19:51:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#10004577 (10XenoRyet) p:05Triage→03High [19:51:12] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Drupal admin civi contact getting activites for all contributions - https://phabricator.wikimedia.org/T367612#10004578 (10XenoRyet) p:05Triage→03Low [19:51:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Turns out wmffraud tests not running - https://phabricator.wikimedia.org/T365414#10004579 (10XenoRyet) p:05Triage→03Low [20:01:02] (03PS1) 10Eileen: Move Address insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056008 (https://phabricator.wikimedia.org/T365415) [20:01:20] (03PS1) 10Wfan: Force lowercase for buyer email for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056009 (https://phabricator.wikimedia.org/T370700) [20:01:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10004670 (10AKanji-WMF) p:05Triage→03Unbreak! [20:01:44] (03CR) 10CI reject: [V:04-1] Force lowercase for buyer email for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056009 (https://phabricator.wikimedia.org/T370700) (owner: 10Wfan) [20:03:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#10004675 (10MBeat33) I think 90 days would be a nice balance between giving donors... [20:09:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called fro... - https://phabricator.wikimedia.org/T366742#10004693 [20:10:49] (03PS2) 10Wfan: Force lowercase for buyer email for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056009 (https://phabricator.wikimedia.org/T370700) [20:15:36] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 13Patch-For-Review: Gravy treat buyer email address case sensitive - https://phabricator.wikimedia.org/T370700#10004715 (10AnnWF) [20:23:44] 06Fundraising-Backlog: New design layout variant for payments wiki - https://phabricator.wikimedia.org/T370369#10004796 (10AKanji-WMF) Thanks @ppenloglou - let us know if you have any CSS for us, and what date you'd ideally like to start testing this variant! [20:42:26] (03CR) 10Ejegg: [C:03+2] "Looks good, can't see any errors smoke testing locally!" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1052668 (https://phabricator.wikimedia.org/T287405) (owner: 10Jforrester) [20:47:34] 06Fundraising-Backlog, 10fundraising-tech-ops, 07Epic, 07payments-orchestration: Network configuration for Gravy integration - https://phabricator.wikimedia.org/T370319#10004864 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt PFW changes deployed so we should be all set. closing. [20:53:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called fro... - https://phabricator.wikimedia.org/T366742#10004883 [20:57:49] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1052668 (https://phabricator.wikimedia.org/T287405) (owner: 10Jforrester) [21:09:02] (03PS6) 10Eileen: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) [21:09:02] (03PS1) 10Eileen: Superficial clean up in Adyet processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056019 (https://phabricator.wikimedia.org/T270675) [21:09:02] (03PS1) 10Eileen: Superficial clean up in Amazon audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056020 (https://phabricator.wikimedia.org/T270675) [21:09:03] (03PS1) 10Eileen: Superficial clean up in Braintree processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056021 [21:09:04] (03PS1) 10Eileen: Superficial clean up in Dlocal audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056022 (https://phabricator.wikimedia.org/T270675) [21:09:06] (03PS1) 10Eileen: Superficial clean up in FundraiseUpAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056023 (https://phabricator.wikimedia.org/T270675) [21:09:10] (03PS1) 10Eileen: Superficial clean up in Ingenico AuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056024 (https://phabricator.wikimedia.org/T270675) [21:23:42] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Adyet processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056019 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:24:02] (03PS7) 10Eileen: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) [21:24:02] (03PS1) 10Eileen: Superficial clean up in BaseAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056027 (https://phabricator.wikimedia.org/T270675) [21:24:04] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Amazon audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056020 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:24:20] hopefully I've made the move patch a bit cleaner [21:24:23] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Braintree processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056021 (owner: 10Eileen) [21:24:34] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Dlocal audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056022 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:24:58] cos I can't get away from it touching 50+ files [21:25:12] (03CR) 10Ejegg: [C:03+2] Superficial clean up in FundraiseUpAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056023 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:27:24] (03CR) 10Ejegg: [C:03+2] Superficial clean up in Ingenico AuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056024 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:30:26] (03CR) 10Ejegg: [C:03+2] Superficial clean up in BaseAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056027 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:30:58] :) yeah, looks pretty safe in the latest version. Thanks! [21:31:38] was it just annoying to move BaseAuditProcessor in the same patch? [21:32:37] once the big-audit-files move is merged I have some questions.... [21:32:37] 1) it looks like the options we have code to handle are [21:32:37] - submod_prefix [21:32:37] - quiet [21:32:38] - verbose [21:32:38] - charlimit [21:32:38] - log_search_past_days' (we pass this through process control now) [21:32:39] Do we use all of these in practice - it feels like quiet & verbose & charlimit all relate to how / what we log [21:32:40] 2) we have the test testFillEmptyContributionTrackingData which calls wmf_audit_get_contribution_tracking_data directly - meaning we can't move that function. We do indirectly test it - in that (eg) adyen test has messages with no corresponding Contribution Tracking record - we could maybe add some asserts on AdyenTest & remove that tests, allowing the function to be moved [21:32:59] ejegg: I think BaseAuditProcessor was already moved [21:33:04] lol charlimit is like a terminal width thing? [21:33:18] oh no it isn't - ok lets move [21:35:06] (03PS8) 10Eileen: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) [21:35:22] ejegg: now in the move ^^ [21:35:26] oh cool! [21:36:12] ejegg: oh yeah most of that `wmf_echo` seems to be about that charlimit too... [21:39:51] oh, submod_prefix is basically just a reference to the processor name: $options['submod_prefix'] = $this->name; [21:40:01] so not even meant to be sent on the CLI [21:40:38] (03CR) 10Ejegg: [C:03+2] Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:41:33] orrr is that how we decide which to run [21:42:45] (03Merged) 10jenkins-bot: Superficial clean up in Adyet processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056019 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:43:39] (03Merged) 10jenkins-bot: Superficial clean up in Amazon audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056020 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:43:41] (03Merged) 10jenkins-bot: Superficial clean up in Braintree processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056021 (owner: 10Eileen) [21:43:58] I don't think submodule prefix could ever be set? [21:45:22] (03Merged) 10jenkins-bot: Superficial clean up in Dlocal audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056022 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:45:23] (03Merged) 10jenkins-bot: Superficial clean up in FundraiseUpAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056023 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:45:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10005113 (10Cstone) a:03Cstone [21:45:42] yeah, it looks like that got lost in a long-ago refactor [21:47:43] (03Merged) 10jenkins-bot: Superficial clean up in Ingenico AuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056024 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:47:48] I think we can just replace it with the gateway name [21:50:00] ejegg: yeah - looks like we need to unwravel wmf_audit_get_contribution_tracking_data first - cos that calls wmf_audit_log_error which winds us up in submod-prefix craziness [21:50:16] (03Merged) 10jenkins-bot: Superficial clean up in BaseAuditProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056027 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:50:46] I guess I can try removing that test in favour of a bit more testing in Adyen [22:00:11] (03Merged) 10jenkins-bot: Move main audit classes & tests to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054696 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:05:56] (03PS1) 10Eileen: Put test for missing contribution tracking in AdyenAuditTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056033 (https://phabricator.wikimedia.org/T270675) [22:06:18] ejegg: ok - so I guess ^^ makes it so that function can be moved [22:07:49] (03CR) 10Ejegg: [C:03+2] Put test for missing contribution tracking in AdyenAuditTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056033 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:08:52] eileen: re the output printers, maybe we can choose one of the more compact printerClass ones, PLUS that slow test logger copied over from the mediawiki CI? [22:09:58] looks like we should be able to configure both [22:11:17] (03PS1) 10Eileen: Move function back to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056036 (https://phabricator.wikimedia.org/T270675) [22:13:13] (03PS1) 10Cstone: WIP: Add in street field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) [22:13:50] (03PS2) 10Cstone: WIP: Add in street number field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) [22:13:57] gonna head out early. See y'all tomorrow! [22:14:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10005187 (10Cstone) Dlocal needs these fields for address: Street Number City [22:20:07] (03PS2) 10Eileen: Move function back to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056036 (https://phabricator.wikimedia.org/T270675) [22:20:07] (03PS1) 10Eileen: Decommission wmf_audit_log_error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056039 (https://phabricator.wikimedia.org/T270675) [22:20:08] (03PS1) 10Eileen: Fold isFatal check back into logError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056040 (https://phabricator.wikimedia.org/T270675) [22:26:46] (03Merged) 10jenkins-bot: Put test for missing contribution tracking in AdyenAuditTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056033 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:37:40] (03PS1) 10Eileen: Move countMissing to BaseProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056041 (https://phabricator.wikimedia.org/T270675) [22:37:42] (03PS1) 10Eileen: Use gateway name, not confusing thing (submod_prefix) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056042 (https://phabricator.wikimedia.org/T270675) [22:37:44] (03PS1) 10Eileen: Remove handling for charlimit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056043 (https://phabricator.wikimedia.org/T270675) [22:43:10] (03PS1) 10Eileen: Switch to using \Civi::log() for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) [22:44:50] (03CR) 10CI reject: [V:04-1] Switch to using \Civi::log() for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:06:38] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:34:00] (03PS1) 10Eileen: Remove now-unused audit_runtime [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056046 (https://phabricator.wikimedia.org/T270675) [23:34:01] (03PS1) 10Eileen: Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675)