[00:21:26] hey cstone are you about ? [00:32:50] Eileen I'll be back in like 1.5 hours [00:33:10] cstone: ok cool - not urgent just some ideas kicking around in my head [00:33:33] Going to get a milkshake haha [00:36:40] (03PS2) 10Eileen: Switch to using \Civi::log() for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) [00:36:40] (03PS2) 10Eileen: Remove now-unused audit_runtime [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056046 (https://phabricator.wikimedia.org/T270675) [00:36:40] (03PS2) 10Eileen: Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675) [00:36:41] (03PS1) 10Eileen: Fold DAO-to-list back into callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056051 [00:36:42] (03PS1) 10Eileen: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056052 (https://phabricator.wikimedia.org/T270675) [00:36:44] (03PS1) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [00:36:48] (03PS1) 10Eileen: Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) [00:36:52] (03PS1) 10Eileen: Stop enabling wmf_audit sub-modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056055 (https://phabricator.wikimedia.org/T270675) [01:00:52] (03CR) 10CI reject: [V:04-1] Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [01:01:50] (03CR) 10CI reject: [V:04-1] Stop enabling wmf_audit sub-modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056055 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [01:04:37] (03CR) 10CI reject: [V:04-1] Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [01:46:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10005465 (10RKumar_WMF) @CaitVirtue - I am not sure how would you like to make it work for Maj... [01:48:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD. - https://phabricator.wikimedia.org/T370583#10005466 (10RKumar_WMF) House Number and Street Name/Locality Village/Town/City State PIN Code... [02:37:09] Eileen I failed at getting back quickly [02:38:02] I'm back if you are still around [03:21:23] Yeah sorry - was away [03:25:15] (03PS2) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [03:48:06] (03CR) 10CI reject: [V:04-1] Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [04:06:53] (03PS3) 10Eileen: Phpunit printer option 1 CodeDudgeon [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054958 [04:06:53] (03PS2) 10Eileen: Phpunit printer option 2 Tap [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054959 [04:06:53] (03PS2) 10Eileen: Phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054962 [04:06:54] (03PS2) 10Eileen: Phpunit printer option 4 DiabloMedia [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054963 [04:06:55] (03PS2) 10Eileen: Phpunit printer option Sempro [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054965 [04:44:44] (03PS3) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [05:00:38] (03PS4) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [05:07:56] (03PS1) 10Eileen: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) [05:07:56] (03PS1) 10Eileen: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) [05:08:13] (03PS5) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [05:10:24] (03PS2) 10Eileen: Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) [05:10:24] (03PS2) 10Eileen: Stop enabling wmf_audit sub-modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056055 (https://phabricator.wikimedia.org/T270675) [05:12:42] (03CR) 10CI reject: [V:04-1] Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:18:18] (03PS5) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [05:18:18] (03PS3) 10Eileen: Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) [05:18:19] (03PS3) 10Eileen: Stop enabling wmf_audit sub-modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056055 (https://phabricator.wikimedia.org/T270675) [05:19:01] (03CR) 10CI reject: [V:04-1] Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [05:19:22] (03CR) 10CI reject: [V:04-1] Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [05:19:23] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [05:21:05] (03PS2) 10Eileen: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) [05:21:05] (03PS2) 10Eileen: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) [05:21:05] (03PS6) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [05:23:34] (03CR) 10CI reject: [V:04-1] Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:28:07] (03Abandoned) 10Eileen: Disable debug in unit tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054945 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [05:28:34] (03Abandoned) 10Eileen: Try to find why this is not always an array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055316 (owner: 10Eileen) [05:34:15] (03CR) 10Eileen: Remove now-unused audit_runtime (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056046 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:40:00] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [06:06:33] (03PS3) 10Eileen: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) [06:06:33] (03PS3) 10Eileen: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) [06:06:33] (03PS7) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [06:06:34] (03PS1) 10Eileen: Do not implement transactionalInterface in MergeTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056074 (https://phabricator.wikimedia.org/T370371) [06:26:43] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [09:32:25] (03PS8) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [09:55:39] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [12:01:25] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10006502 (10CDenes_WMF) From caitlin virtue: //> We do not target small dollar donors outside 6c countries for Endowment gifts, but anyone is able... [12:05:04] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10006514 (10CDenes_WMF) The WTG page is being refreshed and translations are being updated. If we wanted to, we could remove the 'Endowment' section i... [13:54:28] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10006844 (10CDenes_WMF) Hi all. Decision has been made by Caitlin Virtue to keep the Endowment section in the non-english WTG page. Context: > Let’s... [13:54:49] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10006859 (10CDenes_WMF) Thus, we can consider this resolved. [14:06:52] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10006938 (10krobinson) Would it be possible to see how many donations we're received to the endowment in non-English / non-6C? We have only had 2 co... [14:17:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Investigation: Cancel Paypal Recurring doesn't always cancel on processor side - https://phabricator.wikimedia.org/T341346#10006970 (10AMJohnson) Sounds good to me too. Thank you, @Ejegg! [14:22:26] (03PS1) 10Jforrester: [DNM] CurrencyRatesModule: Stop using Xml::encodeJsVar, deprecated [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056171 (https://phabricator.wikimedia.org/T341779) [14:22:56] (03CR) 10Jforrester: [C:03+2] build: Updating npm dependencies [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056057 (owner: 10Libraryupgrader) [14:23:53] (03CR) 10CI reject: [V:04-1] [DNM] CurrencyRatesModule: Stop using Xml::encodeJsVar, deprecated [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056171 (https://phabricator.wikimedia.org/T341779) (owner: 10Jforrester) [15:13:42] (03PS2) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:14:04] (03CR) 10CI reject: [V:04-1] Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) (owner: 10Damilare Adedoyin) [15:21:54] (03PS1) 10Damilare Adedoyin: Add Gr4vy webhook listener to Rewrite rule [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1056185 [15:23:21] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frqueue2003, pay-lb2001, pay-lb2002 - https://phabricator.wikimedia.org/T369566#10007234 (10Jhancock.wm) a:03Jhancock.wm [15:25:01] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw: Q1:rack/setup/install frban2002 - https://phabricator.wikimedia.org/T369931#10007251 (10Jhancock.wm) a:03Jhancock.wm [15:27:20] (03PS3) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:27:31] (03PS4) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:27:51] (03CR) 10CI reject: [V:04-1] Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) (owner: 10Damilare Adedoyin) [15:28:53] (03PS3) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [15:36:03] (03PS4) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [15:36:49] (03PS5) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [15:57:28] (03PS6) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [16:17:01] (03PS7) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [16:35:45] ejegg: when you were fixing those recurring cancels through the scheduled db upgrade did you get it to succesfully test on staging? [16:35:50] er queued [16:36:11] it runs my update but then I dont see anything in the queue table [16:38:54] cstone ah no, I just tested locally with fake data [16:39:04] ah okay [16:39:06] and then on prod with a small number at first I think [16:39:08] i can try that then [16:39:29] odd that it wouldn't add anything to the queue on staging, though! [16:40:06] was coworker not running there before or did i make that up? but i can see stuff in the queue_items table [16:40:23] i think it's not running maybe [16:40:31] let's see, how can we figure that out [16:40:44] i thought it would at least put stuff in the tables though [16:41:02] also could be an issue with my code lemme try locally [16:41:41] (03PS5) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [16:42:28] hmm, I do see 5 things in dev_civicrm.civicrm_queue_item where queue_name='wmf_data_upgrades' [16:44:35] but the date on those is july 8 [16:44:39] unless the date is unreliable [16:45:06] it should have the weight of 100 like yours does from 6/20 [16:53:01] ah ok [16:53:04] so hmmm [16:53:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices, and 2 others: Job that sets PayPal recurs as cancelled after 90 days w/no donation should also cancel at PayPal - https://phabricator.wikimedia.org/T341346#10007727 (10Ejegg) [16:53:41] I wonder if someone tested a different unmerged upgrade that bumped the version past your upgrade number? [16:53:51] Let's look in the log for the extension metadata table [16:53:55] oh i was hacking that [16:54:01] that part was working [16:54:07] ah so you're sure it ran [16:54:10] yeah [16:54:17] weird, [16:54:22] it should be 5556 cause i ran it twice [16:54:33] er 4556 [16:54:43] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Create new Benevity import - https://phabricator.wikimedia.org/T359219#10007732 (10NNichols) We will also need to create a new benevity import for the Endowment as well. The total number of gift coming through that are much smaller but it could... [16:54:48] i just got the test data set up locally so trying that [16:54:57] lemme see, I'll look at https://gerrit.wikimedia.org/r/1047215 [16:56:51] hmm locally eileens show up but not mine so maybe something is wrong with that patch [16:57:35] she did add a function to queue it inbetween me starting this patch and now [16:58:18] cstone oh so I only see 5 rows when I try the select statement on dev_civicrm; [16:58:21] yeah [16:58:23] i made those 5 [16:58:33] the bad data isnt there so its just 5 right now [16:58:38] ah ok [16:59:25] so they also have the data in the log table to make it get into the if ($recurLog->cancel_date) { ... } block? [16:59:51] it should I was using searchkit to update a previouslly cancelled one [16:59:55] ok [17:00:16] i wonder if that if is right though but I guess i was expecting it to be queued anyway [17:00:38] 14Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Process jobs-gravy queue - https://phabricator.wikimedia.org/T370797 (10Damilare) 03NEW [17:00:48] 14Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Process jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10007761 (10Damilare) [17:01:25] 14Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 07payments-orchestration: Process jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10007764 (10Damilare) [17:05:43] cstone your comment mentions 'get the latest cancel_date' [17:05:57] maybe you want to add an 'order by cancel_date desc' before the 'limit 1' ? [17:06:12] im trying to remember why I took that out [17:06:37] maybe that was before i added in the is not null [17:07:47] ok, I just did the individual queries from the log_civicrm_contribution_recur table, and they all came back with a date [17:09:52] (03CR) 10Damilare Adedoyin: "Thanks wfan for catching that edge case, I have highlighted the class and method where we currently map the request params and would be re" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056009 (https://phabricator.wikimedia.org/T370700) (owner: 10Wfan) [17:10:44] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Banner preview: fix banner editor for users without CN admin rights - https://phabricator.wikimedia.org/T230857#10007794 (10Astinson) [17:10:45] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice: Don't show live preview section for users without CN rights - https://phabricator.wikimedia.org/T226961#10007795 (10Astinson) [17:11:09] ejegg: rml data question in the analytics call if you want to join [17:12:41] ok sorry actually pageviews question [17:20:46] 06Fundraising-Backlog, 10FR-donorservices: Endowment 'Thank You' email/receipt sent in English to non-English donors - https://phabricator.wikimedia.org/T367594#10007832 (10Ejegg) @krobinson Here's what I can get for languages with a quick query on the contribution_tracking table: `lang=sql select language, co... [17:22:36] oops, be right there cstone [17:23:04] and... i missed it [17:23:06] sorry! [17:34:49] no worries ejegg [17:40:10] 06Fundraising-Backlog: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10007875 (10AKanji-WMF) @Eileenmcnaughton based on convo with @MDemosWMF this is the higher of the current import tasks - moving to Sprint +1 but let me know if you recommend different timing. [17:45:39] 06Fundraising-Backlog: Citibank international import mapping - issue with default fields + contribution source currency/amount - https://phabricator.wikimedia.org/T370483#10007924 (10AKanji-WMF) @Eileenmcnaughton enabled the addition of extra default fields, unfortunately these are not saving so we have to creat... [17:48:13] 06Fundraising-Backlog: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10007935 (10Ejegg) @Dwisehaupt this might be a fr-tech-ops task. looks like the batch input screen might just post back a zillion POST vars (#_of_columns x #_of_donations). Do you have any concerns with settin... [17:49:43] 06Fundraising-Backlog: Building Fidelity import - issue with addressee column - https://phabricator.wikimedia.org/T370469#10007940 (10AKanji-WMF) @Eileenmcnaughton sounds like the mapping tool breaks the ability you enabled where a supporter's full name would be aligned to prefix fname lname etc - putting this t... [17:50:38] 06Fundraising-Backlog: Engage mapping import - Individual - https://phabricator.wikimedia.org/T364653#10007943 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF In speaking with @MDemosWMF this has been tested and appears resolved - thank you! [17:52:42] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Pledge currency issue - https://phabricator.wikimedia.org/T365405#10007951 (10AKanji-WMF) [17:58:06] ok, today's test is done. I think I want to deploy the 'runnable' fixes [17:58:13] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Pledge currency issue - https://phabricator.wikimedia.org/T365405#10007960 (10AKanji-WMF) Current volume of non-USD pledges are low - 1-2 per year. In discussion with @MDemosWMF keeping this in "next" is fine for now - would be useful to address with any... [17:58:17] let me see if I can do that without failmail this time [17:58:29] 06Fundraising-Backlog: Search kit fields for pledges - https://phabricator.wikimedia.org/T361635#10007962 (10AKanji-WMF) @Eileenmcnaughton noting that MGFE would also like relationship managers to receive scheduled reminders from when a pledge instalment is pending (e.g. 1 month out) - shall I make a seperate ph... [18:00:03] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Empty table when looking at import results - https://phabricator.wikimedia.org/T354457#10007985 (10AKanji-WMF) 05Open→03Resolved In discussion with @MDemosWMF we're closing as we haven't seen this happen again. Will re-open if we do! [18:02:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: DMA default 'spontaneousdonation' - https://phabricator.wikimedia.org/T367477#10007999 (10AKanji-WMF) can this field be blank fr-tech, or does there NEED to be a value in there? "spontaneousdonation" is not part of @NNichols coding FYI. [18:02:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Country ID error in Engage Organization import - https://phabricator.wikimedia.org/T366126#10008001 (10AKanji-WMF) 05Open→03Resolved a:03AKanji-WMF [18:04:10] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Cannot update the option value of a custom field - https://phabricator.wikimedia.org/T352343#10008013 (10AKanji-WMF) @JMando has this been resolved from your perspective? [18:18:26] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008116 (10Dwisehaupt) Aside from the concerns of ever growing request length, I think we can up this. It is not a setting we have moved from the default yet, so let me template it ou... [18:23:15] 06Fundraising-Backlog: Building Fidelity import - issue with addressee column - https://phabricator.wikimedia.org/T370469#10008125 (10AKanji-WMF) Aaand moving to +1 based on convo in office hours. [18:32:25] fr-tech i'll be late to tech talk [18:32:38] just seeing off my Bogotá friends [18:32:42] sorry! [18:35:17] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008165 (10Dwisehaupt) This has been templated and merged. It will roll out with the next scheduled puppet run. You will be clear to test in ~15mins. ` 349ba5c17 Set max_input_vars=2... [18:45:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: DMA default 'spontaneousdonation' - https://phabricator.wikimedia.org/T367477#10008199 (10NNichols) Thank you. It can be blank (for now). I also want to let you know that Melanie pointed this out to me before she logged this and I unchecked the Default... [19:53:22] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008418 (10Dwisehaupt) [19:54:13] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008420 (10AKanji-WMF) @MDemosWMF Can you please try now? [19:57:42] cstone: want to paste that wall of text from coworker to someplace shareable? [19:58:28] ejegg: thinking about supplemental_address_1 i think this would make the most sense, this is an example of both address and number "Sh No.8, 2/8, Mahajan Galli, Zaveri Bzr, Chira Bazar" [19:58:37] yeah lemme get back out that laptop i left it outside hah [20:01:10] ejegg: https://etherpad.wikimedia.org/p/coworkeroutput [20:02:19] can you put up a WIP of the code that you were running? [20:03:38] yeah lemme clean that up [20:04:33] (03PS8) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [20:08:38] dang, i can't see what's wrong [20:11:34] ok, I cleaned up the stack trace a bit in that etherpad [20:11:34] lemme try again with everything fresh [20:12:00] I'm wondering if there's something wrong with the custom code that eileen wrote to do that api4 harness [20:12:19] is this failing trying to run the upgrade cstone has ^^ [20:12:19] since it's only ever been used one other time, and that time had an 'increment' block [20:12:21] yeah i switched to that when the og wasnt working lemme switch back to that too [20:12:32] it was just us trying a bunch of different stuff [20:12:47] eileen: its getting the coworker to do what we want it to do part [20:12:55] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008527 (10MDemosWMF) I just tried again and still getting the same notice {F56623785} [20:13:42] how many are you updating? It feels like you could just call the api directly here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1047215/8/drupal/sites/default/civicrm/extensions/wmf-civicrm/CRM/Wmf/Upgrader.php [20:13:53] 15k [20:14:49] ok - well the way that line looks is probably not much different to calling it directly I don't think [20:15:44] I mean it would push it into the queue but you would be doing 1 at a time if direct of via coworker (compare that to trying to do batches of 500 at a time which is what that queueApi4 is designed for [20:19:57] hmm i think i have it running locally now its actually printing out things still erroring though but a different error ! [20:20:11] it ran 28 times! hah [20:21:41] Queue task returned false maybe something is wrong with the update itself then [20:23:34] (03PS9) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [20:25:30] -hmm - there is a hook that kicks in maybe? [20:26:03] ahhh that contributionrecur hook [20:26:10] yeah probably that eileen and cstone [20:26:14] hmmmm [20:26:21] how did you get around that ejegg ? [20:26:44] i blanked the rescue id [20:27:06] ahhh [20:27:20] ok i just confirmed too that whats getting on the queue now is what we want [20:27:59] can we see if some of those have a rescue id [20:28:05] (03PS9) 10Cstone: Fix paypal cancellation dates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1047215 (https://phabricator.wikimedia.org/T367623) [20:28:14] yeah lets see [20:29:38] i think they are all in a table [20:31:33] oh hey, another banner test going on? [20:31:52] yeah looks like it based on the dr channel [20:35:25] k, i'll hold off deploys for a bit [20:37:21] wait none of these should have autorescue anything they are all paypal [20:38:01] oh is it just one? hmm [20:38:14] oh right [20:38:23] so... not that hook [20:40:15] yeah and confirmed too that none of them accidentally have one [20:41:06] ok im gona put this on pause and go get some food [20:41:38] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install franio100[1-3] - https://phabricator.wikimedia.org/T367820#10008619 (10Jclark-ctr) [20:43:25] (03CR) 10Ejegg: [C:03+2] Move function back to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056036 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [20:46:01] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad: Q1:rack/setup/install frnetmon1002, pay-lb1001, pay-lb1002 - https://phabricator.wikimedia.org/T369565#10008630 (10Jclark-ctr) [20:46:19] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [20:48:37] processing rate hovering around 5/sec [20:49:05] save contact taking around 100ms, save donation 80ms [20:54:59] hmm ok - a bit on the slow side [21:05:42] (03Merged) 10jenkins-bot: Move function back to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056036 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:11:56] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008692 (10Dwisehaupt) @MDemosWMF I just restarted the civicrm apache process. It's possible this setting was cached at that level. Feel free to try again when you get a chance. [21:14:11] (03CR) 10Ejegg: [C:03+2] Decommission wmf_audit_log_error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056039 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:18:48] (03CR) 10Ejegg: [C:03+2] Fold isFatal check back into logError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056040 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:22:30] (03CR) 10Ejegg: [C:03+2] Move countMissing to BaseProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056041 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:35:27] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008783 (10MDemosWMF) @Dwisehaupt Still getting this:{F56625304} [21:35:34] (03Merged) 10jenkins-bot: Decommission wmf_audit_log_error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056039 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:37:38] (03Merged) 10jenkins-bot: Fold isFatal check back into logError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056040 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:40:59] (03Merged) 10jenkins-bot: Move countMissing to BaseProcessor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056041 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:52:16] (03CR) 10Ejegg: [C:03+2] Use gateway name, not confusing thing (submod_prefix) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056042 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:56:00] omg cstone confusing thing is GONE [21:56:28] (03CR) 10Ejegg: [C:03+2] Remove handling for charlimit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056043 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [21:58:16] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008875 (10Dwisehaupt) Ok, so it has the new setting but it still isn't large enough. I'll chat with @Eileenmcnaughton and @Ejegg to see if we can get a good estimate on how high up w... [21:59:11] ^^ eileen: ejegg: do you have an opinion on how high to bump that value? 2k wasn't enough for the 59 gift batch. [22:00:30] not knowing the data, my guess would be to go large and then possibly back it down when the import is done. [22:02:46] dwisehaupt: yeah - so I guess the calculation is number of rows * number of fields - it looks like 59 rows was over 1000 - so I guess that's like nearly 200 rows per field - which seems higher than I would expect but I guess some fields (e.g receive_date) have a date & a time field - it's like 'how many columns are in a spreadsheet' [22:05:19] Hype eileen !!!! [22:05:27] :-) [22:06:41] yeah, it was over 2000 since i bumped to there and she still got the error. [22:07:11] if this isn't something done often, perhaps we bump it to 4k, try and if it works then bump it back down and let her know. [22:11:21] I think the goal is to do it ften [22:11:22] (03Merged) 10jenkins-bot: Use gateway name, not confusing thing (submod_prefix) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056042 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:12:08] the idea is that there is a flow where they enter data in a spreadsheet & import it but they want to enter the data directly into a civicrm batch - which is a spreadsheet-like interface [22:12:46] it MIGHT be possible to bump from within php for that process (I just have to to check that we can increase from php & how we would pick up that context) [22:14:19] ok. well, i'll bump to 4k for now. this is a bit like the URL length that we had to keep bumping up. [22:14:20] (03Merged) 10jenkins-bot: Remove handling for charlimit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056043 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [22:18:05] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10008924 (10Dwisehaupt) @MDemosWMF I have doubled the limit. Please try the import again. ` 884d4f03 Bump php max_input_vars = 4000 on civicrm and frdev ` [22:25:33] (03PS10) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [22:25:33] (03PS1) 10Eileen: Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [22:36:37] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install fransw200[1-3].frack.codfw.wmnet - https://phabricator.wikimedia.org/T367800#10008969 (10Jhancock.wm) [22:38:57] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frqueue2003, pay-lb2001, pay-lb2002 - https://phabricator.wikimedia.org/T369566#10008973 (10Jhancock.wm) [22:43:21] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [22:46:39] (03CR) 10CI reject: [V:04-1] Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen) [23:03:33] (03PS4) 10Eileen: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) [23:03:33] (03PS4) 10Eileen: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) [23:03:33] (03PS2) 10Eileen: Do not implement transactionalInterface in MergeTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056074 (https://phabricator.wikimedia.org/T370371) [23:03:34] (03PS2) 10Eileen: Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [23:03:35] (03PS11) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [23:03:36] (03PS1) 10Eileen: Fix fidelity test to fully delete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056262 [23:09:12] (03CR) 10Ejegg: [C:04-1] "Shoot, I think we don't want to log a whole line for each character we output during the parse_recon_file loop. That would just be endless" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [23:10:43] ejegg: thanks for that comment - I got the feeling from cstone that maybe logging those characters doesn't add much value - how do you see it's value [23:11:36] it's a way to see what the mix of transaction types is for a given file. So we could replace it with a line for each type present plus a count [23:12:00] i don't think we've ever cared about the position in the file [23:12:02] ejegg: hmm so right at the end? We would just log a summary? [23:12:17] yeah, just log the summary at the end of each file parse [23:12:54] ok - I'll take a look - if you are not totally over review this & a couple above it could be rebased out of the chain https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1056047/2 [23:13:11] gonna get some dinner, then I can review some more [23:13:21] see ya again soon [23:15:42] (03PS3) 10Eileen: Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [23:15:43] (03PS12) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [23:16:48] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1056265 [23:18:18] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1056265 (owner: 10Eileen) [23:22:02] (03CR) 10CI reject: [V:04-1] Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen) [23:22:20] (03PS3) 10Eileen: Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675) [23:22:20] (03PS2) 10Eileen: Fold DAO-to-list back into callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056051 [23:22:20] (03PS2) 10Eileen: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056052 (https://phabricator.wikimedia.org/T270675) [23:22:20] (03PS6) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [23:22:21] (03PS3) 10Eileen: Switch to using \Civi::log() for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056044 (https://phabricator.wikimedia.org/T270675) [23:22:23] (03PS3) 10Eileen: Remove now-unused audit_runtime [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056046 (https://phabricator.wikimedia.org/T270675) [23:22:27] (03PS4) 10Eileen: Call WMFAudit::parse from within drush [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056054 (https://phabricator.wikimedia.org/T270675) [23:22:31] (03PS4) 10Eileen: Stop enabling wmf_audit sub-modules [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056055 (https://phabricator.wikimedia.org/T270675) [23:23:13] !log civicrm upgraded from 4247715d to c656ab2f [23:23:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:25:29] (03PS2) 10Eileen: Fix fidelity test to fully delete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056262 [23:25:29] (03PS5) 10Eileen: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) [23:25:29] (03PS5) 10Eileen: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) [23:25:30] (03PS3) 10Eileen: Do not implement transactionalInterface in MergeTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056074 (https://phabricator.wikimedia.org/T370371) [23:25:31] (03PS4) 10Eileen: Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [23:25:32] (03PS13) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [23:26:16] (03PS14) 10Jdlrobson: Introduce the Donate skin [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020408 (https://phabricator.wikimedia.org/T257862) [23:31:30] (03PS4) 10Jdlrobson: POC: Potential styles [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1020409 (https://phabricator.wikimedia.org/T257862) [23:34:41] (03CR) 10CI reject: [V:04-1] Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen) [23:43:57] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [23:44:55] (03CR) 10CI reject: [V:04-1] Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen)