[00:22:33] eileen: delayed resposne to the audit visual output ive never used it for anything and would be okay with it being gone [00:24:49] cstone: ok thanks [00:27:20] unrelated question eileen we have to collect address info for india now and they have a different address structure mainly street/number I was looking at putting number in Supplemental Address 1 and it doesnt seem to be for one specific thing, does that make sense to you [00:28:31] hmm so it looks like their address would look like Street: 7, 7, Narnarayan Palace, Ellisbridge [00:30:24] I was thinking I could ping a civi dev who works in India to see what they do - but it is 6am there now [00:31:32] right now we arent saving any addresses at all [00:34:14] hmm actually it looks like we are but where are they coming from hmm [00:47:26] :-) [01:43:37] (03CR) 10Ejegg: [C:03+2] Fix fidelity test to fully delete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056262 (owner: 10Eileen) [01:44:00] (03CR) 10Ejegg: [C:03+2] Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [01:45:24] (03CR) 10Ejegg: [C:03+2] Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [01:45:35] (03CR) 10Ejegg: [C:03+2] Do not implement transactionalInterface in MergeTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056074 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [01:47:53] (03PS1) 10Eileen: Only log summary, not characters per record, for negative audit transations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056269 [01:47:54] (03PS1) 10Eileen: Minor clean up on the parseReconciliationFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056270 [01:47:54] (03PS1) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [01:48:31] ejegg: thanks [01:48:52] I consolidated the helpers to the bottom of the chain https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1056047 & am fighting the logging at the top :-) [01:53:01] (03PS2) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [01:55:13] (03PS3) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [01:55:16] yep, looking at that rebased chain now! [02:00:04] (03PS4) 10Eileen: Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675) [02:00:32] (03CR) 10Ejegg: [C:03+2] Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:01:21] (03PS3) 10Eileen: Fold DAO-to-list back into callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056051 [02:01:28] (03CR) 10Ejegg: [C:03+2] Fold DAO-to-list back into callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056051 (owner: 10Eileen) [02:02:54] (03Merged) 10jenkins-bot: Fix fidelity test to fully delete [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056262 (owner: 10Eileen) [02:03:03] (03Merged) 10jenkins-bot: Do not implement transational interface on BaseQueueTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056064 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [02:03:28] (03PS3) 10Eileen: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056052 (https://phabricator.wikimedia.org/T270675) [02:03:47] (03Merged) 10jenkins-bot: Minor modernization on extension test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056063 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [02:04:05] (03CR) 10Ejegg: [C:03+2] Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056052 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:05:27] (03Merged) 10jenkins-bot: Do not implement transactionalInterface in MergeTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056074 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [02:06:03] ejegg: I'm heading out for a bit - I had a go at the logging & would def love feedback if you get to it but will kick the tyres on it again in 1.5-2 hours [02:08:58] (03CR) 10CI reject: [V:04-1] Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:16:21] (03CR) 10CI reject: [V:04-1] Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:17:18] (03CR) 10Ejegg: "we occasionally use run_all to try to clear out a ton of accumulated files - it's getting into the code via $this->get_runtime_options('ru" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:18:44] (03Merged) 10jenkins-bot: Consolidate helper functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056047 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:19:44] (03PS2) 10Eileen: Only log summary, not characters per record, for negative audit transations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056269 [02:19:52] (03CR) 10Ejegg: [C:03+2] Only log summary, not characters per record, for negative audit transations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056269 (owner: 10Eileen) [02:20:43] (03Merged) 10jenkins-bot: Fold DAO-to-list back into callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056051 (owner: 10Eileen) [02:20:48] ejegg: have you been in the dlocal test console recently [02:21:59] (03Merged) 10jenkins-bot: Fold function back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056052 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:25:02] no cstone, why? [02:25:33] not seeing any test transactions [02:25:46] it just let me do a bunch of api calls but then nothing in the console [02:35:19] (03PS3) 10Cstone: Add in street_number field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) [02:36:14] (03CR) 10Ejegg: "Looks pretty good at first glance. I'm a bit attached to seeing the mix of different payment methods in the files, if it wouldn't be too t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [02:36:30] ^ that adds the input field for street_number which is already setup in smashpig so don't need to change any code there and we are already sending the description, and as of now civi just wont get the extra data [02:37:59] (03Merged) 10jenkins-bot: Only log summary, not characters per record, for negative audit transations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056269 (owner: 10Eileen) [02:40:31] looking cstone [02:41:11] trying to understand why the id on the input needs to be street_address_1 if the name is street_address [02:41:19] i mean the name is street_number [02:41:26] oh is that something i missed with the copypasta [02:42:17] shoot, I've got to get to bed. Will look more in the morning! [02:42:39] no worries ejegg|away thanks! [02:43:52] (03PS4) 10Cstone: Add in street_number field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) [02:44:04] yeah i messed up renaming when i switched it back [02:47:56] ohhh we already had a lot of the boilerplate there for street_number, like the var_map entry and the bit in the transactions array [05:05:41] (03PS7) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [05:05:41] (03PS2) 10Eileen: Minor clean up on the parseReconciliationFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056270 [05:05:41] (03PS4) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [05:05:41] (03PS1) 10Eileen: Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 [05:09:12] (03CR) 10Eileen: "I had a go at replacing it with fileLimit - in order to make it work with the existing use of defaults being different for FundraiseUp I w" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:19:04] (03PS1) 10Eileen: Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 [05:22:04] (03PS1) 10Eileen: Minor standardisations in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056276 (https://phabricator.wikimedia.org/T370371) [05:24:04] (03CR) 10CI reject: [V:04-1] Minor clean up on the parseReconciliationFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056270 (owner: 10Eileen) [05:24:11] (03CR) 10CI reject: [V:04-1] Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:24:24] (03CR) 10CI reject: [V:04-1] Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [05:24:28] (03CR) 10CI reject: [V:04-1] Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 (owner: 10Eileen) [05:27:00] (03PS1) 10Eileen: Ensure values are correctly typed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056277 [05:33:03] (03PS1) 10Eileen: Move maxContributionID, maxContactID to our test trait [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056278 [05:37:35] (03CR) 10CI reject: [V:04-1] Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 (owner: 10Eileen) [05:38:37] (03PS5) 10Eileen: Add code to help get rid of audit-created contacts. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [05:39:35] (03PS14) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [05:47:19] (03PS8) 10Eileen: Add WMFAudit.parse function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056053 (https://phabricator.wikimedia.org/T270675) [05:47:19] (03PS3) 10Eileen: Minor clean up on the parseReconciliationFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056270 [05:47:20] (03PS5) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [05:47:20] (03PS2) 10Eileen: Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 [05:47:21] (03PS2) 10Eileen: Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 [05:57:56] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [06:06:37] (03CR) 10CI reject: [V:04-1] Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 (owner: 10Eileen) [06:11:36] (03PS1) 10Eileen: Can we catch it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056320 [06:25:59] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [06:26:22] (03CR) 10CI reject: [V:04-1] Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen) [06:26:25] (03CR) 10CI reject: [V:04-1] Remove unnecessary setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056280 (owner: 10Eileen) [06:29:55] (03CR) 10CI reject: [V:04-1] Can we catch it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056320 (owner: 10Eileen) [06:39:42] (03PS7) 10Eileen: Slight improvement in test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 [06:39:42] (03PS2) 10Eileen: Remove unnecessary setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056280 [06:39:42] (03PS16) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [06:39:43] (03PS2) 10Eileen: Can we catch it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056320 [08:10:41] (03CR) 10CI reject: [V:04-1] Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) (owner: 10Eileen) [08:11:34] (03CR) 10CI reject: [V:04-1] Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 (owner: 10Eileen) [08:12:17] (03CR) 10CI reject: [V:04-1] Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 (owner: 10Eileen) [08:15:32] (03PS3) 10Eileen: Remove unnecessary setup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056280 [08:15:32] (03PS17) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [08:15:32] (03PS1) 10Eileen: Do not use transactional interface in geocode [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056443 [08:22:08] (03PS8) 10Eileen: Replace a chunk of single character outputs with summary text [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056271 (https://phabricator.wikimedia.org/T270675) [08:22:08] (03PS5) 10Eileen: Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 [08:22:09] (03PS5) 10Eileen: Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 [08:25:27] (03PS1) 10Eileen: Remove single char output in making section [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056444 [08:37:14] (03PS6) 10Eileen: Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 [08:37:14] (03PS6) 10Eileen: Replace count construct with for-each [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056275 [08:37:14] (03PS2) 10Eileen: Remove single char output in making section [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056444 [08:37:15] (03PS1) 10Eileen: stop stray contact being left in fundraise audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056446 [08:37:30] (03CR) 10CI reject: [V:04-1] Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [08:41:54] (03CR) 10CI reject: [V:04-1] Remove grumble [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056274 (owner: 10Eileen) [08:46:14] (03CR) 10CI reject: [V:04-1] Remove single char output in making section [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056444 (owner: 10Eileen) [09:40:56] (03PS18) 10Eileen: Add test listener to make test clean up more consistent [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1054971 (https://phabricator.wikimedia.org/T370371) [09:40:56] (03PS2) 10Eileen: stop stray contact being left in fundraise audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056446 [09:40:56] (03PS1) 10Eileen: Remove transactional from OmniMail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056453 [09:40:57] (03PS1) 10Eileen: Mousify Christine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056454 [09:40:58] (03PS1) 10Eileen: Ensure very unique gets deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056455 [11:00:18] (03CR) 10Jgleeson: Setup Gravy webhook listener (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) (owner: 10Damilare Adedoyin) [11:01:48] (03Abandoned) 10Jgleeson: Update tearDown in tests to work with PHP 8.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055304 (owner: 10Jgleeson) [11:08:43] wb jgleeson and thanks for the review on the listener patch. I'd be moving it out of "Ready for review" because of some suggestions ejegg brought up during standup yesterday. [11:09:14] np damilare thanks for the heads up it was just ome drive-by review [11:09:32] good to see that our experimental validator is serving a good purpose [11:09:33] awesoem [11:09:48] yep it is, good to have that one class that fits the purpose [11:09:57] 100% [11:17:52] (03PS6) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [11:17:59] (03PS7) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:13:37] (03PS1) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056525 (https://phabricator.wikimedia.org/T368039) [15:15:50] (03PS1) 10Jgleeson: Map gravy buyer ID to external_idetifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) [15:16:14] (03PS2) 10Jgleeson: Map gravy buyer ID to external_identifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) [15:17:34] (03PS1) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056528 (https://phabricator.wikimedia.org/T368039) [15:17:56] (03PS3) 10Jgleeson: Map gravy buyer ID to external_identifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) [15:20:29] (03CR) 10CI reject: [V:04-1] Map gravy buyer ID to external_identifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) (owner: 10Jgleeson) [15:22:27] (03PS1) 10Jgleeson: Add convenience script for civicrm container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1056529 (https://phabricator.wikimedia.org/T368039) [15:29:09] (03PS8) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:29:32] (03CR) 10CI reject: [V:04-1] Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) (owner: 10Damilare Adedoyin) [15:31:05] (03PS1) 10Damilare Adedoyin: WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:31:33] (03CR) 10CI reject: [V:04-1] WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:32:06] ok time to write that patch to preserve coding styles after a fresh install for payments [15:32:26] super annoying when it's done and lost [15:33:32] (03PS4) 10Jgleeson: Map gravy buyer ID to external_identifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) [15:34:34] 14Fundraising Sprint: meow(), 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Create jobs for the events pushed to the jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10011132 (10Damilare) [15:36:43] (03PS2) 10Damilare Adedoyin: WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:37:09] (03CR) 10CI reject: [V:04-1] WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:38:11] (03PS3) 10Damilare Adedoyin: WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:38:36] (03CR) 10CI reject: [V:04-1] WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:40:39] (03PS4) 10Damilare Adedoyin: WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:40:58] (03PS1) 10Jgleeson: Preserve .idea config during reclones for Payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1056536 [15:41:54] (03PS2) 10Jgleeson: Preserve .idea config during reclones for Payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1056536 [15:46:26] this is reminding me to add a unit test to that crm patch https://www.bbc.co.uk/news/articles/ce58p0048r0o [15:47:59] (03PS9) 10Damilare Adedoyin: Setup Gravy webhook listener [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1055981 (https://phabricator.wikimedia.org/T367807) [15:48:43] (03PS5) 10Damilare Adedoyin: WIP [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:56:05] (03Abandoned) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056525 (https://phabricator.wikimedia.org/T368039) (owner: 10Jgleeson) [15:56:46] (03PS2) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056528 (https://phabricator.wikimedia.org/T368039) [17:07:15] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frqueue2003, pay-lb2001, pay-lb2002 - https://phabricator.wikimedia.org/T369566#10011817 (10Jhancock.wm) a:05Jhancock.wm→03Papaul These are ready for you. frqueue2003 ETH0 <-> FASW-C8A eth-0/0/32 ETH1 <-> FASW-C8B eth-1/0/32... [17:12:31] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad: Q1:rack/setup/install frban1002 - https://phabricator.wikimedia.org/T369947#10011888 (10RobH) a:03Dwisehaupt @Dwisehaupt, The fundraising hosts follow a different workflow than normal hosts, in that we typically don't reimage them and hand them off to your te... [17:17:11] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad: Q1:rack/setup/install fran1002 - https://phabricator.wikimedia.org/T369940#10011920 (10RobH) a:03Dwisehaupt @Dwisehaupt, The fundraising hosts follow a different workflow than normal hosts, in that we typically don't reimage them and hand them off to your tea... [17:17:27] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad: Q1:rack/setup/install frdb1007 - https://phabricator.wikimedia.org/T369922#10011925 (10RobH) a:03Dwisehaupt @Dwisehaupt, The fundraising hosts follow a different workflow than normal hosts, in that we typically don't reimage them and hand them off to your tea... [17:25:26] (03PS1) 10Ejegg: Put Number on same line as Street [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056568 (https://phabricator.wikimedia.org/T370583) [17:25:48] cstone: I tried out a thing to put the two street fields on the same line ^^^ [17:35:49] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install fransw200[1-3].frack.codfw.wmnet - https://phabricator.wikimedia.org/T367800#10012024 (10Jhancock.wm) a:05Jhancock.wm→03Papaul @Papaul these are ready for your part. fransw2001 ETH0 <-> FASW-C8A eth-0/0/29 ETH1 <-> FASW-C8B e... [17:36:52] (03PS5) 10Cstone: Add in street_number field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) [17:37:45] (03CR) 10Ejegg: [C:03+2] "This works! We might want to do something in a follow-on patch to clarify the 'Number' label so people don't enter other numbers." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) (owner: 10Cstone) [17:39:34] (03Merged) 10jenkins-bot: Add in street_number field and update the India form fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056037 (https://phabricator.wikimedia.org/T370583) (owner: 10Cstone) [18:14:14] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-Civi-Dedupe: Consider phonetic names when deduping - https://phabricator.wikimedia.org/T362196#10012187 (10AKanji-WMF) Reviewed with Dylan and decided it would be a "nice to address" in a deduping sprint [18:16:41] 06Fundraising-Backlog, 10FR-donorservices: PDF Civi receipts - feature request - https://phabricator.wikimedia.org/T368671#10012200 (10AKanji-WMF) * Stretch goal for Q2 quiet storm period [18:19:10] 06Fundraising-Backlog, 10FR-donorservices: Donation history in a single email feature request - https://phabricator.wikimedia.org/T368668#10012206 (10AKanji-WMF) * Adding in as stretch for Q2 "quiet storm" period [18:21:20] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Donate Wiki Support Page Pageviews - https://phabricator.wikimedia.org/T367460#10012222 (10AKanji-WMF) @JMando could we please set up a call to talk about next steps and timelines for this? [18:27:39] 06Fundraising-Backlog: Scoping: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#10012239 (10AKanji-WMF) @MSuijkerbuijk_WMF resurfacing! let me know if you'd like me to set up a quick call. [18:28:49] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog: Create new Benevity import - https://phabricator.wikimedia.org/T359219#10012253 (10AKanji-WMF) Leaving this task in the queue for "next" right now; several other imports are currently higher in priority. [18:39:02] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Data-Platform, 10FR-Tech-Analytics: Allow Fundraising Supserset to connect to Production Druid - https://phabricator.wikimedia.org/T370944 (10Dwisehaupt) 03NEW p:05Triage→03Medium [18:42:39] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Consider population address source fields - https://phabricator.wikimedia.org/T364700#10012342 (10AKanji-WMF) @Eileenmcnaughton is there more we need to do on this task? [18:43:26] (03PS1) 10Eileen: Fix PrimaryLocationTest to not use transactional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056583 [18:43:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Splitting Organization Contacts in Civi that are Workplace Giving and Restricted Funds - https://phabricator.wikimedia.org/T364978#10012364 (10AKanji-WMF) have added this request to a broader [[ https://docs.google.com/spreadsheets/d/1-AmcEuSXVcfa_VrNHOVD... [18:44:45] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Consider population address source fields - https://phabricator.wikimedia.org/T364700#10012371 (10Eileenmcnaughton) I think it would be good to look at in a tech-talk - we can add some useful information from our queues (e.g if an address came from the do... [18:44:58] (03Abandoned) 10Eileen: Can we catch it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056320 (owner: 10Eileen) [18:47:37] 06Fundraising-Backlog, 10FR-Email: Export last payment method to Acoustic - https://phabricator.wikimedia.org/T369765#10012405 (10AKanji-WMF) I don't know if this is a dependency, but would still love to get clarity on my question in the parent of this task: > Hi Team - the intention for the "both_funds_lat... [18:50:48] ejegg: yeah i full lined it because i couldn't tell how much someone was going to type in each field [18:50:58] all the example addresses i found were really long [18:50:59] 06Fundraising-Backlog: Update app submit payment endpoint to handle wmf_ and utm_ fields - https://phabricator.wikimedia.org/T367916#10012413 (10AKanji-WMF) Bringing to triage to add context. [18:51:08] So I just ran the whole test suite after my various fixes to the tests & by the end of it the only extra contacts I have now if 4 * Adam Ant & one Daisy Duck [19:00:21] (03PS2) 10Eileen: Fix DataCheck tests to not use transactional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056583 [19:12:04] 06Fundraising-Backlog, 10FR-Email: Export last payment method to Acoustic - https://phabricator.wikimedia.org/T369765#10012490 (10MSuijkerbuijk_WMF) Hi @AKanji-WMF, Apologies I missed this ping. I agree with grouping if @EMartin considers it's a good approach and the team doesn't foresee issues with this opt... [19:13:10] (03PS1) 10Eileen: Fix exceptions in a few places [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056588 [19:28:14] (03CR) 10Eileen: [C:03+2] Try a different listener for slow tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055301 (owner: 10Ejegg) [19:40:13] (03PS1) 10Eileen: Put Minnie on strike [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056593 [19:43:42] (03CR) 10Cstone: [C:03+2] Mousify Christine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056454 (owner: 10Eileen) [19:45:35] (03PS3) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056528 (https://phabricator.wikimedia.org/T368039) [19:45:37] (03PS1) 10Jgleeson: Update deprecated variables in strings to quiet down PHP 8.2 warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056594 (https://phabricator.wikimedia.org/T368039) [19:46:29] eileen: here's another local test fix https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1056594 [19:49:21] (03Merged) 10jenkins-bot: Try a different listener for slow tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1055301 (owner: 10Ejegg) [19:51:12] (03PS4) 10Jgleeson: Add Gravy ID to external identifiers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056528 (https://phabricator.wikimedia.org/T368039) [19:54:13] (03PS6) 10Jgleeson: WIP: Add CiviCRM Standalone [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1039235 [19:58:13] (03PS5) 10Jgleeson: Map gravy buyer ID to external_identifier queue message field. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056527 (https://phabricator.wikimedia.org/T368039) [19:58:44] (03PS1) 10Eileen: Remove extraneous command output [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056596 [20:17:35] (03PS2) 10Eileen: Move Address insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056008 (https://phabricator.wikimedia.org/T365415) [20:17:38] (03CR) 10Ejegg: [C:03+2] Move Address insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056008 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:17:58] (03PS4) 10Eileen: Move retrieval of PaymentToken data to the message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) [20:18:05] (03CR) 10Ejegg: [C:03+2] Move retrieval of PaymentToken data to the message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:18:27] 06Fundraising-Backlog, 10fundraising-tech-ops: Rename fundraise-up audit directory to fundraiseup - https://phabricator.wikimedia.org/T370307#10012709 (10Dwisehaupt) Cleaned up the old copies of the audit data by removing: * /var/spool/audit/fundraise-up * /srv/archive/civi/audit/fundraise-up [20:19:13] (03PS2) 10Eileen: Mousify Christine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056454 [20:20:13] (03PS1) 10Eileen: Add phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056599 (https://phabricator.wikimedia.org/T370371) [20:22:19] (03PS2) 10Eileen: Add phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056599 (https://phabricator.wikimedia.org/T370371) [20:22:23] (03CR) 10Ejegg: [C:03+2] Add phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056599 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [20:39:30] (03Merged) 10jenkins-bot: Move Address insert to only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056008 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:39:32] (03Merged) 10jenkins-bot: Move retrieval of PaymentToken data to the message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1051484 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [20:41:46] (03Merged) 10jenkins-bot: Add phpunit printer option 3 clagiordano [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056599 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [20:44:12] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10012809 (10MDemosWMF) @Dwisehaupt Looks like it works now! I tested it with 100 which looks like that's been around our max in the past. [21:00:06] 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10012839 (10Dwisehaupt) Wonderful. Thanks! [21:00:44] 03Fundraising Sprint: neveruse(), 06Fundraising-Backlog, 10fundraising-tech-ops: Batch data entry - batch size limit - https://phabricator.wikimedia.org/T370642#10012841 (10Dwisehaupt) [21:02:40] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frdb1007 - https://phabricator.wikimedia.org/T369922#10012861 (10Dwisehaupt) [21:05:38] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frdb1007 - https://phabricator.wikimedia.org/T369922#10012862 (10Dwisehaupt) a:05Dwisehaupt→03None @RobH Correct. That is our assumption. Once the host is racked, cabled, and all the basic provisioning of the hardware is comple... [21:05:40] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frban1002 - https://phabricator.wikimedia.org/T369947#10012865 (10Dwisehaupt) [21:05:57] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install fran1002 - https://phabricator.wikimedia.org/T369940#10012866 (10Dwisehaupt) [21:06:43] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frban1002 - https://phabricator.wikimedia.org/T369947#10012867 (10Dwisehaupt) a:05Dwisehaupt→03None @RobH Correct. That is our assumption. Once the host is racked, cabled, and all the basic provisioning of the hardware is compl... [21:07:32] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install fran1002 - https://phabricator.wikimedia.org/T369940#10012870 (10Dwisehaupt) a:05Dwisehaupt→03None @RobH Correct. That is our assumption. Once the host is racked, cabled, and all the basic provisioning of the hardware is comple... [21:29:54] 10fundraising-tech-ops: Add a TXT record to the Yahoo sending domain - https://phabricator.wikimedia.org/T370963 (10nisrael) 03NEW [21:36:54] (03PS2) 10Eileen: Minor standardisations in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056276 (https://phabricator.wikimedia.org/T370371) [21:36:59] (03CR) 10Ejegg: [C:03+2] Minor standardisations in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056276 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [21:55:59] (03Merged) 10jenkins-bot: Minor standardisations in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056276 (https://phabricator.wikimedia.org/T370371) (owner: 10Eileen) [21:58:22] (03PS1) 10Eileen: Copy wmf_civicrm.module address functions to ChecksFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056607 [21:58:22] (03PS1) 10Eileen: Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 [22:12:19] ok, queues look pretty quiet [22:12:23] (03PS2) 10Eileen: Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 [22:12:24] (03PS1) 10Eileen: Do not call mark_refund from Audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056610 [22:13:10] I'm going to turn off the jobs-adyen queue for a bit, update the SmashPig code at frpig, then get it to the end of the old messages [22:15:31] (03CR) 10CI reject: [V:04-1] Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 (owner: 10Eileen) [22:17:10] (03CR) 10Eileen: [V:03+2] Mousify Christine [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056454 (owner: 10Eileen) [22:19:51] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1056612 [22:19:54] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1056612 (owner: 10Ejegg) [22:20:16] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1056612 (owner: 10Ejegg) [22:30:55] (03CR) 10CI reject: [V:04-1] Do not call mark_refund from Audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056610 (owner: 10Eileen) [22:32:09] (03CR) 10CI reject: [V:04-1] Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 (owner: 10Eileen) [22:33:05] !log disabled Adyen job runner [22:33:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:34:03] !log SmashPig upgraded from f2aca230 to 1b2d9a6e on frpig2001 only [22:34:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:34:37] !log SmashPig upgraded from f2aca230 to 1b2d9a6e on frpig1002 only [22:34:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:37:39] hmm, is QueuePeek not working? or are those queues still really empty? [22:37:45] let's use redis-cli [22:40:01] ok, cool, i got lucky. No more of the old messages in the queue [22:40:29] and QueuePeek IS working, for the record [22:41:25] !log SmashPig upgraded from f2aca230 to 1b2d9a6e across all frack servers [22:41:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:42:31] !log re-enabled Adyen job runner [22:42:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:42:51] no whammy no whammy no whammy... [22:59:00] (03PS2) 10Eileen: Ensure values are correctly typed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056277 [22:59:02] (03CR) 10Ejegg: [C:03+2] Ensure values are correctly typed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056277 (owner: 10Eileen) [23:02:15] (03CR) 10Ejegg: "Just curious about the setActiveMailer removal" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056278 (owner: 10Eileen) [23:04:02] (03CR) 10Eileen: Move maxContributionID, maxContactID to our test trait (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056278 (owner: 10Eileen) [23:04:47] (03CR) 10Eileen: "it's not really more standard now - cos that part is no longer in the patch :-)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056260 (owner: 10Eileen) [23:08:33] Is it reasonable to feel extremely proud of myself cos I thought of a new Mouse name - I mean I'd like to think some work I've done this week would give me that but no - the only time I've felt proud of my efforts this week was just now.... Maisy [23:08:57] but WTF smash pig SmashPig\Core\ConfigurationKeyException : Configuration key 'data-store/maisy' does not exist. [23:10:34] (03PS2) 10Eileen: Do not call mark_refund from Audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056610 [23:10:34] (03PS3) 10Eileen: Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 (https://phabricator.wikimedia.org/T365415) [23:10:34] (03PS1) 10Eileen: Fix refundTest to test via queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056616 (https://phabricator.wikimedia.org/T365415) [23:10:36] (03PS1) 10Eileen: Long live Maisy (update WMF Donor Refund test to go via queue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056617 (https://phabricator.wikimedia.org/T365415) [23:17:58] (03Merged) 10jenkins-bot: Ensure values are correctly typed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056277 (owner: 10Eileen) [23:29:36] (03CR) 10CI reject: [V:04-1] Do not call mark_refund from Audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056610 (owner: 10Eileen) [23:29:54] (03CR) 10CI reject: [V:04-1] Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [23:30:10] (03CR) 10CI reject: [V:04-1] Long live Maisy (update WMF Donor Refund test to go via queue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056617 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [23:30:32] omg Maisy crashed & burned [23:30:48] (03CR) 10CI reject: [V:04-1] Fix refundTest to test via queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056616 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen) [23:33:52] (03PS3) 10Eileen: Do not call mark_refund from Audit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056610 [23:33:52] (03PS4) 10Eileen: Move remaining address update functions from wmf_civicrm to WMFContact::Save [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056608 (https://phabricator.wikimedia.org/T365415) [23:33:52] (03PS2) 10Eileen: Fix refundTest to test via queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056616 (https://phabricator.wikimedia.org/T365415) [23:33:53] (03PS2) 10Eileen: Long live Maisy (update WMF Donor Refund test to go via queue) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056617 (https://phabricator.wikimedia.org/T365415) [23:33:54] (03PS1) 10Eileen: Switch remining refund tests to use RefundQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056620 [23:33:56] (03PS1) 10Eileen: Remove deprecated function calls from RefundTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056621 (https://phabricator.wikimedia.org/T365415) [23:54:17] (03CR) 10CI reject: [V:04-1] Switch remining refund tests to use RefundQueue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056620 (owner: 10Eileen) [23:57:49] (03CR) 10CI reject: [V:04-1] Remove deprecated function calls from RefundTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1056621 (https://phabricator.wikimedia.org/T365415) (owner: 10Eileen)