[00:01:33] ejegg: I'm having trouble replicating that issue you found on deduper - I am seeing 4 emails afterwards [00:02:17] oh weird [00:02:38] shall I share my screen [00:02:43] ? [00:04:39] are you testing on wmff or dmaster? [00:16:43] on wmff [00:17:17] I was just trying to figure out a reproducible way to do it - https://gist.github.com/eileenmcnaughton/adbb175ee8ae44e4dce917373dcb795e [00:18:35] sorry, i didn't include the is_primary info [00:18:50] let me paste some rows from the log table [00:18:56] actually that one might have worked [00:20:16] - I could add screen shots with the gist [00:20:26] https://phabricator.wikimedia.org/P67403 [00:20:52] so contact_id 207 is the one to keep [00:21:02] and 220 is the one to delete [00:21:52] all the log lines at 2024-08-20 14:03:00 are what happened during the merge [00:22:38] let me reproduce [00:22:57] it locally with those cv commands [00:24:14] ejegg: side thing - can you merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1064130 [00:24:35] sure [00:24:52] (03CR) 10Ejegg: [C:03+2] Add last_name,first_name index [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064130 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [00:24:54] looks fine [00:25:02] thanks [00:31:30] huh, with the bobs I get two billing emails [00:31:56] oh dang, I was on a different patch [00:32:01] switching back to yours [00:34:24] so this should re-create it - but it passes locally https://github.com/eileenmcnaughton/deduper/pull/55 [00:37:24] well dang, the bobs merge as expected now for me [00:37:28] (03PS1) 10Eileen: wip - what do tests do with full upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064138 [00:37:40] those pesky bobs [00:37:45] let me see if the log table looks any different from jimmy [00:40:54] (03CR) 10CI reject: [V:04-1] wip - what do tests do with full upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064138 (owner: 10Eileen) [00:44:07] ok. i need to feed and walk the dog, then feed and not walk the kids. i can check back in later if anything is needed for the index patch. [00:44:37] if you need me more urgently, hit me up via sms/signal/whatsapp/slack/etc [00:44:56] well, the email logs look identical as far as the setup goes - just with jwales I got one updated to location_type_id=7 and with the bobs no type change [00:45:28] (03Merged) 10jenkins-bot: Add last_name,first_name index [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064130 (https://phabricator.wikimedia.org/T353971) (owner: 10Eileen) [00:46:15] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064139 [00:47:29] only difference I can find is that in the initial setup the IDs were non-sequential [00:47:38] but I can't see how that would affect the code [00:47:53] (just contact_ids and primary email ids non-sequential) [00:47:55] (03PS2) 10Eileen: wip - what do tests do with full upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064138 [00:49:19] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064139 (owner: 10Eileen) [00:50:00] hmm - so you can still replicate it? [00:50:07] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064139 (owner: 10Eileen) [00:50:11] no, I haven't been able to again [00:50:30] I guess, let me try again with details created via donations [00:51:37] !log civicrm upgraded from 1022abf1 to 3b22c823 [00:51:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:58:08] ugh, can't replicate it with donors created via contribs either [00:59:23] hmm, i wonder if I reverted the merge I could replicate it with the original jimmys [00:59:42] ejegg: ok - I'm gonna keep trying things but maybe we should push it through for now? [00:59:57] oh - original jimmys! [00:59:59] yesh, it's a big improvement over prior crashiness! [01:00:23] yeah - also - if I DO fix it it will be a patch on top rather than a change to that patch [01:00:54] (03PS6) 10Eileen: Update deduper with fixes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1058727 (https://phabricator.wikimedia.org/T363965) [01:00:56] (03CR) 10Ejegg: [C:03+2] Update deduper with fixes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1058727 (https://phabricator.wikimedia.org/T363965) (owner: 10Eileen) [01:01:07] ok, I should help with home stuff. have a good rest of your day! [01:03:23] thanks ejegg|away [01:23:33] (03Merged) 10jenkins-bot: Update deduper with fixes merged upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1058727 (https://phabricator.wikimedia.org/T363965) (owner: 10Eileen) [01:27:46] !log config revision changed from f569b590 to 3ef2ec32 disable jobs to run index-add [01:27:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:56:05] !log config revision changed from 3ef2ec32 to b1b3a1e6 [01:56:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:08:38] (03PS2) 10Eileen: Add support for creating relationship on non-dupes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060526 (https://phabricator.wikimedia.org/T367234) [02:08:38] (03PS2) 10Eileen: Add default for our new setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060527 (https://phabricator.wikimedia.org/T367234) [02:08:38] (03PS1) 10Eileen: Improve cache-flush time out issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064144 [02:09:10] (03Abandoned) 10Eileen: wip - what do tests do with full upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064138 (owner: 10Eileen) [02:22:52] (03PS1) 10Eileen: Deduper test fixes (merged upstream) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064145 [02:23:20] (03CR) 10CI reject: [V:04-1] Deduper test fixes (merged upstream) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064145 (owner: 10Eileen) [02:26:36] (03PS3) 10Eileen: Add support for creating relationship on non-dupes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060526 (https://phabricator.wikimedia.org/T367234) [02:26:36] (03PS3) 10Eileen: Add default for our new setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060527 (https://phabricator.wikimedia.org/T367234) [02:26:36] (03PS2) 10Eileen: Improve cache-flush time out issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064144 [02:26:37] (03PS2) 10Eileen: Deduper test fixes (merged upstream) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064145 [02:27:43] (03CR) 10Cstone: "This looks good and is working for me, one error I was able to cause in redirect land:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [02:45:18] (03CR) 10Cstone: Gravy ACH (Trustly) (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [03:06:13] (03PS1) 10Eileen: Move our wmf tweaks to the deduper form to our own custom code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064147 [03:07:46] (03PS2) 10Eileen: Move our wmf tweaks to the deduper form to our own custom code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064147 [03:09:03] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, and 2 others: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10079991 (10Eileenmc... [03:09:59] (03PS3) 10Eileen: Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 [03:14:08] (03PS4) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [03:14:08] (03PS3) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [03:14:09] (03PS4) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [03:14:09] (03PS3) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [03:14:10] (03PS1) 10Eileen: Remove no longer used property in deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064148 [03:14:12] (03PS1) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [03:21:39] (03CR) 10CI reject: [V:04-1] Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [03:22:30] (03CR) 10CI reject: [V:04-1] Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 (owner: 10Eileen) [03:23:15] (03CR) 10CI reject: [V:04-1] Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [03:24:11] (03CR) 10CI reject: [V:04-1] Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [03:24:25] ok. end of maint day email sent. i'm headed out. [03:25:17] (03CR) 10CI reject: [V:04-1] Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [03:26:56] (03CR) 10CI reject: [V:04-1] Add in subset name resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1059523 (owner: 10Eileen) [03:31:20] (03PS2) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [03:31:20] (03PS5) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [03:31:20] (03PS4) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [03:31:21] (03PS5) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [03:31:22] (03PS4) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [03:39:44] (03PS1) 10Eileen: Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) [03:58:18] (03CR) 10CI reject: [V:04-1] Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [04:01:53] (03CR) 10CI reject: [V:04-1] Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) (owner: 10Eileen) [04:53:54] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 07recurring upgrade: Update text for recurring upgrade thank you email - https://phabricator.wikimedia.org/T371848#10080027 (10MSuijkerbuijk_WMF) @Ej... [05:17:14] (03PS3) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [05:17:14] (03PS6) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [05:17:14] (03PS5) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [05:17:15] (03PS6) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [05:17:16] (03PS5) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [05:17:17] (03PS2) 10Eileen: Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) [08:28:42] (03PS13) 10Damilare Adedoyin: Gravy ACH (Trustly) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) [08:32:08] (03CR) 10Damilare Adedoyin: "thanks cstone for the review, I've made the recommended changes. Please see responses inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [08:33:39] (03PS39) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [08:33:50] (03PS13) 10Damilare Adedoyin: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) [08:34:00] (03PS20) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [08:34:12] (03PS14) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [08:34:18] (03PS16) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [08:34:28] (03PS11) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [08:34:38] (03PS17) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [08:34:45] (03PS7) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [09:02:28] (03PS14) 10Damilare Adedoyin: Gravy ACH (Trustly) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) [09:03:28] (03PS40) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [09:03:28] (03PS21) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [09:03:28] (03PS15) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [09:03:28] (03PS17) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [09:03:30] (03PS12) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [09:03:32] (03PS18) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [09:03:36] (03PS8) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [09:03:49] (03PS14) 10Damilare Adedoyin: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) [09:05:31] (03CR) 10Damilare Adedoyin: "Thanks for the CR and for spotting that scenario, the issue has been fixed on the smashpig patch." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [11:51:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), and 2 others: Error: Call to a member function inNamespace() on null - https://phabricator.wikimedia.org/T372067#10080955 (10Aklapper) Adding FR-Tech team per https://w... [13:45:47] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, and 2 others: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10081349 (10SHust)... [13:54:28] (03CR) 10Ejegg: [C:03+2] "Looks safe, just one fix to a live bug and test and l10n updates." [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1061049 (https://phabricator.wikimedia.org/T372067) (owner: 10Jforrester) [13:58:11] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1061049 (https://phabricator.wikimedia.org/T372067) (owner: 10Jforrester) [14:30:49] 10fundraising-tech-ops, 06cloud-services-team, 10VPS-Projects, 10Puppet (Puppet 7.0): Update puppet civicrm-prototype puppetmaster - https://phabricator.wikimedia.org/T361595#10081625 (10Andrew) Hello! Can I get an update on this? [14:38:11] (03CR) 10Ejegg: [C:03+2] Add support for creating relationship on non-dupes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060526 (https://phabricator.wikimedia.org/T367234) (owner: 10Eileen) [14:38:40] (03CR) 10Ejegg: [C:03+2] Add default for our new setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060527 (https://phabricator.wikimedia.org/T367234) (owner: 10Eileen) [14:39:32] (03CR) 10Ejegg: [C:03+2] Improve cache-flush time out issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064144 (owner: 10Eileen) [14:58:25] (03Merged) 10jenkins-bot: Add support for creating relationship on non-dupes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060526 (https://phabricator.wikimedia.org/T367234) (owner: 10Eileen) [14:58:27] (03Merged) 10jenkins-bot: Add default for our new setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1060527 (https://phabricator.wikimedia.org/T367234) (owner: 10Eileen) [14:59:22] (03Merged) 10jenkins-bot: Improve cache-flush time out issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064144 (owner: 10Eileen) [15:15:32] (03CR) 10Jgleeson: Gravy ACH (Trustly) (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [15:17:14] (03CR) 10Jgleeson: Gravy ACH (Trustly) (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [15:27:08] (03CR) 10Jgleeson: [C:04-1] "Thanks Dami. I testing this out with a live IPN and left some feedback inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:27:24] (03CR) 10Jgleeson: [C:04-1] "tested*" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:40:21] (03PS1) 10Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1064400 [15:41:04] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1064400 (owner: 10Ejegg) [15:42:32] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1064400 (owner: 10Ejegg) [15:46:56] (03PS15) 10Damilare Adedoyin: Gravy ACH (Trustly) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) [15:49:50] (03CR) 10Damilare Adedoyin: "Thanks for the CR jgleeson, I've removed the comments you highlighted." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [15:50:04] (03PS41) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [15:50:04] (03PS22) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [15:50:04] (03PS16) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [15:50:04] (03PS18) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [15:50:06] (03PS13) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [15:50:10] (03PS19) 10Damilare Adedoyin: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) [15:50:14] (03PS9) 10Damilare Adedoyin: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 [15:56:18] !log fundraising python tools upgraded from 490a7b3f to 3f7b238d [15:56:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:01:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10082037 (10EMartin) I am tracking the drop off rate here: https://docs.google.com/spreadsheets/d/1H4o2P7NsdgGXOQZu0WPIb-tOBDJoNm9kSc8gYn... [16:12:37] (03PS42) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [16:13:06] (03CR) 10CI reject: [V:04-1] Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [16:16:42] (03PS43) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [16:24:11] (03PS23) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [16:25:28] (03PS17) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [16:31:15] (03PS24) 10Damilare Adedoyin: ProcessCaptureRequestJob for authorization messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1057937 (https://phabricator.wikimedia.org/T370797) [16:31:16] (03PS18) 10Damilare Adedoyin: Record capture job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1058580 (https://phabricator.wikimedia.org/T370797) [16:31:17] (03PS19) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [16:47:47] (03PS1) 10Ejegg: Stop using JsonSerializableObject in Autorescue test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064417 (https://phabricator.wikimedia.org/T366367) [16:48:21] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064417 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:48:45] :) speedy! [16:49:15] (03Merged) 10jenkins-bot: Stop using JsonSerializableObject in Autorescue test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064417 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [16:49:55] I was sniffing around some of the JSON instance stuff earlier so it was half on the radar :) [16:53:38] I keep getting gravy trustly IPNs for trxn with the status of authorization_failed. damilare do they continue to hit us until we acknowledge stuff? [16:54:18] yes they do jgleeson [16:55:20] hmm [16:55:30] with all trxns or just trustly? [16:55:59] all trxns, not just trustly [16:57:01] if you have the listener patch set up, it should acknowledge the message [16:58:08] I have the patch I reviewed earlier checked out [16:58:20] it shows some errors in log for trustly calls [16:58:39] but I was ignoring those for now [16:59:09] (03CR) 10Damilare Adedoyin: "Thanks for the review jgleeson, I've made all required changes." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [17:00:54] hmm I'd check that out, it shouldn't treat trustly messages any differently. [17:01:43] damilare: I see us fetch the trxn details but I can't see us acknowledging in the listener code. where is that happening? [17:01:59] I'm on this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1056531 [17:02:07] it might come later? [17:02:18] (03PS1) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [17:02:40] that happens in the calling code, smashpig core, after the listener completely resolves the message jgleeson [17:03:47] do you mean the http response code? [17:03:50] yes [17:03:57] or are we sending out a ack call [17:04:00] ah ok so just the 200 [17:04:05] yes [17:04:20] hmmm [17:04:33] so if they send us something that results in an error they just keep trying [17:04:38] that might not be ideal [17:06:07] let's comnfirm that on the call [17:08:08] jgleeson: I asked earlier here: https://wikimedia.slack.com/archives/C070F1DVBRN/p1721679776772589 [17:10:35] so currently we're throwing exceptions when we can't map the message or process it entirely which is creating an error loop [17:10:50] 2024-08-21T17:09:52+00:00 500855c61965 SmashPig: SPCID-0764037337 | Last chance error handler fired. (2) Undefined array key "description" @ /srv/smashpig/PaymentProviders/Gravy/Factories/GravyPaymentResponseFactory.php:31 | | [17:10:51] 2024-08-21T17:09:52+00:00 500855c61965 SmashPig: SPCID-0764037337 | Last chance error handler fired. (2) Undefined array key "code" @ /srv/smashpig/PaymentProviders/Gravy/Factories/GravyPaymentResponseFactory.php:31 | | [17:10:54] 2024-08-21T17:09:52+00:00 500855c61965 SmashPig: SPCID-0764037337 | (TransactionAction) Skipping unsuccessful transaction with transaction id | | [17:10:56] 2024-08-21T17:09:52+00:00 500855c61965 SmashPig: SPCID-0764037337 | Finished processing listener request | | [17:11:16] can you share the received message please? [17:12:34] damilare: https://phabricator.wikimedia.org/P67456 [17:12:40] tnx! [17:13:02] that's missing fields feel like an exception constructor [17:13:15] those [17:15:08] this raises a general question. in the scenario that we do hit an error we might want to throw exceptions/failmail on our end to log the issue but then send back a 200 to stop them resending it if it's gonna send us the same message every 30 seconds and jam up our logs. That won't scale well. [17:16:46] this one is also coming in but I think that'll go away if I pull down the later patches [17:16:48] 2024-08-21T15:47:36+00:00 [ERROR] Listener received unknown message type report-execution [17:17:49] woah [17:17:55] RSA sunsetting [17:25:39] 06Fundraising-Backlog: Scoping: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#10082450 (10MSuijkerbuijk_WMF) Hi @Cstone and @AKanji-WMF Do we have an update on this second email? I can help with the rules and edge cases. Could we agree on a timeline for this? Thanks! [17:30:46] (03PS44) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [17:31:32] jgleeson: the update should fix the issue you're currently experiencing [17:31:45] thanks will check it out [17:54:12] (03PS2) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [18:00:20] (03CR) 10CI reject: [V:04-1] Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) (owner: 10Ejegg) [18:00:46] (03PS16) 10Damilare Adedoyin: Gravy ACH (Trustly) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063208 (https://phabricator.wikimedia.org/T371810) [18:12:33] (03PS15) 10Damilare Adedoyin: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) [18:12:42] (03PS45) 10Damilare Adedoyin: Setup listener for transaction event message. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1056531 (https://phabricator.wikimedia.org/T370797) [18:19:23] jgleeson: should I change the code to OK all webhook messages [18:19:42] I'm thinking we should wait till they provide the dashboard [18:19:52] so we don't lose any info [18:24:36] We're ok for now but I think we might need it before the banner test in 2 weeks just in case the volume catches us out. Wwe could ticket it up for now and throw it into next sprint if you wanted to. [18:34:42] sure [18:53:38] (03PS3) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [18:53:38] (03PS1) 10Ejegg: Stop calling parent::__construct() in Amazon messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064448 (https://phabricator.wikimedia.org/T366367) [19:39:22] (03CR) 10Cstone: [C:03+2] "thanks looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063242 (https://phabricator.wikimedia.org/T371810) (owner: 10Damilare Adedoyin) [19:48:26] (03PS4) 10Eileen: Move support for full_name to the api layer (deduper extension) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064149 (https://phabricator.wikimedia.org/T370469) [19:48:26] (03PS7) 10Eileen: Upgrade references to 'special' org_contact_name to the actual apiv4 field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062770 (https://phabricator.wikimedia.org/T370469) [19:48:26] (03PS6) 10Eileen: Move a couple of tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062778 [19:48:26] (03PS7) 10Eileen: Fix custom field to be wrangled consistently on message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062777 (https://phabricator.wikimedia.org/T370469) [19:48:27] (03PS6) 10Eileen: Fix WMFSave to use apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1062779 (https://phabricator.wikimedia.org/T370469) [19:48:30] (03PS3) 10Eileen: Port import fix upstream [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064151 (https://phabricator.wikimedia.org/T370469) [19:48:34] (03PS1) 10Eileen: Port https://github.com/civicrm/civicrm-core/pull/30941 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064457 [19:57:02] 06Fundraising-Backlog, 10FR-Smashpig, 07payments-orchestration: Update Adyen listener to deal with Gravy transactions - https://phabricator.wikimedia.org/T372508#10082861 (10jgleeson) Let's drop these right away instead of letting them get on the jobs-adyen queue and filter out that way. [20:51:39] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make 'Full Name' available as an import field - https://phabricator.wikimedia.org/T342718#10083006 (10Eileenmcnaughton) [20:57:10] 06Fundraising-Backlog: New contribution field - https://phabricator.wikimedia.org/T371636#10083043 (10NNichols) Adding in the other new field - Channel as well [21:12:20] 06Fundraising-Backlog: New contribution field - https://phabricator.wikimedia.org/T371636#10083118 (10NNichols) At some point these will need to sync with acoustic [21:16:23] 06Fundraising-Backlog: Make the phone number field mandator on all payment types in the India Form - https://phabricator.wikimedia.org/T373060 (10EMartin) 03NEW [21:19:55] 06Fundraising-Backlog: Adding a field for last 4 digits of CC number - https://phabricator.wikimedia.org/T373061 (10NNichols) 03NEW [21:21:18] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1064475 [22:01:54] ejegg: cstone these new fields Nora created - it kinda annoys me that we didn't get the column name to be sane - give we will have to interact with them via code - I'm wondering if we should take adantage on maintenance week & them not being used yet to change it [22:02:29] for the one that wasn't fund? [22:08:03] now today or tomorrow are definitely the times to do it. [22:10:06] cstone: yeah - the one that wasn't fund :-) [22:10:28] +1 to makng names match [22:10:33] the new ones are campaign code or something [22:11:56] 378 | Channel | channel_378 | [22:11:56] | 377 | Package | package_377 [22:14:37] ok - my brain is borken - I can't even see tose fiels [22:18:05] ok - only 73 rows have values for the fields (one I just created) [22:45:19] 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10fundraising-tech-ops: FR-Tech FY2425Q1 maintenance window - https://phabricator.wikimedia.org/T337582#10083273 (10Dwisehaupt) [22:47:23] (03PS1) 10Eileen: Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) [23:06:05] (03PS1) 10Eileen: Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) [23:07:17] (03CR) 10CI reject: [V:04-1] Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [23:11:42] (03PS2) 10Eileen: Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) [23:11:42] (03PS2) 10Eileen: Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) [23:13:03] (03PS3) 10Eileen: Add gift source custom field updates from live [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064489 (https://phabricator.wikimedia.org/T371636) [23:13:03] (03PS3) 10Eileen: Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) [23:25:18] (03CR) 10CI reject: [V:04-1] Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) (owner: 10Eileen) [23:40:36] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 10FR-Civi-Dedupe, and 2 others: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10083302 (10Eileenmc... [23:42:02] (03PS4) 10Eileen: Update script to change column name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1064492 (https://phabricator.wikimedia.org/T371636) [23:42:54] cstone: if you feel up to looking at it then that ^^ gets us to having sane names on those 2 new fields (that have only 73 values in them so far) - since these will be used a lot of code it feels worth it