[00:42:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Settled Adyen transaction not in Civi - https://phabricator.wikimedia.org/T372670#10094633 (10AnnWF) Found this transaction still not been audit parsed, in both settlement_detail_report_batch_1069.csv and payments_accounting_report_2... [00:46:00] 06Fundraising-Backlog: adyen use same order id for two transactions - https://phabricator.wikimedia.org/T373411 (10AnnWF) 03NEW [00:47:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Manually settled transactions didn't reach Civi - https://phabricator.wikimedia.org/T372480#10094654 (10AnnWF) Found above transactions still not been audit parsed, similar to this https://phabricator.wikimedia.org/T372670, seems lik... [00:52:18] 06Fundraising-Backlog: adyen use same order id for two transactions - https://phabricator.wikimedia.org/T373411#10094660 (10AnnWF) [01:36:23] (03CR) 10Wfan: [C:03+2] Add PaymentSettings to allowlist [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1064870 (owner: 10Cstone) [01:50:39] (03CR) 10Cstone: [V:03+2] Add PaymentSettings to allowlist [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1064870 (owner: 10Cstone) [02:27:40] (03PS1) 10Cstone: Flip the sorting of the audit files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1066992 [06:11:29] (03CR) 10Eileen: [C:03+2] Flip the sorting of the audit files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1066992 (owner: 10Cstone) [06:29:06] (03Merged) 10jenkins-bot: Flip the sorting of the audit files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1066992 (owner: 10Cstone) [13:36:12] fr-tech has anyone else been able to get the gravy 3dsecure flow working in dev ? [13:36:26] I can't seem to make it trigger the redirect [13:37:40] Gravy lists the test cards here: https://docs.gr4vy.com/guides/features/3ds/testing#challenge-flow-successful-or-declined-status-y-eci-05-or-n [13:38:04] and we have those numbers set up in the adyen console with 3ds name & password [13:38:19] but they all see to just authorize with no challenge [13:38:22] *seem [13:39:03] ejegg: it might need switching on at the connection setting [13:39:21] dami disabled it so we could test general trxns [13:39:34] you can set up a dedicated flow for it [13:40:14] 3dsecure isn't active on sandbox atm [13:40:20] https://sandbox.wikimedia.gr4vy.app/merchants/default/connections/payment-services/9996be63-1e6f-4290-9d6e-b70f5d9b6bf8/overview [13:48:28] aha, yep, it was the connection setting! [13:48:31] thanks jgleeson [13:49:30] So how about we leave it active at the connection level and just fine tune it at the flow level for specific BINs [13:49:45] ? [13:50:37] yeah sounds good [13:50:47] we can probably delete dami's earlier flow [14:00:23] (03CR) 10Ejegg: "Seems ok, but there are a lot of unrelated changes in the ResponseMapper" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [14:01:34] ejegg: with dami out we might have to work up the review responses ourselves and push them back into review [14:01:45] I'm looking at the refund stuff atm [14:01:50] (03CR) 10Ejegg: [C:04-1] "The php code ends up correctly returning a PaymentResult::newRedirect, but the JS is just popping up the monthly convert. Do we need to up" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060421 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [14:02:11] ah right dami is out [14:02:42] ok, I'll disable 3ds again for now [14:06:56] (03PS1) 10Krinkle: installer: Support MW_SKIP_EXTERNAL_DEPENDENCIES in update.php [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 (https://phabricator.wikimedia.org/T370380) [14:13:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4370 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:14:53] (03PS2) 10Umherirrender: Use real type hints for class properties holding type hinted arguments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065800 [14:14:55] (03CR) 10Ejegg: [C:03+2] Use real type hints for class properties holding type hinted arguments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065800 (owner: 10Umherirrender) [14:15:02] (03PS3) 10Umherirrender: Add missing documentation to class properties [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065801 [14:15:04] (03CR) 10Ejegg: [C:03+2] Add missing documentation to class properties [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065801 (owner: 10Umherirrender) [14:18:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2054 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:19:13] (03CR) 10CI reject: [V:04-1] installer: Support MW_SKIP_EXTERNAL_DEPENDENCIES in update.php [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067358 (https://phabricator.wikimedia.org/T370380) (owner: 10Krinkle) [14:20:28] jgleeson: the gravy audit code is done right? Was there a task to do the rest of the setup? Make the folders/job/turn on the report downloads? [14:20:44] I'm also asking this and going afk so sorry for that hah [14:22:12] cstone: there's still one bit left on that.I've got a patch on the CRM side which I put on the backburner last week to review dami's stuff [14:23:14] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 569301 Threads: 4 Questions: 20589680 Slow queries: 281 Opens: 2870 Open tables: 1129 Queries per second avg: 36.166 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:23:29] Is it anything I could help with jgleeson and now actually afk [14:42:16] (03PS1) 10Ejegg: Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 [14:43:01] Hmm, getting lots of failures on the payments-phpunit locally [14:43:18] gateway chooser tests all missing a 'general' key [14:43:29] guessing that's missing for gravy? [14:44:06] ugh, I still don't like that config bit [14:44:26] I wonder if I can change it back to just check for fallbackCurrency as it did before [14:44:32] (03CR) 10CI reject: [V:04-1] Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (owner: 10Ejegg) [14:49:34] (03PS2) 10Ejegg: Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) [14:51:42] (03CR) 10CI reject: [V:04-1] Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) (owner: 10Ejegg) [14:53:54] (03PS3) 10Ejegg: Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) [14:57:05] (03CR) 10CI reject: [V:04-1] Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) (owner: 10Ejegg) [14:57:57] (03PS1) 10Ejegg: Add missing config file to gravy gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067370 [15:00:20] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) (owner: 10Ejegg) [15:00:46] blah, phan test throwing exceptions org.jenkinsci.plugins.postbuildscript.PostBuildScriptException: hudson.AbortException: castor-save-workspace-cache aborted. [15:06:51] (03CR) 10Ejegg: Support iDEAL 2.0 (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063253 (https://phabricator.wikimedia.org/T372571) (owner: 10Ejegg) [15:10:02] (03Merged) 10jenkins-bot: Use real type hints for class properties holding type hinted arguments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065800 (owner: 10Umherirrender) [15:13:20] (03Merged) 10jenkins-bot: Add missing documentation to class properties [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1065801 (owner: 10Umherirrender) [15:18:40] (03PS4) 10Ejegg: Send payment_submethod not issuer_id for ideal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063255 [15:27:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10096572 (10Ejegg) Some of those new ones are still a bit hazy on where the process breaks - at least one says PayPal is not working, whi... [15:27:32] ejegg: did you see my msg from yesterday about that di test patch with config ? If that's maybe doing it [15:44:07] cstone: oops, i might have missed it [15:44:34] this fixed the gateway chooser tests for me: https://gerrit.wikimedia.org/r/1067370 [15:44:52] did you have a similar patch? [15:45:12] no i had just saw the test change patch when I deployed yesterday and didn't know if that had been related, i didnt look into it more [15:46:17] ah ok [15:46:38] locally it's failing because the localsettings have the gravy gateway enabled [15:47:06] and the gateway chooser loops over all enabled gateways checking something from a config file that didn't exist in gravy yet [15:47:27] ah, we should also enable gravy for the chooser test config [15:48:03] Ahh okay [15:49:06] Ah I added that css change to hide the new instructions for ideal 2.0: https://gerrit.wikimedia.org/r/1063255 [15:49:52] I saw you tested the new SmashPig patch maybe without the DI changes? It still worked with the issuer_id for iDEAL 1.0, right? [15:50:09] It just won't get the payment_submethod till you apply that DonationInterface patch [15:51:28] mmm, family at the patio table next to me has pizza. Think I might go grab some slices of my own [15:52:10] Oh I could comment that new css so it's not so mysterious [15:52:57] (03PS5) 10Ejegg: Send payment_submethod not issuer_id for ideal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063255 [16:48:31] ejegg: I can test again I thought i had all the patches ejegg but this was charging the 2nd charge from the recurring charge job [16:48:47] and would older ones have the wrong submethod? [16:48:51] sorry for the ideal2.0 [16:48:54] cstone: ohhh i see [16:49:09] so for ideal 2.0 I think the only change is the front-end, right? [16:49:24] yeah it was just the changes to that if else, it never got to the else for the token charge [16:49:26] when we get to the recurrings I think we keep everything as before [16:50:01] i.e. charge it as sepa direct debit [16:50:05] with the token [16:50:32] yeah when I tried to charge one it had $submethod === 'rtbt_ideal' so it went into the 2nd block [16:50:54] instead of createpaymentfromtoken [16:50:59] lemme try again though [16:51:45] ohhh i see [16:51:51] (again) [16:52:05] sorry, I didn't think we were sending the $submethod in from the backend [16:52:58] Then I'll smoke test that flow - no need for you to do it again [16:53:20] i can't remember didn't we switch the backend submethod for these a couple times [16:53:26] like was it changed to sepa? or away from sepa? [16:53:34] i thought it was still sepa! [16:53:41] hmm okay [16:53:45] yeah that would make the most sense [16:53:51] I just created a new one locally, let me consume queues and see [17:27:52] ah right needs IPN listener [17:30:55] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 13Patch-For-Review, 07recurring upgrade: Update text for recurring upgrade thank you email - https://phabricator.wikimedia.org/T371848#10097196 (10XenoRyet) [17:31:03] 06Fundraising-Backlog: Benevity import not working - https://phabricator.wikimedia.org/T369647#10097197 (10XenoRyet) [17:31:10] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import migration - add support for currency conversion - https://phabricator.wikimedia.org/T368998#10097198 (10XenoRyet) [17:37:32] do other folks see crashes locally during the donations queue consumer, specifically in removeRecurringToken ? [17:45:29] whew, i had about 1 zillion backlogged ipns to work through [17:46:35] yeah i was trying to ifugre out if we could clean them on adyens side somehow [17:46:43] i didnt see anything obvious in the UI [17:53:31] ok, i see, we map the sepa back to rtbt/rtbt_ideal in the SmashPig payments class before charging [17:54:29] so we should just check for recurring_payment_token first and use the token method when that exists [17:55:17] that makes sense [17:55:41] im gona see if adyen can clean out those ipns ill send them a ticket [17:57:15] ahh or we could just make a quick script to blank out the jobs-adyen queue [17:57:31] redis-cli something [17:58:50] we do have one [17:58:55] thats what I did when i was testing [17:58:58] its -clear [17:59:09] oh i seee just jobs adyen [17:59:23] well hopefully they can delete them too itll keep the logs cleaner [18:16:56] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q#:rack/setup/install payments200[456] - https://phabricator.wikimedia.org/T369942#10097398 (10Dwisehaupt) a:05Dwisehaupt→03Papaul Assigning to @Papaul for payments2006 setup. Assign back to me when it's ready for OS install an... [18:20:20] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE, 13Patch-For-Review: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10097416 (10Dwisehaupt) a:05Dwisehaupt→03Papaul Assigning to @Papaul for frdb2005 setup. Assign back to me when it's ready for OS install and setup. [18:24:47] (03CR) 10Jgleeson: [C:03+2] "This is working for me. There's a few warnings showing for me on the cli when running and there's a possible bug in the CSV reader code on" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) (owner: 10Damilare Adedoyin) [18:39:52] 10fundraising-tech-ops: Install and configure new host frlog2002 - https://phabricator.wikimedia.org/T372933#10097458 (10Dwisehaupt) [19:23:23] 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10097573 (10AKanji-WMF) Traditionally Katie had set aside "no mailing" weeks to do this mapping - and blocked out period per year to propagate this. @AKanji-WMF to meet with @MSuijke... [19:31:00] 06Fundraising-Backlog: Update import code (inc upstream) to permit importing last 4 digits of CC number (to financial_trxn.pan_truncation) - https://phabricator.wikimedia.org/T373061#10097595 (10Eileenmcnaughton) [19:42:55] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Missing fields in import mapping - https://phabricator.wikimedia.org/T373390#10097611 (10AKanji-WMF) [19:42:57] 14Fundraising Sprint: didAnyoneTryThis(), 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10FR-Civi-Dedupe, and 2 others: Sandra can't dedupe Name + address matching contacts (no email match) - https://phabricator.wikimedia.org/T353971#10097610 (10AKanji-WMF) [19:43:00] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 07payments-orchestration: Accept all Gravy webhook messages - https://phabricator.wikimedia.org/T373117#10097612 (10AKanji-WMF) [19:43:01] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10FR-WMF-Audit, 07payments-orchestration: Update Adyen audit parser to deal with Gravy transactions - https://phabricator.wikimedia.org/T372509#10097614 (10AKanji-WMF) [19:43:02] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10FR-Smashpig, 07payments-orchestration: Update Adyen listener to deal with Gravy transactions - https://phabricator.wikimedia.org/T372508#10097615 (10AKanji-WMF) [19:43:04] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Add new 'backend_processor' field to CiviCRM - https://phabricator.wikimedia.org/T372589#10097613 (10AKanji-WMF) [19:43:05] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Gravy test rollout plan - https://phabricator.wikimedia.org/T372469#10097616 (10AKanji-WMF) [19:43:07] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10097617 (10AKanji-WMF) [19:43:11] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Processing (Trustly) - https://phabricator.wikimedia.org/T371812#10097618 (10AKanji-WMF) [19:43:15] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Migration of India recurring to an alternate dlocal processor - https://phabricator.wikimedia.org/T371723#10097631 (10AKanji-WMF) [19:43:19] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Citibank international import mapping - issue with default fields + contribution source currency/amount - https://phabricator.wikimedia.org/T370483#10097632 (10AKanji-WMF) [19:43:27] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Import migration - add support for currency conversion - https://phabricator.wikimedia.org/T368998#10097635 (10AKanji-WMF) [19:43:31] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.20; 2024-08-27), 13Patch-For-Review, 07payments-orchestration: Gravy ACH (Trustly) - https://phabricator.wikimedia.org/T371810#10097619 (10AKanji-WMF) [19:43:39] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit/Settlement Processing - https://phabricator.wikimedia.org/T367788#10097637 (10AKanji-WMF) [19:43:43] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Create jobs for the events pushed to the jobs-gravy queue - https://phabricator.wikimedia.org/T370797#10097633 (10AKanji-WMF) [19:43:47] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy Refunds - https://phabricator.wikimedia.org/T367808#10097636 (10AKanji-WMF) [19:43:51] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Need to not autocancel recurring iDEAL/SEPA chargebacks - https://phabricator.wikimedia.org/T366769#10097639 (10AKanji-WMF) [19:43:55] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Gravy 3DSecure - https://phabricator.wikimedia.org/T367786#10097638 (10AKanji-WMF) [19:43:59] 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10FR-Smashpig, 13Patch-For-Review: Migrate remaining jobs off JsonSerializableObject - https://phabricator.wikimedia.org/T366367#10097640 (10AKanji-WMF) [19:44:03] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: QQQ, 06Fundraising-Backlog: Add Auto Rescue for SEPA Direct Debit - https://phabricator.wikimedia.org/T362575#10097642 (10AKanji-WMF) [19:44:07] 14Fundraising Sprint: justWork(), 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Make email custom fields editable from contact summary, upstream patch - https://phabricator.wikimedia.org/T366356#10097641 (10AKanji-WMF) [19:44:11] 03Fundraising Sprint: QQQ, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Organization Matching EFT import Error - https://phabricator.wikimedia.org/T373377#10097644 (10AKanji-WMF) [19:44:17] 14Fundraising Sprint: didAnyoneTryThis(), 14Fundraising Sprint: justWork(), 03Fundraising Sprint: QQQ, 06Fundraising-Backlog, and 4 others: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330#10097643 (10AKanji-WMF) [20:04:32] (03CR) 10Jgleeson: [C:03+2] "This is working well for me!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [20:05:06] (03CR) 10CI reject: [V:04-1] Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [20:05:58] (03PS22) 10Damilare Adedoyin: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) [20:06:13] (03PS17) 10Damilare Adedoyin: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) [20:07:03] (03PS2) 10Ejegg: Support iDEAL 2.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063253 (https://phabricator.wikimedia.org/T372571) [20:08:09] ok cstone I think ^^^ should work for front end and back end [20:08:12] trying now [20:15:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: Banner Closed Status Code Increase Year over Year - https://phabricator.wikimedia.org/T371632#10097796 (10Ejegg) Update - looks like last year's stats are the outlier. Looking at July for 22-23 we see sim... [20:24:14] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Missing fields in import mapping - https://phabricator.wikimedia.org/T373390#10097831 (10MDemosWMF) Adding that we do not want to import gifts with missing data so this is blocking us from getting gifts into Civi. [20:24:35] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Missing fields in import mapping - https://phabricator.wikimedia.org/T373390#10097837 (10MDemosWMF) p:05Triage→03High [20:24:39] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#10097839 (10Cstone) Apologies @RKumar_WMF and @EMartin I talked to Anil so much wh... [20:25:28] ok cstone with PS2 of the SmashPig iDEAL patch I can get the initial setup and the recurring charge [20:25:33] nice ejegg [20:27:42] 06Fundraising-Backlog: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484 (10MDemosWMF) 03NEW [20:30:04] (03PS1) 10Ejegg: Fix dynamic property declaration warnings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067419 [20:42:01] (03CR) 10Jgleeson: [C:04-1] "Looks like we're missing the refund status "succeeded" and getting errors as a result, so I'll add that to this patch as it can be merged " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [20:44:51] ejegg: do you have any old style ideal recurrings around to charge with 2.0 itll probably be fine but I don't have one [20:45:06] i don't [20:45:11] okie [20:45:18] but I'm pretty sure there's no change [20:45:39] it's saved the exact same way in civi [20:45:44] yeah [20:45:51] and ends up sending the exact same charge call to Adyen [20:46:04] only the setup call changes, removing the issuer_id [20:53:00] (03PS18) 10Ejegg: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [20:53:56] (03CR) 10Cstone: [C:03+2] "this looks good, thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063253 (https://phabricator.wikimedia.org/T372571) (owner: 10Ejegg) [20:54:06] (03PS1) 10Ejegg: Add more functions to Gravy ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 [20:54:30] (03Merged) 10jenkins-bot: Support iDEAL 2.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1063253 (https://phabricator.wikimedia.org/T372571) (owner: 10Ejegg) [20:54:45] (03CR) 10Cstone: [C:03+2] "thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063255 (owner: 10Ejegg) [20:56:08] 06Fundraising-Backlog, 06Wikipedia-Android-App-Backlog, 06Wikipedia-iOS-App-Backlog, 13Patch-For-Review: [S] Update donation links in apps to use wmf_ parameters - https://phabricator.wikimedia.org/T367360#10098020 (10HNordeenWMF) Note: if this is picked up, @SNowick_WMF would need to revisit queries and u... [21:02:44] thank you cstone! [21:02:58] Gonna update the smashpig version [21:06:01] (03PS1) 10Ejegg: Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067427 [21:06:03] (03CR) 10Ejegg: [C:03+2] Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067427 (owner: 10Ejegg) [21:08:43] (03CR) 10Jgleeson: [C:04-1] "Ok, it looks like the pending => succeeded state changes of these refund IPNs will require some extra work as it'll result in multiple ref" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [21:10:27] XenoRyet, fr-tech the refunds code needs some updates due to how gravy communicate refund progress via IPNs so I'll push the fixes for the patches to that tomorrow and then we can hopefully get that out for testing. [21:15:46] (03Merged) 10jenkins-bot: Send payment_submethod not issuer_id for ideal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1063255 (owner: 10Ejegg) [21:15:47] (03CR) 10CI reject: [V:04-1] Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067427 (owner: 10Ejegg) [21:17:10] thanks jgleeson [21:48:28] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#10098161 (10EMartin) @Cstone Hi Christine, thank you for this!! With what you hav... [22:01:12] I can review for you jgleeson [22:01:33] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067427 (owner: 10Ejegg) [22:13:21] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1067434 [22:15:25] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1067434 (owner: 10Cstone) [22:16:33] 06Fundraising-Backlog: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10098244 (10Eileenmcnaughton) @MDemosWMF is that the full_name you are trying to import (which goes into the field called `Full Name`) [22:16:56] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1067434 (owner: 10Cstone) [22:17:01] 14Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog, 13Patch-For-Review: Building Fidelity import - issue with addressee column - https://phabricator.wikimedia.org/T370469#10098248 (10Eileenmcnaughton) @MDemosWMF the new field is called 'Full Name' [22:17:42] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10098251 (10Eileenmcnaughton) [22:18:23] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10098253 (10Eileenmcnaughton) a:03Eileenmcnaughton [22:24:07] 06Fundraising-Backlog, 10FR-WMF-Audit: Audit: Let transactions change payment methods from contribution_tracking to final payment - https://phabricator.wikimedia.org/T373492 (10Cstone) 03NEW [22:30:08] (03Merged) 10jenkins-bot: Update SmashPig version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067427 (owner: 10Ejegg) [22:34:08] !log civicrm upgraded from f70d753c to e3aead7d [22:34:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:55:03] (03PS1) 10Eileen: Move 2 more tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067442 [22:56:12] (03PS1) 10Eileen: Fully remove ImportMessageTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067443 [23:23:18] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067444 [23:23:23] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067444 (owner: 10Ejegg) [23:36:29] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067444 (owner: 10Ejegg)