[00:47:46] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Citibank international import mapping - issue with default fields + contribution source currency/amount - https://phabricator.wikimedia.org/T370483#10098489 (10Eileenmcnaughton) a:03Eileenmcnaughton [00:48:58] (03PS1) 10Eileen: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) [00:50:14] (03PS2) 10Eileen: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) [00:59:57] !log payments-wiki upgraded from 0455b791 to f6a3be41 [00:59:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:00:13] cstone: ok, that's the new ideal uploadead [01:00:17] let's see how it looks [01:01:29] Hmm that sentence is back [01:01:40] oh weird, not on mine! [01:01:45] css cached? [01:01:59] ahh wait it IS there for me [01:02:02] I just did hard reload hmm let me try [01:02:18] It was gone in testing though [01:02:31] maybe cached in resourceloader cache? [01:02:40] though I thought touching the source file invalidated it [01:06:26] (03CR) 10CI reject: [V:04-1] Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) (owner: 10Eileen) [01:07:26] there is a load.php line that just comes back with a /* Cached xxxyyy */ comment: https://payments.wikimedia.org/load.php?lang=en&modules=site.styles&only=styles&skin=vector [01:09:17] oh ok, the adyen stuff seems to be inline [01:09:24] is that OUR adyen stuff? [01:10:07] yeah, looks like it [01:10:34] minified so hard to compare [01:11:05] but yeah, that's it, all but the new piece [01:11:15] lemme check on frpm that it is up there ok [01:11:57] ahh, nope! [01:11:59] what happened? [01:12:42] oh no, the ideal patch didn't get into the merge :P [01:12:45] ok, let's fix that [01:13:29] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067468 [01:13:35] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067468 (owner: 10Ejegg) [01:13:42] Ahh hah [01:14:39] (03PS1) 10Ejegg: Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 [01:14:43] (03CR) 10Ejegg: [C:03+2] Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 (owner: 10Ejegg) [01:15:09] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1067468 (owner: 10Ejegg) [01:15:17] (03CR) 10CI reject: [V:04-1] Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 (owner: 10Ejegg) [01:16:51] ackkk [01:17:11] did not mean to comming that geodb [01:18:47] (03PS2) 10Ejegg: Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 [01:19:08] (03Abandoned) 10Ejegg: Update smashpig to v0.8.10.8 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1034563 (owner: 10Damilare Adedoyin) [01:19:24] (03CR) 10Ejegg: [C:03+2] Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 (owner: 10Ejegg) [01:19:32] So I haven't replicated it in a test yet but the dedupe fails affect contacts where one has the postal_code_suffix in the main postal_code [01:19:33] (03PS3) 10Ejegg: Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 [01:19:37] (03CR) 10Ejegg: [V:03+2 C:03+2] Update composer.lock for new SmashPig version [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1067469 (owner: 10Ejegg) [01:19:44] - so far maybe coming from adyen? [01:21:10] !log payments-wiki upgraded from f6a3be41 to 54988ad9 [01:21:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:21:37] ok cstone the extra sentence is gone now [01:21:54] the postal code suffix coming from adyen eileen ? [01:21:57] I don't think so... [01:21:58] Nice ejegg [01:22:12] we should just be collecting postal code in the one field on our forms [01:22:20] ejegg: yeah I think so - just trying to find a new 'unfixed' example [01:22:32] i can check the adyen audit but I don't think any of our audit files have a postal code suffix field [01:22:50] so I tested a card donation with the new form before fixing the css [01:22:56] and it went through just fine [01:23:02] now let's take a peek at ideal [01:23:54] huh, slower to load than the card form [01:24:16] could the payment method lookup we do before we render the form be extra slow for NL for some reason? [01:24:53] Well, the iDEAL 2.0 page does finally load [01:25:02] let's see if it is faster the second time [01:25:35] yep, right quick the second time [01:25:42] should have that response cached [01:30:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10098513 (10Ejegg) Hi @krobinson, @AMJohnson , @EMartin and everyone else following! We just deployed the iDEAL 2.0 changes to production... [01:37:21] (03PS1) 10Eileen: Fix deduper failing on a postal code conflict where one side has the suffix in the main address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 [01:37:40] ejegg: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1067470 is the failing scenario [01:39:05] e.g the address on https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=64414511 has the suffix in the same field as the postal code [01:39:32] that should be a) resolved on deduping & b) separated out in the first place - we can do a follow up phab on b [01:41:57] (03PS2) 10Eileen: Fix deduper failing on a postal code conflict where one side has the suffix in the main address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 [01:42:07] looking [01:47:53] (03PS3) 10Eileen: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) [01:49:35] (03PS4) 10Eileen: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) [01:49:38] (03CR) 10Ejegg: "PS18: broke out unrelated code into follow-on patch" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [01:51:52] eileen: just scanning this list of postcode formats: https://en.wikipedia.org/wiki/List_of_postal_codes [01:51:59] wondering if there are others that use a - [01:52:30] japan does seem to have one [01:52:36] NNN-NNNN [01:52:51] ah but I guess we only collect em in a couple of countries [01:53:47] Latvia [01:55:36] we could compare the second match with the postal_suffix of the other [01:55:57] I guess if you want the extension to be totally generic [01:56:07] lessee how many jp addresses we have that even have a code [01:56:26] oh i guess we get full addresses from paypal [01:58:07] yeah, there are a whole bunch of NNN-NNNN addresses in there [01:59:26] you could special-case it to only split when the - is in the 6th position [01:59:54] should limit the impact to just US-style codes as far as I can tell [02:00:50] ah, and Brazil [02:00:55] but those look like similar suffixes [02:01:32] ok, costa rica too [02:04:04] i'll look again in the morning eileen ! [02:08:19] (03CR) 10CI reject: [V:04-1] Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) (owner: 10Eileen) [02:11:10] (03PS3) 10Eileen: Fix deduper failing on a postal code conflict where one side has the suffix in the main address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 [02:13:03] (03PS5) 10Eileen: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) [02:18:08] (03PS1) 10Eileen: Move normalize tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067500 [02:26:45] (03PS1) 10Eileen: Fix notice when requireFieldError is NULL [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067501 [02:56:50] (03PS1) 10Eileen: Use do_not_import rather than NULL if no value is mapped [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067530 [03:18:56] (03PS4) 10Eileen: Fix deduper failing on a postal code conflict where one side has the suffix in the main address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 [03:25:37] (03PS2) 10Eileen: Use do_not_import rather than NULL if no value is mapped [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067530 [05:38:08] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Annual Recurring - Tagging and segmenting in Civi and Acoustic - https://phabricator.wikimedia.org/T372378#10098628 (10MSuijkerbuijk_WMF) @AKanji-WMF Do we also need no mailing weeks to implement the fields in Civi? If we could have the fi... [06:57:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10098718 (10krobinson) Awesome, thanks @Ejegg - we'll monitor and see if this has an impact. [10:38:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), 13Patch-For-Review: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD - https://phabricator.wikimedia.org/T370583#10099221 (10RKumar_WMF) Please see below the fro... [13:36:48] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10099674 (10MDemosWMF) @Eileenmcnaughton I just tried to map addressee in the file to 'Full Name' but it is not showing as a field option in the dropdown:... [13:41:50] (03CR) 10Ejegg: [C:03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 (owner: 10Eileen) [13:43:03] (03PS5) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [13:43:03] (03PS3) 10Ejegg: Stop calling parent::__construct() in Amazon messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064448 (https://phabricator.wikimedia.org/T366367) [13:43:03] (03PS3) 10Ejegg: Stop using fromJson in DLocal tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064784 (https://phabricator.wikimedia.org/T366367) [13:43:04] (03PS2) 10Ejegg: Stop RejectedMessageJob extending JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064796 (https://phabricator.wikimedia.org/T366367) [13:43:05] (03PS3) 10Ejegg: Remove JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064785 (https://phabricator.wikimedia.org/T366367) [13:43:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 14654 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:43:53] ejegg: rakhi was messaging asking about how much is left to do to get backend processor info into civicrm. I think it's just the patch for payments to drop it on the queue right? [13:43:54] (03PS4) 10Ejegg: Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) [13:43:58] hi* [13:44:03] jgleeson: hi! [13:44:11] yep, I think that should be it [13:44:18] let me just run the tests locally [13:45:02] (03PS2) 10Ejegg: Add missing config file to gravy gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067370 [13:45:15] oh right, jgleeson, want to take a look at this patch to reduce test noise locally? ^^^ [13:46:10] (03PS1) 10Ejegg: Add backend_processor to gravy queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) [13:46:19] looking [13:46:58] I think it's only passing in CI because we don't set the gravy gateway to enabled for the chooser tests [13:48:05] (03CR) 10CI reject: [V:04-1] Add backend_processor to gravy queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [13:48:06] I still have the gripe with that file I had when it was introduced, but I don't really want to make that gatewayChooser change right now [13:48:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 14954 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:48:20] don't we have a centrally located config file [13:48:39] how did we end up with gateway-specific general ones too [13:49:27] jgleeson: AndyRussG decided to add that instead of having the GatewayChooser consult the FallbackCurrency when we were doing the chooser refactor [13:49:50] could we move this into extensions/DonationInterface/config [13:50:33] I guess we could do it later [13:50:44] well, the setting does differ from gateway to gateway [13:51:02] we only want to include the gateway in the chooser options if it has a fallback currency [13:51:16] i.e. if you try to donate via paypal with a currency that's not on paypal's list [13:51:26] we will show you the form, but with a converted currency and a message [13:52:05] however for Adyen there are so many supported currencies that we don't do the conversion, we just show you another gateway (dlocal?) or an 'unsupported currency' error message [13:52:51] with paypal and amazon we do the currency fallback since there aren't other gateways that process those methods [13:53:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 15254 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:53:55] ok I see your commit message suggstion also [13:54:03] (03CR) 10Jgleeson: [C:03+2] Add missing config file to gravy gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067370 (owner: 10Ejegg) [13:54:36] thanks! [13:55:08] ah shoot, I might need to make another little update to SmashPig to get rid of this problem: [13:55:11] Error: Typed property SmashPig\PaymentProviders\Responses\PaymentDetailResponse::$backendProcessor must not be accessed before initialization [13:55:18] I guess it needs to default to null [13:55:22] ah [13:55:30] I thought it would be OK since the type is ?string [13:55:33] but nope [13:56:03] I'll do that update [13:58:13] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 15554 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [13:58:43] (03Merged) 10jenkins-bot: Add missing config file to gravy gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067370 (owner: 10Ejegg) [14:00:56] (03Merged) 10jenkins-bot: Fix deduper failing on a postal code conflict where one side has the suffix in the main address [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067470 (owner: 10Eileen) [14:01:54] (03PS1) 10Ejegg: Add real types for DetailResponse props, initialize [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068006 [14:02:18] jgleeson: is that too much to do in one patch? ^^^ I tried not to go too far [14:03:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 15854 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:04:00] lgtm ejegg [14:04:10] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068006 (owner: 10Ejegg) [14:04:41] (03Merged) 10jenkins-bot: Add real types for DetailResponse props, initialize [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068006 (owner: 10Ejegg) [14:06:41] thanks! [14:08:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 16154 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:09:21] (03PS1) 10Ejegg: More types for responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068011 [14:13:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 13130 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:17:14] (03PS1) 10Ejegg: Set type hints on numeric properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068012 [14:17:14] (03PS1) 10Ejegg: Add getters and setters for new Approve props [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068013 [14:18:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 4040 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:23:15] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2045 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:26:56] ejegg: nitpicking here [14:26:59] :) [14:27:30] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1068012/1/PaymentProviders/Responses/ApprovePaymentResponse.php#24 this is never gonna be an int right? so could we go with float|null [14:28:15] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 656001 Threads: 4 Questions: 39389439 Slow queries: 321 Opens: 2890 Open tables: 1132 Queries per second avg: 60.044 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [14:28:29] ah in the phpdoc? Sure, I should update those to match [14:30:20] (03PS2) 10Ejegg: Set type hints on numeric properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068012 [14:30:20] (03PS2) 10Ejegg: Add getters and setters for new Approve props [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068013 [14:30:44] k, that's updated [14:31:00] ty [14:31:19] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068012 (owner: 10Ejegg) [14:32:00] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068011 (owner: 10Ejegg) [14:32:27] (03Merged) 10jenkins-bot: More types for responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068011 (owner: 10Ejegg) [14:32:29] (03Merged) 10jenkins-bot: Set type hints on numeric properties [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068012 (owner: 10Ejegg) [14:33:20] (03CR) 10Jgleeson: [V:03+2 C:03+2] Add getters and setters for new Approve props [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068013 (owner: 10Ejegg) [14:33:49] (03Merged) 10jenkins-bot: Add getters and setters for new Approve props [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068013 (owner: 10Ejegg) [14:34:14] ejegg: is this one gonna need a smashpig tag and a composer bump? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1068002 [14:37:19] yep, working on it! [14:37:44] updating the test too, to check the queue message [14:38:21] thanks for all the CR [14:38:48] oh hmm, it's sending a different gateway_txn_id to the queue than i would have expected [14:39:04] the test has one id for the auth and another for the capture [14:39:11] and it's sending the auth txn_id to the queue [14:39:25] lemme do a test txn and make sure that's how it works in the real API [14:43:35] ok, for gravy it seems to use the same txn_id across auth and capture [14:51:11] ejegg: just wanna double check an assumption with you [14:53:30] gravy is sending us two IPNs per refund. The first is 'processing' which is what we get when the the refund is requested via the console and gravy have likely forwarded it on to the backend processor to be processed. The second IPN comes over with 'succeeded' which I'm guessing is when the backend processor has actioned the refund. Am I right in thinking we only want a queue message [14:53:32] on the refund queue on our side when we get the latter message? [14:54:10] 06Fundraising-Analysis, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Archive banner impression stats on a rolling basis - https://phabricator.wikimedia.org/T373529 (10Ejegg) 03NEW [14:56:52] (03PS2) 10Ejegg: Add backend_processor to gravy queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) [14:57:39] jgleeson: yep, I agree, we can just ack & ignore that processing one [15:00:10] what was the process of getting prod accounts turned on for gravy just asking in the slack channel? trustly ach did get deployed but returning There is no active payment service for this transaction. [15:03:17] oh right theres a new channel [15:07:59] ah the connection needs to be made jgleeson did we just do that ourselves on prod or are we sharing that with payments? [15:11:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Uptick in Dutch donors experiencing issues donating - https://phabricator.wikimedia.org/T372571#10099966 (10EMartin) Thanks Elliott @Ejegg ! Watching. [15:17:08] hmm the backend processor txn id is coming back the same for auth & capture too [15:17:36] even though adyen gives different pspReference for auth & capture [15:24:35] so we should add that to the queue messages too I guess [15:24:43] ok, one more SmashPig patch coming up [15:35:44] sorry cstone for going brb right after you're question! roxy's family needed to leave so I had to move my car [15:36:06] cstone: they are called "connections" in the prod console [15:36:14] I think Dami has set trustly up on sandbox [15:36:34] so you could probably check that. We do need a prod account with the backend processor to plug in [15:37:40] your* [15:39:58] (03PS1) 10Ejegg: Add backendProcessorTransactionId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) [15:40:21] (03CR) 10CI reject: [V:04-1] Add backendProcessorTransactionId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [15:41:47] thanks jgleeson are we in control of making the connections in production? [15:42:16] yep, we add those here https://wikimedia.gr4vy.app/merchants/default/connections/configured [15:43:33] (03CR) 10Jgleeson: [C:03+2] "Ok there was a bit more needed here, so I'll +2 this and add the 'succeeded' stuff in a follow-on" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:43:41] (03CR) 10Jgleeson: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [15:44:02] (03Merged) 10jenkins-bot: Setup Refunds method and maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059078 (https://phabricator.wikimedia.org/T367808) (owner: 10Damilare Adedoyin) [15:44:44] (03PS2) 10Ejegg: Add backendProcessorTransactionId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) [15:56:24] (03PS1) 10Jgleeson: Gravy Refund IPN Handler updates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068031 [15:59:40] (03CR) 10Jgleeson: [C:03+2] Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [16:00:12] (03Merged) 10jenkins-bot: Refund job [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059356 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [16:19:02] (03PS1) 10Ejegg: Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068038 [16:19:11] (03CR) 10Ejegg: [C:03+2] Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068038 (owner: 10Ejegg) [16:23:30] fr-tech: https://phabricator.wikimedia.org/F57326108 :) [16:24:01] XenoRyet: last night's tech-talk didn't auto-record. Did we miss that meeting by chance? [16:25:22] (03PS19) 10Jgleeson: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [16:25:33] I broke out the 3DS stuff from the other chain ^ [16:25:48] (03CR) 10CI reject: [V:04-1] Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [16:25:55] ouch [16:27:23] should we get CI to auto phpcodebeautify code sniffer violations? [16:28:21] (03PS20) 10Jgleeson: Setup 3DS Flow [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1060129 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [16:31:00] (03PS25) 10Jgleeson: Handle Report execution webhook message [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1059932 (https://phabricator.wikimedia.org/T370797) (owner: 10Damilare Adedoyin) [16:31:00] (03PS13) 10Jgleeson: Implement DownloadReportJob execute function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064020 (owner: 10Damilare Adedoyin) [16:32:11] jgleeson, I didn't go to tech-talk yesterday, so I'm not sure if it actually happened, but I would assume so. I'll check the autorecord settings. [16:33:29] Oh weird, looks like it just wasn't set to record. Maybe this is one of the ones where there's more instances than it seems and I missed one. [16:33:34] I'll fix it and check the rest. [16:35:57] (03PS2) 10Jgleeson: Add more functions to Gravy ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [16:36:29] ejegg|food: i just fixed a conflict in your follow on that wasn't letting me rebase over the 3ds patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1067422/2 [16:36:50] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10100401 (10AKanji-WMF) [16:37:05] thanks XenoRyet [16:38:35] (03Merged) 10jenkins-bot: Update SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068038 (owner: 10Ejegg) [16:44:18] 06Fundraising-Backlog: Paypal Giving Fund gift going to wrong CID - https://phabricator.wikimedia.org/T373542 (10MDemosWMF) 03NEW [17:13:42] thanks jgleeson|food [17:15:47] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068049 [17:22:54] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068049 (owner: 10Ejegg) [17:23:44] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068049 (owner: 10Ejegg) [17:36:29] (03PS1) 10Ejegg: Update wikimedia [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1068056 [17:36:31] (03CR) 10Ejegg: [C:03+2] Update wikimedia [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1068056 (owner: 10Ejegg) [17:37:20] (03PS1) 10Ejegg: Update vendor for SmashPig upgrade [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068057 [17:44:06] (03CR) 10Ejegg: [C:03+2] Update vendor for SmashPig upgrade [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068057 (owner: 10Ejegg) [17:44:27] (03CR) 10Ejegg: [V:03+2 C:03+2] Update wikimedia [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1068056 (owner: 10Ejegg) [17:44:35] (03CR) 10Ejegg: [V:03+2 C:03+2] Update vendor for SmashPig upgrade [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1068057 (owner: 10Ejegg) [17:48:15] !log fundraising civicrm upgraded from e3aead7d to 916cad45 [17:48:18] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:50:00] ok, re-enabled that dedupe job. Let's see how it goes [17:51:17] (03PS2) 10Ejegg: Fix dynamic property declaration warnings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067419 [17:52:02] (03PS6) 10Ejegg: Remove JsonSerializableMessage from more tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064422 (https://phabricator.wikimedia.org/T366367) [17:52:02] (03PS4) 10Ejegg: Stop calling parent::__construct() in Amazon messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064448 (https://phabricator.wikimedia.org/T366367) [17:52:03] (03PS4) 10Ejegg: Stop using fromJson in DLocal tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064784 (https://phabricator.wikimedia.org/T366367) [17:52:03] (03PS3) 10Ejegg: Stop RejectedMessageJob extending JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064796 (https://phabricator.wikimedia.org/T366367) [17:52:04] (03PS4) 10Ejegg: Remove JsonSerializableObject [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064785 (https://phabricator.wikimedia.org/T366367) [17:52:45] (03PS3) 10Ejegg: Add backendProcessorTransactionId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) [17:58:24] (03CR) 10Jgleeson: Add more functions to Gravy ResponseMapper (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [18:00:40] (03CR) 10Jgleeson: Add more functions to Gravy ResponseMapper (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [18:02:52] (03CR) 10Jgleeson: Add more functions to Gravy ResponseMapper (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [18:03:18] ejegg: do you remember what patch you split those out from? [18:05:58] ejegg: I think something funky has happened [18:07:25] the 2 of the 3 methods in that split out patch (the two I hadn't asked to be moved yet) are also in this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1059932/25/PaymentProviders/Gravy/Mapper/ResponseMapper.php so I'm thinking maybe dami was layering updates and accidentially added a bunch of changes to that file unrelated to the patch you split them out [18:07:27] from [18:09:11] (03PS2) 10Eileen: Move 2 more tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067442 [18:09:12] (03CR) 10Ejegg: [C:03+2] Move 2 more tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067442 (owner: 10Eileen) [18:09:38] I think we can orphan that patch for now and I'll move the other two methods to a different WebhookMessageMapper or something like that [18:09:40] (03PS2) 10Eileen: Fully remove ImportMessageTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067443 [18:09:43] (03CR) 10Ejegg: [C:03+2] Fully remove ImportMessageTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067443 (owner: 10Eileen) [18:11:42] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [18:14:14] (03CR) 10Jgleeson: [C:04-1] "Let's not merge this yet. One of the methods is unused and was moved over to the GravyListener and the other two are included in a separat" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [18:23:42] thanksk for the C+2 jgleeson ! [18:23:49] np [18:24:00] ah just saw your question [18:24:09] I split that off from the 'Setup 3DS' patch [18:24:14] since they had nothing to do with it [18:24:16] oh right! [18:24:25] I guess it makes sense they were also included in something else [18:24:28] yeah I think that was an accident [18:24:36] so we can abandon it if we want [18:24:43] yeah I think we can [18:24:47] cool cool [18:24:57] (03Abandoned) 10Ejegg: Add more functions to Gravy ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1067422 (owner: 10Ejegg) [18:27:25] Asana confuses me [18:28:33] (03Merged) 10jenkins-bot: Move 2 more tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067442 (owner: 10Eileen) [18:29:16] (03Merged) 10jenkins-bot: Fully remove ImportMessageTest [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067443 (owner: 10Eileen) [18:29:16] (03Merged) 10jenkins-bot: Add backendProcessorTransactionId [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068029 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [18:39:37] rip mac had the right minutes but the wrong hour [18:44:16] (03PS3) 10Ejegg: Add backend_processor and id to gravy queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) [18:44:32] OK, I've tagged another new SmashPig version [18:44:41] oops, needs packagist button push [18:45:01] k, pushed that button [18:45:27] and the new DI patch has the backend processor ID now [18:51:59] (03PS1) 10Ejegg: Add backend_processor_txn_id to allowed message fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068074 [18:52:30] Hmm, maybe I should add a test to make sure those fields get through the import [18:53:08] missing that adyen auto tab on the gravy form hah [19:02:34] (03CR) 10Cstone: [C:03+2] "looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [19:04:52] (03Merged) 10jenkins-bot: Add backend_processor and id to gravy queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068002 (https://phabricator.wikimedia.org/T372589) (owner: 10Ejegg) [19:10:19] (03PS1) 10Cstone: Add ACH trustly link [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1068077 [19:23:39] 06Fundraising-Backlog: Add refund activity with refund reason - https://phabricator.wikimedia.org/T373555 (10Cstone) 03NEW [19:36:24] (03CR) 10Umherirrender: [V:03+2 C:03+2] build: Update MediaWiki requirement to 1.43 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1064901 (owner: 10Jforrester) [19:36:46] (03CR) 10Umherirrender: [V:03+2] "T357804" [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1065345 (owner: 10Libraryupgrader) [19:56:11] 06Fundraising-Backlog, 07payments-orchestration: Make gravy form match adyen form - https://phabricator.wikimedia.org/T373557 (10Cstone) 03NEW [20:01:26] (03PS2) 10Jgleeson: Gravy Refund IPN Handler updates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068031 [20:01:50] (03CR) 10Ejegg: [C:03+2] "Looks decent, works locally." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068031 (owner: 10Jgleeson) [20:02:21] (03Merged) 10jenkins-bot: Gravy Refund IPN Handler updates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068031 (owner: 10Jgleeson) [20:10:39] the official merch is't too expensive. I think I'll pick one of these plushys up for £2.50 https://retail.blackpoolpleasurebeach.com/product/big-one-super-hero-plush/ [20:11:30] ah man the website is broke [20:19:52] (03PS1) 10Eileen: Update phpunit & dependencies, minor version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068086 [20:26:27] (03PS1) 10Eileen: Update monolog to 2.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068087 [20:30:44] (03PS2) 10Ejegg: Add backend_processor_txn_id to allowed message fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068074 [20:38:47] (03CR) 10CI reject: [V:04-1] Update phpunit & dependencies, minor version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068086 (owner: 10Eileen) [20:42:48] (03PS1) 10Jgleeson: Update comment for Gravy Refund IPN reason placeholder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068088 [20:43:08] fr-tech I just correct that comment ^ [20:43:12] corrected* [20:46:18] (03CR) 10CI reject: [V:04-1] Update monolog to 2.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068087 (owner: 10Eileen) [20:48:32] ok, that test to check the backend processor fields is passing on https://gerrit.wikimedia.org/r/1068074 [20:49:51] (03PS2) 10Ejegg: Update comment for Gravy Refund IPN reason placeholder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068088 (owner: 10Jgleeson) [20:50:20] (03CR) 10Ejegg: [C:03+2] "Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068088 (owner: 10Jgleeson) [20:50:49] (03Merged) 10jenkins-bot: Update comment for Gravy Refund IPN reason placeholder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1068088 (owner: 10Jgleeson) [21:55:37] (03PS1) 10Eileen: Update monolog point version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068121 [22:07:28] (03Abandoned) 10Eileen: Update monolog to 2.9.3 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068087 (owner: 10Eileen) [22:08:23] I'm gonna re-enable the dedupe job [22:09:30] oh looks like you already did [22:11:40] 14Fundraising Sprint: justWork(), 14Fundraising Sprint: powerfulFunctionPleaseOnlyCallIfAbsolutelyNecessary(), 06Fundraising-Backlog: Re-try data prior to Auto-Rescue was enabled - https://phabricator.wikimedia.org/T365348#10101357 (10EMartin) @Cstone - Are you able to give me the total transactions atte... [22:12:49] (03PS1) 10Eileen: Notice fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068126 [22:13:13] (03Abandoned) 10Eileen: Update phpunit & dependencies, minor version [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1068086 (owner: 10Eileen) [23:07:25] cstone: I'm reneabling dedupe-contacts-from-start job - I think the patch is trivial enough you don't need to log in & eyeball it - just OK the concept here [23:08:20] sure eileen i just got back to the computer too [23:10:45] !log config revision changed from cb9b3655 to af0aadef re-enable dedupe contacts from start [23:10:47] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log