[00:37:31] (03CR) 10Cstone: [C:03+2] "looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) (owner: 10Ejegg) [00:39:31] (03Merged) 10jenkins-bot: Pass through frequency_unit to TY page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1067365 (https://phabricator.wikimedia.org/T371848) (owner: 10Ejegg) [00:44:12] 06Fundraising-Backlog, 03Web Team Essential Work 2024, 10Web-Team-Backlog (Needs Prioritization (Tech)): Plan for Donate Wiki and Thank You Wiki Rollback and Redesign - https://phabricator.wikimedia.org/T361500#10119965 (10Jdlrobson) [00:45:52] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10119967 (10Cstone) [00:46:00] thanks for the CR cstone ! [00:51:49] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10119975 (10Cstone) >>! In T371523#10065889, @MSuijkerbuijk_WMF wrote: > Hi @Ejegg It looks good, the only change... [01:01:17] ejegg: on this comment looks like this is an issue with all monthly convert modals, ever see the background image overriding the color like this before? https://phabricator.wikimedia.org/T371523#10106697 [01:01:24] oh hah, adyen js is also broken on return from 3ds when showing monthly convert [01:01:38] ah, looking cstone [01:02:27] the logo is in the background image but the background color of the modal isn't overridng it but it is overriding the other elements of the page [01:02:56] yep, i see the same thing [01:03:10] let's see what king of tweak it needs [01:04:22] where's that 3-d stacked view they used to have in dev tools? [01:04:30] oooh is there one [01:10:45] ugh it has something to do with position: absolute I think [01:11:11] and that's on base mediawiki's div#mw-panel [01:11:49] ok ill just put it into its own task its probably been there the whole time [01:12:18] yah it's a matter of screen size [01:15:29] so if you get back from 3ds on the Adyen form with monthly convert enabled, it's actually throwing a JS error in the console. [01:15:35] 06Fundraising-Backlog: Foundation logo overlapping monthly convert modal in smaller screen sizes - https://phabricator.wikimedia.org/T374074 (10Cstone) 03NEW [01:16:01] since the adyen resultswitcher never sets the adyenConfiguration JS config var [01:16:06] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10120018 (10Cstone) >>! In T371523#10106697, @spatton wrote: > Hi @Ejegg , I am excited to test this! I and the b... [01:16:20] similarly, in gravy we don't set the secureFieldsScriptLink var [01:16:33] on the resultswitcher [01:17:28] we just get different manifestations of the error because adyen.js tries to access adyenConfiguration.environment.XX nested vars [01:17:50] but the gravy var is just used to set the script src without looking at any nested vars [01:18:08] so we get to the script.onError handling for gravy [01:18:22] I guess I'll fix the gravy one right in that same 3ds patch [01:18:29] and then do a different patch to fix adyen [01:20:49] 06Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface: JS error in console on Adyen form when coming back from 3DS with Monthly Convert enabled - https://phabricator.wikimedia.org/T374075 (10Ejegg) 03NEW [01:34:03] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10120034 (10Eileenmcnaughton) **Example 3** Import Row First Name : 'Bob & Mary' Last Name: "Smith" email: bob@example.org" Street address : 123 Main Street Existing contacts 1: First Name : 'B... [01:48:27] (03PS15) 10Ejegg: Setup 3DS flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060421 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [01:48:50] (03PS16) 10Ejegg: Setup 3DS flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060421 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [01:49:12] ok cstone that's solved the visual uglies, I think it's good to go [01:50:48] (03CR) 10CI reject: [V:04-1] Setup 3DS flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060421 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [01:51:01] derp, lint, I'm guessing? [01:53:12] (03PS17) 10Ejegg: Setup 3DS flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1060421 (https://phabricator.wikimedia.org/T367786) (owner: 10Damilare Adedoyin) [01:54:25] oh hmm, there's an attempt to deal with the resultswitcher in adyen js [01:54:32] if ( !configFromServer ) { [01:54:36] right in setup() [01:55:51] oh hah, but that's called in the onload function of a script whose src needs to be under configFromServer [01:56:55] k, we just move that check to the page ready handler [02:00:39] (03PS1) 10Ejegg: Stop JS console error on Adyen 3DS / MonthlyConvert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1070689 (https://phabricator.wikimedia.org/T374075) [02:02:49] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10FR-Adyen, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: JS error in console on Adyen form when coming back from 3DS with Monthly Convert enabled - https://phabricator.wikimedia.org/T374075#10120046 (10Ejegg) [02:40:25] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10120082 (10Eileenmcnaughton) Example 4 is an contact with prior engage giving The contact has 2 matches based on Name + address. Both have prior engage donations, they have different addresses -... [02:52:06] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10120088 (10Eileenmcnaughton) Example 5 is a contact with prior online giving & no prior engage giving There are 2 matches - which I will merge 1) Name + Address + different email 2) Address + ema... [03:17:31] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10120112 (10Eileenmcnaughton) The last one was a match with 2 contacts where both had - the same name - the same address - previous engage donations - no email One had only 1 donation, dating bac... [03:28:52] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10120113 (10Eileenmcnaughton) OK so my thinking is 1) let's see if @SHust has any capacity to do some deduping of the Group I created 'Engage' 2) let's consider doing a safe-merge attempt in the i... [06:40:45] (03CR) 10Thiemo Kreuz (WMDE): [C:03+1] "I can confirm the code does the same as before. Personally I find this more readable. 👍" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1069627 (owner: 10Umherirrender) [07:14:55] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10Recurring-Donations: Implement Post-Payment Monthly Convert variant for testing - https://phabricator.wikimedia.org/T371523#10120210 (10MSuijkerbuijk_WMF) @Cstone We should show the numbers and decimals in the same way we do in control,... [07:20:37] 06Fundraising-Backlog: [low priority] Investigate conditional Google's script addition for Google Ads Grant (fundraising) - https://phabricator.wikimedia.org/T374079 (10MSuijkerbuijk_WMF) 03NEW [08:25:01] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: Q1:codfw:frack network upgrade tracking task - https://phabricator.wikimedia.org/T371434#10120336 (10cmooney) >>! In T371434#10119784, @Papaul wrote: > The diagram below will outline the cabling of the new Fundraising n... [14:47:02] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121836 (10Jhancock.wm) [14:57:10] RECOVERY - Host pay-lb2002 is UP: PING OK - Packet loss = 0%, RTA = 30.46 ms [15:03:15] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121912 (10Papaul) [15:04:17] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121920 (10Papaul) [15:05:19] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121924 (10Papaul) [15:06:01] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121929 (10Papaul) [15:07:35] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121940 (10Papaul) @Dwisehaupt civi2002 and frpig2002 relocation complete. I am checking pay-lb2002 [15:11:45] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Relocate servers in C8 to make room for new Network devices - https://phabricator.wikimedia.org/T373893#10121968 (10Papaul) [15:30:28] (03CR) 10Wfan: [C:03+2] "check before we load the js make sense~ LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1070689 (https://phabricator.wikimedia.org/T374075) (owner: 10Ejegg) [15:46:38] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 10FR-Smashpig, 07payments-orchestration: Update Adyen listener to deal with Gravy transactions - https://phabricator.wikimedia.org/T372508#10122081 (10AnnWF) a:03AnnWF [15:46:56] thanks wfan ! [15:47:28] np [15:47:40] there's a parent patch there which could use review too, if you have time [15:47:56] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1060421 [15:53:45] 10fundraising-tech-ops: Fundraising access request for seddon - https://phabricator.wikimedia.org/T374126 (10Dwisehaupt) 03NEW [15:53:47] 10fundraising-tech-ops: Fundraising access request for hnordeen - https://phabricator.wikimedia.org/T374127 (10Dwisehaupt) 03NEW [15:55:31] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jtanner - https://phabricator.wikimedia.org/T356674#10122115 (10Dwisehaupt) 05Resolved→03Open Reopening to renew certificate for superset access. [15:56:47] 10fundraising-tech-ops: Fundraising access request for seddon - https://phabricator.wikimedia.org/T374126#10122121 (10Dwisehaupt) [15:57:27] 10fundraising-tech-ops: Fundraising access request for hnordeen - https://phabricator.wikimedia.org/T374127#10122124 (10Dwisehaupt) [16:08:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), 13Patch-For-Review: Add Address field, Description of service and PAN for any donation above INR 250k INR /3K USD - https://phabricator.wikimedia.org/T370583#10122170 (10RKumar_WMF) UPI declines are happeni... [16:20:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: 'Expected field payments_final_status bound for table payments_initial' failmails - https://phabricator.wikimedia.org/T374132 (10jgleeson) 03NEW [16:49:38] 06Fundraising-Backlog: [low priority] Investigate conditional Google's script addition for Google Ads Grant (fundraising) - https://phabricator.wikimedia.org/T374079#10122319 (10AKanji-WMF) p:05Triage→03Low [17:01:12] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10122394 (10MDemosWMF) @Eileenmcnaughton Thanks for the thorough investigation here! With Engage I believe the historical rule for their address data entry has been to match how it is written on the... [17:15:55] (03PS2) 10Umherirrender: Avoid assignment in condition in GatewayPage::renderResponse [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1069627 [17:16:09] (03CR) 10Ejegg: [C:03+2] "Yep, more readable. Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1069627 (owner: 10Umherirrender) [17:20:53] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frban2002 - https://phabricator.wikimedia.org/T369931#10122514 (10Papaul) @Dwisehaupt all good we had the netmask wrong [17:21:22] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q#:rack/setup/install payments200[456] - https://phabricator.wikimedia.org/T369942#10122515 (10Papaul) @Dwisehaupt all good we had the netmask wrong [17:25:13] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10122530 (10Papaul) @Dwisehaupt all good on this one as well [17:26:17] (03Merged) 10jenkins-bot: Avoid assignment in condition in GatewayPage::renderResponse [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1069627 (owner: 10Umherirrender) [17:26:18] (03Merged) 10jenkins-bot: build: Use inline ignore for Generic.CodeAnalysis.AssignmentInCondition [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1069630 (owner: 10Umherirrender) [17:34:26] (03PS12) 10Ejegg: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) (owner: 10Eileen) [17:40:52] 06Fundraising-Backlog, 07payments-orchestration: Display Gravy reconciliation ID in CiviCRM - https://phabricator.wikimedia.org/T374144 (10jgleeson) 03NEW [17:42:25] (03CR) 10Ejegg: [C:03+2] "Code looks good, works in smoke tests. Nice to know about about the api.prepare hook" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) (owner: 10Eileen) [17:42:52] 06Fundraising-Backlog, 07payments-orchestration: Display Gravy reconciliation ID in CiviCRM - https://phabricator.wikimedia.org/T374144#10122620 (10jgleeson) [17:46:33] (03PS2) 10Eileen: Move normalize tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067500 [17:46:50] (03CR) 10Ejegg: [C:03+2] Move normalize tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067500 (owner: 10Eileen) [18:00:55] (03PS6) 10Ejegg: Add currency conversion handling to Import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1070080 (https://phabricator.wikimedia.org/T368998) (owner: 10Eileen) [18:04:33] (03Merged) 10jenkins-bot: Move setting of Source from the queue code to the api layer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067464 (https://phabricator.wikimedia.org/T370483) (owner: 10Eileen) [18:07:33] (03Merged) 10jenkins-bot: Move normalize tests to the extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1067500 (owner: 10Eileen) [18:19:46] (03CR) 10Ejegg: [C:03+2] Add currency conversion handling to Import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1070080 (https://phabricator.wikimedia.org/T368998) (owner: 10Eileen) [18:28:55] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q#:rack/setup/install payments200[456] - https://phabricator.wikimedia.org/T369942#10122772 (10Dwisehaupt) @Papaul Thanks. Confirmed that I can get to the drac and will start building the host. [18:28:56] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frban2002 - https://phabricator.wikimedia.org/T369931#10122770 (10Dwisehaupt) a:05Dwisehaupt→03None @Papaul Thanks. Confirmed that I can get to the drac and will start building the host. [18:29:07] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Q1:rack/setup/install frdb200[45] - https://phabricator.wikimedia.org/T369920#10122773 (10Dwisehaupt) @Papaul Thanks. Confirmed that I can get to the drac and will start building the host. [18:40:55] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jtanner - https://phabricator.wikimedia.org/T356674#10122799 (10Dwisehaupt) 05Open→03Resolved Certificate renewed and sent via email. Password sent via SMS. Also reset the superset credentials at this time and sent thos... [18:41:28] (03Merged) 10jenkins-bot: Add currency conversion handling to Import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1070080 (https://phabricator.wikimedia.org/T368998) (owner: 10Eileen) [18:56:15] (03CR) 10Wfan: "LGTM, also looks good on mobile and the one without house number" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056568 (https://phabricator.wikimedia.org/T370583) (owner: 10Ejegg) [18:56:29] (03CR) 10Wfan: [C:03+2] Put Number on same line as Street [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056568 (https://phabricator.wikimedia.org/T370583) (owner: 10Ejegg) [19:03:32] 03Fundraising Sprint: quietlyBreakingThings(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: Fidelity import - addressee issue testing - https://phabricator.wikimedia.org/T373484#10122879 (10MDemosWMF) @Eileenmcnaughton Just tested this out - with results here: https://civicrm.wikimedia.org/civicrm/search... [19:24:05] (03Merged) 10jenkins-bot: Put Number on same line as Street [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1056568 (https://phabricator.wikimedia.org/T370583) (owner: 10Ejegg) [19:51:58] (03PS7) 10Wfan: Set address2/supplimental address to blank if N/A [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064801 [20:00:11] (03CR) 10Cstone: [C:03+2] "thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064801 (owner: 10Wfan) [20:00:29] Thanks cstone :) [20:00:45] (03PS3) 10Wfan: Set address2/supplimental address to blank if N/A [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068883 [20:01:03] (03Merged) 10jenkins-bot: Set address2/supplimental address to blank if N/A [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1064801 (owner: 10Wfan) [20:04:55] (03CR) 10Cstone: [C:03+2] "thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068883 (owner: 10Wfan) [20:05:09] sorry I never actually +2d it on monday I had tested it [20:06:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: "Zendesk TIckets" tab not showing related tickets on for some donors - https://phabricator.wikimedia.org/T374154 (10jgleeson) 03NEW [20:09:22] Np~ [20:14:19] (03Merged) 10jenkins-bot: Set address2/supplimental address to blank if N/A [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1068883 (owner: 10Wfan) [20:23:10] 06Fundraising-Backlog: Record duplicates when processing Engage import - https://phabricator.wikimedia.org/T374063#10123146 (10SHust) @Eileenmcnaughton and @MDemosWMF I reviewed the Engage group, and we can certainly assist by deduping records using the first+last name and address rule, as this appears to be the... [20:38:21] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1, Paypal:1, minFraud:1) 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [20:43:21] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1, Paypal:1, minFraud:1) 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [20:44:56] i just tagged a new version of smashpig [20:45:21] ^^ those are related to timeouts with payments2006. nothing affecting production work. [20:45:40] ACKNOWLEDGEMENT - check_log_messages on frav1003 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1, Paypal:1, minFraud:1) 3 [=1] Dwisehaupt known https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [20:45:44] i'm keeping an eye on it. [20:54:54] jgleeson: are you still around? [20:58:21] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [22:38:07] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: Q1:codfw:frack network upgrade tracking task - https://phabricator.wikimedia.org/T371434#10123557 (10Papaul) [23:35:03] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new firewalls - https://phabricator.wikimedia.org/T374176 (10Papaul) 03NEW [23:37:28] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new firewalls - https://phabricator.wikimedia.org/T374176#10123837 (10Papaul) [23:38:30] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: codfw:frack:rack/install/configuration new firewalls - https://phabricator.wikimedia.org/T374176#10123839 (10Papaul) [23:46:50] 06Fundraising-Backlog, 10FR-donorservices: CIDs with PayPal cancel date of 1969-12-31 need canceling on Paypals end - https://phabricator.wikimedia.org/T373947#10123858 (10Cstone)