[02:14:44] (03CR) 10Abijeet Patro: "Looks OK, but don't have rights to give CR +2" [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1091045 (owner: 10L10n-bot) [05:57:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [06:02:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [06:07:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [06:12:11] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 197500 Threads: 4 Questions: 136168769 Slow queries: 34 Opens: 3296 Open tables: 1598 Queries per second avg: 689.462 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [07:06:17] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make cancellation reason available to Acoustic - https://phabricator.wikimedia.org/T379206#10329936 (10MSuijkerbuijk_WMF) Hi @Eileenmcnaughton I checked on Acoustic and seems like the most_recent_cancel_reason field is pop... [08:50:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Add ability to attach pdfs to end of year emails - https://phabricator.wikimedia.org/T378677#10330107 (10krobinson) No, sorry, I don't want to open a new can of worms - it was just a suggestion if it was going to make things easier t... [14:30:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Transactions not found in Civi for the month of August'24 - https://phabricator.wikimedia.org/T378634#10331456 (10Damilare) Hi @RKumar_WMF, I can confirm the missing Fundraiseup transactions have been imported into Civi... [15:23:46] 10Wikimedia-Fundraising-Banners: Fundraising banner close tooltips pointing to wrong place? - https://phabricator.wikimedia.org/T378997#10331657 (10Pcoombe) [16:14:39] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1092279 [16:17:23] fr-tech we can just ignore those payment-method IPNs for now, right? [16:19:15] hi ejegg, haven't ssen those today [16:23:56] ejegg: damilare I wonder if they are related to michaels experimental regund [16:23:58] refund [16:25:03] right, possible [16:25:39] it does sound like a mapping bug [16:25:55] that eception is getting thrown here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/7320bea4e8742d35f431b40f950ba0bfbef0c0b9/PaymentProviders/Gravy/GravyListener.php#L104 [16:28:15] (03PS1) 10Ejegg: Update GravyMessage to make some properties nullable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092284 [16:28:45] ejegg: I'm not sure we want to ignore them [16:29:03] let's add some debug code to get the payload in that scenario so we can debug further [16:29:14] yh I'm wondering what the trigger is [16:29:19] yep make sense [16:29:42] we don't have much to on inside that method, I wonder if we can detect it earlier [16:29:47] or wrap the try catch [16:29:58] wrap with* a try catch [16:31:51] why not log the message on entry in the listener? [16:33:45] I think that might get noisy [16:33:50] how about this damilare [16:34:20] (just running tests) [16:35:26] they look sort of like this jgleeson: https://docs.gr4vy.com/guides/features/webhooks/payload [16:35:54] do we need them for some recurring transactions? [16:36:18] do you have a copy of the IPN? [16:36:25] we'd need to confirm from gravy as I'm not sure we've implemented those [16:36:31] just adding code to log them but it#s broken a test [16:36:37] like the ability to change payment method [16:36:46] damilare: we haven't - all those failmails on Friday were for not having the mapping [16:37:02] jgleeson it's on the docs, second tab [16:37:08] so we can make a log contents action [16:37:09] https://docs.gr4vy.com/guides/features/webhooks/payload [16:37:25] ah I see thanks [16:38:32] ahh, but then we would want to use that previously-unused $message property [16:38:52] (03PS1) 10Ejegg: Ignore 'payment-method' Gravy messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 [16:39:03] so ^^ was the patch I was making to drop them [16:39:10] but I'll do an alternate patch to log them [16:39:16] I'm doing that now ejegg [16:39:20] check above [16:39:54] ok, does the https://gerrit.wikimedia.org/r/1092284 cleanup here seem good to make that patch on top of? [16:40:27] (03PS1) 10Jgleeson: Add debug loggin to gravy IPN listener for unknown types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092287 [16:41:05] we've got an unknown type test that the code in that patch doesn't like [16:41:47] damilare: that *should* just log when we need it [16:44:41] hmm if we are switching over to gravy next monday we would want to code freeze on all gravy right? or are we not freezing at all then? [16:45:32] fixed it [16:45:44] (03PS2) 10Jgleeson: Add debug loggin to gravy IPN listener for unknown types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092287 [16:45:57] ejegg: damilare if we push that out we'll have messages logged. [16:46:11] and then I guess once captured we can ignore/supress them, [16:48:16] looking [16:48:40] ty [16:51:39] cstone: could you check this on your end see if pass on your end https://paymentstest6.wmcloud.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote&payment_method=google&recurring=1&uselang=en&language=en¤cy=USD&amount=10&country=US&first_name=Jimmy&last_name=Wales&street_address=1+Montgomery+Street&city=San+Francisco&state_province=CA&postal_code=94104&email=jwales%40example.com&debug=true [16:51:45] (03CR) 10Ejegg: [C:03+2] Add debug loggin to gravy IPN listener for unknown types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092287 (owner: 10Jgleeson) [16:51:48] cstone: I joined late. are we sending all card traffic to gravy? [16:51:49] thanks jgleeson [16:51:54] thanks ejegg [16:51:59] it was just talked about in the standup [16:52:07] all everything traffic i think? [16:52:13] @_@ [16:52:19] (03Merged) 10jenkins-bot: Add debug loggin to gravy IPN listener for unknown types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092287 (owner: 10Jgleeson) [16:52:25] anilk: Xeno1 greg-g please confirm ^ [16:53:05] wfan: I got an error 12355057.1 [16:53:39] jgleeson: it said after test on wednesday goes well but even if we delay it a couple of weeks its still the same situation [16:54:21] huh, fundraising_code_update didn't pull in the new code [16:54:25] it says merged here [16:54:56] cstone: https://phabricator.wikimedia.org/T367806 could you checkout those patches on your local see if those pass [16:56:12] we tried multiple times last Friday, I got all the patches applied, and oneitme works just this recurring failed with error as "cannot store payment method of type: googlepay" [16:56:14] oh man [16:56:27] I just completely forgot to merge it to deployment [16:56:29] that might help [16:57:22] jgleeson, what is it you're wanting me to confirm? [16:57:28] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092291 [16:57:55] XenoRyet: cstone mentioned that folks were talking about switching everything over to Gravy next Monday on today's call [16:58:12] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092291 (owner: 10Jgleeson) [16:58:30] No, that's not the plan as I understand it. [16:58:37] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092291 (owner: 10Jgleeson) [16:59:21] ejegg: damilare that change is out. we should start seeing the debug output in payents-listeners-smashpig [16:59:37] We're going to run the start of big English on our existing stuff, and then a couple of weeks in we'll try Gravy for cards, paypal, and Trustly if all goes well with this Wednesday's test. [16:59:42] awesome jgleeson [17:00:32] XenoRyet: sounds like verifying & documenting in that shared sheet from evelyn would be good :) [17:00:47] Yea, I'll do that. [17:06:13] PROBLEM - check_listener_ipn on frpig1002 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Unhandled internal server exception. - 280 bytes in 0.026 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1002&service=check_listener_ipn [17:06:45] the updated payment method message occurs when a card is renewed https://wikimedia.slack.com/archives/C070F1DVBRN/p1731949432649469?thread_ts=1731948590.319219&cid=C070F1DVBRN [17:07:00] cstone: nevermind, seems like Phillip found the issue and will have fix apply today. [17:07:00] it's safe to ignore [17:07:16] good news wfan 😂😂 [17:09:43] (03CR) 10Jgleeson: "Looks like we need a vendor submodule update to go with this one" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1090574 (owner: 10Ejegg) [17:10:58] haha I see, it's safe to ignore, good news~ thanks for noticing that damilare [17:11:13] RECOVERY - check_listener_ipn on frpig1002 is OK: HTTP OK: HTTP/1.1 200 OK - 445 bytes in 0.023 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1002&service=check_listener_ipn [17:11:54] ahh I meant its safe to ignore the payment method, and good news on the gravy gpay issue. [17:12:06] fr-tech, failmail wave was due to an unrelated patch with missing dependencies going live. I've rolled smashpig back [17:15:57] damilare: ah ok maybe we should just skip the debug step if gravy have confirmed it's expected and we should just get ejegg's ignore patches merged [17:16:46] sorry, i need to add to that normalize switch case [17:16:56] and i should probably add a test case jgleeson [17:17:00] 06Fundraising-Backlog: Monthly gift messaging on Annual gift via Paypal - https://phabricator.wikimedia.org/T380205 (10EMartin) 03NEW [17:17:09] I think we should keep both, since we might need the log for any other unsupported message [17:17:19] yeah, that sounds good damilare [17:17:25] np ejegg . also that other headers patch need a corresponding vendor update [17:17:36] fair enough damilare [17:18:01] I guess we can leave the try catch there [17:18:20] KISS - acronym [17:36:43] (03PS9) 10Damilare Adedoyin: Setup Gravy GooglePay payment provider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1084829 (https://phabricator.wikimedia.org/T367806) [17:42:43] (03PS2) 10Ejegg: Update GravyMessage to make some properties nullable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092284 [17:53:56] 06Fundraising-Backlog: Monthly gift messaging on Annual gift via Paypal - https://phabricator.wikimedia.org/T380205#10332872 (10EMartin) p:05Triage→03High [18:03:23] wfan your link works for me now on recurring [18:04:04] wow, let me verify that and then plus 2 [18:04:06] thanks [18:05:25] just replied Phillip, seems all good, will plus 2 thanks damilare [18:06:34] (03CR) 10Wfan: [C:03+2] "Works well now, previous recurring error was fixed by gravy,thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1084829 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [18:07:04] (03Merged) 10jenkins-bot: Setup Gravy GooglePay payment provider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1084829 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [18:07:46] Please fix the syntax error on your gravy.js, I will plus two there :) [18:10:10] awesome thanks [18:10:27] I should also update the smashpig too [18:10:34] so we can get them all in [18:23:14] (03PS10) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [18:25:46] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 [18:29:12] (03CR) 10CI reject: [V:04-1] Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [18:29:21] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [18:30:45] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [18:37:28] (03PS11) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [18:38:31] (03CR) 10Damilare Adedoyin: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [18:39:38] (03CR) 10CI reject: [V:04-1] Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [18:40:27] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [18:42:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10333109 (10SHust) Adding another, donor from CID 65632796 who was snoozed in Civi on 11/6 and got another RML on 11/18. Civi log: {F57718509} Acoustic... [18:44:04] (03PS2) 10Damilare Adedoyin: Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 [18:50:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10333158 (10bsisolak) What do you logs say about the API call? The API call failed, that data will be on your end I suspect. [18:56:52] (03PS12) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [18:57:06] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [18:58:42] (03CR) 10CI reject: [V:04-1] Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [19:00:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10333211 (10SHust) @NNgu-WMF do you know where the API log for a CID can be found? [19:02:50] (03PS13) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [19:04:45] (03CR) 10CI reject: [V:04-1] Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [19:07:01] (03PS14) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [19:09:52] (03Merged) 10jenkins-bot: Update smashpig to v0.8.23 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1092310 (owner: 10Damilare Adedoyin) [19:11:09] (03PS15) 10Damilare Adedoyin: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) [19:11:45] wfan the DI patch is now ready to review, TY! [19:11:54] ok checking [19:14:19] 06Fundraising-Backlog: Monthly gift messaging on Annual gift via Paypal - https://phabricator.wikimedia.org/T380205#10333252 (10EMartin) 05Open→03Resolved a:03EMartin closing this task as it is redundant to: https://phabricator.wikimedia.org/T379949 [19:17:04] (03CR) 10Wfan: [C:03+2] "LGTM, tested on both onetime and recurring :) Thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [19:24:52] (03PS1) 10Wfan: Add gravy google pay link [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1092320 (https://phabricator.wikimedia.org/T367806) [19:26:32] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1092320 (https://phabricator.wikimedia.org/T367806) (owner: 10Wfan) [19:27:01] thanks jgleeson~ [19:27:05] np! [19:30:27] (03Merged) 10jenkins-bot: Setup Gravy Google Pay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1084823 (https://phabricator.wikimedia.org/T367806) (owner: 10Damilare Adedoyin) [19:30:48] (03CR) 10Wfan: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:30:51] (03CR) 10Cstone: [C:03+2] "thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:31:02] 06Fundraising-Backlog, 10MediaWiki-extensions-WikimediaMaintenance, 10WikimediaMessages, 05FY2024-25 WE3.2 Donation Entry Points, 13Patch-For-Review: Donate sidebar link consistency (sitesupport-url) - https://phabricator.wikimedia.org/T379205#10333314 (10Jdlrobson) Web team discussed this today - we don... [19:31:07] haha wfan ahead of me [19:31:44] (03CR) 10Wfan: [C:03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:32:00] (03CR) 10Cstone: "order_id also got duplicated in the test" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:34:52] I do not see order_id duplicate haha [19:35:06] its in the test [19:35:43] (03CR) 10Wfan: [C:03+1] Add recipient_id to DonationData (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:35:53] I see, let's fix that in the other patch~ [19:35:57] (03CR) 10CI reject: [V:04-1] Add recipient_id to DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:37:16] since there was the follow on patch fixing the others i thought maybein that one? [19:41:29] (03CR) 10CI reject: [V:04-1] Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:48:01] (03PS3) 10Wfan: Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:50:59] (03PS4) 10Wfan: Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:50:59] (03PS2) 10Wfan: Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:52:20] thanks wfan, I'd have that deployed soon. [19:55:15] (03PS5) 10Wfan: Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:55:55] (03PS2) 10Ejegg: Add recipient_id to DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) [19:56:46] (03PS3) 10Wfan: Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:57:21] (03PS4) 10Wfan: Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:57:51] cstone: ok order_id got removed from that duplicate patch~ [19:58:28] (03CR) 10Wfan: [C:03+2] Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [19:58:36] (03CR) 10Wfan: [C:03+2] Add recipient_id to DonationData (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [19:59:08] (03CR) 10CI reject: [V:04-1] Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [20:06:25] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make cancellation reason available to Acoustic - https://phabricator.wikimedia.org/T379206#10333558 (10Eileenmcnaughton) @bsisolak are you able to advise here? [20:06:38] (03PS5) 10Wfan: Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [20:17:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [20:22:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [20:27:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [20:28:54] 03Fundraising Sprint: void(), 06Fundraising-Backlog: Paypal Giving Fund coding - Channel - https://phabricator.wikimedia.org/T379013#10333625 (10XenoRyet) 05Open→03Resolved [20:29:28] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 07fr-direct-mail, 07FR-Imports, 07Unplanned-Sprint-Work: Engage direct mail imports - https://phabricator.wikimedia.org/T378403#10333631 (10XenoRyet) 05Open→03Resolved [20:30:25] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-direct-mail, 07Unplanned-Sprint-Work: New Solicit Codes - https://phabricator.wikimedia.org/T374720#10333635 (10XenoRyet) 05Open→03Resolved [20:30:56] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), 07payments-orchestration: Gravy ACH (Trustly) - https://phabricator.wikimedia.org/T371810#10333638 (10XenoRyet) 05Open→03Resolved [20:31:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy dupe contributions cleanup - https://phabricator.wikimedia.org/T379941#10333643 (10jgleeson) So, this query counts all PayPal Gravy dupes. There's 2470. {P71081} and then amending it slightly to show the results {P71082} [20:31:16] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 07payments-orchestration: Gravy Audit Edge Cases - https://phabricator.wikimedia.org/T376655#10333644 (10XenoRyet) 05Open→03Resolved [20:32:10] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), 07payments-orchestration: Display Gravy reconciliation ID in CiviCRM - https://phabricator.wikimedia.org/T374144#10333649 (10XenoRyet) 05Open→03Resolved [20:32:11] PROBLEM - check_mysql on frdb1003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [20:33:06] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 07Epic, 07payments-orchestration: Gravy Paypal - https://phabricator.wikimedia.org/T376469#10333657 (10XenoRyet) 05Open→03Resolved [20:34:47] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 07Unplanned-Sprint-Work: By Nov 5: Changes to export templates: Donation and Recurring Status fields - https://phabricator.wikimedia.org/T378361#10333659 (10XenoRyet) 05Open→03Resolved [20:36:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Individual Matching Import Issue - Recurring - https://phabricator.wikimedia.org/T379171#10333662 (10XenoRyet) 05Open→03Resolved [20:37:04] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.3; 2024-11-12): 0.00 native Google Pay payment - https://phabricator.wikimedia.org/T376195#10333664 (10XenoRyet) 05Open→03Resolved [20:37:11] RECOVERY - check_mysql on frdb1003 is OK: Uptime: 249400 Threads: 4 Questions: 191398461 Slow queries: 48 Opens: 3796 Open tables: 1607 Queries per second avg: 767.435 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1359 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [20:38:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07Transaction-missing-in-CiviCRM: Settled Adyen transaction not in Civi - https://phabricator.wikimedia.org/T372670#10333666 (10XenoRyet) 05Open→03Resolved [20:40:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy Audit Download job failure - https://phabricator.wikimedia.org/T379902#10333675 (10XenoRyet) 05Open→03Resolved [20:41:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Get rid of some civi error when TY email - https://phabricator.wikimedia.org/T377895#10333683 (10XenoRyet) 05Open→03Resolved [20:42:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: 'Expected field payments_final_status bound for table payments_initial' failmails - https://phabricator.wikimedia.org/T374132#10333693 (10XenoRyet) 05Open→03Resolved [20:44:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Add in missing countries for adyen - https://phabricator.wikimedia.org/T349667#10333695 (10XenoRyet) 05Open→03Resolved [20:44:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Update utm_medium to wmf_medium for endowment - https://phabricator.wikimedia.org/T375147#10333722 (10XenoRyet) 05Open→03Resolved [20:47:44] 06Fundraising-Backlog, 07ContentSecurityPolicy: Add app.goacoustic.com to wikipedia.org Content Security Policy (CSP) - https://phabricator.wikimedia.org/T380232#10333737 (10Eileenmcnaughton) [20:57:52] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make cancellation reason available to Acoustic - https://phabricator.wikimedia.org/T379206#10333757 (10bsisolak) The best way to figure this out is to run a Values report on the database. Open the database, click Values. Th... [21:09:08] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10FR-Batch-Data-Entry: Batch data entry feature request: Save button - https://phabricator.wikimedia.org/T371546#10333775 (10MDemosWMF) Adding @BJordan-WMF to this task - Bre can you test this and make sure the auto save is indeed working? [21:17:46] 06Fundraising-Backlog, 06Privacy Engineering, 07ContentSecurityPolicy, 07Privacy: Add app.goacoustic.com to wikipedia.org Content Security Policy (CSP) - https://phabricator.wikimedia.org/T380232#10333805 (10Reedy) [21:20:23] 06Fundraising-Backlog, 06Privacy Engineering, 10Wikimedia-Site-requests, 07ContentSecurityPolicy, 07Privacy: Add app.goacoustic.com to wikipedia.org Content Security Policy (CSP) - https://phabricator.wikimedia.org/T380232#10333812 (10Reedy) [21:24:58] 06Fundraising-Backlog, 06Privacy Engineering, 10Wikimedia-Site-requests, 07ContentSecurityPolicy, 07Privacy: Add app.goacoustic.com to wikipedia.org Content Security Policy (CSP) - https://phabricator.wikimedia.org/T380232#10333818 (10greg) Hi Privacy team! This request is supporting our new SMS fundrais... [21:25:52] 06Fundraising-Backlog: auto rescue for one time payment - https://phabricator.wikimedia.org/T379987#10333827 (10AKanji-WMF) [21:27:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy dupe contributions cleanup - https://phabricator.wikimedia.org/T379941#10333829 (10AKanji-WMF) p:05Triage→03High [21:28:19] ejegg are you still updating the ignore payment-method patch? [21:29:23] (03PS3) 10Ejegg: Update GravyMessage to make some properties nullable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092284 [21:29:23] (03PS2) 10Ejegg: Ignore 'payment-method' Gravy messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 [21:32:34] (03CR) 10Damilare Adedoyin: [C:03+2] Update GravyMessage to make some properties nullable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092284 (owner: 10Ejegg) [21:32:47] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Updates to tags might not make it to Acoustic - https://phabricator.wikimedia.org/T379961#10333849 (10Eileenmcnaughton) a:03Eileenmcnaughton [21:32:56] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Updates to tags might not make it to Acoustic - https://phabricator.wikimedia.org/T379961#10333850 (10Eileenmcnaughton) [21:33:02] (03Merged) 10jenkins-bot: Update GravyMessage to make some properties nullable [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092284 (owner: 10Ejegg) [21:33:45] cstone: ready for Alphabetize's path review again thanks~ [21:33:58] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Updates to tags might not make it to Acoustic - https://phabricator.wikimedia.org/T379961#10333851 (10Eileenmcnaughton) [21:34:15] 03Fundraising Sprint: void(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Updates to tags might not make it to Acoustic - https://phabricator.wikimedia.org/T379961#10333855 (10Eileenmcnaughton) 05Open→03Resolved [21:35:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10dev-images, 10FR-Docker, 13Patch-For-Review: fundraising-tools-bullseye dev image depends on non-existent fundraising-bullseye-php73 - https://phabricator.wikimedia.org/T380134#10333840 (10AKanji-WMF) p:05Triage→03Low December - built to test... [21:45:09] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks ejegg for putting this in, looks good but the added test need a little refactor." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 (owner: 10Ejegg) [21:46:54] (03PS1) 10Ejegg: Update symfony/http-foundation [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/1092332 [21:49:12] hey ejegg, I guess I could also update the test as its just removing a couple of lines and +2 [21:49:54] (03PS3) 10Damilare Adedoyin: Ignore 'payment-method' Gravy messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 (owner: 10Ejegg) [21:50:24] (03CR) 10Damilare Adedoyin: "Thanks for all the work on this." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 (owner: 10Ejegg) [21:55:20] ejegg: did you deploy the Django change I can see tools was deployed but maybe that was cherry picked ? [22:05:42] (03CR) 10Ejegg: [C:03+2] Update symfony/http-foundation [wikimedia/fundraising/SmashPig/vendor] - 10https://gerrit.wikimedia.org/r/1092332 (owner: 10Ejegg) [22:12:43] cstone: I don't think so... let me see [22:16:17] (03PS4) 10Ejegg: Ignore 'payment-method' Gravy messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 [22:18:26] cstone ahh that was just for the silverpop stuff, no django deploy [22:18:45] shoot, I didn't see damilare|away's ping till too late [22:19:46] cstone: if you have a chance, could you maybe review https://gerrit.wikimedia.org/r/1092286 ? I think I fixed the copypasta as Dami suggested [22:20:41] * ejegg really needs to get IRC pings back. And irssinotifier just won't work on the Pixel... [22:20:56] i guess I need to install weechat / glowingbear [22:21:17] I see, this is the one to ignore the failmail about payment_method, looks good to me [22:21:23] thanks wfan [22:21:37] (03CR) 10Wfan: [C:03+2] "LGMT" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 (owner: 10Ejegg) [22:21:44] :) [22:21:46] Thanks for fixing that~ [22:22:05] (03Merged) 10jenkins-bot: Ignore 'payment-method' Gravy messages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1092286 (owner: 10Ejegg) [22:22:33] I also rebased your https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1091760/5 Alphabetize patch, if feels ok, I can plus two this one also [22:23:19] ah thanks, sure, sounds good! [22:23:27] (03CR) 10Wfan: [C:03+2] Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [22:23:40] (03CR) 10Wfan: [C:03+2] Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [22:25:19] (03Merged) 10jenkins-bot: Alphabetize lists in DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091760 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [22:25:20] (03CR) 10CI reject: [V:04-1] Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [22:26:49] (03Merged) 10jenkins-bot: Add recipient_id to DonationData [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091768 (https://phabricator.wikimedia.org/T379680) (owner: 10Ejegg) [22:26:56] (03Merged) 10jenkins-bot: Remove duplicate key in DonationData, update comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091765 (owner: 10Ejegg) [22:27:22] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092337 [22:27:24] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092337 (owner: 10Ejegg) [22:27:47] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1092337 (owner: 10Ejegg) [22:27:54] dang, I've got to pick up my kid. I'll try to get that deployed when I get home [22:28:16] sounds good, thanks ejegg~ [23:06:42] (03PS1) 10Eileen: Update phpspreadsheet for upstream security patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1092342 [23:09:41] 14Fundraising Sprint: meow(), 06Fundraising-Backlog, 10FR-donorservices, 10Recurring-Donations: Enable drop-down menu for DR to indicate recurring cancel reason - https://phabricator.wikimedia.org/T341247#10334126 (10Eileenmcnaughton) Just noting that these options have since been hard-coded into the A...