[00:21:10] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10385383 (10bsisolak) I'm now recalling something.... we've had this conversation before. Maybe... [01:21:05] (03PS1) 10Wfan: ignore mp_cancel for paypal IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100880 (https://phabricator.wikimedia.org/T337326) [01:22:59] 10Fundraising Refactor, 06Fundraising-Backlog, 10FR-Paypal, 10FR-Smashpig, 13Patch-For-Review: Invalid PayPal message type: mp_cancel - https://phabricator.wikimedia.org/T337326#10385443 (10AnnWF) This is not a subscription cancel, it's about billing agreement, similar to mp_signup and mp_notification, t... [01:23:51] 10Fundraising Refactor, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Paypal, and 2 others: Invalid PayPal message type: mp_cancel - https://phabricator.wikimedia.org/T337326#10385447 (10AnnWF) a:03AnnWF [01:44:31] 06Fundraising-Backlog: Failmail: Expected to find one Contact record, but there were zero. - https://phabricator.wikimedia.org/T381632 (10Cstone) 03NEW [01:45:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633 (10AnnWF) 03NEW [01:45:32] 06Fundraising-Backlog: Failmail: Expected to find one Contact record, but there were zero. - https://phabricator.wikimedia.org/T381632#10385508 (10AnnWF) this can closed due to duplicate T381633 [01:49:12] 06Fundraising-Backlog: Failmail: Expected to find one Contact record, but there were zero. - https://phabricator.wikimedia.org/T381632#10385511 (10greg) →14Duplicate dup:03T381633 [01:49:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10385513 (10greg) [01:49:30] jinx :) [01:52:13] 06Fundraising-Backlog, 10MediaWiki-extensions-WikimediaMaintenance, 10WikimediaMessages, 05FY2024-25 WE3.2 Donation Entry Points: Donate sidebar link consistency (sitesupport-url) - https://phabricator.wikimedia.org/T379205#10385534 (10tstarling) 05Open→03Resolved a:03tstarling I deleted them. [01:54:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10385537 (10AnnWF) [02:02:23] too slow greg-g [02:02:35] oh no mine got deletd [02:02:39] you still won greg-g ! [02:03:13] oh you killed it [02:03:13] rip [02:03:14] haha [02:14:18] 06Fundraising-Backlog, 10MediaWiki-extensions-WikimediaMaintenance, 07Chinese-Sites, 07Technical-Debt: Clean up onwiki fundraising cruft - https://phabricator.wikimedia.org/T136134#10385541 (10tstarling) 05Open→03Resolved a:03tstarling >>! In T136134#3428835, @Krinkle wrote: > (I cleaned up the r... [03:12:15] cstone: hah, yeah, sorry, wenjun just had more details :P [03:12:38] (03PS1) 10Wfan: Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [03:13:18] i didnt know if Jack had made one out there too he had been looking at it earlier [03:22:55] omg apple pay wasnt working because it just turned itself off on the mac [03:42:32] (03PS2) 10Cstone: WIP: Add ApplePay for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100582 (https://phabricator.wikimedia.org/T367785) [03:44:23] (03CR) 10CI reject: [V:04-1] WIP: Add ApplePay for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100582 (https://phabricator.wikimedia.org/T367785) (owner: 10Cstone) [07:16:39] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1100611 (owner: 10L10n-bot) [12:32:30] 06Fundraising-Backlog, 10MediaWiki-extensions-WikimediaMaintenance, 10WikimediaMessages, 05FY2024-25 WE3.2 Donation Entry Points: Donate sidebar link consistency (sitesupport-url) - https://phabricator.wikimedia.org/T379205#10386328 (10Pcoombe) Fantastic, thanks! [12:35:43] 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.5; 2024-11-25): Update web sidebar donation links to use wmf_ parameters - https://phabricator.wikimedia.org/T367361#10386345 (10Pcoombe) 05Open→03Resolved [12:55:46] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 10Temporary accounts: [Temporary Accounts] Update CentralNotice extension to support Temporary Accounts - https://phabricator.wikimedia.org/T374437#10386393 (10Tchanders) [12:56:23] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice, 10Temporary accounts (Major pilot wiki deployment): [Temporary Accounts] Update CentralNotice extension to support Temporary Accounts - https://phabricator.wikimedia.org/T374437#10386399 (10Tchanders) [14:45:12] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10386664 (10SHust) @Eileenmcnaughton, do you need more CIDs or do the ones here suffice? [16:59:41] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10387139 (10bsisolak) To document this, see https://help.goacoustic.com/hc/en-us/articles/36004... [17:12:00] (03PS1) 10Wfan: wip: update contact id if been merged [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101088 (https://phabricator.wikimedia.org/T381633) [17:33:56] (03CR) 10CI reject: [V:04-1] wip: update contact id if been merged [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101088 (https://phabricator.wikimedia.org/T381633) (owner: 10Wfan) [17:48:01] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10387284 (10SHust) Thanks for sharing the documentation about the re-sign up, @bsisolak. We’ll... [18:26:55] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10387385 (10bsisolak) I don't think there is an issue with the API calls either, the users are... [18:46:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review, 07Transaction-missing-in-CiviCRM: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10387483 (10AnnWF) [18:46:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10387486 (10AnnWF) [18:53:33] (03CR) 10Cstone: [C:03+2] ignore mp_cancel for paypal IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100880 (https://phabricator.wikimedia.org/T337326) (owner: 10Wfan) [20:43:32] (03CR) 10Eileen: "I think I would put this logic in DonationMessage::getContactID()" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101088 (https://phabricator.wikimedia.org/T381633) (owner: 10Wfan) [20:46:15] (03CR) 10Eileen: "I think I'd also push this to the DonationMessage class - maybe in 'cleanMoney()'" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [20:50:09] Cool, thanks eileen for the suggestion, we was about to ask your opinion. And I will add a unit test for this. [20:50:56] wfan: yeah - I guess those Message classes are intended to be the place where the data is converted from a semi-standard external format to a hopefully standard internal format [20:51:23] but then they also grew into a bit of DB look ups cos ... real life [20:51:46] & so now they are both standardisation & checking for existing [20:52:22] Haha, we think this might also related with that referring contact thing we just merged. [20:52:28] Cool [20:52:34] :-)