[03:14:35] 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223 (10Eileenmcnaughton) 03NEW [04:00:32] (03PS1) 10Eileen: Do not include annual donors in end of year emails. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104403 (https://phabricator.wikimedia.org/T379751) [04:00:34] (03PS1) 10Eileen: Do not set no_thank_you to 'recurring' if frequency_unit is year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104404 (https://phabricator.wikimedia.org/T379751) [04:25:26] (03CR) 10CI reject: [V:04-1] Do not include annual donors in end of year emails. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104403 (https://phabricator.wikimedia.org/T379751) (owner: 10Eileen) [04:25:35] (03CR) 10CI reject: [V:04-1] Do not set no_thank_you to 'recurring' if frequency_unit is year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104404 (https://phabricator.wikimedia.org/T379751) (owner: 10Eileen) [12:20:14] 10fundraising-tech-ops, 10VPS-Projects, 10Puppet (Puppet 7.0): Update puppet civicrm-prototype puppetmaster - https://phabricator.wikimedia.org/T361595#10405852 (10MoritzMuehlenhoff) What's the status, is the old puppet 5 puppet master already out of service? [13:03:00] (03PS5) 10Damilare Adedoyin: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 [13:03:35] (03CR) 10CI reject: [V:04-1] Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [13:04:13] (03PS6) 10Damilare Adedoyin: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 [13:09:03] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the review and the suggestion. I implemented the trait, it works just and simplifies things also." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [13:09:26] (03PS9) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [13:09:26] thanks damilare will check it out shortly [13:09:43] TY! [13:10:56] Did you finish signing up to Bupa btw? We had to use it again today to get Roxy an appointment with a doctor as she's struggling with a chest infection. [13:24:25] yep jgleeson, haven't used them yet but good to know we now have the option [13:24:37] nice [13:25:02] hope Roxy feels better also [13:30:15] ty [15:22:37] (03PS7) 10Damilare Adedoyin: Add new text for PayPal annual recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) [15:24:52] (03CR) 10CI reject: [V:04-1] Add new text for PayPal annual recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) (owner: 10Damilare Adedoyin) [15:28:09] (03PS8) 10Damilare Adedoyin: Add new text for PayPal annual recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) [15:43:54] (03CR) 10Damilare Adedoyin: "Thanks wfan and the good suggestion of adding a data provider, I've now updated the tests accordingly." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) (owner: 10Damilare Adedoyin) [16:47:31] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#10406711 (10AKanji-WMF) [16:48:47] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Mailings pages fail to load on prod Civi - https://phabricator.wikimedia.org/T290289#10406715 (10AKanji-WMF) 05Open→03Declined [16:50:08] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: recipient_id unexpectedly base64 encoded - https://phabricator.wikimedia.org/T381931#10406721 (10AKanji-WMF) [16:50:09] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: SMS testing - https://phabricator.wikimedia.org/T381809#10406722 (10AKanji-WMF) [16:50:12] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: 2024 Sprint X- Priorities - https://phabricator.wikimedia.org/T376751#10406724 (10AKanji-WMF) [16:50:53] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07fr-acoustic: U.S. Payments Wiki form variant with Phone Number and SMS opt-in - https://phabricator.wikimedia.org/T380106#10406730 (10AKanji-WMF) [16:50:55] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-donorservices, 07fr-acoustic: Civi: add new data type to Forget Me button - https://phabricator.wikimedia.org/T362821#10406731 (10AKanji-WMF) [16:50:56] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07fr-acoustic: Acoustic clarity issue on acoustic date fields as they relate to merged CiviCRM contact - https://phabricator.wikimedia.org/T354379#10406732 (10AKanji-WMF) [16:51:50] 06Fundraising-Backlog, 07fr-acoustic: Acoustic SMS stage 1 Scoping: Supporting SMS campaign functionality in Acoustic - https://phabricator.wikimedia.org/T365826#10406733 (10AKanji-WMF) [16:52:28] (03CR) 10Jgleeson: "Thanks for all the updates Dami! This is taking shape nicely. I left a few final minor inline points." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [16:54:52] (03CR) 10Wfan: [C:03+2] "Thanks, LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) (owner: 10Damilare Adedoyin) [16:56:53] (03Merged) 10jenkins-bot: Add new text for PayPal annual recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1100844 (https://phabricator.wikimedia.org/T379949) (owner: 10Damilare Adedoyin) [16:58:41] (03PS2) 10Wfan: ignore mp_cancel for paypal IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100880 (https://phabricator.wikimedia.org/T337326) [17:11:03] (03CR) 10Wfan: [V:03+2] ignore mp_cancel for paypal IPN [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1100880 (https://phabricator.wikimedia.org/T337326) (owner: 10Wfan) [17:12:07] (03PS7) 10Damilare Adedoyin: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 [17:18:59] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the CR, I added a response to some of your suggestions and renamed the Validator trait." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [17:19:51] thanks for the CR wfan [17:20:25] Sure nice to have the additional text! [17:58:41] (03CR) 10Jgleeson: "Thanks Dami. Responses inline" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:10:43] (03PS8) 10Damilare Adedoyin: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 [18:14:25] (03CR) 10Damilare Adedoyin: "thanks jgleeson for the review, I've updated the changes. I'm aware we can remove code during refactoring, I just don't want to muddle thi" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:17:15] thanks for the CR jgleeson|food, I don't think removing that unused code is priority at the moment. I think we can focus on moving on with the patch chain for now. [18:17:38] damilare: i guess that's subjective [18:18:08] if we've got code that we don't intend to use then merging that as new code feels wrong to me [18:18:13] do we plan to use it? [18:18:59] ok [18:19:37] did you catch my point about adding a comment for the two methods you felt might be used for paypal? those are fine [18:19:45] (03PS9) 10Damilare Adedoyin: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 [18:20:38] (03CR) 10WikiEditor5678910: "recheck" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:21:35] (03CR) 10Damilare Adedoyin: "thanks jgleeson, I've removed the validateCancelPaymentInput function from the validator class." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:21:40] (03PS10) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [18:22:11] (03CR) 10CI reject: [V:04-1] Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [18:22:36] damilare: are we actually validating the cancel api calls anywhere? or is there no input to valdiate. what's the history of that method [18:24:09] when the provider was first created, I was hoping to pass in an array param to the functions [18:24:50] but it turns out the cancelPayment method definition only requires the string parameter [18:24:57] ah I see [18:26:20] (03PS11) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [18:33:20] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the work on this and the overall improvements to our codebase!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:33:50] (03Merged) 10jenkins-bot: Refactor: Create payment provider validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1102877 (owner: 10Damilare Adedoyin) [18:35:34] thanks for the CR jgleeson [18:35:44] np. thanks for all the work [18:38:35] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1104712 [18:50:57] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1104712 (owner: 10Damilare Adedoyin) [18:52:11] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1104712 (owner: 10Damilare Adedoyin) [19:04:46] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.8; 2024-12-17): Annual Paypal donation checkout screen says 'monthly' - https://phabricator.wikimedia.org/T379949#10407203 (10Damilare) This has now been deployed with the label showing the annual description. {F58024315} [19:04:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10407204 (10jgleeson) @Eileenmcnaughton @Cstone @Wfan I haven't seen any of these failures over the weekend. Did we fix this one?... [19:09:20] 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10407214 (10EMartin) I previously confirmed the countries Adyen can support in this document: https://docs.google.com/spreadsheets/d/1GnmFM2VoXHcZJzRo-dLWq2Ndi4SKCb5... [19:09:21] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.8; 2024-12-17): Annual Paypal donation checkout screen says 'monthly' - https://phabricator.wikimedia.org/T379949#10407215 (10Pcoombe) Great, thanks @Damilare! I confirmed it from a banner link as well [19:12:13] jgleeson: it's not fixed just it causing fail mail is fixed [19:13:53] (03PS7) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [19:14:15] (03PS8) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [19:16:40] (03CR) 10CI reject: [V:04-1] Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [19:31:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10407246 (10AnnWF) Same here, I am not able to reproduce this bug with unit test locally, and this issue could marked as resolved wi... [19:33:04] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10407255 (10Eileenmcnaughton) I'm not sure if the timing fits but this may be a follow on https://phabricator.wikimedia.org/T382223 [19:38:59] 06Fundraising-Backlog: Apple Pay enablement across all browsers - https://phabricator.wikimedia.org/T382279 (10EMartin) 03NEW [20:01:33] (03PS2) 10Wfan: Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [20:02:50] (03PS3) 10Wfan: Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [20:19:33] (03PS4) 10Wfan: Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [20:19:39] (03CR) 10Cstone: [V:03+2 C:03+2] Add apple pay links [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1103306 (owner: 10Damilare Adedoyin) [20:20:11] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: Acoustic SMS stage 5 - update queue consumer support for SMS RML - https://phabricator.wikimedia.org/T376686#10407341 (10XenoRyet) 05Open→03Resolved [20:20:42] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: SMS testing - https://phabricator.wikimedia.org/T381809#10407344 (10XenoRyet) 05Open→03Resolved [20:21:19] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.4; 2024-11-19): Update donation interface such that recipient_id reaches donationn queue - https://phabricator.wikimedia.org/T379680#10407346 (10XenoRyet) 05Open→03Resolved [20:21:37] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.8; 2024-12-17): Annual Paypal donation checkout screen says 'monthly' - https://phabricator.wikimedia.org/T379949#10407351 (10XenoRyet) 05Open→03Resolved [20:21:54] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Add additional cancellation reason to Civi and Acoustic - https://phabricator.wikimedia.org/T380425#10407353 (10XenoRyet) 05Open→03Resolved [20:22:34] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: recipient_id unexpectedly base64 encoded - https://phabricator.wikimedia.org/T381931#10407355 (10XenoRyet) 05Open→03Resolved [20:23:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: Ensure contact_id/contact_hash params are passed from DonateWiki to PaymentsWiki - https://phabricator.wikimedia.org/T381405#10407358 (10XenoRyet) 05Open→03Resolved [20:24:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Fundraising: Incorrect utm_campaign on US END email send - https://phabricator.wikimedia.org/T381872#10407367 (10XenoRyet) 05Open→03Resolved [20:24:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.6; 2024-12-03): Fix "The 'timeZoneOffset' field is invalid" bug - https://phabricator.wikimedia.org/T380741#10407370 (10XenoRyet) 05Open→03Resolved [20:27:37] (03PS5) 10Wfan: Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [20:28:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Expected to find one Contact record, but there were zero - https://phabricator.wikimedia.org/T381633#10407399 (10XenoRyet) 05Open→03Resolved [20:29:08] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 06Privacy Engineering, 10Wikimedia-Site-requests, and 3 others: Add app.goacoustic.com to wikipedia.org Content Security Policy (CSP) - https://phabricator.wikimedia.org/T380232#10407405 (10XenoRyet) [20:53:15] (03CR) 10CI reject: [V:04-1] Make sure gross in DonationQueue is rounded to curreny's decimal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [21:24:33] (03PS6) 10Wfan: Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [21:28:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: gross value coming in as string for some paypal messages - https://phabricator.wikimedia.org/T381106#10407545 (10AnnWF) I believe this only happened 2 times in 11/28/2024, and nothing in the future, (plus all 197742821 13 previous f... [21:30:18] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Apple Pay enablement across all browsers - https://phabricator.wikimedia.org/T382279#10407549 (10XenoRyet) [21:30:57] 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10407554 (10XenoRyet) p:05Triage→03High [21:31:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10407556 (10XenoRyet) [21:32:31] 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10407562 (10XenoRyet) p:05Triage→03Medium [21:32:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10407564 (10XenoRyet) [21:33:05] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Next maintenance window - Add banner_history_id to civicrm contribution tracking table - https://phabricator.wikimedia.org/T357375#10407565 (10Dwisehaupt) [21:33:48] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Changes for annual recurring post-payments prompt - https://phabricator.wikimedia.org/T382088#10407571 (10XenoRyet) [21:34:09] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Imports: Thank you failing on lack of currency - https://phabricator.wikimedia.org/T381932#10407572 (10XenoRyet) 05Open→03Resolved [21:34:46] (03CR) 10Cstone: [C:03+2] "thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1102925 (https://phabricator.wikimedia.org/T382088) (owner: 10Pcoombe) [21:54:24] (03Merged) 10jenkins-bot: Changes for annual recurring post-payments prompt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1102925 (https://phabricator.wikimedia.org/T382088) (owner: 10Pcoombe) [22:52:53] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Importing Direct Mail Activities - https://phabricator.wikimedia.org/T381925#10407716 (10MDemosWMF) Thanks @Eileenmcnaughton! let me know when the grassroots file is in. FYI we are also going to work on getting the backlog data imported for DM mailings... [23:13:42] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Importing Direct Mail Activities - https://phabricator.wikimedia.org/T381925#10407737 (10Eileenmcnaughton) @MDemosWMF - so all we need to do when you get them is put them on the file server for you - once they are there you can import them - they show up... [23:14:13] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Importing Direct Mail Activities - https://phabricator.wikimedia.org/T381925#10407739 (10Eileenmcnaughton) Also - here is the in progress upload - https://civicrm.wikimedia.org/civicrm/queue/monitor?name=user_job_1903 it needs to get to around 160k rows [23:16:47] (03PS2) 10Eileen: Do not include annual donors in end of year emails. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104403 (https://phabricator.wikimedia.org/T379751) [23:16:48] (03PS2) 10Eileen: Do not set no_thank_you to 'recurring' if frequency_unit is year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1104404 (https://phabricator.wikimedia.org/T379751) [23:30:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10407758 (10Eileenmcnaughton) Looking at the first one of these[[ https://civicrm.wikimedia.org/ci... [23:48:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10407780 (10Eileenmcnaughton) OK - I found what is hitting donation queue consumer (donations_queu... [23:49:56] hey cstone or wfan looking at ^^ - just wanting to check in on my understanding [23:51:57] looking [23:54:09] Country isn't on the form eileen it's geolocated in the URL or chosen in the drop-down on donate wiki [23:54:31] cstone: ok - so that feels like it is a problem in at least some cases [23:54:45] ie cos it is wrong & the presumably don't get a chance to fix it? [23:54:58] It shouldn't have been en_gb though that's language looking [23:55:07] It should have been UK [23:55:21] sorry - yes GB [23:55:43] Ok yeah they can change it on donate wiki peter added a menu [23:55:53] But if they get to payments then the only way is editing the URL [23:56:12] the specific donor donated in 2022 with gb picked up & then it never got fixed... [23:56:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10407803 (10AnnWF) Yes, country is as hidden field, and only when we are getting unsupported curre... [23:56:56] I guess this is another reason for finishing that logging of the URL they were on when donating [23:57:29] so utm_source indicates an Acoustic email - "utm_source":"sp74642322.default~default~JimmyQuote~default~control.cc" [23:58:26] & landing page default~default~JimmyQuote~default~control [23:58:53] Also for future TY email will have the epc for them to select their country and prefer language [23:59:00] I guess is the issue that the country never got updated in civi [23:59:15] - so does that mean we emailed them a link direct to payments & from then on they never got presented with the country to fix? [23:59:40] No I think they just didn't change the donate form