[00:33:39] (03PS7) 10Eileen: Standardise activity type declarations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107076 [02:12:20] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107076 (owner: 10Eileen) [02:35:52] (03CR) 10CI reject: [V:04-1] Standardise activity type declarations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107076 (owner: 10Eileen) [02:54:34] (03CR) 10Eileen: [V:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107076 (owner: 10Eileen) [02:55:20] (03CR) 10Eileen: [C:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107100 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [02:55:52] (03CR) 10Eileen: [V:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107101 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [02:56:03] (03PS4) 10Eileen: Remove unused use, array formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107101 (https://phabricator.wikimedia.org/T376959) [02:56:06] (03CR) 10Eileen: [V:03+2] Remove unused use, array formatting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107101 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [02:56:53] (03CR) 10Eileen: [V:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107075 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [02:57:25] (03CR) 10Eileen: [V:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107100 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [02:57:37] (03PS4) 10Eileen: Add typing to a property [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107100 (https://phabricator.wikimedia.org/T376959) [02:57:46] (03CR) 10Eileen: [V:03+2] "test fails are date related - let's push through" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107100 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [08:42:16] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Remove unneeded constructor from CentralNoticePager [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108158 (owner: 10Umherirrender) [08:55:43] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Add @inheritDoc to functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108167 (owner: 10Umherirrender) [08:59:01] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] tests: Use TestingAccessWrapper instead of a Testing class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108160 (owner: 10Umherirrender) [09:07:48] (03Merged) 10jenkins-bot: Remove unneeded constructor from CentralNoticePager [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108158 (owner: 10Umherirrender) [09:08:39] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Remove or use own line for comments [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106001 (owner: 10Umherirrender) [09:25:31] (03Merged) 10jenkins-bot: tests: Use TestingAccessWrapper instead of a Testing class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108160 (owner: 10Umherirrender) [12:44:06] (03PS4) 10Eileen: Set retry interval more consistently in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107103 (https://phabricator.wikimedia.org/T376959) [12:44:21] (03CR) 10Damilare Adedoyin: [C:03+2] Set retry interval more consistently in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107103 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [12:45:17] (03PS11) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) [12:45:23] (03PS2) 10Eileen: Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) [13:07:43] (03CR) 10CI reject: [V:04-1] Set retry interval more consistently in tests [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107103 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [13:09:10] (03CR) 10CI reject: [V:04-1] Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [13:10:27] (03CR) 10CI reject: [V:04-1] Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [14:40:04] (03CR) 10Jforrester: [C:03+2] Use type-declaration on undocumented functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108165 (owner: 10Umherirrender) [14:40:23] (03CR) 10Jforrester: [C:03+2] Add function documentation [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108166 (owner: 10Umherirrender) [14:43:39] (03Merged) 10jenkins-bot: Use type-declaration on undocumented functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108165 (owner: 10Umherirrender) [14:46:14] (03Merged) 10jenkins-bot: Add function documentation [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108166 (owner: 10Umherirrender) [15:16:24] (03Abandoned) 10Jforrester: build: Updating cross-spawn to 7.0.6 [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1094882 (owner: 10Libraryupgrader) [15:20:00] (03Abandoned) 10Jforrester: build: Updating npm dependencies [extensions/FundraisingTranslateWorkflow] (REL1_41) - 10https://gerrit.wikimedia.org/r/997399 (owner: 10Libraryupgrader) [15:24:41] (03CR) 10Jforrester: [C:03+2] build: Updating mediawiki/mediawiki-phan-config to 0.15.0 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1104007 (owner: 10Libraryupgrader) [17:55:59] (03PS1) 10Ejegg: Update drush and symfony packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 [17:56:12] just some minor composer updates ^^^ [18:03:12] (03CR) 10Jgleeson: "This looks straightforward enough to +2, but I had a question about moving the assignment. Do we want to leave setBackendProcessorAndId() " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1091750 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [18:06:11] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 (owner: 10Ejegg) [18:08:45] ejegg: cstone's codex patch will like 1.43! https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1026946 [18:18:57] (03CR) 10CI reject: [V:04-1] Update drush and symfony packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 (owner: 10Ejegg) [18:20:14] oh lol, new year test, new date-related test fails [18:20:56] huh, that patch composer installed ok for me [18:22:06] https://www.irccloud.com/pastebin/ZIKbEl1o/ [18:22:21] argh! irccloud intercepting my paste [18:22:31] 18:18:52 1) Civi\WMFQueue\RefundQueueTest::testMarkRefundCheckWMFDonorData [18:22:31] 18:18:52 Undefined index: wmf_donor.total_2026 [18:22:41] 18:18:52 1) Civi\Api4\Action\WMFDonorTest::testWMFDonorGetAnnualRecurSegments [18:22:41] 18:18:53 Failed asserting that '500' matches expected 450. [18:22:53] looks unrelated ejegg ^ flaky test maybe [18:24:02] jgleeson: Yeah, it's a date-related calculation that's failing because it's now January of a new year :S [18:24:54] the other one - Undefined index: wmf_donor.total_2026 - seems like it could be a problem in production too, i.e. not calculating totals for this year [18:26:31] jgleeson: about the setBackendProcessorAndId happening in both places, I think should be fine. Could be useful in debuging payments that weren't completed but made it half way. What do you think? [18:26:49] damilare: yeah good point [18:26:57] thanks! [18:27:09] (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1091750 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [18:27:13] thanks for the CR! [18:27:19] np [18:31:01] (03Merged) 10jenkins-bot: Set backend processor and transaction id after capture [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1091750 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [18:31:18] (03PS3) 10Wfan: Add gateway adyen for cancel recurring queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1107349 (https://phabricator.wikimedia.org/T382833) [18:31:24] (03CR) 10Damilare Adedoyin: [C:03+2] "Looks good, thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1107349 (https://phabricator.wikimedia.org/T382833) (owner: 10Wfan) [18:31:53] (03Merged) 10jenkins-bot: Add gateway adyen for cancel recurring queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1107349 (https://phabricator.wikimedia.org/T382833) (owner: 10Wfan) [18:54:14] (03CR) 10Damilare Adedoyin: [C:03+2] If transaction_response null, set it up [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1107350 (https://phabricator.wikimedia.org/T382834) (owner: 10Wfan) [18:56:10] (03Merged) 10jenkins-bot: If transaction_response null, set it up [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1107350 (https://phabricator.wikimedia.org/T382834) (owner: 10Wfan) [18:58:57] (03PS5) 10Damilare Adedoyin: Populate backend processor and transaction id in approve payment result to ensure capture id is saved on Civi. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) [19:00:09] (03CR) 10CI reject: [V:04-1] Populate backend processor and transaction id in approve payment result to ensure capture id is saved on Civi. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [19:01:06] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [19:21:10] (03PS6) 10Damilare Adedoyin: Populate backend processor and transaction id in approve payment result to ensure capture id is saved on Civi. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) [19:29:41] (03CR) 10Eileen: [V:03+2] "giving this v+2 as it is date related fail" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107103 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [19:30:23] is someone digging into 1 or both of the new year test fails? [19:30:31] I can look but don't want to double up [19:32:29] HNY eileen. ejegg hit that failure with his composer patch [19:33:02] but he's gone afk so I'm guessing he put it down for now [19:33:26] OK - I can look [19:34:44] in other news. paypal is trying to offer us loans. should we get some fr-tech branded airpods? [19:41:07] lol [19:57:45] (03PS1) 10Eileen: Fix annual recur segment test to be relative to current date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108476 [19:58:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10433940 (10MBeat33) Another manual settle not in Civi: merchant ref: 227750668.1 payment reference JFF95KM783RQM8F6 / V... [20:03:01] (03CR) 10Jgleeson: [C:03+2] "Working for me locally. Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108476 (owner: 10Eileen) [20:13:03] (03CR) 10Wfan: [C:03+2] Populate backend processor and transaction id in approve payment result to ensure capture id is saved on Civi. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [20:17:01] (03PS1) 10Eileen: Adjust markRefundTest for new year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108478 [20:18:09] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Data-Engineering, 06Data-Platform, 10FR-Tech-Analytics: Allow Fundraising Supserset to connect to Production Druid - https://phabricator.wikimedia.org/T370944#10434024 (10VirginiaPoundstone) [20:22:45] (03CR) 10CI reject: [V:04-1] Fix annual recur segment test to be relative to current date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108476 (owner: 10Eileen) [20:23:35] (03Merged) 10jenkins-bot: Populate backend processor and transaction id in approve payment result to ensure capture id is saved on Civi. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1091752 (https://phabricator.wikimedia.org/T379943) (owner: 10Damilare Adedoyin) [20:23:40] (03CR) 10Eileen: [V:03+2] "pushing this through as it fixed one out of 2 new year related test fails" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108476 (owner: 10Eileen) [20:30:17] (03PS2) 10Ejegg: Update drush and symfony packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 [20:39:18] 06Fundraising-Backlog, 07Epic: DonationInterface JavaScript Modernisation - https://phabricator.wikimedia.org/T383087 (10jgleeson) 03NEW [20:40:49] sorry in advance to the US folks who see the 's' and think that should be a 'z' :) [20:42:47] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1108480 [20:43:01] lol jgleeson (or should I say jgleezon?) [20:43:12] ha! [20:43:30] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1108480 (owner: 10Eileen) [20:44:30] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/1108480 (owner: 10Eileen) [20:47:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Try to log more detail of client side script error - https://phabricator.wikimedia.org/T382623#10434161 (10XenoRyet) p:05Triage→03Low [20:48:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: log bin for bin attach - https://phabricator.wikimedia.org/T382538#10434163 (10XenoRyet) p:05Triage→03Low [20:48:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10434167 (10XenoRyet) p:05Triage→03High [20:49:18] !log tools upgraded from c7b53ecd to 6ddfb22f [20:49:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:49:43] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: Civi Export: What to do with the MatchingGifts file and mystery fields - https://phabricator.wikimedia.org/T338259#10434178 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:49:53] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: Civi Export: What to do with the MatchingGifts file and mystery fields - https://phabricator.wikimedia.org/T338259#10434179 (10Eileenmcnaughton) [20:54:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi cancelation button not working on two PayPal donations. - https://phabricator.wikimedia.org/T382426#10434224 (10XenoRyet) p:05Triage→03High [20:59:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi cancelation button not working on two PayPal donations. - https://phabricator.wikimedia.org/T382426#10434310 (10AnnWF) a:03AnnWF [21:01:41] this fixes the second one of the New Year test fails https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1108478 [21:04:16] (03PS2) 10Eileen: Adjust markRefundTest for new year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108478 [21:04:16] (03PS12) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) [21:04:17] (03PS3) 10Eileen: Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) [21:06:10] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi cancelation button not working on two PayPal donations. - https://phabricator.wikimedia.org/T382426#10434367 (10Ejegg) Sounds like we should catch this specific error message from the PayPal API and allow the Civi-side status update to go ahead, mayb... [21:18:37] 06Fundraising-Backlog, 10FR-Smashpig, 10FR-WMF-Audit, 13Patch-For-Review: PayPal audit processor and IPN listener should send payments to donations queue - https://phabricator.wikimedia.org/T366526#10434532 (10jgleeson) a:05jgleeson→03None [21:21:13] 06Fundraising-Backlog, 06Data-Engineering, 06Data-Engineering-Radar, 10MediaWiki-extensions-CentralNotice, 06Movement-Insights: Unique Devices seasonal trends on small projects - https://phabricator.wikimedia.org/T344381#10434575 (10VirginiaPoundstone) [21:21:22] fr-tech I just got to Dec 4 in my inbox and I see an EOD message from cstone saying the DjangoBannerStats change I made doesn't seem to be working (to stop counting hits from an IP address after X # in a day) [21:21:35] does anyone know if that was resolved? [21:23:15] I'm not sure ejegg I don't know if that was followed up [21:23:30] ejegg: yes. so. it's a long answer. [21:24:12] the changes you made didn't get deployed since the analytics hosts have their own f_c_u/rsync_blaster setup. and the code hadn't been run there. [21:24:58] _but_ it ended up being good that it hadn't, since the request hadn't been passed through the analytics folks and they were scared that the data model had shifted under them. [21:25:50] i think there wasn't full communication between who requested it (can't remember who) and the analytics team to make sure it was wanted by everyone. [21:27:31] dwisehaupt: sam patton was the one who most vehemently wanted it [21:28:54] i'd be thrilled if the analytics folks had some better way to filter out likely AI bot traffic [21:29:36] cause I was a bit worried about the run time increase for tracking all those individual hits in a table [21:30:16] So we should re-open that ticket and get Sam and analytics folks together, I guess [21:31:09] also maybe roll back the commit in the repo so we don't deploy it by accident with any fixes we might need to make [21:36:45] i think cstone did roll it back, but i could be wrong. [21:37:15] and to my knowledge, the analytics folks were going to reach out to sam and figure out what to do. [21:40:07] ok, cool [21:40:15] thanks for the update! [21:41:22] I'd be quite excited to get this & the follow on out there if anyone can +2 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1107102 [21:42:14] - they wouldn't 'do' anything until we schedule [21:44:32] (03PS2) 10Eileen: Remove old EOY data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107574 (https://phabricator.wikimedia.org/T380403) [21:45:49] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 (owner: 10Ejegg) [21:54:42] (03PS1) 10Eileen: Civix update for wmf-civicrm [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108487 [21:55:51] (03PS1) 10Jgleeson: Refactor: Add return type hints to gravy adapter. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1108488 [21:56:20] (03PS2) 10Jgleeson: Refactor: Add return type hints to gravy adapter. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1108488 [22:11:03] (03PS1) 10Jgleeson: Refactor: Mostly adding in some missing type hints [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108491 [22:14:14] eileen: looks like a good for someone to get their teeth into [22:14:40] although this made me @_@ e.g. "(but doesn't seem to work except on my local & hopefully prod....)" [22:14:58] jgleeson: yeah - it's kinda annoying that it is hard to run for most people cos it requires Acoustic to have your IP in there [22:15:04] ah I see [22:15:05] grrr [22:15:18] maybe one for tech-talk tomorrow> [22:15:24] yeah could demo it then [22:15:30] sounds good [22:15:43] might be a hard one to record without getting too much donor info tho [22:17:17] (03PS3) 10Eileen: Remove old EOY data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107574 (https://phabricator.wikimedia.org/T380403) [22:17:17] (03PS1) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [22:23:56] (03CR) 10Eileen: [C:03+2] Update drush and symfony packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 (owner: 10Ejegg) [22:30:44] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add wmf-cv to our dev environments - https://phabricator.wikimedia.org/T383097 (10Eileenmcnaughton) 03NEW [22:33:39] (03PS2) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [22:35:11] (03PS3) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [22:37:30] (03PS4) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [22:41:10] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10435702 (10Eileenmcnaughton) a:03Eileenmcnaughton We agreed on the option where we only include dono... [22:41:30] (03PS4) 10Eileen: Remove old EOY data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107574 (https://phabricator.wikimedia.org/T380403) [22:41:58] (03CR) 10Ejegg: [C:03+2] "Seems sensible. Anything that's been sent should have created an activity." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107574 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [22:42:06] (03CR) 10CI reject: [V:04-1] Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [22:44:23] (03CR) 10Ejegg: "one question inline" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [22:48:51] (03Merged) 10jenkins-bot: Update drush and symfony packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108460 (owner: 10Ejegg) [22:57:55] looks like a couple of composer updates in the pipeline [22:58:53] I could do the deploy merge and vendor update [23:01:31] (03CR) 10CI reject: [V:04-1] Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [23:02:27] (03PS1) 10Ejegg: Update drush and symfony packages [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1108503 [23:02:43] (03CR) 10Ejegg: [C:03+2] Update drush and symfony packages [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1108503 (owner: 10Ejegg) [23:06:33] (03Merged) 10jenkins-bot: Remove old EOY data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107574 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [23:24:26] (03PS5) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [23:24:58] (03PS6) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [23:25:17] (03CR) 10Eileen: Update EOYMakeJob to exclude one-off (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [23:25:44] (03Merged) 10jenkins-bot: Update drush and symfony packages [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1108503 (owner: 10Ejegg) [23:31:16] (03PS1) 10Eileen: Remove deprecated unused function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108505 (https://phabricator.wikimedia.org/T299096) [23:32:43] ejegg: I'm just trying to work my way through the various email classes to figure out what is going on - do you think we can remove `thank_you_batch_test()` fn ? [23:41:07] eileen i think we use that to benchmark still [23:41:14] but not exactly sure [23:42:06] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108506 [23:47:15] (03Abandoned) 10Eileen: Remove deprecated unused function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108505 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:48:20] (03CR) 10CI reject: [V:04-1] Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [23:51:40] (03PS1) 10Eileen: Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) [23:52:10] ejegg: what would we benchmark with it? [23:57:24] eileen: the db overhead of the thank you send, lookups + record creation