[00:05:04] hmm - I wonder when we actually do that - we wound up removing rather than migrating our queue performance stuff on the basis we could create it again if we want it [00:13:02] (03CR) 10CI reject: [V:04-1] Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:13:20] (03PS2) 10Eileen: Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) [00:17:26] eileen: probably fine to remove, then [00:17:47] hmm, I've got to hang it up, and I haven't nearly put in a full day with all these distractions [00:18:25] I'll do some PTO - chalking it up to family leave seems complicated [00:18:30] see you all tomorrow! [00:19:54] (03PS7) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [00:31:34] (03PS8) 10Eileen: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) [00:34:06] (03PS1) 10Eileen: Remove thank you test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108509 (https://phabricator.wikimedia.org/T299096) [01:05:23] 10fundraising-tech-ops, 10VPS-Projects, 10Puppet (Puppet 7.0): Update puppet civicrm-prototype puppetmaster - https://phabricator.wikimedia.org/T361595#10435861 (10Dwisehaupt) 05Open→03Resolved Closing this out since things have been ok with the new instances. [01:15:50] (03PS1) 10Eileen: Superficial cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108517 (https://phabricator.wikimedia.org/T299096) [01:15:52] (03PS1) 10Eileen: Remove deprecated function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108518 (https://phabricator.wikimedia.org/T299096) [03:52:58] (03PS1) 10Eileen: Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108526 (https://phabricator.wikimedia.org/T299096) [03:52:59] (03PS1) 10Eileen: Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108527 (https://phabricator.wikimedia.org/T299096) [03:52:59] (03PS1) 10Eileen: Declare parameters as an empty array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108528 (https://phabricator.wikimedia.org/T299096) [03:52:59] (03PS1) 10Eileen: Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) [03:53:00] (03PS1) 10Eileen: Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) [03:53:01] (03PS1) 10Eileen: Update Thankyou.send action to require less parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108531 (https://phabricator.wikimedia.org/T299096) [04:33:08] (03PS1) 10Eileen: Set preferred_language from contact if not provided [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108535 (https://phabricator.wikimedia.org/T299096) [04:44:38] (03PS1) 10Eileen: WIP - switch from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 [05:06:52] (03CR) 10CI reject: [V:04-1] WIP - switch from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (owner: 10Eileen) [12:25:42] (03CR) 10Jgleeson: Add v4 api Omniactivity.get & Omniactivity.load (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [14:00:57] (03CR) 10Jgleeson: [C:03+1] "This looks great. I really appreciate the extensive test coverage. I've +1ed as I'd like to try out the end-to-end test with the donation " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [14:11:34] thanks jgleeson, there was an issue on the gr4vy api that they seem to have fixed now. I'd test again and if all goes well, I'd take the DI patch out of wip [14:20:40] hmm actually the DI patch isn't in WIP, here's the completed DI patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1101583 [14:21:07] still testing to confirm the issue has been fixed, just thought to point that out. [14:25:19] damilare: you're right. I was getting mixed up with this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1100584 [14:26:49] ok great lemme know when its good to smoke test [14:33:44] np [14:49:49] jgleeson, it's still failing unfortunately. Can you help try it out on your side as well incase its an issue with my computer. You can also follow the conversation with gr4vy here: https://wikimedia.slack.com/archives/C070F1DVBRN/p1735820084753619 [14:50:35] I'll give it a whirl once I get back from the school run. [14:50:36] back soon [14:51:37] thanks! [15:34:24] ok it wasn't my machine, Philip found the issue and would be pushing out a fix shortly. [15:57:32] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108506 (owner: 10Ejegg) [15:58:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108506 (owner: 10Ejegg) [16:27:20] cool damilare [16:36:52] (03PS4) 10Jgleeson: WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [16:53:12] !log fundraising civicrm upgraded from 64cfe3a0 to d8ec1e91 [16:53:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:58:18] (03CR) 10CI reject: [V:04-1] WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [17:45:00] (03PS5) 10Jgleeson: WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [17:46:42] that patch is mostly working now ^ I just need to fix the test [17:47:46] (03PS15) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [17:48:00] (03CR) 10CI reject: [V:04-1] Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [17:49:49] (03PS16) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [17:51:13] (03CR) 10Ejegg: [C:03+2] Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [17:53:12] (03CR) 10Damilare Adedoyin: [C:03+2] Refactor: Add return type hints to gravy adapter. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1108488 (owner: 10Jgleeson) [17:55:07] (03Merged) 10jenkins-bot: Refactor: Add return type hints to gravy adapter. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1108488 (owner: 10Jgleeson) [18:07:26] (03CR) 10CI reject: [V:04-1] WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [18:13:07] (03Merged) 10jenkins-bot: Update EOYMakeJob to exclude one-off [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108496 (https://phabricator.wikimedia.org/T380403) (owner: 10Eileen) [18:42:41] damilare: I'm looking over the changes in this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1091750/4/PaymentProviders/Gravy/Factories/GravyApprovePaymentResponseFactory.php and it's got me wondering if there's any risks associated with setting that ID across two different API calls [18:43:30] atm I'm working on a patch to pull the backend processor data during the smashpig recurring charges and the create payment response is the "default" response to get that info from [18:43:58] do you foresee any code pulling that data from the subsequent approve payment response? [18:44:32] donate interface does so we can have the updated transaction id in civi [18:45:14] it was added in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1091752 [18:46:03] the reason is because, for paypal and adyen transactions the id on gravy is usually the one sent in the response of the approve payment api call. [18:47:29] if I remember correctly, currently we are only saving that of create payment, which makes it hard to identify some transactions on the dashboard. [18:47:50] so I found this patch damilare which looks like the patch that switched over to using the auth result https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1047493 [18:50:29] so I guess the question I have is, should we settle on one ? [18:50:48] having the same data across two different stages of the response feels error prone [18:51:01] ejegg|food: thoughts ^ [18:51:48] is there a scenario we know of where we're not going to auth the payment that would make sense to fallback to the create payment response? [18:51:57] it feels like that would justify it [18:52:49] hmm, to me it's like our current gateway_txn_id logic [18:53:16] on auth it's the auth transaction_id, on capture it becomes the capture transaction_id [19:01:59] hmm [19:02:43] I'll look over the code and see where and if we're using the backend ID for the first stage [19:05:29] do you mean using like in another api call? [19:06:52] if so, I don't think so, the usage is more of record keeping and identifying the transaction on the processor console. [19:19:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438417 (10MBeat33) It looks like the # of CIDs without emails is 1930 from the /referrals list. The scale of this kind of snuck up on us and I'm wonderi... [19:20:12] jgleeson|ish: ah yeah, we need the ID from the auth to make the capture call I think [19:20:53] I guess when we first made our data model we were using a processor which just had a single ID for each payment through all stages [19:21:11] and we didn't update the data model to be able to hold multiple processor-side IDs [19:22:07] we made this epic a long time ago: https://phabricator.wikimedia.org/T163947 [19:22:17] but didn't end up prioritizing it [19:23:32] oh I see [19:24:14] hmm I can't think of an easy way to explain that in the code [19:24:18] I guess we did add the gateway_session ID to hold that short-term token [19:25:47] (for at least paypal) [19:27:32] 14Fundraising Sprint Judgement Suspenders, 14Fundraising Sprint Loose Lego Carpeting, 06Fundraising-Backlog, 10FR-Smashpig, and 2 others: Epic: Support and normalize multiple payment identifiers - https://phabricator.wikimedia.org/T163947#10438471 (10Ejegg) [19:29:01] so I guess in the short term, I'll use the final one, capture/approve result, as the response to pull the backend IDs from [19:29:33] seems most likely to be the right one for the purposes of looking up stuff in civicrm [19:29:53] (03PS13) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) [19:32:46] (03PS1) 10Jgleeson: Update SmashPig to v0.8.25 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1108817 [19:34:28] damilare: I just pushed up the core and vendor patches to go with that the recent smashpig bump [19:37:16] sounds good, thanks jgleeson|ish [19:37:19] (03PS2) 10Jgleeson: Update SmashPig to v0.8.25 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1108817 [19:38:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438501 (10Eileenmcnaughton) @MBeat33 I can take a look but re the 'dedupe query' - what would you do with that? There are the merge links at the left -... [19:38:27] fr-tech I can't make tech-talk due to being on kid watch but should be around for the later calls [19:46:38] (03PS17) 10Damilare Adedoyin: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) [19:46:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438538 (10MBeat33) Thanks @Eileenmcnaughton I hadn't seen those links before. [19:48:32] (03PS9) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [19:50:19] (03CR) 10CI reject: [V:04-1] Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [19:51:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438558 (10Eileenmcnaughton) @MBeat33 yeah - I hoped it would make for a quick way to work through them - I seem to have merged about 20 just in my poki... [19:53:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438560 (10MBeat33) Thank you. I sorted the referrals list by clicking the column heading for //original donor -primary Email//, which seemed to be the b... [19:55:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438575 (10MBeat33) Also, does //everthing// on the /referrals list need merging? I exported the results and there were over 21k, but only 1930 were miss... [19:55:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438576 (10Eileenmcnaughton) One thing that struck me looking at them is that I hit a handful where the older contact had opted in & the newer one hadn't... [19:56:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438579 (10Eileenmcnaughton) @MBeat33 we are on https://meet.google.com/rvq-ygtd-xgm?authuser=0 atm - do you want to jump on? [20:00:08] (03CR) 10CI reject: [V:04-1] Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:18:26] 06Fundraising-Backlog, 10BDC-Implementation: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162 (10Arnis.dizdari) 03NEW [20:26:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10438668 (10Eileenmcnaughton) - Reply email block - is it too much - primary when they donate on one & received on the other [20:31:44] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:36:35] 06Fundraising-Backlog, 10BDC-Implementation: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162#10438731 (10Eileenmcnaughton) I think it can be NULL - we can update to that [20:43:35] 06Fundraising-Backlog, 10BDC-Implementation: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162#10438758 (10Arnis.dizdari) Yes, that works as well. [20:44:13] (03CR) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:46:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Dlocal submethod always cap, but in config we use lowercase - https://phabricator.wikimedia.org/T382554#10438760 (10Ejegg) Let's not do the lowercase transform as that will only work for mc - I think we need to make sure we are mappi... [21:01:38] (03CR) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [21:02:07] (03PS4) 10Eileen: Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) [21:08:57] (03PS1) 10Eileen: Fix invalid receipt date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108832 (https://phabricator.wikimedia.org/T383162) [21:16:40] (03PS2) 10Eileen: Fix invalid receipt date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108832 (https://phabricator.wikimedia.org/T383162) [21:16:42] (03CR) 10Ejegg: [C:03+2] Fix invalid receipt date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108832 (https://phabricator.wikimedia.org/T383162) (owner: 10Eileen) [21:17:50] ah derp, BDC = brooklyn data - i thought that ticket was referring to the community CRM instance at first, so I was confused why it had contrib dates at all [21:18:39] hah [21:29:33] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108838 [21:29:48] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108838 (owner: 10Eileen) [21:41:06] (03Merged) 10jenkins-bot: Fix invalid receipt date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108832 (https://phabricator.wikimedia.org/T383162) (owner: 10Eileen) [21:47:24] (03PS4) 10Wfan: Gr4vy suggest to add some explination for Trustly ACH [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1105826 (https://phabricator.wikimedia.org/T382559) [22:10:30] (03CR) 10Ejegg: "Can we take it out of composer.json too now?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [22:18:17] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174 (10SHust) 03NEW [22:20:36] (03PS2) 10Eileen: Remove thank you test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108509 (https://phabricator.wikimedia.org/T299096) [22:20:38] (03CR) 10Ejegg: [C:03+2] Remove thank you test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108509 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [22:22:07] (03CR) 10Ejegg: [C:03+2] "Oops, we should also remove the place this is called in thank_you.drush.inc: function drush_thank_you_send_test() {" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108509 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [22:27:56] (03CR) 10Jgleeson: [C:03+2] "Looks great. thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1105826 (https://phabricator.wikimedia.org/T382559) (owner: 10Wfan) [22:28:27] Thanks Jack :) [22:28:54] np! [22:32:10] (03Merged) 10jenkins-bot: Gr4vy suggest to add some explination for Trustly ACH [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1105826 (https://phabricator.wikimedia.org/T382559) (owner: 10Wfan) [22:35:25] (03CR) 10Jgleeson: [C:03+2] Update SmashPig to v0.8.25 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1108817 (owner: 10Jgleeson) [22:42:36] 06Fundraising-Backlog: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177 (10Dwisehaupt) 03NEW [22:43:06] 06Fundraising-Backlog: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177#10439104 (10Dwisehaupt) [22:43:13] (03Merged) 10jenkins-bot: Remove thank you test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108509 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [22:46:35] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.25 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1108817 (owner: 10Jgleeson) [22:50:24] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108848 [22:50:45] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108848 (owner: 10Eileen) [22:51:30] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1108848 (owner: 10Eileen) [22:51:54] ejegg: you aren't doing that second remove are you? If not I'll put up a patch [22:52:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177#10439117 (10AnnWF) [22:55:58] (03PS2) 10Eileen: Superficial cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108517 (https://phabricator.wikimedia.org/T299096) [22:56:08] (03CR) 10Ejegg: [C:03+2] Superficial cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108517 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [22:58:56] (03PS2) 10Eileen: Remove deprecated function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108518 (https://phabricator.wikimedia.org/T299096) [22:59:11] (03CR) 10Ejegg: [C:03+2] Remove deprecated function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108518 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:00:41] (03PS2) 10Eileen: Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108526 (https://phabricator.wikimedia.org/T299096) [23:00:44] (03CR) 10Ejegg: [C:03+2] Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108526 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:01:31] (03CR) 10Ejegg: [C:03+2] Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108527 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:02:06] (03CR) 10Ejegg: [C:03+2] Declare parameters as an empty array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108528 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:02:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177#10439145 (10Dwisehaupt) [23:05:25] (03PS2) 10Eileen: Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108527 (https://phabricator.wikimedia.org/T299096) [23:05:33] (03PS2) 10Eileen: Declare parameters as an empty array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108528 (https://phabricator.wikimedia.org/T299096) [23:05:44] (03PS2) 10Eileen: Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) [23:06:58] (03PS2) 10Eileen: Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) [23:07:00] (03PS1) 10Wfan: if paymentMehtod params do not have currency or language [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108851 (https://phabricator.wikimedia.org/T283627) [23:08:26] (03PS2) 10Wfan: if paymentMehtod params do not have currency or language [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108851 (https://phabricator.wikimedia.org/T383177) [23:11:23] (03PS3) 10Wfan: if params do not have currency or language or recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108851 (https://phabricator.wikimedia.org/T383177) [23:15:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177#10439182 (10AnnWF) a:03AnnWF [23:22:09] (03Merged) 10jenkins-bot: Superficial cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108517 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:24:47] (03Merged) 10jenkins-bot: Remove deprecated function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108518 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:24:48] (03Merged) 10jenkins-bot: Fix deprecation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108526 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:46:56] (03PS1) 10Eileen: Follow up removal of drush test fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108856 (https://phabricator.wikimedia.org/T299096) [23:47:13] ok ejegg I pushed in the second remove ^^ [23:50:07] (03PS2) 10Eileen: Follow up removal of drush test fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108856 (https://phabricator.wikimedia.org/T299096) [23:50:13] (03CR) 10Ejegg: [C:03+2] Follow up removal of drush test fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108856 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:51:05] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review Acoustic permitted IP addresses - https://phabricator.wikimedia.org/T383185 (10Eileenmcnaughton) 03NEW [23:52:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review Acoustic permitted IP addresses - https://phabricator.wikimedia.org/T383185#10439340 (10Eileenmcnaughton) [23:58:42] !log civicrm upgraded from d8ec1e91 to 82b02ce5 [23:58:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log