[00:07:05] (03PS1) 10Eileen: Remove phpmailer from composer.json [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) [00:08:04] (03PS1) 10Eileen: Remove legacy polyfill replaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108858 [00:09:43] (03PS3) 10Eileen: Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) [00:09:44] (03PS2) 10Eileen: Remove phpmailer from composer.json [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) [00:09:44] (03PS2) 10Eileen: Remove legacy polyfill replaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108858 [00:13:24] (03PS1) 10Eileen: Update phpunit related packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108860 [00:13:24] (03Merged) 10jenkins-bot: Follow up removal of drush test fn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108856 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:14:04] (03CR) 10Eileen: "Yes & no - we can remove from composer.json (done as a follow up) but it doesn't go away cos smashpig requires it" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:29:16] (03CR) 10CI reject: [V:04-1] Remove phpmailer from composer.json [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:29:22] (03CR) 10CI reject: [V:04-1] Remove legacy polyfill replaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108858 (owner: 10Eileen) [00:32:11] (03CR) 10CI reject: [V:04-1] Remove phpmailer from composer.json [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:49:01] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108528 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:49:24] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108527 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:51:16] (03CR) 10Eileen: "hmm the composer.json I thought I sorted -but it comes right in the next commit...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [00:52:24] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10BDC-Implementation: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162#10439416 (10Eileenmcnaughton) a:03Eileenmcnaughton OK -... [00:52:56] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10BDC-Implementation, 07Unplanned-Sprint-Work: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162#10439420 (10Eileenmcnaughton) [00:58:47] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Suppress opt in when contact hash in the url? - https://phabricator.wikimedia.org/T383189 (10Eileenmcnaughton) 03NEW [00:59:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10439433 (10Eileenmcnaughton) I created this regarding the ones who appear to have opted out inadvertently https://phabricator.wikimedia.org/T383189 [01:25:07] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 07fr-acoustic: Review what we do when a contact uses a url with a contact ID & hash but enters different details - https://phabricator.wikimedia.org/T383191 (10Eileenmcnaughton) 03NEW [01:26:49] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe, 07fr-acoustic: Review what we do when a contact uses a url with a contact ID & hash but enters different details - https://phabricator.wikimedia.org/T383191#10439492 (10Eileenmcnaughton) [01:29:14] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10439495 (10Eileenmcnaughton) I created https://phabricator.wikimedia.org/T383191 to cover the question for the ones that entered DIFFERENT emails [01:40:03] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Acoustic - review handling of 'opt outs' - https://phabricator.wikimedia.org/T383193 (10Eileenmcnaughton) 03NEW [01:40:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10439522 (10Eileenmcnaughton) I added https://phabricator.wikimedia.org/T383193 for the Comcast issue [01:47:08] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Fix dedupe merge wrapper script to track modified date - https://phabricator.wikimedia.org/T383194 (10Eileenmcnaughton) 03NEW [01:48:42] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Come July 1 we need to roll over the donor segment & status values - https://phabricator.wikimedia.org/T383195 (10Eileenmcnaughton) 03NEW [01:50:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10439557 (10Eileenmcnaughton) Hi @SHust - I see nearly half of these have been resolved now - I'm gonna move this to done at our end & leave in your camp... [02:08:47] (03PS3) 10Eileen: Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) [02:08:48] (03PS3) 10Eileen: Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) [02:08:48] (03PS2) 10Eileen: Update Thankyou.send action to require less parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108531 (https://phabricator.wikimedia.org/T299096) [02:08:48] (03PS2) 10Eileen: Set preferred_language from contact if not provided [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108535 (https://phabricator.wikimedia.org/T299096) [02:08:48] (03PS2) 10Eileen: WIP - switch from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 [02:27:25] (03PS3) 10Eileen: Switch thankyou.send from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (https://phabricator.wikimedia.org/T299096) [02:31:34] (03CR) 10CI reject: [V:04-1] Switch thankyou.send from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [02:32:41] (03CR) 10CI reject: [V:04-1] Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [02:37:12] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [03:07:35] (03PS1) 10Eileen: Simplify thank you code in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108870 (https://phabricator.wikimedia.org/T299096) [03:07:37] (03PS1) 10Eileen: Fold thank_you_send back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108871 (https://phabricator.wikimedia.org/T299096) [03:30:27] (03PS1) 10Eileen: Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) [03:30:28] (03PS1) 10Eileen: Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) [03:53:40] (03CR) 10CI reject: [V:04-1] Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [04:27:15] (03PS2) 10Eileen: Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) [04:49:26] (03CR) 10CI reject: [V:04-1] Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [04:52:56] (03CR) 10Eileen: [C:04-1] "actually - we still use it - just only in the smtp context" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [10:54:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10440209 (10krobinson) We have two sat in the queue: Moldova and Cambodia. Could we get a fix for them asap so we can close these ti... [13:01:09] (03CR) 10Damilare Adedoyin: [C:03+2] if params do not have currency or language or recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108851 (https://phabricator.wikimedia.org/T383177) (owner: 10Wfan) [13:01:39] (03Merged) 10jenkins-bot: if params do not have currency or language or recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108851 (https://phabricator.wikimedia.org/T383177) (owner: 10Wfan) [13:03:06] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#10440668 (10Damilare) Hi @Elbar53, has there been any reoccurrence of this issue since your last update? [13:06:24] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#10440676 (10Elbar53) I haven't had this issue repeat since I put in the phab task. [13:07:40] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#10440679 (10Damilare) Awesome, I'd move this to done now. We can pull it back out if it ever happens again. Thanks! [13:08:41] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: missing recurring donation record in civicrm_contritbution table - https://phabricator.wikimedia.org/T350754#10440689 (10Damilare) Looks like the last time we got this failmail was in November 2023, probably got fix... [13:10:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10440692 (10Damilare) a:03Damilare [14:21:41] howdy damilare. I moved the applepay stuuff back into doing. the backend patch is +2able but I'll hold out until we can do that end to end test. [14:22:39] hi jgleeson, ohh sorry I forgot to update yesterday. The bug has been fixed and we can now do the test [14:23:16] it was an issue with the gr4vy sdk, I've added a bump to the smashpig composer json [14:23:38] Philip released a new tag to fix [14:26:36] awesome! thanks I'll take a look before digging into Eileen's omnisuperpower patch [14:27:00] thanks! [14:57:28] 06Fundraising-Backlog, 10FR-Tech-Analytics: Update currency exchange rate data source to include rates for each day of the year - https://phabricator.wikimedia.org/T382359#10441202 (10IAckerman-WMF) [16:09:45] 06Fundraising-Backlog, 10FR-Tech-Analytics: Update currency exchange rate data source to include rates for each day of the year - https://phabricator.wikimedia.org/T382359#10441595 (10Ejegg) The currency markets are closed on weekends, so the exchange rate stays the same from close of business Friday to open o... [16:11:22] 06Fundraising-Backlog, 10FR-Tech-Analytics: Update currency exchange rate data source to include rates for each day of the year - https://phabricator.wikimedia.org/T382359#10441612 (10Ejegg) @IAckerman-WMF if you just need to simplify the ETL, we can update the Civi logic to add rows for Saturday and Sunday du... [16:24:26] ooh fr-tech, Drupal 7 EOL is finally real. Just got the email from drupal.org [16:34:45] 06Fundraising-Backlog, 10FR-Tech-Analytics: Update currency exchange rate data source to include rates for each day of the year - https://phabricator.wikimedia.org/T382359#10441704 (10JMando) @Ejegg another issue would be for holidays (assuming the same issue that markets are closed on holidays). Also I have... [16:37:26] (03PS1) 10Damilare Adedoyin: Map 'visadebit_applepay' payment method to allow successful audit imports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109114 (https://phabricator.wikimedia.org/T382498) [16:42:34] end of an era ejegg [16:46:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10441755 (10Damilare) @MBeat33 Thanks for putting this forward, I've ran the job to import the transa... [16:47:10] (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1105770 (https://phabricator.wikimedia.org/T382522) (owner: 10Wfan) [16:59:14] damilare: does applepay load for you here? https://paymentstest1.wmcloud.org/index.php?title=Special:GravyGateway&title=Special:GravyGateway&appeal=JimmyQuote&payment_method=apple&recurring=0&uselang=en&language=en¤cy=USD&amount=1.21&country=US&first_name=Jimmy&last_name=Wales&email=jwales%40example.com&debug=true [16:59:34] I'm testing both patches on my mac and not getting the pay button [17:00:06] checking [17:03:40] (03CR) 10Ejegg: "Seems totally functional from what I've reviewed so far. Just one suggestion for where to do the action mapping just in case another bulk " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [17:09:43] (03CR) 10Ejegg: [C:03+2] Map 'visadebit_applepay' payment method to allow successful audit imports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109114 (https://phabricator.wikimedia.org/T382498) (owner: 10Damilare Adedoyin) [17:10:27] (03Merged) 10jenkins-bot: Map 'visadebit_applepay' payment method to allow successful audit imports. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109114 (https://phabricator.wikimedia.org/T382498) (owner: 10Damilare Adedoyin) [17:15:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10441880 (10SHust) Ok to close this ticket and the entire list will be done by tomorrow. Thanks again, @Eileenmcnaughton! [17:24:33] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Check that end of year (EOY) email receipt templates are ready for January 2025 and send them - https://phabricator.wikimedia.org/T380330#10441898 (10SHust) @Eileenmcnaughton Would you be able to share details about this send, such as the estimated volum... [17:28:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10441905 (10MBeat33) Thank you so much, @Damilare. I will mention to our Adyen rep that them adding m... [17:30:58] (03Merged) 10jenkins-bot: Do not log 3rd party error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1105770 (https://phabricator.wikimedia.org/T382522) (owner: 10Wfan) [17:35:14] jgleeson: I'd do the civicrm smashpig vendor bump to get the adyen audit change out [17:35:52] is that one +2ed ? [17:36:07] yep ejegg|food did during standup [17:36:12] ah awesome [17:36:16] thanks [17:36:40] is there another patch you want in the smashpig tag? [17:41:20] no I don't think so. I need the bump to make the patch I'm working on, work [17:41:57] gonna get dinner started and once I get back I'll dig into why that applepay payment borked for me [17:42:50] (03PS1) 10Damilare Adedoyin: Upgrade smashpig to v0.8.25.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109122 [18:06:49] (03CR) 10Damilare Adedoyin: [C:03+2] Upgrade smashpig to v0.8.25.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109122 (owner: 10Damilare Adedoyin) [18:13:01] 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: Switch from metabase "open source" to "enterprise" - https://phabricator.wikimedia.org/T383256 (10Jgreen) 03NEW [18:33:27] (03Merged) 10jenkins-bot: Upgrade smashpig to v0.8.25.1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109122 (owner: 10Damilare Adedoyin) [18:43:37] 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: Switch from metabase "open source" to "enterprise" - https://phabricator.wikimedia.org/T383256#10442328 (10Jgreen) [18:44:53] (03CR) 10Ejegg: [C:03+2] Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [18:46:26] (03PS7) 10Wfan: Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) [18:46:41] (03CR) 10Ejegg: Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [18:46:44] (03CR) 10Ejegg: [C:03+2] Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [18:47:08] (03PS4) 10Eileen: Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) [18:48:46] (03CR) 10Ejegg: [C:03+2] "Looks good! TODO later: remove the \PHPMailer\PHPMailer\Exception catch above, and decide if we want to go back to making the malformed em" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:10:41] (03Merged) 10jenkins-bot: Clean up unused ref and add return value for getSettledAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1100881 (https://phabricator.wikimedia.org/T381106) (owner: 10Wfan) [19:11:18] 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: Switch from metabase "open source" to "enterprise" - https://phabricator.wikimedia.org/T383256#10442449 (10Jgreen) [19:13:58] (03PS4) 10Eileen: Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) [19:14:14] (03Merged) 10jenkins-bot: Handle email not being set [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108529 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:15:09] (03CR) 10Ejegg: [C:03+2] Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:29:27] (03PS3) 10Eileen: Update Thankyou.send action to require less parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108531 (https://phabricator.wikimedia.org/T299096) [19:31:21] damilare|brb: I'm getting failures due to the undefined gravy sdk method [19:31:38] I can see the gravy package bump in your smashpig patch [19:33:05] (03CR) 10Ejegg: [C:03+2] "Looks good! I wonder if we should set the contact_id in the parameters in thank_you.module to ensure that we don't have to do the extra db" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108531 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:33:18] ah it might be the lock file [19:33:29] on payments [19:33:34] I see you added it to smashpig [19:37:18] Cannot use gr4vy/gr4vy-php's latest version v0.24.1 as it requires php >=8.1 which is not satisfied by your platform. [19:37:22] interesting [19:37:35] oooh [19:37:50] docker@payments:/var/www/html$ php -v [19:37:50] PHP 8.2.7 (cli) (built: Jun 9 2023 19:37:27) (NTS) [19:37:54] @_@ [19:38:19] jgleeson it's the platform block in composer.json [19:38:20] (03Merged) 10jenkins-bot: Type hint fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108530 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:38:24] ahh [19:38:42] we use that to peg to the prod platform [19:38:51] I think we might be able to force past that [19:39:27] locally [19:39:56] but we can't deploy till prod is all updated ! [19:41:07] dwisehaupt: so assuming no more big problems show up on the bookworm payments host, what's the timeline look like for updating the rest? [19:41:38] oh right [19:41:54] assuming we are happy with the first, i can have the last 2 built and back online in less than a day. [19:42:01] nice [19:42:06] damilare|brb: we might have to ask them to retrofit that latest apple update to PHP 7.4 :) [19:42:25] ah nice dwisehaupt [19:42:54] the replicas are super simple, the origin db server i'll copy off the db since it's easier than an origin swap if we don't need to. [19:43:26] jgleeson: ah, the new Mediawiki LTS version needs php 8.1 too [19:44:32] i can easily up the amount of traffic to the current bookworm host and see if any other errors or warnings show up. and then move on to the other two. [19:45:08] at the current traffic levels i haven't seen anything aside from the 3 already reported warnings. [19:46:32] ok I'll put this down for a bit and move back to eileen's patch [19:47:59] ejegg: I realised we don't need the latest version of Gravy's SDK. The latest version is 0.24.1 but we only need 0.23.1 which is what damilare|brb has added to the apple pay patch so we might be ok in the intermin... once we can get it installing [19:48:47] damilare|brb: did you use your other method for injecting smashpig into payments? I wasn't able to install the required gravy SDK running `docker@payments:/var/www/html$ composer require gr4vy/gr4vy-php:0.23.2 -W [19:48:48] ` which I figured would be enough just to test it [19:48:56] damilare|brb: did you use your other method for injecting smashpig into payments? I wasn't able to install the required gravy SDK running `docker@payments:/var/www/html$ composer require gr4vy/gr4vy-php:0.23.2 -W` which I figured would be enough just to test it [19:52:59] (03PS3) 10Eileen: Set preferred_language from contact if not provided [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108535 (https://phabricator.wikimedia.org/T299096) [19:53:52] eileen: I guess a reinstall will fix this? [19:53:53] CRM_Core_Exception : Mandatory values missing from Api4 Activity::create: activity_type_id [19:54:01] (03CR) 10Ejegg: [C:03+2] "Looks good, seems like we're already setting the language in the batch send so shouldn't cause any extra DB lookups there." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108535 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:56:41] (03Merged) 10jenkins-bot: Update Thankyou.send action to require less parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108531 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:59:09] increasing the weight on payments1007 to 5% of the total [20:02:55] yep re:fixed by rebuilt [20:02:58] d* [20:04:58] (03CR) 10Jgleeson: Add v4 api Omniactivity.get & Omniactivity.load (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:12:34] yea jgleeson, I used that method. You can also install gravy on payments, I think that works [20:15:11] jgleeson, the 0.23.2 does not have the php 8.1 dependecy [20:17:26] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109143 [20:17:50] (03Merged) 10jenkins-bot: Set preferred_language from contact if not provided [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108535 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [20:19:19] (03PS14) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) [20:20:07] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.25.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1109144 [20:21:08] (03PS2) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109143 [20:22:26] (03PS2) 10Damilare Adedoyin: Update smashpig to v0.25.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1109144 [20:23:03] (03PS4) 10Eileen: Switch thankyou.send from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (https://phabricator.wikimedia.org/T299096) [20:23:18] (03PS2) 10Eileen: Simplify thank you code in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108870 (https://phabricator.wikimedia.org/T299096) [20:23:26] (03PS2) 10Eileen: Fold thank_you_send back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108871 (https://phabricator.wikimedia.org/T299096) [20:23:27] (03PS3) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109143 [20:32:06] (03CR) 10Jgleeson: [C:03+2] "LGTM and other folks on tech-talk. Thanks for all the work on this!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:36:01] (03PS2) 10Eileen: Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) [20:45:03] (03CR) 10CI reject: [V:04-1] Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:49:30] (03PS15) 10Eileen: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) [20:49:58] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.25.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1109144 (owner: 10Damilare Adedoyin) [20:50:19] (03CR) 10Jgleeson: [C:03+2] Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [20:51:54] damilare: apple pay payment worked! [20:52:04] awesome! [20:52:43] you can try out recurring and the charge as well. [20:55:05] (03Abandoned) 10Eileen: Remove phpmailer from composer.json [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108857 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [20:55:17] (03Abandoned) 10Eileen: Remove legacy polyfill replaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108858 (owner: 10Eileen) [20:55:24] (03Abandoned) 10Eileen: Update phpunit related packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108860 (owner: 10Eileen) [20:55:32] so i may have missed it. is the fix for these php8.2 warnings waiting on the smashpig version bump? [20:56:07] since if we are in a chicken/egg situation, we can look at upgrading the other 2 payments hosts and get past that blocker. [21:10:41] damilare: one minor thing. the cursor doesn't change to a hand when I hover over the button [21:11:05] you can tell how good my html/css skills are with that technical explanation [21:11:14] oh I can update that on the frontend [21:11:25] (03Merged) 10jenkins-bot: Update smashpig to v0.25.1 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1109144 (owner: 10Damilare Adedoyin) [21:12:28] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109143 (owner: 10Damilare Adedoyin) [21:14:11] (03Merged) 10jenkins-bot: Add v4 api Omniactivity.get & Omniactivity.load [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107102 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [21:18:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109143 (owner: 10Damilare Adedoyin) [21:23:32] jgleeson: that's weird, the cursor on mine actually changes to the pointer. [21:23:46] on both chrome and safari [21:24:32] huh, ok now it is for me. I'm now wondering how I got it to not show [21:25:09] hmm [21:25:35] ok scratch that request. I think I might have triggered an error and possibly broke it [21:26:36] I'm just xdebugging through the flow [21:27:00] slightly tricker initiating from one machine and debugging on the other :) [21:29:44] damilare: I noticed the returnURL has an uppercased V for visa payment_method=apple&payment_submethod=Visa [21:29:54] not sure if that matters but it stood out [21:30:12] ohh we should probably lower case everything [21:30:54] sounds good [21:33:05] I have to drop off now, I'd get to all the fixes and complete the civi deployment tomorrow. [21:36:56] sounds good. have a good night! [21:46:52] damilare|away: I just tested recurring apple pay via gravy and that looks good too! [21:47:58] I think we pass the returnURL on the frontend so I can +2 the smashpig patch as the backend all looks good and works well. that will allow you to tag smashpig, update the frontend patch and get that passing on CI [21:48:39] (03CR) 10Jgleeson: [C:03+2] "end-to-end test completed successfully for one-time and recurring! nice work" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [21:49:06] (03Merged) 10jenkins-bot: Implement Provider classes for Gravy apple pay integration [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1101564 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [22:16:10] (03PS2) 10Jgleeson: Refactor: Mostly adding in some missing type hints [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108491 [22:16:10] (03PS1) 10Jgleeson: Refactor: missing type hints for files in PaymentProviders/Gravy/ExpatriatedMessages/ [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 [22:16:45] (03PS2) 10Jgleeson: Refactor: missing type hints for files in ExpatriatedMessages [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 [22:17:20] (03PS3) 10Jgleeson: Refactor: missing type hints for Expatriated Message files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 [22:18:22] (03CR) 10Ejegg: Add snooze date to Acoustic-snoozed contacts (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:19:40] eileen: do you happen to know what happens if we send acoustic a snooze request via the API for the same date they're already snoozed until? [22:20:56] yeah I saw your comment - I *think* it's OK - I feel like we can push it out & try to do some 'real' tests on it - via the command line [22:22:38] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109177 [22:23:06] (03PS5) 10Eileen: Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) [22:23:17] (03PS1) 10Jgleeson: Refactor: missing type hints for Job files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109178 [22:23:32] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109177 (owner: 10Eileen) [22:24:19] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109177 (owner: 10Eileen) [22:27:11] !log civicrm upgraded from 82b02ce5 to 1c93f7a1 [22:27:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:27:40] (03CR) 10Ejegg: [C:03+2] Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:28:36] (03PS4) 10Jgleeson: Refactor: add type hints to Expatriated Message files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 [22:28:36] (03PS2) 10Jgleeson: Refactor: add type hints to Job files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109178 [22:28:36] (03PS1) 10Jgleeson: Refactor: add type hints to Maintenance files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109179 [22:29:18] (03PS2) 10Eileen: Rename AuditSnooze to VerifySnooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107345 (https://phabricator.wikimedia.org/T376959) [22:29:32] (03CR) 10Ejegg: [C:03+2] Rename AuditSnooze to VerifySnooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107345 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:30:38] (03PS2) 10Eileen: Fix mis-ordered parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107346 (https://phabricator.wikimedia.org/T376959) [22:30:40] (03CR) 10Ejegg: [C:03+2] Fix mis-ordered parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107346 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:34:07] (03PS5) 10Jgleeson: Refactor: add type hints to gravy expatriated message files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 [22:34:07] (03PS3) 10Jgleeson: Refactor: add type hints to gravy job files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109178 [22:34:07] (03PS2) 10Jgleeson: Refactor: add type hints to gravy maintenance files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109179 [22:34:08] (03PS1) 10Jgleeson: Refactor: add type hints to handful of remaining gravy files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109180 [22:36:28] anilk: I feel like I saw a ping from your somewhere but no idea where [22:36:43] on fredgy - but no worries [22:51:43] bye for now o/ [22:52:19] (03Merged) 10jenkins-bot: Add snooze date to Acoustic-snoozed contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107344 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:52:27] (03Merged) 10jenkins-bot: Rename AuditSnooze to VerifySnooze [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107345 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:53:23] (03Merged) 10jenkins-bot: Fix mis-ordered parameters [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107346 (https://phabricator.wikimedia.org/T376959) (owner: 10Eileen) [22:54:24] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109181 [22:54:37] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109181 (owner: 10Eileen) [22:55:05] did me running MakeJob start failmail? [22:55:28] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1109181 (owner: 10Eileen) [23:03:37] !log civicrm upgraded from 1c93f7a1 to 24f3b57f [23:03:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:08:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10443035 (10SHust) I have two tickets from Iceland who ran into the same issue and weren’t able to donate. [23:22:52] (03PS2) 10Eileen: Convert api calls to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1107347 (https://phabricator.wikimedia.org/T376959) [23:22:52] (03PS4) 10Eileen: Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) [23:22:52] (03PS1) 10Eileen: Make year optional in EOY email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109184 [23:28:40] just sent 100 thank yous taking 16 sec - gonna give Sandra a moment to check them & then try a bigger batch [23:33:25] cool cool [23:39:00] guess we should probably stop the other jobs when running makeJob next time! [23:39:48] (03CR) 10Ejegg: [C:03+2] Refactor: Mostly adding in some missing type hints [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108491 (owner: 10Jgleeson) [23:39:53] (03CR) 10Ejegg: [C:03+2] Refactor: add type hints to gravy expatriated message files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 (owner: 10Jgleeson) [23:40:19] (03CR) 10Ejegg: [C:03+2] Refactor: add type hints to gravy job files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109178 (owner: 10Jgleeson) [23:40:39] (03Merged) 10jenkins-bot: Refactor: Mostly adding in some missing type hints [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1108491 (owner: 10Jgleeson) [23:40:40] (03Merged) 10jenkins-bot: Refactor: add type hints to gravy expatriated message files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109175 (owner: 10Jgleeson) [23:40:43] (03CR) 10Ejegg: [C:03+2] Refactor: add type hints to gravy maintenance files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109179 (owner: 10Jgleeson) [23:40:55] (03Merged) 10jenkins-bot: Refactor: add type hints to gravy job files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109178 (owner: 10Jgleeson) [23:40:59] (03CR) 10Ejegg: [C:03+2] Refactor: add type hints to handful of remaining gravy files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109180 (owner: 10Jgleeson) [23:41:11] (03Merged) 10jenkins-bot: Refactor: add type hints to gravy maintenance files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109179 (owner: 10Jgleeson) [23:41:32] (03Merged) 10jenkins-bot: Refactor: add type hints to handful of remaining gravy files [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1109180 (owner: 10Jgleeson) [23:50:20] (03CR) 10Ejegg: "just curious about the impact of the change to thankyou_date update" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [23:51:37] (03PS1) 10Umherirrender: selenium: Wait for the page to be fully loaded in Page.openTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1109152