[00:49:43] 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10451872 (10Bugreporter) [12:58:56] (03PS4) 10Jgleeson: Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) [12:59:06] Krinkle: thanks for the heads up. I'll forward it on to pcoombe on Slack also [13:00:51] (03CR) 10CI reject: [V:04-1] Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) (owner: 10Jgleeson) [13:01:47] damilare: I don't think there's much left on that it just needs a few test updates. I keep meaning to get around to it [13:02:14] yh I thought so, I think it's a useful feature to have [13:02:27] was just checking if there's anyway I could help fast track it [13:04:42] feel free to take a peek and leave and comments or update the patch if you see any quick wins. I'll also try and get to it today as it had fallen off my list. I'm currently finishing the review on your gravy frontend patch [13:05:32] oh I was just going to ask if it's ok if I try to get the tests passing [13:05:44] I'd look into that [13:05:59] thanks for all the review on the apple pay stuff [13:19:11] (03PS7) 10Damilare Adedoyin: Update smashpig to v0.26 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1109409 [13:19:21] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.26 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1109409 (owner: 10Damilare Adedoyin) [13:27:12] (03Merged) 10jenkins-bot: Update smashpig to v0.26 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1109409 (owner: 10Damilare Adedoyin) [13:34:54] damilare: I noticed tests/phpunit/TestConfiguration.php was updated on the patch but there are no unit tests. Was that change needed for CI or something? [13:35:16] on the apple patch? [13:35:18] checking [13:35:25] yeah [13:36:14] yeah CI needs a value for the AppleScript added to the config [13:36:20] it's on 188 [13:36:33] is it worth copying over extensions/DonationInterface/tests/phpunit/Adapter/Gravy/GooglePayTest.php and adjusting for the the applepay difference to give us coverage of that new method? [13:36:44] maybe as a followon [13:37:00] or even add a ticket for it and we can get to it next sprint [13:38:31] sure I'd push that in a separate patch, so it doesn't block this. [13:39:45] sounds good [13:45:57] damilare: when testing locally, do you see these log lines on payments even though it doesn't fail? [13:45:58] 2025-01-13T13:45:00+00:00 ce2512e7d868 gravy_gateway: 230:230.4 Client-side debug messages: Apple Pay failure: http [13:46:17] checking [13:53:36] hmm [13:54:21] I see the client error on the tunnel link but not on localhost [13:55:22] its also on the browser and clicking into it shows the html template of the wikipage when the proxy is unavailable [13:56:21] the wikipage template also looks invalid as it is missing a closing html tag [13:59:05] yep I can confirm it has to do with the proxy template as it also sends the same log output for google and cc [13:59:57] the proxy template? [14:00:17] do you mean the page shown when the tunnelling isn't active [14:01:42] yea [14:02:13] ok that wasn't related to my issue [14:02:15] the site was loaded [14:02:50] although that's got me thinking how it would trigger payments logs via the tunnel link if the tunnelling wasn't active [14:03:04] my experience might have been down to debugging the requests [14:03:22] it happened for me as I was stepping through the session check [14:03:47] let me copy what I'm seeing on the logs when I refresh [14:03:56] the tunnel link [14:04:31] bear in mind that the tunnel is active and the page loads for me as well [14:04:45] I think there's some redirect happening in the background [14:04:50] here's the log: [14:05:06] [message] => SyntaxError: Unexpected token '<' [file] => https://paymentstest3.wmcloud.org/load.php?debug=1&lang=en&modules=site&only=scripts&skin=vector&version=ztntf [line] => 1 [col] => 0 [userAgent] => Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.0.1 Safari/605 [14:05:23] that's mine [14:05:24] https://phabricator.wikimedia.org/P72007 [14:05:27] 2025-01-13T14:02:12+00:00 d6f9cdb3c64a gravy_gateway: 373:373.1 Client side error: Array ( [message] => SyntaxError: Unexpected token '<' [file] => https://paymentstest3.wmcloud.org/load.php?debug=1&lang=en&modules=ext.donationInterface.employerAutoComplete% [14:07:28] I think it might have been due to some weirdness with debugging the request because I've just put through two successful requests without debugging turned on and I don't see that log line anymore [14:08:44] that's possible, I don't see any results when I do that grep on my logs [14:19:16] (03CR) 10Jgleeson: [C:04-1] "Thanks Dami. Local payments tests were successful! I did spot a few small things we could polish, which I've left further info about inlin" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [14:21:12] not much to change there dami ^ however I think we might have broken the setting of paymentOrchestratorReconciliationId somewhere along the way. I'm not seeing them coming back for gravy now [14:21:44] although it's not the frontend back. I think that might be in the backend updates and it was missed [14:21:52] -back [14:22:12] I noticed when importing the donations into civicrm [14:35:55] ohh, is that for apple pay or generally? [14:36:27] generally I think [14:45:21] (03PS7) 10Jgleeson: WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [15:08:25] (03CR) 10CI reject: [V:04-1] WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [15:10:06] (03PS16) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [15:11:53] (03CR) 10CI reject: [V:04-1] Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [15:18:24] (03PS17) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [15:27:09] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the CR, I've added the test and make the corrections as suggested." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [16:08:59] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops, 06SRE: Manage frack switches with Netbox - https://phabricator.wikimedia.org/T268802#10454053 (10cmooney) [16:24:43] oh man this flaky test that I can't replicate locally is tricky [16:27:17] (03PS8) 10Jgleeson: WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [16:44:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10454285 (10RKumar_WMF) Cambodia - supported via Adyen accepted currency KHR. Moldova - Not supported via Adyen so it is unaccepted... [16:48:55] jgleeson: did you see the changes I made on the apple pay patch? [16:49:32] no not damilare I'm trying to get my patch passing on CI and then I'll circle back to it [16:49:46] no not yet* [16:50:11] no worries, lemme know if you need any help with that also [16:50:38] Thanks Krinkle, changing MediaWiki:Mainpage to Special:FundraiserRedirector worked great! [16:51:33] huh that's interesting. the failing test took 15s on CI [16:51:54] it takes 1s on local [16:52:02] It also solved the long term annoyance of getting redirected to foundationwiki after logging in to donatewiki :) [16:53:01] well that's annoying ^ :) [16:55:10] (03CR) 10CI reject: [V:04-1] WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [16:56:55] ah ok so it's the return values on CI [16:56:59] interesting [16:57:03] why would they be different [16:57:16] fixture leftovers maybe from earlier tests [17:05:57] argh [17:06:05] I'll check back in on your patch damilare [17:07:52] thanks! [17:08:05] 06Fundraising-Backlog: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587 (10JScherer-WMF) 03NEW [17:09:10] damilare: the code extractions look great! I can see see magic number 3 though [17:09:17] -see [17:09:24] I guess I've seen it twice now [17:09:26] :D [17:09:26] number 3? [17:09:39] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1101583/15..17/gravy_gateway/forms/gravy.js#b384 [17:09:51] "let's make this a variable and describe the intent of the value in the var name." [17:10:42] damilare: better link - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1101583/17/gravy_gateway/forms/gravy.js#413 [17:10:47] ohh I read that wrong, I thought you meant the function below it [17:11:20] I think I got it from apple pay's page,I'd check back on the docs and fix that [17:11:39] oh I see [17:11:43] i guess I got two for one then :D [17:11:52] ty [17:12:04] lol [17:12:09] yea its the version number [17:12:12] I'll test out apple pay payments across adyen & gravy and give google pay a once over [17:14:50] Apple Pay working well for both gravy and adyen after changes [17:16:40] 06Fundraising-Backlog: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10454472 (10KSarabia-WMF) [17:22:51] damilare: googlepay isnt working for me on the new code or the old code [17:23:08] are you able to pay with googlepay on master / your patch? [17:23:12] via gravy [17:23:17] ok I got the 3 from gr4vy's docs, but looking at apple pay doc looks like they have higher versions that support more methods [17:23:24] payment methods* [17:23:40] with the caveat of not supporting browsers on older OS [17:23:44] checking [17:23:50] re:google-pay. it works via adyen but not gravy [17:25:00] yh I think that's because of that connector Philip asked me to remove on sandbox [17:25:16] I'd reach out to him to confirm [17:29:32] (03PS18) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [17:31:21] (03CR) 10CI reject: [V:04-1] Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [17:32:56] (03PS19) 10Damilare Adedoyin: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) [17:37:28] pcoombe: thx! [17:41:47] gonna grab some food [17:55:20] 06Fundraising-Backlog: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10454819 (10Damilare) Adding @Pcoombe for visibility of online fundraising. [18:57:33] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the update. This looks great and is working well for me. Thanks dami!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [19:00:05] damilare|brb: The Google Pay issues are outside of that patch as it's still broke on master so I don't think that blocks your Apple Pay patch, which is good to go! [19:10:04] (03Merged) 10jenkins-bot: Setup Gravy Apple Pay front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1101583 (https://phabricator.wikimedia.org/T367785) (owner: 10Damilare Adedoyin) [19:18:30] thanks jgleeson [19:25:50] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1110836 [19:27:21] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1110836 (owner: 10Damilare Adedoyin) [19:31:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1110836 (owner: 10Damilare Adedoyin) [19:45:35] (03PS9) 10Jgleeson: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [19:45:47] eileen: I might need your help on this one ^ [19:46:06] I'm chasing a test locally that is failing on CI but passing locally [19:46:46] I'm pretty sure that last update isn't going to fix it but I figured I'd test it anyhoo [19:54:59] relocating for call. back soon! [19:59:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14): Clear some non-us client side error log - https://phabricator.wikimedia.org/T382522#10455479 (10AnnWF) Since Adyen is not going to fix this error Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML,... [20:08:28] (03CR) 10CI reject: [V:04-1] Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [20:27:40] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14): Make sure Gravy backend processor transaction ID is the capture id - https://phabricator.wikimedia.org/T379943#10455629 (10XenoRyet) 05Open→03Resolved [20:28:04] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10BDC-Implementation, 07Unplanned-Sprint-Work: Bug in "civicrm"."civicrm_contribution" table column "receipt_date" where the date field is denoted as 0 instead of a valid date - https://phabricator.wikimedia.org/T383162#10455632 (10XenoRyet) 05O... [20:28:25] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), 07payments-orchestration: Trustly form UI change suggested by Gr4vy (gravy) - https://phabricator.wikimedia.org/T382559#10455636 (10XenoRyet) 05Open→03Resolved [20:28:46] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Batch-Data-Entry: Upstream batch data entry soft credit fix - https://phabricator.wikimedia.org/T381328#10455638 (10XenoRyet) 05Open→03Resolved [20:29:03] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: FundraiseUp testing Q2 - 2425 - https://phabricator.wikimedia.org/T377732#10455640 (10XenoRyet) 05Open→03Resolved [20:29:15] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 07fr-acoustic: Civi Export: What to do with the MatchingGifts file and mystery fields - https://phabricator.wikimedia.org/T338259#10455642 (10XenoRyet) 05Open→03Resolved [20:29:54] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Importing Direct Mail Activities - https://phabricator.wikimedia.org/T381925#10455644 (10XenoRyet) 05Open→03Resolved [20:30:18] 03Fundraising Sprint: XenoRyet(), 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.44-notes (1.44.0-wmf.8; 2024-12-17): Changes for annual recurring post-payments prompt - https://phabricator.wikimedia.org/T382088#10455646 (10XenoRyet) 05Open→... [20:31:35] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Suppress Annual recurring donors from January receipt. Set up a receipt right after the yearly donation is processed - https://phabricator.wikimedia.org/T379751#10455654 (10XenoRyet) 05Open→03Resolved [20:33:17] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Request to please begin the deployment of the Auto TY email receipt ("End of Year Receipt") on January 13th (date changed from Jan 6th) - https://phabricator.wikimedia.org/T381781#10455674 (10XenoRyet) 05Open→03Resolved [20:33:28] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog: Check that end of year (EOY) email receipt templates are ready for January 2025 and send them - https://phabricator.wikimedia.org/T380330#10455677 (10XenoRyet) 05Open→03Resolved [20:34:32] 14Fundraising Sprint: UnusedFunctionButDontDeleteItIncaseItsUsed(), 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Civi "thank you letter summary" feature request - https://phabricator.wikimedia.org/T299096#10455682 (10XenoRyet) 05Open→03Resol... [20:35:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: smash-pig warnings after bookworm / php 8.2 upgrade - https://phabricator.wikimedia.org/T383177#10455686 (10XenoRyet) 05Open→03Resolved [20:36:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: check gateway in message recurringQueueConsumer for subscr_cancel - https://phabricator.wikimedia.org/T382833#10455689 (10XenoRyet) 05Open→03Resolved [20:36:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14): Call to a member function setCommunicationStatus() on null - https://phabricator.wikimedia.org/T382834#10455695 (10XenoRyet) 05Open→03Resolved [20:36:25] 10Fundraising Refactor, 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, and 2 others: Invalid PayPal message type: mp_cancel - https://phabricator.wikimedia.org/T337326#10455697 (10XenoRyet) 05Open→03Resolved [20:36:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: add pending as paypal ec status - https://phabricator.wikimedia.org/T382551#10455699 (10XenoRyet) 05Open→03Resolved [20:36:57] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Improve speed in creating pdfs by fixing the attempt to load css by http - https://phabricator.wikimedia.org/T188560#10455704 (10Eileenmcnaughton) 05Open→03Declined This is a bit old to pick up as is - it might come up again as we address some oth... [20:37:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: pending transactions refund or chargeback will not find parent contributions trigger fail mail - https://phabricator.wikimedia.org/T378860#10455707 (10XenoRyet) 05Open→03Resolved [20:37:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Clean up historical appmenu Android donations to 2023-07-01 - https://phabricator.wikimedia.org/T381546#10455709 (10XenoRyet) 05Open→03Resolved [20:37:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Referred donation imports lose email on paypal recurring - https://phabricator.wikimedia.org/T382223#10455712 (10XenoRyet) 05Open→03Resolved [20:38:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Tech-Analytics, 10FR-tech-data-integrity: New Donors Donating On Email - https://phabricator.wikimedia.org/T356911#10455719 (10XenoRyet) 05Open→03Resolved [20:38:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Update text for recurring upgrade thank you email - https://phabricator.wikimedia.org/T371848#10455724 (10XenoRyet) 05Open→03Resolved [20:38:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: New recurring donations that have the contribution_recur info but are missing the contribution info - https://phabricator.wikimedia.org/T381937#10455730 (10XenoRyet) 05Open→03Resolved [20:38:58] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: gross value coming in as string for some paypal messages - https://phabricator.wikimedia.org/T381106#10455737 (10XenoRyet) 05Open→03Resolved [20:39:19] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: missing recurring donation record in civicrm_contritbution table - https://phabricator.wikimedia.org/T350754#10455741 (10XenoRyet) 05Open→03Resolved [20:39:47] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: Matching gift import - https://phabricator.wikimedia.org/T356445#10455756 (10XenoRyet) 05Open→03Resolved [20:41:25] 06Fundraising Tech - Chaos Crew, 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog: fail to import recurring donation to civi due to missing recurring token which exist - https://phabricator.wikimedia.org/T353930#10455768 (10XenoRyet) 05Open→03Resolved [20:41:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.6; 2024-12-03): Add some unit tests for in-app api calls - https://phabricator.wikimedia.org/T378397#10455769 (10XenoRyet) 05Open→03Resolved [20:58:00] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10455856 (10Eileenmcnaughton) 05Open→03Resolved [20:58:03] 03Fundraising Sprint: XenoRyet(), 06Fundraising-Backlog, 10FR-donorservices: Suppress recurrings with only one charge from ty email receipt - https://phabricator.wikimedia.org/T380403#10455857 (10Eileenmcnaughton) [21:12:13] 06Fundraising-Backlog: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10455907 (10spatton) a:03spatton Thanks @Damilare for adding Peter, I've assigned myself this task and will get the messaging from our Content Strategy team. @JScherer-WMF three quick practical quest... [21:21:23] 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10455941 (10AKanji-WMF) @Eileenmcnaughton wonders if this might be related to snooze testing, and will resolve now that's done. [21:22:58] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: FundraiserLandingPage doesn't declare perf budget for ext.fundraiserLandingPage.LogPageview - https://phabricator.wikimedia.org/T383526#10455947 (10AKanji-WMF) [21:23:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: ClientSide errors - https://phabricator.wikimedia.org/T383445#10455952 (10AKanji-WMF) p:05Triage→03Medium [21:25:48] 06Fundraising-Backlog, 13Patch-For-Review: Standardise on createPayment/approvePayment over a mix of create/authorize/approve/capture. - https://phabricator.wikimedia.org/T383404#10455972 (10AKanji-WMF) Next architecture call on Feb 4 [21:26:42] 06Fundraising-Backlog: Come up with a better name for PaymentDetailResponse in SmashPig - https://phabricator.wikimedia.org/T383400#10455975 (10AKanji-WMF) For architecture call Feb 4 [21:28:40] 06Fundraising-Backlog, 10FR-Civi-Dedupe, 10FR-donorservices: Civi search feature request - https://phabricator.wikimedia.org/T383363#10455984 (10AKanji-WMF) [21:32:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Trustly ACH recurring (gravy) that are cancelled on the donors end are breaking the charge job - https://phabricator.wikimedia.org/T382629#10456016 (10AKanji-WMF) p:05Triage→03High [21:32:40] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10456021 (10SHust) Here's another CID 67344496, displaying the same issue. [21:47:23] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10456108 (10Eileenmcnaughton) These seem to be happening on a couple of activity types - one historical & the other being created now - which is probably what we are getting problems from & probably re... [21:51:01] anilk do we have a phab for Rosie's civimail [21:52:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Come July 1 we need to roll over the donor segment & status values - https://phabricator.wikimedia.org/T383195#10456122 (10NNgu-WMF) Noted, thank you @Eileenmcnaughton ! cc @nisrael for campaign planning [21:53:42] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10456136 (10Eileenmcnaughton) This is coming from - why does `$parentTxnID` = 0 - should we cast it NULL below (ie ` ->addValue('source_record_id', $parentTxn ?: NULL) ` - or should we fix it earlie... [22:03:52] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10456183 (10Eileenmcnaughton) It looks like in these case the parent_trxn_id was either missing or invalid - perhaps we need to check [22:11:50] (03PS5) 10Jgleeson: Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) [22:12:01] damilare: that might be what we need ^ [22:12:48] yea exactly [22:12:56] but it's also on the api tests as well [22:13:12] did it pass completely locally? [22:13:42] hmm I was only testing one suite. lemme see if they share a common ancestor [22:14:02] (03CR) 10CI reject: [V:04-1] Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) (owner: 10Jgleeson) [22:14:46] hmm [22:15:19] ok this might be better fix at the implementation level where the exception is thrown to save not having to update a lot of test setup which doesn't care [22:16:36] yh logging is probably better [22:17:10] because I can't think of a situation where the request url isn't set [22:23:28] did anyone want to join snooze discussion (Brian, Natalie) [22:30:43] ok I think I might have it dami [22:30:57] not me eileen. heading off soon. thanks for the invite tho [22:31:02] 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay on the Web - https://phabricator.wikimedia.org/T383634 (10Cstone) 03NEW [22:32:22] 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay on the Web - https://phabricator.wikimedia.org/T383634#10456289 (10Cstone) [22:33:19] 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay - check before February 4 - https://phabricator.wikimedia.org/T383634#10456295 (10Cstone) [22:33:22] (03PS6) 10Jgleeson: Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) [22:33:39] * jgleeson crosses fingers [22:38:02] jgleeson: ahh I see what you're doing, I was thinking something along the lines of try/catch. This should work also has the tests use a mock class [22:38:16] hopefully I don't jinx it [22:38:32] it worked! [22:40:01] awesome [22:43:45] We were probably gonna need a guard clause like that anyway so that the batch jobs which call the same code don't error. I imagine they come in via the SAPI / CLI [22:44:45] ok that'll do for today [22:44:51] catch you all tomorrow o/