[00:47:08] anilk: following the catch up on the snooze issue there really only seems to be one good solution - which is 'sort out the email preference centre translation issues and collect snooze & RML & unsubscribe requests via civi rather than Acoustic' - a bigger project but one we want to do anyway [01:20:39] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10456619 (10Eileenmcnaughton) I caught up with @NNgu-WMF @bsisolak & @CaCogdill-WMF and we were able to confirm that snooze pauses the email being sent... [03:01:17] thanks eileen - if we were able to flip a switch today and only use the Civi pref centre going forward, is there anything we'd need to do to acoustic-snoozed records to not break their snoozes? Or would they be fine... [03:04:50] we would need to create one or more new fields in Acoustic & populate them - this isn't a big chunk of work but think it would require some more conversations & there would be adaptation needed by Natalie et al. Also we need to finish getting the snooze data in from Acoustic (which is something underway) [03:05:29] well I guess actually [03:05:50] for parity we might need to do those things - to solve the problems we would [03:10:42] anilk: I just read your planning doc - feels good seeing stuff laid out like that - like all the things we've been thinking about are down in one place rather than just falling out of our heads :-) [03:13:20] Thanks eileen - yeah I'm sure you recognize lots of your good flags in there :) There's probably a bunch more to add. [03:14:02] yeah - probably more stuff to add for sure - but now that there is a framework we can go there when we have ideas [03:14:05] Thanks for flagging this stuff around snooze for the preference centre - I really would like to get back on track with that - it's relate to the donor portal too, and that's coming [03:15:20] yeah - well we (Brian, Natalie & Caitlin) had that call & ultimately it's a long standing problem that we have been trying to mitigate for a long time [03:15:37] but we couldn't see a way to actually fix it using the acoustic form [03:16:40] ah interesting I found this - I remember when we were talking to Danny about snooze he didn't want it in the pref centre. But I'm pretty sure consensus is we do now want it https://phabricator.wikimedia.org/T278859 [03:17:29] that's a child task of the pref centre, but maybe it wasn't actually linked. In other words, maybe diregard! [03:25:02] anilk: I'm 100% sure the consensus would be we do want it in the preference centre, along with remind me later & unsubscribe once people understand the way the Acoustic one leads to our donor issues [03:44:40] eileen: I'll follow up tomorrow morn with Rosie on a civimail phab [03:44:50] cool [04:10:49] 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10456768 (10Eileenmcnaughton) a:03Eileenmcnaughton I have some preliminary code [04:24:37] (03PS1) 10Eileen: Stop passing 'contributions' when we only want one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110901 (https://phabricator.wikimedia.org/T383174) [04:24:38] (03PS1) 10Eileen: Unpack the contributions to the single one we want earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110902 (https://phabricator.wikimedia.org/T383174) [04:38:30] (03PS1) 10Eileen: Fix Refund activity to hold correct value for source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110904 (https://phabricator.wikimedia.org/T383174) [04:38:31] (03PS1) 10Eileen: Fix data errors on source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110905 (https://phabricator.wikimedia.org/T383174) [04:40:51] (03PS2) 10Eileen: Unpack the contributions to the single one we want earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110902 (https://phabricator.wikimedia.org/T383174) [04:40:52] (03PS2) 10Eileen: Fix Refund activity to hold correct value for source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110904 (https://phabricator.wikimedia.org/T383174) [04:40:52] (03PS2) 10Eileen: Fix data errors on source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110905 (https://phabricator.wikimedia.org/T383174) [04:42:09] (03PS3) 10Eileen: Fix data errors on source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110905 (https://phabricator.wikimedia.org/T383174) [04:47:57] (03CR) 10CI reject: [V:04-1] Unpack the contributions to the single one we want earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110902 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [05:02:07] (03CR) 10CI reject: [V:04-1] Fix Refund activity to hold correct value for source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110904 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [06:04:37] (03PS1) 10Eileen: Start to migrate to message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110949 (https://phabricator.wikimedia.org/T383174) [06:04:37] (03PS1) 10Eileen: Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) [06:04:38] (03PS1) 10Eileen: Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) [06:04:40] (03PS1) 10Eileen: Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 [06:04:40] (03PS1) 10Eileen: Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 [06:04:40] (03PS1) 10Eileen: Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 [06:04:44] (03PS1) 10Eileen: Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 [06:04:48] (03PS1) 10Eileen: Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 [06:30:13] (03CR) 10CI reject: [V:04-1] Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 (owner: 10Eileen) [06:30:20] (03CR) 10CI reject: [V:04-1] Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [06:30:32] (03CR) 10CI reject: [V:04-1] Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 (owner: 10Eileen) [06:30:58] (03CR) 10CI reject: [V:04-1] Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 (owner: 10Eileen) [06:31:24] (03CR) 10CI reject: [V:04-1] Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 (owner: 10Eileen) [06:31:41] (03CR) 10CI reject: [V:04-1] Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 (owner: 10Eileen) [06:33:52] (03CR) 10CI reject: [V:04-1] Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [13:00:44] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the coding. LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) (owner: 10Jgleeson) [13:02:54] thanks damilare ! [13:03:00] np! [13:03:31] gonna push that out so we can start getting those log outputs [13:03:41] I can do it [13:04:00] did that smashpig bump go out yesterday? [13:04:12] 0.8.26? [13:04:23] that log one will be a good milestone to get out [13:04:31] yeah I think so? [13:04:49] I did not do any deployment yesterday but I think it did last week [13:04:59] wasn't there one you merged yesterday [13:05:03] I also want to add the gr4vy domain association file to payment [13:05:08] or am I mixing up days [13:05:12] no that was just composer.lock in payments [13:05:29] the vendor had been merged since friday [13:05:51] might have been the composer file [13:06:05] one thing we need to circle back on is the payments reconciliation bug [13:06:09] vendor was merged on thursday [13:07:31] this one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1110836 [13:07:40] (03Merged) 10jenkins-bot: Log referrer and request URL related to a new donor session. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1035804 (https://phabricator.wikimedia.org/T364478) (owner: 10Jgleeson) [13:07:58] oh yh I haven't deployed that yet [13:08:31] ah ok [13:09:09] do you wanna push that out and then I can deploy the logging thing and check that [13:09:24] I wanna keep an eye on the logs once it goes out ready to roll it back in case anything breaks [13:09:43] make sense [13:09:54] or you can hold off on the apple stuff if its not convenient [13:13:40] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111217 [13:13:42] done [13:13:45] ty! [13:14:26] I'm wondering how noisy this log addition is going to be [13:14:45] it will log with every instance of the gateway adapter [13:14:52] so effectively on every page [13:15:00] or visit [13:15:02] 2-3 mayve [13:15:04] maybe [13:15:11] we'll see! [13:19:49] I imagine it will be [13:26:42] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111217 (owner: 10Jgleeson) [13:27:54] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111217 (owner: 10Jgleeson) [13:29:52] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110901 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [13:32:19] (03PS1) 10Damilare Adedoyin: Ensure payment reconciliation id isn't wiped off by approve payment response [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111220 [13:32:50] jgleeson: I think I found the reason behind the reconciliation id drop off [13:33:50] the approve payment response seems to be the culprit, we can also fix this by adding the property to the response in the factory [13:34:09] but since it's the same value, that might not be useful [13:34:12] i was thinking that, doesn't that fix mean its broke in smashpig [13:34:50] did we lose it in the restructure of the assigning backend id stuff [13:34:55] not really, the property wasn't set in the approve payment response factory [13:35:12] it's only set in the create response factory [13:35:19] didn't you pull that code up so it gets set on both [13:35:40] no it was just the backend processor id that is set on both [13:35:56] oh weird [13:36:36] so I guess we're back in that position again of which one is the truth [13:36:57] I guess jut to have a "complete" respomnse we should also add it to the approve payment response [13:37:18] to save checking "is this a partial response update" [13:38:14] hmm ok, also there are a couple of properties we don't set on approve. Like donordetails and payment method. [13:38:14] we'll then know approve payment, which I guess is technically the final state, contains the latest id data [13:38:26] we should probably set those too [13:40:30] actually I think most times we only read the payment status and trxn_id from approve payment. We had to set the backend trxn id because of the unique situation we have for gravy [13:40:33] hmm [13:40:58] setting unused properties seem like adding bloat to the response [13:41:09] I think just adding the reconciliation id will be fine [13:41:19] +1 [13:41:36] as it means this method doesn't have to expect two types of responses, from the calling code perspective, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1111220/1/gravy_gateway/gravy.adapter.php [13:41:41] I think! [13:42:20] I guess you could make arguments for either cas [13:42:21] e [13:42:27] whatever you think is best! [13:45:10] I think our paypal spammer is back [13:48:39] (03PS1) 10Damilare Adedoyin: Add payment reconciliation id to approve payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1111226 [13:49:47] that's the patch adding the id ^ [13:54:44] (03Merged) 10jenkins-bot: Stop passing 'contributions' when we only want one [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110901 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [13:55:09] (03PS2) 10Damilare Adedoyin: Add payment reconciliation id to approve payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1111226 [14:09:07] (03PS2) 10Damilare Adedoyin: Ensure payment reconciliation id isn't wiped off by approve payment response [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111220 [14:31:46] damilare: I thought you were gonna add that to the smashpig response [14:31:54] just that id though [14:32:06] yh I did in the smashpig patch [14:32:16] oh right is there two [14:32:18] gotcha [14:33:45] (03CR) 10Jgleeson: [C:03+2] "LGTM! let's give it a go and see it if fixes the issue." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1111226 (owner: 10Damilare Adedoyin) [14:41:26] (03Merged) 10jenkins-bot: Add payment reconciliation id to approve payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1111226 (owner: 10Damilare Adedoyin) [14:47:23] (03PS3) 10Damilare Adedoyin: Ensure payment reconciliation id isn't wiped off by approve payment response [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111220 [14:51:27] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.26.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111244 [14:54:13] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.26.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111244 (owner: 10Damilare Adedoyin) [14:55:22] (03CR) 10Jgleeson: [C:04-1] "Sorry. It works but it scared me. See inline :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110902 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [15:02:35] (03Merged) 10jenkins-bot: Update smashpig to v0.26.1 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111244 (owner: 10Damilare Adedoyin) [15:03:05] (03PS4) 10Damilare Adedoyin: Ensure payment reconciliation id isn't wiped off by approve payment response [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111220 [15:03:32] (03PS5) 10Damilare Adedoyin: Ensure payment reconciliation id isn't wiped off by approve payment response [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111220 [15:05:17] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111249 [15:06:28] (03PS1) 10Damilare Adedoyin: Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [15:06:30] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111249 (owner: 10Damilare Adedoyin) [15:06:46] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [15:07:26] (03PS2) 10Damilare Adedoyin: Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [15:16:49] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [15:19:26] (03PS3) 10Damilare Adedoyin: Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [15:22:16] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1111249 (owner: 10Damilare Adedoyin) [15:28:26] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [15:33:42] (03PS4) 10Damilare Adedoyin: Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [15:42:52] (03CR) 10CI reject: [V:04-1] Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [15:59:56] 06Fundraising-Backlog, 10fundraising-tech-ops, 10SRE Observability (FY2024/2025-Q3): Shift frack alerting to use alertmanager instead of icinga - https://phabricator.wikimedia.org/T367370#10458598 (10lmata) [16:36:20] (03CR) 10Damilare Adedoyin: "recheck" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [17:58:23] (03Merged) 10jenkins-bot: Unpack the contributions to the single one we want earlier [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110902 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [17:58:25] (03Merged) 10jenkins-bot: Fix Refund activity to hold correct value for source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110904 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [17:58:30] (03Merged) 10jenkins-bot: Fix data errors on source_record_id [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110905 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [17:59:31] (03Merged) 10jenkins-bot: Start to migrate to message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110949 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [18:06:40] (03PS1) 10Hashar: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) [18:07:03] (03PS6) 10Damilare Adedoyin: Update smashpig to v0.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [18:13:48] (03CR) 10Hashar: Update smashpig to v0.26.1 (031 comment) [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [18:16:03] (03CR) 10CI reject: [V:04-1] build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) (owner: 10Hashar) [18:20:21] (03PS7) 10Damilare Adedoyin: Update smashpig to v0.8.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 [18:26:03] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.8.26.1 (031 comment) [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [18:48:22] (03PS8) 10Damilare Adedoyin: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (https://phabricator.wikimedia.org/T138401) [18:49:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10459558 (10Dwisehaupt) This is related to DNS lookup failures: `    8   │ 2025-01-14 03:29:53,087 ERROR   Cannot connect to transfer.silverpop.com:22 [transfer... [18:50:42] (03CR) 10Hashar: "recheck after having switched back to Node 18 image ( https://gerrit.wikimedia.org/r/c/integration/config/+/1111301 )" [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) (owner: 10Hashar) [18:55:35] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi: expand 'deceased' checkbox to cover all outreach methods - https://phabricator.wikimedia.org/T383717 (10MBeat33) 03NEW [19:03:33] (03Abandoned) 10Damilare Adedoyin: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (https://phabricator.wikimedia.org/T138401) (owner: 10Damilare Adedoyin) [19:04:04] (03Restored) 10Damilare Adedoyin: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (https://phabricator.wikimedia.org/T138401) (owner: 10Damilare Adedoyin) [19:04:12] (03PS9) 10Hashar: Update smashpig to v0.8.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [19:04:12] (03PS2) 10Hashar: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) [19:05:59] PROBLEM - Host frbast2002 is DOWN: PING CRITICAL - Packet loss = 100% [19:08:11] RECOVERY - Host frbast2002 is UP: PING OK - Packet loss = 0%, RTA = 30.28 ms [19:19:42] (03CR) 10Damilare Adedoyin: [C:03+2] Update smashpig to v0.8.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [19:29:12] (03Merged) 10jenkins-bot: Update smashpig to v0.8.26.1 [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111250 (owner: 10Damilare Adedoyin) [19:29:29] (03CR) 10Damilare Adedoyin: [C:03+2] build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) (owner: 10Hashar) [19:39:23] (03Merged) 10jenkins-bot: build: Disable old jsduck-based JS documentation in this branch [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111293 (https://phabricator.wikimedia.org/T138401) (owner: 10Hashar) [19:42:42] (03PS1) 10Damilare Adedoyin: Add gravy apple pay domain association file [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111314 [19:44:27] (03PS2) 10Damilare Adedoyin: Add gravy apple pay domain association file [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111314 [19:52:29] PROBLEM - Host frban2002 is DOWN: PING CRITICAL - Packet loss = 100% [19:53:14] ACKNOWLEDGEMENT - Host frban2002 is DOWN: PING CRITICAL - Packet loss = 100% Jeff_Green kernel upgrade [19:55:15] RECOVERY - Host frban2002 is UP: PING OK - Packet loss = 0%, RTA = 30.35 ms [19:55:24] 03Fundraising Sprint: A: 2025 Sprint A Priorities - https://phabricator.wikimedia.org/T383727 (10AKanji-WMF) 03NEW [19:57:15] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10460145 (10Eileenmcnaughton) It still works correctly with `transfer4.silverpop.com` which is what we have been using - maybe a deployment messed with the 4... [20:01:53] (03CR) 10Damilare Adedoyin: [C:03+2] Add gravy apple pay domain association file [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111314 (owner: 10Damilare Adedoyin) [20:04:13] (03PS2) 10Eileen: Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) [20:04:13] (03PS2) 10Eileen: Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) [20:04:13] (03PS2) 10Eileen: Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 [20:04:13] (03PS2) 10Eileen: Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 [20:04:14] (03PS2) 10Eileen: Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 [20:04:15] (03PS2) 10Eileen: Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 [20:04:19] (03PS2) 10Eileen: Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 [20:10:18] (03Merged) 10jenkins-bot: Add gravy apple pay domain association file [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/1111314 (owner: 10Damilare Adedoyin) [20:13:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10460219 (10bsisolak) That is the domain for SFTP (transfer-campaign-us-4.goacoustic.com), which resolves to 3.209.96.38. I don't know what transfer.silverpop.c... [20:28:06] (03CR) 10CI reject: [V:04-1] Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 (owner: 10Eileen) [20:28:34] (03CR) 10CI reject: [V:04-1] Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 (owner: 10Eileen) [20:29:04] (03CR) 10CI reject: [V:04-1] Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 (owner: 10Eileen) [20:29:05] (03CR) 10CI reject: [V:04-1] Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 (owner: 10Eileen) [20:29:23] (03CR) 10CI reject: [V:04-1] Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 (owner: 10Eileen) [20:31:08] (03CR) 10CI reject: [V:04-1] Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [20:45:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay - check before February 4 - https://phabricator.wikimedia.org/T383634#10460290 (10Cstone) [20:49:36] (03PS3) 10Eileen: Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) [20:49:36] (03PS3) 10Eileen: Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) [20:49:36] (03PS3) 10Eileen: Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 [20:49:36] (03PS3) 10Eileen: Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 [20:49:37] (03PS3) 10Eileen: Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 [20:49:38] (03PS3) 10Eileen: Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 [20:49:42] (03PS3) 10Eileen: Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 [20:49:46] (03PS1) 10Eileen: Remove function only called from test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111327 [20:55:12] 03Fundraising Sprint: A, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10460319 (10AKanji-WMF) [20:59:13] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_communication into an extenstion = probably wmf-thankyou - https://phabricator.wikimedia.org/T270682#10460350 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [20:59:16] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Epic: Epic: drupal upgrade - https://phabricator.wikimedia.org/T261779#10460353 (10Eileenmcnaughton) [20:59:17] PROBLEM - Host payments2006 is DOWN: PING CRITICAL - Packet loss = 100% [21:00:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Update Exchange Rates job should emit some logs - https://phabricator.wikimedia.org/T117149#10460357 (10Eileenmcnaughton) 05Open→03Declined logged in 2015 - prob sorted now [21:04:31] RECOVERY - Host payments2006 is UP: PING OK - Packet loss = 0%, RTA = 30.50 ms [21:08:17] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: When is a snooze not a snooze - https://phabricator.wikimedia.org/T383295#10460391 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [21:10:53] eileen: I think I need your help [21:11:42] jgleeson: ok.... [21:12:01] * jgleeson should confirm things before asking for help [21:12:43] cool - just grabbing breakfast [21:12:51] 03Fundraising Sprint: A, 06Fundraising-Backlog: Add uselang=xx in epc link with the translate from Tomaz - https://phabricator.wikimedia.org/T381336#10460422 (10AKanji-WMF) [21:12:55] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Activity field failing - https://phabricator.wikimedia.org/T383174#10460421 (10AKanji-WMF) [21:12:56] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_civicrm module into wmf-civicrm extension - https://phabricator.wikimedia.org/T270677#10460424 (10AKanji-WMF) [21:12:59] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10FR-Smashpig, 10FR-WMF-Audit, 13Patch-For-Review: PayPal audit processor and IPN listener should send payments to donations queue - https://phabricator.wikimedia.org/T366526#10460423 (10AKanji-WMF) [21:13:00] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10460425 (10AKanji-WMF) [21:13:02] 03Fundraising Sprint: A, 06Fundraising-Backlog, 07FR-Imports, 07Unplanned-Sprint-Work: Checking for code bottlenecks to improve speed of imports - https://phabricator.wikimedia.org/T376337#10460427 (10AKanji-WMF) [21:13:03] 03Fundraising Sprint: A, 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Possible issue with the civi snooze - https://phabricator.wikimedia.org/T376959#10460426 (10AKanji-WMF) [21:13:19] sorry eileen I wanted to rerun the tests locally to confirm they still pass before explaining [21:13:52] so, I have this relatively small patch which is pretty close to doing what I think we need here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1105729 [21:14:45] and the tests pass fine locally. However, on CI they are not working and reporting odd failures as if the test fixed population is not working on the contribution_extra fields [21:15:11] 20:08:18 1) Civi\Test\SmashPigTest::testRecurringChargeJobAddsGravyFieldsToQueueMessageIfNeeded [21:15:11] 20:08:18 Undefined index: backend_processor [21:15:17] (03CR) 10CI reject: [V:04-1] Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 (owner: 10Eileen) [21:15:24] 20:08:18 1) Civi\Test\SmashPigTest::testRecurringChargeJobAddsGravyFieldsToContributionDirectlyIfNeeded [21:15:24] 20:08:18 Failed asserting that null matches expected 'adyen'. [21:15:35] It's entirely possible I'm doing something stupid [21:16:09] it's also possible there's an environment difference I'm not aware of [21:16:18] but I'm leaning more towards the former [21:16:58] (03CR) 10CI reject: [V:04-1] Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 (owner: 10Eileen) [21:17:08] brb just gonna say goodnight to the small humans [21:28:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices, 13Patch-For-Review: Civi merge is not saving the state when a mailing address is present. - https://phabricator.wikimedia.org/T379684#10460470 (10SHust) Quick update: This issue is still ongoing.... [21:30:37] jgleeson: I'll take a look [21:33:15] who will rid me of this noisy teenager [21:34:23] if you can fix that patch I can send pizza [21:36:26] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_civicrm module into wmf-civicrm extension - https://phabricator.wikimedia.org/T270677#10460475 (10Eileenmcnaughton) a:03Eileenmcnaughton [21:40:01] are you gonna negotiate with my son to deliver it [21:42:37] The eagles will do it for the right price/mice [21:50:27] (03PS1) 10Jgleeson: DO NOT MERGE YET: Run fraud filters for ApplePay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111333 (https://phabricator.wikimedia.org/T383352) [21:54:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10460526 (10Eileenmcnaughton) p:05Triage→03Unbreak! [22:01:15] (03PS1) 10Jgleeson: Constantize app payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111334 (https://phabricator.wikimedia.org/T383352) [22:01:16] (03PS1) 10Jgleeson: Constantize other payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) [22:06:47] (03PS1) 10Eileen: Update omnimail-silverpop [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111337 (https://phabricator.wikimedia.org/T383528) [22:07:07] That patch there ^^ should fix the Acoustic sftp. Now I'll look at jgleeson's patch [22:08:22] looking & ty [22:12:25] (03CR) 10Jgleeson: [C:03+2] "Surely it's transfer-campaign-us-T800.goacoustic.com or transfer-campaign-us-T1000.goacoustic.com... or something logical like that." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111337 (https://phabricator.wikimedia.org/T383528) (owner: 10Eileen) [22:17:29] (03PS1) 10Jgleeson: To Run, RunDo or DoRun. That is the question. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111339 [22:18:18] jgleeson: I'm just trying to replicate - but one thing I'm thinking is that this setting 'smashpig_recurring_use_queue', - seems to be 0 in the new test but 1 i most of the tests that do queue->pop() [22:19:14] eileen: so I added two tests, one using the queue and one without. I defaulted to using the queue originally and added the additional one after getting those errors to see if I was missing something in that area :( [22:20:08] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit, 10Recurring-Donations: wmf_audit: support recurring donations - https://phabricator.wikimedia.org/T187505#10460562 (10AKanji-WMF) @Eileenmcnaughton this is currently in unscheduled; let me know if we should bring it to next or the long... [22:20:09] It shouldn't be popping for the non-queue test [22:21:11] 03Fundraising Sprint: A, 06Fundraising-Backlog: 2025 Sprint A Priorities - https://phabricator.wikimedia.org/T383727#10460563 (10AKanji-WMF) [22:21:33] OK - I can see that [22:23:34] I'm getting the feeling that the fixture setup for the contribution is behaving differently on CI [22:25:06] I was considering peppering the test with some console output debug statements mid-test so we could confirm what happens there [22:25:19] the tricky part being how long the tests take [22:29:39] I'll do that tomorrow [22:29:46] have a good evening all! [22:29:51] 06Fundraising-Backlog: Give RLewis access to https://civicrm.wikimedia.org/admin/config/large_donation/configure - https://phabricator.wikimedia.org/T368152#10460574 (10AKanji-WMF) @RLewis did you ever get access to this? [22:32:03] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert orphan slayer to an extension - https://phabricator.wikimedia.org/T270670#10460585 (10AKanji-WMF) So this is done @jgleeson ? [22:36:07] (03Merged) 10jenkins-bot: Update omnimail-silverpop [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111337 (https://phabricator.wikimedia.org/T383528) (owner: 10Eileen) [23:15:58] (03PS1) 10Eileen: Update wikimedia/omnimail-silverpop [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1111348 [23:16:10] (03CR) 10Eileen: [C:03+2] Update wikimedia/omnimail-silverpop [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1111348 (owner: 10Eileen) [23:18:37] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1111349 [23:25:38] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1111349 (owner: 10Eileen) [23:27:23] cstone: I feel like we can close this ? https://phabricator.wikimedia.org/T187505 [23:32:10] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit, 10Recurring-Donations: wmf_audit: support recurring donations - https://phabricator.wikimedia.org/T187505#10460746 (10Eileenmcnaughton) My feeling is it is resolved - trying to confirm with @cstone or @Ejegg [23:33:46] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit, 10Recurring-Donations: wmf_audit: support recurring donations - https://phabricator.wikimedia.org/T187505#10460748 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton [23:38:47] (03Merged) 10jenkins-bot: Update wikimedia/omnimail-silverpop [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1111348 (owner: 10Eileen) [23:41:00] !log civicrm upgraded from 1ea537d3 to 4206a253 [23:41:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:43:01] 06Fundraising-Backlog, 07fr-acoustic: Acoustic block some email prefix which lead to failed save email there - https://phabricator.wikimedia.org/T383744 (10AnnWF) 03NEW