[00:23:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10460811 (10Eileenmcnaughton) OK - this seems to be working now - @nisrael - I pushed up last nights file & tonights' should go up in the next few hours - if al... [02:07:29] (03PS1) 10Eileen: Port upstream activity display fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111368 (https://phabricator.wikimedia.org/T383174) [02:59:15] (03PS1) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [03:21:02] (03CR) 10CI reject: [V:04-1] Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [03:45:09] (03PS2) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [03:50:13] (03PS3) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [04:04:45] (03PS10) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [04:04:45] (03PS1) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [04:18:21] (03CR) 10CI reject: [V:04-1] Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [04:26:42] (03CR) 10CI reject: [V:04-1] Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [04:31:20] (03CR) 10CI reject: [V:04-1] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [04:31:55] (03PS4) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [04:31:55] (03PS2) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [04:31:56] (03PS11) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [04:33:09] (03PS3) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [04:33:09] (03PS12) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [04:34:44] (03PS2) 10Eileen: Port upstream activity display fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111368 (https://phabricator.wikimedia.org/T383174) [04:54:04] (03CR) 10CI reject: [V:04-1] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [04:54:20] (03CR) 10CI reject: [V:04-1] Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [04:55:46] (03CR) 10CI reject: [V:04-1] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [04:56:15] (03CR) 10CI reject: [V:04-1] Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [04:57:16] (03PS1) 10Eileen: Remove call to legacy function from legacy test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111375 (https://phabricator.wikimedia.org/T270677) [05:03:10] (03PS5) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [05:12:55] (03PS1) 10Eileen: Remove another instance of legacy fn call from legacy test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111376 (https://phabricator.wikimedia.org/T270677) [05:29:06] (03CR) 10CI reject: [V:04-1] Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [05:37:54] (03PS6) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [05:39:54] (03PS4) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [05:39:54] (03PS13) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [06:00:32] (03CR) 10CI reject: [V:04-1] Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [06:03:18] (03CR) 10CI reject: [V:04-1] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [06:04:26] (03PS7) 10Eileen: Preliminary tidy up in SmashPigTest class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 [06:04:27] (03PS5) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [06:04:27] (03PS14) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [06:27:02] (03CR) 10CI reject: [V:04-1] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [06:27:53] (03CR) 10CI reject: [V:04-1] Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [07:16:54] (03PS6) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [07:16:54] (03PS15) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [08:39:46] 10fundraising-tech-ops, 10BDC-Implementation, 06Privacy Engineering, 10Security Preview, 07SecTeam-Processed: [minIO] Investigate packaging, install, security monitoring. - https://phabricator.wikimedia.org/T367123#10461168 (10Gehel) Removing Data Platform SRE as it seems that we don't need to be involve... [10:17:22] (03CR) 10Jgleeson: [C:03+2] Port upstream activity display fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111368 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [10:23:21] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10FR-Smashpig, 10FR-WMF-Audit, 13Patch-For-Review: PayPal audit processor and IPN listener should send payments to donations queue - https://phabricator.wikimedia.org/T366526#10461509 (10jgleeson) a:03jgleeson [10:41:57] (03Merged) 10jenkins-bot: Port upstream activity display fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111368 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [10:42:30] (03CR) 10Jgleeson: [C:03+2] Update code to apiv4, eliminating deprecated fn calls (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 (owner: 10Eileen) [10:49:55] (03CR) 10Jgleeson: [C:03+2] Remove last calls to old drupal module function (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [11:10:19] (03CR) 10Jgleeson: [C:03+2] Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [11:15:27] (03CR) 10Jgleeson: [C:03+2] Remove function only called from test (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111327 (owner: 10Eileen) [11:22:50] (03CR) 10Jgleeson: [C:03+2] Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 (owner: 10Eileen) [11:27:54] (03CR) 10Jgleeson: [C:03+2] Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 (owner: 10Eileen) [11:32:21] (03CR) 10Jgleeson: [C:03+2] Remove call to legacy function from legacy test (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111375 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:33:52] (03Merged) 10jenkins-bot: Standardise Contribution.get calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110950 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [11:36:24] (03CR) 10Jgleeson: [C:03+2] "It probably makes sense to relocate this helper method to the newer code so it can be shared across the code in this patch and the previou" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111376 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:39:03] (03Merged) 10jenkins-bot: Remove function only called from test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111327 (owner: 10Eileen) [11:39:04] (03Merged) 10jenkins-bot: Remove last calls to old drupal module function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110951 (https://phabricator.wikimedia.org/T383174) (owner: 10Eileen) [11:39:05] (03Merged) 10jenkins-bot: Update code to apiv4, eliminating deprecated fn calls [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110952 (owner: 10Eileen) [11:45:51] (03Merged) 10jenkins-bot: Get rid of always-same version parameter [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110953 (owner: 10Eileen) [11:46:51] (03CR) 10Jgleeson: [C:03+2] "looks great overall. this line caught my eye $params['payment_processor_type_id:name'] = 'smashpig_ingenico', which appears to be a defaul" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [11:51:17] (03Merged) 10jenkins-bot: Get rid of apiv3 field name handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110954 (owner: 10Eileen) [11:55:12] (03Merged) 10jenkins-bot: Remove call to legacy function from legacy test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111375 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:58:25] (03CR) 10Jgleeson: Clean up handling of payment processor (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [11:58:47] (03Merged) 10jenkins-bot: Remove another instance of legacy fn call from legacy test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111376 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:59:36] (03CR) 10Jgleeson: "Left question inline about is_test = FALSE flag" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [13:00:18] 06Fundraising-Backlog: 2nd Recurring Failure Email in Civi - https://phabricator.wikimedia.org/T365488#10461917 (10MSuijkerbuijk_WMF) Hi team - could I ask where we are at with this task? Our intention is to mitigate cancellations due to maximum failures reached and this second email would help us with some reco... [14:21:00] (03PS7) 10Eileen: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 [14:21:22] (03PS16) 10Eileen: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [14:22:09] (03PS17) 10Jgleeson: WIP: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [14:48:01] (03PS18) 10Jgleeson: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [14:49:23] 06Fundraising-Backlog: Add Plug-In / Hook design to SmashPig recurring charge extension - https://phabricator.wikimedia.org/T383782 (10jgleeson) 03NEW [14:49:34] (03PS19) 10Jgleeson: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [14:53:01] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10462463 (10Damilare) a:03Damilare [14:59:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10462508 (10nisrael) Great, thank you Eileen! It doesn't look like we had any failmail from last night. [15:03:55] 03Fundraising Sprint: A, 06Fundraising-Backlog: 2025 Sprint A Priorities - https://phabricator.wikimedia.org/T383727#10462526 (10AKanji-WMF) [15:43:03] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Fundraising-Tech-Roadmap: FR-Tech FY2425Q4 maintenance window - https://phabricator.wikimedia.org/T337585#10462813 (10AKanji-WMF) [15:43:15] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-email-preferences: EmailPreferences form lacks template for user-friendly error display - https://phabricator.wikimedia.org/T340167#10462816 (10AKanji-WMF) [15:43:45] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-DonationInterface: Monthly convert at a payment method level should be configured in yaml - https://phabricator.wikimedia.org/T352340#10462822 (10AKanji-WMF) [15:43:54] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Investigation: Reduce number of clicks in donation flow through DonateWiki - https://phabricator.wikimedia.org/T351168#10462825 (10AKanji-WMF) [15:45:35] 14Fundraising Sprint Cheese String Theory, 14Fundraising Sprint Discworld reformatted as ntfs, 14Fundraising Sprint e^🥧👀=yum, 06Fundraising-Backlog, and 3 others: Civi Searchkit should allow user to export list to acoustic - https://phabricator.wikimedia.org/T301514#10462830 (10AKanji-WMF) @Eileenmcnaughto... [15:46:37] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Smashpig, 10Recurring-Donations, 13Patch-For-Review: Use auto-capture when authorizing recurring charges - https://phabricator.wikimedia.org/T348858#10462832 (10AKanji-WMF) [15:58:18] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07fr-acoustic: Explore whether we can activate Acoustic web tracking on our donation forms and thank you pages - https://phabricator.wikimedia.org/T360151#10462915 (10AKanji-WMF) Noting this review is complete and we have approval to move forward. Need to de... [18:36:10] PROBLEM - check_freeradius on frauth2002 is CRITICAL: PROCS CRITICAL: 0 processes with args /usr/sbin/freeradius https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2002&service=check_freeradius [18:38:40] PROBLEM - Host frauth2002 is DOWN: PING CRITICAL - Packet loss = 100% [18:41:10] RECOVERY - check_freeradius on frauth2002 is OK: PROCS OK: 1 process with args /usr/sbin/freeradius https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2002&service=check_freeradius [18:41:10] RECOVERY - Host frauth2002 is UP: PING OK - Packet loss = 0%, RTA = 30.32 ms [18:41:48] damilare: did you see that this one resolves https://payments.wikimedia.org/.well-known/apple-developer-merchantid-domain-association.txt [18:42:57] super strange that your one isn't [18:43:48] yea exactly [18:44:15] I was just worried that it might affect adyen's [18:44:29] but if its a one time thing [18:48:57] dwisehaupt: Jeff_Green is there any server-level redirect or rewriting going on for traffic to payments-wiki serving file data without a recognised extension? We've got this file which is served correctly https://payments.wikimedia.org/.well-known/apple-developer-merchantid-domain-association.txt but damilare has pushed up a different version without the .txt extension [18:48:57] https://payments.wikimedia.org/.well-known/apple-developer-merchantid-domain-association which is not being served and instead we're being redirect to donate wiki with some catch-all redirect I think. Do you know anything about that catch-all redirect? [19:00:41] jgleeson: looking [19:04:40] jgleeson: there's a very specific list of URLs that don't fall through to the redirect to donatewiki [19:04:55] ah, damilare that might be it ^ [19:05:19] in that list is: \.well-known/apple-developer-merchantid-domain-association\.txt [19:05:30] if we need a different/additional filename it's easy to modify [19:05:39] it's likely that we requested it in the past and forgot [19:05:43] can we add that same file without the extension [19:05:46] can you add the same URL without the .txt ext [19:05:57] yh that [19:06:03] yes, I can just trim that off the regex [19:06:23] can we keep the new one and the old (.txt) ? [19:06:32] hmm another win for creating phabs [19:07:13] cstone: we should move that domain association stuff over to our docs [19:07:21] jgleeson: yeah, anything .well-known/apple-developer-merchantid-domain-association.* would match [19:07:30] lemme see, do we have an applepay bit [19:07:44] cool thanks Jeff_Green [19:08:00] Jeff_Green: can we remove the "." before the * [19:08:06] at the end of the url [19:08:10] yes [19:08:23] so it catches all even those without an extension [19:08:34] oh I see it already does [19:08:36] sorry [19:08:45] thanks Jeff_Green [19:09:44] please let me know when it's deployed [19:10:54] it's merged, but it'll take a few minutes for puppet to get it out to the servers [19:13:02] sok thank you [19:13:06] ok** [19:14:27] awesome [19:14:38] also, for the future, at least for Adyen https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/Adyen_Checkout#Verifying_Merchant_Domains_(payments.wikimedia.org) [19:15:42] I guess the same would work for Gravy damilare [19:15:48] maybe? [19:21:00] jgleeson: yes its pretty much similar steps. Just that we are currently using the gravy applepay certificate. We would need to create ours as in Adyen when doing the mobile app integration [19:21:18] would be nice to work on the gravy equivalent of this doc too [19:21:43] I tried uploading the image also but wikitech said I don't have permissions to upload images :| [19:22:22] weird, isn't that suppose to be through commons [19:22:52] I think so yeah [19:23:00] maybe it's related to that account switch stuff [19:23:31] yea could be [19:23:33] brb dinner [19:25:20] (03PS5) 10Eileen: Switch thankyou.send from apiv3 to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108536 (https://phabricator.wikimedia.org/T299096) [19:25:55] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10464072 (10Eileenmcnaughton) @Damilare - just flagging I had done some tidy up patches... [19:26:42] (03PS3) 10Eileen: Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) [19:26:56] (03PS3) 10Eileen: Simplify thank you code in RecurringQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108870 (https://phabricator.wikimedia.org/T299096) [19:27:04] (03PS3) 10Eileen: Fold thank_you_send back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108871 (https://phabricator.wikimedia.org/T299096) [19:27:41] (03PS3) 10Eileen: Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) [19:27:59] (03PS4) 10Eileen: Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) [19:30:35] (03PS4) 10Eileen: Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 [19:30:35] (03PS4) 10Eileen: Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 [19:31:54] (03CR) 10Eileen: Clean up handling of payment processor (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [19:33:03] 14Fundraising Sprint Cheese String Theory, 14Fundraising Sprint Discworld reformatted as ntfs, 14Fundraising Sprint e^🥧👀=yum, 06Fundraising-Backlog, and 3 others: Civi Searchkit should allow user to export list to acoustic - https://phabricator.wikimedia.org/T301514#10464084 (10Eileenmcnaughton) @AKanji-WM... [19:33:36] (03PS20) 10Jgleeson: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) [19:34:29] (03CR) 10Eileen: Preliminary tidy up in SmashPigTest class (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111370 (owner: 10Eileen) [19:35:33] yeah jgleeson +1 to moving to docs, I was trying to think of the best way to restructure payment methods out of processors and we can just start with apple pay [19:36:06] (03CR) 10Eileen: "the helper is obsolete if we are using apiv4 - so hoping to phase out use - even the underlying civi function is deprecated!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111376 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:40:45] 03Fundraising Sprint: A, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10464102 (10Eileenmcnaughton) @Damilare also - my thinking now on this is that it makes... [19:42:24] (03CR) 10Eileen: [C:03+2] "Adding +2 as I'm happy with the functional changes here (I collaborated on some of the test changes)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [19:49:24] (03CR) 10CI reject: [V:04-1] Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [19:53:27] (03CR) 10CI reject: [V:04-1] Fully remove old drupal function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 (owner: 10Eileen) [19:54:14] (03CR) 10CI reject: [V:04-1] Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 (owner: 10Eileen) [19:56:13] (03CR) 10Eileen: Remove call to legacy function from legacy test (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111375 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:00:37] (03PS5) 10Eileen: Move function to last remaining caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110955 (https://phabricator.wikimedia.org/T270677) [20:01:17] (03PS5) 10Eileen: Move last usage of function back to calling class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1110956 [20:06:12] thanks for the review eileen ! [20:15:32] not much here right now but I made the apple pay page as a start https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/Payment_methods/Apple_Pay [20:21:33] awesome cstone. I'll move this over as it's own heading maybe? https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/Adyen_Checkout#Verifying_Merchant_Domains_(payments.wikimedia.org) [20:21:41] (03PS1) 10Eileen: Remove one of our legacy timestamp functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111696 [20:21:55] yeah sounds good jgleeson [20:22:37] (03CR) 10Jgleeson: [C:03+2] Remove call to legacy function from legacy test (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111375 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:24:09] (03PS1) 10Eileen: Remove legacy constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111697 [20:27:38] (03PS1) 10Eileen: Fold date back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111698 [20:34:41] (03PS1) 10Eileen: Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 [20:38:21] (03PS1) 10Eileen: Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 [20:38:21] (03PS1) 10Eileen: Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 [20:45:51] (03CR) 10CI reject: [V:04-1] Remove one of our legacy timestamp functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111696 (owner: 10Eileen) [20:47:41] (03CR) 10CI reject: [V:04-1] Remove legacy constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111697 (owner: 10Eileen) [20:48:03] (03PS1) 10Jgleeson: Extract exchange conversion out and check it worked ok. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111704 [20:51:01] (03CR) 10CI reject: [V:04-1] Fold date back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111698 (owner: 10Eileen) [20:52:56] (03CR) 10Eileen: Extract exchange conversion out and check it worked ok. (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111704 (owner: 10Jgleeson) [20:58:29] (03PS2) 10Jgleeson: Extract exchange conversion out and check it worked ok. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111704 [21:00:19] (03CR) 10CI reject: [V:04-1] Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 (owner: 10Eileen) [21:01:24] (03CR) 10CI reject: [V:04-1] Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 (owner: 10Eileen) [21:03:53] (03CR) 10CI reject: [V:04-1] Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 (owner: 10Eileen) [21:09:07] (03CR) 10Jgleeson: [C:03+2] Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [21:20:35] (03PS1) 10Eileen: Remove call to legacy WMF date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111707 [21:32:03] (03PS1) 10Eileen: Minor signature fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111708 (https://phabricator.wikimedia.org/T270677) [21:32:14] I'm already taking longer than I'd like writing this EOD [21:32:29] (03Merged) 10jenkins-bot: Clean up handling of payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111372 (owner: 10Eileen) [21:33:10] (03Merged) 10jenkins-bot: Add in backend processor fields if present for smashpig recurring charges. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1105729 (https://phabricator.wikimedia.org/T381866) (owner: 10Jgleeson) [21:41:15] ok, chatgpt is useless for generating EOD emails. You can't paste in links without it losing the URLs. I think our jobs are safe... [21:42:16] phew [21:42:33] +1 ^ cuz that's like 40% of my job (emails) [21:42:45] other 40% is gdocs/sheets/slides [21:42:50] 20% dunno [21:44:00] I even asked it if I could paste in URLs after it not working first time [21:44:16] "Yes, you can paste links from Google Docs into the canvas here, and they will retain their hyperlink formatting. Just ensure that you're copying the formatted text (not plain text) from Google Docs when you paste it." [21:44:21] and then after it failed [21:44:34] "Unfortunately, the canvas doesn't currently support retaining hyperlinks when pasting formatted text from external sources like Google Docs. When you paste, only plain text is preserved, and links lose their embedded formatting." [21:44:47] stop gaslighting me! [21:45:56] silly AIs [21:46:14] I guess I have to write my own damn emails [21:46:19] :) [21:46:43] (03PS2) 10Umherirrender: Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 [21:47:04] (03CR) 10Jforrester: [C:03+2] Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 (owner: 10Umherirrender) [21:49:38] (03CR) 10CI reject: [V:04-1] Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 (owner: 10Umherirrender) [21:50:21] (03PS3) 10Jforrester: Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 (owner: 10Umherirrender) [21:50:21] (03PS17) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) [21:50:21] (03PS1) 10Jforrester: FundraiserSubscriptionPage: Don't let unknown wgDonationInterfacePolicyURL fatal [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1111710 [21:50:25] (03CR) 10jenkins-bot: Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 (owner: 10Umherirrender) [21:51:14] 06Fundraising-Backlog: Add Plug-In / Hook design to SmashPig recurring charge extension - https://phabricator.wikimedia.org/T383782#10464622 (10jgleeson) 05Open→03Declined [21:52:43] (03CR) 10CI reject: [V:04-1] FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) (owner: 10Jforrester) [21:53:13] (03CR) 10CI reject: [V:04-1] FundraiserSubscriptionPage: Don't let unknown wgDonationInterfacePolicyURL fatal [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1111710 (owner: 10Jforrester) [21:54:10] (03PS2) 10Eileen: Minor signature fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111708 (https://phabricator.wikimedia.org/T270677) [21:54:10] (03PS2) 10Eileen: Remove one of our legacy timestamp functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111696 [21:54:10] (03PS1) 10Eileen: Move getContributionStatus to the message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111711 (https://phabricator.wikimedia.org/T270677) [21:54:12] (03PS1) 10Eileen: Switch markRefund from using legacy function to message function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111712 (https://phabricator.wikimedia.org/T270677) [21:54:15] (03PS1) 10Eileen: Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111713 [21:55:25] (03PS2) 10Eileen: Remove legacy constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111697 [21:55:47] (03PS2) 10Eileen: Fold date back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111698 [21:56:01] (03PS2) 10Eileen: Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 [21:56:12] (03PS2) 10Eileen: Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 [21:56:18] (03PS2) 10Eileen: Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 [21:56:24] (03PS2) 10Jforrester: FundraiserSubscriptionPage: Don't let unknown wgDonationInterfacePolicyURL fatal [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1111710 [21:56:24] (03PS4) 10Jforrester: Change function name to remove underscore [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1106000 (owner: 10Umherirrender) [21:56:24] (03PS18) 10Jforrester: FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) [22:01:58] (03CR) 10CI reject: [V:04-1] FundraiserSubscriptionPage::getTemplateParams: Fix errors on PHP 8.1 [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1003549 (https://phabricator.wikimedia.org/T357593) (owner: 10Jforrester) [22:02:11] (03PS1) 10Eileen: Use Message->getDate() for all retrievals of message date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111714 (https://phabricator.wikimedia.org/T270677) [22:17:54] (03CR) 10CI reject: [V:04-1] Switch markRefund from using legacy function to message function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111712 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [22:19:10] (03CR) 10CI reject: [V:04-1] Remove one of our legacy timestamp functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111696 (owner: 10Eileen) [22:21:20] (03CR) 10CI reject: [V:04-1] Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 (owner: 10Eileen) [22:22:16] (03CR) 10CI reject: [V:04-1] Fold date back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111698 (owner: 10Eileen) [22:23:00] (03CR) 10CI reject: [V:04-1] Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 (owner: 10Eileen) [22:23:05] (03CR) 10CI reject: [V:04-1] Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 (owner: 10Eileen) [22:24:16] (03CR) 10CI reject: [V:04-1] Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111713 (owner: 10Eileen) [22:24:32] (03CR) 10CI reject: [V:04-1] Remove legacy constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111697 (owner: 10Eileen) [22:26:45] (03CR) 10CI reject: [V:04-1] Use Message->getDate() for all retrievals of message date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111714 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [22:39:11] ug I'm getting myself in a chain mess! [22:43:03] (03PS2) 10Eileen: Switch markRefund from using legacy function to message function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111712 (https://phabricator.wikimedia.org/T270677) [22:43:03] (03PS2) 10Eileen: Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111713 [22:43:03] (03PS3) 10Eileen: Remove one of our legacy timestamp functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111696 [22:43:04] (03PS3) 10Eileen: Remove legacy constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111697 [22:43:05] (03PS3) 10Eileen: Fold date back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111698 [22:43:06] (03PS3) 10Eileen: Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 [22:43:10] (03PS3) 10Eileen: Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 [22:43:14] (03PS3) 10Eileen: Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 [22:43:18] (03PS2) 10Eileen: Use Message->getDate() for all retrievals of message date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111714 (https://phabricator.wikimedia.org/T270677) [23:10:46] (03CR) 10CI reject: [V:04-1] Remove last reference to one of our legacy date functions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111701 (owner: 10Eileen) [23:11:49] (03CR) 10CI reject: [V:04-1] Fix another place not to use legacy date function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111700 (owner: 10Eileen) [23:12:10] PROBLEM - check_coworker on frdev1002 is CRITICAL: PROCS CRITICAL: 1 process with args php /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_coworker [23:13:12] (03CR) 10CI reject: [V:04-1] Use Message->getDate() for all retrievals of message date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111714 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [23:13:31] (03CR) 10CI reject: [V:04-1] Simplify timestamp handling in contribution tracking [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111699 (owner: 10Eileen) [23:17:10] RECOVERY - check_coworker on frdev1002 is OK: PROCS OK: 0 processes with args php /srv/coworker/bin/coworker https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_coworker [23:33:48] PROBLEM - Host frbackup2002 is DOWN: PING CRITICAL - Packet loss = 100% [23:37:12] RECOVERY - Host frbackup2002 is UP: PING OK - Packet loss = 0%, RTA = 30.45 ms [23:42:59] dwisehaupt: I love that we have automated 'check coworker is OK' [23:44:08] well, that's just checking the process is running. not that it's doing what we want. :) but yeah, it's a good thing since it made me realize that in my package updates i accidentally started coworker on frdev.