[00:22:16] 03Fundraising Sprint: A, 06Fundraising-Backlog: translate epc - https://phabricator.wikimedia.org/T381336#10469048 (10AnnWF) [11:11:32] (03CR) 10Jgleeson: [C:03+2] "This looks good to me. Good test coverage also." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [11:14:40] (03CR) 10Damilare Adedoyin: [C:03+2] Fold thank_you_send back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108871 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [11:24:04] (03CR) 10Jgleeson: [C:03+2] Code comments - just some of my thoughts about exceptiosn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111734 (owner: 10Eileen) [11:33:45] (03PS2) 10Jgleeson: Refactor: Add type hints to QueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112085 [11:33:45] (03PS2) 10Jgleeson: Refactor: Add type hints to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112087 [11:37:23] (03PS2) 10Cstone: Add payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 [11:39:54] (03CR) 10CI reject: [V:04-1] Add payment methods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [11:41:23] (03Merged) 10jenkins-bot: Fold thank_you_send back into only caller [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108871 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [12:00:47] (03CR) 10Damilare Adedoyin: "Thanks for the work on this, I'm thinking we could go a step further to make all the payment methods used in this class a constant. Makes " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111334 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:01:10] nevermind jgleeson, just saw the follow on [12:01:18] :) [12:02:05] (03CR) 10Damilare Adedoyin: [C:03+2] "Ahh never mind, just saw the follow on patch that did what I suggested on this patch. LGTM, thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111334 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:03:07] (03CR) 10Damilare Adedoyin: [C:03+2] Run fraud filters for Adyen ApplePay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111333 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:06:41] (03Merged) 10jenkins-bot: Run fraud filters for Adyen ApplePay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111333 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:06:42] (03Merged) 10jenkins-bot: Constantize app payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111334 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:09:48] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks for all the work on this, added some comments inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:11:23] (03CR) 10Jgleeson: "Thanks dami, I'll those missing ones in and push it back up" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [12:19:39] thanks jgleeson [12:20:25] brb gotta make a gp appointment with Tosin. [12:58:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 492291MiB [12:58:12] de=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:03:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 470507MiB [13:03:12] de=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:08:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 446344MiB [13:08:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:09:17] (03PS3) 10Jgleeson: Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:09:27] thanks for the review damilare|brb [13:10:22] I'll circle back to that patch now. I went down a rabbit hole looking over cstone's patch as it looks really useful. [13:11:15] (03CR) 10CI reject: [V:04-1] Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:11:54] (03PS4) 10Jgleeson: Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:13:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 421526MiB [13:13:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:13:41] (03CR) 10CI reject: [V:04-1] Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:14:16] (03PS5) 10Jgleeson: Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:15:27] (03PS6) 10Jgleeson: Add payment methods special page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1064895 (owner: 10Cstone) [13:18:14] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 397625MiB [13:18:14] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:20:24] (03PS4) 10Jgleeson: Constantize other payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) [13:20:30] updated damilare|brb ^ [13:21:51] cstone: your payments method special page is now passing on CI. I added a wikidata table class to the output which looks kinda nice, what do you think? [13:22:12] (03PS4) 10Jgleeson: To Run, RunDo or DoRun. That is the question. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111339 [13:22:51] (03PS5) 10Jgleeson: Constantize other payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) [13:23:06] (03PS5) 10Jgleeson: To Run, RunDo or DoRun. That is the question. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111339 [13:23:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 374392MiB [13:23:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:28:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 353280MiB [13:28:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:33:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 333883MiB [13:33:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:38:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 314115MiB [13:38:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:43:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 293241MiB [13:43:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:48:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 269565MiB [13:48:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:48:31] (03PS1) 10Jgleeson: Fix PHPUnit deprecated strtottime() warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112212 [13:53:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 249231MiB [13:53:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [13:58:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 220915MiB [13:58:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:03:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 187298MiB [14:03:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:08:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 151945MiB [14:08:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:13:12] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 134180MiB [14:13:12] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:18:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 118201MiB [14:18:13] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:23:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 110537MiB [14:23:13] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:28:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 104508MiB [14:28:13] e=99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:33:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 94455MiB [14:33:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:38:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 86006MiB [14:38:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:43:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 76751MiB [14:43:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:48:12] (03CR) 10Jgleeson: [C:03+2] Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [14:48:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 68932MiB [14:48:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:53:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 62340MiB [14:53:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [14:55:05] (03CR) 10Jgleeson: "That extension you recommended doesn't like the nested ternary operator https://phabricator.wikimedia.org/F58222405" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109184 (owner: 10Eileen) [14:58:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 56788MiB [14:58:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:03:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 49445MiB [15:03:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:08:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 39283MiB [15:08:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:13:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 28926MiB [15:13:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:14:45] (03Merged) 10jenkins-bot: Remove unused phpMailer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108507 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [15:18:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 19179MiB [15:18:13] =99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:23:13] PROBLEM - check_disk on frdb1004 is CRITICAL: DISK CRITICAL - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25486MiB (96% inode=99%): /srv 9615MiB ( [15:23:13] 99%): /var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:28:13] RECOVERY - check_disk on frdb1004 is OK: DISK OK - free space: /dev 257273MiB (100% inode=99%): /run 51457MiB (99% inode=99%): / 4703MiB (67% inode=89%): /dev/shm 257297MiB (100% inode=99%): /run/lock 5MiB (100% inode=99%): /boot 571MiB (83% inode=99%): /home 12347MiB (99% inode=99%): /tmp 12350MiB (99% inode=99%): /var 25833MiB (97% inode=99%): /var/tmp 408MiB (99% inode=99%): /var/log 25485MiB (96% inode=99%): /srv 1328944MiB (29% inod [15:28:13] var/log/audit 408MiB (99% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_disk [15:53:39] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work on this, LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [15:57:12] thanks damilare ! [15:57:22] np [16:02:45] (03CR) 10Jgleeson: "Ready-baked-EA-extension-pleasing alternative:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1109184 (owner: 10Eileen) [16:21:48] (03CR) 10Damilare Adedoyin: [C:03+2] "Efficient naming, one verb (run) doing the job of two (run & do)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111339 (owner: 10Jgleeson) [16:44:21] thanks damilare lol [16:44:55] there's a song with the lyrics, "they do run run run they do run run run" and that patch reminded me of it [16:45:58] lol [16:47:41] https://www.youtube.com/watch?v=uTqnam1zgiw [16:48:03] the words are actually "Da Do Ron Ron" [16:48:08] but to the ear... [16:52:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10471657 (10Cstone) a:03Cstone [16:58:53] jeez, 1h 30m wait on gate-and-submit jobs https://integration.wikimedia.org/zuul/ [17:02:02] (03CR) 10Damilare Adedoyin: [C:03+2] Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [17:06:17] 06Fundraising-Backlog: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10471785 (10KSarabia-WMF) Hi @spatton We had an async discussion about this and this is what we came up with: - Dynamic Elements: This could impact performance and is flagged as scope creep for the cu... [17:10:23] (03Merged) 10jenkins-bot: Constantize other payment method strings in Adyen Adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111335 (https://phabricator.wikimedia.org/T383352) (owner: 10Jgleeson) [17:24:37] (03CR) 10Máté Szabó: [C:03+2] selenium: Wait for the page to be fully loaded in Page.openTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1109152 (owner: 10Umherirrender) [17:32:44] (03CR) 10CI reject: [V:04-1] Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [17:32:45] (03CR) 10CI reject: [V:04-1] Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [17:32:46] (03CR) 10CI reject: [V:04-1] Code comments - just some of my thoughts about exceptiosn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111734 (owner: 10Eileen) [17:37:58] (03Merged) 10jenkins-bot: To Run, RunDo or DoRun. That is the question. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1111339 (owner: 10Jgleeson) [17:53:27] (03CR) 10Damilare Adedoyin: [C:03+2] "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [18:16:59] (03CR) 10CI reject: [V:04-1] selenium: Wait for the page to be fully loaded in Page.openTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1109152 (owner: 10Umherirrender) [18:20:27] (03Merged) 10jenkins-bot: Update function signature to reflect callers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108872 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [18:23:54] (03CR) 10CI reject: [V:04-1] Consolidate handling of contributionID [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [18:23:54] (03CR) 10CI reject: [V:04-1] Code comments - just some of my thoughts about exceptiosn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111734 (owner: 10Eileen) [18:31:03] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1108873 (https://phabricator.wikimedia.org/T299096) (owner: 10Eileen) [18:46:55] (03CR) 10Umherirrender: [C:03+2] "Resubmit" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1109152 (owner: 10Umherirrender) [18:52:08] (03PS1) 10Damilare Adedoyin: Pull out mailing data query to simplify the thank_you_for_contribution function. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112271 (https://phabricator.wikimedia.org/T270674) [18:56:13] (03PS2) 10Damilare Adedoyin: Pull out mailing data query to simplify the thank_you_for_contribution function. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112271 (https://phabricator.wikimedia.org/T270674) [19:07:39] (03Merged) 10jenkins-bot: selenium: Wait for the page to be fully loaded in Page.openTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1109152 (owner: 10Umherirrender) [19:09:40] (03PS1) 10Damilare Adedoyin: Set venmo username in params if it exists in mailing data, since we are accepting Venmo for Gravy and Braintree [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112272 [21:02:37] (03CR) 10Umherirrender: FundraiserSubscriptionPage: Don't let unknown wgDonationInterfacePolicyURL fatal (032 comments) [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/1111710 (owner: 10Jforrester) [21:05:08] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111734 (owner: 10Eileen) [21:06:10] (03CR) 10Eileen: [C:03+2] Pull out mailing data query to simplify the thank_you_for_contribution function. (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112271 (https://phabricator.wikimedia.org/T270674) (owner: 10Damilare Adedoyin) [21:07:00] (03CR) 10Eileen: [C:03+2] "OK - I did wonder about that if clause - makes sense" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112272 (owner: 10Damilare Adedoyin) [21:09:50] (03PS1) 10Umherirrender: tests: Add bundle size file without budget to pass tests [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1112287 (https://phabricator.wikimedia.org/T383526) [21:15:32] (03PS1) 10Damilare Adedoyin: Make sure to send the venmo username only when contribution is from venmo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 [21:20:44] thanks for the review eileen, I just realised it probably best to keep that check for the venmo contribution ^ [21:25:40] because the value is against the contact not the contribution - at a high level I would suggest the check belongs in \Civi\WorkflowMessage\ThankYou - in general that is the class that handles what is assigned to the template - we have that extra query in the thank_you.module because we *suspect* it *might* be more performant to pre-load the variables - but variables are loaded by ` \Civi\WorkflowMessage\ThankYou` if [21:25:40] not provided and, importantly, when you send from the UI it is the ` \Civi\WorkflowMessage\ThankYou` class that decides what to assign [21:26:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Update Adyen support cc methods and currencies - https://phabricator.wikimedia.org/T384081 (10AnnWF) 03NEW [21:26:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Update Adyen support cc methods and currencies - https://phabricator.wikimedia.org/T384081#10472662 (10AnnWF) p:05Triage→03Low [21:27:59] also damilare|away FYI - my personal suspicion is that if the `getMailingQuery` JUST got the contribution IDs & only passed them to ThankYou:send there would be no significant loss of performance or functionality [21:28:20] (03Merged) 10jenkins-bot: Code comments - just some of my thoughts about exceptiosn [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1111734 (owner: 10Eileen) [21:31:28] (03Merged) 10jenkins-bot: Pull out mailing data query to simplify the thank_you_for_contribution function. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112271 (https://phabricator.wikimedia.org/T270674) (owner: 10Damilare Adedoyin) [21:31:30] (03Merged) 10jenkins-bot: Set venmo username in params if it exists in mailing data, since we are accepting Venmo for Gravy and Braintree [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112272 (owner: 10Damilare Adedoyin) [23:06:34] 03Fundraising Sprint: A, 06Fundraising-Backlog: translate epc - https://phabricator.wikimedia.org/T381336#10473054 (10AnnWF) [23:08:20] (03PS1) 10Wfan: translate epc in zh-hant [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) [23:09:41] (03PS2) 10Wfan: translate epc in zh-hant/ zh-hans/ vi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) [23:21:07] (03PS3) 10Wfan: translate epc in zh-hans/zh-hant and vi [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336)