[22:20:14] (03PS1) 10Eileen: Fix recurring to call api directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) [22:53:00] (03PS1) 10Eileen: Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) [22:59:47] (03CR) 10Eileen: [C:03+2] Fix PHPUnit deprecated strtottime() warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112212 (owner: 10Jgleeson) [23:00:06] (03CR) 10Eileen: [C:03+2] Refactor: Add type hints to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112087 (owner: 10Jgleeson) [23:00:28] (03CR) 10Eileen: [C:03+2] Refactor: Add type hints to QueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112085 (owner: 10Jgleeson) [23:02:11] (03CR) 10Eileen: "at a high level I would suggest the check belongs in \Civi\WorkflowMessage\ThankYou - in general that is the class that handles what is as" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 (owner: 10Damilare Adedoyin) [23:02:24] (03CR) 10Eileen: "my personal suspicion is that if the `getMailingQuery` JUST got the contribution IDs & only passed them to ThankYou:send there would be no" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 (owner: 10Damilare Adedoyin) [23:24:26] (03Merged) 10jenkins-bot: Refactor: Add type hints to QueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112085 (owner: 10Jgleeson) [23:24:27] (03Merged) 10jenkins-bot: Refactor: Add type hints to DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112087 (owner: 10Jgleeson) [23:24:29] (03Merged) 10jenkins-bot: Fix PHPUnit deprecated strtottime() warnings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112212 (owner: 10Jgleeson) [23:33:13] (03PS1) 10Eileen: Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) [23:33:14] (03PS1) 10Eileen: Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) [23:54:41] (03PS1) 10Eileen: Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) [23:54:43] (03PS1) 10Eileen: Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) [23:54:44] (03PS1) 10Eileen: Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) [23:56:06] (03CR) 10CI reject: [V:04-1] Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen)