[00:03:00] (03PS2) 10Eileen: Fix recurring to call api directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) [00:03:00] (03PS2) 10Eileen: Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) [00:03:01] (03PS2) 10Eileen: Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) [00:03:01] (03PS2) 10Eileen: Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) [00:03:02] (03PS2) 10Eileen: Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) [00:03:03] (03PS2) 10Eileen: Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) [00:03:07] (03PS2) 10Eileen: Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) [00:50:06] (03PS3) 10Eileen: Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) [00:50:06] (03PS1) 10Eileen: Remove unreachable if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112424 (https://phabricator.wikimedia.org/T270677) [00:50:07] (03PS1) 10Eileen: Hone type hint - only recurDonationMessages get this far [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112425 (https://phabricator.wikimedia.org/T270677) [00:50:09] (03PS1) 10Eileen: Simplify retrieval of value used only for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112426 (https://phabricator.wikimedia.org/T270677) [00:50:11] (03PS1) 10Eileen: Move payment create call into createRecur, next to it's twin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112427 (https://phabricator.wikimedia.org/T270677) [00:50:13] (03PS1) 10Eileen: Remove trxn_id from extraRecurringParams [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112428 (https://phabricator.wikimedia.org/T270677) [00:50:14] (03PS1) 10Eileen: Merge the 2 token creates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112429 (https://phabricator.wikimedia.org/T270677) [00:50:17] (03PS1) 10Eileen: Fold back last call to token create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112430 (https://phabricator.wikimedia.org/T270677) [00:50:21] (03PS1) 10Eileen: Remove last call to recurring.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112431 (https://phabricator.wikimedia.org/T270677) [00:50:25] (03PS1) 10Eileen: Some minor additional comments, extra usage of message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112432 (https://phabricator.wikimedia.org/T270677) [00:50:29] (03PS1) 10Eileen: Use api directly instead of legacy wrapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112433 (https://phabricator.wikimedia.org/T270677) [00:50:33] (03PS1) 10Eileen: Remove last call to tracking.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112434 (https://phabricator.wikimedia.org/T270677) [00:50:37] (03PS1) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112435 [01:07:21] (03PS1) 10Eileen: Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) [01:07:23] (03PS1) 10Eileen: Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) [01:13:53] (03PS1) 10Eileen: Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) [01:27:53] (03CR) 10CI reject: [V:04-1] Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112435 (owner: 10Eileen) [01:32:20] (03CR) 10CI reject: [V:04-1] Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [01:35:08] (03CR) 10CI reject: [V:04-1] Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [01:40:02] (03CR) 10CI reject: [V:04-1] Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [02:25:10] (03Abandoned) 10Eileen: Do not merge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112435 (owner: 10Eileen) [02:30:14] (03PS2) 10Eileen: Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) [02:30:14] (03PS2) 10Eileen: Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) [02:30:14] (03PS2) 10Eileen: Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) [02:30:15] (03PS1) 10Eileen: Simplify contribution extra lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112443 [02:30:16] (03PS1) 10Eileen: Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) [03:04:52] (03CR) 10CI reject: [V:04-1] Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [03:23:34] (03PS2) 10Eileen: Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) [03:31:12] (03PS1) 10Eileen: Migrate last wmf_civicrm variable to a setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112446 (https://phabricator.wikimedia.org/T270677) [04:37:46] (03PS2) 10Eileen: Migrate last wmf_civicrm variable to a setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112446 (https://phabricator.wikimedia.org/T270677) [04:37:46] (03PS1) 10Eileen: Run civix upgrade on matching-gifts extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112448 [05:18:16] PROBLEM - check_mysql on frdb1004 is CRITICAL: Too many connections https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:23:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: Too many connections https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:28:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: Too many connections https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:33:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: Too many connections https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:38:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:43:16] PROBLEM - check_mysql on frdb1004 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:48:16] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 72779 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:51:02] ^^ replication lag here is know and recovering. [05:51:21] need to find out why connections weren't closing out from the icinga checks. [05:53:14] PROBLEM - check_mysql on frdb1004 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 17727 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [05:58:16] RECOVERY - check_mysql on frdb1004 is OK: Uptime: 892 Threads: 4 Questions: 1806750 Slow queries: 0 Opens: 1150 Open tables: 1144 Queries per second avg: 2025.504 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1004&service=check_mysql [07:25:55] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112607 (owner: 10L10n-bot) [08:47:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 13Patch-For-Review: Unable to find a donation form matching parameters error - https://phabricator.wikimedia.org/T382102#10475257 (10krobinson) Thanks for sharing [[ https://docs.google.com/spreadsheets/d/1GnmFM2VoXHcZJzRo-dLWq2Ndi... [10:26:33] (03CR) 10Jgleeson: [C:04-1] "The PaymentToken stuff looks fine. However I think there's some left over debug code in PriceSet.tpl" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [10:36:13] (03CR) 10Jgleeson: [C:03+2] Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [10:59:20] (03CR) 10Jgleeson: [C:03+2] Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:10:38] (03CR) 10Jgleeson: [C:03+2] Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:22:05] (03CR) 10Jgleeson: [C:03+2] Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:41:13] (03CR) 10Jgleeson: [C:03+2] Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:03:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Trustly ACH recurring (gravy) that are cancelled on the donors end are breaking the charge job - https://phabricator.wikimedia.org/T382629#10476003 (10jgleeson) We had another one of these today [13:10:06] (03CR) 10Jgleeson: [C:03+2] Remove unreachable if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112424 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:15:29] (03CR) 10Jgleeson: [C:03+2] Hone type hint - only recurDonationMessages get this far [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112425 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:21:15] (03CR) 10Jgleeson: [C:03+2] Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:34:54] (03CR) 10Jgleeson: [C:03+2] Simplify retrieval of value used only for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112426 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:41:11] (03CR) 10Jgleeson: [C:03+2] Move payment create call into createRecur, next to it's twin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112427 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [13:55:48] (03CR) 10Jgleeson: [C:03+2] Remove trxn_id from extraRecurringParams [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112428 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:05:39] (03CR) 10Jgleeson: [C:03+2] "The gateway removal made me curious, but it's impossible to be unset by that point, so it's safe to go." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112429 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:09:41] (03CR) 10Jgleeson: [C:03+2] Fold back last call to token create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112430 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:16:55] (03CR) 10Jgleeson: Send recurring payments to donations queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/556829 (https://phabricator.wikimedia.org/T366526) (owner: 10Ejegg) [14:39:40] (03CR) 10Jgleeson: [C:03+2] "There's a small docblock update needed due to this change for" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112431 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:49:40] (03CR) 10Jgleeson: [C:03+2] Some minor additional comments, extra usage of message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112432 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:50:11] (03CR) 10Jgleeson: [C:03+2] Use api directly instead of legacy wrapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112433 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:52:55] (03CR) 10Jgleeson: [C:03+2] Remove last call to tracking.inc (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112434 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [15:42:40] (03PS2) 10Damilare Adedoyin: Make sure to send the venmo username only when contribution is from venmo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 [15:46:55] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112607 (owner: 10L10n-bot) [16:18:44] (03CR) 10Jgleeson: [C:03+2] "Nice cleanup!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112443 (owner: 10Eileen) [16:47:15] (03CR) 10Jgleeson: [C:03+2] Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [16:53:24] (03CR) 10Jgleeson: [C:03+2] Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [17:07:07] (03PS3) 10Damilare Adedoyin: Make sure to send the venmo username only when contribution is from venmo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 [17:08:23] (03CR) 10Damilare Adedoyin: "Thanks eileen for the feedback. I've moved the username check to the WorkflowMessage class, since there's no reason we should be doing the" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 (owner: 10Damilare Adedoyin) [17:50:53] (03CR) 10Jgleeson: [C:03+2] Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [17:57:47] (03CR) 10Jgleeson: [C:03+2] Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [17:58:51] (03CR) 10Jgleeson: [C:03+2] Run civix upgrade on matching-gifts extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112448 (owner: 10Eileen) [18:08:38] (03CR) 10Jgleeson: [C:03+2] "I forgot about this procedural process to pull down these files. This will be a great one to wrap up in an object or two once moved over." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112446 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:15:18] (03CR) 10Jgleeson: [C:04-1] "eileen - I'll remove that debug code and we can add it back in if needed" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:31:16] oh man. I wish I did that first [18:31:17] To ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm.git [18:31:17] ! [remote rejected] HEAD -> refs/for/master (the number of pushed changes in a batch exceeds the max limit 20) [18:31:17] error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm.git' [18:33:59] (03PS3) 10Jgleeson: Fix recurring to call api directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:33:59] (03PS3) 10Jgleeson: Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:00] (03PS3) 10Jgleeson: Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:00] (03PS3) 10Jgleeson: Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:01] (03PS3) 10Jgleeson: Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:03] (03PS2) 10Jgleeson: Remove unreachable if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112424 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:07] (03PS2) 10Jgleeson: Hone type hint - only recurDonationMessages get this far [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112425 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:11] (03PS4) 10Jgleeson: Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:15] (03PS2) 10Jgleeson: Simplify retrieval of value used only for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112426 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:19] (03PS2) 10Jgleeson: Move payment create call into createRecur, next to it's twin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112427 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:23] (03PS2) 10Jgleeson: Remove trxn_id from extraRecurringParams [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112428 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:27] (03PS2) 10Jgleeson: Merge the 2 token creates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112429 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:31] (03PS2) 10Jgleeson: Fold back last call to token create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112430 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:35] (03PS2) 10Jgleeson: Remove last call to recurring.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112431 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:39] (03PS2) 10Jgleeson: Some minor additional comments, extra usage of message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112432 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:43] (03PS2) 10Jgleeson: Use api directly instead of legacy wrapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112433 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:47] (03PS2) 10Jgleeson: Remove last call to tracking.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112434 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:34:51] (03PS2) 10Jgleeson: Simplify contribution extra lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112443 (owner: 10Eileen) [18:34:55] (03PS3) 10Jgleeson: Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:36:00] (03PS3) 10Eileen: Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) [18:36:05] (03PS3) 10Eileen: Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) [18:36:10] (03PS3) 10Eileen: Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) [18:36:15] (03PS2) 10Eileen: Run civix upgrade on matching-gifts extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112448 [18:36:19] (03PS3) 10Eileen: Migrate last wmf_civicrm variable to a setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112446 (https://phabricator.wikimedia.org/T270677) [18:36:46] argh. that 20 patch rebase just wiped all the +2s [18:38:19] (03CR) 10Jgleeson: [C:03+2] "Another +2!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:22] (03CR) 10Jgleeson: [V:03+2 C:03+2] Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:25] (03CR) 10Jgleeson: [V:03+2 C:03+2] Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:29] (03CR) 10Jgleeson: [V:03+2 C:03+2] Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:40] (03CR) 10Jgleeson: [V:03+2 C:03+2] Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:43] (03CR) 10Jgleeson: [V:03+2 C:03+2] Remove unreachable if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112424 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:46] (03CR) 10Jgleeson: [V:03+2 C:03+2] Hone type hint - only recurDonationMessages get this far [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112425 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:38:51] (03CR) 10Jgleeson: [V:03+2 C:03+2] Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [18:39:35] oh no! it was the v+2 that got removed not the c+2 [18:39:40] ok I can see the rest alone [18:42:13] jgleeson: looks like you have been reviewing up a storm [18:42:53] (03PS1) 10Jgleeson: Small docblock update post e9ebe2d1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112827 (https://phabricator.wikimedia.org/T270677) [18:43:35] sorry eileen for the double noise. I figured I'd update the patch at the base of the chain to get it all merged for you as everything else looked good [18:44:04] yeah chains can get tricking! [18:44:05] rebasing the chain then triggered a wave of v+2 strippings and irc spam [18:44:07] tricky [18:44:44] eileen: can you confirm this was added accidentially? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1112414/3#message-181ed9102808c2572beb94fa6f4755ceb5f783a1 [18:45:19] lol - I can!! [18:46:11] thanks [18:55:31] eileen: I noted a few things as potential follow ups to that chain [18:55:41] - extract dupicated $invoice_fields = ['invoice_id', 'order_id']; code into fn DonationQueueConsumer.php:318 [18:55:41] - look into followup on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1112434/1 [18:55:41] - type hints in UpiDonationsQueueConsumer.php [18:55:41] - enhance testRecurringNoToken to check for token also (inline with name) [18:55:41] - remove layer of condition nesting in 0f1670cf (check tab) [18:55:41] -- extract out combine if params and give them specifc names e.g. isRecurringAndHasRecurID isRecurringWithoutRecurID [18:56:59] a few of them were kinda answered as I moved through the following patches - the top one has a block of duplicated code across two files but one of them is that checksfile which is on your hitlist [18:57:00] oh cool - on the unnecessary casting - I kinda tend to over cast if in doubt for clarity [18:57:34] is that call where there is no casting? [18:57:50] I think that point was that we might need casting [18:58:29] oh - I thought you were seeing too much - just looking at the top one now [19:03:11] (03Merged) 10jenkins-bot: Fix recurring to call api directly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112414 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:03:13] (03Merged) 10jenkins-bot: Call PaymentToken api directly from DonationQueueConsumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112415 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:03:15] (03Merged) 10jenkins-bot: Split out if-else to separate IF clauses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112417 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:03:16] (03Merged) 10jenkins-bot: Set the values from the PaymentToken in the normalize function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112418 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:03:53] (03Merged) 10jenkins-bot: Consolidate createRecurring if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112419 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:12] (03Merged) 10jenkins-bot: Remove unreachable if [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112424 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:14] (03Merged) 10jenkins-bot: Hone type hint - only recurDonationMessages get this far [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112425 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:30] (03Merged) 10jenkins-bot: Replace call to legacy function with keeping the saved value [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112421 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:32] (03Merged) 10jenkins-bot: Simplify retrieval of value used only for logging [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112426 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:33] (03Merged) 10jenkins-bot: Move payment create call into createRecur, next to it's twin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112427 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:35] (03Merged) 10jenkins-bot: Remove trxn_id from extraRecurringParams [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112428 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:36] (03Merged) 10jenkins-bot: Merge the 2 token creates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112429 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:38] (03Merged) 10jenkins-bot: Fold back last call to token create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112430 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:39] (03Merged) 10jenkins-bot: Remove last call to recurring.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112431 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:41] (03Merged) 10jenkins-bot: Some minor additional comments, extra usage of message object [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112432 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:47] (03Merged) 10jenkins-bot: Use api directly instead of legacy wrapper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112433 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:04:55] (03Merged) 10jenkins-bot: Remove last call to tracking.inc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112434 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:05:12] (03Merged) 10jenkins-bot: Simplify contribution extra lookup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112443 (owner: 10Eileen) [19:10:17] (03PS1) 10Eileen: Move invoice ID handling to Message classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112834 (https://phabricator.wikimedia.org/T270677) [19:11:23] jgleeson: so on the first thing you pointed out - this is what I would do on that https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1112834 [19:12:10] (03CR) 10Jgleeson: "The only one I can see missing in Tonga - TO. Should we add that too?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112310 (https://phabricator.wikimedia.org/T382102) (owner: 10Cstone) [19:13:58] eileen: do you think it's worth consolidating this copy also? https://github.com/wikimedia/wikimedia-fundraising-crm/blob/74e3a89794ef78fa528600ecd2ab1c3598a11bcd/drupal/sites/all/modules/offline2civicrm/ChecksFile.php#L380 [19:14:09] it#s the same right up to the log line [19:14:25] but I did see it's due to be retired [19:14:31] jgleeson: nah - that code is gonna be deleted soon [19:16:07] ok cool [19:17:23] (03PS3) 10Eileen: Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) [19:26:14] (03PS1) 10Eileen: Clean up type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112835 [19:26:37] I've been seeing a message coming up as a deadlock that seems to be not going through - suggesting it's not really a deadlock - I feel like we want to add a way to retry the message in real time - I might have a go [19:26:38] (03Merged) 10jenkins-bot: Simplify handling of thankyou_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112436 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:26:46] eileen: on that invoice ID one - it looks like that foreach loop gives priority to order_id (with it coming second) [19:26:47] jgleeson: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1112835 does 2 & 3 on your list [19:27:02] jgleeson: I thought that too BUT there is a break [19:27:09] oh rly [19:27:16] lemme look again [19:28:02] yes there is! [19:28:04] I missed that [19:30:11] jgleeson: a good argument for why the code was worth changing! We both misread it [19:43:20] indeed [19:44:39] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112834 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:44:52] (03CR) 10Jgleeson: [C:03+2] Clean up type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112835 (owner: 10Eileen) [19:46:30] eileen: I think 5 on that list might have been made redundant in later changes [19:46:44] jgleeson: oh cool [19:46:48] as in, I don't think that code even exists that I was referring to [19:46:53] anymore [19:48:22] I'm wrapping up now and gonna do a bit of reading. catch you all tomorrow [19:52:00] (03PS1) 10Eileen: Further if clean up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112842 (https://phabricator.wikimedia.org/T270677) [19:52:19] ok cool - I just pushed up one more change to one of your points [20:11:36] (03Merged) 10jenkins-bot: Copy legacy date function to be called directly in outgoing code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112437 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:11:37] (03Merged) 10jenkins-bot: Partial consolidation of handling for cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112439 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:11:38] (03Merged) 10jenkins-bot: Remove date legacy function from RecurringQueue processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112444 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:11:40] (03Merged) 10jenkins-bot: Run civix upgrade on matching-gifts extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112448 (owner: 10Eileen) [20:11:41] (03Merged) 10jenkins-bot: Migrate last wmf_civicrm variable to a setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112446 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:11:44] (03Merged) 10jenkins-bot: Move invoice ID handling to Message classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112834 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [20:11:45] (03Merged) 10jenkins-bot: Clean up type hints [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112835 (owner: 10Eileen) [21:42:04] (03PS1) 10Eileen: Add Damaged.consume api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112847 [21:46:57] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [21:47:05] (03PS4) 10Eileen: Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) [21:47:40] (03Abandoned) 10Eileen: Move token create into create recur [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112420 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [21:58:52] (03CR) 10Eileen: [C:03+2] Small docblock update post e9ebe2d1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112827 (https://phabricator.wikimedia.org/T270677) (owner: 10Jgleeson) [21:59:40] (03CR) 10Eileen: [C:03+2] Make sure to send the venmo username only when contribution is from venmo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 (owner: 10Damilare Adedoyin) [22:22:03] (03Merged) 10jenkins-bot: Small docblock update post e9ebe2d1 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112827 (https://phabricator.wikimedia.org/T270677) (owner: 10Jgleeson) [22:23:49] (03Merged) 10jenkins-bot: Make sure to send the venmo username only when contribution is from venmo [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112288 (owner: 10Damilare Adedoyin) [22:25:38] (03PS1) 10Eileen: Declare matching gift settings properly [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112850 (https://phabricator.wikimedia.org/T270677) [22:54:13] (03PS1) 10Eileen: Move initial code chunk to MatchingGift.VerifyEmployerFile api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112851 (https://phabricator.wikimedia.org/T270677) [23:44:33] (03PS2) 10Eileen: Move initial code chunk to MatchingGift.VerifyEmployerFile api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112851 (https://phabricator.wikimedia.org/T270677) [23:44:33] (03PS1) 10Eileen: Move function to new api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112854 (https://phabricator.wikimedia.org/T270677) [23:44:33] (03PS1) 10Eileen: Move another function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112855 (https://phabricator.wikimedia.org/T270677) [23:44:35] (03PS1) 10Eileen: Move another function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112856 (https://phabricator.wikimedia.org/T270677) [23:44:37] (03PS1) 10Eileen: Another function move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112857 (https://phabricator.wikimedia.org/T270677)