[02:41:38] (03PS1) 10Cstone: WIP: Create getErrorMesageText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) [05:05:39] 06Fundraising-Backlog: Queue messages are logged twice - https://phabricator.wikimedia.org/T384561 (10Cstone) 03NEW [06:13:48] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1113635 (owner: 10L10n-bot) [07:15:46] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1113274 (owner: 10L10n-bot) [07:15:48] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1113635 (owner: 10L10n-bot) [08:12:07] 06Fundraising-Backlog, 05FY2024-25 WE3.2 Donation Entry Points: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10487777 (10Aklapper) [11:48:41] (03CR) 10Máté Szabó: [C:03+2] Use Title::makeTitle in Banner::getTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108164 (owner: 10Umherirrender) [12:12:43] (03Merged) 10jenkins-bot: Use Title::makeTitle in Banner::getTitle [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108164 (owner: 10Umherirrender) [12:12:45] (03Merged) 10jenkins-bot: Add @inheritDoc to functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1108167 (owner: 10Umherirrender) [12:13:03] 03Fundraising Sprint: Abula, 06Fundraising-Backlog: Create chargeback and cancel recurring on failed Trustly ACH payments - https://phabricator.wikimedia.org/T384593 (10Damilare) 03NEW [14:00:00] (03CR) 10Jgleeson: [C:03+2] "LGTM! Looking back over this code, I wish I'd used fewer if statements!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112856 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:02:45] (03CR) 10Jgleeson: [C:03+2] Another function move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112857 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:07:09] (03CR) 10Jgleeson: [C:03+2] Preliminary clean up in test classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112859 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:15:20] (03CR) 10Jgleeson: [C:03+2] Move last function in major gifts drush job, add unit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112862 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:27:28] (03Merged) 10jenkins-bot: Move another function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112856 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:28:44] (03Merged) 10jenkins-bot: Another function move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112857 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:33:35] (03Merged) 10jenkins-bot: Preliminary clean up in test classes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112859 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:38:51] (03Merged) 10jenkins-bot: Move last function in major gifts drush job, add unit test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112862 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [14:46:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Monthly convert template broken (monthly_convert.es_MX.html) - https://phabricator.wikimedia.org/T384602 (10jgleeson) 03NEW [15:47:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Monthly convert template broken (monthly_convert.es_MX.html) - https://phabricator.wikimedia.org/T384602#10489337 (10jgleeson) [16:01:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Monthly convert template broken (monthly_convert.es_MX.html) - https://phabricator.wikimedia.org/T384602#10489433 (10TomaszGorski) Hello everyone, I forgot to put the {/if} closing statement at the end of the sentence, which means I forgot to preview the... [16:55:13] 06Fundraising-Backlog, 05FY2024-25 WE3.2 Donation Entry Points: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10489745 (10KSarabia-WMF) Thank you so much, @spatton ! We appreciate it! [18:07:20] (03PS2) 10Damilare Adedoyin: Update ThankYou tests to use APIv4 send, to complete the phasing off of the thank_you_for_contribution function in the thank_you.module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113156 (https://phabricator.wikimedia.org/T270674) [18:37:21] 06Fundraising-Backlog, 05FY2024-25 WE3.2 Donation Entry Points: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10490124 (10JScherer-WMF) >>! In T383587#10486471, @spatton wrote: > Hi @KSarabia-WMF , thanks! Here's our copy; we've extensively tested the 'If Wikipedia is... [18:37:34] 06Fundraising-Backlog, 05FY2024-25 WE3.2 Donation Entry Points: Copy for the enhanced Minerva donate button - https://phabricator.wikimedia.org/T383587#10490125 (10JScherer-WMF) [21:17:28] 10fundraising-tech-ops: Issue new SSL Client Certificate for dallas - https://phabricator.wikimedia.org/T384653 (10Dwisehaupt) 03NEW [21:20:16] 10fundraising-tech-ops: Issue new SSL Client Certificate for jgreen - https://phabricator.wikimedia.org/T384654 (10Dwisehaupt) 03NEW [21:23:50] (03CR) 10Jgleeson: [C:03+2] "Thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:27:19] (03CR) 10CI reject: [V:04-1] translate epc with selected lang [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:28:20] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:28:28] thanks Jack~ [21:33:27] np! those CI errors look like we might need to update the build job [21:34:11] the @cover code completion ones should be suppressible but the deprecation warnings might need code changes [21:35:53] (03CR) 10Jgleeson: [C:03+2] "Looks great! although I can't read much of it ha!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112301 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:36:40] hahah, thanks and yeah need to log a ticket for those CI error [21:37:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: CI needs to update some test with @covers - https://phabricator.wikimedia.org/T384656 (10AnnWF) 03NEW [21:38:14] (03CR) 10CI reject: [V:04-1] translate epc with selected lang [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:38:15] (03CR) 10CI reject: [V:04-1] translate epc in uk, sv, sk [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112301 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:39:47] (03CR) 10Jgleeson: [C:03+2] translate epc in vi, zh-hans, zh-hant [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112306 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:41:30] looks like we're on the bleeding edge for the email-pref-cntr CI environment - /srv/jenkins/workspace/quibble-donationinterface-REL1_43-php82 [21:41:57] (03CR) 10CI reject: [V:04-1] translate epc with selected lang [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112299 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:41:58] (03CR) 10CI reject: [V:04-1] translate epc in uk, sv, sk [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112301 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:41:58] (03CR) 10CI reject: [V:04-1] translate epc in vi, zh-hans, zh-hant [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112306 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [21:43:53] oh interesting. that looks like it got recently updated as that's our main DI build [21:44:43] I'll also dig into that more tomorrow [21:45:18] I'll pause reviewing your patches for now wfan and pickup on that CI issue when I get back online tomorrow [21:45:43] catch you all tomorrow [21:46:00] cool thanks Jack, and here is the ticekt for his pipeline https://phabricator.wikimedia.org/T384656 good night~ [21:50:49] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgleeson - https://phabricator.wikimedia.org/T384657 (10Dwisehaupt) 03NEW [22:06:47] ls