[06:04:29] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1114182 (owner: 10L10n-bot) [07:23:28] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114287 (owner: 10L10n-bot) [09:36:47] (03PS1) 10Damilare Adedoyin: Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 [09:37:16] (03CR) 10CI reject: [V:04-1] Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 (owner: 10Damilare Adedoyin) [10:34:10] (03PS1) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [10:34:39] (03CR) 10CI reject: [V:04-1] Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) (owner: 10Damilare Adedoyin) [10:35:12] (03PS2) 10Damilare Adedoyin: Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 [10:41:20] (03PS1) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [10:41:50] (03CR) 10CI reject: [V:04-1] Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [10:43:55] (03PS2) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [10:45:26] (03PS2) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [10:45:56] (03CR) 10CI reject: [V:04-1] Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) (owner: 10Damilare Adedoyin) [10:50:26] (03PS3) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [10:56:34] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114287 (owner: 10L10n-bot) [11:00:43] (03CR) 10Jgleeson: "What's the deal with the changes to $errorParameters['normalized_response']? Should we add this change to the commit message or link it to" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 (owner: 10Damilare Adedoyin) [11:21:05] (03CR) 10Jgleeson: [C:03+2] "Thanks for this improvement!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114104 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [11:23:16] (03Merged) 10jenkins-bot: Pass no-nullable value as preg_match second param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114104 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [11:33:42] (03CR) 10Jgleeson: [C:03+2] "Thanks for the tidy-up! I considered suggesting that the $cardPaymentProvider property could be moved to the parent classes since it’s use" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114100 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [11:44:03] (03CR) 10Jgleeson: [C:03+2] "Thanks for this!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114101 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [11:51:20] (03Merged) 10jenkins-bot: tests: Declare $cardPaymentProvider property on some tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114100 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [11:51:22] (03Merged) 10jenkins-bot: tests: Use the ModuleManager to create api modules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114101 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [12:01:14] (03CR) 10Jgleeson: [C:04-1] "Thanks for this. I've suggested an alternative to improve readability." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114102 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [12:10:32] (03CR) 10Jgleeson: "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114103 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [12:30:44] (03CR) 10Jgleeson: "Good to see we got these merging! I was sniffing around and noticed we are suppressing the @covers errors already in our phpcs config via " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1112306 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [13:22:54] (03PS4) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [13:53:45] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1114182 (owner: 10L10n-bot) [14:33:17] hi fr-tech! [14:33:28] howdy ejegg ! [14:34:05] (03CR) 10Ejegg: "recheck" [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113231 (owner: 10Ejegg) [14:43:08] ejegg: we had a bunch of CI failures happening towards the end of last week due to the CI job upgrades. At first, I figured it might make sense to roll back the changes on CI to get through the patches in limbo, as the CI blockers were unrelated to the code in the patches but still blocking. Anyway, it turned out we couldn't easily roll it back due to the old jobs being deleted after the 8.2 builds were merged. It looks like [14:43:08] wfan figured out half of the issues late on Friday, which allowed us to get this chain passing on CI https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1112299/5 after earlier failures. There's a ticket tracking the CI issues here https://phabricator.wikimedia.org/T384656 which is progressing well. We've also had help from Umherirrender, who pushed up some patches over the weekend! [14:44:37] (03CR) 10Jgleeson: [C:03+2] "Oops. forgot +2 on last "thanks". Thanks again :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114103 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [14:49:00] ah jgleeson|skrun, thanks for the update [14:49:21] hopefully we can get everything switched over to MW 1.43 today or tomorrow [14:53:43] (03Merged) 10jenkins-bot: tests: Add database group when calling verifyFormOutput [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114103 (https://phabricator.wikimedia.org/T384656) (owner: 10Umherirrender) [15:22:12] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frnetmon1002, pay-lb1001, pay-lb1002 - https://phabricator.wikimedia.org/T369565#10497387 (10VRiley-WMF) [15:25:06] ah i see, it's just test changes needed. Awesome that we can keep moving forward! [15:45:01] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frnetmon1002, pay-lb1001, pay-lb1002 - https://phabricator.wikimedia.org/T369565#10497449 (10VRiley-WMF) [15:45:59] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frnetmon1002, pay-lb1001, pay-lb1002 - https://phabricator.wikimedia.org/T369565#10497468 (10VRiley-WMF) [15:50:07] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10497485 (10Damilare) a:05Damilare→03Eileenmcnaughton [15:53:18] (03PS2) 10Cstone: Create getErrorMesageText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) [15:54:57] (03PS1) 10Cstone: WIP: Add example messages to a queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114411 [15:55:32] (03CR) 10CI reject: [V:04-1] WIP: Add example messages to a queue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114411 (owner: 10Cstone) [16:01:17] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1114412 [16:01:33] im going to deploy standalone smashpig [16:03:16] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1114412 (owner: 10Cstone) [16:03:35] cool cstone [16:03:39] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1114412 (owner: 10Cstone) [16:05:20] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring queue consumer PHP notice clean up - auto rescue failure - https://phabricator.wikimedia.org/T384729#10497553 (10Cstone) →14Duplicate dup:03T382833 [16:05:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: check gateway in message recurringQueueConsumer for subscr_cancel - https://phabricator.wikimedia.org/T382833#10497555 (10Cstone) [16:07:24] !log SmashPig upgraded from 1d060a11 to 136869d3 [16:07:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:12:22] 06Fundraising-Backlog: Unusued PHPMailer was actually being used - https://phabricator.wikimedia.org/T384847 (10Cstone) 03NEW [16:12:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Trustly ACH recurring (gravy) that are cancelled on the donors end are breaking the charge job - https://phabricator.wikimedia.org/T382629#10497611 (10Cstone) [16:15:01] 06Fundraising-Backlog: placeholder name for now - https://phabricator.wikimedia.org/T384849 (10Cstone) 03NEW [16:23:03] (03CR) 10Damilare Adedoyin: "Hi cstone, thanks for the work on this. I did a quick scan and dropped a suggestion inline. I'd debug through it shortly also." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [17:14:54] (03PS2) 10Ejegg: Remove extensions not used on payments-wiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113169 (https://phabricator.wikimedia.org/T384338) [17:14:54] (03PS2) 10Ejegg: Add payments-wiki extensions as submodules [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113171 (https://phabricator.wikimedia.org/T384338) [17:15:58] (03PS4) 10Ejegg: Update composer.json and vendor for payments-wiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113231 [17:18:48] hmm, still need to upgrade the CI for mediawiki/core on fundraising branches: Your Composer dependencies require a PHP version ">= 8.2.0". You are running 7.4.33. [17:21:17] :O [17:21:40] main cluster ops is just now starting to migrade prod mediawiki servers to 8.1 ! [17:23:07] (03CR) 10CI reject: [V:04-1] Remove extensions not used on payments-wiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113169 (https://phabricator.wikimedia.org/T384338) (owner: 10Ejegg) [17:25:14] So that's just from the platform: line I guess. [17:25:19] (03CR) 10CI reject: [V:04-1] Add payments-wiki extensions as submodules [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113171 (https://phabricator.wikimedia.org/T384338) (owner: 10Ejegg) [17:25:22] We could take that out for now [17:25:54] (03CR) 10CI reject: [V:04-1] Update composer.json and vendor for payments-wiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1113231 (owner: 10Ejegg) [18:14:26] (03PS2) 10Wfan: translate epc in de, da, cs [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113235 (https://phabricator.wikimedia.org/T381336) [18:17:32] (03PS2) 10Jgleeson: WIP: Test sending recurring payments to donations queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) [18:18:59] (03PS2) 10Wfan: translate epc in ca [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113239 (https://phabricator.wikimedia.org/T381336) [18:19:25] (03CR) 10CI reject: [V:04-1] translate epc in ca [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113239 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [18:20:44] (03PS3) 10Wfan: translate epc in ca [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113239 (https://phabricator.wikimedia.org/T381336) [18:25:52] ejegg|food: mostly good news on the redirection of recurring payments => donations queue consumer. Most of the messages work apart from the case where we have a payment with no apparent recurring subscription associated. In this case, the recurring and donation queues respective consumers behave differently. I ran into this issue in the earlier incarnation of the code when I started to restructure it and documented it here: [18:25:52] https://phabricator.wikimedia.org/T240581#9353558. The related new test verifying this behaviour (and currently failing) is here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1113582/2/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/WMFQueue/RecurringDonationsQueueTest.php#313 [18:26:10] taking a short break. back later [18:26:14] aha, so that's the missing piece [18:26:22] thanks for digging back into it [18:26:28] yep! np [18:40:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10498341 (10Cstone) Coming back to this issue, @ppenloglou @krobinson to summarize the above: Emai... [18:40:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10498342 (10Cstone) a:03Cstone [18:59:02] fr-tech I've got a change up in the CiviCRM settings to resolve that missing phpmailer problem [18:59:11] ejegg: I don't know what chaos black hole I was in but i found the phab task where we were logging ips into the payment token table, do we still want to do that? [18:59:16] err, it's up for review rather [18:59:18] it was from a couple uears ago [18:59:30] i dont know if we ever did anything with it? [18:59:54] cstone sorry, is the ticket that we are logging them and shouldn't, or that we want to start logging them? [19:00:02] we are logging them [19:00:12] and do we still want to? [19:00:40] or maybe do something with them? just I never realized that data was there [19:00:44] Well, I guess if we are sure we don't need them, we can stop [19:01:07] Let's check the uses of any data we get from that table [19:01:58] in the meantime, want to take a peek at settings on frpm? I think it's the solution to https://phabricator.wikimedia.org/T384847 [19:02:48] yeah just need to switch computers [19:02:51] (the putenv syntax turned out to be a little different than the solution I suggested on the ticket) [19:08:26] ejegg: i think it makes sense in the big config instead of setting per queue consumer traps [19:08:34] looks good ejegg [19:09:40] thanks cstone [19:09:50] I'll push it up [19:13:02] !log deployed fallback SMTP settings for Fundraising CiviCRM [19:13:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:15:13] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113190 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [19:15:33] (03PS3) 10Cstone: Create getErrorMesageText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) [19:15:33] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q1:rack/setup/install frnetmon1002, pay-lb1001, pay-lb1002 - https://phabricator.wikimedia.org/T369565#10498484 (10VRiley-WMF) [19:16:06] (03CR) 10Cstone: Create getErrorMesageText and test Also fix it to handle ApprovePaymentMethod (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [19:16:24] cstone: I took a peek at that patch on friday and had some draft notes about maybe spitting out the error response handler [19:18:15] which would still give you a public interface to point your test at [19:18:18] i thought i had a ticket about doing something with the errors but now i cant find it [19:18:36] i think it was more about how it was in a bunch of different formats [19:23:26] just thinking about it now [19:23:43] the best way to make a practical suggestion and not just "let's make this a class" [19:31:28] (03Merged) 10jenkins-bot: translate epc in ru, ro, pt [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1113190 (https://phabricator.wikimedia.org/T381336) (owner: 10Wfan) [19:35:17] (03CR) 10Jgleeson: "As mentioned on IRC, I had an idea of how you might be able to have your cake and eat it :) i.e., you can get testability without opening " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [19:35:36] lemme know if that makes sense cstone ^ [19:43:52] (03CR) 10Ejegg: "This is pretty cool! The potential to lose logs does seem like a pitfall here, though. If we only want to do this on dev machines rather t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1112847 (owner: 10Eileen) [19:45:19] 06Fundraising-Backlog: Unusued PHPMailer was actually being used - https://phabricator.wikimedia.org/T384847#10498563 (10Ejegg) I went with the second option, so we don't have to worry about running into the issue again if we add new queue consumers. The putenv syntax ended up being slightly different: `lang=ph... [19:52:24] (03PS1) 10Ejegg: Remove unused phpMailer (take 2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114453 (https://phabricator.wikimedia.org/T384847) [19:52:42] cstone: ^^^ is mostly eileen's previous patch, with that deprecated 'else' bit removed [19:53:26] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Unusued PHPMailer was actually being used - https://phabricator.wikimedia.org/T384847#10498590 (10Ejegg) [19:53:41] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Replace call_user_func_array with dynamic function call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114059 (owner: 10Umherirrender) [19:58:27] oh ejegg it looks like the releng folks did revert the CI build back to 7.4 [19:58:56] I just spotted this from friday. I'd dropped off at that point https://gerrit.wikimedia.org/r/c/integration/config/+/1114025 [19:59:14] so I guess those cover errors didnt get fixed [19:59:45] I left a comment about those earlier on wfan's patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1112306/8#message-71452a1c86c5eb542e70ef9cc79d3df5f6665c1b [20:01:29] just trying to load into the meeting [20:08:14] (03CR) 10Eileen: [C:03+2] Remove unused phpMailer (take 2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114453 (https://phabricator.wikimedia.org/T384847) (owner: 10Ejegg) [20:09:18] (03Merged) 10jenkins-bot: Replace call_user_func_array with dynamic function call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114059 (owner: 10Umherirrender) [20:09:41] (03CR) 10Thiemo Kreuz (WMDE): [C:03+2] Replace call_user_func_array with dynamic function call [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1114043 (owner: 10Umherirrender) [20:24:29] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Update fr-tech documentation with Acoustic changes - https://phabricator.wikimedia.org/T379208#10498684 (10Damilare) [20:24:33] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Update fr-tech documentation with Acoustic changes - https://phabricator.wikimedia.org/T379208#10498685 (10Damilare) 05Open→03Resolved a:03Damilare [20:25:53] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), 13Patch-For-Review, 07payments-orchestration: Gravy ApplePay - https://phabricator.wikimedia.org/T367785#10498688 (10Damilare) [20:26:05] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), 13Patch-For-Review, 07payments-orchestration: Gravy ApplePay - https://phabricator.wikimedia.org/T367785#10498691 (10Damilare) 05Open→03Resolved [20:27:37] (03Merged) 10jenkins-bot: Replace call_user_func_array with dynamic function call [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1114043 (owner: 10Umherirrender) [20:28:59] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10498728 (10Damilare) [20:29:08] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10498729 (10Damilare) 05Open→03Resolved [20:32:55] (03Merged) 10jenkins-bot: Remove unused phpMailer (take 2) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114453 (https://phabricator.wikimedia.org/T384847) (owner: 10Ejegg) [20:35:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10498744 (10Damilare) [20:35:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Failmail from Silverpop over the past several days - https://phabricator.wikimedia.org/T383528#10498745 (10Damilare) 05Open→03Resolved a:03Damilare [20:35:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay - check before February 4 - https://phabricator.wikimedia.org/T383634#10498749 (10Damilare) [20:35:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Algorithm changes to server connections for Apple Pay - check before February 4 - https://phabricator.wikimedia.org/T383634#10498750 (10Damilare) 05Open→03Resolved [20:36:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14): Clear some non-us client side error log - https://phabricator.wikimedia.org/T382522#10498751 (10Damilare) [20:36:19] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.12; 2025-01-14): Clear some non-us client side error log - https://phabricator.wikimedia.org/T382522#10498752 (10Damilare) 05Open→03Resolved [20:36:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring upgrade payments missing Gravy backend processor info. - https://phabricator.wikimedia.org/T381866#10498757 (10Damilare) [20:40:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring upgrade payments missing Gravy backend processor info. - https://phabricator.wikimedia.org/T381866#10498759 (10Damilare) 05Open→03Resolved [20:44:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Transactions not found in Civi for the month of August'24 - https://phabricator.wikimedia.org/T378634#10498784 (10Cstone) @RKumar_WMF did you figure out what was going on with these? [20:45:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices, 13Patch-For-Review: Civi merge is not saving the state when a mailing address is present. - https://phabricator.wikimedia.org/T379684#10498787 (10Damilare) a:05jgleeson→03Eileenmcnaughton [20:59:35] 10fundraising-tech-ops: Fundraising access request for scampos - https://phabricator.wikimedia.org/T384873 (10Dwisehaupt) 03NEW [21:00:29] 10fundraising-tech-ops: Fundraising access request for scampos - https://phabricator.wikimedia.org/T384873#10498844 (10Dwisehaupt) [21:01:39] 10fundraising-tech-ops: Fundraising access request for scampos - https://phabricator.wikimedia.org/T384873#10498845 (10Dwisehaupt) Access approval. ` Date: Fri, 24 Jan 2025 14:35:42 From: Lisa Seitz Gruwell To: Ilse Ackerman Cc: Dallas Wisehaupt, Sara Campos Subject: Re: Superset access ------------------------... [21:14:05] hi all - am working for a few hours today but didn't prioritise the meeting - just checking up what has been happening [21:25:04] 06Fundraising-Backlog: Automatic merging of organization records with same name - is a problem - https://phabricator.wikimedia.org/T384748#10498906 (10jgleeson) [21:25:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Automatic merging of organization records with same name - is a problem - https://phabricator.wikimedia.org/T384748#10498911 (10Damilare) [21:35:53] if anyone is able to check it I just pushed in the change to switch from calling drush to civi api for matching gifts job [21:35:53] Also - I think we need to do the same for the thank you jobs damilare [21:40:54] (03PS1) 10Eileen: Remove matching gifts drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114462 (https://phabricator.wikimedia.org/T270677) [21:40:56] (03PS1) 10Eileen: Remove resettle drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114463 (https://phabricator.wikimedia.org/T270677) [21:47:57] ejegg: the last 2 things in wmf_civicrm are the delete_deleted_contacts & contact_merge drush wrappers - they basically track the progress of the jobs. What are your thoughts on moving them to co-worker - we already have that wrapper to allow it to requeue the next job when done. The down side is that turning on & off is less familiar but we are at the start of the year so we have time to work through that [22:00:22] (03CR) 10Jgleeson: [C:03+2] Remove matching gifts drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114462 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [22:01:51] jgleeson: thanks for that - do you want to double check the corresponding process control change before I push it out? [22:02:08] just testing it locally now [22:04:15] so the command runs but it fails due to the licence key [22:04:24] which I guess is to be expected locally? [22:09:00] it's pretty low risk that command, we just essentially wrap something that movies csv's around so it should be fine [22:09:05] moves* [22:09:13] lgtm eileen [22:09:22] thanks! [22:10:20] !log config revision changed from 1c401675 to 5508ba83 [22:14:03] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1114465 [22:14:09] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1114465 (owner: 10Ejegg) [22:23:16] (03PS2) 10Jgleeson: Standardise on createPayment/approvePayment over a mix of create/authorize/approve/capture. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1109709 (https://phabricator.wikimedia.org/T383404) [22:23:18] (03CR) 10Ejegg: [C:03+2] Standardise on createPayment/approvePayment over a mix of create/authorize/approve/capture. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1109709 (https://phabricator.wikimedia.org/T383404) (owner: 10Jgleeson) [22:23:27] ty ejegg [22:25:17] (03Merged) 10jenkins-bot: Standardise on createPayment/approvePayment over a mix of create/authorize/approve/capture. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1109709 (https://phabricator.wikimedia.org/T383404) (owner: 10Jgleeson) [22:25:39] :) [22:26:02] I'll make a ticket tomorrow to port that to Adyen for consistency [22:26:29] eileen: do you mind if I tidy up some of those nested if statements in the matching gifts code? [22:26:42] jgleeson: go for it! [22:27:02] when reviewing that chain I wish I'd of flattened a few of those out way back when [22:27:09] have* [22:28:11] (03Merged) 10jenkins-bot: Remove matching gifts drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114462 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [22:28:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1114465 (owner: 10Ejegg) [22:54:04] !log fundraising civicrm upgraded from f82f7c98 to 12a02d52 [22:54:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:54:22] ok, let's keep an eye on the recurring qc [23:04:42] heading next door for a bit but i'll be watching for failmail [23:05:59] (03PS3) 10Jgleeson: WIP: Test sending recurring payments to donations queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) [23:05:59] (03PS1) 10Jgleeson: Reduce if/else nesting and mental load in matching gifts fn. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114472 (https://phabricator.wikimedia.org/T270677) [23:06:21] hmm lemme split those [23:06:29] (03PS2) 10Jgleeson: Reduce if/else nesting and mental load in matching gifts fn. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114472 (https://phabricator.wikimedia.org/T270677) [23:08:12] eileen: I'll add a test to that tomorrow. getting sleepy now [23:08:19] bye for now [23:12:28] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dbautista - https://phabricator.wikimedia.org/T384670#10499199 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms.