[00:27:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10499296 (10MBeat33) 227750668.1 reached Civi, thank you. @Damilare re "This wasn't automatically imported because of the... [00:28:32] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10499297 (10Eileenmcnaughton) 05Open→03Resolved [00:28:35] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10FR-donorservices: Activity field failing - https://phabricator.wikimedia.org/T383174#10499298 (10Eileenmcnaughton) [00:42:26] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ehughes - https://phabricator.wikimedia.org/T384887 (10Dwisehaupt) 03NEW [00:42:27] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ejohnston - https://phabricator.wikimedia.org/T384888 (10Dwisehaupt) 03NEW [00:42:29] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T384889 (10Dwisehaupt) 03NEW [00:42:30] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewhite - https://phabricator.wikimedia.org/T384890 (10Dwisehaupt) 03NEW [01:00:42] (03PS1) 10Eileen: Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) [01:28:47] (03CR) 10CI reject: [V:04-1] Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [01:57:27] (03PS4) 10Cstone: Create getErrorText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) [02:38:11] (03PS2) 10Eileen: Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) [05:57:21] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1114537 (owner: 10L10n-bot) [09:55:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Email, 13Patch-For-Review, and 2 others: FundraisingEmailUnsubscribe doesn't pass tests in PHP 8.1 - https://phabricator.wikimedia.org/T357593#10499811 (10jijiki) @greg as we are moving forward with the PHP8.1 rollout, shall we treat this as a b... [10:18:44] 03Fundraising Sprint: Abula, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.14; 2025-01-28), 13Patch-For-Review: Standardise on createPayment/approvePayment over a mix of create/authorize/approve/capture. - https://phabricator.wikimedia.org/T383404#10499898 (10jgleeson) a:03jgleeson [10:25:46] (03CR) 10Jgleeson: "This looks great! I'll remove that commented line and then we can +2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [10:34:33] (03PS5) 10Jgleeson: Create getErrorText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [10:55:33] (03Abandoned) 10Jgleeson: Add test to confirm 'Expected to find one Contact record, but there were zero' bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1101869 (https://phabricator.wikimedia.org/T381633) (owner: 10Jgleeson) [10:55:54] (03CR) 10Jgleeson: [C:03+2] Remove resettle drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114463 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [10:58:23] (03CR) 10Jgleeson: [C:03+2] "thanks for the updates!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113156 (https://phabricator.wikimedia.org/T270674) (owner: 10Damilare Adedoyin) [11:00:46] (03CR) 10Jgleeson: [C:03+2] Create getErrorText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [11:01:02] (03PS1) 10Jgleeson: Add small guard clause to getErrorText() to handle broken input. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114677 (https://phabricator.wikimedia.org/T382629) [11:24:18] (03Merged) 10jenkins-bot: Remove resettle drush command [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114463 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [11:24:20] (03Merged) 10jenkins-bot: Update ThankYou tests to use APIv4 send, to complete the phasing off of the thank_you_for_contribution function in the thank_you.module [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113156 (https://phabricator.wikimedia.org/T270674) (owner: 10Damilare Adedoyin) [11:24:22] (03Merged) 10jenkins-bot: Create getErrorText and test Also fix it to handle ApprovePaymentMethod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113602 (https://phabricator.wikimedia.org/T382629) (owner: 10Cstone) [11:38:24] (03PS1) 10Jgleeson: Standardise on createPayment/approvePayment in Adyen code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114686 (https://phabricator.wikimedia.org/T383404) [11:45:25] (03PS2) 10Jgleeson: Standardise on createPayment/approvePayment in Adyen payment code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114686 (https://phabricator.wikimedia.org/T383404) [11:45:25] (03PS1) 10Jgleeson: Standardise on createPayment/approvePayment in Adyen fraud filter code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114688 (https://phabricator.wikimedia.org/T383404) [11:51:33] (03PS1) 10Jgleeson: Standardise on createPayment/approvePayment in Gravy fraud filter code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1114690 (https://phabricator.wikimedia.org/T383404) [12:49:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10500382 (10krobinson) I think we should go with more recent, especially now we have the country s... [13:52:26] (03PS3) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [14:03:05] (03PS3) 10Damilare Adedoyin: Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 [14:17:19] (03PS4) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [14:17:23] (03PS5) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [14:18:23] (03CR) 10CI reject: [V:04-1] Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) (owner: 10Damilare Adedoyin) [14:18:26] (03PS6) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [14:19:25] (03CR) 10Jgleeson: [C:03+2] Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 (owner: 10Damilare Adedoyin) [14:19:56] (03Merged) 10jenkins-bot: Make camel case consistent in ResponseMapper [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114338 (owner: 10Damilare Adedoyin) [14:21:02] (03PS1) 10Jgleeson: WIP: Add to coverage for VerifyEmployerFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114737 [15:08:46] (03CR) 10Jgleeson: [C:04-1] "Thanks, Dami. I've left a suggestion inline about breaking the larger mapping method into smaller, more focused methods." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [15:51:28] (03PS5) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [15:53:18] (03CR) 10CI reject: [V:04-1] Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [15:58:23] (03PS6) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [16:11:40] (03CR) 10Damilare Adedoyin: "thanks jgleeson for the CR, I've made the change and added my thoughts inline as to why this monolith (in this scenario) might not exactly" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [16:30:43] (03PS7) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [17:17:59] (03CR) 10Cstone: [C:03+2] "thanks for the improvements, looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114677 (https://phabricator.wikimedia.org/T382629) (owner: 10Jgleeson) [17:18:09] thanks cstone ! [17:39:47] (03Merged) 10jenkins-bot: Add small guard clause to getErrorText() to handle broken input. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114677 (https://phabricator.wikimedia.org/T382629) (owner: 10Jgleeson) [17:40:05] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07Transaction-missing-in-CiviCRM: Adyen audit files + missing manual settles Dec 2024 - https://phabricator.wikimedia.org/T382498#10501521 (10MBeat33) Jake at Adyen said that the best way to pick up when new PaymentMethod variants are added is to receiv... [17:40:35] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10donate.wikimedia.org: Suppress opt in when contact hash in the url? - https://phabricator.wikimedia.org/T383189#10501522 (10Pcoombe) I emailed Aeryn for some Legal input [18:00:36] (03CR) 10Jgleeson: "Thanks, Dami, for the updates. Looking good! I responded inline with a more detailed explanation behind the previous review points. Also, " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [18:07:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Email, 13Patch-For-Review, and 2 others: FundraisingEmailUnsubscribe doesn't pass tests in PHP 8.1 - https://phabricator.wikimedia.org/T357593#10501626 (10greg) p:05Low→03High Thanks for the prod. Let me sync with the team on this. I'm at an... [18:16:11] ejegg: I'm misunderstanding how the guzzle mock stuff works in your older matching gifts sync code. Does this test make sense to you? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1114737/1/drupal/sites/default/civicrm/extensions/matching-gifts/tests/phpunit/Civi/Api4/MatchingGift/VerifyEmployerFileTest.php#87 It's failing so it's wrong, but I think it's due to my assumptions about how the API will be hit. [18:16:12] Does anything obvious stand out? [18:17:01] sorry jgleeson, baby woke up and is really noisy where she got her shots, back in a bit [18:17:12] ah np [18:17:24] sorry to hear :( [18:30:16] derp, i meant hurting where she got her shots. noise is coming out the usual end [18:41:13] ok, now diving into that test code [18:43:05] I'm digging into the guzzle client to see if the requests I'm assuming are being made, are actually being made. I think that's the issue [18:53:55] back later [18:55:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Email, 13Patch-For-Review, and 2 others: FundraisingEmailUnsubscribe doesn't pass tests in PHP 8.1 - https://phabricator.wikimedia.org/T357593#10501780 (10Ejegg) We've upgraded the payments cluster to bookworm and php 8.2. The unsubscribe page ha... [19:09:10] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T384889#10501806 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [19:09:28] thanks ejegg for that comment re php8.1 [19:14:21] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewhite - https://phabricator.wikimedia.org/T384890#10501826 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [19:32:18] (03PS7) 10Damilare Adedoyin: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 [19:48:25] 06Fundraising-Backlog, 10fundraising-tech-ops, 06Fundraising-Tech-Roadmap: FR-Tech FY2425Q3 maintenance window - https://phabricator.wikimedia.org/T337584#10502011 (10Dwisehaupt) [19:50:05] (03CR) 10Damilare Adedoyin: "Thanks jgleeson, sorry I missed the part where you suggested renaming the function. I've renamed the two new functions, let me know what y" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [19:55:24] 06Fundraising-Backlog, 07payments-orchestration: Gravy Dlocal connection implementation - https://phabricator.wikimedia.org/T384967#10502040 (10Damilare) [20:27:21] I dropped out - what I would say is this issue is downstream of various other discussions [21:04:56] wfan: what do you think about making a drop-in replacement for the old unsubscribe page, that just uses exactly the same parameters (and which we can wire in to the same URL) [21:05:47] So not url redirect. Hmm sounds better! [21:06:00] https://payments.wikimedia.org/index.php/Special:FundraiserUnsubscribe?p=thankyou&c=&e=&h=&uselang=en [21:07:13] I'm leaning that way because I really want to delete the old extension [21:07:30] it's got a legacy twig version and doesn't pass php 8.x tests [21:08:07] so if we just port the same functionality we don't need legal or design input [21:08:48] i'mma see if I can just get the template to render under the email prefs page [21:08:56] and set it up as an alias [21:09:43] Sure, we can keep the current epc design without opt-in and snooze. [22:16:38] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the updates Dami and the discussion! This looks great." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [22:16:54] (03PS8) 10Damilare Adedoyin: Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) [22:17:06] (03Merged) 10jenkins-bot: Move payment response normalization to own function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114345 (owner: 10Damilare Adedoyin) [22:17:20] (03CR) 10CI reject: [V:04-1] Create chargeback on failed Trustly ACH payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1114343 (https://phabricator.wikimedia.org/T384593) (owner: 10Damilare Adedoyin) [22:31:47] elliott, you mean we will use this link https://payments.wikimedia.org/index.php/Special:FundraiserUnsubscribe?p=thankyou&c=&e=&h=&uselang=en with the epc template, so instead of check checksum, still check the hash? [22:37:26] yes wfan, the hash that is just calculated on the payments side [22:37:43] with the same logic from the fundraiserunsubscribe extension [22:40:30] if so, ty unsubscribe link will remain the same, then should email team still update the link name to 'manage your email preferences'? [23:07:35] wfan: hmm maybe the new links can go to the new page, and the 'legacy unsubscribe' form will just handle people clicking from old links? [23:42:51] (03PS2) 10Jgleeson: Add to test coverage for VerifyEmployerFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114737 [23:48:37] (03PS3) 10Jgleeson: Add to test coverage for VerifyEmployerFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114737 (https://phabricator.wikimedia.org/T270677) [23:48:39] (03PS3) 10Jgleeson: Reduce if/else nesting and in verifyEmployerFile API action. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114472 (https://phabricator.wikimedia.org/T270677) [23:51:23] (03PS4) 10Jgleeson: Add to test coverage for VerifyEmployerFile [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114737 (https://phabricator.wikimedia.org/T270677) [23:51:23] (03PS4) 10Jgleeson: Reduce if/else nesting and in verifyEmployerFile API action. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114472 (https://phabricator.wikimedia.org/T270677) [23:55:12] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-donorservices: Donors included wrongly in email send due to "country". - https://phabricator.wikimedia.org/T381437#10502664 (10Cstone) @ppenloglou Is there a reason why you went to hardcoding country vs hardcoding...