[00:01:21] 14Fundraising Sprint: didAnyoneTryThis(), 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Create new Benevity import - https://phabricator.wikimedia.org/T359219#10561901 (10AKanji-WMF) [00:01:38] (03Merged) 10jenkins-bot: tests: Add missing covers annotations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1119857 (https://phabricator.wikimedia.org/T385539) (owner: 10Umherirrender) [00:09:19] 03Fundraising Sprint: Churros, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257#10561922 (10Eileenmcnaughton) [00:09:48] 03Fundraising Sprint: Churros, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257#10561924 (10Eileenmcnaughton) Bringing this in due... [00:54:46] (03PS6) 10Wfan: Update thank you unsubscribe url to epc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1115952 (https://phabricator.wikimedia.org/T359445) [02:29:45] (03PS5) 10Wfan: Add opt-in unsubscribe and a general email perference center activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1118864 (https://phabricator.wikimedia.org/T384412) [02:33:04] (03CR) 10Eileen: [C:03+2] "Looks good - one minor thing to think about - apparently best practice is to use the domain example.org for all emails in tests to avoid a" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1118864 (https://phabricator.wikimedia.org/T384412) (owner: 10Wfan) [02:44:34] (03PS2) 10Ejegg: Add new zip codes for 2025 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) [02:46:16] (03PS1) 10Wfan: Update epc link to the one with hash fallback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120693 (https://phabricator.wikimedia.org/T386771) [02:47:14] (03CR) 10CI reject: [V:04-1] Update epc link to the one with hash fallback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120693 (https://phabricator.wikimedia.org/T386771) (owner: 10Wfan) [02:47:22] (03CR) 10CI reject: [V:04-1] Add new zip codes for 2025 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) (owner: 10Ejegg) [02:54:36] (03PS2) 10Wfan: Update epc link to the one with hash fallback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120693 (https://phabricator.wikimedia.org/T386771) [02:59:35] (03PS3) 10Eileen: Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) [02:59:35] (03PS1) 10Eileen: Monolog updates - adds support for test processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120694 [02:59:35] (03PS1) 10Eileen: Add test env Logger & add to one test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 [02:59:36] (03PS1) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [02:59:37] (03PS1) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [03:00:20] (03PS6) 10Wfan: Add opt-in unsubscribe and a general email perference center activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1118864 (https://phabricator.wikimedia.org/T384412) [03:03:58] 14Fundraising Sprint: Abula, 03Fundraising Sprint: Churros, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 13Patch-For-Review: Add comms preferences footer to all Civi-generated emails - https://phabricator.wikimedia.org/T359445#10562143 (10AnnWF) [03:06:35] (03PS2) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [03:07:13] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1118864 (https://phabricator.wikimedia.org/T384412) (owner: 10Wfan) [03:07:56] OK - so I have a job that will find deleted contacts with recurrings & let us know, using the new monolog->failmail approach - in that chain above [03:24:28] (03CR) 10Eileen: [C:03+2] Fix UTC0 -> UTC+0, spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120664 (owner: 10Ejegg) [03:25:09] (03CR) 10CI reject: [V:04-1] Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [03:27:08] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [03:30:48] (03Merged) 10jenkins-bot: Add opt-in unsubscribe and a general email perference center activity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1118864 (https://phabricator.wikimedia.org/T384412) (owner: 10Wfan) [03:31:08] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [03:40:42] (03PS2) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [03:40:43] (03PS3) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [03:40:43] (03PS3) 10Ejegg: Add new zip codes for 2025 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) [03:43:40] (03PS2) 10Eileen: Add test env Logger & add to one test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 [03:43:40] (03PS3) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [03:43:41] (03PS4) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [03:50:03] (03Merged) 10jenkins-bot: Fix UTC0 -> UTC+0, spacing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120664 (owner: 10Ejegg) [03:53:14] eileen: ah just saw that. I will check those delete deleted job related patches tomorrow thanks a lot! [03:53:20] Have a good night [03:53:25] night [03:58:19] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [03:59:06] (03CR) 10CI reject: [V:04-1] Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [04:00:46] (03PS4) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [04:00:46] (03PS5) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [04:09:01] (03CR) 10CI reject: [V:04-1] Add test env Logger & add to one test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 (owner: 10Eileen) [04:26:41] (03CR) 10CI reject: [V:04-1] Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [04:27:17] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [04:38:05] (03PS3) 10Eileen: Add test env Logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 [04:38:05] (03PS5) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [04:38:05] (03PS6) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [04:38:05] (03PS1) 10Eileen: Remove transitional managed hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120703 [04:42:17] (03PS1) 10Eileen: Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 [05:04:03] (03CR) 10CI reject: [V:04-1] Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [05:04:04] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [05:09:22] (03CR) 10CI reject: [V:04-1] Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 (owner: 10Eileen) [05:20:06] (03PS6) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [05:20:06] (03PS7) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [05:20:06] (03PS2) 10Eileen: Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 [05:44:40] (03CR) 10CI reject: [V:04-1] Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 (owner: 10Eileen) [05:46:06] (03CR) 10CI reject: [V:04-1] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [06:48:39] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1120740 (owner: 10L10n-bot) [07:36:34] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_43) - 10https://gerrit.wikimedia.org/r/1120325 (owner: 10L10n-bot) [07:38:48] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1120740 (owner: 10L10n-bot) [10:08:25] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-direct-mail: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#10562740 (10RLewis) Hi Eileen, Thanks for the ping on this, Megan and I are meeting today to go over some of this and will update the task. Rosie... [11:17:15] 06Fundraising-Backlog: External identifier - multiple trx - the ability to differentiate between donations to cancel the correct one. - https://phabricator.wikimedia.org/T386800 (10RKumar_WMF) 03NEW [13:07:26] 14Fundraising Sprint: Abula, 03Fundraising Sprint: Churros, 06Fundraising-Backlog, 10FR-Smashpig, 10FR-WMF-Audit: Handle PayPal recurring charges that don't include a subscription ID - https://phabricator.wikimedia.org/T385801#10563230 (10Damilare) a:03Damilare [13:21:54] (03CR) 10Damilare Adedoyin: "Hi ejegg, thanks for working on this. Please can you add test instructions to this patch, I seem to have lost the command for db upgrades." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) (owner: 10Ejegg) [13:23:15] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T386420#10563289 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [13:26:53] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rkumar - https://phabricator.wikimedia.org/T385926#10563327 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [13:51:06] damilare: I noticed you picked up the paypal ticket. When I added that, I linked to an earlier patch I'd pushed up with a new test suite that looks like it was passing so it might have broken due to the CI updates. I'll take a peek https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1113582 [13:51:45] (03CR) 10Jgleeson: [V:03+2 C:03+2] Fixes for payments-smashpig-checkout-patch [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1119730 (owner: 10Jgleeson) [14:04:22] yh jgleeson, thanks! [14:05:18] wb! [14:06:15] ty! [14:14:41] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [Trino] Trino Python Client - https://phabricator.wikimedia.org/T386269#10563524 (10Jgreen) [14:15:11] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [Trino] Trino Python Client - https://phabricator.wikimedia.org/T386269#10563525 (10Jgreen) [14:15:17] 03Fundraising Sprint: Churros, 06Fundraising-Backlog: Should we switch YAML spacing to 2 spaces? - https://phabricator.wikimedia.org/T385026#10563528 (10Ejegg) a:03Ejegg [14:15:25] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [Trino] Trino Python Client - https://phabricator.wikimedia.org/T386269#10563533 (10Jgreen) p:05Triage→03Medium [14:17:36] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [Trino] Trino Python Client - https://phabricator.wikimedia.org/T386269#10563541 (10Jgreen) New virtualbox venv with jupyter notebooks and trino client prototyped in virtualbox, starts up normally with systemd. Next step is to attempt an ins... [14:43:40] (03PS1) 10Ejegg: Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) [14:44:05] (03CR) 10CI reject: [V:04-1] Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [14:49:33] (03PS1) 10Ejegg: Change YAML to two spaces [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1120981 (https://phabricator.wikimedia.org/T385026) [14:51:49] (03CR) 10CI reject: [V:04-1] Change YAML to two spaces [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1120981 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [14:55:57] (03PS1) 10Ejegg: Change YAML to two spaces [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1120985 (https://phabricator.wikimedia.org/T385026) [15:04:09] (03PS2) 10Ejegg: Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) [15:04:34] (03CR) 10CI reject: [V:04-1] Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [15:08:10] ugh, phpstorm search-n-replace craps out after 90 lines when doing across files sometimes???? [15:08:17] lame [15:08:23] o-o [15:08:48] (03PS3) 10Ejegg: Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) [15:09:21] (03CR) 10CI reject: [V:04-1] Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [15:19:11] (03PS4) 10Ejegg: Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) [15:22:03] ok, looks like the config and config-private patches were good [15:32:57] extra thorough updating the indents of the commented out bits ejegg ;) [15:33:30] (03CR) 10Jgleeson: [C:03+2] "Thanks for this!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [15:33:49] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1120985 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [15:34:14] CI gods don't like the DI patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1120981 [15:34:25] (03Merged) 10jenkins-bot: Change YAML to two spaces [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1120975 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [15:35:02] yeah jgleeson it's the search-n-replace crapout [15:35:11] I'm going over the long files & fixing now [15:36:16] (03PS2) 10Ejegg: Change YAML to two spaces [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1120981 (https://phabricator.wikimedia.org/T385026) [15:38:04] ok, that should be right [15:41:38] (03PS4) 10Eileen: Upstream updates to contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119599 [15:41:44] (03CR) 10Ejegg: [C:03+2] Upstream updates to contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119599 (owner: 10Eileen) [15:42:23] (03PS2) 10Eileen: Fix move-deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120678 [15:43:40] (03CR) 10Ejegg: [C:03+2] Fix move-deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120678 (owner: 10Eileen) [15:44:14] (03PS3) 10Eileen: Code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119600 [15:44:19] (03CR) 10Ejegg: [C:03+2] Code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119600 (owner: 10Eileen) [15:54:22] (03PS4) 10Eileen: Code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119600 [15:54:26] PROBLEM - Host frav1003 is DOWN: PING CRITICAL - Packet loss = 100% [15:54:27] (03CR) 10Ejegg: [V:03+2 C:03+2] Code comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119600 (owner: 10Eileen) [15:55:31] (03PS4) 10Eileen: Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) [15:58:16] RECOVERY - Host frav1003 is UP: PING OK - Packet loss = 0%, RTA = 0.48 ms [16:00:14] (03CR) 10Ejegg: "Code looks good, just some copied comments could be updated" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [16:03:52] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ayounsi - https://phabricator.wikimedia.org/T386037#10564148 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [16:05:36] 06Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: [Trino] Trino Python Client - https://phabricator.wikimedia.org/T386269#10564156 (10Jgreen) 05Open→03Resolved a:03Jgreen [16:08:06] (03Merged) 10jenkins-bot: Upstream updates to contact layout editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1119599 (owner: 10Eileen) [16:11:08] ejegg: you will like this one [16:11:24] I ran yamllint on that DI patch - here's the output https://phabricator.wikimedia.org/P73490 [16:11:44] this one caught my eye https://phabricator.wikimedia.org/P73490$169 [16:11:53] " 157:5 warning truthy value should be one of [false, true] (truthy)" [16:12:25] and it relates to this line (which you didn't add) https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1120981/2/gravy_gateway/config/payment_submethods.yaml#157 [16:12:30] (03Merged) 10jenkins-bot: Fix move-deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120678 (owner: 10Eileen) [16:12:32] huh, let's see [16:12:43] so apparently, the string NO in yaml is interpreted as a bool! [16:12:44] arrrgh [16:12:53] right, that actually bit us someplace [16:12:57] we need to quote that [16:13:19] yep [16:13:24] I read that here https://noyaml.com/ [16:13:27] line 30 [16:14:06] lol: is marginally better than windows.ini [16:14:21] lol yes that page is a good laugh [16:15:26] (03CR) 10Jforrester: [C:03+2] Remove @phan-suppress to fix CI [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120571 (owner: 10Esanders) [16:15:46] jgleeson: perhaps one for tech talk but it seems setting the subscr_id in this test (testRecurringPaymentPaypalMissingPredecessor) doesn't trigger the expected exception. [16:15:54] (03CR) 10Jforrester: [C:03+2] ESLint: Use server config for server files [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120533 (owner: 10Esanders) [16:16:02] on this patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1113582 [16:16:53] yep damilare. check the comment in markTestIncomplete() on that one [16:17:19] that test was the catalyst for the ticket r [16:17:22] -r [16:17:35] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1113582/4/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/WMFQueue/PayPalRecurringDonationsQueueTest.php#312 [16:17:55] yh but it isn't throwing the exception you're expecting at the moemnt [16:18:15] ohh [16:19:04] yep. we need to implement the code to make that test pass. it's effectively a TDD test [16:19:55] do we expect it to throw an exception when the subscr_id is present? [16:19:59] that discrepancy came up with comparing how the same flow is handled by the recurring queue consumer, which does throw the expected exception, [16:20:30] I wrote up the cause on an old post here https://phabricator.wikimedia.org/T240581#9353558 [16:20:31] oh I see, I'd checkout that flow then [16:21:16] however the code has changed since that was written, but I think it's still useful for context as it describes the underlying issue that still needs resolving [16:21:20] ok, I should do the yaml fixes up in config [16:21:24] on prod [16:21:43] I guess I was expecting it to fail on a missing subscr_id given the title of the test [16:21:49] thanks for the context [16:22:44] Especially on this comment here: * TODO: This test is failing because the subscription is not being created. [16:27:48] yeah damilare that comment is accurate, I think. If I recall correctly, In the RQC we create the subscription as part of the import if the subscr_id is set but not set up however for the DQC we ignore it, or at least don't create it, so the test isn't failing (or throwing the exception) due to trying to import an orphaned donation [16:28:10] when it should [16:28:18] ok fr-tech, I'm updating the prod yaml in a couple different patches [16:28:43] ejegg: did you wanna update the NO line as part of the DI patch ? [16:28:56] I just pushed one with the process-control yaml to the repo, but it's not deployed [16:29:03] oh sure jgleeson, lemme do thatt now [16:29:09] I can +2 that [16:29:11] then [16:29:14] just to confirm terminologies jgleeson, subscription as used here means our contribution recur row right? [16:29:40] jgleeson: ahh there are a couple more, let me make a follow-on patch for that [16:29:51] damilare: check out this comment https://github.com/wikimedia/wikimedia-fundraising-crm/blob/b55f00505c780512e4ad88211a2d3b0e248b0ad2/drupal/sites/all/modules/wmf_civicrm/wmf_civicrm.module#L254 [16:30:08] that's what we need to do I think - or decide how to accommodate [16:30:54] and this is where the expected exception is thrown https://github.com/wikimedia/wikimedia-fundraising-crm/blob/cdfadb2e8c672ce61a26c64580bf796cd7ad9a5a/drupal/sites/all/modules/queue2civicrm/recurring/RecurringQueueConsumer.php#L200 [16:32:14] (03PS1) 10Ejegg: Quote 'NO' in YAML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1121045 [16:32:57] jgleeson: there are the NO fixes ^^^ [16:33:02] lookin [16:33:13] (03CR) 10Jgleeson: [C:03+2] Change YAML to two spaces [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1120981 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [16:33:34] gonna check to see if SmashPig mentions Norway at all [16:33:51] man norway has it rough with config :P [16:33:59] ha [16:33:59] lol [16:34:24] that's a no... [16:34:39] yh I'm just stepping through that bit of the code to confirm the discrepancy [16:34:45] (as in, no mentions of NO in the SmashPig yaml) [16:35:41] (03CR) 10Jgleeson: [C:03+2] "'NO' issues here" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1121045 (owner: 10Ejegg) [16:39:56] 03Fundraising Sprint: Churros, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review, 07Unplanned-Sprint-Work: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257#10564328 (10Ejegg) a:03Eile... [16:46:51] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10564356 (10Cstone) @EMartin @Pcoombe what is the url you were using? This is one that just got me to the trustly pick the bank UI: https://payments.wikimedia.org/index.php?title=Special:GravyGateway&... [16:47:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Unknown Gravy Payment Method - dd - https://phabricator.wikimedia.org/T386531#10564359 (10Cstone) This was due to Peter and Evelyn testing with wrong link parameters [16:48:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Unknown Gravy Payment Method - dd - https://phabricator.wikimedia.org/T386531#10564365 (10Cstone) {T386502} Forgot to link [16:49:21] (03CR) 10Cstone: [C:04-2] "The error was from testing with a bad link, we don't need to change this" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119781 (https://phabricator.wikimedia.org/T386531) (owner: 10Wfan) [16:53:11] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sdaniels - https://phabricator.wikimedia.org/T386053#10564386 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [16:53:38] 10fundraising-tech-ops: Fundraising access request for astein - https://phabricator.wikimedia.org/T386746#10564394 (10Dwisehaupt) SSL client certificate created and sent via email. Password sent via SMS. CiviCRM account created and set with random password. Superset account created and set with random password.... [17:00:26] 06Fundraising-Backlog, 10FR-email-preferences: Email Preference Center - handle email addresses with plus signs - https://phabricator.wikimedia.org/T386847 (10Cstone) 03NEW [17:07:41] 14Fundraising Sprint: Abula, 03Fundraising Sprint: Churros, 06Fundraising-Backlog: Duplicates after import - https://phabricator.wikimedia.org/T382516#10564461 (10BJordan-WMF) @MDemosWMF I do believe this is still a presenting issue. I have been splitting large batches into two parts to avoid deadlocks, but... [17:10:01] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10564484 (10Pcoombe) This is the form I was using https://payments.wikimedia.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote&country=US¤cy=USD&payment_method=dd&recurring=0&gateway=grav... [17:12:12] (03CR) 10Jforrester: [C:03+2] ESLint: Update to ES6 and autofix [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120567 (owner: 10Esanders) [17:12:44] (03Abandoned) 10Wfan: Gravy dd is using trustly [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119781 (https://phabricator.wikimedia.org/T386531) (owner: 10Wfan) [17:12:55] (03CR) 10Jforrester: [C:03+2] ESLint: Manually fix prefer-const violations [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120568 (owner: 10Esanders) [17:21:53] (03PS3) 10Wfan: Update epc link to the one with hash fallback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120693 (https://phabricator.wikimedia.org/T386771) [17:22:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: External identifier - multiple trx - the ability to differentiate between donations to cancel the correct one. - https://phabricator.wikimedia.org/T386800#10564593 (10Damilare) [17:22:39] (03PS7) 10Wfan: Update thank you unsubscribe url to epc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1115952 (https://phabricator.wikimedia.org/T359445) [17:24:13] 06Fundraising-Backlog, 10FR-email-preferences: Email Preference Center - handle email addresses with plus signs - https://phabricator.wikimedia.org/T386847#10564612 (10Cstone) 05Open→03Declined already handled [17:24:55] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact received 2 Adyen donations AFTER being deleted (most recent 18 Feb 25) - https://phabricator.wikimedia.org/T386770#10564618 (10Damilare) [17:25:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Civi recur failure message emails not consistently deploying - https://phabricator.wikimedia.org/T386733#10564627 (10Damilare) [17:26:29] 06Fundraising-Backlog, 10FR-email-preferences: Email Preference Center - handle email addresses with plus signs - https://phabricator.wikimedia.org/T386847#10564630 (10AnnWF) handled by https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1115952/5..6 [17:26:59] 10fundraising-tech-ops, 10BDC-Implementation: Survey Monkey load data into platform - https://phabricator.wikimedia.org/T385743#10564631 (10Jgreen) [17:27:29] 10fundraising-tech-ops, 10BDC-Implementation: Survey Monkey load data into platform - https://phabricator.wikimedia.org/T385743#10564634 (10Jgreen) a:05Jgreen→03None [17:28:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Unknown Gravy Payment Method - dd - https://phabricator.wikimedia.org/T386531#10564643 (10Damilare) 05Open→03Declined [17:29:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: CLP amounts to adyen are missing the conversion to cents - https://phabricator.wikimedia.org/T386526#10564648 (10Damilare) [17:29:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: CLP amounts to adyen are missing the conversion to cents - https://phabricator.wikimedia.org/T386526#10564649 (10Damilare) p:05Triage→03High [17:31:35] fr-tech it's because of this line: https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/Core/Helpers/CurrencyRoundingHelper.php$13 [17:32:41] (03CR) 10Wfan: Set failmail on alert (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [17:32:43] that's consulted in getAmountInMinorUnits [17:36:14] 10fundraising-tech-ops, 10BDC-Implementation: Survey Monkey load data into platform - https://phabricator.wikimedia.org/T385743#10564689 (10Jgreen) [17:41:21] (03CR) 10Wfan: "Thanks, works on my local, only one small thought, could we add a todo to make sure we know only recur now but will add one time in the fu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [17:42:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: CLP amounts to adyen are missing the conversion to cents - https://phabricator.wikimedia.org/T386526#10564728 (10Ejegg) We've got CLP on the list of 'NoDecimalCurrencies' along with JPY here: https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/... [17:44:27] (03CR) 10Wfan: [C:03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [17:44:56] (03CR) 10Wfan: [C:03+2] Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [17:51:41] (03Merged) 10jenkins-bot: Remove @phan-suppress to fix CI [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120571 (owner: 10Esanders) [17:51:42] (03Merged) 10jenkins-bot: ESLint: Use server config for server files [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120533 (owner: 10Esanders) [17:58:52] (03Merged) 10jenkins-bot: Change YAML to two spaces [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1120981 (https://phabricator.wikimedia.org/T385026) (owner: 10Ejegg) [17:58:53] (03Merged) 10jenkins-bot: Quote 'NO' in YAML [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1121045 (owner: 10Ejegg) [18:03:15] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10564872 (10EMartin) @Cstone @Pcoombe I retried and am still getting the error in the US. {F58425881} [18:04:56] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10564877 (10Cstone) @Pcoombe for the submethod=ach it should be payment_submethod=ach [18:05:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Backfill recurring payments missing Gravy backend processor info. - https://phabricator.wikimedia.org/T385115#10564880 (10jgleeson) a:03jgleeson [18:30:57] (03Merged) 10jenkins-bot: ESLint: Update to ES6 and autofix [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120567 (owner: 10Esanders) [18:31:00] (03Merged) 10jenkins-bot: ESLint: Manually fix prefer-const violations [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1120568 (owner: 10Esanders) [18:49:25] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10565183 (10Pcoombe) Oops, thanks @Cstone. I've corrected that parameter now. @EMartin does this link work for you? https://payments.wikimedia.org/index.php?title=Special:GravyGateway&appeal=JimmyQuote... [18:57:37] (03CR) 10Eileen: "ejegg - are you OK to +2 this & I'll fix at the top of the chain - I think I might have fixed one further up but also I see some merge man" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:06:35] (03CR) 10Ejegg: [C:03+2] Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:10:22] ugh, can't run tests locally due to a probable yaml malformation [19:11:27] which tests ejegg ? [19:11:36] I've been running civi ones today [19:11:56] payments-phpunit crashes on startup with an error in the SmashPig logger init call, inside the Configuration get value call [19:12:00] expecting an array [19:12:16] and getting null [19:12:21] trying to figure out exactly where [19:12:27] (03PS8) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [19:12:27] (03PS3) 10Eileen: Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 [19:12:53] k, it's looking in logging/log-streams/$streamName [19:12:57] but for which stream? [19:13:32] argh - the test I was fighting jenkins on failed overnight cos of a rebase mistake [19:15:16] huh, searching the whole fundraising-dev project i only see log-streams in the smashpig library's provider-defaults.yaml [19:15:53] oh i see, it's in config-private [19:16:02] and I did mess that up with the search-n-replace [19:16:05] fixing now [19:16:31] ah [19:16:42] I don't think I caught that update [19:32:15] (03Merged) 10jenkins-bot: Move deleteDeletedContact to an api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1114477 (https://phabricator.wikimedia.org/T270677) (owner: 10Eileen) [19:32:39] fixed now. sorry, i should have run the tests before pushing it to the config repo [19:33:46] fr-tech there are also three yaml patches in the settings repo on prod that have yet to be pushed out [19:34:08] I'm going over them again to double check, but would love another set of eyes on them [19:34:52] ejegg: is yamllint installed on that box [19:34:55] might help [19:36:34] jeez [19:37:07] ok yamllint is accessible [19:37:37] ejegg: `git diff --name-only HEAD~1 HEAD -- '*.yaml' '*.yml' | xargs yamllint` looks good [19:38:32] (03PS7) 10Eileen: Add verifyDeleted task, focussing only on recur for now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) [19:38:59] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120696 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [19:45:29] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: CLP amounts to adyen are missing the conversion to cents - https://phabricator.wikimedia.org/T386526#10565408 (10Ejegg) At https://docs.adyen.com/development-resources/currency-codes/ they list CLP as using 2 decimal places in their API but note that it '... [19:45:37] thanks jgleeson ! [19:46:47] (03PS1) 10Ejegg: Add exceptions to currency minor units for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1121084 (https://phabricator.wikimedia.org/T386526) [19:47:27] ok cstone I think that should get CLP charging correctly via Adyen ^^^ [19:54:56] damilare|brb: so that test is failing due to test fixture pollution between tests. I'll add a teardown cleanup [19:55:10] well, i'mma deploy those yaml patches one at a time [19:55:17] going for the process-control one first [19:55:37] ejegg: we've got tech-talk in 5 [19:55:47] might be a good one to slow-walk with folks testing for you [19:56:06] (the scary ones) [19:56:24] heh, could be [19:59:58] ah so CLP was a special case ejegg ? [20:00:05] sounds good jgleeson [20:00:22] yah cstone [20:00:43] doesn't actually have any cents but Adyen treats it as having 'em for whatever reason [20:08:16] (03CR) 10CI reject: [V:04-1] Add exceptions to currency minor units for Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1121084 (https://phabricator.wikimedia.org/T386526) (owner: 10Ejegg) [20:13:48] 10fundraising-tech-ops, 10BDC-Implementation: Service monitoring for FR analytics platform. - https://phabricator.wikimedia.org/T386259#10565486 (10Jgreen) [20:23:31] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work on this, tested and can see the added zipcodes in the table locally." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) (owner: 10Ejegg) [20:30:55] (03PS5) 10Jgleeson: Verify sending recurring Paypal payments to the donations queue. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) [20:34:18] (03PS2) 10Eileen: Monolog updates - adds support for test processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120694 [20:34:18] (03PS2) 10Eileen: Remove transitional managed hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120703 [20:34:18] (03PS4) 10Eileen: Add test env Logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 [20:34:19] (03PS9) 10Eileen: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) [20:34:21] (03PS4) 10Eileen: Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 [20:34:37] (03CR) 10Wfan: [C:03+2] Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [20:39:50] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10565591 (10EMartin) @Pcoombe @Cstone Yes! It worked with that link. Thanks! [20:44:05] (03PS1) 10Eileen: Do not use hash from deleted contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121089 (https://phabricator.wikimedia.org/T386770) [20:56:18] (03CR) 10CI reject: [V:04-1] Verify sending recurring Paypal payments to the donations queue. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) (owner: 10Jgleeson) [20:56:35] (03Merged) 10jenkins-bot: Add new zip codes for 2025 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120669 (https://phabricator.wikimedia.org/T386057) (owner: 10Ejegg) [20:57:38] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121091 [20:57:56] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121091 (owner: 10Eileen) [20:58:53] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121091 (owner: 10Eileen) [21:00:04] !log civicrm upgraded from 4ffa9c7c to afe59b16 [21:00:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:01:28] (03CR) 10Wfan: [C:03+2] Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 (owner: 10Eileen) [21:03:47] 06Fundraising-Backlog: update EPC queue consumer to sue api4 - https://phabricator.wikimedia.org/T386871 (10AnnWF) 03NEW [21:19:03] 06Fundraising-Backlog: Trustly error when attempting to bring live - https://phabricator.wikimedia.org/T386502#10565661 (10Pcoombe) 05Open→03Resolved a:03Cstone [21:19:15] (03PS6) 10Jgleeson: Verify sending recurring Paypal payments to the donations queue. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) [21:19:29] ok that should fix that test patch [21:19:43] Testy McTester needed a name change [21:19:47] to Testy McTest [21:20:45] highlander style "there can be only one" https://github.com/wikimedia/wikimedia-fundraising-crm/blob/e774756a1c53776ab3d92a408a2d736829481358/drupal/sites/default/civicrm/extensions/wmf-civicrm/tests/phpunit/Civi/WMFEnvironmentTrait.php#L100 [21:21:10] how did "Russ" make it on the guest list? [21:22:32] Gen D Russ & RussTheGreat, [21:22:52] https://en.wikipedia.org/wiki/Robert_D._Russ [21:28:47] gonna push out the donationinterface yaml changes [21:30:15] !log payments-wiki upgraded from 7f66dea6 to 028cc28a [21:30:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:30:34] k, that still looks good [21:31:10] going for the smashpig ones now [21:34:03] looks fine so far [21:52:13] gonna have to call it a day - feel free to revert and roll back the settings repo patches if you see any issues that might be due to yaml changes [21:52:58] wfan: I need the earlier things in the queue to merge before those ones you gave a +2 to https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1120694/2 [21:53:30] Looking [21:54:06] (03CR) 10Eileen: [C:03+2] Verify sending recurring Paypal payments to the donations queue. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1113582 (https://phabricator.wikimedia.org/T366526) (owner: 10Jgleeson) [21:54:51] (03CR) 10Wfan: [C:03+2] Monolog updates - adds support for test processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120694 (owner: 10Eileen) [22:23:08] (03Merged) 10jenkins-bot: Monolog updates - adds support for test processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120694 (owner: 10Eileen) [22:23:47] (03CR) 10Wfan: [C:03+2] Do not use hash from deleted contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121089 (https://phabricator.wikimedia.org/T386770) (owner: 10Eileen) [22:31:50] thanks wfan there are still 2 in the chain blocking merge - one I can rebase out but https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1120695 needs to merge [22:34:55] (03CR) 10Wfan: [C:03+2] Remove transitional managed hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120703 (owner: 10Eileen) [22:36:44] just one question: 'weight' => -20, is that supported? [22:36:52] if so looks good to go~ [22:37:54] wfan: yeah I tested it! [22:38:04] cool! [22:38:14] (03CR) 10Wfan: [C:03+2] Add test env Logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 (owner: 10Eileen) [22:38:26] thanks wfan [22:39:11] np~ thanks for all those work! [22:39:34] 06Fundraising-Backlog: update EPC queue consumer to use api4 - https://phabricator.wikimedia.org/T386871#10565924 (10AnnWF) [22:46:52] (03Merged) 10jenkins-bot: Do not use hash from deleted contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121089 (https://phabricator.wikimedia.org/T386770) (owner: 10Eileen) [22:59:44] (03Merged) 10jenkins-bot: Remove transitional managed hook [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120703 (owner: 10Eileen) [23:00:43] 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: Solve the user config file problem for FR analytics. - https://phabricator.wikimedia.org/T386878 (10Jgreen) 03NEW [23:03:21] (03Merged) 10jenkins-bot: Add test env Logger [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120695 (owner: 10Eileen) [23:04:47] (03Merged) 10jenkins-bot: Set failmail on alert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120697 (https://phabricator.wikimedia.org/T317257) (owner: 10Eileen) [23:04:48] (03Merged) 10jenkins-bot: Fight the good fight with jenkins [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120704 (owner: 10Eileen) [23:08:56] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121107 [23:09:06] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121107 (owner: 10Eileen) [23:09:55] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1121107 (owner: 10Eileen) [23:13:21] !log civicrm upgraded from afe59b16 to 944ad623 [23:13:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:24:53] (03PS1) 10Eileen: Fix url [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121108 [23:25:07] ok that url was a bit off ^^ [23:28:21] (03PS4) 10Wfan: Update epc link to the one with hash fallback [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1120693 (https://phabricator.wikimedia.org/T386771) [23:28:37] (03PS8) 10Wfan: Update thank you unsubscribe url to epc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1115952 (https://phabricator.wikimedia.org/T359445) [23:35:08] (03CR) 10Wfan: [C:03+2] Fix url [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121108 (owner: 10Eileen) [23:35:39] thanks wfan [23:51:37] (03PS1) 10Eileen: See if jenkins has cheered up [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121110 [23:55:27] (03PS1) 10Eileen: Comment fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121112 [23:58:34] (03Merged) 10jenkins-bot: Fix url [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1121108 (owner: 10Eileen)