[00:06:00] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Handling for known-invalid emails - https://phabricator.wikimedia.org/T389447 (10Eileenmcnaughton) 03NEW [01:18:55] (03PS3) 10Eileen: More CRM_Core_Exception error handling up to handleError() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1126703 (https://phabricator.wikimedia.org/T365418) [01:21:59] (03CR) 10Ejegg: [C:03+2] "I like it, and it looks safe as written. We'll have to be careful as we add more 'push' calls to avoid pushing two+ deep, then catching th" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1126703 (https://phabricator.wikimedia.org/T365418) (owner: 10Eileen) [01:22:24] thanks ejegg [01:24:09] do you think the risk is we don't push / pop them in the right order? [01:24:38] hmm - we'll have to see how it shakes down [01:25:58] oh this one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1128588 - is deliberately failing to 'prove' the test - but it is 'good' & should merge cos the one above it has the fix [01:30:17] fr-tech shall we turn off dlocal? [01:30:38] I think some card payments can be processed via adyen in the dlocal countries [01:30:54] sorry, I just noticed we're still getting failmails [01:32:02] oh, there are banners up! [01:32:21] pcoombe: we're getting a lot of failures from dlocal - let's take down the banners for now [01:32:36] oh wait, it's 1:30AM for him, sorry [01:38:13] OK, I just turned them off and put a message in the slack channel [01:40:04] oh. sorry. i didn't think to check for banners. [01:40:33] dlocal had been off and on for a while but looks like they moved to full fail mode [01:40:53] although now their status page says they are fully operational [01:42:28] but the ip they are advertising is still non resposive [01:44:29] ok, are we about to start charging recurrings? [01:45:28] ah we started a while ago [01:46:03] would be nice to bump any yet-to-charge dlocal recurrings out another day to avoid a certain failure [01:46:10] let me see if I can figure that our [01:47:43] they had been advertising 75.2.102.18 and 99.83.182.17 via dns, but now they are only giving out 34.149.74.49 which times out even a basic `openssl s_client -connect` from the payments hosts and locally. [01:47:48] (03Merged) 10jenkins-bot: More CRM_Core_Exception error handling up to handleError() [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1126703 (https://phabricator.wikimedia.org/T365418) (owner: 10Eileen) [01:53:48] well, it's only 128 but i pushed them out to tomorrow [01:55:45] eileen: i just worry we'll try { ... push(A) .... push(B) .... throw, catch, then only pop B. I guess if we only care about the innermost ctx it doesn't matter if we leave A on the stack [01:57:27] ah damg, there seem to be emails out too [01:58:12] need to edit tyhe outage file onwiki i think [02:04:34] aha, https://meta.wikimedia.org/wiki/MediaWiki:FR2013/Resources/PaymentOutages.js [02:07:06] hmm, that's not quite what we need [02:07:28] I'll just turn dlocal off at payments-wiki and we can at least accept cards via adyen [02:07:50] as long as there's no gateway hardcoded in the donatewiki links [02:09:02] though folks will get a 'gateway not found' error for non-card methods [02:09:12] !log disabled dlocal at payments-wiki [02:09:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:09:40] so let's write an email [02:20:06] ok, email written [02:20:23] hmm, i could add 'cash' to that outage file [02:21:14] ah dang, but i don't have permission to edit it anymore [02:30:21] ok, there's something we can comment out on donatewiki [02:35:48] ahh, i can grep for it in the dump maybe [02:36:41] Template:Paymentmethod/Cash-dLocal [02:38:47] OK, I've commented out the cash button [02:51:37] ejegg: can you +2 this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1128588 - it's the test for the next patch which has a +2 but can't merge [02:56:22] ok, checking [02:58:51] sorry, I need to read the next patch to figure out what that test is supposed to do [02:59:40] ok, i think i get it now [02:59:52] so this is if they make a donation with a link that has hash + id [02:59:58] and the id has been deleted since [03:00:02] (likely merged) ? [03:00:15] so for now we kick it to damaged [03:00:36] but maybe later we can use that get_merged_to function to get the right new ID to import it to? [03:02:11] ejegg: the next patch in the chain does that [03:02:25] which got +2d [03:02:34] but the test for it was in the patch before [03:02:53] well no sorry this is hard deleted not merged [03:02:59] so it can't be found [03:03:25] so we can't create a referral activity - cos it doesn't exist [03:03:48] so currently it goes to damaged (as a deadlock! - but the exception fix should handle that) [03:03:55] ok, got it [03:04:10] (03PS2) 10Eileen: Add unit test and fix error handler to give usable error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128588 (https://phabricator.wikimedia.org/T389156) [03:04:16] (03CR) 10Ejegg: [C:03+2] Add unit test and fix error handler to give usable error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128588 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [03:04:43] thanks! [03:05:06] so 'expected to fail' means it needs a V+2 too, right? [03:20:08] ok, dlocal says it's been fixed [03:21:51] let's check [03:28:55] ok, seems to work [03:29:01] (03CR) 10CI reject: [V:04-1] Add unit test and fix error handler to give usable error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128588 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [03:29:04] will go about undoing the things [03:29:27] ah, and that patch does indeed need the v+2, will do that too [03:30:21] Dang - gerrit never used to declare merge conflicts when there was no conflict - it has gotten worse [03:30:42] - but even if we switch to gitlab I assume this will still happen.... [03:31:05] (03PS2) 10Eileen: Fix import when contact_id is in hash but is deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128589 (https://phabricator.wikimedia.org/T389156) [03:31:13] (03PS2) 10Eileen: Add extra test for soft-deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128590 (https://phabricator.wikimedia.org/T389156) [03:35:03] (03PS3) 10Eileen: Fixes to notifications on queueErrors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1127259 (https://phabricator.wikimedia.org/T366635) [03:39:25] ejegg: dlocal email that they say it is corrected. i see connections working from my localhost, but not from payments1005. i'm digging in to see what's doing on but i am not seeing any local firewall blocks in the way [03:39:56] (03PS4) 10Eileen: Fixes to notifications on queueErrors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1127259 (https://phabricator.wikimedia.org/T366635) [03:40:38] ok - that one is cleaned up post-merge now [03:41:38] ah. i see the issue. and it's annoying. [03:42:23] we have moved the iptables config to use the ipset, but the pfw config is still using the static ip addresses. [03:43:10] i'll put in a high priority task to add the new ip in, but in the long term we may want to shift the payments hosts to using ipset based rules across the board. as long as that clears the PCI hurdles. [03:53:38] ok. created T389455 for handling the pfw changes. [03:53:39] T389455: Add new dlocal API ip addresses to firewall rules - https://phabricator.wikimedia.org/T389455 [03:54:10] it's triaged as high so should hopefully be sorted out early european time. [04:07:53] oh shoot dwisehaupt [04:08:11] i had just turned it on but will turn it off again [04:19:18] ok, it's back off [04:24:19] (03CR) 10Eileen: "resubmit" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128589 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [04:24:34] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128590 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [04:25:51] yeah. payments is one of the only places that we still have strict limits that aren't fully dns based. [04:31:59] (03PS1) 10Eileen: Port upstream import fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1129603 [04:38:32] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128589 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [06:12:41] (03CR) 10Eileen: [V:03+2] Add unit test and fix error handler to give usable error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1128588 (https://phabricator.wikimedia.org/T389156) (owner: 10Eileen) [09:01:14] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for llugo - https://phabricator.wikimedia.org/T385053#10656127 (10Aklapper) @Dwisehaupt: Is there more to do in this open ticket? [10:04:08] (03CR) 10Ladsgroup: [C:03+1] "Overall, looks good to me. It's a bit scary given the original fallback from replica to primary (and thank you for cleaning it up). I leav" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1129227 (https://phabricator.wikimedia.org/T389348) (owner: 10Reedy) [10:20:34] (03CR) 10Reedy: [C:03+2] build: Update MediaWiki requirement to 1.44 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1129439 (owner: 10Jforrester) [10:40:56] (03CR) 10Jgleeson: More CRM_Core_Exception error handling up to handleError() (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1126703 (https://phabricator.wikimedia.org/T365418) (owner: 10Eileen) [10:55:59] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.44 [extensions/FundraisingTranslateWorkflow] - 10https://gerrit.wikimedia.org/r/1129439 (owner: 10Jforrester) [14:01:00] 06Fundraising-Backlog, 10fundraising-tech-ops: Add new dlocal API ip addresses to firewall rules - https://phabricator.wikimedia.org/T389455#10657184 (10jgleeson) dLocal has reported a fix has been deployed on their side. I'll switch it all back on. [14:32:13] (03CR) 10Thiemo Kreuz (WMDE): [C:03+1] CentralNoticeHooks: Some very minor cleanup (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1129232 (owner: 10Reedy) [14:33:36] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Allow community without extended rights to help with CN banner translations going 'live' - https://phabricator.wikimedia.org/T341414#10657265 (10Astinson) >>! In T341414#9112530, @Frostly wrote: > I think that th... [14:34:15] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1129603 (owner: 10Eileen) [14:35:27] (03CR) 10Jgleeson: [C:03+2] Update a couple comments about iDEAL [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1126656 (https://phabricator.wikimedia.org/T387738) (owner: 10Ejegg) [14:36:03] morning fr-tech, how's dlocal looking? [14:37:08] (03PS3) 10Thiemo Kreuz (WMDE): More compact code with the fn() callable syntax [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1118475 [14:38:38] (03CR) 10Thiemo Kreuz (WMDE): CampaignLog: Don't run null through json_decode() (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1128986 (https://phabricator.wikimedia.org/T389261) (owner: 10Reedy) [14:39:39] (03CR) 10Jgleeson: [C:03+2] "The form looks good to me with the changes, and submitting it successfully redirects me to https://cdn.sandbox.wikimedia.gr4vy.app/connect" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1124180 (https://phabricator.wikimedia.org/T387758) (owner: 10Wfan) [14:55:37] ejegg|away: it's back on [14:55:45] logs look ok [15:06:45] (03Merged) 10jenkins-bot: Port upstream import fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1129603 (owner: 10Eileen) [15:06:46] (03Merged) 10jenkins-bot: Update a couple comments about iDEAL [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1126656 (https://phabricator.wikimedia.org/T387738) (owner: 10Ejegg) [15:18:25] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Allow community without extended rights to help with CN banner translations going 'live' - https://phabricator.wikimedia.org/T341414#10657429 (10Johannnes89) Thanks! I don't think there has been much community di... [17:13:38] (03Merged) 10jenkins-bot: Remove address fields for ACH in checkout flow [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1124180 (https://phabricator.wikimedia.org/T387758) (owner: 10Wfan) [17:59:31] jgleeson: ^ i think we need to wait on that one [17:59:46] gravy needs to send info back on the response before we remove those fields on our end [18:00:20] i didnt realize we had had a patch [18:29:05] (03PS1) 10Cstone: Revert "Remove address fields for ACH in checkout flow" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1129907 [18:38:36] cstone: oh right [18:45:53] (03CR) 10Umherirrender: [C:03+2] build: Update MediaWiki requirement to 1.44 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1129464 (owner: 10Jforrester) [19:29:44] (03CR) 10CI reject: [V:04-1] build: Update MediaWiki requirement to 1.44 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1129464 (owner: 10Jforrester) [20:22:34] (03PS2) 10Jgleeson: Add Pago Efectivo for Gravy dLocal Peru [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1129290 (https://phabricator.wikimedia.org/T385012) [20:22:34] (03PS1) 10Jgleeson: Add Redpagos for Gravy dLocal Uruguay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1129925 [20:25:46] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Allow community without extended rights to help with CN banner translations going 'live' - https://phabricator.wikimedia.org/T341414#10659193 (10DerHexer) I second Johannnes89’s reasoning. CN admins would appreci... [20:30:06] (03PS2) 10Jgleeson: WIP: Add Redpagos for Gravy dLocal Uruguay [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1129925 [20:30:38] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Allow community without extended rights to help with CN banner translations going 'live' - https://phabricator.wikimedia.org/T341414#10659206 (10Aafi) I agree with both @DerHexer and @Johannnes89 but I must reite... [20:41:28] 03Fundraising Sprint: Elephant Toothpaste, 06Fundraising-Backlog, 07Epic, 07payments-orchestration: Gravy dLocal Internal Test Plan - https://phabricator.wikimedia.org/T389547 (10jgleeson) 03NEW [20:41:37] 03Fundraising Sprint: Elephant Toothpaste, 06Fundraising-Backlog, 07payments-orchestration: Gravy dLocal Internal Test Plan - https://phabricator.wikimedia.org/T389547#10659278 (10jgleeson) [20:42:46] XenoRyet: that ticket we discussed earlier is there ^^ I'll flesh it out tomorrow and add a link to our testing doc template [21:20:30] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1129941 [21:23:31] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1129941 (owner: 10Eileen) [21:24:45] (03CR) 10Umherirrender: [C:03+2] "Resubmit" [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1129464 (owner: 10Jforrester) [21:25:14] !log civicrm upgraded from 7b532ad7 to fba4c3d6 [21:25:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:27:23] eileen: would you be able to jump on a call to look at a searchkit for me real quick? I'm joining on the wrong thing I think [21:27:44] I can't quite yet - I could in 30 mins [21:28:39] well progress i actually got a result this time hah [21:29:58] (03CR) 10Pppery: [C:04-1] "This is a duplicate. Please don't add a blank line after the change-id when amending your commit message." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1129260 (https://phabricator.wikimedia.org/T389165) (owner: 10Ayush_khati1) [21:30:27] ooh i think i got it [21:33:16] (03Merged) 10jenkins-bot: build: Update MediaWiki requirement to 1.44 [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1129464 (owner: 10Jforrester) [21:38:29] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Allow community without extended rights to help with CN banner translations going 'live' - https://phabricator.wikimedia.org/T341414#10659554 (10Johannnes89) >>! In T341414#10659206, @Aafi wrote: > Although trans... [21:46:06] 10fundraising-tech-ops: Fundraising Access for CiviCRM and Superset for Erica Viegas - https://phabricator.wikimedia.org/T388391#10659600 (10Dwisehaupt) [21:46:22] 10fundraising-tech-ops: Fundraising Access for CiviCRM and Superset for Erica Viegas - https://phabricator.wikimedia.org/T388391#10659601 (10Dwisehaupt) 05Open→03Resolved Verified access is working. Closing. [21:50:11] cool [21:50:22] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for llugo - https://phabricator.wikimedia.org/T385053#10659666 (10Dwisehaupt) [21:51:44] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for llugo - https://phabricator.wikimedia.org/T385053#10659671 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt Logins haven't been verified but if there are any issues they can be opened in a new task. [21:55:10] 10fundraising-tech-ops: Fundraising access request for astein - https://phabricator.wikimedia.org/T386746#10659705 (10Dwisehaupt) [21:56:40] 10fundraising-tech-ops: Fundraising access request for astein - https://phabricator.wikimedia.org/T386746#10659726 (10Dwisehaupt) [21:58:10] 10fundraising-tech-ops: Fundraising access request for ccogdill - ssh - https://phabricator.wikimedia.org/T376155#10659744 (10Dwisehaupt) @CaCogdill-WMF Just wanted to follow up and see if your ssh access was working. If so we can finish the mysql setup if it is needed. [22:00:06] 10fundraising-tech-ops: Fundraising access request for PPenloglou - https://phabricator.wikimedia.org/T363936#10659751 (10Dwisehaupt) 05Open→03Resolved Login access hasn't been fully verified. If there are any issues, they can be opened in a follow on task. [23:09:31] cstone: all good now?