[00:52:15] thanks eileen [00:52:58] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog, 10FR-donorservices: Request to Revert field back to what it was - https://phabricator.wikimedia.org/T385745#10676697 (10AKanji-WMF) Moving out of Sprint F to accommodate offsite capacity [02:46:16] oh hmm, log in link is showing on donor prefs wiki [02:46:19] let's hide that [03:09:58] dwisehaupt: if you're still at a kayboard, I've got a lil puppet patch in my frpm:~/puppet/0001-Use-modern-way-to-hide-log-in-link-on-donorwiki.patch [03:10:04] nothing urgent [03:10:28] looking. [03:12:23] (03PS1) 10Ejegg: Fix hiding login link on email prefs page [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131122 [03:12:36] ok. it's commited to puppet and will roll out with the next puppet runs on the hosts. [03:15:10] thanks! [03:15:28] (03PS1) 10Ejegg: Enable DonationInterface on donutwiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131123 [03:22:48] (03PS1) 10Ejegg: WIP switch new checksum link to require email [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1131125 (https://phabricator.wikimedia.org/T388739) [03:24:57] (03CR) 10CI reject: [V:04-1] WIP switch new checksum link to require email [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1131125 (https://phabricator.wikimedia.org/T388739) (owner: 10Ejegg) [03:58:16] (03PS4) 10Wfan: When checksum invalid like empty, let them get update link instead of return error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1127941 (https://phabricator.wikimedia.org/T388912) [04:01:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Checksums and contact ids missing from recurring upgrade links - https://phabricator.wikimedia.org/T388912#10676922 (10AnnWF) [04:40:29] (03PS4) 10Cstone: WIP: Gateway chooser not choosing correctly with gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) [04:55:54] (03PS5) 10Cstone: Gateway chooser not choosing correctly with gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) [04:56:39] (03PS6) 10Cstone: Check that google and apple pay are chosen correctly for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) [05:50:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Checksums and contact ids missing from recurring upgrade links - https://phabricator.wikimedia.org/T388912#10677039 (10MSuijkerbuijk_WMF) Thanks, makes sense. @NNgu-WMF do you mind adding this to our Agreements tab for targeting and... [06:19:19] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1131152 (owner: 10L10n-bot) [07:04:53] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_41) - 10https://gerrit.wikimedia.org/r/1131152 (owner: 10L10n-bot) [09:28:20] 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\FundraiserLandingPage\Specials\Fund... - https://phabricator.wikimedia.org/T390032 [10:07:58] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extensio... - https://phabricator.wikimedia.org/T390032#10677595 [10:23:54] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extensio... - https://phabricator.wikimedia.org/T390032#10677674 [10:32:11] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extensio... - https://phabricator.wikimedia.org/T390032#10677706 [10:49:42] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extensio... - https://phabricator.wikimedia.org/T390032#10677748 [10:53:56] 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Call... - https://phabricator.wikimedia.org/T390032#10677753 [11:24:02] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-CentralNotice, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from CentralNotice::outputListOfNotices] - https://phabricator.wikimedia.org/T390040... [11:24:52] 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Call... - https://phabricator.wikimedia.org/T390032#10677840 [11:29:22] 06Fundraising-Backlog, 06Content-Transform-Team, 10MediaWiki-extensions-CentralNotice, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from SpecialCentralNoticeBanners::showBa... - https://phabricator.wikimedia.org/T390041 [11:57:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, and 2 others: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\Fun... - https://phabricator.wikimedia.org/T390032#10677940 [13:14:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054 (10jgleeson) 03NEW [13:25:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678314 (10Aklapper) [13:25:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678317 (10Aklapper) [13:35:47] 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, 10MediaWiki-extensions-FundraiserLandingPage, 07Wikimedia-production-error: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Call... - https://phabricator.wikimedia.org/T390032#10678357 [13:36:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678358 (10jgleeson) a:03jgleeson [13:36:33] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678361 (10jgleeson) p:05Triage→03Unbreak! [13:48:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678468 (10Jdforrester-WMF) I was looking at this now, but it's hard to see how to do t... [13:49:50] (03PS1) 10Jgleeson: Remove use of deprecated OutputPage::parserOptions() [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131324 (https://phabricator.wikimedia.org/T390054) [13:51:24] (03PS2) 10Jgleeson: Remove use of deprecated OutputPage::parserOptions() [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131324 (https://phabricator.wikimedia.org/T390032) [13:51:25] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, and 2 others: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\Fun... - https://phabricator.wikimedia.org/T390032#10678479 [13:51:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 13Patch-For-Review: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678485 (10jgleeson) 05Open→03Invalid [14:03:47] (03PS1) 10Jforrester: [WIP] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390054) [14:05:30] (03CR) 10CI reject: [V:04-1] [WIP] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390054) (owner: 10Jforrester) [14:06:44] (03PS2) 10Aklapper: [WIP] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:10:41] (03CR) 10CI reject: [V:04-1] [WIP] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:13:04] (03PS3) 10Jgleeson: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:14:33] (03CR) 10Jgleeson: "I took the liberty of adding a missing import after testing it locally and confirming that it was needed for the code to work." [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:16:29] (03Abandoned) 10Jgleeson: Remove use of deprecated OutputPage::parserOptions() [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131324 (https://phabricator.wikimedia.org/T390032) (owner: 10Jgleeson) [14:16:55] (03CR) 10CI reject: [V:04-1] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:22:43] (03PS4) 10Jgleeson: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:25:09] (03CR) 10Jforrester: "Aha, amazing, sorry, was rushing between meetings and wanted to say that this was written on-spec and untested. Thanks!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:25:33] (03CR) 10CI reject: [V:04-1] Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:26:42] (03PS5) 10Jforrester: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) [14:26:42] (03CR) 10Jforrester: Instead of calling deprecated parserOptions(), parse content ourselves (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:26:59] (03PS6) 10Jgleeson: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:27:41] (03CR) 10Jgleeson: "Extra Liberties: $this->mRevisionId" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:28:27] (03CR) 10Jforrester: [C:03+1] "Yeah, thanks!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:28:54] (03CR) 10Jgleeson: "Ignore. Started writing and then CI failed. Memory emptied :)" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:30:18] (03CR) 10Jgleeson: Instead of calling deprecated parserOptions(), parse content ourselves (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:32:31] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:32:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 13Patch-For-Review: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678874 (10Jdforrester-WMF) →14Duplicate dup:03T390032 [14:32:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06Content-Transform-Team, 10donate.wikimedia.org, and 3 others: PHP Deprecated: Use of MediaWiki\Output\OutputPage::parserOptions was deprecated in MediaWiki 1.44. [Called from MediaWiki\Extension\Fun... - https://phabricator.wikimedia.org/T390032#10678876 [14:35:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 13Patch-For-Review: Remove Use of OutputPage::parserOptions in Extension\FundraiserLandingPage - https://phabricator.wikimedia.org/T390054#10678900 (10cscott) Another option is to use a strip marker fo... [14:37:24] (03CR) 10C. Scott Ananian: Remove use of deprecated OutputPage::parserOptions() (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131324 (https://phabricator.wikimedia.org/T390032) (owner: 10Jgleeson) [14:40:24] (03CR) 10C. Scott Ananian: [C:03+1] "I can't easily tell where the 'raw html' is coming from, but a better solution would be to use strip markers for the raw html, so we don't" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:41:20] (03CR) 10Jforrester: [C:03+1] Instead of calling deprecated parserOptions(), parse content ourselves (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [14:54:28] (03Merged) 10jenkins-bot: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/1131329 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [15:06:54] (03PS1) 10C. Scott Ananian: Avoid use of OutputPage::parserOptions() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1131346 (https://phabricator.wikimedia.org/T390040) [15:21:50] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07PHP 8.1 support, 07Unplanned-Sprint-Work: Merge master into wmf_deploy (Mar 12, 2025) - https://phabricator.wikimedia.org/T388723#10679128 (10Reedy) [15:30:31] (03CR) 10Jforrester: [C:03+2] Avoid use of OutputPage::parserOptions() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1131346 (https://phabricator.wikimedia.org/T390040) (owner: 10C. Scott Ananian) [15:37:01] (03Merged) 10jenkins-bot: Avoid use of OutputPage::parserOptions() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1131346 (https://phabricator.wikimedia.org/T390040) (owner: 10C. Scott Ananian) [15:37:36] (03PS1) 10Jforrester: Instead of calling deprecated parserOptions(), parse content ourselves [extensions/FundraiserLandingPage] (wmf/1.44.0-wmf.22) - 10https://gerrit.wikimedia.org/r/1131348 (https://phabricator.wikimedia.org/T390032) [15:59:23] (03CR) 10Cstone: Separate out paypal validation for gravy (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1127754 (https://phabricator.wikimedia.org/T385738) (owner: 10Cstone) [16:10:19] (03PS1) 10Jforrester: Merge remote-tracking branch 'origin/master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1131364 (https://phabricator.wikimedia.org/T350626) [16:51:43] (03PS11) 10Jdlrobson: Fixes warning: mediawiki.Uri is deprecated, use URL instead [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) [17:06:10] Does someone plan to backport https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FundraiserLandingPage/+/1131348 ? TIA [17:31:57] (03CR) 10Krinkle: [C:04-1] "This does not warrant a new module, the wrapper is larger than the contents, thus both adding more in the critical path via startup and no" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [17:33:17] (03CR) 10Krinkle: [C:04-1] "I'd suggest the kvStore, assuming it has no side effects is a clean bundle for shared logic" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [17:53:56] (03CR) 10Jgleeson: [C:03+1] "+2ed original patch. LGTM!" [extensions/FundraiserLandingPage] (wmf/1.44.0-wmf.22) - 10https://gerrit.wikimedia.org/r/1131348 (https://phabricator.wikimedia.org/T390032) (owner: 10Jforrester) [18:03:11] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680148 (10MDemosWMF) Adding some notes from our checkin: New aspects to investigate: - Fund soft credits individual and banking institution - Is... [18:16:21] (03PS1) 10Wfan: Add Stitch for Gravy dLocal South Africa [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131400 (https://phabricator.wikimedia.org/T385012) [18:20:23] (03PS12) 10Jdlrobson: Fixes warning: mediawiki.Uri is deprecated, use URL instead [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) [18:20:54] (03CR) 10Jdlrobson: "Fixed." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [18:21:14] (03PS1) 10Wfan: Add back bank transfer for south africa without fiscal number (use default) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131402 (https://phabricator.wikimedia.org/T385012) [18:22:00] (03PS2) 10Wfan: Add back bank transfer for south africa without fiscal number (use default) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131402 (https://phabricator.wikimedia.org/T385012) [18:23:38] (03CR) 10CI reject: [V:04-1] Fixes warning: mediawiki.Uri is deprecated, use URL instead [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [18:27:40] (03CR) 10Jgleeson: [V:03+2 C:03+2] "LGTM!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131402 (https://phabricator.wikimedia.org/T385012) (owner: 10Wfan) [18:39:07] (03CR) 10Jgleeson: [C:03+2] "Thanks for all the updates. This looks great and worked well for me during testing!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1127754 (https://phabricator.wikimedia.org/T385738) (owner: 10Cstone) [18:39:38] (03Merged) 10jenkins-bot: Separate out paypal validation for gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1127754 (https://phabricator.wikimedia.org/T385738) (owner: 10Cstone) [18:39:44] thanks jgleeson ! [18:39:57] np [18:51:40] ok time to see why CI thinks PHP Enums are goto syntax https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1131105 [19:08:18] (03PS1) 10Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1131414 [19:08:21] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1131414 (owner: 10Ejegg) [19:12:02] (03PS4) 10Jgleeson: Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 [19:12:27] (03CR) 10CI reject: [V:04-1] Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 (owner: 10Jgleeson) [19:13:30] (03PS13) 10Jdlrobson: Fixes warning: mediawiki.Uri is deprecated, use URL instead [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) [19:18:12] (03CR) 10CI reject: [V:04-1] Fixes warning: mediawiki.Uri is deprecated, use URL instead [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [19:22:14] (03PS1) 10Wfan: Add stitch for bt in civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1131420 (https://phabricator.wikimedia.org/T385012) [19:28:08] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1131414 (owner: 10Ejegg) [19:29:13] (03PS1) 10Jgleeson: Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 [19:29:37] (03CR) 10CI reject: [V:04-1] Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 (owner: 10Jgleeson) [19:29:38] (03PS5) 10Jgleeson: Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 [19:30:05] (03CR) 10CI reject: [V:04-1] Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 (owner: 10Jgleeson) [19:31:34] (03PS6) 10Jgleeson: Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 [19:32:33] (03CR) 10CI reject: [V:04-1] Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 (owner: 10Jgleeson) [19:44:59] (03PS2) 10Jgleeson: Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 [19:45:25] (03CR) 10CI reject: [V:04-1] Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 (owner: 10Jgleeson) [19:53:19] (03PS7) 10Cstone: Check that google and apple pay are chosen correctly for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) [20:11:17] PROBLEM - check_dagster on fran2001 is CRITICAL: CRITICAL - Plugin timed out after 10 seconds https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_dagster [20:11:17] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 126.29, 68.78, 30.51 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [20:15:07] RECOVERY - check_dagster on fran2001 is OK: PROCS OK: 1 process with args python /srv/dagster/bin/dagster https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_dagster [20:15:09] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 3.90, 32.70, 24.19 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [20:45:09] RECOVERY - check_load on fran2001 is OK: LOAD OK - total load average: 0.26, 0.69, 4.06 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [21:11:54] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680737 (10MDemosWMF) FYI RE Fidelity unique donor number: "The giving account number is specifically associated with the donors account and listed in our data... [21:14:41] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680767 (10Eileenmcnaughton) @MDemosWMF ok so we CAN use it! [21:17:33] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680770 (10MDemosWMF) @Eileenmcnaughton Unfortunately they said we can't use it based on their response above. It is confidential and not able to be included i... [21:24:35] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680789 (10Eileenmcnaughton) oh - so the number they provide is not it - is there any way the can provide a unique number - ie they could easily provide a hash... [21:24:56] (03CR) 10Jgleeson: [C:03+2] "Wfan and I tested this on Tech Talk, and it worked well! Thanks." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) (owner: 10Cstone) [21:27:02] (03Merged) 10jenkins-bot: Check that google and apple pay are chosen correctly for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1130694 (https://phabricator.wikimedia.org/T387512) (owner: 10Cstone) [21:32:16] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10680828 (10MDemosWMF) Following up, I'll see what they say! [21:39:43] (03PS3) 10Jgleeson: Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 [21:40:08] (03CR) 10CI reject: [V:04-1] Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 (owner: 10Jgleeson) [21:41:01] argh. phpcs warnings also result in a failure [21:51:07] cstone: you were right [21:51:09] 34 | WARNING | assertEmpty performs loose comparisons and should not be used. (MediaWiki.PHPUnit.AssertEmpty.AssertEmptyUsed) [22:02:57] (03PS4) 10Jgleeson: Update mediawiki/mediawiki-codesniffer to v46.0 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131422 [22:06:23] (03PS7) 10Jgleeson: Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 [22:06:50] (03CR) 10CI reject: [V:04-1] Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 (owner: 10Jgleeson) [22:08:49] emptyyyyy [22:09:55] (03PS8) 10Jgleeson: Introduce PaymentMethod Enum for Gravy methods [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1131105 [22:11:41] fr-tech those two tricky patches from tech-talk are now passing on CI https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1131422/4 [22:12:18] I'm wrapping up. Catch you all tomorrow o/ [22:47:29] (03PS1) 10Eileen: Not not merge - password check script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1131474 [23:35:32] 06Fundraising-Backlog, 06Data-Engineering, 06Data-Engineering-Radar, 10MediaWiki-extensions-CentralNotice, 06Movement-Insights: Unique Devices seasonal trends on small projects - https://phabricator.wikimedia.org/T344381#10681185 (10Mayakp.wiki) 05Open→03Resolved a:03Mayakp.wiki We can go ahead...