[06:10:06] (03PS1) 10VriaA: Replace spaces with underscores in filter box input [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133604 (https://phabricator.wikimedia.org/T374505) [06:30:49] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1133629 (owner: 10L10n-bot) [07:27:47] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1133769 (owner: 10L10n-bot) [07:59:07] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1133769 (owner: 10L10n-bot) [09:23:40] (03CR) 10Damilare Adedoyin: [C:03+2] Add wmf-cv utility script to CiviCRM Docker container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133485 (https://phabricator.wikimedia.org/T383097) (owner: 10Jgleeson) [09:23:44] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Add wmf-cv utility script to CiviCRM Docker container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133485 (https://phabricator.wikimedia.org/T383097) (owner: 10Jgleeson) [10:59:51] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1133629 (owner: 10L10n-bot) [12:05:15] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners - https://phabricator.wikimedia.org/T390956 (10Pcoombe) 03NEW [12:05:25] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners - https://phabricator.wikimedia.org/T390956#10707557 (10Pcoombe) p:05Triage→03Unbreak! [12:06:27] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners - https://phabricator.wikimedia.org/T390956#10707561 (10Pcoombe) Confirmed that editing existing banners still works okay [12:11:45] (03PS1) 10Damilare Adedoyin: WIP [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133883 [12:17:16] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners - https://phabricator.wikimedia.org/T390956#10707586 (10Pcoombe) Timing appears to line up with the train deployment to meta yesterday, which h... [12:19:22] fr-tech: sorry to interrupt your offsite again :( got a centralnotice bug this time. It's not the most NOW of Unbreak Nows, nothing donor facing, but it is stopping us from doing any banner prep & testing. might impact community usage too [12:19:54] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10707589 [12:25:14] no worries pcoombe some of us are up [12:37:25] (03PS1) 10Ejegg: Use master MW branch for donutwiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133898 [12:38:50] (03PS3) 10Ejegg: Add NoticeHideUrls CentralNotice setting [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1128510 [12:38:50] (03PS3) 10Ejegg: Update donatewiki content dump [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1130777 [12:38:50] (03PS3) 10Ejegg: Fix hiding login link on email prefs page [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131122 [12:38:51] (03PS3) 10Ejegg: Enable DonationInterface on donutwiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1131123 [12:38:52] (03PS2) 10Ejegg: Settings for new large donation notifications [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133529 (https://phabricator.wikimedia.org/T270667) [12:38:53] (03PS2) 10Ejegg: Use master MW branch for donutwiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133898 [12:52:09] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10707731 [13:21:46] 10fundraising-tech-ops: Fundraising access request for chudson - https://phabricator.wikimedia.org/T389250#10707876 (10CHudson-WMF) ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAILeOcjSMDWaPKv5kSNAQ0MOx5Ve6sgekijKWv8Jmce+e chudson@wikimedia.org [13:28:28] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10707915 [13:50:51] (03PS4) 10Jgleeson: WIP: Add CiviCRM standalone composer build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133552 [13:53:31] (03PS5) 10Jgleeson: WIP: Add CiviCRM standalone composer build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133552 [13:58:58] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10MediaWiki-extensions-CentralNotice: Get data about banner closes and maybe more - https://phabricator.wikimedia.org/T324140#10708072 (10AKanji-WMF) Note - consider whether growthbook could address some of these requirements cc: @AnnWF , noting [[ https://d... [14:08:18] (03PS2) 10Wfan: Do not show submethod for trustly ACH [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132044 [14:08:18] (03PS3) 10Wfan: fix wrong word [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132146 [14:09:13] (03CR) 10Cstone: [V:03+2 C:03+2] Point import upload folder to our test files for dev [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1128991 (owner: 10Eileen) [14:13:01] (03CR) 10Damilare Adedoyin: [C:03+2] Do not show submethod for trustly ACH [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132044 (owner: 10Wfan) [14:13:10] (03CR) 10Damilare Adedoyin: [C:03+2] "Looks good to me!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132044 (owner: 10Wfan) [14:18:52] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for the fix wfan! Looks good to me!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132146 (owner: 10Wfan) [14:22:02] (03CR) 10Wfan: [C:03+2] Add wmf-cv utility script to CiviCRM Docker container [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133485 (https://phabricator.wikimedia.org/T383097) (owner: 10Jgleeson) [14:23:20] (03PS10) 10Damilare Adedoyin: Refactor: Catch only validation and api exceptions in Gravy provider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1119549 [14:23:28] (03PS2) 10Damilare Adedoyin: Remove irrelevant "throws ApiException" from Gravy API method docs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1132667 [14:25:05] (03Merged) 10jenkins-bot: Do not show submethod for trustly ACH [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132044 (owner: 10Wfan) [14:25:07] (03Merged) 10jenkins-bot: fix wrong word [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1132146 (owner: 10Wfan) [14:25:21] (03PS2) 10Damilare Adedoyin: Convert docker cp to docker compose cp to remove intermediate directories. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133883 [14:25:27] (03PS6) 10Jgleeson: WIP: Add CiviCRM standalone composer build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133552 [14:25:34] (03CR) 10Wfan: [C:03+2] Convert docker cp to docker compose cp to remove intermediate directories. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133883 (owner: 10Damilare Adedoyin) [14:27:16] (03CR) 10Damilare Adedoyin: [V:03+2] Convert docker cp to docker compose cp to remove intermediate directories. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133883 (owner: 10Damilare Adedoyin) [14:29:00] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708216 [14:34:19] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708256 [14:35:21] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708257 [14:35:22] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708258 [14:36:43] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708266 [14:36:51] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708267 [14:37:43] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708269 [14:39:33] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708279 [14:42:51] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708303 [14:47:55] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708339 [14:51:10] (03PS1) 10Ladsgroup: Remove catching of db exception [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133936 (https://phabricator.wikimedia.org/T390956) [14:58:14] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollba... - https://phabricator.wikimedia.org/T390956#10708396 [15:00:07] (03PS1) 10Reedy: Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 [15:00:18] (03CR) 10CI reject: [V:04-1] Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:02:44] (03PS2) 10Reedy: Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 [15:03:08] (03CR) 10Reedy: [C:03+2] "Revert, self +2" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:04:06] (03CR) 10CI reject: [V:04-1] Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:04:58] (03CR) 10Reedy: [C:03+2] Remove catching of db exception [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133936 (https://phabricator.wikimedia.org/T390956) (owner: 10Ladsgroup) [15:07:46] (03CR) 10Reedy: [C:03+2] "`" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:11:30] (03PS3) 10Reedy: Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 [15:12:56] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollba... - https://phabricator.wikimedia.org/T390956#10708558 [15:15:40] (03Merged) 10jenkins-bot: Remove catching of db exception [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133936 (https://phabricator.wikimedia.org/T390956) (owner: 10Ladsgroup) [15:16:24] (03CR) 10Reedy: [C:03+2] Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:16:39] (03PS1) 10Reedy: Remove catching of db exception [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133944 (https://phabricator.wikimedia.org/T390956) [15:16:53] (03CR) 10Reedy: "not in wmf_deploy; will deal with later" [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133944 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:17:23] (03CR) 10Reedy: [C:03+2] Remove catching of db exception [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133944 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:17:39] (03PS1) 10Reedy: Remove catching of db exception [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133945 (https://phabricator.wikimedia.org/T390956) [15:17:54] (03CR) 10Reedy: [C:03+2] "Put this on master for simplicity" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133945 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:18:13] (03CR) 10Reedy: [C:03+2] "Oh it is. Ignore that then." [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133944 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:21:52] (03Merged) 10jenkins-bot: Remove catching of db exception [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133944 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:21:58] (03PS1) 10Reedy: Banner: Cleanup... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133946 [15:30:05] (03Merged) 10jenkins-bot: Revert "CNDatabasePatcher: Drop migration code from REL1_24" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133939 (owner: 10Reedy) [15:30:07] (03Merged) 10jenkins-bot: Remove catching of db exception [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133945 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:32:31] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708809 [15:33:10] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708812 [15:35:44] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708861 [15:40:09] (03PS7) 10Jgleeson: Add CiviCRM standalone composer build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133552 [15:41:01] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708953 [15:43:35] (03PS1) 10Reedy: Banner: Explicitly check for banner existence from primary [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) [15:43:38] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollback of all peer transac... - https://phabricator.wikimedia.org/T390956#10708960 [15:48:28] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expected mass rollba... - https://phabricator.wikimedia.org/T390956#10709003 [15:48:50] (03CR) 10Ladsgroup: "That function is called in a lot of places and that actually might overwhelm the primary db (I don't know the codebase to judge with confi" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:50:55] (03CR) 10Reedy: "It's only got 4 callers directly...." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:53:40] (03CR) 10Reedy: "My IDE is lying to me today." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:55:32] (03CR) 10Ladsgroup: "I looked at some of them, one is unused it seems, one is a special page (which means we might get a cross-dc read and a warning when someo" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [15:57:10] (03PS2) 10Reedy: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) [15:58:10] (03PS3) 10Reedy: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) [15:59:09] (03PS4) 10Reedy: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) [16:04:29] (03CR) 10Ladsgroup: [C:03+2] Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:05:19] 03Fundraising Sprint: Frito Pie, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10709112 (10MDemosWMF) Fidelity: "Currently the information in the excel sheets, for grant details, are the only details to be given, per policy and procedure.... [16:08:00] (03Merged) 10jenkins-bot: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133954 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:09:52] (03PS1) 10Reedy: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133958 (https://phabricator.wikimedia.org/T390956) [16:09:56] (03CR) 10Reedy: [C:03+2] Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133958 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:10:02] (03PS1) 10Reedy: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133959 (https://phabricator.wikimedia.org/T390956) [16:10:10] (03CR) 10Reedy: [C:03+2] Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133959 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:13:29] (03Merged) 10jenkins-bot: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133959 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:13:57] (03Merged) 10jenkins-bot: Banner: Conditionally check for banner existence from primary db [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133958 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:20:54] (03PS2) 10Reedy: Banner: Cleanup... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133946 [16:23:10] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), 13Patch-For-Review, and 2 others: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expecte... - https://phabricator.wikimedia.org/T390956#10709244 [16:27:51] (03PS1) 10Reedy: Banner: While saving, do exists() against primary [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133965 (https://phabricator.wikimedia.org/T390956) [16:28:18] (03CR) 10Ladsgroup: [C:03+2] Banner: While saving, do exists() against primary [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133965 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:31:49] (03Merged) 10jenkins-bot: Banner: While saving, do exists() against primary [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133965 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:32:45] (03PS1) 10Reedy: Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133968 (https://phabricator.wikimedia.org/T390956) [16:32:50] (03CR) 10Reedy: [C:03+2] Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133968 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:32:56] (03PS1) 10Reedy: Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133969 (https://phabricator.wikimedia.org/T390956) [16:33:00] (03CR) 10Reedy: [C:03+2] Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133969 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:36:33] (03Merged) 10jenkins-bot: Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133969 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:45:42] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), 13Patch-For-Review, and 2 others: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expecte... - https://phabricator.wikimedia.org/T390956#10709335 [16:52:11] (03PS1) 10Reedy: Banner: More reading from primary... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133970 (https://phabricator.wikimedia.org/T390956) [16:53:31] (03Merged) 10jenkins-bot: Banner: While saving, do exists() against primary [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133968 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [16:59:02] (03CR) 10Ladsgroup: [C:03+2] "It really should cache the reads..." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133970 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [17:05:30] (03Merged) 10jenkins-bot: Banner: More reading from primary... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133970 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [17:15:25] (03PS1) 10Reedy: Banner: More reading from primary... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133983 (https://phabricator.wikimedia.org/T390956) [17:15:32] (03CR) 10Reedy: [C:03+2] Banner: More reading from primary... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133983 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [17:15:37] (03PS1) 10Reedy: Banner: More reading from primary... [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133984 (https://phabricator.wikimedia.org/T390956) [17:20:42] (03CR) 10Reedy: [C:03+2] Banner: More reading from primary... [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133984 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [17:23:24] (03Merged) 10jenkins-bot: Banner: More reading from primary... [extensions/CentralNotice] (wmf/1.44.0-wmf.23) - 10https://gerrit.wikimedia.org/r/1133984 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [17:41:50] (03Merged) 10jenkins-bot: Banner: More reading from primary... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133983 (https://phabricator.wikimedia.org/T390956) (owner: 10Reedy) [18:05:25] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), 13Patch-For-Review, and 2 others: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::save: Expecte... - https://phabricator.wikimedia.org/T390956#10709787 [18:06:05] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.44-notes (1.44.0-wmf.23; 2025-04-01), 07Regression, 07Wikimedia-production-error: Internal error when creating/cloning centralnotice banners (Wikimedia\Rdbms\DBUnexpectedError: Banner::... - https://phabricator.wikimedia.org/T390956#10709789 [18:33:52] (03PS1) 10Reedy: Banner: Cleanup... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134002 [18:36:27] (03CR) 10CI reject: [V:04-1] Banner: Cleanup... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134002 (owner: 10Reedy) [18:36:45] (03Abandoned) 10Reedy: Banner: Cleanup... [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1133946 (owner: 10Reedy) [18:38:16] (03PS2) 10Reedy: Banner: Cleanup... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134002 [18:41:15] (03CR) 10CI reject: [V:04-1] Banner: Cleanup... [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134002 (owner: 10Reedy) [18:47:06] (03PS1) 10Umherirrender: Add documentation to undocumented parameterless functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134008 [20:02:12] (03CR) 10Reedy: [C:03+2] Add documentation to undocumented parameterless functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134008 (owner: 10Umherirrender) [20:55:31] (03Merged) 10jenkins-bot: Add documentation to undocumented parameterless functions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1134008 (owner: 10Umherirrender) [21:45:35] (03PS8) 10Jgleeson: Add CiviCRM standalone composer build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1133552 [22:11:44] (03CR) 10Pppery: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133604 (https://phabricator.wikimedia.org/T374505) (owner: 10VriaA)