[01:08:39] (03PS1) 10Wfan: fix dlocal submethod, show when not ach or direct payment like google apple and creditcard [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 [01:08:59] (03CR) 10Wfan: [C:03+2] "fix this https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1132044" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 (owner: 10Wfan) [01:09:17] (03CR) 10Wfan: [C:03+2] "fix bug introduced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1132044" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 (owner: 10Wfan) [01:11:01] (03CR) 10Wfan: fix dlocal submethod, show when not ach or direct payment like google apple and creditcard [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 (owner: 10Wfan) [01:22:03] (03PS2) 10Wfan: fix dlocal submethod, show when not ach or direct payment like google apple and creditcard [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 [01:22:43] (03CR) 10Wfan: [C:03+2] "fix bug introduced by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1132044" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 (owner: 10Wfan) [01:25:07] (03Merged) 10jenkins-bot: fix dlocal submethod, show when not ach or direct payment like google apple and creditcard [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134390 (owner: 10Wfan) [01:51:32] (03CR) 10Wfan: [C:03+2] Update Gravy PayPal Mapper to use new PaymentMethod Enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1133224 (owner: 10Jgleeson) [01:52:00] (03Merged) 10jenkins-bot: Update Gravy PayPal Mapper to use new PaymentMethod Enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1133224 (owner: 10Jgleeson) [06:33:52] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1134445 (owner: 10L10n-bot) [15:45:21] I'm not if it's jetlag or something else but I'm finding it hard to see today :| [15:45:35] symptoms feel similar to this https://www.nhs.uk/conditions/floaters-and-flashes-in-the-eyes/ [15:46:27] I've got annoying flickering lines blurring my vision. They were cool at first but now not so much [15:46:45] I'm not sure* [15:48:15] gonna go lie down for a bit to see if it clears [15:48:26] 06Fundraising-Backlog: Faircom List Clean Up - https://phabricator.wikimedia.org/T390205#10718407 (10MDemosWMF) @Eileenmcnaughton Thanks! Currently Faircom is using a static list, but we shouldn't have this problem in the future because that will be changing - possibly in the new fiscal year? @MRitch-WMF I think... [15:51:39] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07fr-acoustic: Populating both_funds_latest_donation_source field - https://phabricator.wikimedia.org/T379700#10718437 (10AKanji-WMF) [16:12:07] (03PS2) 10Eileen: Fix activity import issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134352 (https://phabricator.wikimedia.org/T390965) [16:12:10] (03CR) 10Ejegg: [C:03+2] Fix activity import issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134352 (https://phabricator.wikimedia.org/T390965) (owner: 10Eileen) [16:30:43] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1134445 (owner: 10L10n-bot) [16:32:42] (03CR) 10Ejegg: [C:04-1] "Thanks for sticking with this! The previously-mentioned issues all look resolved, but I found a couple more places that are still using mw" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1125253 (https://phabricator.wikimedia.org/T380079) (owner: 10Jdlrobson) [16:39:32] (03Merged) 10jenkins-bot: Fix activity import issue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134352 (https://phabricator.wikimedia.org/T390965) (owner: 10Eileen) [16:56:11] (03PS2) 10Eileen: Superficial follow ups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134348 [16:56:28] (03CR) 10Ejegg: [C:03+2] "Thanks for the modernization!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134348 (owner: 10Eileen) [16:57:34] (03PS2) 10Eileen: Let's try for a failmail rather than logging an alert' [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134349 [16:57:50] (03CR) 10Ejegg: "Thanks, this makes sense" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134349 (owner: 10Eileen) [16:58:28] ok, looks like that large donation notification will be ready to go out today - i should get the matching settings change ready [17:14:59] fr-tech I just pushed up a settings change to let the large donation notifications work with the new Civi code [17:15:11] if anyone wants to review it, it's in the settings repo on frpm [17:16:58] (03PS1) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1134737 [17:19:57] (03PS2) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1134737 [17:21:57] (03PS3) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1134737 [17:22:02] (03CR) 10Wfan: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1134737 (owner: 10Wfan) [17:23:36] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1134737 (owner: 10Wfan) [17:23:57] (03Merged) 10jenkins-bot: Superficial follow ups [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1134348 (owner: 10Eileen) [17:51:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: fix adyen css error - https://phabricator.wikimedia.org/T391276 (10AnnWF) 03NEW [17:59:31] (03PS1) 10Wfan: fix adyen css bug: [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134739 (https://phabricator.wikimedia.org/T391276) [17:59:58] can anyone look at this css patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1134739 will do a new di deployment to fix this [18:05:37] I'm looking wfan but even without your patch I don't see the blue label on my local [18:05:41] though I do in production [18:05:58] yeah the blue one only in prod and tested with my patch in prod by adding the new css [18:06:21] oh weird [18:06:34] i wonder if we're pulling down a different version of the Adyen js [18:07:04] let's try to make sure we're using the same version locally [18:07:57] 5.67.0 in prod [18:08:53] looks like the same in dev [18:08:59] what the heck, then? [18:09:30] the blue was there then I force it update by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1127961 this and seems like need to add the important, let me update it again~ [18:10:08] (03PS2) 10Wfan: fix adyen css bug: [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1134739 (https://phabricator.wikimedia.org/T391276) [18:15:09] both 5.67.0 Field.scss and our adyen.css have the style for focused label, so add important will make sure we use the version we want [18:15:44] ok, we can also use a more specific selector [18:16:10] i just wish I understood why I can't see the style on my local [18:17:45] hmm, perhaps it's a load order thing? [18:19:11] we preload the script but not css [18:19:23] wfan so instead of adding the !important to single properties, I think we can just make sure our style overrides theirs for everything in the selector by making the selector more specific [18:19:34] that is, we just add a parent element selector [18:20:02] ok will do [18:20:25] and we can maybe reuse the block above [18:20:32] (line 59) [18:20:43] so we don't have to repeat the color [18:21:30] Ah I see, ok [18:21:49] good catch! [18:23:15] hmm, maybe that selector is outdated? [18:23:29] It references a