[01:05:05] 06Fundraising-Backlog, 07payments-orchestration: Log 'pending' details JSON blob for all authorized Gravy transactions - https://phabricator.wikimedia.org/T392156#10750723 (10AnnWF) T381012 will help with those manual captured txn without log [02:10:39] eileen: are you still around? [02:10:47] cstone: yep [02:11:37] i might have just answered my own question but im trying to write a unit test to check for an email send [02:11:49] but i was looking at the monthly convert one but thats in ty email style [02:11:59] and i think i need to look at if we have ones that are using the other templates [02:12:44] I may be a rubber duck [02:15:18] hmm maybe we dont have any other tests doing it [02:15:27] the others are all checking activities [02:15:54] wait the other extension! [02:16:13] cstone: so you want to see if an email was sent? We have 2 ways of sending emails - the civi way & our own special way - they each have helpers... [02:16:53] yeah the recurring failure email [02:16:58] previously it was only in the smashpig extension [02:17:06] but now its escaped into the recurring queue consumer [02:17:48] FailureEmail::send() [02:18:51] lol [02:19:04] we have a test just testing the send in the smashpig extension [02:19:26] but i wanted to add it part of a bigger autorescue cancel test, that checks that the recurring is cancelled and that the email is sent [02:19:34] which would be in the civicrm extension [02:19:39] ok - so being sent via Civi - `\CRM_Utils_Mail::send($params)` [02:20:44] i guess in the smashpig test its still checking activities [02:27:36] hmm eileen does the FailureEmail::send automatically make an activity too [02:28:22] actually its missing locally so its not [02:28:28] cstone: I think so but before my hamster-brain got distracted I was looking to see if we have a precedent for checking the email - I will start doing that again :-) [02:29:40] OK - I see this in the SmashPig test // Ensure site is set to put mail into civicrm_mailing_spool table. [02:29:40] Civi::settings()->set('mailing_backend', ['outBound_option' => \CRM_Mailing_Config::OUTBOUND_OPTION_REDIRECT_TO_DB]); [02:29:40] [02:29:41] theres FailureEmailTest [02:30:51] yeah - so with the above done (which we should do in the WMFEnvironmentTrait or the listener - the emails will be saved to the civicrm_mailing_spool table for inspection [02:31:42] hmm but then the test is just looking for an acitivity unless theres another one i missed [02:31:50] there is an upstream helper class but the tests directory doesn't ship with core so we would copy some handy functions https://github.com/civicrm/civicrm-core/blob/4f297a5ddcf69a5b438b534304127665c0c7845a/tests/phpunit/CiviTest/CiviMailUtils.php#L132 [02:32:20] Right I think that line in the test is just PREVENTING any smtp attempts but the corresponding check is not being done [02:32:35] ahhh [02:36:50] (03PS1) 10Eileen: WMF Test listener - ensure mailings redirected to DB, support HookInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137094 [02:37:02] cstone: ^^ might be the place to set that setting [02:39:15] & then maybe copy enough of that `CiviMailUtils` class into `WMFEnvironmentTrait` to be able to check the mailings. I'm 50% tempted to make `getMailing()` return mailings of either type so which one we use is invisible/irrelevant [02:42:49] i got distracted looking at why it wasn't making the activity in the first place but maybe good to be able to use getmailings we are only going to get more? [02:43:55] (03PS3) 10Cstone: WIP: Also send recurring failure email on autorescue failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1135155 (https://phabricator.wikimedia.org/T386733) [02:50:44] cstone: yeah - ideally we would consolidate on the civi method cos ours is just overhead - I think the Civi one might not handle fallback smtp servers yet - I was working on that at one point but don't think I got it over the line [02:53:06] ok cool its late here for me and my brain is not the best, I'll look at this again tomorrow thanks for showing where to look eileen [02:53:45] no worries have a good sleep [03:08:36] (03CR) 10CI reject: [V:04-1] WIP: Also send recurring failure email on autorescue failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1135155 (https://phabricator.wikimedia.org/T386733) (owner: 10Cstone) [04:06:48] (03PS4) 10Eileen: mgd files to support imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136834 (https://phabricator.wikimedia.org/T386017) [04:06:48] (03PS1) 10Eileen: Upstream fix for uploaded file with template [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137096 [04:06:48] (03PS1) 10Eileen: CiviCRM upstream updates to 6.1.0 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137097 [04:37:05] 03Fundraising Sprint: Grits & Catfish, 06Fundraising-Backlog: Fidelity Mapping Import - Change in gift framework - https://phabricator.wikimedia.org/T386017#10750838 (10Eileenmcnaughton) @MDemosWMF I have deployed code updates onto staging & there is a configured Fidelity import there https://civicrm.frdev.wik... [05:33:13] (03PS5) 10Eileen: mgd files to support imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136834 (https://phabricator.wikimedia.org/T386017) [05:34:20] (03CR) 10CI reject: [V:04-1] mgd files to support imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136834 (https://phabricator.wikimedia.org/T386017) (owner: 10Eileen) [05:36:34] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136834 (https://phabricator.wikimedia.org/T386017) (owner: 10Eileen) [06:34:10] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1137134 (owner: 10L10n-bot) [07:20:14] 06Fundraising-Backlog: Switch Credit Cards from Adyen to Gravy - https://phabricator.wikimedia.org/T392147#10751005 (10RKumar_WMF) @EMartin - Is this include credit cards by dLocal too? Ty. [07:38:01] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_42) - 10https://gerrit.wikimedia.org/r/1137134 (owner: 10L10n-bot) [13:48:13] (03PS1) 10Ejegg: Add DonorPortal to new checksum link consumer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137287 (https://phabricator.wikimedia.org/T388739) [13:48:15] (03PS1) 10Ejegg: WIP API call for donor portal summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137288 (https://phabricator.wikimedia.org/T388744) [14:18:23] (03CR) 10CI reject: [V:04-1] WIP API call for donor portal summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137288 (https://phabricator.wikimedia.org/T388744) (owner: 10Ejegg) [14:49:03] (03PS2) 10Ejegg: API call for donor portal summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137288 (https://phabricator.wikimedia.org/T388744) [15:03:57] 06Fundraising-Backlog: comms pref centre; instrumenting usage - https://phabricator.wikimedia.org/T392228 (10AKanji-WMF) 03NEW [15:07:03] 10fundraising-tech-ops, 06DC-Ops, 06Infrastructure-Foundations, 10netops, and 2 others: eqiad: determine second frack - https://phabricator.wikimedia.org/T392007#10752388 (10RobH) a:03Jclark-ctr Summary from where I see things: * I think that B8 is the best choice as it requires the least amount of new i... [15:13:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi contact summary and contributions page style broken - https://phabricator.wikimedia.org/T392231 (10Damilare) 03NEW [15:31:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Potential FundraiseUp Data Integration Issue - https://phabricator.wikimedia.org/T391126#10752518 (10Damilare) Thanks for reporting this @SHust, I've been able to identify two issues one of which we would have to bring up with Fundra... [15:35:15] 06Fundraising-Backlog: Switch Credit Cards from Adyen to Gravy - https://phabricator.wikimedia.org/T392147#10752556 (10EMartin) @RKumar_WMF Yes, Dlocal should be considered as well in the cut over plan. If we need more time to test that connection, we should consider that in the cut over. [15:37:44] 10fundraising-tech-ops, 10FR-Tech-Analytics, 06Privacy Engineering, 06secscrum, 10Security Preview: Security review for python package dbt-metabase - https://phabricator.wikimedia.org/T385337#10752564 (10sbassett) a:03Mstyles [15:48:47] 10fundraising-tech-ops, 10BDC-Implementation, 10Data-Platform-SRE (2025-04-12 - 2025-05-02): [Hive] Investigate packaging, install, security monitoring. - https://phabricator.wikimedia.org/T377635#10752622 (10Gehel) [16:05:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Gr4vy audit file edge cases - https://phabricator.wikimedia.org/T381012#10752708 (10AnnWF) >>! In T381012#10748084, @MBeat33 wrote: > Another example of a donation manually settled at Adyen, still at Captu... [16:20:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Potential FundraiseUp Data Integration Issue - https://phabricator.wikimedia.org/T391126#10752786 (10SHust) @Damilare, thanks for sharing your findings! Did you happen to come across any other cases similar to the one I flagged? As w... [16:30:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Potential FundraiseUp Data Integration Issue - https://phabricator.wikimedia.org/T391126#10752846 (10Damilare) Yes @SHust, definitely not a one off as I found some that are still been charged in Fundraiseup but are cancelled on Civi.... [16:58:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Potential FundraiseUp Data Integration Issue - https://phabricator.wikimedia.org/T391126#10752989 (10SHust) Thanks for confirming! If there's no way to cancel the ones you found automatically on the FRU console, please let me know (s... [17:32:36] 06Fundraising-Backlog: Direct Mail NCOA Updates - https://phabricator.wikimedia.org/T392252 (10MDemosWMF) 03NEW [17:59:33] 10fundraising-tech-ops, 10BDC-Implementation, 07Epic: [Metabase] Switch from metabase "open source" to "enterprise" - https://phabricator.wikimedia.org/T383256#10753341 (10Jgreen) 05Invalid→03Resolved [18:05:10] 06Fundraising-Backlog: Investigate moving native apple and google pay to gravy - https://phabricator.wikimedia.org/T392259 (10Cstone) 03NEW [18:05:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices: Potential FundraiseUp Data Integration Issue - https://phabricator.wikimedia.org/T391126#10753421 (10Damilare) Hi @SHust, Here's a list of transactions that I found which are cancelled on Civi but not on Fundraiseup. I'd update this... [20:09:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Civi contact summary and contributions page style broken - https://phabricator.wikimedia.org/T392231#10753778 (10Cstone) I think this one fixed itself? [20:53:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-donorservices, 07payments-orchestration: Gr4vy audit file edge cases - https://phabricator.wikimedia.org/T381012#10753845 (10MBeat33) Many thanks, @AnnWF Noting one more settled-at-Adyen-instead-of-Gravy here, to make sure the script catches it... [21:24:57] 06Fundraising-Backlog: Setting up consolidated settlement reporting for all PSPs via Gr4vy for new recon process - https://phabricator.wikimedia.org/T391496#10753913 (10EMartin) @cstone. I floated the static column issue by Jules at Gr4vy and here's what he's asking for: // "Could you maybe send us an example of... [22:41:31] (03PS1) 10Wfan: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1137365 [22:43:16] (03CR) 10Wfan: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1137365 (owner: 10Wfan) [22:43:40] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1137365 (owner: 10Wfan) [23:29:50] (03CR) 10Cstone: [C:03+2] Rename PaymentDetailResponse to PaymentProviderExtendedResponse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136824 (https://phabricator.wikimedia.org/T383400) (owner: 10Wfan) [23:30:09] Thanks Christine~ [23:35:45] 06Fundraising-Backlog: Setting up consolidated settlement reporting for all PSPs via Gr4vy for new recon process - https://phabricator.wikimedia.org/T391496#10754123 (10Cstone) @EMartin I created a test report user in our Adyen sandbox and connected it to the Gravy sandbox, we can change anything we want in here... [23:44:16] 06Fundraising-Backlog: Rename monlthy convert to recurring convert - https://phabricator.wikimedia.org/T392274 (10Cstone) 03NEW [23:44:38] 06Fundraising-Backlog: Rename monthly convert to recurring convert - https://phabricator.wikimedia.org/T392274#10754152 (10Cstone) [23:59:01] (03Merged) 10jenkins-bot: Rename PaymentDetailResponse to PaymentProviderExtendedResponse [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1136824 (https://phabricator.wikimedia.org/T383400) (owner: 10Wfan)