[00:25:47] (03PS1) 10Ejegg: Fix handling of failed TY email sends [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137844 (https://phabricator.wikimedia.org/T392387) [00:26:03] eileen: what do you think of restoring that throw there? ^^^ [00:26:53] we could also do it as an else block after the check for 'Invalid Address' [00:27:25] but then we'd still add the activities and mark the queue entry delivered for other types of failure [01:01:57] eileen: remind me where those draft messages live these days? [01:02:26] civicrm_translation? [01:04:08] ejegg: yeah that sounds like the right table [01:04:14] just looking at that activity one [01:16:51] ejegg: where do the activities get created? [01:22:08] hmm - it's in `trackMessage` - but that's wrong cos `if` we ever turned off civimail tracking we'd still want the activities I think [01:29:15] ooh, so we create that even BEFORE we attempt the send? [01:29:25] yeah, we should wait till after [01:29:57] and also decouple from civimail tracking [01:51:14] ok, well, I can easily replicate the 'sending draft not live' bug on dev [01:51:44] so I should be able to git bisect to find when the bug came in [01:51:48] (03PS1) 10Eileen: WIP - thank you except [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137852 [01:52:04] ejegg: so I've been playing around with thishttps://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1137852 [01:52:07] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1137852 [01:54:14] - I'm just thinking about where the .module stuff should go while pondering but [01:54:15] 1) I think create Activity should move [01:54:15] 2) the whole exception box is way too complex [01:54:15] 3) the way we handle stuff is spread across legacy drush to legacy module to this function & it's weird. I guess we really have 2 layers - the batch & the individual record [01:54:46] yeah, i'm happy moving marking the noThankYou to Send [01:56:11] yeah - hopefully this coming spring the module dies [01:57:37] I'm just not quite sure about the `getEmail()` - that throws an Exception - which possibly makes sense - ie you tried to call ThankYou::send() where there is no email - maybe it is on the caller to handle an exception [01:58:34] or maybe that is a 'whatever' error & it gets swallowed in-class [01:58:45] (03Abandoned) 10Ejegg: Fix handling of failed TY email sends [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137844 (https://phabricator.wikimedia.org/T392387) (owner: 10Ejegg) [01:58:47] I suspect the UI send catches [01:59:19] so, maybe we need a new API ThankYou.BatchSend that holds what is now in the module & it will start to get simpler [02:00:11] (not sure how it all ties in with my efforts here, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1134344 - but for that I'm trying to track progress whereas a batchSend would not need to [02:00:56] BatchSend sounds like a fine way to start [02:01:39] ejegg: do you want to take a run at it or should I [02:02:00] I'm not going to be on for much longer tonight [02:02:21] but I could take a crack at it in the morning if you're working on other stuff [02:02:38] ok - I'll poke - I think I've been burrowing in this hole I'm in now for too long so context switch probably good [02:09:44] dang, I'm all the way back to commits from Nov 12 and the draft message is still being selected [02:09:56] doesn't seem to be caching related [02:10:02] as I've been flushing in between [02:10:22] but that's now failing, probably because the db is more out of sync with the code [02:17:04] dang, i'm all the way back to last August and still getting the draft sent [02:17:24] (03CR) 10CI reject: [V:04-1] WIP - thank you except [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137852 (owner: 10Eileen) [02:18:21] ok, I have to get to bed. Will take a look at your patch in the morning! [02:18:25] thanks eileen [02:27:17] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move wmf_common into an extension - probably wmf-civicrm - https://phabricator.wikimedia.org/T270681#10758230 (10Eileenmcnaughton) 05Open→03Resolved a:03Eileenmcnaughton We did this! [02:28:22] 14Fundraising Sprint: Abula, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021, 13Patch-For-Review: Finish moving wmf thank you functionality to the existing extension - https://phabricator.wikimedia.org/T270674#10758235 (10Eileenmcnaughton) 05Resolved→03Open We didn't... [02:30:40] (03PS1) 10Eileen: Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) [02:44:04] (03PS2) 10Eileen: Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) [02:44:04] (03PS1) 10Eileen: Move thankyou_for_contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137861 (https://phabricator.wikimedia.org/T270674) [02:44:05] (03PS1) 10Eileen: Move getMailingData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137862 (https://phabricator.wikimedia.org/T270674) [02:44:06] (03PS1) 10Eileen: Remove test-specific constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137863 (https://phabricator.wikimedia.org/T270674) [02:48:12] 06Fundraising-Backlog, 10fundraising-tech-ops: Can we get more MariaDB deadlock tools? - https://phabricator.wikimedia.org/T392396#10758250 (10Eileenmcnaughton) Locally `SELECT * FROM information_schema.INNODB_LOCKS ` sometimes gives something [02:53:39] (03PS1) 10Eileen: Move getMaxRenderAttempts to Thankyou:send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137866 (https://phabricator.wikimedia.org/T270674) [02:58:52] (03PS1) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) [03:08:22] (03PS2) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) [03:08:23] (03PS1) 10Eileen: Switch test api call to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137871 (https://phabricator.wikimedia.org/T270674) [03:33:47] (03CR) 10CI reject: [V:04-1] Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [03:34:12] (03CR) 10CI reject: [V:04-1] Switch test api call to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137871 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [03:36:30] (03PS1) 10Eileen: I caught some stuff with this - but not sure what it means [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137877 (https://phabricator.wikimedia.org/T392396) [03:53:17] 06Fundraising-Backlog: Cz Republic Online Banking disabled - https://phabricator.wikimedia.org/T392393#10758304 (10Cstone) Looks like the bank dropdown is back, @EMartin do we have someone in CZ that could do a test donation? [04:01:02] (03PS3) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) [04:35:08] (03PS3) 10Eileen: Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) [04:35:08] (03PS2) 10Eileen: Move thankyou_for_contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137861 (https://phabricator.wikimedia.org/T270674) [04:35:08] (03PS2) 10Eileen: Move getMailingData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137862 (https://phabricator.wikimedia.org/T270674) [04:35:08] (03PS2) 10Eileen: Remove test-specific constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137863 (https://phabricator.wikimedia.org/T270674) [04:35:09] (03PS2) 10Eileen: Move getMaxRenderAttempts to Thankyou:send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137866 (https://phabricator.wikimedia.org/T270674) [04:35:11] (03PS4) 10Eileen: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) [04:35:15] (03PS2) 10Eileen: Switch test api call to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137871 (https://phabricator.wikimedia.org/T270674) [04:35:19] (03PS1) 10Eileen: Add BatchSend test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137887 (https://phabricator.wikimedia.org/T270674) [14:23:29] 06Fundraising-Backlog: Cz Republic Online Banking disabled - https://phabricator.wikimedia.org/T392393#10758772 (10EMartin) @RKumar_WMF Can we get a CZ tester to try Bank Transfer? [14:36:59] (03CR) 10Ejegg: [C:03+2] Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [14:46:11] (03CR) 10Ejegg: [C:03+2] Move thankyou_for_contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137861 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [14:49:18] (03CR) 10Ejegg: [C:03+2] Move getMailingData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137862 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [14:50:19] (03CR) 10Ejegg: [C:03+2] Remove test-specific constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137863 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [14:54:50] (03CR) 10Ejegg: [C:03+2] Move getMaxRenderAttempts to Thankyou:send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137866 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:04:56] (03CR) 10Ejegg: [C:03+2] "lil more cleanup could follow on" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:16] (03CR) 10CI reject: [V:04-1] Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:18] (03CR) 10CI reject: [V:04-1] Move thankyou_for_contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137861 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:19] (03CR) 10CI reject: [V:04-1] Move getMailingData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137862 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:20] (03CR) 10CI reject: [V:04-1] Remove test-specific constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137863 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:21] (03CR) 10CI reject: [V:04-1] Move getMaxRenderAttempts to Thankyou:send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137866 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:22] (03CR) 10CI reject: [V:04-1] Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:07:56] (03CR) 10Ejegg: [C:03+2] Switch test api call to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137871 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:12:51] (03CR) 10Ejegg: [C:03+2] Add BatchSend test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137887 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:14:33] oh shoot, what's that V-1 about? [15:15:45] arrr, build timed out [15:17:14] (03CR) 10Ejegg: [V:03+2 C:03+2] Move guts of drush script to CiviCRM api [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137860 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [15:23:35] (03PS1) 10Ejegg: More TY test cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138091 [16:00:51] (03Merged) 10jenkins-bot: Move thankyou_for_contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137861 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:00:53] (03Merged) 10jenkins-bot: Move getMailingData [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137862 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:27:56] (03Merged) 10jenkins-bot: Remove test-specific constant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137863 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:27:59] (03Merged) 10jenkins-bot: Move getMaxRenderAttempts to Thankyou:send [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137866 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:28:02] (03Merged) 10jenkins-bot: Superficial clean up in test class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137867 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:28:05] (03Merged) 10jenkins-bot: Switch test api call to v4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137871 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [16:47:34] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07fr-direct-mail: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#10758902 (10AKanji-WMF) Targeting to review Sprint H [16:52:45] (03Merged) 10jenkins-bot: Add BatchSend test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137887 (https://phabricator.wikimedia.org/T270674) (owner: 10Eileen) [17:05:31] (03PS2) 10Ejegg: WIP - thank you exception handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137852 (https://phabricator.wikimedia.org/T392387) (owner: 10Eileen) [17:06:56] (03PS3) 10Ejegg: WIP - thank you exception handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137852 (https://phabricator.wikimedia.org/T392387) (owner: 10Eileen) [17:07:19] fr-tech we've got a pretty good idea why the failed TY sends keep getting retried (and keep creating activities) [17:07:47] I've rebased and updated eileen's WIP patch ^^^ [17:08:08] would be nice to have more eyes on that if anyone is free [17:08:34] Nice ejegg but today is a global holiday for Earth Day [17:09:32] oh wow! [17:09:37] hah, I totally missed that [17:09:42] ok, I should take it easy then [17:10:21] also, I really hope I pushed all my local wmff changes up to gerrit, because I jsut deleted and recloned by mistake in setup.sh :( [17:18:25] Nuuu ejegg [17:18:47] Yeah just why if no one would respond to your review requests [20:20:35] ejegg|away: I'm about [20:22:56] (03PS1) 10Eileen: Thank you test fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138104 [20:27:38] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1138105 [20:48:17] (03CR) 10Pcoombe: [C:03+2] "Looks good to me. Thanks!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133604 (https://phabricator.wikimedia.org/T374505) (owner: 10VriaA) [20:48:40] (03CR) 10CI reject: [V:04-1] Thank you test fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138104 (owner: 10Eileen) [20:51:38] (03Merged) 10jenkins-bot: Replace spaces with underscores in filter box input [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1133604 (https://phabricator.wikimedia.org/T374505) (owner: 10VriaA) [20:55:04] (03Abandoned) 10Eileen: Thank you test fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138104 (owner: 10Eileen) [20:56:05] (03PS1) 10Eileen: Remove drupal variable, minor cleanup [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138107 (https://phabricator.wikimedia.org/T392387) [20:56:05] (03PS1) 10Eileen: Set up consolidatation [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138108 (https://phabricator.wikimedia.org/T270624) [20:57:00] 06Fundraising-Backlog, 14Fundraising-Backlog-Old, 10MediaWiki-extensions-CentralNotice: CentralNotice audit log should reuse core logging - https://phabricator.wikimedia.org/T97381#10759050 (10Pcoombe) →14Duplicate dup:03T32009 [21:21:01] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Avoid the increasing length of Special:CentralNotice - https://phabricator.wikimedia.org/T153230#10759101 (10Pcoombe) →14Duplicate dup:03T328424 [21:21:03] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Move archived CentralNotice campaigns to a separate page - https://phabricator.wikimedia.org/T328424#10759103 (10Pcoombe) [21:32:40] (03Abandoned) 10Eileen: WIP: Add test for recurring failure email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137379 (https://phabricator.wikimedia.org/T386733) (owner: 10Cstone) [21:59:02] (03PS1) 10Eileen: Extract startTime, endTime, timeLimit to simplify main flow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138111 (https://phabricator.wikimedia.org/T270624) [21:59:04] (03PS1) 10Eileen: Fix batchSendTest to test something [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138112 (https://phabricator.wikimedia.org/T270624) [21:59:05] (03PS1) 10Eileen: Extract, move & test activity Create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138113 (https://phabricator.wikimedia.org/T270624) [22:15:45] (03PS1) 10Eileen: Clean up thank you exception handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138116 (https://phabricator.wikimedia.org/T392387) [22:17:43] (03PS1) 10Eileen: Include previous exception as part of construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138117 [22:31:12] (03PS4) 10Eileen: Clean up thank you exception handling [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137852 (https://phabricator.wikimedia.org/T392387) [22:31:12] (03PS2) 10Eileen: Include previous exception as part of construct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138117 [22:31:12] (03PS1) 10Eileen: Remove missing data cruft [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138118 [22:31:12] (03PS1) 10Eileen: Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138119 (https://phabricator.wikimedia.org/T270624) [23:00:00] (03CR) 10CI reject: [V:04-1] Remove missing data cruft [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138118 (owner: 10Eileen) [23:03:04] (03CR) 10CI reject: [V:04-1] Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138119 (https://phabricator.wikimedia.org/T270624) (owner: 10Eileen) [23:51:49] (03PS2) 10Eileen: Remove unused variable [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138119 (https://phabricator.wikimedia.org/T270624) [23:51:49] (03PS2) 10Eileen: Remove missing data cruft [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138118 [23:51:49] (03PS1) 10Eileen: Do not check the message age - we only just loaded it [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1138124