[00:00:55] cstone: the new activity types are passing now https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1139928 [00:12:35] (03PS4) 10Eileen: Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 [00:14:44] OK - I'm having some trouble getting ^^ to show up on existing sites but it works when rebuilding (although I hit a different problem on rebuilding) - but I think merging it will reduce confusion [00:14:57] (03PS1) 10Ejegg: Use contact_id for consistency in getDonorSummary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139954 [00:21:46] (03CR) 10Eileen: [C:03+2] Use contact_id for consistency in getDonorSummary (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139954 (owner: 10Ejegg) [00:22:11] (03PS1) 10Ejegg: Add CiviProxy config for donor portal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1139955 (https://phabricator.wikimedia.org/T388745) [00:26:06] (03PS2) 10Ejegg: Use contact_id for consistency in getDonorSummary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139954 [00:26:10] (03PS1) 10Eileen: Fix handling for whitespace in csv [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139956 [00:26:22] oh oops, I added another fix after your C+2 [00:26:31] & ^^ is the second of the issues that was really confusing for demo-ing [00:26:58] ejegg: ok - tbh I think we might have 2 standards we are consolidating on - but I figured your case was strong enough to OK that one [00:27:25] yeah, I originally wrote it to be contactID for consitency with newer stuff [00:27:53] yeah - would probably need a deeper audit [00:27:55] but then when I was making the settings for civiproxy I saw that the other two proxied calls use the _ version [00:29:19] unfortunately I added in an unrelated fix and pushed a PS2 so that would have removed your C+2 [00:30:23] the switch from name to abbr [00:30:37] (03CR) 10Eileen: [C:03+2] Use contact_id for consistency in getDonorSummary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139954 (owner: 10Ejegg) [00:30:49] yep, as it's :abbr we [00:30:58] actually select above [00:31:31] thank you! [00:32:19] so speaking of consistency - this is wfan's patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1135845 - overall looking good - my big question is how does the action `WMFContact::update` fit into our actions selection - given WMFContact::save is basically not really a generic action but more part of the queues behaviour set but it DOES have an update path within it [00:32:41] ALSO - it uses contactID... [00:33:09] argh! [00:33:21] Is it more accurate for that api to be PreferenceCentre::update [00:33:46] WMFContact::updateCommunicationsPreferences? [00:34:19] I guess it just feels weird to me to have there be a PreferenceCent[er][re] pseudo-entity in Civi [00:34:34] even though it was me who made it initially [00:34:46] well given you have recently added `getDonorSummary()` in there I think more WMF actions make sense [00:35:26] I think WMFContact: updateCommunicationsPreferences sounds good to me~ [00:35:42] if eileen you feel the same I will do the update then~ [00:35:46] I think the status of the `save()` action is a bit confusing - cos it was once thought to be a generic action but now it really is about the queues & I think that is good [00:35:52] I'm OK with that name [00:36:09] ejegg: does wfan patch change any of the other work you are doing? [00:36:15] nope eileen [00:36:22] ok cool [00:36:44] cool, thanks both~ I will do the update then~ [00:37:06] wfan: looks like the test class might need a rename too [00:37:41] sure [00:37:45] maybe not actually [00:37:48] (03PS5) 10Eileen: Make SetTimeOfDayIfStockDonation non-static [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139204 (https://phabricator.wikimedia.org/T359219) [00:37:50] (03CR) 10Ejegg: [C:03+2] Make SetTimeOfDayIfStockDonation non-static [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139204 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [00:37:58] I think it matches a different api name [00:39:34] (03PS5) 10Eileen: Extract inValidateModeDoNotRequireTotalAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139205 (https://phabricator.wikimedia.org/T359219) [00:39:37] (03CR) 10Ejegg: [C:03+2] Extract inValidateModeDoNotRequireTotalAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139205 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [00:41:49] fr-tech did anyone make a phab to remind ourselves to deal with the issue that the recurring upgrade TY mail is setting the thankyou_date? [00:45:23] (03PS19) 10Wfan: Replace use api3 to api4 for epc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1135845 (https://phabricator.wikimedia.org/T386871) [00:46:15] ejegg: I don't think so - I created a gerrit to add new activity types & was thinking I'd take a look once that was deployed (ie wait until the Managed.reconcile was done so I could be sure I wouldn't hit deployment issues) [00:47:16] we have one as this https://phabricator.wikimedia.org/T392962 [00:47:21] for monthly convert date [00:48:48] (03Merged) 10jenkins-bot: Use contact_id for consistency in getDonorSummary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139954 (owner: 10Ejegg) [00:56:28] (03Merged) 10jenkins-bot: Make SetTimeOfDayIfStockDonation non-static [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139204 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [00:57:30] (03Merged) 10jenkins-bot: Extract inValidateModeDoNotRequireTotalAmount [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139205 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [01:06:27] (03PS5) 10Eileen: Benevity import feature 1 - filter not-shared-info [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139206 (https://phabricator.wikimedia.org/T359219) [01:06:28] (03PS5) 10Eileen: Minor function extractions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139207 [01:06:28] (03PS5) 10Eileen: Benevity feature 2 - field transformations on Gift Sourc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139208 (https://phabricator.wikimedia.org/T359219) [01:06:28] (03PS4) 10Eileen: Extract Fidelity wrangling to own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139575 [01:06:29] (03PS5) 10Eileen: Extract & remove ensureTrxnIdentifiersSet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) [01:06:31] (03PS5) 10Eileen: Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) [01:06:35] (03PS3) 10Eileen: Bulk of the Benevity logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) [01:06:39] (03PS4) 10Eileen: Add Benevity mgd file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139209 [01:06:56] WHY does gerrit declare things that are NOT in conflict as being in conflict these days!!! [01:18:13] Hmm - when I try to fill in the epc form I get There was an error processing your request. Please contact donate@wikimedia.org or click here to try again. - I did setup.sh on civiproxy & preference_centre - what else to I need to update - maybe I'll resort to --full [01:28:33] (03CR) 10Wfan: [C:03+2] Add new activity types for recurring convert, eoy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139928 (owner: 10Eileen) [01:30:11] hmm eileen it can be fiddly in various places [01:30:23] let me see what logs might have clues [01:30:51] ejegg: well I'm doing a full rebuild now - which I have not done for a long time.... [01:30:57] I'd want to see what request the epc made to civiproxy and try running that against the civiproxy endpoint directly [01:31:08] 06Fundraising-Backlog: TY email with thank you date - https://phabricator.wikimedia.org/T392962#10778725 (10AnnWF) [01:31:16] ah ok, let me know if it's still failing after that [01:31:22] ok - will do [01:32:25] I think I'm gonna push up the instances.yml config I have for a wordpress site - I tend to keep the site around for testing & do a lot of git faffing not to lose my config [01:32:44] ok [01:32:54] Hi eileen I plused 2 the new activity type and update this ticket for both mc and recurring upgrade TY mail is setting the thankyou_date issue [01:32:57] ah right, i notice that gets overwritten though [01:33:17] on civibuild running [01:33:36] ejegg: instances.yml gets updated sometimes but does keep the info that is in it [01:34:16] ah maybe it's just a reformat then? [01:34:20] Hmm I'd love to get rid of the web out of dmaster path - that comes from there - I wonder how disruptive that would be for everyone else though [01:34:32] oh year reformat - there is a fight on about the number of spaces in it.... [01:34:46] i don't think the rest of us do anything on dmaster [01:35:41] ok I might change it [01:38:00] ejegg: this port https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1139929 would be good to get merged - it's working for me but it doesn't always 'pick up' - I think I can nurse it through on prod tho [01:38:35] (03PS2) 10Eileen: WMF Test listener - ensure mailings redirected to DB, support HookInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1137094 [01:39:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy credit card with 3d secure - https://phabricator.wikimedia.org/T392969 (10AnnWF) 03NEW [01:39:35] button, button [01:39:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy credit card with 3d secure - https://phabricator.wikimedia.org/T392969#10778737 (10AnnWF) [01:40:02] (03CR) 10Ejegg: [C:03+2] Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 (owner: 10Eileen) [01:42:36] hmm Error: The DonationInterface extension cannot be loaded. Check that all of its files are installed properly. [01:44:01] - that's on the Donut install part [01:46:05] (03Merged) 10jenkins-bot: Add new activity types for recurring convert, eoy [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139928 (owner: 10Eileen) [01:50:40] also on civiproxy - Required package "wikimedia/smash-pig" is in the lock file as "v0.9.5" but that does not satisfy your constraint "0.9.5.1". [01:51:58] (03PS2) 10Wfan: Add a placeholder phone number for gravy india card payment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1139592 (https://phabricator.wikimedia.org/T391970) [01:52:58] oh hmm, let's see [01:53:14] civiproxy itself shouldn't need smashpig [01:54:16] ejegg: ah - so I guess it went into the dir & ran it & got a higher dir [01:55:04] or ... some dir [01:55:20] oh we do need to update the composer.lock file in the root of mediawiki's fundraising/REL1_43 branch [01:57:01] (03PS1) 10Eileen: Run composer update on privateBin [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/1139958 [01:57:17] ok so ^^ is one of the composer things that was failing ^^ [01:58:34] (03PS1) 10Ejegg: Update composer.lock [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1139959 [01:58:52] ok, and ^^^ should fix the other one I hope [01:59:30] eileen: are we checking in all of vendor for privatebin? [01:59:36] (03CR) 10CI reject: [V:04-1] Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 (owner: 10Eileen) [01:59:43] looks like a cache dir added there too [02:00:10] ejegg: yeah we should ignore that! [02:00:23] oh no, testBatchSend failing! [02:00:41] I made a slight change to that to make message_limit=0 mean unlimited [02:00:53] and we briefly saw that same odd error [02:01:05] attempted / succeeded being 0 instead of 2 [02:01:21] but then it re-ran gate-and-submit and merged it [02:01:47] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1139921 [02:01:58] (03PS2) 10Eileen: Run composer update on privateBin [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/1139958 [02:03:10] yeah - I have seen that timeout intermittently - when I stepped through I just once seemed to find timeLimit unset but could not re-replicate it [02:03:11] ah eileen maybe try with --no-dev? Looks like phpunit got added [02:03:16] ah! [02:03:22] we've been keeping that out of deploy [02:03:38] (03PS3) 10Eileen: Run composer update on privateBin [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/1139958 [02:03:56] that looks cleaner!!! [02:04:07] much :) [02:04:29] (03CR) 10Ejegg: [C:03+2] Run composer update on privateBin [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/1139958 (owner: 10Eileen) [02:05:35] (03CR) 10Ejegg: [V:03+2 C:03+2] Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 (owner: 10Eileen) [02:05:41] (03PS5) 10Eileen: Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 [02:05:55] (03CR) 10Ejegg: [V:03+2 C:03+2] Port lost buttons [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139929 (owner: 10Eileen) [02:06:09] (03PS6) 10Eileen: Benevity import feature 1 - filter not-shared-info [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139206 (https://phabricator.wikimedia.org/T359219) [02:06:11] (03CR) 10Ejegg: [C:03+2] Benevity import feature 1 - filter not-shared-info [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139206 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [02:06:42] (03PS6) 10Eileen: Minor function extractions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139207 [02:06:44] (03CR) 10Ejegg: [C:03+2] Minor function extractions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139207 (owner: 10Eileen) [02:06:45] ok so ejegg donut so which dir do I pull this in from ? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1139959 [02:07:05] sorry - not ejegg donut :-) [02:07:31] ah yeah, donut uses main-branch mediawiki now not fundraising/ [02:07:48] since they've added stuff to CentralNotice that breaks on 1.43 [02:08:35] that patch would be to fix the smashpig mismatch error message on I think epc and payments [02:11:04] OK - I'm getting confused - should I be pulling down that patch & if so from where, relative to fundraising-dev? [02:11:33] in src/payments and also in src/email-pref-ctr [02:11:45] since they both use fundraising/REL1_43 branch of mediawiki [02:12:11] wfan we should try to keep that lock file up to date when we change the smashpig version [02:13:44] Noted~ you mean smashpig version update in DI right [02:14:50] yep when we merge the DI update to deployment we should also update the composer.lock in our branch of mediawiki [02:14:53] (03CR) 10Eileen: [C:03+2] Update composer.lock [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1139959 (owner: 10Ejegg) [02:19:53] (03PS6) 10Eileen: Benevity feature 2 - field transformations on Gift Sourc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139208 (https://phabricator.wikimedia.org/T359219) [02:19:55] (03CR) 10Ejegg: [C:03+2] Benevity feature 2 - field transformations on Gift Sourc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139208 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [02:20:20] unfortunately no improvement in the EPC submit [02:21:03] & logs dir has stayed empty after I deleted files in it [02:23:05] not even an email-pref-ctr-apache-error.log file ? [02:23:18] hmm, mine has some deprecation warnings in it! [02:24:37] so should the url be https://localhost:9002/ or https://wmf.localhost:9002/ [02:25:35] (03Merged) 10jenkins-bot: Update composer.lock [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1139959 (owner: 10Ejegg) [02:25:37] my latest test contact has an epc URL of this: [02:26:05] https://localhost:9002/index.php?title=Special:EmailPreferences/emailPreferences&contact_id=207&checksum=9d23073fd8bf830b2a991017567bbe20_1745979949_168&email=jwales%40example.com&hash=274245789fe4a0724c66b0151e067c6916cd113a [02:26:39] so yeah, localhost:9002 [02:26:52] ok - looks similar - just not triggering my ide debug without the wmff in the url [02:29:52] (03PS1) 10Ejegg: Consistently use setPageTitleMsg [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1139961 [02:30:13] eileen: but your logs dir doesn't even have the access logs? [02:30:53] civiproxy-apache-access.log e.g. [02:31:12] no - they didn't come back after I deleted them - but I now have an error log [02:31:45] eileen@laptop:~/dev/fundraising-dev/logs$ more email-pref-ctr-syslog [02:31:45] 2025-04-30T02:28:35+00:00 fd96a4e942ad CiviproxyConnector: contact id: 123, Serv [02:31:45] er error: `GET https://civiproxy:9001/rest.php?entity=civiproxy&action=getprefer [02:31:45] ences&key=SITE_KEY&api_key=API_KEY&version=3&json=1&checksum=295f8d4d24af24710ea [02:31:45] e67d19c48f9a1_1745979038_168&contact_id=123` resulted in a `500 Internal Server [02:31:54] hmm, I wonder if the rsyslog container is writing to some discarded file handles or something? [02:32:46] I'll down & up the container [02:33:29] the main civiproxy get DOES work [02:34:37] it's on save I hit an error [02:34:50] & it doesn't seem to involve civiproxy at that point [02:35:46] oh hmm, so the save doesn't go through the proxy [02:36:02] it sends a queue message [02:36:07] ok - now I have log noise - filtering through ... [02:36:08] PHP Deprecated: Use of MediaWiki\Output\OutputPage::setPageTitle with Message argument was deprecated in MediaWiki 1.41. [Called from EmailPreferences::setPageTitle] [02:36:23] heh, yep, that's this fix: https://gerrit.wikimedia.org/r/1139961 [02:37:42] ejegg: that looks good - are we sure that fn always exists now? [02:37:55] yeah, ever since MW 1.41 [02:38:23] and the extension.json for DonationInterface says that's the min required version now [02:38:53] ok & which dir do I patch with that? [02:39:20] src/email-pref-ctr/extensions/DonationInterface [02:39:43] gonna have to hang it up soon... [02:40:34] ejegg: yeah I can keep tinkering with this - appreciate the reduction of the benevity chain [02:40:55] so the queue message is not sent - anywhere I should look for that happening (not) [02:43:02] Here's the line of code where it would send: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/special/EmailPreferences.php$302 [02:43:13] (03Merged) 10jenkins-bot: Benevity import feature 1 - filter not-shared-info [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139206 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [02:43:17] (03Merged) 10jenkins-bot: Minor function extractions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139207 (owner: 10Eileen) [02:43:21] (03Merged) 10jenkins-bot: Benevity feature 2 - field transformations on Gift Sourc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139208 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [02:44:09] thanks! [02:47:22] (03CR) 10Eileen: [C:03+2] Consistently use setPageTitleMsg [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1139961 (owner: 10Ejegg) [02:47:38] ejegg: well that patch helped with the noise ^^ [02:48:13] (03CR) 10Eileen: [V:03+2] Run composer update on privateBin [wikimedia/fundraising/privatebin] - 10https://gerrit.wikimedia.org/r/1139958 (owner: 10Eileen) [02:49:52] (03Merged) 10jenkins-bot: Consistently use setPageTitleMsg [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1139961 (owner: 10Ejegg) [02:50:56] :) thanks! [02:51:29] gnight [03:05:39] ok got the error [message:protected] => php_network_getaddresses: getaddrinfo for donorprefsqueues failed: Temporary failure in name resolution [tcp://donorprefsqueues:6379] - gonna step away for a bit & then regroup [06:40:02] (03PS1) 10Eileen: Slight tweak to Fidelity mapping [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1140073 [06:49:32] If someone is around it would be good to merge ^^ before I deploy the Fidelity updates so the mapping is accurate in the first instance (rather than requiring a tweak via the UI) [11:19:22] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1140073 (owner: 10Eileen) [11:37:36] (03Merged) 10jenkins-bot: Slight tweak to Fidelity mapping [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1140073 (owner: 10Eileen) [12:55:58] !log config revision changed from 817b0c94 to 45e49fec [12:56:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:09:01] (03PS5) 10Eileen: Extract Fidelity wrangling to own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139575 [14:09:18] (03CR) 10Ejegg: [C:03+2] Extract Fidelity wrangling to own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139575 (owner: 10Eileen) [14:11:40] (03PS6) 10Eileen: Extract & remove ensureTrxnIdentifiersSet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) [14:11:44] (03CR) 10Ejegg: [C:03+2] Extract & remove ensureTrxnIdentifiersSet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [14:14:08] (03PS6) 10Eileen: Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) [14:14:19] (03CR) 10Ejegg: [C:03+2] Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [14:29:58] (03CR) 10CI reject: [V:04-1] Extract Fidelity wrangling to own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139575 (owner: 10Eileen) [14:30:00] (03CR) 10CI reject: [V:04-1] Extract & remove ensureTrxnIdentifiersSet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [14:30:00] (03CR) 10CI reject: [V:04-1] Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [14:30:50] (03CR) 10Ejegg: [V:03+2 C:03+2] Extract Fidelity wrangling to own function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139575 (owner: 10Eileen) [14:43:27] (03CR) 10CI reject: [V:04-1] Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [14:56:17] (03PS4) 10Eileen: Bulk of the Benevity logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) [14:56:21] (03CR) 10Ejegg: [C:03+2] Bulk of the Benevity logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [15:18:14] (03CR) 10CI reject: [V:04-1] Extract & remove ensureTrxnIdentifiersSet [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [15:18:15] (03CR) 10CI reject: [V:04-1] Wait until end to transfer contact_id to the contribution [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [15:18:16] (03CR) 10CI reject: [V:04-1] Bulk of the Benevity logic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [15:21:21] oh dang, gerrit's down [15:22:27] k, will work locally for a bit [15:30:44] 10fundraising-tech-ops, 06DC-Ops, 10ops-codfw, 06SRE: Possible frdb2004 hardware failure. - https://phabricator.wikimedia.org/T392579#10780837 (10Jgreen) 05Open→03Resolved >>! In T392579#10777103, @Jhancock.wm wrote: > @Jgreen reseated all the connections to the backplane. server came up. I checked... [15:54:52] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07payments-orchestration: LATAM test issues - Gr4vy - https://phabricator.wikimedia.org/T392677#10780974 (10RKumar_WMF) Gr4vy: eb5077b4-295b-4886-831b-da1696265d6c - Why this is not found in Adyen. Apple pay transaction. Also not found in Buyers tab in... [15:57:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 07payments-orchestration: LATAM test issues - Gr4vy - https://phabricator.wikimedia.org/T392677#10780977 (10AnnWF) Checking >>! In T392677#10780974, @RKumar_WMF wrote: > Gr4vy: eb5077b4-295b-4886-831b-da1696265d6c - Why this is not found in Adyen. Appl... [16:00:17] (03PS4) 10Jgleeson: Fix bugs in Gravy donation queue message builder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1139564 (https://phabricator.wikimedia.org/T381012) [16:01:23] (03CR) 10Jgleeson: [C:03+2] "Self-merging Maintenance script to test on staging." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1139564 (https://phabricator.wikimedia.org/T381012) (owner: 10Jgleeson) [16:01:57] (03Merged) 10jenkins-bot: Fix bugs in Gravy donation queue message builder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1139564 (https://phabricator.wikimedia.org/T381012) (owner: 10Jgleeson) [16:03:33] (03PS1) 10Damilare Adedoyin: Add comments to Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140213 [16:04:00] (03CR) 10CI reject: [V:04-1] Add comments to Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140213 (owner: 10Damilare Adedoyin) [16:04:05] (03PS2) 10Damilare Adedoyin: Add comments and remove unused functions in Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140213 [16:05:00] (03CR) 10CI reject: [V:04-1] Add comments and remove unused functions in Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140213 (owner: 10Damilare Adedoyin) [16:19:16] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 13Patch-For-Review: Apple Pay enablement across all browsers - https://phabricator.wikimedia.org/T382279#10781084 (10AnnWF) We go fully gravy apple pay last couple weeks, so this is no longer needed. [16:31:18] (03PS1) 10Damilare Adedoyin: Add comments to Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140221 [16:31:48] (03PS2) 10Damilare Adedoyin: Add comments and remove unused methods in Validator classes [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1140221 [16:36:35] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 13Patch-For-Review: Apple Pay enablement across all browsers - https://phabricator.wikimedia.org/T382279#10781233 (10EMartin) Great news @AnnWF ! [16:42:59] (03PS1) 10Jgleeson: Fix bugs in Gravy donation queue message builder [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140224 (https://phabricator.wikimedia.org/T381012) [16:43:01] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140225 [16:44:47] (03CR) 10Jgleeson: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140225 (owner: 10Jgleeson) [16:50:07] (03CR) 10Jgleeson: [C:03+2] Fix bugs in Gravy donation queue message builder [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140224 (https://phabricator.wikimedia.org/T381012) (owner: 10Jgleeson) [16:51:32] (03Merged) 10jenkins-bot: Fix bugs in Gravy donation queue message builder [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140224 (https://phabricator.wikimedia.org/T381012) (owner: 10Jgleeson) [16:51:37] (03PS2) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140225 [16:58:45] hmm gerrit weirdness [16:59:21] (03Abandoned) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1140225 (owner: 10Jgleeson) [17:06:53] jgleeson: yeah. prod sre are aware of if and going some more work on it. [17:06:59] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 10MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), 07payments-orchestration: Gravy dLocal Internal Test Plan - https://phabricator.wikimedia.org/T389547#10781367 (10AnnWF) [17:07:07] oh right [17:07:11] argh [17:18:40] PROBLEM - Host frban2002 is DOWN: PING CRITICAL - Packet loss = 100% [17:20:25] From Antoine (hashar) re Gerrit: We have shutdown Gerrit due to data being invalid between the instances. Task is https://phabricator.wikimedia.org/T393034 and we are working on it. [17:23:42] RECOVERY - Host frban2002 is UP: PING OK - Packet loss = 0%, RTA = 30.23 ms [17:31:32] 06Fundraising-Backlog: Refund shows as contribution line without original contribution line - https://phabricator.wikimedia.org/T393036 (10RKumar_WMF) 03NEW [17:32:34] 06Fundraising-Backlog: GRAVY f6f79711-9e3f-4436-89f2-83d6f2f1f8e8 - backend processor missing - https://phabricator.wikimedia.org/T393037 (10RKumar_WMF) 03NEW [17:36:50] ty greg-g [17:39:26] 06Fundraising-Backlog, 06FR-donorrelations: Civi Thank You email check April 29 - https://phabricator.wikimedia.org/T392947#10781522 (10MBeat33) 05Open→03Resolved a:03MBeat33 [17:46:02] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Ignore fraud check for recurring trxns - https://phabricator.wikimedia.org/T393040 (10AnnWF) 03NEW [18:19:36] PROBLEM - Host payments2006 is DOWN: PING CRITICAL - Packet loss = 100% [18:24:38] PROBLEM - Host payments2004 is DOWN: PING CRITICAL - Packet loss = 100% [18:24:38] RECOVERY - Host payments2006 is UP: PING OK - Packet loss = 0%, RTA = 30.38 ms [18:27:12] RECOVERY - Host payments2004 is UP: PING OK - Packet loss = 0%, RTA = 30.28 ms [18:28:05] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Migrating recurring donors off of Fundraise UP - https://phabricator.wikimedia.org/T390331#10781728 (10greg) Status update: Gravy supplied us with the PCI AoC today, Dami forwarded it to Stripe. [18:58:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Please set a default rule in donation_rules.yaml in logs for gravy transactions - https://phabricator.wikimedia.org/T392544#10781814 (10jgleeson) We fixed this by adding a default currency to the gravy config. [19:42:02] PROBLEM - Host payments1006 is DOWN: PING CRITICAL - Packet loss = 100% [19:46:08] RECOVERY - Host payments1006 is UP: PING OK - Packet loss = 0%, RTA = 0.46 ms [19:58:37] PROBLEM - Host payments1005 is DOWN: PING CRITICAL - Packet loss = 100% [20:02:11] RECOVERY - Host payments1005 is UP: PING OK - Packet loss = 0%, RTA = 0.57 ms [20:15:23] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap, 07Epic: Ensure Fundraiseup recurring record have the Processor ID - https://phabricator.wikimedia.org/T392808#10781950 (10Damilare) [20:17:39] 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Discuss Token migration and requirements with Gravy - https://phabricator.wikimedia.org/T391982#10781952 (10Damilare) Gravy reassured us that they have done a similar export with Stripe and Philip was assigned to us as the manager on Grav... [20:18:00] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Discuss Token migration and requirements with Gravy - https://phabricator.wikimedia.org/T391982#10781953 (10Damilare) [20:20:16] 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Credit cards - https://phabricator.wikimedia.org/T391990#10781961 (10Damilare) Gravy provided the PCI document as requested by Stripe. Now awaiting next steps from Stripe. [20:21:10] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Credit cards - https://phabricator.wikimedia.org/T391990#10781962 (10Damilare) [20:21:31] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: PayPal - https://phabricator.wikimedia.org/T392021#10781963 (10Damilare) [20:21:56] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Credit cards - Import tokens to Civi - https://phabricator.wikimedia.org/T391991#10781965 (10Damilare) [20:22:17] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Apple Pay and Google Pay - https://phabricator.wikimedia.org/T391996#10781966 (10Damilare) [20:22:33] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: PayPal - Import tokens to Civi - https://phabricator.wikimedia.org/T392025#10781967 (10Damilare) [20:23:11] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Credit cards - https://phabricator.wikimedia.org/T391990#10781968 (10Damilare) a:03Damilare [20:23:18] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Credit cards - Import tokens to Civi - https://phabricator.wikimedia.org/T391991#10781970 (10Damilare) a:03Damilare [20:23:39] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: Apple Pay and Google Pay - https://phabricator.wikimedia.org/T391996#10781971 (10Damilare) a:03Damilare [20:23:50] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: PayPal - https://phabricator.wikimedia.org/T392021#10781972 (10Damilare) a:03Damilare [20:23:58] 03Fundraising Sprint: Hot Pot!, 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap: Payment method migration: PayPal - Import tokens to Civi - https://phabricator.wikimedia.org/T392025#10781973 (10Damilare) a:03Damilare [20:25:46] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap: Migrating recurring donors off of Fundraise UP - https://phabricator.wikimedia.org/T390331#10781975 (10Damilare) [20:25:48] 06Fundraising-Backlog, 07Fundraising-FRUP, 06Fundraising-Tech-Roadmap, 07Epic: Fundraiseup migration - https://phabricator.wikimedia.org/T391961#10781976 (10Damilare) [20:49:58] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139586 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [20:57:33] (03Abandoned) 10Jgleeson: WIP: Fix issues in donation message build script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1139564 (https://phabricator.wikimedia.org/T381012) (owner: 10Jgleeson) [21:09:08] (03PS1) 10Umherirrender: tests: Rename data provider to start with provide [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1140233 [21:12:06] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [21:14:07] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [21:14:37] (03PS5) 10Eileen: Add Benevity mgd file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139209 [21:15:09] ejegg: I just rebased ^^ on master since it doesn't actually rely on the other 2 to be mergeable [21:20:12] (03CR) 10Ejegg: [C:03+2] Add Benevity mgd file (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139209 (owner: 10Eileen) [21:29:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Refund shows as contribution line without original contribution line - https://phabricator.wikimedia.org/T393036#10782180 (10AnnWF) [21:29:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: GRAVY f6f79711-9e3f-4436-89f2-83d6f2f1f8e8 - backend processor missing - https://phabricator.wikimedia.org/T393037#10782181 (10AnnWF) [21:35:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Create WMF standalone config - https://phabricator.wikimedia.org/T372005#10782216 (10jgleeson) I managed to install all our extensions, and then when I ran the database upgrader, I ran into th... [21:39:33] well this gets stranger - from email-pref-ctr I CAN ping donorprefsqueues [21:40:15] (03CR) 10CI reject: [V:04-1] Add Benevity mgd file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139209 (owner: 10Eileen) [21:40:41] PROBLEM - Host frlog1002 is DOWN: PING CRITICAL - Packet loss = 100% [21:43:15] RECOVERY - Host frlog1002 is UP: PING OK - Packet loss = 0%, RTA = 0.47 ms [21:46:41] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Create WMF standalone config - https://phabricator.wikimedia.org/T372005#10782238 (10Eileenmcnaughton) Hmm - I just added 2 new activities & moved one from wmf_civicrm to wmf_thank you - has b... [21:46:47] 14:37 greg-g: SmashPig repo is now set to active again [21:48:48] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139209 (owner: 10Eileen) [21:50:03] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139587 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [21:50:14] eileen: ohhh right! [21:50:18] that's how it's supposed to be [21:50:28] to replicate the network in production [21:50:40] ejegg: yeah - but why does predis fail [21:50:50] Predis\Connection\ConnectionException Object [21:50:50] ( [21:50:50] [message:protected] => php_network_getaddresses: getaddrinfo for donorprefsqueues failed: Temporary failure in name resolution [tcp://donorprefsqueues:6379] [21:51:27] the networks are intentionally separated [21:58:47] yeah - but it should find it!! [21:58:55] during composer [21:58:55] Class SmashPig\PaymentProviders\Amazon\Tests\AuditTest located in ./vendor/wikimedia/smash-pig/PaymentProviders/Amazon/Tests/phpunit/AuditTest.php does not comply with psr-4 autoloading standard. Skipping. [22:05:38] ah from payments [22:05:39] docker@payments:/$ ping donorprefsqueues [22:05:39] ping: donorprefsqueues: Temporary failure in name resolution [22:06:10] - the prefs form I'm opening is on payments, not email-prefs-centre & that can't find that network [22:07:58] if you look in the docker-compose.yml you see it defines two different networks [22:08:38] payments and the main queue are on one, epc + its queue are on the other, and civi is on both [22:09:52] any clue why that TY test should be so flakey no=w [22:09:54] ? [22:10:06] seems to be failing every gate+submit run [22:10:17] but it's passing for me locally [22:11:30] PROBLEM - Host frdb1006 is DOWN: PING CRITICAL - Packet loss = 100% [22:26:12] RECOVERY - Host frdb1006 is UP: PING OK - Packet loss = 0%, RTA = 0.49 ms [22:32:36] ejegg: it's something odd - on one occassion I caused timeLimit being unset locally [22:32:58] - we could default it to say 3 minutes ? [22:35:08] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1139793 (https://phabricator.wikimedia.org/T359219) (owner: 10Eileen) [22:43:38] (03PS1) 10Eileen: Do not merge - current 6.3 master [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1140254 [22:43:38] (03PS1) 10Eileen: Do not merge Port https://github.com/civicrm/civicrm-core/pull/32541 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1140255 [22:45:40] Hmm it does seem to skip something on installing payments Class SmashPig\PaymentProviders\Ingenico\Tests\AuditTest located in ./vendor/wikimedia/smash-pig/PaymentProviders/Ingenico/Tests/phpunit/AuditTest.php does not comply with psr-4 autoloading standard. Skipping. [22:46:57] - presumably it just skips adding to Autoload? [22:47:47] hmm, it's just the phpunit folder I think [22:48:01] but that doesn't need to be autoloaded as phpunit discovers it based on phpunit.xml [22:56:40] ok [22:58:08] well it's all merged so I will deploy! [22:58:08] There are some patches left but they stand alone [22:59:47] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1140259 [23:00:11] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1140259 (owner: 10Eileen) [23:01:04] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1140259 (owner: 10Eileen) [23:29:53] hmm - so this is the gist trying to re-install donut - it correctly identifies DonationInterface is missing https://gist.github.com/eileenmcnaughton/d72e9b9e98dc4ff82c41bea23b6970c7 [23:33:10] !log * civicrm upgraded from 2b8b4651 to 6c99f0c9 [23:33:10] * config revision changed from 817b0c94 to 45e49fec [23:33:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:41:30] 10fundraising-tech-ops: Deactivate fundraising accounts for dmorgan - https://phabricator.wikimedia.org/T393070 (10Dwisehaupt) 03NEW