[04:33:31] (03CR) 10CI reject: [V:04-1] build: Updating mediawiki/mediawiki-phan-config to 0.16.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1168019 (owner: 10Libraryupgrader) [07:23:10] PROBLEM - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 116.22, 82.56, 40.32 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [07:25:16] PROBLEM - check_load on frban2002 is CRITICAL: LOAD CRITICAL - total load average: 63.99, 76.44, 45.50 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [07:28:12] PROBLEM - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 18.69, 53.77, 40.88 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [07:30:18] PROBLEM - check_load on frban2002 is CRITICAL: LOAD CRITICAL - total load average: 4.17, 36.92, 37.82 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [07:33:12] PROBLEM - check_load on frban1002 is CRITICAL: LOAD CRITICAL - total load average: 2.96, 23.33, 31.30 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [07:55:16] RECOVERY - check_load on frban2002 is OK: LOAD OK - total load average: 1.56, 2.59, 9.83 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2002&service=check_load [07:58:12] RECOVERY - check_load on frban1002 is OK: LOAD OK - total load average: 2.05, 2.74, 8.75 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1002&service=check_load [09:36:52] 06Fundraising-Backlog, 10Quibble, 10Continuous-Integration-Infrastructure (Zuul upgrade): Remove reliance on EXECUTOR_NUMBER environment variable in CI - https://phabricator.wikimedia.org/T399283#10994671 (10hashar) wikimedia/fundraising/tools has: ` lang=python,name=silverpop_export/tests/test_update.py def... [09:45:28] (03PS1) 10Hashar: tox: pin flake8<7.2 [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168133 [09:45:28] (03PS1) 10Hashar: Replace EXECUTOR_NUMBER env var by CI [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168134 (https://phabricator.wikimedia.org/T399283) [09:47:10] (03CR) 10Hashar: "The flake8 issues can be addressed in another change. I am only pinning it so I can have tests passing when sending child change I23731814" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168133 (owner: 10Hashar) [09:47:46] (03CR) 10Hashar: "This would need to be merged/cherry-picked to the `deploy` branch." [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168134 (https://phabricator.wikimedia.org/T399283) (owner: 10Hashar) [13:10:26] (03CR) 10Jgleeson: [C:03+2] "Fixed the errors for me locally when running tox on the image! Thanks for this" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168133 (owner: 10Hashar) [13:11:39] (03Merged) 10jenkins-bot: tox: pin flake8<7.2 [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168133 (owner: 10Hashar) [13:11:48] (03CR) 10Jgleeson: [C:03+2] "LGTM! thanks" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168134 (https://phabricator.wikimedia.org/T399283) (owner: 10Hashar) [13:12:28] nothing I like more than the sound of patches being merged on a Friday :] [13:13:11] (03Merged) 10jenkins-bot: Replace EXECUTOR_NUMBER env var by CI [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1168134 (https://phabricator.wikimedia.org/T399283) (owner: 10Hashar) [13:13:17] :) [13:13:24] jgleeson: flake8 kept working on CI cause it reuses whatever version it had in cache [13:13:35] ah [13:13:47] and when I ran tox inside a container that has no cache, it got whatever latest version of flake8 is available and.. failed! :) [13:13:55] that is cause when you do "pip install flake8" [13:14:02] pip looks at the cache and install whatever matches [13:14:15] so potentially that could be flake8 0.0.1-beta-1999 [13:14:17] or whateer [13:14:26] anyway fixed, thanks for the +2!:] [13:14:29] hashar: that project is hardly ever updated so it entirely possible we would have missed those broken tox runs for some time. [13:14:37] yeah no worries :] [13:14:51] thanks for catching and fixing those! [13:14:53] I have noticed it still uses `nose` as a test runner when the ecosystem has moved to `pytest` [13:15:01] anyway, it works! [13:15:13] oh rly? I could make a ticket to track that and we could get to it [13:15:47] nose last release was in 2015 https://pypi.org/project/nose/#history [13:15:51] some went with nose2 [13:16:01] and most went for pytest [13:16:07] but I don't know the real story [13:16:27] apparently nose2 still has releases :] [13:17:50] thx for the quick review, that made my life easier [13:19:20] 06Fundraising-Backlog: Update nose to pytools on fundraising-tools - https://phabricator.wikimedia.org/T399304 (10jgleeson) 03NEW [13:19:24] np! [13:49:34] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Settled Adyen Donation - Settled Gravy Donation - Not Appearing in Civi - https://phabricator.wikimedia.org/T395340#10995468 (10SHust) @jgleeson, the ticket shared by EBrill above still hasn’t made it to Civi, and the donor is upset... [13:50:54] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Settled Adyen Donation - Settled Gravy Donation - Not Appearing in Civi - https://phabricator.wikimedia.org/T395340#10995469 (10jgleeson) I'll take a peek @SHust and see what we can do [14:13:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Settled Adyen Donation - Settled Gravy Donation - Not Appearing in Civi - https://phabricator.wikimedia.org/T395340#10995525 (10jgleeson) @SHust @EBrill-WMF I've just manually imported the transaction, so you should be able to trigg... [15:28:09] 06Fundraising-Backlog: Update nose to pytest on fundraising-tools - https://phabricator.wikimedia.org/T399304#10995828 (10Edgars2007) [16:01:18] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1168189 (https://phabricator.wikimedia.org/T394334) (owner: 10Damilare Adedoyin) [16:59:47] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07payments-orchestration: Enable Amazon Pay through Adyen (via Gr4vy?) - https://phabricator.wikimedia.org/T362991#10996217 (10EMartin) We have enabled Amazon Pay via Stripe via Gr4vy. We are asking for it to be fast tracked under phab: T398377: Fast track... [17:01:04] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07payments-orchestration: Enable Amazon Pay through Adyen (via Gr4vy?) - https://phabricator.wikimedia.org/T362991#10996225 (10AKanji-WMF) 05Open→03Declined I'm closing this in favour of the newer task implementing this via Gravy: {T398377} [17:01:42] (03PS11) 10Damilare Adedoyin: WIP: Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 [17:01:53] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Recurring donation module should be able to charge Amazon recurring donations - https://phabricator.wikimedia.org/T111431#10996229 (10AKanji-WMF) 05Open→03Declined I'm closing this in favour of the newer task implementing this via Gravy: {T398377} [17:02:09] 06Fundraising-Backlog, 10FR-Amazon, 10Recurring-Donations, 07Epic: Amazon recurring (Epic) - https://phabricator.wikimedia.org/T107391#10996235 (10AKanji-WMF) 05Open→03Declined I'm closing this in favour of the newer task implementing this via Gravy: {T398377} [17:02:34] (03PS4) 10Damilare Adedoyin: WIP: Add login template in vue with tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1166927 [17:03:31] (03PS3) 10Damilare Adedoyin: WIP: Add vue navigation guard to check checksum validity [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167615 [18:03:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 13Patch-For-Review: Remove Gravy fiscal_number countries requirement from PayPal transactions - https://phabricator.wikimedia.org/T394334#10996380 (10SHust) Thank you @Damilare, much appreciated! [18:27:55] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.16.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1168019 (owner: 10Libraryupgrader) [18:29:40] (03CR) 10Umherirrender: "Some missing @throws needs to be added to make phan pass" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1168019 (owner: 10Libraryupgrader) [18:31:06] (03CR) 10CI reject: [V:04-1] build: Updating mediawiki/mediawiki-phan-config to 0.16.0 [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1168019 (owner: 10Libraryupgrader) [20:15:39] 06Fundraising-Backlog, 06FR-donorrelations: Civi: check on bad_request:Request failed validation's - https://phabricator.wikimedia.org/T399339 (10MBeat33) 03NEW [20:21:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi: check on bad_request:Request failed validation's - https://phabricator.wikimedia.org/T399339#10996556 (10XenoRyet) p:05Triage→03High [21:01:11] 06Fundraising-Backlog, 06FR-donorrelations: dLocal+Gravy invalid_request_parameters / payer.document - check for cause - https://phabricator.wikimedia.org/T399135#10996633 (10MBeat33) p:05Triage→03Low @RKumar_WMF tested and some of the donors blocked by dLocal have had recent successful donations, so we ca... [21:43:22] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Gravy Card Payment AVS check triggering false positives. - https://phabricator.wikimedia.org/T396355#10996699 (10EMartin) I spent some time today testing out AVS responses through Gr4vy. I have Visa debit and credit cards at my disposal. I tested out th...