[01:38:08] PROBLEM - check_load on franio2002 is CRITICAL: LOAD CRITICAL - total load average: 0.29, 36.84, 39.26 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2002&service=check_load [01:43:08] PROBLEM - check_load on franio2002 is CRITICAL: LOAD CRITICAL - total load average: 0.99, 14.61, 28.88 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2002&service=check_load [01:48:08] PROBLEM - check_load on franio2002 is CRITICAL: LOAD CRITICAL - total load average: 2.27, 7.09, 21.73 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2002&service=check_load [01:53:08] PROBLEM - check_load on franio2002 is CRITICAL: LOAD CRITICAL - total load average: 0.03, 2.72, 15.79 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2002&service=check_load [02:03:08] RECOVERY - check_load on franio2002 is OK: LOAD OK - total load average: 4.14, 3.16, 9.59 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=franio2002&service=check_load [06:39:17] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/1175318 (owner: 10L10n-bot) [11:21:02] (03PS1) 10Hashar: tox: do not overide flake8 built-in list of ignored errors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175488 [11:24:35] (03PS2) 10Hashar: tox: do not override flake8 built-in list of ignored errors [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175488 [11:55:31] (03PS3) 10Hashar: tox: do not override flake8 built-in extends/ignore [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175488 [12:12:16] (03PS17) 10Damilare Adedoyin: Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 [12:12:36] (03PS3) 10Damilare Adedoyin: WIP: Add API to fetch DonorSummary [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167680 [12:13:10] (03PS5) 10Damilare Adedoyin: WIP: Add login template in vue with tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1166927 [12:13:18] (03PS4) 10Damilare Adedoyin: WIP: Add vue navigation guard to check checksum validity [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167615 [12:13:27] (03PS6) 10Ejegg: Get real donor data for Vue portal from server-side call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175127 (https://phabricator.wikimedia.org/T388745) [12:13:46] (03PS3) 10Ejegg: Add a missing message to donorPortal list [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175184 [12:14:48] (03CR) 10CI reject: [V:04-1] WIP: Add API to fetch DonorSummary [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167680 (owner: 10Damilare Adedoyin) [12:58:42] hi fr-tech! [12:58:48] thanks for all the review ejegg|away! [13:10:47] (03PS5) 10Hashar: Migrate from nose to pytest [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) [13:10:54] 06Fundraising-Backlog, 13Patch-For-Review: Update nose to pytest on fundraising-tools - https://phabricator.wikimedia.org/T399304#11057446 (10hashar) a:03hashar [13:11:50] (03CR) 10Hashar: "This change is a bit dense but it get rides of the obsolete nosetest in favor of pytest 😊" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) (owner: 10Hashar) [13:35:12] hi jgleeson ! [13:35:21] hope your time off was relaxing [13:36:29] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [13:37:00] hard to tell why zuul wouldn't submit that one ^^^ [13:37:14] I hope it's nothing to do with the extra node modules for the vue tests [13:40:31] Jeff_Green: did you see that reply from dlocal with the two new IPs? [13:41:07] yep, I put in a task on friday re. updating the policy [13:41:38] https://phabricator.wikimedia.org/T400936 [13:44:06] ok, thanks! [13:50:28] thanks ejegg. yep it was a pretty good break although they never feel long enough ha! [13:50:54] how was the wedding? [13:57:18] really good! Great to see the community my sister's built over in the EU [13:57:29] and the groom's family were interesting nerds [14:00:32] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1172649 (https://phabricator.wikimedia.org/T399021) (owner: 10Ejegg) [14:01:04] nice lol [14:01:15] (03Merged) 10jenkins-bot: Handle missing resultCode in Adyen recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1172649 (https://phabricator.wikimedia.org/T399021) (owner: 10Ejegg) [14:01:16] ty jgleeson [14:01:16] in she in Germany? [14:01:20] is* [14:01:27] wb jgleeson [14:01:35] thanks damilare ! [14:01:41] yep, though she was in Switzerland for a long time before that, so there was a big Swiss contingent there [14:02:01] including a couple I'd hung out with in Gruyere way back in 2014 [14:02:20] is she still working in the ER? [14:02:27] that's the other sister [14:02:30] ahh [14:02:46] the EU one is the one that keeps going for one more degree [14:02:53] oh right ha! [14:05:10] ejegg: the DI patch has this error on CI: "PHP Fatal error: Uncaught Error: Class "MediaWiki\Http\Telemetry" not found in /workspace/src/includes/Request/HeaderCallback.php:67" [14:05:18] have you come across it before? [14:05:24] oh weird, nope [14:05:32] that's the one that keeps failing to submit? [14:05:38] looking [14:06:48] yes but I also just saw it on my other DI patch [14:08:29] Can you link to the error? I'm not seeing it on the donorPortal patch [14:12:02] ejegg: here https://integration.wikimedia.org/ci/job/mwext-codehealth-patch/176820/console [14:13:34] oh ok, but that's an optional pipeline, so I don't know why it would be blocking [14:13:41] I think we should ask releng [14:14:38] oh lol, addshore/psr-6-mediawiki-bagostuff-adapter is a bit behind the times [14:15:04] Looks like we'll need the newer psr/cache interface to make that keep working [14:15:11] I'll make a PR [14:15:40] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [14:21:01] sure I'd reach out to releng [14:21:51] oh I know why it's failing ejegg, it's because of the depends-on [14:22:13] the patch it depends on is yet to be merged, I can take that out [14:22:25] (03PS18) 10Damilare Adedoyin: Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 [14:28:51] (03PS4) 10Jgleeson: Add script to declare debug / error settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1169255 (https://phabricator.wikimedia.org/T396171) (owner: 10Eileen) [14:29:08] ohhh! [14:29:11] hah [14:29:42] right, right [14:29:54] so I can still merge that core patch [14:30:10] unless you're close to having it load in the extension [14:30:41] (03CR) 10Ejegg: [C:03+2] Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [14:31:27] not really, I think you can go ahead to merge the core patch. The extension bit doesn't seem to be coming along well [14:33:25] (03CR) 10CI reject: [V:04-1] Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [14:35:49] ahhh right, there's the fail for the missing dependency [14:36:10] (03PS6) 10Damilare Adedoyin: Add vue router package to fundraising mediawiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1164183 [14:36:38] (03CR) 10Ejegg: [C:03+2] "Merging this to allow progress on the vue donorPortal, but let's try to get this into the extension." [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1164183 (owner: 10Damilare Adedoyin) [14:38:20] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [14:40:24] (03CR) 10Jgleeson: [C:03+2] "The files are being generated as expected for me, which is half the battle. The other half involves updating the Docker image to add a sym" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1169255 (https://phabricator.wikimedia.org/T396171) (owner: 10Eileen) [14:40:30] (03CR) 10Jgleeson: [V:03+2 C:03+2] Add script to declare debug / error settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1169255 (https://phabricator.wikimedia.org/T396171) (owner: 10Eileen) [14:43:53] i think we need to allow newer symfony/yaml in smashpig to keep it working on newer MW [14:44:06] getting errors trying to composer update in donutwiki [14:50:33] (03Merged) 10jenkins-bot: Add vue router package to fundraising mediawiki [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1164183 (owner: 10Damilare Adedoyin) [14:50:38] (03PS1) 10Ejegg: Add data-nosnippet attr on CN div [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1175528 (https://phabricator.wikimedia.org/T401004) [14:53:26] 06Fundraising-Backlog, 13Patch-For-Review, 07SEO: Fundraising message displayed as description for some search results by Google - https://phabricator.wikimedia.org/T401004#11057880 (10Ejegg) @R4356th are you still seeing these? I haven't been able to get them to appear again in any search results. I wonder... [14:54:29] 14Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 06Fundraising-Backlog, 10FR-Docker, 10FR-Smashpig: Update symfony\yaml library used in SmashPig - https://phabricator.wikimedia.org/T321621#11057883 (10Ejegg) Need to upgrade again, current MW has 6.x [15:00:10] (03PS1) 10Ejegg: Allow newer symfony/yaml [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175532 (https://phabricator.wikimedia.org/T321621) [15:00:43] (03CR) 10CI reject: [V:04-1] Allow newer symfony/yaml [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175532 (https://phabricator.wikimedia.org/T321621) (owner: 10Ejegg) [15:01:52] (03PS2) 10Ejegg: Allow newer symfony/yaml [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175532 (https://phabricator.wikimedia.org/T321621) [15:02:03] fr-tech does that look OK to merge? Trying to get local CentralNotice running under latest MW and we've got SmashPig on donutwiki ^^^ [15:02:32] (and it'll be one less thing to do when we have to upgrade MW again next year) [15:34:49] taking a peek ejegg [15:38:09] (03CR) 10Jgleeson: [C:03+2] "I don't see anything scary in the changelog and tests are passing so LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175532 (https://phabricator.wikimedia.org/T321621) (owner: 10Ejegg) [15:38:40] ejegg: I think we have some unit tests covering the yaml parsing from them old ingenico template map things [15:38:44] (03Merged) 10jenkins-bot: Allow newer symfony/yaml [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175532 (https://phabricator.wikimedia.org/T321621) (owner: 10Ejegg) [15:40:25] https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/772ecaf533016444d07cdd2d2bc43d26224de0d2/Tests/MapperTest.php#L54 [15:40:55] that thing uses the Symfony YAML lib under the hood also and tests are passing so it's probably a good enough indicator of nothing broken [15:42:00] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [15:42:29] wow, we don't even use that thing anymore. it was all confined to the old ingenico code [15:42:51] we should probably delete all that old stuff [15:42:58] 7 years old now... [15:46:20] (03PS7) 10Ejegg: Get real donor data for Vue portal from server-side call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175127 (https://phabricator.wikimedia.org/T388745) [15:48:36] thanks for the CR jgleeson [15:48:53] and yeah, we should do another round of dead code purge [15:49:02] specifically Ingenico [15:50:57] it's all temporary! [15:53:07] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [15:55:21] (03Merged) 10jenkins-bot: Donor Portal structure on Vue JS [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1163874 (owner: 10Damilare Adedoyin) [16:02:33] woo [16:04:47] (03PS1) 10Ejegg: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175543 [16:04:49] (03CR) 10Ejegg: [C:03+2] Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175543 (owner: 10Ejegg) [16:04:57] oh i should grab lunch [16:23:55] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11058197 (10Jgreen) traffic was switched back to pay-lb's at about 15:30 UTC today [16:25:10] (03Merged) 10jenkins-bot: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175543 (owner: 10Ejegg) [16:49:25] (03PS8) 10Ejegg: Get real donor data for Vue portal from server-side call [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175127 (https://phabricator.wikimedia.org/T388745) [17:01:23] 06Fundraising-Backlog, 13Patch-For-Review, 07SEO: Fundraising message displayed as description for some search results by Google - https://phabricator.wikimedia.org/T401004#11058344 (10R4356th) Yeah, I cannot see these either. It seems like your theory regarding Google misbehaving is correct but considering... [17:03:41] ejegg|food: I just got around testing this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1174807 but it doesn't seem to work on my computer [17:03:53] when you get back please can you confirm it works on your end [17:04:45] I had been using the wmff config as I had tested this out while you were away but wasn't successful [17:07:22] 03Fundraising Sprint: Omakase, 06Fundraising-Backlog, 07fr-acoustic, 07fr-current-sprint: July 30th: Removing Data Axle CE fields from Civi - License Expiring - https://phabricator.wikimedia.org/T395961#11058367 (10MDemosWMF) @RLewis and @AFowler-WMF want to make sure you are good with your lists before we... [17:16:42] (03PS1) 10Ejegg: Update mailcheck.js, use foreign-resources.yaml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175554 [17:17:05] hi damilare [17:17:31] i should have written there that you need to either rebuild civi or manually edit the apache config to make that take effect [17:18:37] so i think it's in config/civicrm/amp/apache.d [17:18:54] there are files that are generated when you setup civicrm [17:19:12] there should be a wmf.localhost_32353.conf there [17:19:28] and you'll need to add in the ServerAlias wmf.civicrm [17:19:39] if you don't want to do a full rebuild [17:20:04] just right under the ServerName should be fine [17:20:16] then do a docker-compose restart to pick up the new network aliases [17:20:24] I'll add those instructions to the commit message [17:21:42] ahh ok, I'd do that now [17:22:22] (03PS3) 10Ejegg: More steps to get civiproxy working with one-f [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1174807 [17:22:45] damilare: I was able to get mailcheck.js working with the foreign-modules in https://gerrit.wikimedia.org/r/1175554 [17:23:01] I figured starting with something simple might be a step towards getting vue-router working [17:24:34] ohh ok, cool. I see all the config is in the extension.json... That must be where I missed it as I was using the addScript to load it in the output page [17:24:52] lemme try that while civi reinstalls [17:47:29] (03PS1) 10Ejegg: Allow newer symfony/yaml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175559 [17:47:31] (03CR) 10Ejegg: [C:03+2] Allow newer symfony/yaml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175559 (owner: 10Ejegg) [17:54:33] (03Merged) 10jenkins-bot: Allow newer symfony/yaml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175559 (owner: 10Ejegg) [18:12:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [18:23:12] 06Fundraising Tech Chaos Holding Pen, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143 (10Ejegg) 03NEW [18:23:52] huh eileen isn't on gitlab [18:24:14] I just tried adding her as the reviewer on https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/82 [18:27:35] I can review that jgleeson [18:28:49] thanks ejegg. I just added some testing notes here https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/82#note_156211 [18:34:41] oh I need to push up one more thinbg [18:38:59] (03PS1) 10Jgleeson: Update CiviCRM Docker image and ignore debug config files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) [18:39:24] ejegg: that will do the image updating locally. ahh lemme port that to the mac config also [18:39:53] (03PS2) 10Jgleeson: Update CiviCRM Docker image and ignore debug config files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) [18:56:37] (03PS3) 10Jgleeson: Update CiviCRM Docker image and ignore debug config files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) [19:07:00] (03PS1) 10Damilare Adedoyin: WIP: Load vue-router from within extension [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175573 [19:09:32] jgleeson: we want to update the common-settings block to 1.0.1 there too right? [19:09:53] (03CR) 10Ejegg: Update CiviCRM Docker image and ignore debug config files (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) (owner: 10Jgleeson) [19:10:06] good spot ejegg [19:10:10] oh and the civiproxy block [19:10:29] hmm, should that block inherit from common-settings? [19:10:35] maybe it doesn't need its own image tag [19:11:13] huh it doesn't for whatever reason [19:11:27] oh hey, should we delete that experimental gravy container? [19:13:42] (03PS4) 10Jgleeson: Update Docker images and ignore debug config files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) [19:13:51] updated ejegg ^ [19:14:02] yep that also makes sense ejegg that the POC one [19:14:40] I'll get rid of that. I use it from time to time for scripts but it doesn't need to be in the official build [19:19:20] (03PS1) 10Jgleeson: Remove gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175577 [19:21:31] Relocating for call. back soon [19:31:51] (03CR) 10Ejegg: "Looks like civiproxy needs a bump too" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) (owner: 10Jgleeson) [19:41:55] ejegg: I'll add that too. Are we gonna remove that afterwards? [19:46:09] (03PS5) 10Jgleeson: Update Docker images and ignore debug config files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175567 (https://phabricator.wikimedia.org/T396171) [19:52:12] 03Fundraising Sprint: Omakase, 06Fundraising-Backlog, 07fr-current-sprint: Get more clarity on Message / wmf_contribution_extra fields - https://phabricator.wikimedia.org/T400856#11058935 (10Eileenmcnaughton) https://docs.google.com/spreadsheets/d/1PR2Jpifw8cL5ezFTLBEQGzv8rwKhqBUm02uBHpm1g4k/edit?gid=1225331... [20:12:21] (03CR) 10Eileen: "OK - Civi has" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174876 (owner: 10Eileen) [20:12:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: dLocal Upcoming SFTP Security Update - https://phabricator.wikimedia.org/T399031#11058960 (10Damilare) a:03Jgreen [20:14:31] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: DLocal CO donation form failing with no error message - https://phabricator.wikimedia.org/T400818#11058969 (10Ejegg) The fiscal number validation is fixed so you can submit now, but we should stil... [20:16:11] 06Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-Platform-Team (Radar), 10MW-1.45-notes (1.45.0-wmf.13; 2025-08-05), 13Patch-For-Review: Remove mobile domain variance from $wgCentralBannerRecorder URL - https://phabricator.wikimedia.org/T400586#11058975 (10Krinkle) 05Open→... [20:17:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143#11058978 (10greg) p:05Triage→03Medium [20:17:09] 06Fundraising-Backlog, 06FR-donorrelations, 10Recurring-Donations: email update process for recurring PayPal donors: issue + question - https://phabricator.wikimedia.org/T400765#11058980 (10AnnWF) [20:18:00] (03PS5) 10R4356thwiki: Remove $wgCentralNoticeESITestString [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1173362 (https://phabricator.wikimedia.org/T400472) [20:18:08] (03CR) 10Ejegg: [C:03+2] "Looks good!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1173362 (https://phabricator.wikimedia.org/T400472) (owner: 10R4356thwiki) [20:18:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06Traffic, and 2 others: ESI test string is still shipped by CentralNotice - https://phabricator.wikimedia.org/T400472#11058991 (10greg) p:05Triage→03Medium a:05R4356th→03Ejegg [20:20:25] (03CR) 10Wfan: Add data-nosnippet attr on CN div (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1175528 (https://phabricator.wikimedia.org/T401004) (owner: 10Ejegg) [20:21:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, 07SEO: Fundraising message displayed as description for some search results by Google - https://phabricator.wikimedia.org/T401004#11059001 (10greg) p:05Triage→03Medium [20:21:08] (03CR) 10Wfan: Add data-nosnippet attr on CN div (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1175528 (https://phabricator.wikimedia.org/T401004) (owner: 10Ejegg) [20:21:48] 03Fundraising Sprint: Omakase, 06Fundraising-Backlog, 13Patch-For-Review, 07payments-orchestration: Setup fallback default currency logic on Gravy PayPal - https://phabricator.wikimedia.org/T400996#11059005 (10greg) [20:21:49] (03Merged) 10jenkins-bot: Remove $wgCentralNoticeESITestString [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1173362 (https://phabricator.wikimedia.org/T400472) (owner: 10R4356thwiki) [20:22:48] 06Fundraising-Backlog: Make the Upgrade monthly gift URL active/available - https://phabricator.wikimedia.org/T400930#11059009 (10greg) 05Open→03Resolved a:03Ejegg [20:24:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-PayPal-ExpressCheckout: Intermittent PayPal auth failures lead to bad payments-initial messages - https://phabricator.wikimedia.org/T400846#11059014 (10greg) p:05Triage→03Low [20:30:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add recipient to MGFE large donation bot emails - https://phabricator.wikimedia.org/T396791#11059042 (10greg) p:05Triage→03Medium [20:31:35] 06Fundraising-Backlog: Civi donor segment doesn't match with Acoustic donor segment - https://phabricator.wikimedia.org/T400416#11059056 (10greg) 05Open→03Resolved a:03Eileenmcnaughton [20:38:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add recipient to MGFE large donation bot emails - https://phabricator.wikimedia.org/T396791#11059081 (10Ejegg) OK, this is done. [20:40:53] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 07fr-acoustic: Data enrichment via SMS + Surveymonkey - https://phabricator.wikimedia.org/T397101#11059085 (10NNgu-WMF) Sorry I missed the last comment! We = fundraising products, SMS team. Looks like Eileen and Anil have added project tags, thanks both! [20:42:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143#11059090 (10Johannnes89) The issue is not the time limit. @srishakatux you need to enable [[https://meta.... [20:42:07] jgleeson: I just merged the gitlab bit [20:42:18] thanks ejegg [20:42:23] I guess we wait for publish before we merge the docker-compose updates? [20:42:29] I added the update to civiproxy [20:42:35] sounds good ejegg [20:42:35] oh nice [20:43:03] eileen: those patches will enable your E_ALL debug.ini overrides [20:43:13] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-PayPal-ExpressCheckout: Intermittent PayPal auth failures lead to bad payments-initial messages - https://phabricator.wikimedia.org/T400846#11059105 (10Ejegg) The auth failures aren't happening any more, but we could improve error handling to make... [20:43:21] ejegg: yay - which ones are they? [20:43:51] https://gitlab.wikimedia.org/repos/releng/dev-images/-/merge_requests/82 and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1175567 [20:47:14] eileen: if you don't want to build the docker images yourself, we will probably get them deployed to the WMF registry by tomorrow [20:47:30] ejegg: nice! [20:50:07] I'm so glad I made a phab for ssethi's CN issue - it was a lack of 2FA. Again I think we should add messaging for folks with the group but no 2FA! https://phabricator.wikimedia.org/T394321 [20:51:27] don't see "thusly" used much ejegg [20:51:48] heh [20:51:48] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143#11059130 (10Ejegg) Ahhh thanks @Johannnes89 - this has bitten me before, and I even filed {T394321} but I... [20:52:07] :) [20:52:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143#11059132 (10Ejegg) 05Open→03Resolved [20:53:29] 10fundraising-tech-ops: Modify Fundraising nagios check_ssl plugin to send proxy_protocol - https://phabricator.wikimedia.org/T400735#11059137 (10Jgreen) 05Open→03Resolved p:05Triage→03Medium This is done. [20:54:59] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Add text to CentralNotice admin UI when user has admin but no 2FA - https://phabricator.wikimedia.org/T394321#11059144 (10Johannnes89) This affects other user groups as well: {T396061} [21:02:22] (03CR) 10Wfan: "I am sending this to fail page with pending status not success page, the previous patch was update to ty page. then this one I change it b" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1174470 (https://phabricator.wikimedia.org/T394098) (owner: 10Wfan) [21:13:24] 10fundraising-tech-ops: Modify payments check_http check to send proxy_protocol - https://phabricator.wikimedia.org/T401153 (10Jgreen) 03NEW [21:14:02] 10fundraising-tech-ops: Modify payments check_http check to send proxy_protocol - https://phabricator.wikimedia.org/T401153#11059257 (10Jgreen) [21:14:07] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11059256 (10Jgreen) [21:16:05] (03PS1) 10Ejegg: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1175605 [21:16:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CN user with time-limited admin rights is unable to exercise them - https://phabricator.wikimedia.org/T401143#11059271 (10srishakatux) That worked! Thank you all for helping resolve this issue! :) [21:17:16] fr-tech does anyone want to look at these CN changes one more time before I put them on the deploy train? [21:17:22] https://gerrit.wikimedia.org/r/1175605 [21:18:38] I'm pretty confident about all of them, but there is a bit of code change around the mobile view logic [21:32:20] (03PS1) 10Jgleeson: Refacor: Remove unused merchantAccountId instance variable in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175607 [21:32:20] (03PS1) 10Jgleeson: Refactor: Add type declaration for gravyApiClient property in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175608 [21:32:21] (03PS1) 10Jgleeson: Refactor: Remove unused donor management methods from Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175609 [21:32:21] (03PS1) 10Jgleeson: Refactor: Replace 'apple' string with PaymentMethod enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175610 [21:33:49] (03PS2) 10Jgleeson: Refactor: Remove unused merchantAccountId instance variable in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175607 [21:33:49] (03PS2) 10Jgleeson: Refactor: Add type declaration for gravyApiClient property in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175608 [21:33:49] (03PS2) 10Jgleeson: Refactor: Remove unused donor management methods from Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175609 [21:33:49] (03PS2) 10Jgleeson: Refactor: Replace 'apple' string with PaymentMethod enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175610 [21:39:48] ejegg: they all look reasonably safe to me [21:40:01] re: CN patches [21:40:26] I don't enough about the mobile view stuff to know for sure [21:40:47] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Add text to CentralNotice admin UI when user has admin but no 2FA - https://phabricator.wikimedia.org/T394321#11059326 (10Ejegg) Good discussion of the difficulties of solving this for the general case here: https://phabricator.wikimedia.org/T396061#... [21:41:08] yeah, those mobile view things should be no-ops based on current config [21:41:34] k, will merge it [21:41:39] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1175605 (owner: 10Ejegg) [21:43:00] ooh, nice refactor drop [21:43:04] looking [21:43:35] (03CR) 10Ejegg: [C:03+2] Refactor: Remove unused merchantAccountId instance variable in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175607 (owner: 10Jgleeson) [21:43:54] (03CR) 10Ejegg: [C:03+2] Refactor: Add type declaration for gravyApiClient property in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175608 (owner: 10Jgleeson) [21:44:06] (03Merged) 10jenkins-bot: Refactor: Remove unused merchantAccountId instance variable in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175607 (owner: 10Jgleeson) [21:44:23] (03Merged) 10jenkins-bot: Refactor: Add type declaration for gravyApiClient property in Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175608 (owner: 10Jgleeson) [21:46:14] (03CR) 10Ejegg: [C:03+2] Refactor: Remove unused donor management methods from Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175609 (owner: 10Jgleeson) [21:46:44] (03Merged) 10jenkins-bot: Refactor: Remove unused donor management methods from Gravy API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175609 (owner: 10Jgleeson) [21:50:27] thanks ejegg [21:50:42] ty for the cleanup [21:50:57] ejegg: do you also get the "Scrutinizer CI" emails about missing config [21:51:01] bash: phpunit: command not found [21:51:01] The coverage file '/home/scrutinizer/build/coverage.xml' was not found. [21:52:02] (03CR) 10Ejegg: [C:03+2] "Looks good - but should we have a generic enum with those payment method values outside of the gravy namespace?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175610 (owner: 10Jgleeson) [21:52:40] (03Merged) 10jenkins-bot: Refactor: Replace 'apple' string with PaymentMethod enum [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175610 (owner: 10Jgleeson) [21:52:43] (03CR) 10CI reject: [V:04-1] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1175605 (owner: 10Ejegg) [21:54:44] oh hmm [21:55:04] jgleeson: argh, yeah, we need to fix that or disconnect the service [21:55:15] I'm not sure what it would give us at this point [21:55:21] (03CR) 10Jgleeson: "Yeah, that makes sense. We could then point the gravy variant at the main list to maintain the single source of truth" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1175610 (owner: 10Jgleeson) [21:55:54] ok, that's a weird fail on the wmf_deploy merge [21:56:01] Died on test #1: too much recursion [21:56:14] I think it used to tell us when coverage dropped but I guess test coverage isnt a great metric anymore [21:56:30] oh that's pretty wild [21:58:16] (03CR) 10Ejegg: [C:03+2] "resubmit" [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1175605 (owner: 10Ejegg) [22:00:45] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1175605 (owner: 10Ejegg) [22:52:17] (03PS3) 10Eileen: Combine CiviCRM vendor with main vendor using composer-merge-plugin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 [22:54:02] (03CR) 10CI reject: [V:04-1] Combine CiviCRM vendor with main vendor using composer-merge-plugin [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 (owner: 10Eileen) [23:17:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:21:49] (03PS1) 10Eileen: Fix bad array join [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1175616 (https://phabricator.wikimedia.org/T400786) [23:22:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:22:29] ah - this was the Acoustic issue ^^ if someone can +2 (yes we did just agree NOT to pull it into the sprint but I got pinged & would up diving in) [23:22:55] wfan: if you are about should be an easy +2 [23:27:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:32:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:37:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:42:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:47:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:52:10] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:57:12] PROBLEM - check_mysql on frdb1003 is CRITICAL: Cant connect to local server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_mysql [23:58:19] (03CR) 10Wfan: [C:03+2] Fix bad array join [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1175616 (https://phabricator.wikimedia.org/T400786) (owner: 10Eileen) [23:58:30] thanks wfan [23:58:42] np~