[01:20:16] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1176329 [01:20:23] just back for a lil bit [01:20:38] wanted to get that fix out for the UIDs in queries [01:20:44] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1176329 (owner: 10Ejegg) [01:21:30] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1176329 (owner: 10Ejegg) [01:39:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339#11067070 (10Ejegg) a:03Ejegg [01:39:25] !log fundraising civicrm upgraded from e591fe72 to ebb98a9e [01:39:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:48:54] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 (owner: 10Eileen) [01:48:56] OK, found one in the slow query log with the UID [01:52:07] hmm, not as easy to find the UID in the new standalone admin interface [01:57:42] hmm ejegg I'm still battling composer + patches on CI [01:57:57] I got some verbosity [01:57:57] patch '-p4' --no-backup-if-mismatch -d '/src/wikimedia/fundraising/crm/vendor/zetacomponents/mail' < '/src/wikimedia/fundraising/crm/core/tools/patches/raw/zetacomponents/mail/100-filename.patch' [01:58:08] sh: 1: patch: not found [01:58:12] but no clarity [01:58:24] ie that file *should* be there [01:58:42] (it also failed from the url so I tried local) [02:02:15] hmmm [02:02:27] so we can pull down the image they use in CI [02:02:50] I just don't know exactly how to kick it off, like what env vars it'll need [02:05:20] yeah not sure - greg pointed to https://docker-registry.wikimedia.org/dev/fundraising-civicrm-bookworm-php82/tags/ [02:09:26] (03PS9) 10Eileen: General composer update + switch to combining with composer merge-plugin update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 [02:09:26] (03PS1) 10Eileen: Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 [02:09:28] (03Abandoned) 10Eileen: General composer update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174876 (owner: 10Eileen) [02:09:45] (03Abandoned) 10Eileen: Update autoloader require [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176318 (owner: 10Eileen) [02:10:56] (03CR) 10CI reject: [V:04-1] Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 (owner: 10Eileen) [02:11:35] (03CR) 10CI reject: [V:04-1] General composer update + switch to combining with composer merge-plugin update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 (owner: 10Eileen) [02:18:41] (03PS2) 10Eileen: Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 [02:20:00] (03CR) 10CI reject: [V:04-1] Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 (owner: 10Eileen) [02:21:16] i'm sorry I can't help more now eileen - that looks really frustrating [02:21:24] gotta get some sleep though [02:21:29] night ejegg|away [02:28:20] (03PS3) 10Eileen: Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 [02:30:24] (03CR) 10CI reject: [V:04-1] Try a different place for the patch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 (owner: 10Eileen) [02:42:16] (03PS1) 10Eileen: Fix field label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176334 [03:11:24] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops: Move pfw1b-codfw to rack F5 - https://phabricator.wikimedia.org/T401297#11067093 (10Papaul) Please see below for the migration diagram. {F65720751} [03:53:16] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [03:55:43] (03PS1) 10Eileen: Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 [03:55:43] (03PS1) 10Eileen: Update test for opt_in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176339 [03:56:21] (03PS2) 10Eileen: Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 [03:57:11] (03PS1) 10Eileen: Improve metadata handling for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176340 [03:58:16] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:08:24] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:10:05] (03CR) 10CI reject: [V:04-1] Update test for opt_in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176339 (owner: 10Eileen) [04:13:16] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:16:01] (03CR) 10CI reject: [V:04-1] Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 (owner: 10Eileen) [04:16:02] (03CR) 10CI reject: [V:04-1] Improve metadata handling for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176340 (owner: 10Eileen) [04:23:16] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:28:22] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:33:18] PROBLEM - check_log_messages on frav1003 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:38:18] RECOVERY - check_log_messages on frav1003 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1003&service=check_log_messages [04:39:25] (03PS3) 10Eileen: Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 [04:57:09] (03CR) 10CI reject: [V:04-1] Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 (owner: 10Eileen) [04:58:47] (03PS2) 10Eileen: Improve metadata handling for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176340 [05:15:35] (03PS1) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [05:20:11] (03PS2) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [05:26:11] (03PS1) 10Eileen: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) [05:31:44] (03PS3) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [05:31:44] (03PS2) 10Eileen: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) [05:41:04] (03CR) 10CI reject: [V:04-1] Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [05:48:00] (03CR) 10CI reject: [V:04-1] Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [05:48:13] (03CR) 10CI reject: [V:04-1] Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [06:09:00] (03PS4) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [06:09:43] (03PS3) 10Eileen: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) [06:15:42] (03PS1) 10Eileen: Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 [06:17:46] (03Abandoned) 10Eileen: Update test for opt_in [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176339 (owner: 10Eileen) [06:18:03] (03Abandoned) 10Eileen: Code tidy up to make handleUpdate easier to follow [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176338 (owner: 10Eileen) [06:18:40] (03CR) 10Eileen: [C:04-1] "Didn't work so let's not" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176331 (owner: 10Eileen) [06:24:30] (03CR) 10CI reject: [V:04-1] Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [06:25:43] (03CR) 10CI reject: [V:04-1] Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [06:30:59] (03CR) 10CI reject: [V:04-1] Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 (owner: 10Eileen) [06:39:58] (03PS5) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [06:39:58] (03PS4) 10Eileen: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) [06:39:58] (03PS2) 10Eileen: Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 [06:44:47] (03PS1) 10Eileen: Add commentry [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176355 [06:54:56] (03CR) 10CI reject: [V:04-1] Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [06:55:21] (03CR) 10CI reject: [V:04-1] Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 (owner: 10Eileen) [06:55:32] (03CR) 10CI reject: [V:04-1] Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [07:04:15] (03CR) 10CI reject: [V:04-1] Add commentry [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176355 (owner: 10Eileen) [07:12:24] (03PS6) 10Eileen: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) [07:12:24] (03PS5) 10Eileen: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) [07:12:25] (03PS3) 10Eileen: Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 [07:12:25] (03PS2) 10Eileen: Add commentry [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176355 [07:49:02] (03PS1) 10Eileen: Do not update opt-in for non-first recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176359 (https://phabricator.wikimedia.org/T401353) [08:02:58] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176396 (owner: 10L10n-bot) [11:57:00] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops: Move pfw1b-codfw to rack F5 - https://phabricator.wikimedia.org/T401297#11067948 (10cmooney) Thanks @papaul for the info. For the most part the diagram looks ok, a few questions/notes: The new switches should be called //fasw1-f5a// and //fasw... [13:16:36] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops: Move pfw1b-codfw to rack F5 - https://phabricator.wikimedia.org/T401297#11068239 (10Papaul) @cmooney please see answers and comments below. >>! In T401297#11067948, @cmooney wrote: > Thanks @papaul for the info. For the most part the diagram l... [13:38:06] (03CR) 10Ejegg: [C:03+2] Fix field label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176334 (owner: 10Eileen) [13:48:15] ok fr-tech I need to get the recurring failure email re-sent to a ton of users [13:48:36] re: T399339 [13:48:36] T399339: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339 [13:49:09] so I think I'm just going to make a long shell script with wmf-cv api4 FailureEmail.Send.... [13:49:22] and run it via the one-off job [13:56:32] (03Merged) 10jenkins-bot: Fix field label [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176334 (owner: 10Eileen) [14:04:19] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops: Move pfw1b-codfw to rack F5 - https://phabricator.wikimedia.org/T401297#11068404 (10cmooney) > "I think we have two cluster control / HA ports on each unit? > em0 and em1 as reported by the box, labelled HA0 and HA1 on the front? > We should u... [14:35:20] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Enable outbound mail on non-custom-mailer [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175979 (owner: 10Ejegg) [14:35:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339#11068535 (10Ejegg) OK, I'm ready to start sending these out. [14:36:02] (03CR) 10Damilare Adedoyin: [C:03+2] Remove gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175577 (owner: 10Jgleeson) [14:36:04] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Remove gr4vy POC build [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1175577 (owner: 10Jgleeson) [14:39:43] fr-tech does anyone want to review the scripts for that FailureEmail send? [14:40:13] I pushed one_off.yaml to the process-control settings repo on frpm [14:40:34] and then on civi there are two files in /tmp with the ticket number in them [14:40:48] T399339.sh and T399339-first.sh (for the slow-start) [14:40:49] T399339: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339 [14:43:30] ok, i pushed up the one-off script to the civi server so you can review everything on one box [14:51:00] ejegg: I see the one-off script and all 3061 lines [14:51:17] looks good to me, no duplicates [14:52:35] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: NL users are reporting "Forbidden" errors when attempting to pay via iDEAL. - https://phabricator.wikimedia.org/T401324#11068649 (10MBeat33) Thank you @jgleeson some donors are reporting success when retrying. One however got an error reference # that I... [14:57:56] thanks damilare [14:58:45] ok, the first email is out [14:59:02] gonna review in the UI to make sure the tokens were filled out right [15:13:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: NL users are reporting "Forbidden" errors when attempting to pay via iDEAL. - https://phabricator.wikimedia.org/T401324#11068808 (10jgleeson) @MBeat33, it looks like that donor was caught by our filters today. They tried to submit a payment 3 times in qui... [15:17:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: NL users are reporting "Forbidden" errors when attempting to pay via iDEAL. - https://phabricator.wikimedia.org/T401324#11068836 (10MBeat33) Thank you, Jack, this is super helpful to know that empty UTM parameters raiseflags. Our 'invite to retry donati... [15:20:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339#11068847 (10SHust) Thanks, @Ejegg! [15:27:20] 10fundraising-tech-ops, 06Infrastructure-Foundations, 10netops: Move pfw1b-codfw to rack F5 - https://phabricator.wikimedia.org/T401297#11068877 (10Papaul) I Still strongly disagree we need redundancy on the HA port. The reason being that if the port goes down, this will not have any impact. On the other ha... [15:31:52] 10fundraising-tech-ops: Modify payments check_http check to send proxy_protocol - https://phabricator.wikimedia.org/T401153#11068885 (10Jgreen) 05Open→03Resolved a:03Jgreen There's a new plugin check_http_hp which roughly copies the behavior of the stock check_http plugin, minus a couple features we do... [15:32:53] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11068892 (10Jgreen) [15:33:41] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11068893 (10Jgreen) [15:45:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: Civi: multiple issues with recurring donations - https://phabricator.wikimedia.org/T399339#11068926 (10MSuijkerbuijk_WMF) Thanks! [15:50:03] (03CR) 10Jgleeson: [C:03+2] "I can see a wfMessage is returned lower down in the code, so this LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175945 (owner: 10Ejegg) [15:50:19] thanks jgleeson [15:50:44] (03CR) 10Jgleeson: [C:03+2] "I thought I +2ed this a few days back :S" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176286 (https://phabricator.wikimedia.org/T401249) (owner: 10Ejegg) [15:50:49] ok, that's the FailureEmail script done [15:51:10] jgleeson: heh, you got santander, that patch is removing bancomer [15:51:23] i didn't realize both were broken when i made the first patch [15:53:05] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 06SRE, 06Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097#11068965 (10greg) Moving this out of unscheduled into Triage for us (FR Tech) to re-review/prioritize our side on it as it's a thing that needs cross-... [15:59:31] (03CR) 10Jgleeson: [C:03+2] "LGTM!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175488 (owner: 10Hashar) [16:01:06] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11069007 (10Jgreen) [16:01:09] (03CR) 10Jgleeson: "When I run tox locally on our development stack I'm getting a failure. I'll dig into it. https://phabricator.wikimedia.org/P80979" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) (owner: 10Hashar) [16:01:22] ah cool thanks ejegg [16:01:27] also thanks damilare for the earlier review [16:01:31] (03Merged) 10jenkins-bot: tox: do not override flake8 built-in extends/ignore [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175488 (owner: 10Hashar) [16:01:35] 10fundraising-tech-ops: Replace fundraising LVS service with BIRD/HAProxy service - https://phabricator.wikimedia.org/T398321#11069009 (10Jgreen) iptables policy now restricts inbound access to WMF subnets [16:01:36] jgleeson: !!! :] [16:01:39] fr-tech be 1 min [16:02:03] jgleeson: tox has certainly plenty of issues somehow :) [16:07:22] (03CR) 10Hashar: "> ERROR: InvocationError for command could not find executable pytest" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) (owner: 10Hashar) [16:07:29] replied [16:07:33] you need to rebuild the tox env [16:07:35] `tox -r` [16:07:38] or rm -fR .tox [16:07:39] :] [16:07:48] I am off for the week-end 👋 [16:12:54] (03Merged) 10jenkins-bot: Fix deprecation warning on DonorPortal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1175945 (owner: 10Ejegg) [16:12:55] (03Merged) 10jenkins-bot: Remove remaining MX bank transfer for gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176286 (https://phabricator.wikimedia.org/T401249) (owner: 10Ejegg) [16:45:07] 10fundraising-tech-ops: dns_to_ipset should clean up deprecated tables - https://phabricator.wikimedia.org/T401419 (10Jgreen) 03NEW [16:45:49] 10fundraising-tech-ops: dns_to_ipset should clean up deprecated tables - https://phabricator.wikimedia.org/T401419#11069250 (10Jgreen) p:05Triage→03Medium [17:32:05] oops, left the flag up [17:37:39] 06Fundraising-Backlog, 13Patch-For-Review: Trustly search by email address - https://phabricator.wikimedia.org/T401277#11069383 (10Ejegg) Looks like it's not so simple - sending any donor info to Gravy makes them send it along to Trustly, who throw an error when we just send email. Since we don't want donors t... [17:49:31] thank you hashar ! [17:49:33] I'll try that [17:50:59] that worked! [17:51:21] I'll update our local test script to refresh the tox env before each run [17:54:34] 06Fundraising-Backlog, 06FR-donorrelations: dLocal missing tax ID + status mismatch errors - https://phabricator.wikimedia.org/T401428 (10MBeat33) 03NEW [18:00:22] (03PS1) 10Jgleeson: Update fundraising-tools tox helper script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176524 (https://phabricator.wikimedia.org/T399304) [18:00:37] (03CR) 10Jgleeson: [C:03+2] "This is working for me locally. thanks for all the work on this!" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) (owner: 10Hashar) [18:01:46] (03Merged) 10jenkins-bot: Migrate from nose to pytest [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1175485 (https://phabricator.wikimedia.org/T399304) (owner: 10Hashar) [18:07:03] (03PS27) 10Damilare Adedoyin: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1154315 (https://phabricator.wikimedia.org/T388749) [18:07:53] (03PS28) 10Damilare Adedoyin: WIP: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1154315 (https://phabricator.wikimedia.org/T388749) [18:08:40] (03Abandoned) 10Damilare Adedoyin: Add designed template for Login screen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1166409 (https://phabricator.wikimedia.org/T388739) (owner: 10Damilare Adedoyin) [18:11:02] (03CR) 10CI reject: [V:04-1] WIP: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1154315 (https://phabricator.wikimedia.org/T388749) (owner: 10Damilare Adedoyin) [18:13:32] (03PS1) 10Damilare Adedoyin: WIP: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176526 (https://phabricator.wikimedia.org/T388749) [18:13:51] (03Abandoned) 10Damilare Adedoyin: WIP: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1154315 (https://phabricator.wikimedia.org/T388749) (owner: 10Damilare Adedoyin) [18:16:03] (03CR) 10CI reject: [V:04-1] WIP: Create donor portal page for recurring donation pause process. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176526 (https://phabricator.wikimedia.org/T388749) (owner: 10Damilare Adedoyin) [18:36:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: dLocal missing tax ID + status mismatch errors - https://phabricator.wikimedia.org/T401428#11069522 (10jgleeson) a:03jgleeson [18:58:09] oh fun tax id problems ^^^ [18:58:19] (03PS1) 10Jgleeson: Add github linkability for mw core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176534 [19:01:16] (03CR) 10Ejegg: "nice! But it seems to run everything twice for me." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176524 (https://phabricator.wikimedia.org/T399304) (owner: 10Jgleeson) [19:01:56] jgleeson: I think that tox -r is running the tests and linter too [19:02:22] so maybe no need for that next tox incantation [19:02:46] ohhhh [19:03:17] I thought it was running twice due to different testenvs [19:03:32] envlist = discover,flake8 [19:03:40] but your point makes more sense [19:03:49] yep - if i remove the second call, it runs once [19:05:09] (03PS2) 10Jgleeson: Update fundraising-tools tox helper script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176524 (https://phabricator.wikimedia.org/T399304) [19:05:09] (03PS2) 10Jgleeson: Add github linkability for mw core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176534 [19:12:42] (03CR) 10Ejegg: [C:03+2] Update fundraising-tools tox helper script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176524 (https://phabricator.wikimedia.org/T399304) (owner: 10Jgleeson) [19:12:44] (03CR) 10Ejegg: [V:03+2 C:03+2] Update fundraising-tools tox helper script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176524 (https://phabricator.wikimedia.org/T399304) (owner: 10Jgleeson) [19:14:28] thanks ejegg ! [19:16:07] (03CR) 10Ejegg: [C:03+2] Add github linkability for mw core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176534 (owner: 10Jgleeson) [19:16:08] (03CR) 10Ejegg: [V:03+2 C:03+2] Add github linkability for mw core [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1176534 (owner: 10Jgleeson) [19:16:19] ty for the fixes! [19:45:16] (03PS14) 10Damilare Adedoyin: Small fixes and tests to DonorPortal Vue pages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167680 [19:45:19] (03CR) 10Ejegg: [C:03+2] Small fixes and tests to DonorPortal Vue pages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167680 (owner: 10Damilare Adedoyin) [19:49:05] (03PS12) 10Damilare Adedoyin: Add vue navigation guard to check checksum validity [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167615 [19:49:20] (03CR) 10Ejegg: [C:03+2] Add vue navigation guard to check checksum validity [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167615 (owner: 10Damilare Adedoyin) [19:50:46] (03PS4) 10Damilare Adedoyin: Align the new DonorPortal Vue and JS files with DI eslint rules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176252 [19:51:33] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 06Traffic, 07fr-acoustic: Acoustic SMS: Domain needed for short links - https://phabricator.wikimedia.org/T379318#11069658 (10BCornwall) 05Open→03Resolved a:03BCornwall Resolving. Please re-open if this needs mo... [20:07:56] (03CR) 10Ejegg: [C:03+2] "Some nice readability improvements" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176252 (owner: 10Damilare Adedoyin) [20:10:25] (03Merged) 10jenkins-bot: Small fixes and tests to DonorPortal Vue pages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167680 (owner: 10Damilare Adedoyin) [20:12:46] (03Merged) 10jenkins-bot: Add vue navigation guard to check checksum validity [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1167615 (owner: 10Damilare Adedoyin) [20:36:42] (03Merged) 10jenkins-bot: Align the new DonorPortal Vue and JS files with DI eslint rules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176252 (owner: 10Damilare Adedoyin) [20:38:16] (03CR) 10Ejegg: [C:03+2] Improve metadata handling for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176340 (owner: 10Eileen) [20:47:50] (03CR) 10Jgleeson: "Folks, it looks like dlocal is rejecting API call made by Gravy omitting the tax ID for some of the countries updated in this patch. I'm l" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1152387 (https://phabricator.wikimedia.org/T395361) (owner: 10Wfan) [20:48:14] (03CR) 10Jgleeson: "API calls*" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1152387 (https://phabricator.wikimedia.org/T395361) (owner: 10Wfan) [20:48:27] Let me find the thread about omit tax is [20:49:54] https://wikimedia.enterprise.slack.com/archives/C092933D9FH/p1749826879779609 [20:50:03] wfan: I might roll that patch back until we can figure it out with dlocal. We're getting 100s of failures due to the missing tax ids [20:50:53] Ok, revert, do you want to let gravy knows in this thread? [20:50:59] We can follow up here [20:51:00] Yes please [20:51:03] Ok [20:53:36] Oh and here is the other thread of confirming this tax id with love [20:54:12] (03Merged) 10jenkins-bot: Improve metadata handling for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176340 (owner: 10Eileen) [20:54:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: dLocal missing tax ID + status mismatch errors - https://phabricator.wikimedia.org/T401428#11069813 (10jgleeson) @MBeat33, we removed the fiscal number / tax ID requirements for these countries after dLocal advised [[ https://phabri... [20:55:06] https://wikimedia.enterprise.slack.com/archives/C072S0VFH42/p1749739060959609 @jgleeson [20:56:30] ty [20:56:56] (03PS1) 10Jgleeson: Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176544 [21:00:50] wfan: are you ok to +2 that pls ^ [21:01:49] sure [21:01:57] (03CR) 10Wfan: [C:03+2] Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176544 (owner: 10Jgleeson) [21:03:40] ty [21:04:16] (03Merged) 10jenkins-bot: Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1176544 (owner: 10Jgleeson) [21:06:55] (03PS1) 10Jgleeson: Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1176545 [21:09:05] fr-tech the diff between master and deploy on donation interface is pretty big and it includes a smashpig bump so for now I'm just gonna cherry pick the revert I pushed up and push that out on its own. I'm dropping off shortly and I don't really want to push out a big deployment without having enough time to confidently confirm nothing is broken. [21:09:19] (03CR) 10Jgleeson: [C:03+2] Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1176545 (owner: 10Jgleeson) [21:09:55] it's also thurfriday [21:10:04] so the deploy demons will be watching [21:10:22] ack, makes sense to cherry-pick in this case [21:10:26] (03Merged) 10jenkins-bot: Revert "do not pass fiscal number to gravy dlocal with waiver" [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1176545 (owner: 10Jgleeson) [21:10:36] thanks both jgleeson and wfan [21:11:23] thanks jgleeson [21:11:44] and wfan [21:11:51] Thanks Jack! [21:12:38] (this is where gmeet would do a celebration explosion) [21:12:55] lol [21:16:18] ok that's been deployed and the tax ID / fiscal number fields are back [21:16:27] !log payments-wiki upgraded from 0ab5bab9 to 0a1084a8 [21:16:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:29:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations: dLocal missing tax ID + status mismatch errors - https://phabricator.wikimedia.org/T401428#11069865 (10jgleeson) That change has been deployed, and I can now see successful donations from Chilean donors coming in [[ https://wikimed... [21:32:32] have a good long weekend fr-tech, see you all next week! [21:32:39] o/ [21:53:53] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451 (10Eileenmcnaughton) 03NEW [22:04:26] hi eileen - i've been trying to reproduce the build locally [22:04:51] there's a guide at https://doc.wikimedia.org/quibble/ , but it's pretty specific to running the Mediawiki tests [22:05:07] however it's at least got some useful command-line examples [22:05:59] I ended up being able to run /something/ by creating the recommended directories, then checking out crm into src/wikimedia/fundraising/crm [22:06:35] ejegg: I did add https://phabricator.wikimedia.org/T401451 [22:07:07] then running the docker CLI from the failed test run [22:07:11] docker run -e WORKSPACE= --volume ./src:/src --volume ./cache:/cache --volume ./log:/log --security-opt seccomp=unconfined --init --rm --label jenkins.job=wikimedia-fundraising-civicrm-bookworm --label jenkins.build=1567 --env-file=./.env docker-registry.wikimedia.org/releng/civicrm:0.5 [22:07:18] also ejegg - I think if we get to the end of this - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1176359 - I feel pretty OK about the update side (not the backfill) [22:07:41] ah right, I had started reviewing that [22:07:49] but focus time has been scarce today [22:07:59] yeah! [22:08:05] it's probably higher priority [22:08:15] just got relieved of baby-duty again, so I'll maybe focus on that [22:10:35] I think we are inching towards a better organization of what code does what [22:17:25] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070019 (10greg) Kindly asking for help diagnosing this #releng. [22:34:21] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070036 (10dancy) 05Open→03In progress a:03dancy I'll see what I can do. [22:41:49] (03CR) 10Ejegg: [C:03+2] Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [22:45:12] (03CR) 10Ejegg: [C:03+2] Update opt_out on update (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [22:45:37] (03CR) 10Ejegg: [C:03+2] Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 (owner: 10Eileen) [22:47:56] (03CR) 10Ejegg: [C:03+2] Add commentry (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176355 (owner: 10Eileen) [22:48:30] ejegg: can you push that up as a follow up? [22:48:37] - ie your comment [22:48:53] I guess it also begs the question as to whether it is handled on update too [22:52:29] oh sure [22:52:51] are we getting any opt_in on recurring contributions? [22:53:28] I'm trying to see where we set the contribution_recur_id outside of donations sent from the recurring charge job [22:56:04] (03Merged) 10jenkins-bot: Clean up WMFSave handling of contact updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176347 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [23:02:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 13Patch-For-Review: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070058 (10Eileenmcnaughton) @dancy a huge thanks - can you also add [23:02:43] (03Merged) 10jenkins-bot: Update opt_out on update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176348 (https://phabricator.wikimedia.org/T401353) (owner: 10Eileen) [23:02:45] (03Merged) 10jenkins-bot: Remove legacy Organization custom fields from queue methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176351 (owner: 10Eileen) [23:02:48] (03Merged) 10jenkins-bot: Add commentry [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176355 (owner: 10Eileen) [23:03:46] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 13Patch-For-Review: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070059 (10Eileenmcnaughton) Also - what is the publish process / timeline? [23:08:46] (03PS1) 10Ejegg: Comments on employer message fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176550 [23:13:57] (03CR) 10Eileen: [C:03+2] Comments on employer message fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176550 (owner: 10Ejegg) [23:19:08] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 13Patch-For-Review: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070063 (10dancy) >>! In T401451#11070058, @Eileenmcnaughton wrote: > @dancy a huge thanks - can you also add `php-mysqli`... [23:19:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 13Patch-For-Review: CI build - missing patch & mysqli? - https://phabricator.wikimedia.org/T401451#11070065 (10Eileenmcnaughton) @dancy thank you very much! [23:20:32] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1174877 (owner: 10Eileen) [23:33:47] (03Merged) 10jenkins-bot: Comments on employer message fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1176550 (owner: 10Ejegg)