[01:44:18] (03PS4) 10Eileen: Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 [01:44:20] (03CR) 10Ejegg: [C:03+2] Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 (owner: 10Eileen) [01:50:19] (03PS1) 10Eileen: Make moving completed optional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189378 [01:50:19] (03PS1) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 [01:57:23] (03CR) 10Ejegg: [C:03+2] build: Handle excluded CommentBeforeClass sniff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189272 (owner: 10Umherirrender) [01:59:53] (03Merged) 10jenkins-bot: build: Handle excluded CommentBeforeClass sniff [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1189272 (owner: 10Umherirrender) [02:00:13] (03CR) 10Ejegg: "With this change you can shrink the next if condition since we know both are truthy" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189300 (owner: 10Eileen) [02:01:07] (03CR) 10Eileen: Build on auth fix (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189300 (owner: 10Eileen) [02:01:16] (03Merged) 10jenkins-bot: Swap out apiv3 to apiv4 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187105 (owner: 10Eileen) [02:03:00] eileen is it possible that the authenticatorTarget has either userId or contactId falsy ? [02:04:03] They are cast to a string for the comparison... I think we can hack it for now & maybe tomorrow I can check with Tim/ Ben [02:06:25] looks like AuthenticatorTarget::setPrincipal allows just one or the other [02:06:38] https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/core/ext/authx/Civi/Authx/Authenticator.php$464 [02:06:53] oh i see, but then it looks up the missing onefrom UFMatch [02:08:23] ok, back to looking at the settlement fields for now [02:11:22] (03CR) 10CI reject: [V:04-1] Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 (owner: 10Eileen) [02:13:02] eileen: so the getSettlementFields class on the message doesn't populate any of the fields if there's no settled date? [02:13:38] ejegg: no - it's still a bit WIP - but the current thinking is no settlement without a date [02:13:44] k [02:14:38] ok, and we have different settlement fields for settled amount and settled reversal amount [02:14:53] in case the refund doesn't match the original amount [02:15:41] so should there also be a settled_reversal_date? [02:18:14] (03CR) 10Ejegg: [C:03+2] "Looks pretty solid! Couple of questions inline" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:18:28] (03PS6) 10Eileen: Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 [02:18:37] (03CR) 10Ejegg: [C:03+2] Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:19:05] (03PS6) 10Eileen: Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 [02:19:08] (03CR) 10Ejegg: [C:03+2] Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 (owner: 10Eileen) [02:19:54] ejegg: we can possibly wrap up this one too? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1179992 [02:30:48] right, that way looks safe enough [02:32:27] (03PS12) 10Eileen: Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 [02:32:34] (03CR) 10Ejegg: [C:03+2] Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 (owner: 10Eileen) [02:35:19] (03Merged) 10jenkins-bot: Start to populate settlement fields on refund [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187106 (owner: 10Eileen) [02:35:31] (03Merged) 10jenkins-bot: Remove obsolete comment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187119 (owner: 10Eileen) [02:37:06] k, i can see where in coworker it's calling login with the runAs params [02:37:22] but i'm still a little foggy as to what the existing code is doing wrong [02:37:29] lemme read that upstream pull request again [02:40:00] eileen: ah so coworker was hitting the same bug as https://lab.civicrm.org/dev/core/-/issues/4463, i guess when running the second task? [02:40:48] ejegg: well I'm not sure - I feel like it was failing to go from no user to having a user [02:40:49] oh huh, those are a bit old [02:48:01] shoot, I can't quite understand that enough to merge changes to auth logic right now [02:48:25] but that does leave the opt-in backfill un-deployable, huh? [02:48:50] eileen: did you need to deploy other stuff tonight/today? [02:49:26] (03Merged) 10jenkins-bot: Add order_id to fields normalized in the AuditMessage class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1179992 (owner: 10Eileen) [02:49:33] ejegg: I think that auth logic is just loosening the login in a possibly hacky way - so might not be blocking... [02:51:25] but ejegg I'm around tomorrow so can leave overnight [02:52:26] cool cool, i need to get some sleep [02:52:34] cya later! [03:39:35] (03PS1) 10Eileen: Update Audit message due to fundraise_up, ingenico removal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 [03:40:06] if someone can +2 ^^ (or I will self-do-it)- the order one turns out to have references to since-removed fundraise up, ingenico [04:20:21] (03CR) 10Eileen: [C:03+2] "self-merging to avoid fall out from functions removed after the initial patch was put up" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 (owner: 10Eileen) [04:37:43] (03Merged) 10jenkins-bot: Update Audit message due to fundraise_up, ingenico removal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189382 (owner: 10Eileen) [05:02:48] (03PS2) 10Eileen: Make moving completed optional [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189378 [05:02:48] (03PS2) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 [05:18:15] (03PS6) 10Eileen: Minor tidy ups - move currency handling to Message class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1187120 [05:24:21] (03CR) 10CI reject: [V:04-1] Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379 (owner: 10Eileen) [05:29:43] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Acoustic requests / questions - https://phabricator.wikimedia.org/T378974#11192460 (10MSuijkerbuijk_WMF) Sounds good [05:33:50] (03PS3) 10Eileen: Load transaction from SmashPig [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1189379