[00:24:11] <wikibugs>	 (03open) 10dwisehaupt: Upgrade civi to 6.9.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/28
[00:27:33] <wikibugs>	 10fundraising-tech-ops: Update kafkatee puppet process to remove output configs when the are no longer present in puppet - https://phabricator.wikimedia.org/T413144 (10Dwisehaupt) 03NEW
[00:44:06] <wikibugs>	 06Fundraising-Backlog, 10fundraising-tech-ops, 10Observability-Alerting, 13Patch-For-Review: Shift frack alerting to use prometheus-alertmanager instead of icinga - https://phabricator.wikimedia.org/T367370#11474922 (10Dwisehaupt)
[00:51:22] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Get last donation date for active donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219649 (https://phabricator.wikimedia.org/T413132) (owner: 10Ejegg)
[01:30:44] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] Drop cancel IPNs if already cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219200 (https://phabricator.wikimedia.org/T412539) (owner: 10Ejegg)
[01:31:46] <wikibugs>	 (03CR) 10Eileen: "OK - I think I get it" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1219221 (https://phabricator.wikimedia.org/T409958) (owner: 10Lars SG)
[01:31:48] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Prevent opting out of emails when shared. [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1219221 (https://phabricator.wikimedia.org/T409958) (owner: 10Lars SG)
[01:33:08] <wikibugs>	 (03Merged) 10jenkins-bot: Prevent opting out of emails when shared. [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1219221 (https://phabricator.wikimedia.org/T409958) (owner: 10Lars SG)
[01:48:30] <wikibugs>	 (03Merged) 10jenkins-bot: Drop cancel IPNs if already cancelled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219200 (https://phabricator.wikimedia.org/T412539) (owner: 10Ejegg)
[02:06:07] <wikibugs>	 (03PS2) 10Cstone: Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488)
[02:15:26] <wikibugs>	 (03merge) 10dwisehaupt: Upgrade civi to 6.9.1 [repos/fundraising-tech/community-civicrm] - 10https://gitlab.wikimedia.org/repos/fundraising-tech/community-civicrm/-/merge_requests/28
[02:22:40] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488) (owner: 10Cstone)
[02:28:24] <wikibugs>	 (03PS3) 10Cstone: Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488)
[02:44:42] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488) (owner: 10Cstone)
[02:49:00] <wikibugs>	 (03PS2) 10Ejegg: Update composer.lock for new SmashPig version [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1219611
[02:49:04] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update composer.lock for new SmashPig version [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1219611 (owner: 10Ejegg)
[02:53:05] <ejegg>	 !log payments-wiki upgraded from 8a207d81 to 14e22620
[02:53:07] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[02:53:11] <ejegg>	 woot, got API timings in the logs
[03:01:46] <wikibugs>	 (03Merged) 10jenkins-bot: Update composer.lock for new SmashPig version [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1219611 (owner: 10Ejegg)
[03:03:58] <wikibugs>	 (03PS3) 10Eileen: Add dlocal fee fields [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1208137
[03:04:00] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Add dlocal fee fields [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1208137 (owner: 10Eileen)
[03:04:29] <wikibugs>	 (03Merged) 10jenkins-bot: Add dlocal fee fields [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1208137 (owner: 10Eileen)
[03:05:03] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: clarify preloadScript() semantics and rename param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1218770
[03:05:19] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "Thanks for the clarity!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1218770 (owner: 10Jgleeson)
[03:07:17] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: clarify preloadScript() semantics and rename param [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1218770 (owner: 10Jgleeson)
[03:20:39] <wikibugs>	 (03CR) 10Ejegg: [C:04-1] "Argh, and there seems to be no 'setTotalAmount' or 'setLineItems' function on that venmoInstance. Well that's no good - it looks like you " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219580 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[03:23:09] <wikibugs>	 (03CR) 10Ejegg: "OK, my earlier complaint seems out of scope of this ticket. Though I do see this comment in the 'totalAmount' docs: https://braintree.gith" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219580 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[03:37:17] <wikibugs>	 (03PS4) 10Cstone: Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488)
[04:37:38] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488) (owner: 10Cstone)
[04:38:09] <cstone>	 thanks eileen 
[04:39:42] <wikibugs>	 (03CR) 10Eileen: [C:03+1] "Note I'm +2 on this if it is merged with my follow on which fixes the financial items" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1193439 (https://phabricator.wikimedia.org/T405765) (owner: 10Ejegg)
[04:42:15] <eileen>	 no worries - looked like I missed ejegg|away on pinning down that currency .... I'm ok with his patch + my one
[04:49:38] <cstone>	 eileen: if i test both of them want me to +2 yours then or do you want him to look at it?
[04:50:28] <eileen>	 cstone: go ahead & +2 - I'm happy with them both together - the financial items are obscure but the upstream tests picked it up (and it also affects some other scenarios)
[04:55:11] <wikibugs>	 (03Merged) 10jenkins-bot: Switch failure email to new type, remove text from activity subject [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219239 (https://phabricator.wikimedia.org/T365488) (owner: 10Cstone)
[05:09:31] <cstone>	 this code  is all about changing the currency once its already in civi right eileen ?
[05:10:29] <eileen>	 yep - so the idea is that under the hood it should reverse out the financial items, financial trxn & then recreate with the right currency
[05:10:43] <cstone>	 lul why does it tell me direct mail is required
[05:10:57] <cstone>	 ok cool i see it
[05:11:29] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Fix changeCurrency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219218 (https://phabricator.wikimedia.org/T405765) (owner: 10Eileen)
[05:27:54] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Fix financial txn rows on contribution convert [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1193439 (https://phabricator.wikimedia.org/T405765) (owner: 10Ejegg)
[05:28:31] <wikibugs>	 (03PS2) 10Eileen: Fix changeCurrency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219218 (https://phabricator.wikimedia.org/T405765)
[05:28:52] <eileen>	 and once again we got a non-conflict merge conflict...
[05:33:43] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Fix changeCurrency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219218 (https://phabricator.wikimedia.org/T405765) (owner: 10Eileen)
[05:49:34] <wikibugs>	 (03Merged) 10jenkins-bot: Fix changeCurrency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219218 (https://phabricator.wikimedia.org/T405765) (owner: 10Eileen)
[06:16:14] <icinga-wm>	 PROBLEM - check_memory on fransw2003 is CRITICAL: CRIT Memory 95% used. Largest process: trino-server-co (3848879) = 93.8% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[06:21:14] <icinga-wm>	 PROBLEM - check_memory on fransw2003 is CRITICAL: CRIT Memory 95% used. Largest process: trino-server-co (3848879) = 93.8% https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[06:31:14] <icinga-wm>	 RECOVERY - check_memory on fransw2003 is OK: OK Memory 83% used https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fransw2003&service=check_memory
[13:41:54] <jgleeson>	 !log payments-wiki upgraded from 14e22620 to 4d41d604
[13:41:56] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[13:45:31] <jgleeson>	 thanks for the review last night ejegg|away 
[13:47:09] <jgleeson>	 I'm gonna take a crack at restructuring our Venmo JS, so we pull the amount field at the last moment and try to avoid the scenarios you highlighted. 
[13:49:09] <jgleeson>	 but first, I'm gonna go grab the kids. they break up early at 2 pm today as they're now finished for the holidays. chaos christmas crew duties to come. 
[13:49:14] <jgleeson>	 back soon
[14:44:54] <wikibugs>	 03Fundraising Sprint: Yabba Dabba Stew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Change recurring donation frequency from monthly to yearly in the civi UI - https://phabricator.wikimedia.org/T396541#11476950 (10AMJohnson) Hi @Lars!   Regarding your note above //"if you hav...
[15:48:12] <wikibugs>	 (03Abandoned) 10Jgleeson: Pass total amount to Venmo payment request [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219580 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[16:07:24] <ejegg>	 damilare: I made a bunch of tiny fixes to the donor portal yesterday - would you have any time to review today?
[16:08:19] <ejegg>	 it would be the top 4 on this search: https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/DonationInterface+status:open+owner:ejegg@ejegg.com
[16:08:31] <wikibugs>	 (03Abandoned) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1217348 (owner: 10Ejegg)
[16:09:10] <ejegg>	 oh let's see if that CRM conversion patch went out
[16:09:20] <ejegg>	 looks like eileen fixed some bugs in my original patch
[16:10:18] <damilare>	 sure thing ejegg 
[16:10:22] <ejegg>	 thanks!
[16:11:07] <ejegg>	 OK, I think I'm going to cherry-pick just a few patches to civicrm deploy
[16:11:25] <ejegg>	 to see if I can clean up those wrong-currency donations before leaving for the holidays
[16:13:04] <wikibugs>	 (03PS1) 10Ejegg: Get last donation date for active donations [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219888 (https://phabricator.wikimedia.org/T413132)
[16:13:06] <wikibugs>	 (03PS1) 10Ejegg: Drop cancel IPNs if already cancelled [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219889 (https://phabricator.wikimedia.org/T412539)
[16:13:08] <wikibugs>	 (03PS1) 10Ejegg: Fix financial txn rows on contribution convert [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219890 (https://phabricator.wikimedia.org/T405765)
[16:13:10] <wikibugs>	 (03PS1) 10Ejegg: Fix changeCurrency [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219891 (https://phabricator.wikimedia.org/T405765)
[16:13:27] <wikibugs>	 (03CR) 10Ejegg: [V:03+2 C:03+2] Get last donation date for active donations [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219888 (https://phabricator.wikimedia.org/T413132) (owner: 10Ejegg)
[16:13:38] <wikibugs>	 (03CR) 10Ejegg: [V:03+2 C:03+2] Drop cancel IPNs if already cancelled [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219889 (https://phabricator.wikimedia.org/T412539) (owner: 10Ejegg)
[16:13:53] <wikibugs>	 (03CR) 10Ejegg: [V:03+2 C:03+2] Fix financial txn rows on contribution convert [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219890 (https://phabricator.wikimedia.org/T405765) (owner: 10Ejegg)
[16:14:40] <wikibugs>	 (03CR) 10Ejegg: [V:03+2 C:03+2] Fix changeCurrency [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1219891 (https://phabricator.wikimedia.org/T405765) (owner: 10Ejegg)
[16:15:09] <wikibugs>	 10Fundraising analytics stack: Connect Trino to banner data (Kafka topic) - https://phabricator.wikimedia.org/T377625#11477256 (10IAckerman-WMF) Let's get @JMando 's input!
[16:18:20] <ejegg>	 !log civicrm upgraded from 878d168c to 4eee8c62
[16:18:22] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[16:28:24] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Point 'feedback' link after cancel to survey [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219618 (https://phabricator.wikimedia.org/T413107) (owner: 10Ejegg)
[16:33:42] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+1] "Looks good, just to confirm this was not intended to be limited to cancellations from the DonorPortal alone?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219629 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[16:34:23] <wikibugs>	 (03PS1) 10Jgleeson: Refactor braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074)
[16:34:44] <jgleeson>	 let's see if that fails CI due to JS lint issues
[16:34:51] <jgleeson>	 I can't recall how we run that locally so I'll let CI show me
[16:35:00] <jgleeson>	 grunt eslint I think
[16:38:22] <jgleeson>	 ah it passed
[16:38:24] <jgleeson>	 ok
[16:38:25] <jgleeson>	 nvm
[16:49:02] <wikibugs>	 (03Merged) 10jenkins-bot: Point 'feedback' link after cancel to survey [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219618 (https://phabricator.wikimedia.org/T413107) (owner: 10Ejegg)
[16:50:04] <wikibugs>	 (03CR) 10Ejegg: "Right Dami, it's supposed to include ones that the donor asked DR to cancel for them too" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219629 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[16:51:58] <wikibugs>	 10Fundraising analytics stack: Create dev environment for Dagster - https://phabricator.wikimedia.org/T382378#11477478 (10IAckerman-WMF) Looks like David Booke authored the ticket a year ago.
[17:01:11] <wikibugs>	 (03PS1) 10Jgleeson: Refactor: Centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908
[17:02:35] <wikibugs>	 (03PS2) 10Ejegg: Hide last donation date text when it's null [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219648 (https://phabricator.wikimedia.org/T413132)
[17:02:49] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: Tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074)
[17:02:49] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: Centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908
[17:03:40] <wikibugs>	 (03PS2) 10Ejegg: Show 'Cancelled' status for donor-initiated cancels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113)
[17:16:43] <wikibugs>	 03Fundraising Sprint: Yabba Dabba Stew, 06Fundraising-Backlog, 10FR-Donor-portal: Cancel donation - share more feedback should be surveymonkey not mailto link - https://phabricator.wikimedia.org/T413107#11477585 (10Ejegg)
[17:24:34] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913
[17:28:09] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Add 'Cancel Support' to the cancel reasons as it is specified on DonorPortal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219915
[17:47:33] <wikibugs>	 10Fundraising analytics stack, 10fundraising-tech-ops: Turnilo access for hahmed-ctr@wikimedia.org - https://phabricator.wikimedia.org/T413250 (10HAhmed-WMF) 03NEW
[18:01:44] <wikibugs>	 (03PS1) 10Lars SG: Also prevent editing of any recurring details for paypal payment processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219920 (https://phabricator.wikimedia.org/T396541)
[18:06:55] <wikibugs>	 03Fundraising Sprint: Yabba Dabba Stew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal, 13Patch-For-Review: Change recurring donation frequency from monthly to yearly in the civi UI - https://phabricator.wikimedia.org/T396541#11477839 (10Lars) @AMJohnson Yes, you can still canc...
[18:07:19] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for confirming on standup. LGTM!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219629 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[18:21:04] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913
[18:22:48] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "LGTM! We'd probably need to create a new style (background and font colour) for the new status to distinguish from 'Lapsed' status." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[18:23:47] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Hide last donation date text when it's null [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219648 (https://phabricator.wikimedia.org/T413132) (owner: 10Ejegg)
[18:28:11] <wikibugs>	 (03Merged) 10jenkins-bot: Add donor_cancelled to getDonorSummary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219629 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[18:37:54] <wikibugs>	 (03Merged) 10jenkins-bot: Hide last donation date text when it's null [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219648 (https://phabricator.wikimedia.org/T413132) (owner: 10Ejegg)
[18:44:24] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 05MW-1.46-notes (1.46.0-wmf.7; 2025-12-16): Duplicate donations made via Apple Pay and Google Pay from the WP app - https://phabricator.wikimedia.org/T407383#11478002 (10Cstone) Adding an update to what has been going on as it's s...
[18:49:12] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913 (owner: 10Damilare Adedoyin)
[18:49:29] <wikibugs>	 (03PS3) 10Ejegg: Show 'Cancelled' status for donor-initiated cancels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113)
[18:49:33] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913
[18:49:34] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913 (owner: 10Damilare Adedoyin)
[18:49:55] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Add duplicated recurring reason [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219928
[18:49:58] <ejegg>	 transient V-1, already retesting
[18:50:18] <ejegg>	 Ah damilare, they said they didn't want that one in the frontend I think
[18:50:38] <ejegg>	 or... did I miss that in the list?
[18:50:56] <jgleeson>	 Jeff_Green: so to circle back on the log structure. I went with [adyen|cc|authorise|request|time] for now to measure time, but that format also lets us do things like  [adyen|cc|authorise|request|error] and  [adyen|cc|authorise|request|success] / [adyen|cc|authorise|request|fail]. With that, you can imagine how a graph showing precise event success/fails/errors/speed by process/method could help us spot trends and confirm 
[18:50:56] <jgleeson>	 issues in realish-time
[18:51:15] <damilare>	 oh no, I just saw it in civi and htought itd be a nice to have
[18:51:25] <damilare>	 on the frontend
[18:51:36] <ejegg>	 right, it does seem to fit
[18:52:30] <jgleeson>	 one big one that donor relations is interesting in is recurring signup failures so again [adyen|cc|recurring-charge|request|fail] could help us there
[18:52:31] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add duplicated recurring reason [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219928 (owner: 10Damilare Adedoyin)
[18:52:48] <jgleeson>	 but that structure can lend itself to a lot of different metrics
[18:53:03] <jgleeson>	 interested*
[18:53:34] <Jeff_Green>	 jgleeson: makes sense, so in prometheus terms that would be stored like this: "whatever_the_metric_name_is{whatever_we_decide_to_name_the_label="adyen|cc|authorise|request|error"} 0.29394"
[18:54:07] <jgleeson>	 so that would be for timings
[18:54:11] <jgleeson>	 the 0.222
[18:54:40] <jgleeson>	 Is there a way to give you counts as booleans or just the existence of a line?
[18:54:47] <Jeff_Green>	 with a little more work I could make syslog_collector handle more than one label, which would make it possible to store each of the '|' delimited strings to separate labels, I have an idea how to do it but it would take some work
[18:55:08] <Jeff_Green>	 not sure what you mean re counts?
[18:55:36] <jgleeson>	 I mean like if we get 10  [adyen|cc|authorise|request|fail] log lines it would be good to see that. we don't need an avg
[18:56:07] <jgleeson>	 we can infer from that, adyen's auth is failing
[18:56:30] <ejegg>	 or we're getting a fraud cluster
[18:56:38] <jgleeson>	 ^^
[18:56:52] <Jeff_Green>	 the collector can do one of two things with a single collection rule, it can either keep count of the lines it captures, or it can do aggregation of a value it captures
[18:57:12] <jgleeson>	 perfect
[18:57:23] <jgleeson>	 both of those are exactly what we need
[18:57:30] <Jeff_Green>	 so I think what you're saying would translate into two rules, one which counts the occurences and the other that captures the timing and does something with it
[18:57:41] <jgleeson>	 yep
[18:59:00] <jgleeson>	 this would help us see how well gravy performs too
[18:59:01] <Jeff_Green>	 will these all be logged with the same syslog tag? or will that vary?
[18:59:24] <jgleeson>	 current thinking is they will all be one tag
[18:59:50] <Jeff_Green>	 cool, that makes it easy to match them
[18:59:51] <jgleeson>	 we could put them in one of our generic log files too
[18:59:55] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Add duplicated recurring reason [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219928
[19:00:06] <jgleeson>	 that way it's not processor-specific to scrape 
[19:00:57] <Jeff_Green>	 makes sense
[19:04:53] <dwisehaupt>	 Jeff_Green: i would support the work to move the | separated to multiple labels. since it would allow broader queries such as metric_name{step=auth,state=fail} and have it work across providers
[19:05:11] <Jeff_Green>	 cool
[19:05:22] <jgleeson>	 nice
[19:05:38] <Jeff_Green>	 i thought of a way to do it that isn't too funky configwise, I'll make it so
[19:07:14] <Jeff_Green>	 I also have an idea of a way to do message count and the aggregation function with a single rule, maybe I'll do that too b/c it's less regex processing time
[19:08:30] <Jeff_Green>	 i.e. a rule would always count, and optionally store aggregated values noted with a label
[19:10:04] <Jeff_Green>	 metric_name{provider="adyen", method="cc", stage="authorise", idunno="request", result="error", format="count"} 29"
[19:10:21] <Jeff_Green>	 metric_name{provider="adyen", method="cc", stage="authorise", idunno="request", result="error", format="average"} 0.037"
[19:10:26] <Jeff_Green>	 or similar
[19:11:04] <Jeff_Green>	 or I guess it could be a suffix on the metric name like metric_name_count{...}
[19:13:21] <dwisehaupt>	 yeah. i'd do metric_name_count / metric_name_avg
[19:13:28] <Jeff_Green>	 cool
[19:36:40] <ejegg>	 aha, i've got chaining working to fix the wrong-currency contributions
[19:47:34] <wikibugs>	 (03PS3) 10Jgleeson: Refactor: Tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074)
[19:47:34] <wikibugs>	 (03PS3) 10Jgleeson: Refactor: Centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074)
[19:47:36] <wikibugs>	 (03PS1) 10Jgleeson: Venmo: create component on button click [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219931 (https://phabricator.wikimedia.org/T413074)
[19:47:37] <wikibugs>	 (03PS1) 10Jgleeson: Refactor: extract out Venmo component creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219932 (https://phabricator.wikimedia.org/T413074)
[19:47:39] <wikibugs>	 (03PS1) 10Jgleeson: Venmo: pass totalAmount at click time [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219933 (https://phabricator.wikimedia.org/T413074)
[19:47:41] <wikibugs>	 (03PS1) 10Jgleeson: Refactor: reorder braintree.js helper functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219934 (https://phabricator.wikimedia.org/T413074)
[19:47:43] <wikibugs>	 (03PS1) 10Jgleeson: Refactor: align PayPal client instance naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219935 (https://phabricator.wikimedia.org/T413074)
[19:50:10] <jgleeson>	 ok ejegg, that patch chain ^ gets us post-validation amount assignment for Venmo transactions. after a slight restructure of things, adding the total amount in was a small, isolated change. 
[19:51:22] <ejegg>	 nice, will look in just a few min
[19:51:31] <jgleeson>	 argh.. casing inconsistencies 
[19:51:39] <jgleeson>	 lemme fix those commit messages
[19:51:51] <jgleeson>	 (the import things)
[19:51:59] <jgleeson>	 important!
[19:52:04] <jgleeson>	 like the css rule
[19:52:54] <wikibugs>	 (03PS4) 10Jgleeson: Refactor: tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074)
[19:53:08] <wikibugs>	 (03PS4) 10Jgleeson: Refactor: centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074)
[19:53:16] <wikibugs>	 (03PS5) 10Jgleeson: Refactor: centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074)
[19:53:23] <wikibugs>	 (03PS2) 10Jgleeson: Venmo: create component on button click [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219931 (https://phabricator.wikimedia.org/T413074)
[19:53:30] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: extract out Venmo component creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219932 (https://phabricator.wikimedia.org/T413074)
[19:53:39] <wikibugs>	 (03PS2) 10Jgleeson: Venmo: pass totalAmount at click time [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219933 (https://phabricator.wikimedia.org/T413074)
[19:53:45] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: reorder braintree.js helper functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219934 (https://phabricator.wikimedia.org/T413074)
[19:53:51] <wikibugs>	 (03PS2) 10Jgleeson: Refactor: align PayPal client instance naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219935 (https://phabricator.wikimedia.org/T413074)
[19:54:19] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 05MW-1.46-notes (1.46.0-wmf.7; 2025-12-16): Duplicate donations made via Apple Pay and Google Pay from the WP app - https://phabricator.wikimedia.org/T407383#11478344 (10Dwisehaupt) Per adyen's request, I captured traceroutes to t...
[19:54:39] <wikibugs>	 (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[20:01:35] <wikibugs>	 (03PS3) 10Thiemo Kreuz (WMDE): Update code to use various recent PHP features [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1206820
[20:01:36] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update code to use various recent PHP features [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1206820 (owner: 10Thiemo Kreuz (WMDE))
[20:05:58] <wikibugs>	 (03Merged) 10jenkins-bot: Update code to use various recent PHP features [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1206820 (owner: 10Thiemo Kreuz (WMDE))
[20:24:56] <wikibugs>	 (03PS2) 10Wfan: update depreciated function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1215719
[20:24:57] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] update depreciated function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1215719 (owner: 10Wfan)
[20:25:24] <wikibugs>	 (03Merged) 10jenkins-bot: update depreciated function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1215719 (owner: 10Wfan)
[20:25:43] <wikibugs>	 (03CR) 10Ejegg: "resubmit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[20:40:37] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "re-applying C+2 to prompt CI to submit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[20:42:49] <wikibugs>	 (03Merged) 10jenkins-bot: Show 'Cancelled' status for donor-initiated cancels [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219630 (https://phabricator.wikimedia.org/T413113) (owner: 10Ejegg)
[20:42:51] <wikibugs>	 (03Merged) 10jenkins-bot: Update casing on donor cancel reasons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219913 (owner: 10Damilare Adedoyin)
[20:44:38] <wikibugs>	 (03PS2) 10Ejegg: Unlink other amount box from other radio buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219637 (https://phabricator.wikimedia.org/T413106)
[20:53:04] <wikibugs>	 (03PS5) 10Jgleeson: Refactor: tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074)
[20:53:05] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Refactor: tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[20:53:31] <wikibugs>	 (03PS6) 10Jgleeson: Refactor: centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074)
[20:53:32] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Refactor: centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[20:55:17] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: tidy up braintree.js Venmo code. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219898 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[20:55:39] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: centralise Braintree client creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219908 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[20:57:30] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Unlink other amount box from other radio buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219637 (https://phabricator.wikimedia.org/T413106) (owner: 10Ejegg)
[20:59:38] <wikibugs>	 (03Merged) 10jenkins-bot: Unlink other amount box from other radio buttons [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219637 (https://phabricator.wikimedia.org/T413106) (owner: 10Ejegg)
[21:07:19] <wikibugs>	 (03PS3) 10Jgleeson: Venmo: create component on button click [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219931 (https://phabricator.wikimedia.org/T413074)
[21:07:23] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Venmo: create component on button click [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219931 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:08:07] <wikibugs>	 (03PS3) 10Jgleeson: Refactor: extract out Venmo component creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219932 (https://phabricator.wikimedia.org/T413074)
[21:08:10] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Refactor: extract out Venmo component creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219932 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:10:13] <wikibugs>	 (03Merged) 10jenkins-bot: Venmo: create component on button click [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219931 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:12:44] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: extract out Venmo component creation [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219932 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:12:50] <wikibugs>	 (03PS3) 10Jgleeson: Venmo: pass totalAmount at click time [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219933 (https://phabricator.wikimedia.org/T413074)
[21:12:54] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Venmo: pass totalAmount at click time [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219933 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:14:32] <wikibugs>	 (03Merged) 10jenkins-bot: Venmo: pass totalAmount at click time [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219933 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:16:02] <wikibugs>	 (03PS3) 10Jgleeson: Refactor: reorder braintree.js helper functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219934 (https://phabricator.wikimedia.org/T413074)
[21:16:03] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Refactor: reorder braintree.js helper functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219934 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:16:45] <wikibugs>	 (03PS3) 10Jgleeson: Refactor: align PayPal client instance naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219935 (https://phabricator.wikimedia.org/T413074)
[21:16:47] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Refactor: align PayPal client instance naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219935 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:18:23] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: reorder braintree.js helper functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219934 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:18:55] <wikibugs>	 (03Merged) 10jenkins-bot: Refactor: align PayPal client instance naming [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1219935 (https://phabricator.wikimedia.org/T413074) (owner: 10Jgleeson)
[21:21:29] <wikibugs>	 (03PS2) 10Esanders: eslint: Remove unnecessary overrides [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219565
[21:21:31] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] eslint: Remove unnecessary overrides [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219565 (owner: 10Esanders)
[21:24:12] <wikibugs>	 (03PS2) 10Esanders: eslint: Fix documentation wranings [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219566
[21:24:17] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] eslint: Fix documentation wranings [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219566 (owner: 10Esanders)
[21:31:40] <wikibugs>	 (03Merged) 10jenkins-bot: eslint: Remove unnecessary overrides [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219565 (owner: 10Esanders)
[21:31:40] <wikibugs>	 (03Merged) 10jenkins-bot: eslint: Fix documentation wranings [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219566 (owner: 10Esanders)
[21:35:08] <wikibugs>	 (03CR) 10Ejegg: [C:04-1] "Just one seems off" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1219567 (owner: 10Esanders)
[21:43:30] <wikibugs>	 (03PS2) 10Lars SG: Don't resnooze if snooze date is unchanged. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219203 (https://phabricator.wikimedia.org/T392726)
[21:45:15] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "Looks good! While testing, I see that any edit to any email field, including adding a new email to a contact who has one snoozed email, wo" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219203 (https://phabricator.wikimedia.org/T392726) (owner: 10Lars SG)
[21:56:06] <larssandergreen>	 ejegg: thanks for the review on snooze date one above. Yes, any save on that email form triggers the custom hook, but it is something automated that's triggering the resnooze because it always happens 24 hours (plus a few seconds) after the last one. But fingers crossed that it will solve the issue anyways.
[22:01:45] <wikibugs>	 (03Merged) 10jenkins-bot: Don't resnooze if snooze date is unchanged. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1219203 (https://phabricator.wikimedia.org/T392726) (owner: 10Lars SG)
[22:08:55] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 05MW-1.46-notes (1.46.0-wmf.7; 2025-12-16): Duplicate donations made via Apple Pay and Google Pay from the WP app - https://phabricator.wikimedia.org/T407383#11478824 (10Dwisehaupt) We are now collecting the mtr data on each of th...