[00:27:50] (03PS1) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [00:34:10] (03PS2) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [00:52:32] (03CR) 10CI reject: [V:04-1] Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 (owner: 10Eileen) [02:02:51] (03PS3) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [02:21:20] (03CR) 10CI reject: [V:04-1] Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 (owner: 10Eileen) [02:31:43] (03PS4) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [02:55:34] (03CR) 10CI reject: [V:04-1] Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 (owner: 10Eileen) [02:58:34] (03PS5) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [03:24:58] FIRING: CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [04:00:28] (03CR) 10CI reject: [V:04-1] build: Updating dependencies [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1246163 (owner: 10Libraryupgrader) [04:39:00] (03PS1) 10Eileen: Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) [04:57:51] (03CR) 10CI reject: [V:04-1] Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) (owner: 10Eileen) [05:09:18] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1250812 (owner: 10L10n-bot) [05:11:05] (03PS2) 10Eileen: Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) [06:00:59] (03PS1) 10Eileen: Do not update settlement_date for reversals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250938 [06:52:20] (03CR) 10Abijeet Patro: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1250812 (owner: 10L10n-bot) [07:24:58] FIRING: CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [07:48:15] (03PS3) 10Anterdc99: LandingCheck: Update Chinese translations [extensions/LandingCheck] - 10https://gerrit.wikimedia.org/r/1221948 (https://phabricator.wikimedia.org/T399285) [09:37:30] (03PS2) 10Eileen: Do not update settlement_date for reversals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250938 [09:37:31] (03PS6) 10Eileen: Do not upload incomplete journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250751 [09:37:31] (03PS3) 10Eileen: Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) [09:37:31] (03PS1) 10Eileen: Fix wrong field type on new custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251017 [09:37:32] (03PS1) 10Eileen: Start exporting the second journal to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251018 [10:02:52] (03CR) 10CI reject: [V:04-1] Start exporting the second journal to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251018 (owner: 10Eileen) [10:03:49] (03CR) 10CI reject: [V:04-1] Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) (owner: 10Eileen) [10:28:16] (03PS4) 10Eileen: Generate to->endowment journals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250769 (https://phabricator.wikimedia.org/T415626) [10:28:16] (03PS2) 10Eileen: Start exporting the second journal to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251018 [11:24:58] FIRING: CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [11:30:46] (03PS3) 10Eileen: Start exporting the second journal to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251018 (https://phabricator.wikimedia.org/T415626) [11:30:46] (03PS1) 10Eileen: Start tracking the amount journalled to endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251049 [11:53:09] (03CR) 10CI reject: [V:04-1] Start tracking the amount journalled to endowment [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251049 (owner: 10Eileen) [13:33:16] (03PS33) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [13:35:21] (03PS34) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [13:37:39] (03CR) 10CI reject: [V:04-1] Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [13:38:59] (03PS35) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [13:42:18] (03CR) 10CI reject: [V:04-1] Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [13:44:39] (03PS36) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [13:47:09] (03CR) 10CI reject: [V:04-1] Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [13:49:03] (03PS5) 10Jgleeson: Make AVS risk scoring optional by country [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1250028 (https://phabricator.wikimedia.org/T419450) [13:49:34] (03PS37) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [13:53:00] (03CR) 10CI reject: [V:04-1] Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [14:01:52] fr-tech I've got a few small patches out to help up prevent false positive declines for Italian donors if anyone fancies some review. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1250023 && https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1250028 [14:02:10] (03PS38) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [14:04:22] checking jgleeson [14:04:30] thanks damilare [14:04:30] (03CR) 10CI reject: [V:04-1] Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [14:04:59] I'll take a peek at the civi login ping too [14:05:09] review trade! ha [14:11:21] (03PS39) 10Damilare Adedoyin: Ping Civi on Login page to check its status. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) [14:12:41] yes please! [15:07:53] (03CR) 10Damilare Adedoyin: [C:03+2] Make postal code optional for Italy on Gravy donation form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1250023 (https://phabricator.wikimedia.org/T419450) (owner: 10Jgleeson) [15:09:37] (03CR) 10Damilare Adedoyin: [C:03+2] "Looks good to me. I was initially confused when I was still getting AVS scores during testing but I realised the test cards return country" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1250028 (https://phabricator.wikimedia.org/T419450) (owner: 10Jgleeson) [15:10:52] (03Merged) 10jenkins-bot: Make AVS risk scoring optional by country [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1250028 (https://phabricator.wikimedia.org/T419450) (owner: 10Jgleeson) [15:11:55] (03CR) 10Damilare Adedoyin: "thanks for the review ejegg, I've pulled out the client side API and now doing the checks on the server." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [15:19:22] (03Merged) 10jenkins-bot: Make postal code optional for Italy on Gravy donation form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1250023 (https://phabricator.wikimedia.org/T419450) (owner: 10Jgleeson) [15:23:10] (03CR) 10Lars SG: [C:03+2] Fix wrong field type on new custom field [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1251017 (owner: 10Eileen) [15:24:58] FIRING: CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [15:28:06] (03CR) 10Lars SG: [C:03+2] Do not update settlement_date for reversals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250938 (owner: 10Eileen) [15:49:05] (03Merged) 10jenkins-bot: Do not update settlement_date for reversals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1250938 (owner: 10Eileen) [16:23:44] (03CR) 10Wfan: [C:03+2] Show notification on failure errors on Gravy Payment form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1250010 (owner: 10Damilare Adedoyin) [16:26:20] (03Merged) 10jenkins-bot: Show notification on failure errors on Gravy Payment form [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1250010 (owner: 10Damilare Adedoyin) [17:27:55] 06Fundraising-Backlog: Get Stripe API credentials to get the settlement report setup - https://phabricator.wikimedia.org/T419628#11703459 (10Cstone) [17:51:51] 06Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rlopez - https://phabricator.wikimedia.org/T417355#11703570 (10Dwisehaupt) certificate renewed and sent via email. password sent via sms. [18:02:35] (03PS1) 10Jgleeson: Add field-reference comparison to GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1251149 [18:06:34] (03CR) 10Jgleeson: Add field-reference comparison to GenericPatternFilter (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1251149 (owner: 10Jgleeson) [18:06:49] right back to your review damilare [18:07:31] thank you! [18:25:55] 06Fundraising-Backlog: Update fundraising-dev phpunit script - https://phabricator.wikimedia.org/T419890 (10jgleeson) 03NEW [18:26:34] 03Fundraising Sprint E - 2026, 06Fundraising-Backlog, 07fr-current-sprint: Assign ach donation form email billing for dinicate first name and last name low confidence - https://phabricator.wikimedia.org/T418790#11703703 (10AnnWF) Alternative approach. donation like this 245501195.1, we have no first name and... [18:28:06] (03PS1) 10Jgleeson: Use composer phpunit in payments test script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1251153 (https://phabricator.wikimedia.org/T419890) [18:29:12] 03Fundraising Sprint E - 2026, 06Fundraising-Backlog, 13Patch-For-Review: Update fundraising-dev phpunit script - https://phabricator.wikimedia.org/T419890#11703722 (10jgleeson) [18:29:31] 03Fundraising Sprint E - 2026, 06Fundraising-Backlog, 13Patch-For-Review: Update fundraising-dev phpunit script - https://phabricator.wikimedia.org/T419890#11703727 (10jgleeson) a:03jgleeson [18:32:14] 03Fundraising Sprint E - 2026, 06Fundraising-Backlog: Add field-reference comparison to GenericPatternFilter - https://phabricator.wikimedia.org/T419891 (10jgleeson) 03NEW [18:33:30] (03PS2) 10Jgleeson: Add field-reference comparison to GenericPatternFilter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1251149 (https://phabricator.wikimedia.org/T419891) [18:35:25] damilare|brb: I think we might want to revisit the subject of breaking out DonorPortal from DonationInterface [18:36:00] It's feels important enough to warrant its own extension [18:36:55] this would be a good thing for claude to help us with as it could highlight things we might miss [18:37:04] due to the scale of the extraction [18:37:27] might be nice to do before launch [18:37:54] anilk: when is launch? [18:38:34] hoping to start sharing with donors w/o March 23 [19:00:06] ah ok [19:00:09] might be tight [19:00:49] rearchitecting would probably need a sprint to execute and test [19:01:05] yh that'd be a good one to pull out [19:01:05] damilare: what do you think? [19:01:34] yh a dedicated sprint would be more likely, I'd say preferably after launch though [19:01:46] yeah that sounds safer [19:07:50] jgleeson: are you experiencing any challenge with the current setup? [19:11:04] well [19:11:46] it all works [19:14:18] I guess I just noticed that we've built up a sizable portfolio in the one extension, payment integrations, email prefs center, donor portal, recurring upgrade, api stuff, fraud filters and and few other bits [19:14:47] I guess the civiproxy component would need to move too [19:16:40] anyway we can do that in the future [19:16:49] I'm just testing your patch [19:20:39] yea it is getting bigger by the day [19:20:59] and it uses a different architecture that is not reusable with the other projects [19:24:58] FIRING: CoreRouterInterfaceDown: Core router interface down - pfw1-codfw:reth2 (fasw1-f5 2x25G) - https://wikitech.wikimedia.org/wiki/Network_monitoring#Router_interface_down - https://grafana.wikimedia.org/d/fb403d62-5f03-434a-9dff-bd02b9fff504/network-device-overview?var-instance=pfw1-codfw:9804 - https://alerts.wikimedia.org/?q=alertname%3DCoreRouterInterfaceDown [19:46:06] just reinstalling civicrm locally to fix the invalid entity warnings [19:51:09] hmm damilare I'm still getting this invalid entity error on brand new civi and with the civiproxy config in place [19:52:00] https://usercontent.irccloud-cdn.com/file/rxfPsPuX/image.png [19:52:17] so the unhappy path works great! [19:53:08] ohh hmm, are you able to test the underlying action in the civi api [19:55:00] the other thing that works for me is restarting civiproxy [19:56:42] (03CR) 10Jgleeson: "This is looking good! I wasn't able to test the happy path, It might be worth jumping on a call tomorrow to see what I'm doing wrong. Howe" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1239778 (https://phabricator.wikimedia.org/T402972) (owner: 10Damilare Adedoyin) [19:57:05] ah lemme try it at civicrm api explorer [19:58:10] docker@civicrm:/srv/civi-sites/wmf$ cv api4 System.getCiviCRMStatus [19:58:10] [ [19:58:10] { [19:58:10] "success": true [19:58:10] } [19:58:11] ] [19:58:19] it works hitting it directly [19:58:26] I'll try restarting civiproxy [20:07:54] XenoRyet and greg-g, travel team just replied me that they will reach out to you two directly for the Hackathon hotel booking thing. [20:11:49] (03CR) 10Jgleeson: Ping Civi on Login page to check its status (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1239780 (owner: 10Damilare Adedoyin) [20:12:03] damilare: I think I've figured it out. ^ [20:12:24] the config that was added to civiproxy doesnt expect the default params [20:12:31] \ [20:12:33] \ [20:13:07] * jgleeson blackslash morse code [20:13:12] sorry baby typing [20:13:17] ahhh D: [20:13:19] :d [20:13:21] :D * [20:13:56] that's interesting, did the change fix the issue? [20:15:18] because it works for me with the current setup and I think it breaks with a validation error if those params are missing [20:16:05] I'm getting a new error now [20:16:09] but it's hitting civi [20:16:46] if you look at all the other blocks damilare they declare those two params https://github.com/wikimedia/wikimedia-fundraising-dev/blob/77eb20bf9d61d051e916bfd2b1535892d7a0c0d3/config/civiproxy/config.php#L155 [20:17:06] and that seems to be because the internal logic in makeApi4Request() always added them [20:18:13] https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/6d06abe90a77eb26c2482d96019c4629e6c6cc98/extras/civiproxy/CiviproxyConnect.php#L53 [20:18:29] I've got to wrap up now I'm getting kicked out the room ha [20:18:39] let's jump on a call tomorrow and see if we can work it out [20:20:21] thanks jgleeson, Elliott reworked that bit to allow the empty params [20:20:29] I was just trying to find the patch [20:21:03] Yep sounds good to have a call tomorrow to check it out [20:21:22] I'd put something on your calendar [20:21:54] cool maybe it's something at my end [20:23:22] catch you tomorrow