[00:02:57] (03PS1) 10Eileen: Extend fix date range - it's too strict cos it's on settled date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1261669 [00:03:15] larssandergreen: do you want to bless another date bump^^ [00:12:34] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.3.9 => v1.2.3.10) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1261666 (owner: 10Eileen) [00:14:53] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.3.9 => v1.2.3.10) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1261667 (owner: 10Eileen) [00:32:51] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1261677 [00:41:53] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1261677 (owner: 10Eileen) [00:52:26] (03PS2) 10Eileen: Add test for braintree chargeback_reversal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1261664 [04:04:35] (03CR) 10Lars SG: [C:03+2] Extend fix date range - it's too strict cos it's on settled date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1261669 (owner: 10Eileen) [04:35:36] (03Merged) 10jenkins-bot: Extend fix date range - it's too strict cos it's on settled date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1261669 (owner: 10Eileen) [05:38:09] (03PS1) 10Krinkle: Ensure $wgNoticeProjects has a default that includes $wgNoticeProject [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261894 (https://phabricator.wikimedia.org/T419627) [05:38:24] (03CR) 10Krinkle: [C:03+2] Ensure $wgNoticeProjects has a default that includes $wgNoticeProject [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261894 (https://phabricator.wikimedia.org/T419627) (owner: 10Krinkle) [05:40:27] (03PS1) 10Krinkle: Remove need for manual $wgCentralHost configuration [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261897 (https://phabricator.wikimedia.org/T419633) [05:40:34] (03CR) 10Krinkle: [C:03+2] Remove need for manual $wgCentralHost configuration [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261897 (https://phabricator.wikimedia.org/T419633) (owner: 10Krinkle) [05:41:44] (03Merged) 10jenkins-bot: Ensure $wgNoticeProjects has a default that includes $wgNoticeProject [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261894 (https://phabricator.wikimedia.org/T419627) (owner: 10Krinkle) [05:43:45] (03Merged) 10jenkins-bot: Remove need for manual $wgCentralHost configuration [extensions/CentralNotice] (REL1_45) - 10https://gerrit.wikimedia.org/r/1261897 (https://phabricator.wikimedia.org/T419633) (owner: 10Krinkle) [12:08:30] 03Fundraising Sprint - Floor is Lava, 06Fundraising-Backlog: FR-Tech AI Safe Usage Guide - https://phabricator.wikimedia.org/T421487 (10jgleeson) 03NEW [12:09:41] (03PS2) 10Jgleeson: Use composer phpunit in payments test script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1251153 (https://phabricator.wikimedia.org/T419890) [12:09:41] (03PS1) 10Jgleeson: Add .aiignore to exclude sensitive config from AI indexing [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262077 (https://phabricator.wikimedia.org/T421487) [12:10:12] (03CR) 10Jgleeson: [V:03+2] Use composer phpunit in payments test script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1251153 (https://phabricator.wikimedia.org/T419890) (owner: 10Jgleeson) [12:10:34] (03Abandoned) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1254294 (owner: 10Jgleeson) [12:11:31] (03CR) 10Jgleeson: "So I think this is mergeable as is, but we need to speak to Dallas and Jeff to understand puppetizing the shared secret" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1253624 (https://phabricator.wikimedia.org/T416948) (owner: 10Jgleeson) [12:46:05] thanks jgleeson [12:47:24] np! [13:27:06] (03PS1) 10Jgleeson: Add .codeiumignore to exclude sensitive config from Codeium/Windsurf [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262111 (https://phabricator.wikimedia.org/T421487) [13:28:01] damilare|away: are you using vs codium ? [13:28:20] yes I am [13:32:54] (03CR) 10Damilare Adedoyin: [C:03+2] Add .codeiumignore to exclude sensitive config from Codeium/Windsurf [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262111 (https://phabricator.wikimedia.org/T421487) (owner: 10Jgleeson) [13:33:13] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Add .codeiumignore to exclude sensitive config from Codeium/Windsurf [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262111 (https://phabricator.wikimedia.org/T421487) (owner: 10Jgleeson) [13:33:43] awesome thanks [13:37:53] (03PS1) 10Jgleeson: Fix donor portal mobile layout [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262122 (https://phabricator.wikimedia.org/T420983) [13:39:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 13Patch-For-Review: Donor Portal UI Issues on Android - https://phabricator.wikimedia.org/T420983#11758332 (10jgleeson) When testing with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1262122 I now see {F... [13:45:53] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 13Patch-For-Review: Donor Portal UI Issues on Android - https://phabricator.wikimedia.org/T420983#11758363 (10jgleeson) Looks like we need some more UI polish on the **Switch to annual gift text link goes to annual conversion page**... [13:48:11] (03CR) 10Jgleeson: "Check phab tasks for before/after screenshots" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262122 (https://phabricator.wikimedia.org/T420983) (owner: 10Jgleeson) [13:56:53] (03CR) 10Ejegg: [C:03+2] Add .aiignore to exclude sensitive config from AI indexing [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262077 (https://phabricator.wikimedia.org/T421487) (owner: 10Jgleeson) [13:56:54] (03CR) 10Ejegg: [V:03+2 C:03+2] Add .aiignore to exclude sensitive config from AI indexing [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1262077 (https://phabricator.wikimedia.org/T421487) (owner: 10Jgleeson) [14:22:21] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdata1003, frmx1002, frqueue100[5-6] - https://phabricator.wikimedia.org/T416249#11758507 (10Jgreen) >>! In T416249#11758413, @Jclark-ctr wrote: >>>! In T416249#11755868, @Jgreen wrote: >> @Jclark-ctr I finally had a chance to loo... [14:24:41] good morning larssandergreen [14:24:54] do you know how I'm supposed to pass a 'url variable' to a searchkit form? [14:25:15] I'm trying to get a specific row from the pending table (i.e. Transaction Log entity) [14:25:25] for a drilldown link from the fraud filters search [14:25:50] and I think I wired it up right, but it's ignoring the order_id I put in the URL [14:26:05] Here's the form: https://civicrm.wikimedia.org/civicrm/admin/afform#/edit/afsearchPendingTransactionData [14:26:39] So I'd expect a link to https://civicrm.wikimedia.org/civicrm/PendingTransaction?order_id=243657490.1 to only give me rows for that order ID [14:26:43] but it gives me all the rows [14:32:46] I suppose I'll dig into the code [14:36:20] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdev1003 - https://phabricator.wikimedia.org/T418928#11758535 (10Jgreen) [14:36:33] it's the crmSearchDisplay I think [14:38:20] (03PS1) 10Damilare Adedoyin: Add formatted template variables for email preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262144 (https://phabricator.wikimedia.org/T420779) [14:40:49] oh docs say it might need reset=1&force=1 [14:41:24] nope, that didn't help [14:42:00] ejegg try https://civicrm.wikimedia.org/civicrm/PendingTransaction#?order_id=243657490.1 [14:42:08] I added the # [14:42:13] oho! [14:42:14] thank you [14:42:40] np! [14:42:46] ahh yeah, I see where it's getting them from the angular route now [14:43:48] yep, exactly [14:50:00] ok, now I want a smarty modifier for |prettyPrintJson [14:50:58] they do have a print_array one [14:50:59] let [14:51:08] 's see if I can get a lil modification to that upstreamed :) [14:55:36] huh, still seeing multiple pending messages for one gravy txn :( [15:00:29] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07FR-Fraud: Allow DR to refund transactions from Civi and flag as fraud - https://phabricator.wikimedia.org/T421277#11758620 (10Ejegg) From the Civi Docs, the fns to add to CRM_Core_Payment_SmashPig > doRefund function > > This is largely similar to d... [15:01:38] (03PS1) 10Ejegg: WIP |@print_array supports JSON [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262150 [15:04:19] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 13Patch-For-Review: Donor Portal - operational emails gift detail formatting - https://phabricator.wikimedia.org/T420779#11758636 (10Damilare) The fix for this has been deployed. {F73850453} {F73850448} {F73850447} [15:06:28] (03PS1) 10Damilare Adedoyin: Add formatted template variables for email preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262144 (https://phabricator.wikimedia.org/T420779) [15:12:30] ok, so we use api4 to copy packaged searchkits, right? [15:17:25] (03CR) 10Damilare Adedoyin: [C:03+2] Add response properties for auth & capture IDs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261564 (https://phabricator.wikimedia.org/T421380) (owner: 10Ejegg) [15:17:55] hmm, that's not quite the format I see in the other SavedSearch_* mgd files [15:17:58] (03Merged) 10jenkins-bot: Add response properties for auth & capture IDs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261564 (https://phabricator.wikimedia.org/T421380) (owner: 10Ejegg) [15:18:10] (03CR) 10Damilare Adedoyin: [C:03+2] Set backend capture / auth IDs on Gravy responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261569 (https://phabricator.wikimedia.org/T421380) (owner: 10Ejegg) [15:18:13] export, that's what I need [15:18:41] (03Merged) 10jenkins-bot: Set backend capture / auth IDs on Gravy responses [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261569 (https://phabricator.wikimedia.org/T421380) (owner: 10Ejegg) [15:20:34] ejegg: yes, that # is annoying! And yes, export from API for packaging, export from the main SK page for copy-pasting to other sites. [15:22:09] thanks, I'll try to package this [15:22:33] so other folks can hack on it locally [15:24:29] ah that seems to not export the form [15:24:39] I guess I need to export another entity for that? [15:25:22] ohhh right, that's a file on disk [15:32:15] I don't think you can get the afform via API, but you can get it with civix [15:32:37] civix export Afform (id) [15:32:53] and that bundles it up with the SK and SearchDisplay [15:33:01] and created the files for you [15:35:05] you want to do it within the relevant extension of course [15:35:42] oh nice [15:36:11] (03PS1) 10Damilare Adedoyin: Add maintenance script for getting a payment method configuration on Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262164 [15:36:12] for now I've just copied the files from public/ang [15:36:32] and separately done the search export [15:36:42] (03CR) 10CI reject: [V:04-1] Add maintenance script for getting a payment method configuration on Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262164 (owner: 10Damilare Adedoyin) [15:36:55] thanks for the CR dami [15:37:07] (03PS2) 10Damilare Adedoyin: Add maintenance script for getting a payment method configuration on Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262164 [15:46:45] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks for all the work on this ejegg. Just one more config and it should be good to go I think." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261622 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [15:47:45] thanks damilare [15:47:53] np ejegg [15:48:10] I think Gravy may be wrong about that, as we DID have to implement a capture step for AdyenDirect/Vipps [15:48:32] but yeah, looks like we do need that intent to make it work under gravy's current validation [15:49:17] yea I think somethings just haven't been implemented on their end for some of the current methods that is set to capture only [15:50:13] ohh I just saw the slack thread, looks like you already had the error yesterday [15:50:19] :) [15:50:27] gotta love that opaque error message [15:51:11] yepp [15:51:30] so I'll just add vipps to CAPTURE_ONLY_PAYMENT_METHOD and that should do it [15:51:51] yea it should [15:52:24] (03PS2) 10Ejegg: Add Vipps under Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261622 (https://phabricator.wikimedia.org/T390870) [15:52:40] (03CR) 10Ejegg: "Done" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261622 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [15:54:06] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work on this, LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261622 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [15:54:22] :) [15:54:56] (03Merged) 10jenkins-bot: Add Vipps under Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1261622 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [15:55:15] (03CR) 10Damilare Adedoyin: [C:03+2] Add config for Vipps under Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1261624 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [15:57:41] (03Merged) 10jenkins-bot: Add config for Vipps under Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1261624 (https://phabricator.wikimedia.org/T390870) (owner: 10Ejegg) [16:02:59] huh, I can't seem to make print_array fire [16:11:26] (03CR) 10Wfan: [C:03+2] Add formatted template variables for email preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262144 (https://phabricator.wikimedia.org/T420779) (owner: 10Damilare Adedoyin) [16:40:41] (03Merged) 10jenkins-bot: Add formatted template variables for email preview [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262144 (https://phabricator.wikimedia.org/T420779) (owner: 10Damilare Adedoyin) [16:44:37] thanks wfan for the cr [16:45:08] np~ thanks for the great work~ [16:45:56] I will filter the out of office for v3~ [16:46:00] thanks for the advise~ [17:29:43] :) [17:31:40] (03PS1) 10Damilare Adedoyin: Native app payments don't fill in backend processor field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262198 (https://phabricator.wikimedia.org/T420401) [17:34:05] !log on frdb1005 running the following in mysql to up the buffer pool to ~412G: set global innodb_buffer_pool_size = 421552128; [17:34:07] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [17:50:43] !log Corrected value: on frdb1005 running the following in mysql to up the buffer pool to ~412G: set global innodb_buffer_pool_size = 431669379072; [17:50:44] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [17:56:40] ok, giving up on print_array debugging for now... [18:01:26] (03PS1) 10Ejegg: WIP packaged searches for fraud results and pending txn data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262203 [18:10:48] (03PS1) 10Ejegg: Mark Braintree and PayPal with refund interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262205 (https://phabricator.wikimedia.org/T421277) [18:11:19] (03CR) 10CI reject: [V:04-1] Mark Braintree and PayPal with refund interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262205 (https://phabricator.wikimedia.org/T421277) (owner: 10Ejegg) [18:15:09] (03PS2) 10Ejegg: Mark Braintree and PayPal with refund interface [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262205 (https://phabricator.wikimedia.org/T421277) [18:19:08] (03PS1) 10Ejegg: WIP support refunds on multiple payment processors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262207 (https://phabricator.wikimedia.org/T421277) [18:34:20] 06Fundraising-Backlog, 06FR-donorrelations: Outreach to the donors from T420651 - https://phabricator.wikimedia.org/T421534 (10MBeat33) 03NEW [18:45:49] larssandergreen: Huh, Even if we make the payment processor class return true from supportsRefund, no new actions show up. I guess that's just not surfaced in the UI? [18:46:11] All I see is 'record refund', nothing that actually triggers the 'refund' api actions or doRefund [18:58:17] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdb1008 - https://phabricator.wikimedia.org/T414374#11759514 (10VRiley-WMF) Hey Jeff, just looked at the unit again. Made sure the username and password is what I sent you. Please let me know! Thanks! [18:58:33] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdb1008 - https://phabricator.wikimedia.org/T414374#11759515 (10VRiley-WMF) a:05VRiley-WMF→03Jgreen [19:22:34] ejegg: could you push up what you have now as a WIP and I can take a look? [19:24:56] you have doRefund() as a stub at least? [19:36:00] ejegg: oh, you're right, the refund UI is not implemented in core, it's from MJWShared extension: https://docs.civicrm.org/mjwshared/en/latest/refunds/ [19:37:26] I think we could require that, but maybe eileen has thoughts? [19:51:28] 10Fundraising analytics stack: Ingest Zendesk data into MinIO - https://phabricator.wikimedia.org/T379121#11759649 (10AStein-WMF) the changes have been merged! now the daily job loads: users, macros, tickets, and ticket_metrics! [19:51:34] 10Fundraising analytics stack: Ingest Zendesk data into MinIO - https://phabricator.wikimedia.org/T379121#11759650 (10AStein-WMF) 05In progress→03Resolved [19:55:05] larssandergreen: I think we could probably try to get that refund UI into core [19:56:41] ejegg: on these Adyen ones with auth_id vs capture_id issue - it seems the sepa, bt, online_czh ones have the same value for both fields in the reports but it's NOT the same as the one we are storing - not sure if we have done anything to fix that [20:01:07] eileen: that would make sense [20:01:23] (03PS3) 10Eileen: Update backend_processor_txn_id repair for bank transfer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) [20:01:31] 10Fundraising analytics stack: Ingest Zendesk data into MinIO - https://phabricator.wikimedia.org/T379121#11759699 (10IAckerman-WMF) 🎉 [20:02:49] I think ^^ would repair them but payment method might be a bit narrow there I'm not quite sure it's right [20:09:12] larssandergreen: sorry, just saw your comments. I'm making a new form anyway, since I want to add an 'is fraud' checkbox to the refund form [20:09:26] eileen: let me take a look at what other IDs we can get for those transactions [20:22:30] (03CR) 10Jmando: [C:03+1] Update is_major_gift based on utm_medium [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260304 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [20:23:06] (03CR) 10Jmando: [C:03+1] Fix is_major_gift for subsequent recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260198 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [20:29:32] (03PS1) 10Ejegg: WIP form to submit refunds to processors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262277 (https://phabricator.wikimedia.org/T421277) [20:31:30] larssandergreen: I got a +1 from joseph on this & the one after can you up it to one that will merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1260198/2 [20:41:55] (03CR) 10Jmando: "remove if (str_contains($utmSource, '_ipd_')) {" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260563 (owner: 10Eileen) [20:43:26] (03PS2) 10Eileen: Map Ipad banners to Other Banner [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260563 [20:44:01] (03PS2) 10Eileen: Fix label (use the generic not specific as it covers many) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260609 [20:45:05] (03CR) 10Jmando: Update is_major_gift where utm_source like ~MG (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260562 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [20:45:28] (03CR) 10Jmando: [C:03+1] Treat all 'civi_mail%' utm_source as channel email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260561 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [20:48:22] (03CR) 10Jmando: [C:03+1] Map Ipad banners to Other Banner [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260563 (owner: 10Eileen) [21:31:07] eileen: so we DO get a good background processor txn ID from gravy in the IPN message for those redirect methods [21:31:19] we just need to discard the one from the initial createPayment call [21:31:22] we just don't use it? [21:31:40] I think we must let the one from the initial call supercede it [21:32:11] hmm, or actually we probably aren't looking at backend processor IDs in the IPNs from gravy [21:32:19] I can make a couple changes there [21:32:43] larssandergreen: I added you to the meet I have with Joseph on Monday - but it's optional for you [21:33:54] thanks always good to understand a bit more on this stuff [21:41:41] it's crazy that the actual 'spec' for all this is Joseph's code [21:42:45] ejegg: in terms of repair (so the audit file will finish) - I think this is right - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1260864 but I suspect the payment method check is too narrow? [21:43:54] (03PS1) 10Ejegg: Stop sending session IDs as backend IDs (Adyen) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262313 (https://phabricator.wikimedia.org/T421282) [21:44:07] eileen: we can also just check the length of the suspect ID ^^^ [21:44:15] the transient ones are 25 chars [21:44:20] and the long lived ones are 16 [21:44:31] oh ok! but of course [21:44:47] so that's one half of getting it right in the front-end [21:44:59] needs another patch for the listener / job runner [21:46:46] (03CR) 10CI reject: [V:04-1] Stop sending session IDs as backend IDs (Adyen) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262313 (https://phabricator.wikimedia.org/T421282) (owner: 10Ejegg) [21:48:31] (03PS2) 10Ejegg: Stop sending session IDs as backend IDs (Adyen) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262313 (https://phabricator.wikimedia.org/T421282) [21:50:18] ejegg: I feel O to +2 ^^ based on discussion but not sure if you'd rather wait on someone else [21:51:43] also in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1260864 - I'm wondering if doing a length check would add a slow query [21:51:46] hey, if you're fine with it that's cool [21:52:07] oh right the thing to check for the audit would be in the database, wouldn't it [21:52:18] not in the message [21:54:03] (03CR) 10Eileen: [C:03+2] Stop sending session IDs as backend IDs (Adyen) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262313 (https://phabricator.wikimedia.org/T421282) (owner: 10Ejegg) [21:55:07] ejegg: yeah - I think we can identify by payment type though ... just bt is probably too narrow - or by auth_id === capture_id [21:56:45] hah, i like how that getSettlementTimeStamp clause gives us a deadline to get things right in the front end [21:57:22] (03Merged) 10jenkins-bot: Stop sending session IDs as backend IDs (Adyen) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262313 (https://phabricator.wikimedia.org/T421282) (owner: 10Ejegg) [21:58:43] eileen: I'm guessing it's more or less this list of (sub)methods: https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/PaymentProviders/Gravy/Mapper/RequestMapper.php#L16 [21:59:40] I think I'm going to use that to decide when to send the backend id from the capture IPN [22:04:26] hmmm [22:04:44] OK, that should work [22:05:18] we won't get any backend processor txn ID from IPNs for card transactions, but we should always record those from payments-wiki anyway [22:05:53] let's see if the ID they send back in the Paypal capture IPNs is any good [22:08:11] boo, i don't have rights to see the paypal txns any more [22:08:23] well, let's look in the report [22:10:06] ejegg: so in the context of this patch that would be the payment submethod not method? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1260864 [22:11:13] I think so! [22:12:03] hmm, thought I think that's the gravy-side version [22:12:26] identical to our internal version except for onlinebankingcz [22:12:29] annoyingly [22:12:58] $paymentMethodEnum = PaymentMethod::tryFrom( strtolower( $paymentMethodString ) ); [22:13:04] if ( in_array( $paymentMethodEnum->toGravyValue(), self::CAPTURE_ONLY_PAYMENT_METHOD ) ) { [22:13:10] so there's the mapping [22:13:16] Want to check my understanding of ACH payments: Trustly gets them, they give us an immediate status, and then a few days later they may tells us the payment failed for a variety of different reasons. If the payment doesn't fail, do we get anything positive back from Trustly to indicate that or only failures? [22:13:35] ahh ok we do have some other differences [22:13:44] i.e. our submethod for ideal is rtbt_ideal [22:14:31] so you'll unfortunately need to map from the normalized internal submethod to the gravy-style method to check against that list [22:17:48] hmm - so there is another option - from smash-pig these ones are bubbling up with auth_id === capture_id - so we could either look for that pattern or change it to only bubble up auth_id here & look for 'no capture Id' [22:19:09] right eileen, I would guess that for all the methods on that list the auth + capture IDs are identical [22:19:33] shall I try updating the patch to that & we can try running it & see if the file will clear? [22:19:37] sure! [22:20:47] hmm, though Vipps actually has separate IDs: https://ca-live.adyen.com/ca/ui/transactions/payments/PX3M3G62FC6658B9/ [22:22:53] (03PS4) 10Eileen: Update backend_processor_txn_id repair for bank transfer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) [22:23:18] ejegg: so ^^ [22:26:19] ok, that seems reasonable [22:26:34] lemme pull that down to take a peek in an IDE [22:26:38] cool [22:28:01] just dithering about whether we should leave the capture_id column blank [22:28:31] since in the adyen console event list they show a 'capture' but no 'auth' for those [22:28:47] eileen: maybe set them both ? [22:28:51] ok [22:29:15] (03PS5) 10Eileen: Update backend_processor_txn_id repair for bank transfer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) [22:29:16] ejegg: ^^ [22:30:08] (03CR) 10Ejegg: [C:03+2] "Let's give it a shot! I'll try to get the right values in from the front end ASAP." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) (owner: 10Eileen) [22:30:22] cool cool [22:30:35] we should look at paypal repair too huh? [22:31:01] probably [22:32:56] I'm looking at the IPN mapper and I think we maybe are always sending the backend_processor_transaction_id to the job queue [22:33:10] so let's see what the job does with it [22:33:27] (03PS6) 10Eileen: Update backend_processor_txn_id repair for bank transfer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) [22:33:27] (03PS1) 10Eileen: Extend repair to paypal - [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262347 (https://phabricator.wikimedia.org/T421282) [22:33:50] ejegg: I *think* ^^ might be all we need for paypal repair - we can ignore paypal_ec? [22:34:18] right, we should be storing good IDs for paypal_ec [22:35:04] (03CR) 10Eileen: [V:03+2] Update backend_processor_txn_id repair for bank transfer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260864 (https://phabricator.wikimedia.org/T421282) (owner: 10Eileen) [22:35:20] well, that seems like it's worth a shot [22:35:41] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1262351 [22:35:49] It would repair those in the original clause, not the auth==capture clause, right? [22:35:50] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1262351 (owner: 10Eileen) [22:35:56] (03CR) 10Ejegg: [C:03+2] "Worth a shot!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262347 (https://phabricator.wikimedia.org/T421282) (owner: 10Eileen) [22:36:56] (03Merged) 10jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1262351 (owner: 10Eileen) [22:37:15] (03CR) 10Lars SG: [C:03+2] Fix is_major_gift for subsequent recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260198 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [22:37:37] !log civicrm upgraded from c51e98cc to 7138d524 [22:37:38] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [22:38:25] ok eileen, I /think/ the RecordCaptureJob will actually add the good backend ID for us from the IPN once we stop sending a bad one to pending from the front end: [22:38:32] https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/PaymentProviders/Gravy/Jobs/RecordCaptureJob.php#L92 [22:38:45] We might even be able to remove that isSepa special case [22:39:21] oh cool - looks like it's updating again - but so far more because I just deployed the patch that loosens the settled_date check [22:39:21] civicrm.wmf.INFO: Updating backend processor for XVPQH5J959ZZ3F35 {"auth_id":"XVPQH5J959ZZ3F35","capture_id":"HF7DDTF5VVC98Z99","backend_processor":"adyen"} [22:40:31] also on IDs - there are reversal Ids to save - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1259287 [22:40:58] (03PS1) 10Ejegg: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262352 [22:41:01] (03CR) 10Ejegg: [C:03+2] Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262352 (owner: 10Ejegg) [22:41:21] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1262353 [22:41:23] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1262353 (owner: 10Ejegg) [22:41:36] * ejegg is PRETTY SURE ^^^ is safe for a friday deploy :) [22:41:48] oh yeah I forgot it's friday ... [22:41:51] for some [22:43:47] (03Merged) 10jenkins-bot: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262352 (owner: 10Ejegg) [22:43:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1262353 (owner: 10Ejegg) [22:44:51] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Don't store content of thank you email and annual summary receipts - https://phabricator.wikimedia.org/T421558 (10Lars) 03NEW [22:45:51] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Don't store content of thank you email and annual summary receipts - https://phabricator.wikimedia.org/T421558#11760174 (10Lars) [22:47:33] the adyen file cleared!! [22:48:57] getting these civicrm.wmf.INFO: Civi\WMFQueueMessage\AuditMessage unsupported field backend_processor_refund_id - but they will disappear with https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1260932 [22:49:45] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Don't store content of thank you email and annual summary receipts - https://phabricator.wikimedia.org/T421558#11760211 (10Lars) If we stored these for three months, per Eileen ` SELECT activity_type_id, ROUND(SUM( COALESCE(LENGTH(details), 0) ) / 1024 /... [22:56:01] (03CR) 10CI reject: [V:04-1] Extend repair to paypal - [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262347 (https://phabricator.wikimedia.org/T421282) (owner: 10Eileen) [22:58:15] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Don't store content of thank you email and annual summary receipts - https://phabricator.wikimedia.org/T421558#11760268 (10Lars) I have confirmed that we aren't storing either type in the log table, which explains why that one is so much smaller. [22:59:43] (03CR) 10Lars SG: [C:03+2] Stop bubbling up backend_processor_refund_id from AdyenAudit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1260932 (https://phabricator.wikimedia.org/T420527) (owner: 10Eileen) [23:00:16] (03Merged) 10jenkins-bot: Stop bubbling up backend_processor_refund_id from AdyenAudit [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1260932 (https://phabricator.wikimedia.org/T420527) (owner: 10Eileen) [23:02:11] (03CR) 10Eileen: [V:03+2] "Erm - I forced the last one which had the error - not this one" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262347 (https://phabricator.wikimedia.org/T421282) (owner: 10Eileen) [23:02:49] (03PS1) 10Eileen: Fix test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262355 [23:03:22] larssandergreen: are you able to +2 ^^ [23:05:04] I'm gonna head into town but I will self-+2 so no-one hits test fail if they don't see this but please add endorsement [23:05:11] (03CR) 10Eileen: [C:03+2] Fix test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262355 (owner: 10Eileen) [23:08:05] (03PS1) 10Wfan: Trigger failmail if a validation error not categorized [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262356 (https://phabricator.wikimedia.org/T421155) [23:10:03] eileen: retro +2ed [23:10:22] (03CR) 10Lars SG: [C:03+2] Fix test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262355 (owner: 10Eileen) [23:15:36] (03PS2) 10Wfan: Trigger failmail if a validation error not categorized [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262356 (https://phabricator.wikimedia.org/T421155) [23:16:07] (03CR) 10Lars SG: "needs to be v.channel and v.appeal rather than c" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260304 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [23:17:46] (03CR) 10CI reject: [V:04-1] Fix is_major_gift for subsequent recurrings [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260198 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen) [23:19:55] (03CR) 10Lars SG: [C:03+2] Map Ipad banners to Other Banner [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260563 (owner: 10Eileen) [23:20:12] (03CR) 10Lars SG: [C:03+2] Fix label (use the generic not specific as it covers many) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260609 (owner: 10Eileen) [23:41:12] (03Merged) 10jenkins-bot: Fix test [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262355 (owner: 10Eileen) [23:41:15] (03Merged) 10jenkins-bot: Map Ipad banners to Other Banner [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260563 (owner: 10Eileen) [23:41:18] (03Merged) 10jenkins-bot: Fix label (use the generic not specific as it covers many) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260609 (owner: 10Eileen) [23:42:46] (03CR) 10CI reject: [V:04-1] Trigger failmail if a validation error not categorized [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262356 (https://phabricator.wikimedia.org/T421155) (owner: 10Wfan) [23:43:18] (03PS3) 10Wfan: Trigger failmail if a validation error not categorized [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1262356 (https://phabricator.wikimedia.org/T421155) [23:47:11] (03CR) 10Lars SG: "One little detail" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1260561 (https://phabricator.wikimedia.org/T409994) (owner: 10Eileen)