[00:05:28] (03CR) 10Wfan: [V:03+2] Update test data to include fees [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266474 (owner: 10Eileen) [00:15:13] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig to v1.2.3.16 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266483 (owner: 10Eileen) [00:20:48] (03PS1) 10Eileen: Cast order ID to string [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 [00:21:20] (03CR) 10CI reject: [V:04-1] Cast order ID to string [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 (owner: 10Eileen) [00:21:56] (03PS9) 10Eileen: Chariot smashpig plugin [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265981 (https://phabricator.wikimedia.org/T419044) [00:21:56] (03PS2) 10Eileen: Cast order ID to string [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 [00:22:30] (03CR) 10CI reject: [V:04-1] Chariot smashpig plugin [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265981 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [00:22:37] (03CR) 10CI reject: [V:04-1] Cast order ID to string [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 (owner: 10Eileen) [00:23:45] (03PS3) 10Eileen: Cast order ID to string [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 [01:02:22] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig to v1.2.3.16 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266483 (owner: 10Eileen) [01:55:52] (03CR) 10Ejegg: [C:04-1] "This is looking really promising! But the field names in the normalized validation errors should be the same as the names of the input fie" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1264860 (https://phabricator.wikimedia.org/T421155) (owner: 10Wfan) [01:56:58] (03CR) 10Eileen: [C:03+2] "Gonna push this through so I can test before I go away for a week" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 (owner: 10Eileen) [01:59:47] (03CR) 10Ejegg: [C:04-1] Some validation error do not have error_code (034 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1264860 (https://phabricator.wikimedia.org/T421155) (owner: 10Wfan) [02:00:32] Cool, thanks ejegg|afk will do the update [02:02:19] (03PS10) 10Eileen: Chariot smashpig plugin [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265981 (https://phabricator.wikimedia.org/T419044) [02:03:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Repair contribution tracking records where utm_medium overwritten by 'Audit' - https://phabricator.wikimedia.org/T421035#11780683 (10Ejegg) Grepping for the original messages in the last year's worth of... [02:03:48] (03PS1) 10Eileen: Merge branch 'master' of https://github.com/wikimedia/wikimedia-fundraising-SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1266523 [02:03:59] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://github.com/wikimedia/wikimedia-fundraising-SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1266523 (owner: 10Eileen) [02:04:25] (03Merged) 10jenkins-bot: Merge branch 'master' of https://github.com/wikimedia/wikimedia-fundraising-SmashPig into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1266523 (owner: 10Eileen) [02:05:49] (03CR) 10Lars SG: [C:03+2] "Retro +2" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266488 (owner: 10Eileen) [02:06:34] (03PS4) 10Wfan: Some validation error do not have error_code [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1264860 (https://phabricator.wikimedia.org/T421155) [02:09:16] (03CR) 10Ejegg: "So are we just leaving these as 'pending' and waiting for the webhook to actually record them in Civi?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266392 (https://phabricator.wikimedia.org/T389865) (owner: 10Wfan) [02:10:16] wfan: So if Pix Automatico needs to be scheduled in advance, there's got to be a chance some of them fail, right? [02:10:44] and we probably want to record the actual charge day as the receive_date in Civi, not the day we make the API call to schedule it? [02:12:35] Seems like we'd want the recurring charge job to send a message to the pending queue with all the details that it would otherwise send to donations [02:13:01] and then the IPN listener could pick it up when the charge goes through [02:13:14] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.16 => v1.2.3.17) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266535 [02:13:34] Shouldn't be too big a change, I think [02:14:18] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.16 => v1.2.3.17) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266536 [02:14:54] So we want to make sure that the call to createPayment for a subsequent recurring installment on Pix always comes back as 'pending' status in SmashPig [02:15:19] and then write a little code to handle that case in the charge job [02:15:32] sorry, I need to get to bed... [02:15:35] https://sandbox.wikimedia.gr4vy.app/merchants/default/transactions/f63cb7fb-c594-4a8c-8938-422bfd5781ae/overview yes, they need to be 2 days at least advanced, but if you test with sandbox, immediate capture [02:15:45] I need to confirm with Gravy with this part [02:15:55] good night~ thanks for review [02:16:04] !log SmashPig upgraded from 9af71a7c to 18ea746a [02:16:05] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:17:43] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.16 => v1.2.3.17) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266535 (owner: 10Eileen) [02:17:56] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.16 => v1.2.3.17) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266536 (owner: 10Eileen) [02:36:46] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1266537 [02:36:58] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1266537 (owner: 10Eileen) [02:39:13] !log civicrm upgraded from bbed1291 to c512abc6 [02:39:14] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:08:16] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.3.16 => v1.2.3.17) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266536 (owner: 10Eileen) [03:19:37] (03PS1) 10Eileen: Fix fee set to positive not negative [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266561 [04:03:25] (03CR) 10Cstone: [C:03+2] Fix fee set to positive not negative [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266561 (owner: 10Eileen) [04:03:36] (03PS1) 10Eileen: Truncate documentId to allowed 30 char when pushing to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266608 [04:03:58] (03Merged) 10jenkins-bot: Fix fee set to positive not negative [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266561 (owner: 10Eileen) [04:04:41] (03CR) 10Cstone: [C:03+2] Truncate documentId to allowed 30 char when pushing to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266608 (owner: 10Eileen) [04:14:37] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266616 [04:15:28] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266617 [04:15:55] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266617 (owner: 10Eileen) [04:16:10] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266616 (owner: 10Eileen) [04:24:57] (03PS1) 10Eileen: Prepend transaction on Stripe fee [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266619 [04:25:49] (03Merged) 10jenkins-bot: Truncate documentId to allowed 30 char when pushing to Intacct [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266608 (owner: 10Eileen) [04:26:46] (03PS1) 10Eileen: Add fee to fee-type trxn_id, do not expect space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266620 [04:27:17] cstone: if you are still there the last 2 would be good ... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1266620 [04:27:30] & https://gerrit.wikimedia.org/r/1266619 [04:27:38] yeah i started making graphs and now i have some energry back haha [04:27:51] lol [04:27:54] (03CR) 10Cstone: [C:03+2] Add fee to fee-type trxn_id, do not expect space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266620 (owner: 10Eileen) [04:28:14] (03CR) 10Cstone: [C:03+2] Prepend transaction on Stripe fee [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266619 (owner: 10Eileen) [04:28:36] I think I've tagged 4 releases today ... [04:28:45] hah [04:28:45] (03Merged) 10jenkins-bot: Prepend transaction on Stripe fee [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266619 (owner: 10Eileen) [04:28:55] i found out we have 220 recurrings with cycle day 0.... [04:29:42] ohhhh [04:30:11] ah okay all are paypals but 1 [04:31:03] and the one thats not and set to 0 has been charging away happily on the 19 [04:31:09] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266621 [04:32:08] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266622 [04:32:24] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266622 (owner: 10Eileen) [04:34:30] looks like jenkins has his hands full - well maybe I should start packing [04:35:58] (03Merged) 10jenkins-bot: Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266617 (owner: 10Eileen) [04:41:20] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig (v1.2.3.17 => v1.2.3.18) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266616 (owner: 10Eileen) [04:45:27] (03PS1) 10Eileen: Ensure amount fields are strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266624 [04:45:41] (03PS2) 10Eileen: Ensure amount fields are strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266624 [04:46:22] (03CR) 10Eileen: [V:03+2 C:03+2] "Gonna force it to ignore the deprecation error for now & bring that fix up after" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266616 (owner: 10Eileen) [04:47:15] cstone: my own worst enemy - I made the tests complain about hitting deprecation warnings & then .. https://gerrit.wikimedia.org/r/1266624 [04:47:15] [04:47:34] (03CR) 10Cstone: [C:03+2] Ensure amount fields are strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266624 (owner: 10Eileen) [04:47:34] (03PS2) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266621 [04:47:39] hah [04:48:23] (03Merged) 10jenkins-bot: Ensure amount fields are strings [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266624 (owner: 10Eileen) [04:49:35] (03CR) 10CI reject: [V:04-1] Add fee to fee-type trxn_id, do not expect space [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266620 (owner: 10Eileen) [04:50:34] (03CR) 10Eileen: [V:03+2] "test fail is a deprecation that relies on getting a vendor tagged & merged while jenkins struggles to keep up" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266620 (owner: 10Eileen) [04:52:15] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 [04:52:26] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266621 (owner: 10Eileen) [04:52:39] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 (owner: 10Eileen) [04:52:46] (03PS2) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 [04:52:56] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 (owner: 10Eileen) [04:53:17] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 (owner: 10Eileen) [04:54:29] (03PS1) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266626 [04:55:04] (03CR) 10Eileen: [C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266626 (owner: 10Eileen) [04:55:37] (03PS3) 10Eileen: Use - instead of space for trxn_id for fees [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266473 [05:00:45] (03CR) 10Cstone: [C:03+2] Remove test that is not worth maintaining [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266485 (owner: 10Eileen) [05:01:17] (03Merged) 10jenkins-bot: Remove test that is not worth maintaining [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266485 (owner: 10Eileen) [05:01:26] (03PS3) 10Eileen: Wire in Stripe Tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266151 [05:08:15] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig (v1.2.3.18 => v1.2.3.19) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266621 (owner: 10Eileen) [05:14:23] (03CR) 10Eileen: [V:03+2 C:03+2] "deprecation notice has fix queued" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266621 (owner: 10Eileen) [05:14:35] (03CR) 10CI reject: [V:04-1] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266626 (owner: 10Eileen) [05:14:39] (03PS3) 10Eileen: Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 [05:14:44] (03CR) 10Eileen: [V:03+2] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266625 (owner: 10Eileen) [05:15:17] (03CR) 10Eileen: [V:03+2 C:03+2] Upgrading wikimedia/smash-pig (v1.2.3.19 => v1.2.3.20) [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1266626 (owner: 10Eileen) [05:15:39] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266151 (owner: 10Eileen) [05:15:59] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266473 (owner: 10Eileen) [05:16:06] (03CR) 10CI reject: [V:04-1] Wire in Stripe Tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266151 (owner: 10Eileen) [05:17:55] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1266798 [05:18:13] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1266798 (owner: 10Eileen) [05:24:30] !log civicrm upgraded from c512abc6 to 49f541cd [05:24:31] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [05:36:56] (03CR) 10CI reject: [V:04-1] Use - instead of space for trxn_id for fees [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266473 (owner: 10Eileen) [06:27:48] 06Fundraising-Backlog, 06FR-donorrelations: Outreach to the donors from T420651 - https://phabricator.wikimedia.org/T421534#11780846 (10krobinson) Can I confirm we did filter out those who had already set up a new donation? We have two examples of donors who had done so. https://wikimedia.zendesk.com/agent... [07:03:47] (03PS1) 10Eileen: Keep on repairing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266849 [11:13:07] (03CR) 10Jgleeson: [C:03+2] Keep on repairing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266849 (owner: 10Eileen) [11:14:50] (03CR) 10Jgleeson: [C:03+2] pix recurring charge schedule date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266392 (https://phabricator.wikimedia.org/T389865) (owner: 10Wfan) [11:15:25] (03Merged) 10jenkins-bot: pix recurring charge schedule date [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1266392 (https://phabricator.wikimedia.org/T389865) (owner: 10Wfan) [11:18:27] (03CR) 10Jgleeson: [C:03+2] "Really nice extraction and fix!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266320 (https://phabricator.wikimedia.org/T421935) (owner: 10Lars SG) [11:29:33] (03CR) 10Jgleeson: "Thanks for this Dami. This looks really useful, especially to have before we go live. I spotted a few small things and left a question abo" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [11:41:18] (03Merged) 10jenkins-bot: Keep on repairing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266849 (owner: 10Eileen) [11:44:23] thanks for the cr jgleeson and for flagging the pii concern. I'd update that as I didn't consider it then. [11:45:46] (03CR) 10Jgleeson: [C:03+1] "+1ing so you see the other preexisting bug. The code change, however, looks fine" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266189 (owner: 10Eileen) [11:46:07] thanks damilare. It might be fine but I wasn't sure [11:48:35] (03Merged) 10jenkins-bot: Set default location type for new email, etc blocks on contact summary [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266320 (https://phabricator.wikimedia.org/T421935) (owner: 10Lars SG) [11:56:44] (03PS1) 10Jgleeson: Fix operator precedence bug in gateway check for backend processor txn id repair [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266996 [12:18:32] (03PS4) 10Damilare Adedoyin: Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) [12:21:03] (03CR) 10CI reject: [V:04-1] Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [12:24:40] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdev1003 - https://phabricator.wikimedia.org/T418928#11782144 (10Jclark-ctr) a:03Jclark-ctr [12:25:18] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdev1003 - https://phabricator.wikimedia.org/T418928#11782146 (10Jclark-ctr) [12:27:43] (03PS5) 10Damilare Adedoyin: Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) [12:29:59] (03CR) 10CI reject: [V:04-1] Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [12:56:20] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install fransw100[23] - https://phabricator.wikimedia.org/T417295#11782255 (10Jclark-ctr) @Jgreen replaced cable link came up. Sorry for delay [12:57:00] (03PS6) 10Damilare Adedoyin: Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) [13:01:35] (03PS7) 10Damilare Adedoyin: Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) [13:05:53] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the CR, I've made the recommended changes. I also masked the email to allow traceability when debugging, lemme know wh" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [13:07:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Donor Portal - investigation request: activity tracking for cancellations - https://phabricator.wikimedia.org/T422035#11782306 (10CHudson-WMF) I should be able to handle de-duplicating the cancellati... [13:08:34] (03PS3) 10Damilare Adedoyin: WIP: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) [13:11:24] (03CR) 10CI reject: [V:04-1] WIP: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [13:12:39] I like the masked email solution damilare - nice! [13:12:59] thanks! [13:14:22] 03Fundraising Sprint - Floor is Lava, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Add frequency, native currency amount and USD amount to recurring pause and cancel activities from Donor Portal - https://phabricator.wikimedia.org/T421733#11782317 (10CHudson-WMF) @Lars--apolog... [13:25:34] (03CR) 10Jgleeson: [C:03+2] "thanks for this! The maskedEmail function is novel - we should consider adding that to a share library helper in SmashPig that we can use " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [13:29:32] (03CR) 10Jgleeson: Map for dlocal pix automatic (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265527 (https://phabricator.wikimedia.org/T419446) (owner: 10Wfan) [13:29:35] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install fransw100[23] - https://phabricator.wikimedia.org/T417295#11782375 (10Jgreen) >>! In T417295#11782255, @Jclark-ctr wrote: > @Jgreen replaced cable link came up. Sorry for delay @Jclark-ctr looks good, it's imaging now. Thanks! [13:31:42] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdev1003 - https://phabricator.wikimedia.org/T418928#11782380 (10Jclark-ctr) [13:32:20] (03Merged) 10jenkins-bot: Add loglines and error code to DonorPortal API classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266298 (https://phabricator.wikimedia.org/T421917) (owner: 10Damilare Adedoyin) [13:36:52] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install frdata1003, frmx1002, frqueue100[5-6] - https://phabricator.wikimedia.org/T416249#11782402 (10Jclark-ctr) 05Open→03Resolved [13:39:48] (03PS1) 10Jgleeson: Add test link for dLocal Pix automatic [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267054 (https://phabricator.wikimedia.org/T419446) [13:39:50] (03PS1) 10Jgleeson: Rename payments-update-text.sh to payments-update-wiki-pages.sh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267055 [13:40:25] (03PS2) 10Jgleeson: Add test link for dLocal Pix Automatico [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267054 (https://phabricator.wikimedia.org/T419446) [13:40:35] (03PS2) 10Jgleeson: Rename payments-update-text.sh to payments-update-wiki-pages.sh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267055 [14:10:07] 06Fundraising-Backlog, 10FR-Donor-portal: Donor Portal: Dynamic link for 'restart your monthly/annual donation to prepopulate donation form with known gift details - https://phabricator.wikimedia.org/T422164 (10KHill-WMF) 03NEW [14:26:56] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: This Gr4vy (gravy) triple charge looks like it really happened - do our other phabs cover this? - https://phabricator.wikimedia.org/T421990#11782693 (10Ejegg) It sure did happen - we see the three payme... [14:29:17] cstone: do you have a phab for changing the retry cadence? [14:29:49] I have more of an epic I guess but we could also use it [14:30:55] https://phabricator.wikimedia.org/T413905 [14:31:03] I guess it's in the title hah [14:36:21] (03PS1) 10Ejegg: Use 'const' for constants in gravy.js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267071 [14:54:02] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install fransw100[23] - https://phabricator.wikimedia.org/T417295#11782828 (10Jgreen) 05Open→03Resolved hosts are up and running [15:00:55] (03PS1) 10Ejegg: Safeguard against dupe submit after Monthly Convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267078 (https://phabricator.wikimedia.org/T421990) [15:02:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit, 13Patch-For-Review: This Gr4vy (gravy) triple charge looks like it really happened - do our other phabs cover this? - https://phabricator.wikimedia.org/T421990#11782877 (10Ejegg) a:03Ejegg [15:03:57] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Call import hook from batch import - https://phabricator.wikimedia.org/T421978#11782881 (10Ejegg) Looks like it just merged upstream! Nice work @Lars. Shall we cherry-pick it to our local core folder? [15:05:09] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: CiviCRM email location type is not set to default when adding new email on contact summary - https://phabricator.wikimedia.org/T421935#11782884 (10Ejegg) Merged upstream and locally [15:13:37] (03PS3) 10Krinkle: BannerHistoryLogger: Remove unused `waitLogNoSendBeacon` mixin param [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1264185 (https://phabricator.wikimedia.org/T421662) [15:13:47] (03CR) 10Ejegg: [C:03+2] BannerHistoryLogger: Remove unused `waitLogNoSendBeacon` mixin param [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1264185 (https://phabricator.wikimedia.org/T421662) (owner: 10Krinkle) [15:19:31] (03CR) 10CI reject: [V:04-1] BannerHistoryLogger: Remove unused `waitLogNoSendBeacon` mixin param [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1264185 (https://phabricator.wikimedia.org/T421662) (owner: 10Krinkle) [15:25:32] PROBLEM - check_ipsec on fran2001 is CRITICAL: Strongswan CRITICAL - ok: 1 connecting: (unnamed) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_ipsec [15:25:32] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 186.44, 135.31, 62.40 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [15:27:12] 06Fundraising-Backlog: Update the recurring failure/cancellation logic - https://phabricator.wikimedia.org/T413905#11782999 (10Ejegg) In the recurring meeting this morning, we suggested just changing the retry cadence (within a single month) as a first step, since it wouldn't need any additional emails or a 'rep... [15:30:08] RECOVERY - check_ipsec on fran2001 is OK: Strongswan OK - 1 ESP OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_ipsec [15:30:10] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 3.02, 54.77, 46.82 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [15:30:10] (03PS1) 10Lars SG: Add frequency, to recurring upgrade and downgrade activities from Donor Portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) [15:31:33] 06Fundraising-Backlog: Update the recurring failure/cancellation logic - https://phabricator.wikimedia.org/T413905#11783017 (10Ejegg) We currently have a scalar variable 'retry_delay_days' and are using the default value of 1. Let's make that into an array [15:33:05] 03Fundraising Sprint - Floor is Lava, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal, 13Patch-For-Review: Add frequency, native currency amount and USD amount to recurring pause and cancel activities from Donor Portal - https://phabricator.wikimedia.org/T421733#11783031 (10Lars... [15:35:08] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 0.73, 20.60, 34.13 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [15:35:35] (03PS1) 10Lars SG: Add importAlterMappedRow hook to searchkit batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267094 (https://phabricator.wikimedia.org/T421978) [15:36:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Call import hook from batch import - https://phabricator.wikimedia.org/T421978#11783048 (10Lars) You're right on top of it today, @ejegg, have done. [15:40:10] PROBLEM - check_load on fran2001 is CRITICAL: LOAD CRITICAL - total load average: 0.83, 8.04, 24.91 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [15:42:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Donor Portal - investigation request: activity tracking for cancellations - https://phabricator.wikimedia.org/T422035#11783064 (10Lars) Yes, the DR-initiated upgrades/downgrades are currently being r... [15:50:00] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Donor Portal - investigation request: activity tracking for cancellations - https://phabricator.wikimedia.org/T422035#11783081 (10Lars) a:03Lars [15:50:17] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: CiviCRM should not prevent sending of test emails to opted out contacts - https://phabricator.wikimedia.org/T422083#11783084 (10Lars) p:05Triage→03Low [15:52:03] (03CR) 10CI reject: [V:04-1] Add frequency, to recurring upgrade and downgrade activities from Donor Portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) (owner: 10Lars SG) [15:56:32] (03PS4) 10Damilare Adedoyin: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) [15:59:32] (03PS1) 10Ejegg: Add setting for arbitrary charge retry cadence [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267104 (https://phabricator.wikimedia.org/T413905) [15:59:54] cstone: does ^^^ look like about the right way to do it? [16:00:17] I'll delete the superceded settings in a follow-on patch [16:00:35] (03CR) 10Ejegg: [C:03+2] Add importAlterMappedRow hook to searchkit batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267094 (https://phabricator.wikimedia.org/T421978) (owner: 10Lars SG) [16:00:40] (03PS2) 10Lars SG: Add importAlterMappedRow hook to searchkit batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267094 (https://phabricator.wikimedia.org/T421978) [16:00:56] oops, i did that rebase / C+2 out of order [16:01:03] will that confuse zuul? [16:01:16] thanks ejegg ill take a look! sorry i was still reviewing your other change there so youll have to deal with that rebase [16:01:22] oh hah [16:01:31] right, those are gonna be a little clashy [16:01:43] i do wish there was a better way to segment them [16:02:14] i guess i was hoping that seeing the ugly modulo settings would inspire someone to notice a more elegant solution :) [16:04:05] cstone maybe just ID ranges would be less ugly than modulo? [16:04:21] i.e. one runner for the oldest ones, another for middle aged, and a third for newest ones [16:04:41] i was thinking about it ejegg hah but nothing obvious came to me [16:05:08] Let me at least try it with just minRecurID and maxRecurID [16:05:12] bucket by start date year ? [16:05:27] ids is easier though [16:05:59] and more straightforward to read on the process control job the mod stuff made sense just wasnt obvious from the command line what was going on [16:06:26] right, and that silly 'select N times the rows' stuff is horrid [16:06:34] gonna abandon that [16:07:21] (03Abandoned) 10Ejegg: Run recurring charge jobs in parallel [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1249397 (https://phabricator.wikimedia.org/T418824) (owner: 10Ejegg) [16:08:28] let's see, if we bucket by start year I'd still like to do it as min/max [16:08:41] that way the final bucket will always just have a min [16:08:43] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) (owner: 10Lars SG) [16:08:52] and we don't need to rush to get a new job in place when the year changes [16:09:12] just when we start seeing the job times start going too late in the day [16:09:45] I do like bucketing by year since it's a real thing to picture rather than arbitrary ID ranges [16:10:10] RECOVERY - check_load on fran2001 is OK: LOAD OK - total load average: 0.76, 1.06, 4.41 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran2001&service=check_load [16:10:17] and we can look at e.g. total number charged each night to have some idea how they age out [16:13:18] (03PS5) 10Damilare Adedoyin: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) [16:15:38] yeah i like the ids better [16:15:57] oh hah misread [16:16:39] let me see if selecting by year is just as fast [16:17:03] would we have like 10 jobs though or is it multiple years at once [16:17:29] cstone: I was thinking one with just max_start_year=2022 [16:17:46] one with min_start_year=2023 max_start_year=2024 [16:17:53] and one with min_start_year=2025 [16:18:27] then when that last one gets too big we add max_start_year=2025 and add another job with min_start_year=2026 [16:18:54] hmm, or do we do start_date in case we need to segment by months too? [16:19:03] ehhh ok, maybe IDs is simpler [16:19:59] when it gets to min and max i think the same level of complex is there command wise if its ids or years so if its easier code wise with ids [16:20:24] 10000 vs 2023 isnt much different, and then wouldnt have to worry about any time math [16:20:38] yeah, and ids are infinitely adjustable in case one year's worth ever takes too long [16:21:04] just needs a little closer scrutiny of the multiple job configs to ensure no overlap [16:35:00] 03Fundraising Sprint - Floor is Lava, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal, 13Patch-For-Review: Add frequency, native currency amount and USD amount to recurring pause and cancel activities from Donor Portal - https://phabricator.wikimedia.org/T421733#11783355 (10CHuds... [16:43:53] (03PS4) 10Wfan: Map for dlocal pix automatic [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265527 (https://phabricator.wikimedia.org/T419446) [16:44:39] (03CR) 10Wfan: Map for dlocal pix automatic (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265527 (https://phabricator.wikimedia.org/T419446) (owner: 10Wfan) [16:58:17] (03CR) 10Lars SG: [C:03+2] Close SFTP connection explicitly after upload [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1266299 (https://phabricator.wikimedia.org/T421772) (owner: 10Jgleeson) [16:58:27] thanks larssandergreen ! [17:00:17] (03Merged) 10jenkins-bot: Close SFTP connection explicitly after upload [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/1266299 (https://phabricator.wikimedia.org/T421772) (owner: 10Jgleeson) [17:05:21] (03CR) 10Ejegg: [C:03+2] "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1264185 (https://phabricator.wikimedia.org/T421662) (owner: 10Krinkle) [17:29:41] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Add both_funds_latest_OTG_donation_date and both_funds_latest_OTG_usd_amount to Civi & Acoustic export - https://phabricator.wikimedia.org/T422201 (10Lars) 03NEW [17:39:46] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install payments101[0-2] - https://phabricator.wikimedia.org/T416252#11783799 (10Jgreen) 05Open→03Resolved boxes are imaged, in replication, and ready for traffic once pfw policy is done [17:46:09] (03PS2) 10Lars SG: Add frequency, to recurring upgrade and downgrade activities from Donor Portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) [17:48:19] (03CR) 10Damilare Adedoyin: [C:03+1] "Thanks wfan. Looks good, though I'm concerned about the lack of a unit test for the new recurring flow." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1265527 (https://phabricator.wikimedia.org/T419446) (owner: 10Wfan) [17:50:58] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install payments101[0-2] - https://phabricator.wikimedia.org/T416252#11783859 (10Jgreen) [18:09:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Donor Portal - investigation request: activity tracking for cancellations - https://phabricator.wikimedia.org/T422035#11783909 (10CHudson-WMF) That'd be ideal if we could revise the CiviCRM data, but... [18:16:56] 10fundraising-tech-ops, 06DC-Ops, 10ops-eqiad, 06SRE: Q3:rack/setup/install payments101[0-2] - https://phabricator.wikimedia.org/T416252#11783930 (10Jclark-ctr) a:05Jgreen→03Jclark-ctr [18:17:17] (03CR) 10CI reject: [V:04-1] Add frequency, to recurring upgrade and downgrade activities from Donor Portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) (owner: 10Lars SG) [18:19:11] hah, just noticed the headline on the git manpage [18:19:12] git - the stupid content tracker [18:26:44] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donor-portal: Donor Portal - investigation request: activity tracking for cancellations - https://phabricator.wikimedia.org/T422035#11783992 (10Lars) Sure, I'll have a look and see how far back we could reasonably... [18:27:30] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267092 (https://phabricator.wikimedia.org/T421733) (owner: 10Lars SG) [19:10:17] (03CR) 10Damilare Adedoyin: [C:03+2] Use 'const' for constants in gravy.js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267071 (owner: 10Ejegg) [19:11:01] (03CR) 10Damilare Adedoyin: [C:03+2] Safeguard against dupe submit after Monthly Convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267078 (https://phabricator.wikimedia.org/T421990) (owner: 10Ejegg) [19:12:52] (03Merged) 10jenkins-bot: Use 'const' for constants in gravy.js [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267071 (owner: 10Ejegg) [19:13:18] (03Merged) 10jenkins-bot: Safeguard against dupe submit after Monthly Convert [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1267078 (https://phabricator.wikimedia.org/T421990) (owner: 10Ejegg) [19:17:34] (03CR) 10Damilare Adedoyin: [C:03+2] Fix operator precedence bug in gateway check for backend processor txn id repair [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1266996 (owner: 10Jgleeson) [19:18:17] (03CR) 10Damilare Adedoyin: [C:03+2] Add test link for dLocal Pix Automatico [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267054 (https://phabricator.wikimedia.org/T419446) (owner: 10Jgleeson) [19:18:20] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Add test link for dLocal Pix Automatico [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267054 (https://phabricator.wikimedia.org/T419446) (owner: 10Jgleeson) [19:18:33] (03CR) 10Damilare Adedoyin: [C:03+2] Rename payments-update-text.sh to payments-update-wiki-pages.sh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267055 (owner: 10Jgleeson) [19:18:36] (03CR) 10Damilare Adedoyin: [V:03+2 C:03+2] Rename payments-update-text.sh to payments-update-wiki-pages.sh [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1267055 (owner: 10Jgleeson) [19:22:11] (03PS6) 10Damilare Adedoyin: Show appropriate error for recurring pause failure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266308 (https://phabricator.wikimedia.org/T421917) [19:26:42] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1267176 [19:27:20] (03CR) 10Cstone: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1267176 (owner: 10Cstone) [19:34:57] damilare: I clicked your patch to review and then I saw [19:34:58] -46 +1105 [19:35:02] 😅 [19:35:17] uhhh [19:35:22] one for next week ha [19:35:52] ohh its just the tests lol [19:36:33] probably overkill but just wanted to make sure each failure scenario is modeled [19:41:21] tests make the world a better place [19:42:58] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1267176 (owner: 10Cstone) [19:57:42] (03PS2) 10Damilare Adedoyin: WIP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 [20:00:51] (03PS3) 10Damilare Adedoyin: WIP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 [20:03:31] (03PS4) 10Damilare Adedoyin: WIP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 [20:05:11] (03PS5) 10Damilare Adedoyin: Refactor components to share utility functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 [20:05:24] (03PS6) 10Damilare Adedoyin: Refactor DonorPortal components to share utility functions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1266398 [20:06:49] (03PS3) 10Damilare Adedoyin: Add maintenance script for getting a payment method configuration on Gravy [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1262164 [20:06:59] (03PS6) 10Damilare Adedoyin: Fetch enabled countries on Gravy to determine which currencies are unsupported and requires fallback [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1251522 (https://phabricator.wikimedia.org/T419704) [20:09:01] (03PS7) 10Damilare Adedoyin: Add idempotency key to Gravy transaction requests. Using the invoice_id as a key to ensure duplicates are caught. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1255890 [21:02:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: "mismatched contact types" when trying to import anonymous Fidelity donation - https://phabricator.wikimedia.org/T422213 (10Lars) 03NEW [21:02:58] (03PS1) 10Lars SG: Useful error message if the required contact is not found by name for Fidelity anonymous imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267205 (https://phabricator.wikimedia.org/T422213) [21:16:39] (03PS4) 10Wfan: Add play icon for wikiminute and make the image adjustable in mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262384 (https://phabricator.wikimedia.org/T420782) [21:17:14] (03CR) 10Ejegg: [C:03+2] "Looks good to me on Android (FF and Chrome), and still seems good on desktop" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262384 (https://phabricator.wikimedia.org/T420782) (owner: 10Wfan) [21:20:52] (03Merged) 10jenkins-bot: Add play icon for wikiminute and make the image adjustable in mobile [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1262384 (https://phabricator.wikimedia.org/T420782) (owner: 10Wfan) [21:34:22] fr-tech anyone mind if I set the gravy sandbox connector to route CC to adyen again? [21:34:42] I'm getting errors trying the test card numbers I know and it looks like they're going via stripe [21:35:28] go for it ejegg [21:35:37] thanks [21:36:10] im gona deploy DI, small the changes to the app code and gravy js will go out too, ill keep an eye on the logs [21:36:24] oh cool, thanks! [21:36:37] and the triple click prevention you added ejegg is in there too [21:37:13] nice [21:38:44] !log payments-wiki upgraded from 86bec442 to 80cda166 [21:38:45] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:41:44] hey, I think I got a capture IPN from gravy sandbox in just a few minutes [21:41:54] let's run those job runners and see if it gets into civi [21:43:46] 03Fundraising Sprint - Floor is Lava, 06Fundraising-Backlog, 05MW-1.46-notes (1.46.0-wmf.23; 2026-04-07): Add appropriate consent/opt-in language to Payments form SMS capture - https://phabricator.wikimedia.org/T420271#11784460 (10Cstone) Just deployed the text update [21:44:05] ooh nice ejegg do you have your own config for it? i stopped trying to fix mine [21:45:15] the scripts/consume-queues.sh script should run the job runners [21:45:31] ah yeah i meant for the gravy ipn settings [21:45:38] i think thats still my issue if yours are working [21:45:40] and the IPN listener should work fine with the standard config and config-private [21:45:57] your proxy-forward script is working? [21:46:18] yeah i mean the config, you didnt update it from the default gravy ipn username? [21:46:39] oh let me see if I have something custom in there [21:47:33] nope, I just have the same smashpig/gravy/main.yaml as is checked into config-private [21:47:45] so that webhook username and password seems to be working [21:47:48] okay well, ill let you finish testing before i start messing with that [21:47:56] i dont need to test now but ill try that later tonight [21:49:04] ejegg: how long did it take the capture ipn to appear? [21:49:45] about 90 sec from form submit! [21:49:49] nice! [21:50:00] I think maybe they fixed something after I mentioned it in the call [21:50:22] yeah hah [21:52:40] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog: Recurring charge job not getting through that days charges in 24 hours (February 28 and future problem) - https://phabricator.wikimedia.org/T418824#11784485 (10Ejegg) Fun way to get the middle ID to partition jobs by IDs `lang=sql select median(id) over (... [21:55:13] oh hmm, we don't get the invoice_id in the contribution_recur column for gravy? [21:57:08] anyway, let me just test those min_recur_id and max_recur_id parameters [21:59:51] ok, they seem to work [21:59:58] way less confusing than modulo [22:03:48] (03PS1) 10Ejegg: Add min/max recur_id params to segment charge jobs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267224 (https://phabricator.wikimedia.org/T418824) [22:03:58] ok cstone ^^^ is the less confusing version [22:04:26] I left min_recur_id and max_recur_id out of the $allowedParams array because what it really means is '$paramsThatCanAlsoBeSettings' [22:04:45] I just didn't want to rename it in this patch for merge conflict reasons :) [22:09:34] (03CR) 10Wfan: Some validation error do not have error_code (034 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1264860 (https://phabricator.wikimedia.org/T421155) (owner: 10Wfan) [22:18:11] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: "mismatched contact types" when trying to import anonymous Fidelity donation - https://phabricator.wikimedia.org/T422213#11784530 (10Lars) But there was a second layer here: cid 67767406 was also be... [22:33:41] (03CR) 10CI reject: [V:04-1] Add min/max recur_id params to segment charge jobs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267224 (https://phabricator.wikimedia.org/T418824) (owner: 10Ejegg) [22:56:22] (03PS1) 10Wfan: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1267246 [22:57:35] (03CR) 10Wfan: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1267246 (owner: 10Wfan) [23:01:36] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Call import hook from batch import - https://phabricator.wikimedia.org/T421978#11784611 (10Lars) To do: review import code as above, then add a check on importType = contribution_import_searchkit to... [23:32:07] 10fundraising-tech-ops: Fundraising access request for sfloyd - https://phabricator.wikimedia.org/T420990#11784648 (10Dwisehaupt) [23:32:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Converts SearchKit batch import mappedRow keys to match standard import format. - https://phabricator.wikimedia.org/T422221 (10Lars) 03NEW [23:32:42] 10fundraising-tech-ops: Fundraising access request for sfloyd - https://phabricator.wikimedia.org/T420990#11784663 (10Dwisehaupt) 05Open→03Resolved Worked with sfloyd to get the cert installed and verified access is working. [23:36:52] (03PS1) 10Wfan: Upgrade SmashPig to 1.2.3.21 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267278 [23:38:18] (03CR) 10Wfan: [C:03+2] Upgrade SmashPig to 1.2.3.21 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267278 (owner: 10Wfan) [23:48:11] ??? No idea why this is a failure result: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-bookworm/5287/console [23:48:19] all the tests passed [23:49:59] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267224 (https://phabricator.wikimedia.org/T418824) (owner: 10Ejegg) [23:51:19] the only 'warning' is from Civi\BaseTestClass which seems to be inaccurately categorized as being a test case [23:53:25] (03CR) 10Wfan: [V:03+2 C:03+2] Upgrade SmashPig to 1.2.3.21 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1267278 (owner: 10Wfan) [23:55:23] (03PS1) 10Wfan: Update Smashpig to 1.2.3.21 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1267283 [23:56:07] (03CR) 10Wfan: [C:03+2] Update Smashpig to 1.2.3.21 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1267283 (owner: 10Wfan) [23:57:02] (03CR) 10Wfan: [V:03+2 C:03+2] Update Smashpig to 1.2.3.21 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1267283 (owner: 10Wfan) [23:57:19] (03PS1) 10Wfan: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1267284