[00:03:00] 06Fundraising-Backlog: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965 (10spatton) 03NEW [00:03:30] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965#12320551 (10spatton) [00:38:17] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prefer individual over org when 2+ contacts share and email on Acoustic export - https://phabricator.wikimedia.org/T437967 (10Lars) 03NEW [00:43:00] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Change email greeting field in Acoustic to be more usable so we don't have to use first name - https://phabricator.wikimedia.org/T437968 (10Lars) 03NEW [01:16:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 10FR-WMF-Audit: Failmail alert paypal_audit - https://phabricator.wikimedia.org/T437215#12320643 (10Ejegg) Searching in the FRUP account I did find it - seems to be an unsolicited donation. Looks like ppl can send us money just by searc... [01:32:09] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: filter payment method by supported country - https://phabricator.wikimedia.org/T437508#12320662 (10dmiranda) a:03dmiranda [01:44:08] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-failmail, 10FR-WMF-Audit: Failmail alert paypal_audit - https://phabricator.wikimedia.org/T437215#12320688 (10Eileenmcnaughton) @ejegg got in to analyse how this happened {F102981803} And proposed approach {F102981891} [01:45:16] (03PS1) 10Ejegg: Add Payment Attempt Label when marking fraud [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341476 (https://phabricator.wikimedia.org/T437905) [01:55:36] (03PS2) 10Ejegg: Automatic Payment Attempt Labels [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341476 (https://phabricator.wikimedia.org/T437905) [02:10:41] (03PS3) 10Lars SG: Add temporary logging to see why email templates are being sent instead of translated versions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341325 (https://phabricator.wikimedia.org/T437936) [02:10:42] (03CR) 10Ejegg: [C:03+2] Add temporary logging to see why email templates are being sent instead of translated versions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341325 (https://phabricator.wikimedia.org/T437936) (owner: 10Lars SG) [02:18:39] (03PS1) 10Ejegg: Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1341493 [02:18:42] (03CR) 10Ejegg: [C:03+2] Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1341493 (owner: 10Ejegg) [02:18:49] (03CR) 10Ejegg: [C:03+2] Update composer libraries [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1339156 (owner: 10Ejegg) [02:18:57] (03CR) 10Ejegg: [V:03+2 C:03+2] Update SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1341493 (owner: 10Ejegg) [02:19:48] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341497 [02:19:51] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341497 (owner: 10Ejegg) [02:31:40] (03Merged) 10jenkins-bot: Add temporary logging to see why email templates are being sent instead of translated versions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341325 (https://phabricator.wikimedia.org/T437936) (owner: 10Lars SG) [02:31:43] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341497 (owner: 10Ejegg) [02:34:49] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965#12320736 (10Ejegg) This has come up a few times now. At first I thought a simple hook in the CentralNotice code would be... [02:37:05] !log disabled donations queue consumer for civi update [02:37:06] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:37:22] larssandergreen: I'm deploying your code to make those fields use option values [02:37:36] just turning off the queue as a precaution [02:38:57] !log civicrm upgraded from 9436540f to ab17ae45 [02:38:59] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [02:41:23] hmm, warning in loadOptionsForField [02:41:24] [PHP Warning] Trying to access array offset on value of type null at /srv/org.wikimedia.civicrm/ext/wmf-civicrm/Civi/WMFQueueMessage/Message.php:984 [02:41:31] maybe something cached? [02:42:56] still getting the warning after a system.flush [02:44:44] hmm, this is not a simple roll back either [02:44:45] dang [02:45:23] well, just needs to reset those db fields I guess - maybe a logging.revert call [02:49:33] eileen: do you have some insight into why ^^^ warning is happening after deploying this patch? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1339214 [02:50:44] that should have just changed the types for a couple of direct_mail_data fields which extend activity [02:51:13] nothing that extends Contribution or Contact [02:52:05] ahh, but there's the collision in the direct_mail_appeal field name maybe? [02:52:21] that could make sense [02:53:23] so how to we un-collide them? [02:53:43] or I guess just roll back that change for now [02:53:51] looking in the log table [02:56:01] huh, i don't see the changes in there :( [02:59:49] I'll test that get options api call [03:00:49] wait, there is only one direct_mail_appeal field [03:01:26] and it's in the direct_mail_data group [03:01:35] i could have sworn there was another field with that name [03:01:45] i mean, it's in the messages for normal non-direct-mail donations [03:03:15] right, seems like it's just Gift_Data.Appeal [03:04:05] ejegg: let's add debug first to be sure the custom field id it's using - and the entity it is passing to getFields $entity = $field['custom_group']['extends'] === 'Contribution' ? 'Contribution' : 'Contact'; [03:05:09] if it mixed them up it might be trying to get the Activity field in here [03:07:07] I think the SmashPigRecurringProcessor shouldn't be mutating the field names here, either: https://phabricator.wikimedia.org/diffusion/WFCG/browse/master/ext/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php#L401 [03:07:27] We can just pass the full Gift_Data.XXX field names to the queue consumer now, right? [03:11:24] eileen: shoot, at this point I just want to roll back, turn the queue back on, and resolve this in the morning. I think it might be enough to revert log_conn_id 6aa8afcbd414ajecG and roll back the code [03:11:36] ejegg: reading this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1339214/2/ext/wmf-civicrm/CRM/Wmf/Upgrader.php#5465 - it doesn't do what the code comment says? [03:12:29] It looks like that's what it does, but I guess it might have a side effect due to our weird mapping [03:13:03] and I'm not quite awake enough to figure it out tonight [03:14:28] doing the revert [03:17:39] shoot, DB Error: already exists [03:18:00] ok, i'll just manually set it back to free text [03:18:49] So this is what we have [03:18:49] select f.id,f.name,g.name as group_name, extends,option_group_id, custom_group_id,data_type, html_type FROM civicrm_custom_field f LEFT JOIN civicrm_custom_group g ON g.id = custom_group_id WHERE option_group_id IN(39,179); [03:18:49] +-----+---------------------+------------------------+--------------+-----------------+-----------------+-----------+---------------------+ [03:18:49] | id | name | group_name | extends | option_group_id | custom_group_id | data_type | html_type | [03:18:50] +-----+---------------------+------------------------+--------------+-----------------+-----------------+-----------+---------------------+ [03:18:50] | 20 | Appeal | Gift_Data | Contribution | 39 | 7 | String | Select | [03:18:51] | 377 | Package | Gift_Data | Contribution | 179 | 7 | String | Autocomplete-Select | [03:18:51] | 399 | direct_mail_appeal | direct_mail_data | Activity | 39 | 42 | String | Select | [03:18:52] | 400 | direct_mail_package | direct_mail_data | Activity | 179 | 42 | String | Select | [03:18:52] | 488 | Appeal | Major_Gifts_Engagement | Activity | 39 | 48 | String | Select | [03:18:53] +-----+---------------------+------------------------+--------------+-----------------+-----------------+-----------+---------------------+ [03:20:50] ok, I manually set direct_mail_appeal back to single line text and the warning is gone [03:21:00] so I think I can turn the queue consumer on again [03:22:19] cross fingers [03:24:08] ejegg: I may have a patch [03:25:01] (03PS1) 10Ejegg: Queue recurring Gift_Data fields with full names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341540 [03:25:03] oho? [03:25:09] I had that ^^^ [03:25:16] (03PS3) 10Eileen: Add StockGift entity and Overflow audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334716 (https://phabricator.wikimedia.org/T436895) [03:25:16] (03PS1) 10Eileen: Only handle incoming Contact & Contribution fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341541 [03:25:52] ^^ - (can be rebased off the other patch which I think depends on Overflow anyway) [03:29:09] eileen: that $fieldsToMap list has the other two Gift_Data fields with weird message-field names [03:29:18] any reason direct_mail_appeal was missing there? [03:30:40] I think your patch will make it just ignore direct_mail_appeal [03:30:55] since $fieldID = \CRM_Core_BAO_CustomField::getCustomFieldID($parts[0]); is apparently returning the other one [03:31:06] well I think legacy-ness is the issue - ie the old fields all had unique stuff - the new ones were supposed to be generic [03:32:16] but we don't want to just start dropping that field, right? [03:32:34] lemme see [03:33:44] Oh - so direct_mail_appeal is a smashpig field & an activity field but not a contribution field... so it misses [03:34:15] it's just a weird name on the queue that should map to Gift_Data.appeal [03:34:25] but I think we can use the full names on the queue now, right? [03:34:50] yeah - we should be able to - does your db change allow them through - did you try a slow start? [03:35:11] yeah, i did a slow start and got no warning [03:35:21] so i'm just restarting the whole queue [03:35:33] err, did restart the whole queue [03:35:43] !log restarted donations queue consumer [03:35:45] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [03:36:09] right, no warnings in the last full run [03:37:10] so we never send direct_mail_appeal from the front end [03:37:51] and the only place I see it in the IPN listener is something from PayPal/GiveLively referencing this ticket: https://phabricator.wikimedia.org/T295726 [03:38:25] I think if we swap that and merge the SmashPigRecurringProcessor patch we should be able to stop doing that weird mapping [03:39:05] ok ejegg what was your commit link again? [03:39:12] and I guess update the names in the getAvailableFields mapping? [03:39:24] or do fully-specified fields not need that now? [03:39:41] https://gerrit.wikimedia.org/r/1341540 was the one to fix recurring donations [03:39:48] but is def worth a local smoke test [03:39:53] I don't think they do - but I can try & do a test to cover it if we are stable enough for you to go to bed [03:40:12] yeah, I think we are stable enough for now. [03:40:28] I'll just write a note to lars saying I had to undo that part of his patch due to side effects [03:41:07] ok [03:43:49] (03CR) 10CI reject: [V:04-1] Only handle incoming Contact & Contribution fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341541 (owner: 10Eileen) [03:44:12] (03Abandoned) 10Eileen: Only handle incoming Contact & Contribution fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341541 (owner: 10Eileen) [03:44:28] (03CR) 10CI reject: [V:04-1] Add StockGift entity and Overflow audit processor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1334716 (https://phabricator.wikimedia.org/T436895) (owner: 10Eileen) [03:47:58] thanks eileen [03:48:03] I'm going to head to bed now [03:48:17] night [03:48:19] will take another look in the morning [04:03:14] thanks ejegg & eileen, sorry that I missed all the fun [04:10:02] lol larssandergreen I was pretty late to the party too - your patch is partially reverted (at the db layer) at this stage [04:45:09] (03PS1) 10Eileen: Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) [04:47:03] (03PS8) 10Lars SG: Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) [04:47:08] (03PS4) 10Lars SG: Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759) [04:56:07] (03CR) 10Lars SG: [C:03+2] Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) (owner: 10Eileen) [05:03:53] (03CR) 10CI reject: [V:04-1] Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) (owner: 10Eileen) [05:43:16] (03PS2) 10Eileen: Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) [05:50:50] (03PS3) 10Eileen: Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) [08:26:04] (03PS1) 10Eileen: Treat unsolicited payment as a donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341691 (https://phabricator.wikimedia.org/T437215) [08:26:40] (03CR) 10CI reject: [V:04-1] Treat unsolicited payment as a donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341691 (https://phabricator.wikimedia.org/T437215) (owner: 10Eileen) [08:30:04] (03PS2) 10Eileen: Treat unsolicited payment as a donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341691 (https://phabricator.wikimedia.org/T437215) [09:05:22] (03PS1) 10Eileen: Handling incoming unsolicited PayPal donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341707 (https://phabricator.wikimedia.org/T437215) [09:18:00] (03CR) 10CI reject: [V:04-1] Handling incoming unsolicited PayPal donations [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341707 (https://phabricator.wikimedia.org/T437215) (owner: 10Eileen) [10:11:58] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965#12321758 (10Pcoombe) We're also seeing this for the current "[Minimal Minerva](https://www.mediawiki.org/wiki/Readers/Rea... [10:18:18] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341760 (owner: 10L10n-bot) [10:27:19] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341760 (owner: 10L10n-bot) [10:52:50] 06Fundraising-Backlog, 06Data-Engineering, 06Data-Engineering-Icebox, 06WMDE-FUN-Team, 10WMDE-Fundraising-Tech: Find a better way for WMDE to get impression counts for their banners - https://phabricator.wikimedia.org/T243092#12322007 (10AbbanWMDE) 05Open→03Resolved [12:41:59] (03CR) 10Laurabarluzzi: [C:03+2] Treat unsolicited payment as a donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341691 (https://phabricator.wikimedia.org/T437215) (owner: 10Eileen) [12:42:40] (03Merged) 10jenkins-bot: Treat unsolicited payment as a donation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341691 (https://phabricator.wikimedia.org/T437215) (owner: 10Eileen) [13:32:23] (03CR) 10Ejegg: [C:03+2] Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) (owner: 10Eileen) [13:48:10] FIRING: WidespreadPuppetFailure: Puppet has failed on over 5% of hosts - https://frmon.wikimedia.org/d/dwcgqww/puppet - https://alerts.wikimedia.org/?q=alertname%3DWidespreadPuppetFailure [13:54:28] hi larssandergreen [13:54:33] (03Merged) 10jenkins-bot: Update push to integration log for new widget [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341597 (https://phabricator.wikimedia.org/T420671) (owner: 10Eileen) [13:54:50] I just want to smoke test using those Gift_Data.xxx names for the fields rather than the odd mappings [13:55:12] then we should be able to re-apply your field type change [13:55:52] in the meantime I've dug a little bit deeper into the repeat searchkit submission ID bug: https://phabricator.wikimedia.org/T437451 [13:56:02] just need to figure out why the controller container has those stale values [13:56:10] must be cached from the previous submission [13:57:19] We should probably fix the controller container to update its values from the request, rather than just fix loadValues to ignore id from the container when it's already set, right? [14:05:48] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035 (10ppenloglou) 03NEW [14:06:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12323041 (10ppenloglou) [14:09:27] (03PS1) 10Ejegg: Send Gift_Data fields to queues as fully qualified names [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341898 [14:09:48] ok, that should handle the other places that field is being sent from [14:09:55] (03CR) 10CI reject: [V:04-1] Send Gift_Data fields to queues as fully qualified names [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341898 (owner: 10Ejegg) [14:09:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12323065 (10ppenloglou) [14:14:27] huh, there are a couple of places where the field name needs to be snake case for array shape hints etc [14:14:31] bah [14:14:45] ok, maybe we just fix that one message function for now [14:14:56] I was too tired last night to delve into that stuff [14:22:55] ok, so the mapping in that getCustomFieldMetadata function was removed in this patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1191218 [14:25:30] 06Fundraising-Backlog, 10FR-Donor-portal: Add employer field to donor portal - https://phabricator.wikimedia.org/T438039 (10Lars) 03NEW [14:28:45] 06Fundraising-Backlog, 10FR-Donor-portal, 10FR-email-preferences, 07Epic: Epic: Move email preferences center into donor portal - https://phabricator.wikimedia.org/T438040 (10Lars) 03NEW [14:29:53] 06Fundraising-Backlog, 10FR-Donor-portal, 10FR-email-preferences, 07Epic: Epic: Move email preferences center into donor portal - https://phabricator.wikimedia.org/T438040#12323233 (10Bugreporter2) Why is this #epic ? [14:33:31] (03PS1) 10Ejegg: Map direct_mail_appeal before calling getCustomFields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341910 [14:33:49] ok larssandergreen I think that might be the lightest-touch way to fix it ^^^ [14:34:28] (03CR) 10Ejegg: [C:04-1] "Let's try I4799e41328ba33d23b9c72a49178cf262ae6910d instead" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341898 (owner: 10Ejegg) [14:34:32] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refund Contribution searchkit task fails on second search - https://phabricator.wikimedia.org/T437451#12323280 (10Lars) If this is a pain to fix, it might be easier just to move away from the single task and switch back... [14:38:06] hmm, maybe that's not the way either [14:47:22] (03PS2) 10Ejegg: Add direct_mail_appeal as supported field for DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341910 [14:47:39] ok, for real this time. ^^^ seems to be the actual simplest fix [14:48:39] (03CR) 10Ejegg: [C:04-1] "We should be able to fix the collision with I4799e41328ba33d23b9c72a49178cf262ae6910d instead" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341540 (owner: 10Ejegg) [14:52:29] (03PS1) 10Ejegg: Redo rolled-back part of Lars' field type change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341916 (https://phabricator.wikimedia.org/T386031) [14:52:58] oh dang i'm missing a meeting [14:54:58] (03CR) 10Lars SG: [C:03+2] Add direct_mail_appeal as supported field for DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341910 (owner: 10Ejegg) [14:55:32] (03CR) 10Lars SG: [C:03+2] Redo rolled-back part of Lars' field type change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341916 (https://phabricator.wikimedia.org/T386031) (owner: 10Ejegg) [14:57:27] thanks larssandergreen [14:57:55] well, thank you for dealing with the unintended fallout of my change [14:58:31] I kind of miss the procedural queue consumer code, as complex as it was :P [15:18:49] (03Merged) 10jenkins-bot: Add direct_mail_appeal as supported field for DonationMessage [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341910 (owner: 10Ejegg) [15:18:51] (03Merged) 10jenkins-bot: Redo rolled-back part of Lars' field type change [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341916 (https://phabricator.wikimedia.org/T386031) (owner: 10Ejegg) [15:20:57] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341923 [15:20:59] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341923 (owner: 10Ejegg) [15:21:59] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1341923 (owner: 10Ejegg) [15:23:38] !log disabled donations queue consumer for civi update [15:23:40] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [15:24:04] !log fundraising civicrm upgraded from ab17ae45 to ea392ac2 [15:24:05] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [15:37:19] ok, slow start looks good [15:40:32] !log re-enabled donations queue consumer [15:40:33] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [15:47:50] 06Fundraising-Analysis, 06Fundraising-Backlog, 06Data-Platform-SRE (2026-08-28 - 2026-09-18): Upgrade airflow-fr-tech to 3.3.x - https://phabricator.wikimedia.org/T435479#12323789 (10Gehel) [15:48:36] 06Fundraising-Analysis, 06Fundraising-Backlog, 06Data-Platform-SRE (2026-08-28 - 2026-09-18), 07Essential-Work: Upgrade airflow-fr-tech to 3.3.x - https://phabricator.wikimedia.org/T435479#12323807 (10Gehel) [16:06:37] (03CR) 10Ejegg: "Sorry I didn't have more time to review this earlier. So this looks like it will potentially have two unwanted effects:" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1327214 (https://phabricator.wikimedia.org/T435658) (owner: 10Jdlrobson) [16:09:23] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, 07Epic: Epic: Improve batch entry for DAF donation soft credits and shared addresses - https://phabricator.wikimedia.org/T408451#12323990 (10Lars) When we start not adding emails to DAF contacts,... [16:14:23] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Still allow previewing banners despite CentralNoticeProhibitedExperiments - https://phabricator.wikimedia.org/T438057 (10Pcoombe) 03NEW [16:16:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email not added to existing contact without email in Contribution::Save - https://phabricator.wikimedia.org/T438059 (10Lars) 03NEW [16:18:46] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email not added to existing contact without email in Contribution::Save - https://phabricator.wikimedia.org/T438059#12324074 (10Lars) See [[ https://wikimedia.slack.com/archives/C045WH0QYS2/p1789487270364739 | Slack ]] [16:21:11] (03Abandoned) 10Krinkle: Remove calls to Database::getCacheSetOptions() [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1325946 (https://phabricator.wikimedia.org/T424357) (owner: 10Ladsgroup) [16:34:50] 10Fundraising analytics stack, 10fundraising-tech-ops: trino issue on fransw1003 caused failures in the trino controller and metabase - https://phabricator.wikimedia.org/T438060 (10Dwisehaupt) 03NEW [16:36:11] (03PS1) 10Wfan: Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) [16:36:21] (03CR) 10CI reject: [V:04-1] Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) (owner: 10Wfan) [16:41:54] (03PS2) 10Wfan: Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) [16:43:25] (03CR) 10CI reject: [V:04-1] Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) (owner: 10Wfan) [16:52:24] (03PS3) 10Wfan: Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) [16:56:02] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal: Change Donor Account name to Donor Portal - https://phabricator.wikimedia.org/T438069 (10Fundraising-Task-Bot) 03NEW [16:57:09] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12324298 (10SBurnett-WMF) @ppenloglou - do you have a time frame in mind for when this would be implemented? [17:06:01] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal: Change Donor Account name to Donor Portal - https://phabricator.wikimedia.org/T438069#12324347 (10CSatchell-WMF) https://donorpreferences.wikimedia.org/index.php?title=Special:DonorPortal&wmf_medium=wmfSite&wmf_source=79219#/login Change... [17:09:47] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal: Change Donor Account name to Donor Portal - https://phabricator.wikimedia.org/T438069#12324388 (10Lars) @CSatchell-WMF No need to produce a list, we can just grep for them in code. No uses in Civi code. So I think the only other changes... [17:18:44] (03PS1) 10Lars SG: Rename donor account to donor portal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341960 (https://phabricator.wikimedia.org/T438069) [17:20:03] 03Fundraising Sprint: Quiz Show Podium, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal, 13Patch-For-Review: Change Donor Account name to Donor Portal - https://phabricator.wikimedia.org/T438069#12324419 (10Lars) [17:20:34] 03Fundraising Sprint: Quiz Show Podium, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-Donor-portal, 13Patch-For-Review: Change Donor Account name to Donor Portal - https://phabricator.wikimedia.org/T438069#12324421 (10Lars) @CSatchell-WMF The patch above should cover the fr-tech part of this. [17:25:24] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email not added to existing contact without email in Contribution::Save - https://phabricator.wikimedia.org/T438059#12324442 (10Damilare) a:03Damilare [17:30:53] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12324479 (10Lars) The challenge here is how do we handle donors who gave in more than one currency over the year. If we are comfortable just reporting the total of their donati... [17:41:04] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12324537 (10Lars) We have 13500 donors who gave in more than one currency in 2025, for reference. [17:42:11] FIRING: NodeDown: Node payments1009 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1009 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:47:11] RESOLVED: NodeDown: Node payments1009 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1009 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:52:11] FIRING: [2x] NodeDown: Node payments1009 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [17:57:11] RESOLVED: [2x] NodeDown: Node payments1009 is down. - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [18:04:22] 06Fundraising-Backlog: Track backend_processor in payment attempts table - https://phabricator.wikimedia.org/T438075 (10Ejegg) 03NEW [18:09:46] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for akost - https://phabricator.wikimedia.org/T436683#12324628 (10Dwisehaupt) [18:10:22] 06Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for akost - https://phabricator.wikimedia.org/T436683#12324643 (10Dwisehaupt) 05Open→03Resolved Met with Andrea yesterday to assist with cert install and verify it was working. Closing. [18:15:45] (03PS1) 10Wfan: Log ComboWiki monthly convert failures instead of alerting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1340103 (https://phabricator.wikimedia.org/T437543) (owner: 10Dmiranda) [18:15:45] (03CR) 10Wfan: "do not forget to clear error message too, looks nice!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1340103 (https://phabricator.wikimedia.org/T437543) (owner: 10Dmiranda) [18:16:11] FIRING: NodeDown: Node payments1011 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1011 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [18:21:11] RESOLVED: NodeDown: Node payments1011 is down. - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1011 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown [18:24:26] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965#12324711 (10Ejegg) Oh hey, it looks like this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNot... [18:32:06] (03PS4) 10Wfan: Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) [18:47:38] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Solution so TestKitchen experiments can run in tandem with CentralNotice experiments - https://phabricator.wikimedia.org/T437965#12324797 (10SBurnett-WMF) @Ejegg - pop on over here: https://phabricator.wikimedia.org/T438057 [18:59:36] (03CR) 10Jdlrobson: "> Sorry I didn't have more time to review this earlier." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1327214 (https://phabricator.wikimedia.org/T435658) (owner: 10Jdlrobson) [19:08:42] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Still allow previewing banners despite CentralNoticeProhibitedExperiments - https://phabricator.wikimedia.org/T438057#12324852 (10Jdlrobson-WMF) > This is essential for the online fundraising team to test banner interactions with the potential site c... [19:25:47] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email not added to existing contact without email in Contribution::Save - https://phabricator.wikimedia.org/T438059#12324909 (10Lars) @Damilare If you want to handle this, check Civi\Api4\Action\OfflineGift\Save (which e... [19:37:52] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Still allow previewing banners despite CentralNoticeProhibitedExperiments - https://phabricator.wikimedia.org/T438057#12324964 (10SBurnett-WMF) from @Ejegg Oh hey, it looks like this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Centra... [19:49:15] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12324989 (10ppenloglou) Hi @SBurnett-WMF, I'd say no real rush on this one. Maybe in the next month or two if you can accommodate? (Again, let's begin after we've figured out... [19:49:17] 06Fundraising-Backlog, 06FR-donorrelations, 07payments-orchestration: consider updating 'expiry date' to 'expiration date' on US donation form - https://phabricator.wikimedia.org/T414624#12324990 (10MBeat33) I looked at Gravy's documentation and wasn't sure how to make this change based on that. I followed u... [19:50:54] 03Fundraising Sprint: Quiz Show Podium, 06Fundraising-Backlog, 10Fundraising-CiviCRM-Starting-Tasks, 10Wikimedia-Fundraising-CiviCRM, and 3 others: When a donor portal link is requested for an email that isn't a primary email in CiviCRM, send them some kin... - https://phabricator.wikimedia.org/T426118#12324993 [19:53:36] (03CR) 10Dmiranda: [C:03+2] "Thanks for making the case-sensitive update! LGTM @wfan@wikimedia.org" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) (owner: 10Wfan) [19:55:22] (03Merged) 10jenkins-bot: Add forbidden country view render [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1341946 (https://phabricator.wikimedia.org/T435681) (owner: 10Wfan) [19:55:28] 06Wikimedia-Fundraising: fr-design-system updates - https://phabricator.wikimedia.org/T438083 (10ppenloglou) 03NEW [20:04:56] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Maybe we can manage legacy Paypal recurrings or provide links? - https://phabricator.wikimedia.org/T435556#12325071 (10Lars) Further investigation with a goal of being able to send paypal_ec donors to donor portal: [[ https://developer.paypal.com/api/nvp... [20:57:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email change verification has incorrect link - https://phabricator.wikimedia.org/T437921#12325209 (10Lars) Backfill is done. [21:31:23] 10Fundraising-CiviCRM-Starting-Tasks, 10fundraising-tech-ops: CiviCRM Login Assistance for Caitlin Satchell - https://phabricator.wikimedia.org/T437072#12325287 (10JLam-WMF) [21:32:27] 10Fundraising-CiviCRM-Starting-Tasks, 10fundraising-tech-ops: CiviCRM Login Assistance for Caitlin Satchell - https://phabricator.wikimedia.org/T437072#12325293 (10JLam-WMF) Hi all, Adding fundraising-tech-ops for visibility. Please assist Caitlin with this issue. Thanks! [21:37:37] (03PS1) 10Ejegg: Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) [21:38:24] danielfm: I thought it might be nice to have the config classes in their own namespace before doing any refactoring ^^^ [21:39:15] Thanks ejegg: I'll take a look right now! [21:39:24] hmm, though that probably needs some work - seeing a lot of 'E'rrors on my phpunit run [21:40:00] ah no that's because I started trying to enable TestKitchen :P [21:40:37] oh lol I guess that answers my question about whether it can be coerced to work with the LTS version of mediawiki [21:41:45] (03CR) 10CI reject: [V:04-1] Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) (owner: 10Ejegg) [21:43:08] oh weird, why is it still looking for Special/GatewayRouter? [21:43:20] ohhh there was no 'use' statement before because it was in the same dir [21:44:13] (03PS2) 10Ejegg: Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) [21:46:06] (03CR) 10CI reject: [V:04-1] Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) (owner: 10Ejegg) [21:50:14] (03PS3) 10Ejegg: Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) [21:50:24] good catch, phan [21:51:23] then I was trying to remember the best way to cache something for the duration of the request in Mediawiki [21:52:14] (03CR) 10CI reject: [V:04-1] Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) (owner: 10Ejegg) [21:54:21] (03PS4) 10Ejegg: Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) [21:54:35] So there are all these 'Cache' classes: https://www.mediawiki.org/wiki/Object_cache [21:55:07] I guess we could configure one of them to be a HashBagOStuff [21:55:12] which is just in-memory [21:55:45] CiviCRM has this Civi::$statics constant that you're supposed to use for anything like that [21:56:01] rather than local private static properties or variables [21:56:10] since those can have unpredictable side effects [21:56:13] and make testing annoying [21:57:23] I just don't want to cache this stuff much beyond one request [21:57:41] though I guess it should be able to invalidate the cache based on file timestamps [22:01:12] 10fundraising-tech-ops: Fundraising access request for csatchell - https://phabricator.wikimedia.org/T438087 (10Dwisehaupt) 03NEW [22:03:24] 10fundraising-tech-ops: Fundraising access request for csatchell - https://phabricator.wikimedia.org/T438087#12325365 (10Dwisehaupt) [22:05:24] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Clean up data for Civi users whose first names are numbers - https://phabricator.wikimedia.org/T438088 (10Ejegg) 03NEW [22:05:33] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Clean up data for Civi users whose first names are numbers - https://phabricator.wikimedia.org/T438088#12325380 (10Ejegg) p:05Triage→03Low [22:09:29] 10fundraising-tech-ops: Fundraising access request for csatchell - https://phabricator.wikimedia.org/T438087#12325382 (10Dwisehaupt) a:03Dwisehaupt Sent email to @RMurthy and spuri to verify access is needed and get approval. [22:11:22] 10Fundraising-CiviCRM-Starting-Tasks, 10fundraising-tech-ops: CiviCRM Login Assistance for Caitlin Satchell - https://phabricator.wikimedia.org/T437072#12325391 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt The error was due to Caitlin not having an account in civicrm. I have opened {T438087} for t... [22:13:24] whew, passing tests: https://gerrit.wikimedia.org/r/1342054 [22:14:26] ok, I've got to sign off [22:15:49] Nice! ejegg: Ill give it another look :D have a great rest of your day! [22:41:31] (03CR) 10Dmiranda: [C:03+2] "Thanks @ejegg@ejegg.com for implementing this and also talking through it during today's architecture discussion. The changes look good to" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) (owner: 10Ejegg) [22:43:26] (03Merged) 10jenkins-bot: Move some classes to Configuration namespace [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342054 (https://phabricator.wikimedia.org/T291791) (owner: 10Ejegg) [22:46:56] 10fundraising-tech-ops, 06Movement-Insights (FY26-27 H1): Fundraising access request for MKampurath (WMF) - https://phabricator.wikimedia.org/T438095 (10Mayakp.wiki) 03NEW