[01:27:05] (03PS1) 10Eileen: Fix adyen payout files not being moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344412 [02:27:18] (03PS1) 10Eileen: Update gateway names in gateway account to better reflect the ones Finance uses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344413 [02:35:52] (03PS2) 10Eileen: Update gateway names in gateway account to better reflect the ones Finance uses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344413 [02:58:03] (03PS5) 10Eileen: Chariot: add limited queueing support [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) [02:59:08] (03CR) 10Eileen: Chariot: add limited queueing support (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) (owner: 10Eileen) [02:59:38] (03PS6) 10Eileen: Add select options to get the right gateway [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343842 [03:05:07] (03PS1) 10Lars SG: Add Storage Access permission request for Safari & FireFox [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344414 (https://phabricator.wikimedia.org/T437759) [03:06:38] (03PS1) 10Eileen: Stop adding gateway_account info from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344415 [03:07:38] (03PS6) 10Eileen: Chariot: add limited queueing support [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1311308 (https://phabricator.wikimedia.org/T419044) [03:08:42] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-current-sprint, 13Patch-For-Review: Show iframe with donor details in Zendesk - https://phabricator.wikimedia.org/T433866#12357856 (10Lars) @krobinson @EBrill-WMF We have found a small annoyance,... [03:09:53] (03PS2) 10Lars SG: Add Storage Access permission request for Safari & FireFox in authenticated iframe. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344414 (https://phabricator.wikimedia.org/T437759) [03:14:14] (03PS3) 10Eileen: Add api for validating gravy IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1329407 [03:29:49] (03CR) 10CI reject: [V:04-1] Add Storage Access permission request for Safari & FireFox in authenticated iframe. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344414 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG) [03:34:09] (03PS3) 10Lars SG: Add Storage Access permission request for Safari & FireFox [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344414 (https://phabricator.wikimedia.org/T437759) [03:40:12] (03PS1) 10Lars SG: Add by id ordering to import contact get query to make it deterministic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344416 [03:40:37] (03PS2) 10Lars SG: Add by id ordering to import contact get query to make it deterministic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344416 [03:40:47] (03PS3) 10Lars SG: Add by id ordering to import contact get query to make it deterministic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344416 [03:46:48] (03CR) 10Eileen: [C:03+2] Add by id ordering to import contact get query to make it deterministic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344416 (owner: 10Lars SG) [03:47:13] (03CR) 10Cstone: [C:03+2] Add select options to get the right gateway [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343842 (owner: 10Eileen) [03:47:54] (03CR) 10Cstone: [C:03+2] Update gateway names in gateway account to better reflect the ones Finance uses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344413 (owner: 10Eileen) [04:04:40] (03Merged) 10jenkins-bot: Add by id ordering to import contact get query to make it deterministic [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344416 (owner: 10Lars SG) [04:05:48] (03Merged) 10jenkins-bot: Add select options to get the right gateway [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343842 (owner: 10Eileen) [04:14:04] (03Merged) 10jenkins-bot: Update gateway names in gateway account to better reflect the ones Finance uses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344413 (owner: 10Eileen) [04:14:55] (03PS7) 10Eileen: Create settlement batch based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) [04:16:03] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344418 [04:16:40] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344418 (owner: 10Eileen) [04:18:07] !log civicrm upgraded from 11d9e123 to 879c1771 [04:18:09] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [04:33:50] (03CR) 10CI reject: [V:04-1] Create settlement batch based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [04:37:41] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1344449 (owner: 10L10n-bot) [04:43:48] (03CR) 10Cstone: [C:03+2] Fix adyen payout files not being moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344412 (owner: 10Eileen) [04:48:37] (03PS8) 10Eileen: Create settlement batch based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) [04:50:04] (03CR) 10Cstone: [C:03+2] Isolate row and file processing errors instead of aborting the run [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1342543 (owner: 10Eileen) [04:55:22] (03PS9) 10Eileen: Create settlement batch based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) [04:59:31] (03CR) 10Cstone: [C:03+2] Add gateway_account to the general import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343925 (owner: 10Eileen) [05:01:18] (03CR) 10Cstone: [C:03+2] Stop adding gateway_account info from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344415 (owner: 10Eileen) [05:01:55] (03Merged) 10jenkins-bot: Stop adding gateway_account info from Adyen [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344415 (owner: 10Eileen) [05:04:24] (03Merged) 10jenkins-bot: Fix adyen payout files not being moved [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344412 (owner: 10Eileen) [05:08:09] (03Merged) 10jenkins-bot: Isolate row and file processing errors instead of aborting the run [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1342543 (owner: 10Eileen) [05:18:35] (03Merged) 10jenkins-bot: Add gateway_account to the general import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343925 (owner: 10Eileen) [05:19:23] (03PS10) 10Eileen: Create settlement batch based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) [05:20:13] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344529 [05:20:47] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344529 (owner: 10Eileen) [05:22:04] !log civicrm upgraded from 879c1771 to 7545e2c4 [05:22:05] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [05:36:37] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-WMF-Audit, 13Patch-For-Review: Trustly not clearing because backend_processor_trxn_id has gravy ID in it not trustly... - https://phabricator.wikimedia.org/T436050#12357920 (10Eileenmcnaughton) Another one 75YngxRfRKFzMFyOyvsVZk -> 8235354873 (... [05:44:44] (03PS11) 10Eileen: Populate settlement fields based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) [05:49:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [05:50:54] (03PS8) 10Cstone: Add recurring failure activity custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1303013 (https://phabricator.wikimedia.org/T413905) [05:54:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [05:54:24] (03PS9) 10Cstone: Add recurring failure activity custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1303013 (https://phabricator.wikimedia.org/T413905) [05:54:39] (03CR) 10Cstone: Add recurring failure activity custom fields (037 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1303013 (https://phabricator.wikimedia.org/T413905) (owner: 10Cstone) [05:56:20] (03CR) 10Cstone: [C:03+2] Populate settlement fields based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [06:15:38] (03Merged) 10jenkins-bot: Populate settlement fields based on batch import data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343843 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen) [06:37:58] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-current-sprint, 13Patch-For-Review: Show iframe with donor details in Zendesk - https://phabricator.wikimedia.org/T433866#12358249 (10krobinson) Thanks for the heads up, we'll share with the team... [07:31:06] (03CR) 10Nikerabbit: [V:03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_45) - 10https://gerrit.wikimedia.org/r/1344449 (owner: 10L10n-bot) [07:35:59] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344554 (owner: 10L10n-bot) [08:49:22] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344554 (owner: 10L10n-bot) [09:25:59] (03CR) 10Laurabarluzzi: [C:03+2] Add api for validating gravy IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1329407 (owner: 10Eileen) [09:47:20] (03Merged) 10jenkins-bot: Add api for validating gravy IDs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1329407 (owner: 10Eileen) [11:38:49] (03PS1) 10Jgleeson: Refactor: extract ErrorTracker ignore list check to fn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344638 (https://phabricator.wikimedia.org/T438905) [11:38:51] (03PS1) 10Jgleeson: Add recurring_ignore_list to ErrorTracker [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) [11:41:44] (03PS1) 10Jgleeson: Refactor: extract ErrorTracker ignore list check to fn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344638 (https://phabricator.wikimedia.org/T438905) [11:49:46] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: extract ErrorTracker ignore list check to fn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344638 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [11:50:22] (03Merged) 10jenkins-bot: Refactor: extract ErrorTracker ignore list check to fn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344638 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [11:58:50] ty laurabar [12:07:02] (03PS1) 10Jgleeson: Refactor: use getTestableErrorTracker() helper throughout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344650 (https://phabricator.wikimedia.org/T438905) [12:07:41] (03PS3) 10Jgleeson: Add recurring_ignore_list to ErrorTracker [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) [12:21:15] ok I guess it's back to combowiki :D [12:26:40] (03PS3) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [12:43:27] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Cannot create batch import (intermittent) - https://phabricator.wikimedia.org/T412329#12359791 (10BJordan-WMF) Hey @Lars , I didn't create any batches yesterday, but I was unable to import batch that I was working on. I... [12:53:26] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: filter payment method by supported country - https://phabricator.wikimedia.org/T437508#12359881 (10jgleeson) a:03jgleeson [12:56:31] (03CR) 10Laurabarluzzi: Add recurring_ignore_list to ErrorTracker (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [12:57:20] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: filter payment method by supported country - https://phabricator.wikimedia.org/T437508#12359891 (10jgleeson) [13:01:51] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Cannot create batch import (intermittent) - https://phabricator.wikimedia.org/T412329#12359917 (10Lars) Thanks @BJordan-WMF, that sounds like a different issue as this one is specifically about not being able to create a... [13:06:27] (03PS4) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [13:06:57] (03CR) 10CI reject: [V:04-1] WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (owner: 10Damilare Adedoyin) [13:12:18] (03PS5) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [13:21:06] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Tracking donor strategies in Civi - https://phabricator.wikimedia.org/T437526#12360000 (10AKanji-WMF) [13:28:07] (03CR) 10Jgleeson: "Thanks, Laura, for the review. I've replied inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [13:34:45] (03PS4) 10Jgleeson: Add recurring_ignore_list to ErrorTracker [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) [13:34:45] (03PS2) 10Jgleeson: Refactor: use getTestableErrorTracker() helper throughout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344650 (https://phabricator.wikimedia.org/T438905) [13:40:52] (03PS1) 10Ejegg: Add TestKitchen to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1344675 (https://phabricator.wikimedia.org/T438077) [13:42:01] damilare: I think ^^^ should work to make the TestKitchen / CentralNotice patch testable [13:42:22] thanks! [13:42:26] I didn't want to do a full reclone since I have a bunch of changes on my CentralNotice checkout [13:42:35] so I haven't tested the full setup [13:42:50] but I know the tk database setup step works [13:42:54] and gets the UI created [13:43:10] actually, it would be nice to insert a test experiment on setup too [13:53:45] (03PS6) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [14:43:06] (03PS2) 10Ejegg: Skip upsell session backup when no token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1306057 [14:46:03] (03PS2) 10Ejegg: Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 [14:47:38] (03CR) 10CI reject: [V:04-1] Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (owner: 10Ejegg) [14:48:46] (03CR) 10Laurabarluzzi: [C:03+1] "The patch looks good, I think that we should ideally add the `transaction_id` in the log message before merging." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [14:58:50] (03PS5) 10Jgleeson: Add recurring_ignore_list to ErrorTracker [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) [14:58:50] (03PS3) 10Jgleeson: Refactor: use getTestableErrorTracker() helper throughout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344650 (https://phabricator.wikimedia.org/T438905) [15:06:49] (03PS1) 10Jgleeson: Tidyup: Log raw response details for ignore_list Gravy errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344696 (https://phabricator.wikimedia.org/T438905) [15:09:36] (03CR) 10Jgleeson: Add recurring_ignore_list to ErrorTracker (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:09:47] (03PS3) 10Ejegg: Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 [15:10:36] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 4 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12360545 (10Lars) @MDemosWMF @RLewis I think we can simplify this a bit, t... [15:12:26] (03CR) 10CI reject: [V:04-1] Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (owner: 10Ejegg) [15:19:15] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07Epic: Use MediawikiServices for dependency injection throughout DonationInterface - https://phabricator.wikimedia.org/T439146 (10Ejegg) 03NEW [15:20:02] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use MediawikiServices for dependency injection throughout DonationInterface - https://phabricator.wikimedia.org/T439146#12360589 (10Ejegg) [15:22:36] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use dependency injection for gateway configuration and routing - https://phabricator.wikimedia.org/T439147 (10Ejegg) 03NEW [15:32:15] (03PS1) 10Ejegg: Don't use GatewayRouter to set smashpig provider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344708 (https://phabricator.wikimedia.org/T439147) [15:32:54] fr-tech I'd like to refactor a few recent changes to GatewayRouter to make it more focused on just the routing aspect ^^^ [15:33:06] so we can turn it into a service [15:34:00] laurabar: ejegg I was looking at that earlier re:https://phabricator.wikimedia.org/T437508#12359881 [15:34:04] (03CR) 10CI reject: [V:04-1] Don't use GatewayRouter to set smashpig provider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344708 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [15:34:04] (03CR) 10Laurabarluzzi: [C:03+1] "Looks good to merge from my end, but I would rather get another approval since it suppresses a whole category of errors" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:34:24] oops I didn't mean to tag you in that last reply laurabar [15:34:24] It might be nice to have another service to instantiate the gateway classes themselves, but for now I'll just move the instantiation back into ComboWiki [15:34:28] oh cool jgleeson [15:34:40] I like the Service idea [15:34:41] ! [15:34:46] yay! [15:35:12] I was starting to turn GatewayRouter into a service when I saw some functions that looked out of place [15:35:23] so I'm going to do those small refactors, then turn it into a service [15:35:25] we've got a few of those static singleton/registry things and it feels like MW moved over to the Service pattern a while back [15:35:32] yep yep [15:35:35] ^-- all good - I finished my cr for the recur errors suppressions but I'd like someone else to also approve :) [15:35:52] I was looking at the TestKitchen code and saw how many services they had for a much smaller extension [15:36:06] so i'm mostly following the pattern there [15:36:20] :D [15:36:27] thanks laurabar [15:36:34] I just thought the configuration reader would be a good place to start, since there are more and more places we want to read the same set of yaml files [15:36:41] and it would be nice to have a service to cache them [15:36:54] then the router is kind of intertwined with that [15:38:19] here's the patch to make the gateway config service (doesn't actually use it yet anywhere): https://gerrit.wikimedia.org/r/1344403 [15:38:43] (03PS2) 10Ejegg: Don't use GatewayRouter to set smashpig provider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344708 (https://phabricator.wikimedia.org/T439147) [15:42:53] laurabar: check out the conversation here re:ignoring offending categories. The latest patch is an attempt to ignore the noisy ones we "expect" :D and keep the less common ones. https://phabricator.wikimedia.org/T438905#12355440 [15:43:57] You mean ejegg has already approved the approach? [15:44:29] I think so! [15:45:41] laurabar: I'm inclined to defer to jgleeson on the error tracker as he's the one that created it. As long as we can silence unneeded alerts without missing real problems it sounds good to me! [15:45:58] well, and it seems like simpler code than the first draft I banged out [15:47:35] (03CR) 10Laurabarluzzi: [C:03+2] "Let's merge it since the approach was approved in the phab after an exchange of several ideas" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:47:44] I like that wording they're adopting in the banners, and the whole 'urgency based on transparency' approach [15:47:45] Ok I approved it then LOL [15:47:48] :) [15:48:14] (03Merged) 10jenkins-bot: Add recurring_ignore_list to ErrorTracker [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344639 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:48:43] if y'all are about to tag a new version of SmashPig, would you mind taking a look at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/1344121 first? [15:48:58] (03CR) 10Laurabarluzzi: [C:03+2] Refactor: use getTestableErrorTracker() helper throughout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344650 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:49:01] small patch to avoid using bad data from Gr4vy [15:49:11] oh and I'll abandon that first draft [15:49:22] (03Abandoned) 10Ejegg: WIP Error alerts: separate threshold for recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1343989 (owner: 10Ejegg) [15:49:38] (03Merged) 10jenkins-bot: Refactor: use getTestableErrorTracker() helper throughout [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344650 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:49:50] (03CR) 10Laurabarluzzi: [C:03+2] Tidyup: Log raw response details for ignore_list Gravy errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344696 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:50:39] (03Merged) 10jenkins-bot: Tidyup: Log raw response details for ignore_list Gravy errors [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344696 (https://phabricator.wikimedia.org/T438905) (owner: 10Jgleeson) [15:51:41] thanks laurabar ! [15:52:03] looking ejegg [15:53:13] (03PS1) 10Ejegg: Don't use GatewayRouter to instantiate gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344717 (https://phabricator.wikimedia.org/T439147) [15:53:17] (03CR) 10Lars SG: "Sorry for the confusion here, I don't think we want to change the text on these pages (because the donation text doesn't make much sense f" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi) [15:55:34] (03CR) 10Jgleeson: [C:03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344121 (https://phabricator.wikimedia.org/T436050) (owner: 10Ejegg) [15:55:45] thanks jgleeson [15:56:03] (03PS1) 10Ejegg: Don't use GatewayRouter to get enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344719 (https://phabricator.wikimedia.org/T439147) [15:56:21] (03Merged) 10jenkins-bot: Never map Gravy recon ID as backend ID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344121 (https://phabricator.wikimedia.org/T436050) (owner: 10Ejegg) [16:01:16] (03PS1) 10Laurabarluzzi: Reads the language from the request from 'uselang' and not 'language' [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344720 (https://phabricator.wikimedia.org/T437483) [16:04:32] (03PS1) 10Ejegg: WIP send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) [16:06:46] (03CR) 10CI reject: [V:04-1] WIP send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg) [16:13:45] (03Abandoned) 10Ejegg: Send Gift_Data fields to queues as fully qualified names [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1341898 (owner: 10Ejegg) [16:22:25] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Use uselang= for language in the URL - https://phabricator.wikimedia.org/T437483#12360965 (10AnnWF) >>! In T437483#12357126, @Laurabarluzzi wrote: >> sub-ticket could copy over the transla... [16:23:59] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig: Failmail should truncate the error context to at most 30 lines before the error - https://phabricator.wikimedia.org/T438355#12360981 (10AnnWF) a:03AnnWF [16:24:21] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Smashpig: Failmail should truncate the error context to at most 30 lines before the error - https://phabricator.wikimedia.org/T438355#12360982 (10AnnWF) p:05Triage→03Low [16:28:56] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Use uselang= for language in the URL - https://phabricator.wikimedia.org/T437483#12361007 (10Cstone) @Laurabarluzzi yeah I'll edit the task description, I wrote this before those other pha... [16:30:00] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Use uselang= for language in the URL - https://phabricator.wikimedia.org/T437483#12361008 (10Cstone) [16:45:45] (03PS6) 10Laurabarluzzi: Restyle the footer in EmailPreference without the centered gray background box [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) [16:47:49] (03CR) 10Laurabarluzzi: "Gotcha," [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi) [16:58:05] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, and 3 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12361139 (10Lars) @Lars to add a second SK for the contact themselves (ra... [17:04:52] oh darn, payments-wiki tests failing on composer conflict re: JWT lib [17:05:09] that's going to take some finagling [17:05:26] https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-patch/85892/console [17:08:18] oh is that running against MW master? [17:10:08] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 4 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12361161 (10Lars) Notes from discussion today: If we have a MG Engagement... [17:13:15] I don't see any jwt requirement mreged to fundraising/REL1_43 [17:17:53] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Upgrade payments-wiki to REL1_47 - https://phabricator.wikimedia.org/T439155 (10Ejegg) 03NEW [17:22:16] 06Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface, 07payments-orchestration: Update to newer Gr4vy SDK - https://phabricator.wikimedia.org/T439156 (10Ejegg) 03NEW [17:22:43] fr-tech: did someone already look at how gnarly it will be to get off the ancient version of the Gravy php SDK? https://phabricator.wikimedia.org/T439156 [17:22:51] cause we're going to have to do it soon [17:42:19] I took a little peak with the new ACH flow and it seems it might be a couple of changes if we want to go by the SDK approach of making transactions. [17:43:01] but it was only a surface revision, I can take a deeper look once I'm done with this [17:43:20] we might be able to still use our direct to API endpoint approach [18:11:47] (03PS4) 10Ejegg: Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) [18:11:49] (03PS1) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [18:12:00] oh ^^^ will need test updates [18:13:34] (03CR) 10CI reject: [V:04-1] Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:19:28] whew, does it ever need test updates :( [18:25:41] (03PS7) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [18:26:10] (03CR) 10CI reject: [V:04-1] WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (owner: 10Damilare Adedoyin) [18:30:15] (03PS2) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [18:30:30] ejegg: I feel like that SDK bump effort would be a good thing to point Claude at, at least to get an upgrade assessment and highlight any road bumps we may encounter. [18:30:36] ok, the test updates weren't too painful after all [18:30:48] jgleeson: ah yeah, sounds like a good use case [18:33:27] (03CR) 10CI reject: [V:04-1] Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:35:44] I'm gonna try to stick to my (new) earlier finish rule, after 2 months of early nights confirmed it works better than late ones. Catch you all tomorrow o/ [18:41:17] (03PS8) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 [18:43:28] (03PS1) 10Damilare Adedoyin: Add fields for payments through Gravy paybybank connector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344755 [18:45:18] (03PS1) 10Damilare Adedoyin: Add ACH mapping for ACH recurring charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344756 [18:46:02] (03CR) 10CI reject: [V:04-1] Add fields for payments through Gravy paybybank connector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344755 (owner: 10Damilare Adedoyin) [18:55:15] (03CR) 10Wfan: [C:03+2] Don't use GatewayRouter to set smashpig provider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344708 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:55:59] (03CR) 10Wfan: [C:03+2] Don't use GatewayRouter to instantiate gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344717 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:56:23] (03CR) 10Wfan: [C:03+2] Don't use GatewayRouter to get enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344719 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:59:16] (03Merged) 10jenkins-bot: Don't use GatewayRouter to set smashpig provider [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344708 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:59:24] (03Merged) 10jenkins-bot: Don't use GatewayRouter to instantiate gateway [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344717 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [18:59:26] (03Merged) 10jenkins-bot: Don't use GatewayRouter to get enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344719 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [19:02:22] FIRING: [2x] GnmiInterfaceCountersDrop: fasw1-f5a-codfw is exporting less than half the gNMI interface counters it had 24h ago - https://wikitech.wikimedia.org/wiki/Network_monitoring#GnmiInterfaceCountersDrop - https://alerts.wikimedia.org/?q=alertname%3DGnmiInterfaceCountersDrop [19:07:07] thanks wfan ! [19:07:22] RESOLVED: [5x] GnmiInterfaceCountersDrop: fasw1-f5a-codfw is exporting less than half the gNMI interface counters it had 24h ago - https://wikitech.wikimedia.org/wiki/Network_monitoring#GnmiInterfaceCountersDrop - https://alerts.wikimedia.org/?q=alertname%3DGnmiInterfaceCountersDrop [19:07:51] (03CR) 10Laurabarluzzi: [C:03+2] Add ACH mapping for ACH recurring charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344756 (owner: 10Damilare Adedoyin) [19:10:36] (03PS3) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [19:12:14] (03CR) 10CI reject: [V:04-1] Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [19:16:25] (03PS1) 10Ejegg: Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) [19:18:08] (03CR) 10CI reject: [V:04-1] Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [19:19:55] (03PS4) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [19:21:54] (03CR) 10CI reject: [V:04-1] Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [19:22:14] fr-tech I'm going to tag a new version of smashpig [19:22:28] to get that recurring error suppression stuff out [19:26:20] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1344763 [19:26:23] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1344763 (owner: 10Ejegg) [19:26:52] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/1344763 (owner: 10Ejegg) [19:27:11] (03Merged) 10jenkins-bot: Add ACH mapping for ACH recurring charge [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344756 (owner: 10Damilare Adedoyin) [19:29:46] (03PS5) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [19:31:39] (03CR) 10CI reject: [V:04-1] Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [19:33:29] (03PS6) 10Ejegg: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) [19:35:16] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167 (10Lars) 03NEW [19:39:37] !log standalone (ipn listener) SmashPig upgraded from cbbb2d54 to 31c021ba [19:39:39] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:40:28] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12361637 (10Lars) a:03Lars [19:42:32] (03PS1) 10Ejegg: Update SmashPig and a couple other packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344766 [19:42:34] (03CR) 10Ejegg: [C:03+2] Update SmashPig and a couple other packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344766 (owner: 10Ejegg) [19:45:35] (03PS1) 10Ejegg: Update SmashPig to 1.2.6 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1344768 [19:46:21] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344769 [19:46:35] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344769 (owner: 10Ejegg) [19:56:27] (03Merged) 10jenkins-bot: Update SmashPig and a couple other packages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344766 (owner: 10Ejegg) [20:22:12] (03PS2) 10Ejegg: Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) [20:22:12] (03PS1) 10Ejegg: Use config service in adapter and PaymentSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344778 (https://phabricator.wikimedia.org/T439147) [20:23:08] (03CR) 10Ejegg: [C:03+2] Update SmashPig to 1.2.6 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1344768 (owner: 10Ejegg) [20:24:17] (03CR) 10CI reject: [V:04-1] Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [20:24:23] (03CR) 10CI reject: [V:04-1] Use config service in adapter and PaymentSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344778 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [20:25:14] (03PS1) 10Ejegg: Update SmashPig to 1.2.6 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344779 [20:25:26] (03CR) 10Ejegg: [C:03+2] Update SmashPig to 1.2.6 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344779 (owner: 10Ejegg) [20:26:00] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1344780 [20:26:02] (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1344780 (owner: 10Ejegg) [20:26:45] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12361820 (10Lars) @MDemosWMF @Elbar53 Check the contribution (note there are two payments, even though there should only be one)... [20:27:20] (03Merged) 10jenkins-bot: Update SmashPig to 1.2.6 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344779 (owner: 10Ejegg) [20:27:21] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1344780 (owner: 10Ejegg) [20:42:30] (03Merged) 10jenkins-bot: Update SmashPig to 1.2.6 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1344768 (owner: 10Ejegg) [20:42:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1344769 (owner: 10Ejegg) [20:43:07] (03PS1) 10Damilare Adedoyin: Remove console statement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344782 [20:45:38] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12361876 (10MDemosWMF) @Lars From what I recall this had been mapped this way because when you select Money Order as a payment m... [20:46:18] !log fundraising civicrm upgraded from 7545e2c4 to 51e3f920 [20:46:20] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [20:51:05] (03PS1) 10Ejegg: Update composer.lock for library upgrades [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1344792 [20:54:08] (03PS3) 10Ejegg: Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) [20:56:46] (03PS2) 10Ejegg: Use config service in adapter and PaymentSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344778 (https://phabricator.wikimedia.org/T439147) [20:56:46] (03PS1) 10Ejegg: Convert AmountHelper to service, rename [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344793 (https://phabricator.wikimedia.org/T439147) [21:16:44] oh dang, I need to make one more change to smashPig to get the backend processor on failed txns for the auth rate thign [21:16:55] should have waited to tag that release [21:17:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12361966 (10Lars) @MDemosWMF You're right, check number is a very annoying field. A few options: 1) Maybe we don't need the mo... [21:17:45] (03PS2) 10Ejegg: Update composer.lock for library upgrades [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1344792 [21:17:47] (03CR) 10Ejegg: [C:03+2] Update composer.lock for library upgrades [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1344792 (owner: 10Ejegg) [21:20:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12361985 (10MDemosWMF) @Lars My ideal is #3 since we actually ran into this with DAFpay gifts (https://phabricator.wikimedia.org... [21:24:18] (03Merged) 10jenkins-bot: Update composer.lock for library upgrades [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1344792 (owner: 10Ejegg) [21:31:24] (03PS1) 10Lars SG: Convert Manages DAF relationships from an Individual to Owns the DAF [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) [21:34:08] !log payments-wiki upgraded from 375adf37 to 49e656bc [21:34:09] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [21:58:08] that's looking OK so far [21:58:15] gonna make some dinner [22:03:18] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12362109 (10Lars) @MDemosWMF I think Eileen's proposed solution is better and I commented on the core lab issue. [22:04:37] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Adding check number field to DAFpay payment method - https://phabricator.wikimedia.org/T429835#12362117 (10Lars) When we do this, we should also add Check Number to Money Orders and stop importing... [22:05:23] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Imported contact being merged to Anonymous (72) - https://phabricator.wikimedia.org/T439167#12362119 (10Lars) I'm going to call this done because we'll tackle the fix in the other phab. I added a note to the other phab t... [22:50:16] (03CR) 10Wfan: [C:03+1] "looks good overall, consider adding standard parameter type hints to createForGateway" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [22:51:43] (03CR) 10Wfan: [C:03+2] Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [23:17:41] (03PS4) 10Cstone: UI: ComboWiki redesign - FR design system tokens, header, 2-column layout, intro text [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1321592 (owner: 10Ramon Lopez) [23:18:40] (03CR) 10Cstone: [C:03+2] "thanks for all the work here Ramon!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1321592 (owner: 10Ramon Lopez) [23:20:26] (03Merged) 10jenkins-bot: UI: ComboWiki redesign - FR design system tokens, header, 2-column layout, intro text [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1321592 (owner: 10Ramon Lopez) [23:34:29] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 4 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12362239 (10Lars) I went ahead and created MGGONN appeal codes out to 2036... [23:47:45] (03PS2) 10Mstyles: CentralNotice: Require reauth to enable campaigns [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1329340 (https://phabricator.wikimedia.org/T208278) [23:50:02] (03CR) 10Mstyles: "I went ahead and removed the tool tip as that was not easy to put behind a feature flag and that was optional anyways. I did set reauthent" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1329340 (https://phabricator.wikimedia.org/T208278) (owner: 10Mstyles)