[00:19:18] <wikibugs>	 (03PS13) 10Lars SG: Add gift coding for White Mail donations and those expected by MG Engagement activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031)
[00:19:18] <wikibugs>	 (03PS5) 10Lars SG: Add appeal code to DAF donations based on emails received [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343180 (https://phabricator.wikimedia.org/T434201)
[00:19:18] <wikibugs>	 (03PS2) 10Lars SG: Add change reason data when appeal is being set for white mail or empty appeals [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1343626 (https://phabricator.wikimedia.org/T386031)
[00:19:19] <wikibugs>	 (03PS1) 10Lars SG: Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031)
[00:19:21] <wikibugs>	 (03PS1) 10Lars SG: Convert Contribution pre hook to listener and getter/setters for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344827 (https://phabricator.wikimedia.org/T386031)
[00:33:15] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[00:38:48] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Convert Contribution pre hook to listener and getter/setters for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344827 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[01:07:43] <wikibugs>	 (03PS1) 10Cstone: Create a new frequecyOptions to hold all the variants on the words for one-time,monthly, and anuual/yearly Change the text to match the mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344828
[01:08:40] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Internal QA - https://phabricator.wikimedia.org/T439191 (10Cstone) 03NEW
[01:08:54] <wikibugs>	 (03PS2) 10Cstone: Create a new frequecyOptions to hold all the variants on the words for one-time,monthly, and anuual/yearly Change the text to match the mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344828 (https://phabricator.wikimedia.org/T439191)
[01:10:35] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Create a new frequecyOptions to hold all the variants on the words for one-time,monthly, and anuual/yearly Change the text to match the mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344828 (https://phabricator.wikimedia.org/T439191) (owner: 10Cstone)
[01:12:22] <wikibugs>	 (03CR) 10Ejegg: "Thanks for the review, wfan. Answers inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[01:12:38] <wikibugs>	 (03CR) 10Ejegg: Wire up a service to get gateway configurations (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[01:17:23] <wikibugs>	 (03PS2) 10Lars SG: Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031)
[01:17:23] <wikibugs>	 (03PS2) 10Lars SG: Convert Contribution pre hook to listener and getter/setters for custom fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344827 (https://phabricator.wikimedia.org/T386031)
[01:26:19] <wikibugs>	 (03PS1) 10Ejegg: Gravy mapper: add more details to failed calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344830 (https://phabricator.wikimedia.org/T419610)
[01:32:31] <ejegg>	 ah needs the decorateResponse too
[01:49:20] <wikibugs>	 (03PS2) 10Ejegg: Gravy mapper: add more details to failed calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344830 (https://phabricator.wikimedia.org/T419610)
[01:53:54] <ejegg>	 huh, still not populating the gateway_txn_id
[01:59:33] <wikibugs>	 (03PS3) 10Ejegg: Gravy mapper: add more details to failed calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344830 (https://phabricator.wikimedia.org/T419610)
[02:02:38] <wikibugs>	 (03PS2) 10Ejegg: Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610)
[02:04:41] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[02:09:55] <wikibugs>	 (03PS1) 10Ejegg: Add auth rate columns to payment attempts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344836 (https://phabricator.wikimedia.org/T419610)
[02:10:51] <wikibugs>	 (03PS3) 10Ejegg: Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610)
[03:12:36] <wikibugs>	 (03PS3) 10Cstone: Create a new frequecyOptions to hold all the variants on the words for one-time,monthly, and anuual/yearly Change the text to match the mockup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344828 (https://phabricator.wikimedia.org/T439191)
[03:43:40] <wikibugs>	 (03PS1) 10Cstone: Switch hardcoded text to messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344839 (https://phabricator.wikimedia.org/T439191)
[04:37:18] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_46) - 10https://gerrit.wikimedia.org/r/1344872 (owner: 10L10n-bot)
[08:45:25] <wikibugs>	 (03PS7) 10Laurabarluzzi: Remove applePayHelper.js legacy dependencies in ComboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143)
[08:47:02] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Remove applePayHelper.js legacy dependencies in ComboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[09:43:14] <wikibugs>	 (03CR) 10Damilare Adedoyin: "hi @lbarluzzi@wikimedia.org, thanks for all the work on this patch. Looks good so far, I added some comments as currently the ApplePay fun" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[11:56:51] <wikibugs>	 (03CR) 10Jgleeson: "Thanks, ejegg. I noticed something potentially unexpected in how we handle the Donor_BKUP session key. It might not be blocking, but it so" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1306057 (owner: 10Ejegg)
[11:57:12] <wikibugs>	 (03PS2) 10Majavah: Batch campaign mixin lookup [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239)
[11:57:58] <wikibugs>	 (03CR) 10Majavah: "This is untested." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah)
[12:17:55] <wikibugs>	 (03CR) 10Jgleeson: "I just saw this today. Nice!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1321592 (owner: 10Ramon Lopez)
[12:47:17] <wikibugs>	 (03PS1) 10Damilare Adedoyin: Add test coverage for the new error mapping into payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1345094
[12:48:27] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks ejegg, LGTM. I also added a follow on patch to add test coverage on the added bits." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344830 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[12:48:55] <wikibugs>	 (03Merged) 10jenkins-bot: Gravy mapper: add more details to failed calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344830 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[13:20:18] <ejegg|away>	 thanks for the CR and the tests, Dami!
[13:33:06] <wikibugs>	 (03Abandoned) 10Ejegg: Helper fn to check for base 62 UUID [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344107 (owner: 10Ejegg)
[13:33:21] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Add test coverage for the new error mapping into payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1345094 (owner: 10Damilare Adedoyin)
[13:34:01] <wikibugs>	 (03Merged) 10jenkins-bot: Add test coverage for the new error mapping into payment response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1345094 (owner: 10Damilare Adedoyin)
[13:34:46] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "Thanks for the coverage! The specifics of setting null vs not adding the keys might change later, but it's definitely good to make sure th" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1345094 (owner: 10Damilare Adedoyin)
[13:35:08] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Remove console statement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344782
[13:35:10] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Remove console statement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344782 (owner: 10Damilare Adedoyin)
[13:37:22] <wikibugs>	 (03Merged) 10jenkins-bot: Remove console statement [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344782 (owner: 10Damilare Adedoyin)
[13:37:45] <wikibugs>	 (03PS1) 10Jgleeson: WIP: Decide the ComboWiki country once, on the server [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508)
[13:41:03] <wikibugs>	 (03PS2) 10Jgleeson: WIP: Decide the ComboWiki country once, on the server [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508)
[13:41:48] <jgleeson>	 huh, I thought you could use backticks in commits too
[13:41:53] <jgleeson>	 clearly not
[13:42:08] <ejegg>	 jgleeson: that code looks good at first sight, but I wonder if we should be showing a 'select your country' prompt for the small number of ppl who get mislocated rather than assuming US
[13:42:37] <jgleeson>	 ah like we do today
[13:42:40] <ejegg>	 i dunno which blocks of IPs get coded as 'EU' for instance, but I'd bet they're in Europe
[13:42:52] <ejegg>	 Ah, do we do that on donatewiki?
[13:42:55] <ejegg>	 I wasn't sure
[13:43:13] <jgleeson>	 there's one edge case where we ask them to select currency 
[13:43:20] <jgleeson>	 maybe also country
[13:43:25] <jgleeson>	 I forget tbh
[13:44:07] <ejegg>	 any country selection prompt would probs be on donatewiki anyway - pcoombe could probably tell us quicker than we could find it in the templates
[13:45:17] <ejegg>	 hmm, would that be a big code change for combowiki though, since several things depend on country?
[13:45:19] <jgleeson>	 no, I'm not sure about donate-wiki
[13:45:27] <jgleeson>	 I was thinking of payments
[13:45:33] <ejegg>	 I guess we could do a full page refresh for that specific use case
[13:45:55] <ejegg>	 lemme see if there's even a country selector in the forms
[13:46:30] <ejegg>	 I feel like we assume it is already picked on the 2nd stage forms since they need to know it for field and method selection
[13:47:11] <jgleeson>	 it might just be currency
[13:47:13] <ejegg>	 right, looks like Mustache.php just assumes 'country' is there in the data block
[13:47:20] <jgleeson>	 I triggered that drop down just now
[13:47:22] <ejegg>	 yeah, i do see the currency selector
[13:48:49] <pcoombe>	 we do have a country selector on donatewiki. it just does a full page refresh with the new country parameter
[13:49:04] <laurabar>	 jgleeson: if you have a vague memory of payments showing sometimes a currency dropdown I wonder if it would happen when we get a country + currency unsupported ?
[13:49:35] <pcoombe>	 we show it as an option at the top of the form for anyone (in case they got mislocated), and more prominently for cases where geolocation fails https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=XX
[13:49:42] <jgleeson>	 laura you can trigger it by removing currency and clearing session
[13:49:49] <ejegg>	 thanks pcoombe
[13:50:10] <ejegg>	 oh yeah, not much form to display at all till the country is known
[13:50:16] <jgleeson>	 right
[13:50:25] <pcoombe>	 also a bit late but hi jgleeson, welcome back!
[13:50:31] <jgleeson>	 thank you!
[13:50:41] <ejegg>	 oh i see, the country picker on the combowiki form has the currency code right in it too
[13:51:31] <jgleeson>	 yeah I'm not sure about how we decided to merge those
[13:51:33] <ejegg>	 Hmm, but I imagine some people who want to donate in USD are going to pick US and then enter a non-US address
[13:51:56] <ejegg>	 Oh, and we still have to handle PayPal in USD for non-US countries
[13:52:03] <ejegg>	 We might need to rethink that merge
[13:52:10] <jgleeson>	 I think it was in ramon's original designs https://www.figma.com/proto/q4VkurJPwWutmbduQIAvFl/Combo-Wiki?node-id=464-7861&t=eyi5A9P2ACcJHbn8-1&scaling=contain&content-scaling=responsive&page-id=318%3A2180&starting-point-node-id=318%3A2181
[13:52:11] <laurabar>	 jgleeson: they are not merged. It is the same (a country selector) but simply designers I guess chose to be explicit with the currency that is going to be applied (as it does in donate already)
[13:52:26] <ejegg>	 I'll add a phab to handle fallback currency in ComboWiki
[13:52:35] <jgleeson>	 thanks!
[13:52:43] <ejegg>	 and I guess we'll ask for design input on how to show that
[13:54:06] <laurabar>	 To be clear, we did not change the logic ; the dropdown selects the country but de factor has always automatically also the country's default currency. I think the UI was changed to make it explicit. 
[13:55:21] <laurabar>	 ejegg: can you confirm you 'broke' in combowiki somehow if the country and the currency are forced by the URL and not supported in any gateway?
[13:55:43] <jgleeson>	 yeah, I can see DonateWiki does that. I guess in payments, we always treat them as separate.
[13:56:31] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Handle fallback currency in ComboWiki - https://phabricator.wikimedia.org/T439255 (10Ejegg) 03NEW
[13:56:42] <laurabar>	 Yes but from donate wiki the country+currency is set from the default currency of a country, should never lead to a broken country=X&currency=Y unsupported. The issue of these two potentially not matching is probably stemming from links from sources like emails
[13:57:02] <ejegg>	 hmm, if I choose 'Colombia' in donatewiki it has the option 'PayPal (USD)'
[13:57:18] <ejegg>	 though since you select the amount first, you are always choosing the amount in COP
[13:58:23] <ejegg>	 so if I select an amount in COP then select the PayPal (USD) option, it brings me to a form that says 'Your currency was unsupported. Processing will take place in USD if you decide to continue.'
[13:58:39] <ejegg>	 and then I can submit the form with a 'Continue' button
[13:58:51] <jgleeson>	 school run time. back later. 
[13:58:57] <ejegg>	 it does show the converted USD amount
[13:59:26] <ejegg>	 so I guess it is a bit easier for donors to decide the amount in their native currency first rather than showing them USD amounts
[13:59:50] <ejegg>	 Perhaps we just have a nicer-looking UI for that same 'unsupported' message
[14:01:04] <ejegg>	 anyone having issues logging in / staying logged in to Civi lately?
[14:01:30] <laurabar>	 ^-- that is a good find but I wonder if we no longer need to care? PayPal I think is currently supporting all currencies actually (the backend doesn't even apply a currency filter for the legacy paypal). I think going through gravy we accept all currencies we do support now.
[14:01:32] <ejegg>	 i def seem to have to log in again every day now
[14:02:02] <ejegg>	 laurabar: oh really?
[14:02:20] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: Adjust mailcheck on donation form to remove friction for @pm.me addresses - https://phabricator.wikimedia.org/T439256 (10MBeat33) 03NEW
[14:02:27] <ejegg>	 I thought there was some limitation on our account or something
[14:02:34] <laurabar>	 I think so but I cannot confirm 100% 
[14:03:00] <laurabar>	 The code has not list of currency support, but maybe it is because there is a hidden "conversion to USD" rule that I wasn't aware of
[14:05:01] <wikibugs>	 (03PS1) 10Ejegg: Add pm.me to list of default domains for mailcheck [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345132 (https://phabricator.wikimedia.org/T439256)
[14:05:13] <ejegg>	 trivial fix for that thing mbeat just filed ^^^
[14:05:24] <ejegg>	 also, do we have a phab for mailcheck in ComboWiki yet?
[14:14:22] <wikibugs>	 (03CR) 10Damilare Adedoyin: "Thanks for this, tested and code LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[14:16:42] <ejegg>	 thanks Dami!
[14:16:52] <damilare>	 np!
[14:17:55] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Add auth rate columns to payment attempts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344836 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[14:18:03] <ejegg>	 I'll pull the SmashPig update into payments and click around a lot to make sure there are no other unintended results of having those new properties set on failed txns
[14:18:41] <ejegg>	 Just reminded myself how to simulate all the failure scenarios: https://docs.adyen.com/development-resources/testing/result-codes
[14:18:56] <ejegg>	 It looks like you can put the codes in just the first_name box and it works to trigger
[14:19:47] <ejegg>	 also I'll try applying the schema updates to the ML side and CRM side of the payment attempts table to give it a real smoke test
[14:26:17] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 13Patch-For-Review: Adjust mailcheck on donation form to remove friction for @pm.me addresses - https://phabricator.wikimedia.org/T439256#12364360 (10Ejegg)
[14:26:39] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 06FR-donorrelations, 13Patch-For-Review: Adjust mailcheck on donation form to remove friction for @pm.me addresses - https://phabricator.wikimedia.org/T439256#12364361 (10Ejegg) a:03Ejegg
[14:29:29] <damilare>	 ohh yh ejegg I stepped through a failure transaction with the smashpig checked out and it went through the expected path. 
[14:29:34] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Use MediawikiServices for dependency injection throughout DonationInterface - https://phabricator.wikimedia.org/T439146#12364367 (10Ejegg)
[14:29:41] <ejegg>	 oh nice damilare 
[14:29:44] <damilare>	 I useed the CARD_EXPIRED donor first name failure
[14:31:31] <wikibugs>	 (03Merged) 10jenkins-bot: Add auth rate columns to payment attempts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344836 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[14:31:33] <ejegg>	 I notice it newly logs a 'Returned Authorization ID' message which feels a little misleading if the auth is failed
[14:31:43] <ejegg>	 So I might update that text a bit
[14:36:12] <ejegg>	 oh hah i thought the ComboWiki form was broken for ARS but it's just that the default amounts are all way below the minimum
[14:36:27] <ejegg>	 I guess we probs have a ticket to display validation errors?
[14:38:05] <laurabar>	 ^-- re errors Christine had some thoughts but I think user validation errors should be displayed (aka errors that can be fixed with user action)
[14:38:19] <laurabar>	 And should ideally be self-explanatory to not cause zd tickets
[14:38:51] <ejegg>	 yep, preferrably right by the relevant form field
[14:39:02] <ejegg>	 hopefully we can reuse all the same error messages
[14:39:37] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support 'mailcheck' in combowiki - https://phabricator.wikimedia.org/T439258 (10Ejegg) 03NEW
[14:40:38] <ejegg>	 we have some code that exports rules for e.g. donation min/max as JSON to use in client-side validation
[14:40:47] <ejegg>	 that part should be reusable for combowiki
[14:41:21] <laurabar>	 Yeah, indeed damilare as you reviewed my patch I'm looking into introducing this concept but I wonder if I should not introduce it in my patch about dependencies removal? I think it requires a broader scope than apple pay modules etc.
[14:42:16] <ejegg>	 laurabar: your dependencies removal is great! sorry, i just meant the server-side bit that generates the JSON
[14:42:37] <laurabar>	 ejegg: could you create a phab for user validation errors and all the context you have and your idea of an ideal solution in the fr-combowiki project?
[14:42:38] <ejegg>	 We definitely should have a new vue-native bit for applying those rules client-side in combowiki
[14:42:52] <ejegg>	 not use the old jquery-based validation code
[14:43:13] <ejegg>	 sure, I will write that up today
[14:43:30] <laurabar>	 ejegg: I mean Dami did a code-review and asked if I could change the error message handling to be shown to users - I'm wondering if to move that out to a dedicated follow-up task:https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1342784
[14:44:02] <ejegg>	 oh i see
[14:44:07] <damilare>	 moving it out as a follow sounds good to me laurabar 
[14:45:51] <laurabar>	 👌
[14:46:07] <ejegg>	 oh weird, when I choose a different country / currency on the form it very briefly shows an array of appropriate amounts before reloading the page
[14:46:19] <ejegg>	 then when the page is reloaded it has the amount array from USD
[14:46:30] <ejegg>	 which aren't appropriate for a lot of currencies
[14:46:35] <ejegg>	 I wonder where that's coming from 
[14:46:50] <ejegg>	 Lemme dive into that Vue code
[14:46:56] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Add pm.me to list of default domains for mailcheck [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345132 (https://phabricator.wikimedia.org/T439256) (owner: 10Ejegg)
[14:47:04] <ejegg>	 thanks damilare 
[14:47:13] <damilare>	  np!
[14:49:45] <wikibugs>	 (03Merged) 10jenkins-bot: Add pm.me to list of default domains for mailcheck [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345132 (https://phabricator.wikimedia.org/T439256) (owner: 10Ejegg)
[14:49:49] <wikibugs>	 (03Abandoned) 10Damilare Adedoyin: WIP: Add adyen card auto rescue [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1333216 (https://phabricator.wikimedia.org/T378630) (owner: 10Damilare Adedoyin)
[14:50:16] <ejegg>	 oh hmm, mailcheck is jquery-specific
[14:50:27] <ejegg>	 at least v1.1.1 is
[14:50:34] <ejegg>	 i wonder if there's a newer non-jquery version
[14:51:52] <ejegg>	 nope, but you can at least use it without jquery by running Mailcheck.run directly
[14:52:25] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support 'mailcheck' in combowiki - https://phabricator.wikimedia.org/T439258#12364470 (10Ejegg)
[14:52:30] <wikibugs>	 (03PS2) 10Damilare Adedoyin: Add fields for payments through Gravy paybybank connector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344755
[14:53:52] <ejegg>	 hmm damilare I wonder if that old field 'bank_code' was supposed to be for the routing number?
[14:54:48] <ejegg>	 let me re-read that slack thread for context on why we need a new state_code
[14:54:57] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add fields for payments through Gravy paybybank connector [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344755 (owner: 10Damilare Adedoyin)
[14:56:07] <ejegg>	 ah i see, it needs to be country/state concatenated
[14:56:18] <ejegg>	 let's see, can we just do that in a staging helper?
[14:56:37] <damilare>	 ahh makes re:bank_code the qqq.json on a related field called it sort code but looks like for US it may be termed Routing number
[14:58:04] <ejegg>	 damilare: oh, actually, wouldn't we be able to build that state_code down at the SmashPig layer, just for communication with the Gravy API?
[14:58:37] <ejegg>	 and just send the usual state_province + country fields into the createPayment call?
[14:59:08] <damilare>	 ahh that makes sense since we are already mapping similar fields down there
[14:59:09] <ejegg>	 oh or is it something we read from their JS SDK?
[14:59:29] <damilare>	 no it isn't
[14:59:53] <ejegg>	 nice, it would be preferable to keep the createPayment interface less messy
[15:00:06] <ejegg>	 'interface'
[15:00:10] <ejegg>	 lol
[15:00:12] <ejegg>	 i mean, we try
[15:00:31] <ejegg>	 but i guess it's always going to need a free-form array of params
[15:00:49] <damilare>	 tbh I was trying different combinations from the FE to see which worked. I'd tidy that up and move it out to the request mapper
[15:08:12] <ejegg>	 thanks!
[15:26:04] <ejegg>	 hah, did a full composer update yesterday and there's already a new twig minor version update
[15:26:29] <jgleeson>	 trunk.branch.leaf
[15:27:35] * ejegg realizes the silliness of saying that as he tags yet another SmashPig version a day after the previous
[15:32:42] <wikibugs>	 (03PS1) 10Ejegg: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345156
[15:32:44] <ejegg>	 thanks for reviewing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1344724 damilare! Did you want to give it a C+2 ?
[15:33:02] <ejegg>	 I can rebase it over ^^^ so it's in the right order 
[15:33:29] <damilare>	 sure
[15:33:51] <damilare>	 should it be on the mast branch or some other commit?
[15:33:54] <wikibugs>	 (03PS4) 10Ejegg: Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610)
[15:34:16] <damilare>	 ahh cool
[15:34:23] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[15:34:32] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345156 (owner: 10Ejegg)
[15:35:26] <ejegg>	 Huh, I notice git-review isn't sending a topic to gerrit - it used to use the local branch name as the topic
[15:36:15] <ejegg>	 oh i see, it's a new default as of 2.4.0
[15:36:37] <wikibugs>	 (03Merged) 10jenkins-bot: Update SmashPig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345156 (owner: 10Ejegg)
[15:36:39] <wikibugs>	 (03Merged) 10jenkins-bot: Send more info to payment_attempts table [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344724 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[15:36:43] <ejegg>	 https://manpages.ubuntu.com/manpages/trusty/man1/git-review.1.html says to add track=1 to the [gerrit] section
[15:37:14] <ejegg>	 bahhh
[15:37:31] <ejegg>	 shows what i get for trusting gemini's footnotes
[15:37:45] <ejegg>	 anyway, the AI says that's what to do and attributes that page
[15:38:01] <ejegg>	 (which contains no trace of 'track')
[15:39:03] <ejegg>	 oh look who's on the credits for maintaining that manpage! None other than hashar. Cool to work with such folks.
[15:49:02] <ejegg>	 dang, I can't load civicrm locally
[15:49:11] <ejegg>	 DB Error: unknown error
[15:49:27] <ejegg>	 somethign in the standalone auth code?
[15:49:46] <ejegg>	 and it's not letting me run the db update :(
[15:50:18] <damilare>	 looks like the error I had with the stale triggers, might be unrelated though
[15:50:32] <ejegg>	 seems to be trying to select all the auth info from a table with no name
[15:50:45] <ejegg>	   FROM `` a
[15:50:45] <ejegg>	   WHERE (`a`.`username` = "admin")
[15:59:22] <wikibugs>	 (03PS9) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370
[15:59:54] <wikibugs>	 (03CR) 10CI reject: [V:04-1] WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (owner: 10Damilare Adedoyin)
[16:00:09] <wikibugs>	 (03CR) 10Wfan: [C:03+2] Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[16:00:15] <wikibugs>	 (03PS10) 10Damilare Adedoyin: WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370
[16:00:47] <wikibugs>	 (03CR) 10CI reject: [V:04-1] WIP: For paybybank connection [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1344370 (owner: 10Damilare Adedoyin)
[16:02:08] <wikibugs>	 (03Merged) 10jenkins-bot: Wire up a service to get gateway configurations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344403 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[16:04:23] <wikibugs>	 (03CR) 10Wfan: [V:03+2 C:03+2] Add TestKitchen to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1344675 (https://phabricator.wikimedia.org/T438077) (owner: 10Ejegg)
[16:06:07] <wikibugs>	 (03PS3) 10Jgleeson: WIP: Decide the ComboWiki country once, on the server [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508)
[16:19:30] <ejegg>	 thanks for the review wenjun!
[16:25:57] <wikibugs>	 (03PS4) 10Jgleeson: WIP: Decide the ComboWiki country once, on the server [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508)
[16:26:02] <wikibugs>	 (03CR) 10Wfan: [C:03+2] Switch hardcoded text to messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344839 (https://phabricator.wikimedia.org/T439191) (owner: 10Cstone)
[16:28:27] <wikibugs>	 (03Merged) 10jenkins-bot: Switch hardcoded text to messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344839 (https://phabricator.wikimedia.org/T439191) (owner: 10Cstone)
[17:40:44] <ejegg>	 right, so can I fix my local civi?
[17:40:59] <ejegg>	 stack trace involves  CRM_Utils_System_Standalone->getUfId()
[17:42:08] <ejegg>	 annnnnd it mysteriously works again
[17:42:12] <ejegg>	 caching-related???
[17:54:03] <wikibugs>	 (03PS2) 10Ejegg: Convert Manages DAF relationships from an Individual to Owns the DAF [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[17:54:44] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "Looks good to me! Looks like fewer than 100 updates to make." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[17:55:15] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Convert Manages DAF relationships from an Individual to Owns the DAF [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[18:04:30] <ejegg>	 oh oops, bad rebase
[18:05:43] <wikibugs>	 (03PS3) 10Ejegg: Convert Manages DAF relationships from an Individual to Owns the DAF [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[18:06:26] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "PS3: fix bad rebase from PS2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[18:09:07] <ejegg>	 ok, i see why those amounts are bad after changing the country
[18:09:16] <ejegg>	 we reload with the new country, but no currency on the URL
[18:09:28] <ejegg>	 then the currency in routingParams defaults to USD
[18:11:13] <ejegg>	 so how is the formatter getting the right currency later?
[18:22:38] <ejegg>	 ohhhh it's not the wrong currency, it's just that the rates aren't set!
[18:22:47] <ejegg>	 oh i've got to go to a school thing
[18:26:16] <wikibugs>	 (03Merged) 10jenkins-bot: Convert Manages DAF relationships from an Individual to Owns the DAF [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344798 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[19:04:43] <wikibugs>	 06Fundraising-Backlog: Handle gravy ACH moto webhooks - https://phabricator.wikimedia.org/T439276 (10Cstone) 03NEW
[19:04:59] <wikibugs>	 06Fundraising-Backlog: Handle gravy ACH moto webhooks - https://phabricator.wikimedia.org/T439276#12365278 (10Cstone)
[19:05:04] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Engage <> Gr4vy for Direct Mail CC and ACH (moto) - https://phabricator.wikimedia.org/T417842#12365277 (10Cstone)
[20:58:46] <wikibugs>	 (03PS1) 10Ejegg: Make comboWiki depend directly on currency rates module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345217
[21:04:35] <wikibugs>	 (03PS3) 10Lars SG: Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031)
[21:04:36] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[21:12:32] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Clean up mw.config access in ComboWiki - https://phabricator.wikimedia.org/T439282 (10Ejegg) 03NEW
[21:15:06] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Adding check number field to DAFpay payment method - https://phabricator.wikimedia.org/T429835#12365543 (10MDemosWMF) Thanks @Lars + @Eileenmcnaughton please keep us updated!
[21:27:28] <wikibugs>	 (03Merged) 10jenkins-bot: Convert ContributionSoft pre hook to listener [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344826 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG)
[21:31:45] <wikibugs>	 (03PS1) 10Wfan: Fix the style for forbidden countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345225 (https://phabricator.wikimedia.org/T439284)
[21:32:33] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 07fr-combowiki, 13Patch-For-Review: fix the forbidden country view after new css - https://phabricator.wikimedia.org/T439284#12365622 (10AnnWF)
[21:33:23] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Fix the style for forbidden countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345225 (https://phabricator.wikimedia.org/T439284) (owner: 10Wfan)
[21:34:42] <wikibugs>	 (03PS2) 10Wfan: Fix the style for forbidden countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345225 (https://phabricator.wikimedia.org/T439284)
[21:53:45] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286 (10Ejegg) 03NEW
[22:02:54] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Handle message replacements in Combowiki variants - https://phabricator.wikimedia.org/T439287 (10Ejegg) 03NEW
[22:09:21] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Read combowiki variant mapping dynamically from settings - https://phabricator.wikimedia.org/T439288 (10Ejegg) 03NEW
[22:10:26] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] "Looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345225 (https://phabricator.wikimedia.org/T439284) (owner: 10Wfan)
[22:12:27] <wikibugs>	 (03Merged) 10jenkins-bot: Fix the style for forbidden countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345225 (https://phabricator.wikimedia.org/T439284) (owner: 10Wfan)
[22:30:03] <wikibugs>	 (03PS5) 10Dmiranda: Update donation fee message and functionality [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344979 (https://phabricator.wikimedia.org/T438805)
[23:03:01] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Add more pay the fee functionality - https://phabricator.wikimedia.org/T438805#12365878 (10dmiranda) Hi @Cstone! The patch for this ticket is ready for review and can be found here: https:...