[00:24:28] (03PS4) 10Ejegg: Create a new frequecyOptions [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344828 (https://phabricator.wikimedia.org/T439191) (owner: 10Cstone) [00:24:47] (03PS2) 10Ejegg: Make comboWiki depend directly on currency rates module [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345217 [00:25:26] oh oops i didn't mean to rebase yours on mine cstone [00:25:46] but since it is... want to C+1 that tiny patch to make the amounts work again? ^^^ [00:25:51] or even C+2 ? [00:28:59] hmm, which part is responsable for mapping from once / monthly / annual to recurring = 0/1 , frequency_unit=year/month ? [00:30:20] oh i see, it's in getBaseDonateParams [00:30:46] I wonder if we can make that whole bit a little simpler [00:31:15] O dpm [00:31:59] Seems error-prone to have to map from one set of parameter names to another [00:32:15] I know our snake_case fields aren't exactly proper JS syntax [01:04:38] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286#12366040 (10Ejegg) [01:14:04] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Field validation for combowiki - https://phabricator.wikimedia.org/T439286#12366041 (10Ejegg) Looks like cdx-text-input can do some of the indication of validity for us, by setting e.g status = "error". We should also use its in... [01:15:49] (03PS1) 10Ramon Lopez: Added better mobile/responsive support [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345245 [01:19:13] (03CR) 10CI reject: [V:04-1] Added better mobile/responsive support [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345245 (owner: 10Ramon Lopez) [01:21:01] (03PS1) 10Ejegg: Slight cleanup of forbidden container nesting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345246 [01:21:34] (03PS3) 10Mstyles: CentralNotice: Require reauth to enable campaigns [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1329340 (https://phabricator.wikimedia.org/T208278) [01:21:34] (03PS1) 10Mstyles: CentralNotice: Require reauth to change a live campaign [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1345247 (https://phabricator.wikimedia.org/T208278) [01:49:37] (03PS1) 10Eileen: [WIp} - gonna put on staging Update CiviCRM to 6.20 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345248 [01:52:20] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Support autocomplete in Combowiki - https://phabricator.wikimedia.org/T439300 (10Ejegg) 03NEW [01:54:36] (03CR) 10CI reject: [V:04-1] [WIp} - gonna put on staging Update CiviCRM to 6.20 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345248 (owner: 10Eileen) [02:21:59] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Make ComboWiki input fields more composable / minimize mapping names back and forth - https://phabricator.wikimedia.org/T439302 (10Ejegg) 03NEW [02:22:10] (03PS1) 10Ejegg: WIP modular input fields for Combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345250 (https://phabricator.wikimedia.org/T439302) [02:22:26] oh dang it got late [02:33:52] (03PS1) 10Eileen: Update custom field definition in preparation for civi upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345251 [02:34:20] (03PS2) 10Eileen: [WIp} - gonna put on staging Update CiviCRM to 6.20 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345248 [03:35:50] (03PS3) 10Eileen: [WIp} - gonna put on staging Update CiviCRM to 6.20 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345248 [03:35:50] (03PS1) 10Eileen: port https://github.com/civicrm/civicrm-core/pull/36927 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345253 [05:52:01] FIRING: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [06:07:01] RESOLVED: ContextSwitchingSpike: Host context switching high (instance frdb1007.frack.eqiad.wmnet:9100) - https://alerts.wikimedia.org/?q=alertname%3DContextSwitchingSpike [11:06:21] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Clean up mw.config access in ComboWiki - https://phabricator.wikimedia.org/T439282#12366296 (10Aruotes) a:03Aruotes Hii , I would like to work on this task. Thank you!! [11:13:50] (03PS1) 10Aruotes: Refactor: Centralize mw.config access in ComboWiki to honor boundary comment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345271 [12:26:49] (03PS2) 10Aruotes: Refactor: Centralize mw.config access in ComboWiki to honor boundary comment [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345271 (https://phabricator.wikimedia.org/T439282) [19:46:24] 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Better "Maximum impressions" any individual will see - https://phabricator.wikimedia.org/T421662#12366503 (10Krinkle) p:05Triage→03Medium