[00:22:03] <wikibugs>	 (03CR) 10Wfan: [C:03+2] "LGTM thanks for this code refactor!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[00:23:35] <wikibugs>	 (03Merged) 10jenkins-bot: Make GatewayRouter an injectable service [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[00:23:41] <wikibugs>	 (03Merged) 10jenkins-bot: Use config service to build country config [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344762 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[00:25:08] <wikibugs>	 (03CR) 10Wfan: [C:03+2] "Like how we centralize the yaml reading, the following ConfigurationReader patch needs to resolve conflict~" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344778 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[00:26:55] <wikibugs>	 (03Merged) 10jenkins-bot: Use config service in adapter and PaymentSettings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344778 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg)
[00:33:36] <wikibugs>	 (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org! LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345665 (https://phabricator.wikimedia.org/T426118) (owner: 10Lars SG)
[00:37:36] <ejegg|afk>	 thanks for all the review wfan!
[00:46:24] <wikibugs>	 (03Merged) 10jenkins-bot: Apply default in tokens even if the entity is missing [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345665 (https://phabricator.wikimedia.org/T426118) (owner: 10Lars SG)
[00:46:48] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Fundraising-CiviCRM-Starting-Tasks, 10Wikimedia-Fundraising-CiviCRM, and 4 others: When a donor portal link is requested for an email that isn't a primary email in CiviCRM, send them... - https://phabricator.wikimedia.org/T426118#12372258
[01:17:37] <wikibugs>	 (03PS1) 10Cstone: Upgrade smash-pig to v1.2.6.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345681
[01:25:49] <wikibugs>	 (03PS10) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057)
[01:28:39] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Upgrade smash-pig to v1.2.6.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345681 (owner: 10Cstone)
[01:30:04] <wikibugs>	 (03PS1) 10Dmiranda: Record the activity when we can't show a donor portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345682 (https://phabricator.wikimedia.org/T426118)
[01:34:36] <wikibugs>	 (03CR) 10Ejegg: "Thanks for the review, Jon. I'll try another version of the hook in the PS, but PS10 does indeed return the flow correctly to the impressi" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[01:50:36] <wikibugs>	 (03Merged) 10jenkins-bot: Upgrade smash-pig to v1.2.6.2 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345681 (owner: 10Cstone)
[01:52:06] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] Record the activity when we can't show a donor portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345682 (https://phabricator.wikimedia.org/T426118) (owner: 10Dmiranda)
[01:52:20] <wikibugs>	 (03PS11) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057)
[01:53:50] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[01:55:03] <wikibugs>	 (03PS12) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057)
[01:56:48] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[01:57:17] <wikibugs>	 (03PS13) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057)
[02:00:52] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Fundraising-CiviCRM-Starting-Tasks, 10Wikimedia-Fundraising-CiviCRM, and 4 others: When a donor portal link is requested for an email that isn't a primary email in CiviCRM, send them... - https://phabricator.wikimedia.org/T426118#12372315
[02:07:55] <wikibugs>	 (03CR) 10Ejegg: "OK, PS13 has the new version of the hook which fully hands off execution to the experiment. Is it reasonable to require that any prohibite" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[02:18:05] <wikibugs>	 (03Merged) 10jenkins-bot: Record the activity when we can't show a donor portal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345682 (https://phabricator.wikimedia.org/T426118) (owner: 10Dmiranda)
[02:33:03] <wikibugs>	 (03PS14) 10Ejegg: Wait till banner fetched to consult TK enrollment [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057)
[02:33:28] <wikibugs>	 (03PS1) 10Cstone: Update smash-pig to v1.2.6.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345686
[02:33:49] <wikibugs>	 (03CR) 10Ejegg: "PS14 cleans up the hook callback signature and makes sure that only the first handler counts." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[02:36:25] <wikibugs>	 (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1345688
[02:37:14] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1345688 (owner: 10Lars SG)
[02:42:14] <wikibugs>	 (03PS1) 10Lars SG: Update Smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345689
[02:42:49] <wikibugs>	 (03PS2) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1345688
[02:44:34] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1345688 (owner: 10Lars SG)
[02:44:54] <wikibugs>	 (03Abandoned) 10Lars SG: Update Smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345689 (owner: 10Lars SG)
[02:45:45] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1345688 (owner: 10Lars SG)
[02:47:31] <larssandergreen>	 !log civicrm upgraded from 11d70b96 to a7d8ba32
[02:47:33] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL
[02:51:44] <wikibugs>	 (03Restored) 10Lars SG: Update Smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345689 (owner: 10Lars SG)
[03:11:49] <cstone>	 oh yeah finish yours lars
[03:11:54] <cstone>	 ill just abandon mine
[03:12:12] <wikibugs>	 (03Abandoned) 10Cstone: Update smash-pig to v1.2.6.2 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345686 (owner: 10Cstone)
[03:13:53] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Update Smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345689 (owner: 10Lars SG)
[03:35:01] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Fundraising-CiviCRM-Starting-Tasks, 10Wikimedia-Fundraising-CiviCRM, and 3 others: When a donor portal link is requested for an email that isn't a primary email in CiviCRM, send them... - https://phabricator.wikimedia.org/T426118#12372384
[03:39:26] <wikibugs>	 (03Merged) 10jenkins-bot: Update Smashpig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/1345689 (owner: 10Lars SG)
[03:42:21] <wikibugs>	 (03CR) 10Eileen: "I had a long discussion with Claude .... and ultimately these are the points that seem valid" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[03:57:58] <wikibugs>	 (03PS1) 10Cstone: Update smash-pig to v1.2.6.1 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1345693
[03:58:34] <wikibugs>	 (03CR) 10Cstone: [C:03+2] Update smash-pig to v1.2.6.1 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1345693 (owner: 10Cstone)
[04:05:15] <wikibugs>	 (03CR) 10Aruotes: "Ohh, Thank you so much!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345271 (https://phabricator.wikimedia.org/T439282) (owner: 10Aruotes)
[04:09:29] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Update smash-pig to v1.2.6.1 [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1345693 (owner: 10Cstone)
[07:49:42] <wikibugs>	 (03PS7) 10Laurabarluzzi: Create a CustomLogger trait to share setup and getLogMessagePrefix across all ComboWiki included classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831)
[07:51:22] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Create a CustomLogger trait to share setup and getLogMessagePrefix across all ComboWiki included classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi)
[07:55:57] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: In Civi can we show if a donor has a ZD ticket open on the Zendesk tab on a donor record - https://phabricator.wikimedia.org/T438742#12372763 (10RLewis) @Lars this great thank you so much.
[08:34:23] <wikibugs>	 (03PS1) 10Eileen: Fixes merged upstream to support batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345924 (https://phabricator.wikimedia.org/T434041)
[08:57:18] <wikibugs>	 (03PS1) 10Eileen: T434041: Add Engage Summary batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345928
[09:05:46] <wikibugs>	 (03CR) 10Laurabarluzzi: "@lsandergreen@wikimedia.org I don't find anywhere where the actual <iframe> is defined, can you point me to that code? I don't recall if y" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[09:29:47] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373133 (10Laurabarluzzi) a:03jgleeson
[09:30:05] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373135 (10Laurabarluzzi)
[09:31:43] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373142 (10Laurabarluzzi)
[09:31:47] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: filter payment method by supported country - https://phabricator.wikimedia.org/T437508#12373143 (10Laurabarluzzi)
[09:43:33] <wikibugs>	 (03CR) 10Laurabarluzzi: [C:03+1] "The code looks good to me (and resolves what I previously suggested in the related patch, by setting US as fallback default country)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[09:46:19] <jgleeson>	 laurabar: so I think ejegg|away's point was that we risk upsetting some folks by assuming US/USD 
[09:47:11] <jgleeson>	 if I understood correctly
[09:47:14] <jgleeson>	 I'll check the ticket again
[09:48:19] <laurabar>	 You are telling me this because I reviewed the patch that sets it as default?
[09:49:45] <laurabar>	 This is exactly why I created https://phabricator.wikimedia.org/T434807 in the past - to understand how to handle the rare scenario of when we don't detect a valid country 
[09:52:10] <jgleeson>	 right - I think my patch addresses your concerns in https://phabricator.wikimedia.org/T434807
[09:53:21] <wikibugs>	 (03PS8) 10Laurabarluzzi: Create a CustomLogger trait to share setup and getLogMessagePrefix across all ComboWiki included classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831)
[09:54:41] <jgleeson>	 so if I understand this correctly
[09:54:52] <jgleeson>	 we should aim to let a donor pick any currency they like
[09:55:25] <jgleeson>	 and if it's not a valid currency for the payment method, we tell them it will be processed in a valid one (default USD)
[09:56:00] <jgleeson>	 hmm I don't know about giving live fx conversions guides
[09:56:56] <laurabar>	 My understanding is that we let them choose the country (as in donate wiki) but simply let them know whcih currency is applied for that country. then I guess if you want, by knowing, they might choose a currency. But we didn't add a functionality of "selecting only the currency"
[09:57:09] <laurabar>	 The currency, like in donate, is auto-detected by the country selected / detected on page load.
[09:57:54] <laurabar>	 The only scenario where we might have an enforced currency is if it comes from the URL as a params (e.g. from our own emails for restarting a sub, the URLs to payments is built with currency and country with values set in civi)
[09:59:50] <jgleeson>	 so in most cases we try to make the country decision for the donoer
[09:59:52] <jgleeson>	 donor*
[10:00:32] <laurabar>	 The donor can change the country using the country dropdown
[10:01:15] <jgleeson>	 yes they can change it after we've assigned it
[10:01:16] <laurabar>	 Given a country X we need to understand how to handle (1) picking the currency and then, given the currency + country (2) picking the payment methods
[10:01:31] <jgleeson>	 they do not pick it by default
[10:02:42] <jgleeson>	 here's Elliott's ticket. he's talking about offering currency selection https://phabricator.wikimedia.org/T439255
[10:02:59] <wikibugs>	 (03PS1) 10Eileen: Add Engage Summary batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345943 (https://phabricator.wikimedia.org/T434041)
[10:02:59] <wikibugs>	 (03PS1) 10Eileen: Add Finance batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345944 (https://phabricator.wikimedia.org/T434041)
[10:03:42] <jgleeson>	 so I arrive from colombia, i want to pay in COP but with paypal I can't
[10:04:07] <jgleeson>	 instead you see this
[10:04:10] <jgleeson>	 https://usercontent.irccloud-cdn.com/file/Ef2sXUjF/image.png
[10:04:37] <jgleeson>	 so the enhancement suggestion is to do something similar
[10:05:20] <jgleeson>	 If we also wanted to make country configurable in the UI like donate wiki, that's probably a separate ticket at an earlier stage, 
[10:05:21] <laurabar>	 Exactly, the phab to be seems to suggest we should support this exact behavior in ComboWiki.
[10:05:31] <laurabar>	 *to me
[10:06:30] <laurabar>	 The question is "how"? Since in donate wiki the payment methods were hard coded and instead we're discussing in the google docs, and learning along the way, how to put together dynamically our own configurations from different gateways to achieve this without having to create too many redundant configuration files
[10:08:05] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Handle fallback currency in ComboWiki - https://phabricator.wikimedia.org/T439255#12373357 (10jgleeson) >>! In T439255#12371091, @Laurabarluzzi wrote: > Do we know which currencies are supported via PayPal? Only USD? I see that...
[10:08:35] <jgleeson>	 laurabar: we already do this today for gravy via our config
[10:08:39] <jgleeson>	 in payments
[10:08:55] <laurabar>	 I think PayPal is the outlier here; indeed the gateway configuration for paypal doesn't have a `currencies.yaml` file so I think we always default to converting from any currency to USD to our paypal accounts; we don't support paypal as payment_method only if the country is not in countries.yaml 
[10:09:18] <jgleeson>	 however there is a "new" way that we started to use with PayPal, which is calling Gravy directly and getting them to tell us
[10:10:30] <laurabar>	 I was told is the PayPal account that limits the incoming currencies. The Gravy integration is not putting paypal payments to a different paypal account (or so I was told). I cannot verify since I don't have access to the account.
[10:10:54] <jgleeson>	 laurabar: this the currencies.yaml file for Gravy https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/7e13d7d9041c3adcdbbe565a19f245d8cfbd2491/gravy_gateway/config/countries.yaml which was used upuntil we switched over to using a trait to pull it from Gr4vy's API
[10:12:04] <jgleeson>	 there is likely configuration across out Gr4vy/PayPal accounts to decide the list of supported currencies 
[10:12:33] <jgleeson>	 sorry that was the wrong link, this is currencies https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/c40ad319e2077a64c3487917974b30c85bbb8f96/gravy_gateway/config/currencies.yaml
[10:12:43] <laurabar>	 I know, I expanded the list of that countries.yaml list because we spotted a bug taht payments were going to legacy paypal (patches: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1331812)
[10:15:02] <jgleeson>	 ok but for combowiki
[10:15:05] <jgleeson>	 this is all via gravy paypal
[10:15:31] <jgleeson>	 old paypal is deprecated apart from old subscriptions 
[10:16:32] <jgleeson>	 also
[10:16:44] <jgleeson>	 "laurabar: I think PayPal is the outlier here; indeed the gateway configuration for paypal doesn't have a `currencies.yaml` file " - it does have a currencies.yaml
[10:17:04] <jgleeson>	 or are you talking about the gravy paypal external currencies list?
[10:17:28] <jgleeson>	 the one I explained here in answer to your question https://phabricator.wikimedia.org/T439255#12373357
[10:20:32] <laurabar>	 Ok, that answers a question. But in a call I remember hearing that our PayPal account might accept only USD - so that must be an outdated fact in someone's memory
[10:21:45] <laurabar>	 Did we open a different account in PayPal for the gravy integration?
[10:22:44] <jgleeson>	 Yes we did
[10:23:02] <laurabar>	 Ok, I think someone in a conversation wasn't aware of that or didn't remember.
[10:23:10] <laurabar>	 So i got confused.
[10:23:59] <jgleeson>	 check out this link which shows the currencies enabled on the gravy paypal connection https://wikimedia.gr4vy.app/merchants/default/connections/payment-services/b4e49424-f463-4d0d-b05a-b427a4d21c95/region-details
[10:24:07] <jgleeson>	 that's prod
[10:24:14] <jgleeson>	 so for staging it will likely be less
[10:24:18] <jgleeson>	 let's see
[10:24:23] <laurabar>	 Knowing this, I assume that we should be able to skip taht fallback currency logic then; we could run a test to see if all countries supported by PayPal (Gravy) can process payments in the default currency. If so, we can deprioritize that phab and work on it only if we need to support legacy PayPal
[10:25:11] <jgleeson>	 yep, so for our gravy sandbox, EUR is not enabled
[10:25:16] <jgleeson>	 you can see that here https://sandbox.wikimedia.gr4vy.app/merchants/default/connections/payment-services/0387563a-ff51-4346-bcfc-fa40dcddd4a4/region-details
[10:26:34] <laurabar>	 I was discussing this with Dylan  once; I think we need to pull configurations from Gravy because indeed the yaml files weren't updated with all the things we do support in Gravy. similarly, we could have an automated mirroring of prod to sandbox
[10:31:43] <laurabar>	 https://paymentstest8.wmcloud.org/index.php?title=Special:GravyGateway&title=Special:GravyGateway&appeal=JimmyQuote&payment_method=paypal&recurring=1&uselang=en&language=en&currency=EUR&amount=12.23&country=IT&debug=true locally shows the error indeed
[10:33:13] <laurabar>	 So when the gravy gateway selects paypal it currently relies on the API of gravy to validate the support of currencies and countries?
[10:35:44] <jgleeson>	 yep
[10:37:06] <laurabar>	 so this should be taken into consideration when discussing "configurations" in combowiki IMO
[10:39:17] <jgleeson>	 hmm
[10:39:25] <jgleeson>	 I don't want to overcomplicate it for now
[10:40:22] <jgleeson>	 medium/longer-term it might make sense to switch them all over to the gravy supported currencies API calls
[10:40:57] <jgleeson>	 but for now with our deadline, we can leverage our local config and then add tickets to enhance those to API calls if it makes sense
[10:41:32] <jgleeson>	 WRT to the combowiki config - I'm gonna push at an approach to that today
[10:42:09] <jgleeson>	 up*
[10:46:27] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373611 (10jgleeson) On the first question, [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Donatio...
[12:00:14] <damilare>	 session values shared between payments and combo causing leading to gateway not initialized on combo
[12:11:23] <jgleeson>	 have you seen that already damilare ?
[12:11:39] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373963 (10Laurabarluzzi) > The follow-up Validate the ComboWiki session country too also stops normalizeCou...
[12:13:27] <damilare>	 which one, do you mean the error I just described jgleeson 
[12:13:57] <damilare>	 yh it came up when I switched gears from a payments patch I was working to review a combo wiki patch
[12:14:55] <wikibugs>	 (03CR) 10Jgleeson: "Hi @lbarluzzi@wikimedia.org - thanks for the review. I read the ticket you linked, and I don't think it describes what I did in this patch" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:14:56] <damilare>	 I guess because I was working on a new payment method/submethod, so the router used what it had in session
[12:15:23] <jgleeson>	 so I patched one here damilare https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1345607/
[12:15:37] <jgleeson>	 invalid country values coming in via the session
[12:15:56] <jgleeson>	 but it doesn't cover payment methods
[12:16:47] <jgleeson>	 however that might come into play with the remainder of https://phabricator.wikimedia.org/T437508
[12:18:48] <damilare>	 yh that'd probably fix this issue I just had. since it'd only load methods for the specified country
[12:24:38] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12373984 (10jgleeson) @Laurabarluzzi the issue is that the payment forms can currently set values that are re...
[12:25:02] <jgleeson>	 laurabar: damilare just confirmed that with his error report  ^
[12:25:10] <wikibugs>	 (03CR) 10Laurabarluzzi: [C:03+2] "I think you're taking those phabs very literally but they were created during a big refactor as pointers to remember to look at those area" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:28:30] <wikibugs>	 (03CR) 10Damilare Adedoyin: "Thanks @lbarluzzi@wikimedia.org for all the thought and work that went into this, tested all the code paths in this change and works corre" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[12:31:22] <wikibugs>	 (03CR) 10Jgleeson: "Thanks again. I was on sabbatical when your ticket was created, so I wasn't around for the context that they were pointers to revisit, but" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:31:52] <wikibugs>	 (03Merged) 10jenkins-bot: Decide the ComboWiki country once, on the server [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:32:46] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12374026 (10Laurabarluzzi) @jgleeson mmm I think the problem is that indeed we're not isolating combowiki ses...
[12:34:09] <laurabar>	 damilare: what do you think should we do regarding the session data be overriden between payments and combowiki? Do you think is there a way to revert back to combowiki using a separate key?
[12:34:40] <laurabar>	 (if you recall it was our initial intention, but we ended up using 'Donor' for some reasons I dont' recall)
[12:36:34] <damilare>	 Yh let me find the patch, I think we had to move to Donor because the adapter was resetting the values. 
[12:43:36] <wikibugs>	 (03CR) 10Laurabarluzzi: [C:03+2] "It might be safe removing it but I see that there are ~40 of those logs in August so maybe it's still an info that now we don't know we mi" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:46:04] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12374109 (10Laurabarluzzi) I created this phab back when the team picked combowiki and we did a big refactor...
[12:46:08] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12374110 (10Laurabarluzzi) 05Open→03Resolved
[12:47:14] <damilare>	 laurabar: this was the patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1327579 
[12:47:35] <damilare>	 The gatway was not using the values we were setting into session from combowiki
[12:47:40] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update DonationInterface\ComboWiki\DataNormalizer::normalizeCountry - https://phabricator.wikimedia.org/T434807#12374119 (10jgleeson) # Do you remember why you reverted to the key 'Donor'? Changing it might make our l...
[12:48:12] <damilare>	 and since we currently rely on the gateways for payments, it was easier to just have both combowiki and gateways on the same session key.
[12:48:57] <jgleeson>	 ah you just answered my last reply to laurabar on the phab ha!
[12:48:59] <jgleeson>	 ty
[12:50:04] <wikibugs>	 (03PS14) 10Laurabarluzzi: Remove applePayHelper.js legacy dependencies in ComboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143)
[12:50:42] <wikibugs>	 (03CR) 10Laurabarluzzi: Remove applePayHelper.js legacy dependencies in ComboWiki (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[12:52:05] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks! LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[12:53:32] <wikibugs>	 (03CR) 10Jgleeson: "Sounds good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345115 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[12:57:16] <wikibugs>	 (03Merged) 10jenkins-bot: Remove applePayHelper.js legacy dependencies in ComboWiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342784 (https://phabricator.wikimedia.org/T438143) (owner: 10Laurabarluzzi)
[12:58:53] <wikibugs>	 (03PS9) 10Laurabarluzzi: Create a CustomLogger trait to share setup and getLogMessagePrefix across all ComboWiki included classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831)
[13:03:34] <laurabar>	 damilare: so how should we go about it then? I figure it's not a common production issue (if even possible). But it is a potential issue and we can "easily" fix it if we find a way.
[13:05:00] <laurabar>	 For instance what if we make the adapter take a "session key" param? that can override the default? So we can keep the legacy code somewhat the same by setting "Donor" as default value and we pass a new key to override it?
[13:07:31] <damilare>	 oh the session sharing between the adapter and combowiki, well we could consider that
[13:09:00] <damilare>	 the adapter session logic is a bit more complicated though, because we also have the reset values. I didn't mean to imply it impossibe, but since we are considering a different approach for combowiki that might involve not using the adapters, I just don't think its worth the commitment
[13:09:59] <damilare>	 the reset values and backkups*
[13:13:31] <laurabar>	 yeah, it comes back to if it's evn possible to not use the adapters though (there is tension between having new parallel solutions vs reusing what we have)
[13:14:32] <laurabar>	 I'd assume the chance of that problem happening in production is minimal; maybe a hack could be to have each page store a value in the session that can be read to know if the session was written from 'combowiki' vs 'payments'. Kind of a hack but it could solve the issue
[13:16:31] <laurabar>	 Something that the adapters doesn't need to know basically, just an extra 'fieldNames' in the list of values we store in the session under Donor
[13:17:42] <laurabar>	 And in ComboWiki we can ignore session Donor data saved in 'payments' and in payments we can ignored session Donor data saved in 'combowiki'. 🤔
[13:19:57] <damilare>	 🤔
[13:23:14] <jgleeson>	 🤔
[13:23:21] * jgleeson trolls
[13:23:26] <damilare>	 laurabar: I don't think it's a major issue at this MVP phase, but I could be wrong. If you think it is feel free to go ahead with a patch. 
[13:26:04] <damilare>	 I think we can make the payments session usable on combowiki without having to change anything on the adapter though
[13:26:43] <damilare>	 the bug I had today was because of a payment submethod was set in session that doesn't currently exist, this can be handled easily on combowiki
[13:32:20] <ejegg|away>	 damilare and laurabar so my dream is that someday ComboWiki can just call the SmashPig classes directly
[13:32:48] <ejegg>	 with perhaps a few smallish gateway-specific helpers to e.g collect the relevant input parameters
[13:33:28] <ejegg>	 I guess that would come once we're ready to remove the old gateway pages though
[13:34:51] <damilare>	 the ones supporting payments?
[13:35:11] <jgleeson>	 nice dream ejegg !
[13:36:00] <damilare>	 yh I think the work done in removing the normalization and setting session values from the adapter is a big step in that direction
[13:49:42] <jgleeson>	 ejegg: the ComboWiki frontend makes payments through DI API calls, and those API modules are what call the adapters (DonationApi -> $this->adapter->doPayment()). So the front end doesn't know about adapters, and we could change what sits behind those API modules, for example, to call SmashPig directly, without rewriting the Vue side.
[13:51:21] <jgleeson>	 two caveats though, the Special:ComboWiki page itself still creates an adapter server-side when it loads for stuff it needs, so that would need to move too. The adapters do a lot more than call SmashPig: validation, fraud checks, staging of donor data, order IDs, queue messages. Going straight to SmashPig means finding a new home for all of that, so it's doable but a fair amount of work. 
[13:54:24] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Reduce to the minimum all gateway dependencies in ComboWiki.php - https://phabricator.wikimedia.org/T434827#12374497 (10Laurabarluzzi)
[13:54:42] <laurabar>	 I had this post-refactor phab created with this "dream" mentioned https://phabricator.wikimedia.org/T434827
[13:54:43] <laurabar>	 It'd be great if we could add more details on how to investigate and plan this goal going ahead
[13:55:14] <wikibugs>	 (03PS1) 10Jgleeson: Patch undefined variant warning on ComboWiki forbidden country page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346024 (https://phabricator.wikimedia.org/T439147)
[13:55:47] <ejegg>	 yeah jgleeson, replacing those huge classes will definitely not be trivial
[13:57:07] <jgleeson>	 a worthy goal though!
[13:57:11] <laurabar>	 We replaced donor data, order Ids and writing contribution_tracking messages to the queues (the only parts that are still linked are 'sequence' and the session key as far as I recall).
[14:04:29] <jgleeson>	 yep laurabar - that's definitely gonna help! 
[14:04:37] <jgleeson>	 gonna grab the kids - back later
[14:49:26] <wikibugs>	 (03CR) 10Laurabarluzzi: [C:03+1] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344979 (https://phabricator.wikimedia.org/T438805) (owner: 10Dmiranda)
[14:52:55] <ejegg>	 yeah, at this point I'm just getting 'claude is busy right now' type responses so i've moved on to other stuff :)
[14:53:22] <ejegg>	 i'm going to do another payments-wiki deploy
[14:53:46] <ejegg>	 and make sure that config service stuff doesn't break prod
[14:55:44] <wikibugs>	 (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1346038
[14:55:48] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1346038 (owner: 10Ejegg)
[14:57:14] <wikibugs>	 (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/1346038 (owner: 10Ejegg)
[15:01:07] <wikibugs>	 (03PS1) 10Ejegg: Update composer dependencies [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1346040
[15:01:09] <wikibugs>	 (03CR) 10Ejegg: [C:03+2] Update composer dependencies [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1346040 (owner: 10Ejegg)
[15:05:31] <wikibugs>	 (03PS2) 10Ejegg: Update composer dependencies [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1346040
[15:05:32] <wikibugs>	 (03CR) 10Ejegg: Update composer dependencies [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1346040 (owner: 10Ejegg)
[15:12:08] <ejegg>	 ooh wait I think I want to update the ML service first
[15:12:15] <ejegg>	 so it can accept those new parameters
[15:12:34] <ejegg>	 ah it will just silently drop them for now
[15:13:45] <wikibugs>	 (03CR) 10Laurabarluzzi: [C:03+2] Patch undefined variant warning on ComboWiki forbidden country page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346024 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson)
[15:13:54] <ejegg>	 !log payments-wiki upgraded from 49e656bc to dae59de9
[15:13:56] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL
[15:14:13] <ejegg>	 ok, one error while rsyncing but the rest seems OK
[15:14:34] <ejegg>	 I just got routed to the payment form correctly from donatewiki
[15:15:18] <wikibugs>	 (03Merged) 10jenkins-bot: Update composer dependencies [core] (fundraising/REL1_43) - 10https://gerrit.wikimedia.org/r/1346040 (owner: 10Ejegg)
[15:15:38] <ejegg>	 oh that was just the composer.lock file ^^^
[15:15:43] <ejegg>	 no-op on prod
[15:18:24] <wikibugs>	 (03Merged) 10jenkins-bot: Patch undefined variant warning on ComboWiki forbidden country page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346024 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson)
[15:19:26] <jinxer-wm>	 FIRING: NodeDown: Node payments1012 is down.  - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1012 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown
[15:20:14] <ejegg>	 uff, searchkit version of standalone role / permission UI feels like a step backward for usability
[15:21:45] <cstone>	 ejegg: did smash pig work okay for you in that update you just did? I got stuck in a loop last night 
[15:22:13] <cstone>	 Where I couldn't do a composer install because the versions didn't match then it wouldn't let me update because the versions didn't match in the other way 
[15:22:35] <ejegg>	 oh weird, that update went totally smoothly
[15:22:50] <ejegg>	 you weren't trying to update the gravy sdk too?
[15:24:26] <jinxer-wm>	 RESOLVED: NodeDown: Node payments1012 is down.  - https://frmon.wikimedia.org/d/000000377/host-overview?orgId=1&var-host=payments1012 - https://alerts.wikimedia.org/?q=alertname%3DNodeDown
[15:29:44] <cstone>	 ejegg: no I was trying to do a fresh payments install on docker 
[15:30:04] <cstone>	 But then the smash pig version was out of sync 
[15:57:30] <wikibugs>	 (03CR) 10Ejegg: "Working well in local testing. I verified that" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[15:59:38] <wikibugs>	 (03CR) 10Ejegg: [C:03+1] "I'm pretty happy with this. See testing notes on next patch in the chain. If we are worried about timing attacks we could add some delay w" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG)
[16:01:40] <wikibugs>	 (03CR) 10Ejegg: [C:03+1] Add authenticated iframe extension (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG)
[16:04:44] <ejegg>	 hmm cstone have you been able to get it sorted yet?
[16:05:20] <cstone>	 lemme try right now
[16:05:34] <cstone>	 i rage quit last night when it looped hah
[16:31:54] <ejegg>	 ok, looks like the payment attempts table at Civi has the new auth rate fields
[16:32:03] <ejegg>	 let's do the ML service
[16:36:31] <ejegg>	 ok, that's sending along
[16:36:45] <ejegg>	 ooh, we might need another CRM-side patch for the queue consumer
[16:36:46] <ejegg>	 let's see
[16:39:59] <wikibugs>	 (03PS1) 10Ejegg: Add auth_rate fields to consumer list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346067 (https://phabricator.wikimedia.org/T419610)
[16:40:09] <ejegg>	 fr-tech ^^^ should be pretty trivial to review
[16:40:18] <ejegg>	 and is the only thing missing to get that data into the Civi tables
[16:56:02] <jgleeson>	 cautiously looking
[16:56:44] <jgleeson>	 ejegg: I'm going in cold here
[16:56:54] <jgleeson>	 I guess it *looks* fine :)
[16:59:07] <wikibugs>	 (03CR) 10Jgleeson: [C:03+2] "I think this is ok :D" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346067 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[17:04:01] <wikibugs>	 (03CR) 10Jgleeson: Validate the ComboWiki session country too (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345607 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson)
[17:17:18] <wikibugs>	 (03Merged) 10jenkins-bot: Add auth_rate fields to consumer list [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346067 (https://phabricator.wikimedia.org/T419610) (owner: 10Ejegg)
[17:27:01] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597 (10Cstone) 03NEW
[17:27:41] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597#12375944 (10Cstone) p:05Triage→03High
[17:37:17] <wikibugs>	 10fundraising-tech-ops: Fundraising Metabase access request for Yosola Olorunshola - https://phabricator.wikimedia.org/T439599#12376016 (10AStein-WMF) a:03AStein-WMF
[17:44:20] <wikibugs>	 10fundraising-tech-ops: Fundraising Metabase access request for Yosola Olorunshola - https://phabricator.wikimedia.org/T439599#12376040 (10AStein-WMF)
[18:07:44] <ejegg|food>	 thanks jgleeson !
[18:11:49] <jgleeson>	 np
[18:15:28] <wikibugs>	 (03PS1) 10Catrope: SECURITY: Escape system messages in two places [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1346103 (https://phabricator.wikimedia.org/T432419)
[18:15:38] <wikibugs>	 (03PS1) 10Catrope: SECURITY: Escape system messages in two places [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1346104 (https://phabricator.wikimedia.org/T432419)
[18:15:50] <wikibugs>	 (03CR) 10Catrope: [C:03+2] SECURITY: Escape system messages in two places [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1346103 (https://phabricator.wikimedia.org/T432419) (owner: 10Catrope)
[18:17:25] <wikibugs>	 (03CR) 10Catrope: [C:03+2] SECURITY: Escape system messages in two places [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1346104 (https://phabricator.wikimedia.org/T432419) (owner: 10Catrope)
[18:19:02] <wikibugs>	 (03Merged) 10jenkins-bot: SECURITY: Escape system messages in two places [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1346103 (https://phabricator.wikimedia.org/T432419) (owner: 10Catrope)
[18:23:26] <wikibugs>	 (03Merged) 10jenkins-bot: SECURITY: Escape system messages in two places [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/1346104 (https://phabricator.wikimedia.org/T432419) (owner: 10Catrope)
[18:28:28] <jgleeson>	 fr-tech I'm gonna be a few mins late for tech-talk I need to relocate after pushing up this WIP patch
[18:29:56] <wikibugs>	 (03CR) 10Wfan: [C:03+2] Slight cleanup of forbidden container nesting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345246 (owner: 10Ejegg)
[18:30:52] <wikibugs>	 (03PS3) 10Ejegg: Convert AmountHelper to service, rename [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344793 (https://phabricator.wikimedia.org/T439147)
[18:31:49] <wikibugs>	 (03Merged) 10jenkins-bot: Slight cleanup of forbidden container nesting [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345246 (owner: 10Ejegg)
[18:55:51] <wikibugs>	 (03Abandoned) 10Eileen: T434041: Add Engage Summary batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345928 (owner: 10Eileen)
[19:07:48] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Render second-stage form in Combowiki for banner donations - https://phabricator.wikimedia.org/T439621 (10Ejegg) 03NEW
[19:09:44] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] Fixes merged upstream to support batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345924 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:15:03] <wikibugs>	 06Fundraising-Backlog, 10FR-email-preferences: EPC should be mobile responsive - https://phabricator.wikimedia.org/T439622 (10Lars) 03NEW
[19:15:33] <wikibugs>	 06Fundraising-Backlog, 07fr-combowiki: Combowiki: 3DS - https://phabricator.wikimedia.org/T439623 (10Cstone) 03NEW
[19:19:58] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 07fr-current-sprint: Investigate having combowiki on donate.wikipedia.org - https://phabricator.wikimedia.org/T433108#12376525 (10Cstone)
[19:20:37] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 10FR-email-preferences: EPC / Donor portal log in links are taking a long time to arrive - https://phabricator.wikimedia.org/T439624 (10Lars) 03NEW
[19:23:03] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki, 07fr-current-sprint: Use DonationInterface config in Combowiki - https://phabricator.wikimedia.org/T427982#12376544 (10Cstone) 05Open→03Resolved closing this as it's work ha...
[19:23:38] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10FR-email-preferences: EPC should be mobile responsive - https://phabricator.wikimedia.org/T439622#12376549 (10SBurnett-WMF)
[19:28:14] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 10FR-email-preferences: EPC / Donor portal log in links are taking a long time to arrive - https://phabricator.wikimedia.org/T439624#12376577 (10Lars) a:03Lars
[19:31:36] <wikibugs>	 (03Merged) 10jenkins-bot: Fixes merged upstream to support batch imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345924 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:33:11] <damilare>	 jgleeson: laurabar wfan eileen around for standup
[19:34:01] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10DNS, 06SRE, and 2 others: Investigate having combowiki on donate.wikipedia.org - https://phabricator.wikimedia.org/T433108#12376605 (10Ejegg)
[19:35:48] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 10fundraising-tech-ops: Fundraising Metabase access request for Yosola Olorunshola - https://phabricator.wikimedia.org/T439599#12376611 (10SBurnett-WMF) p:05Triage→03Medium
[19:39:53] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10fundraising-tech-ops, 10DNS, and 3 others: Investigate having combowiki on donate.wikipedia.org - https://phabricator.wikimedia.org/T433108#12376635 (10Ejegg)
[19:44:30] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] "+2ing after a quick read on the basis that this will get further testing and maybe future looking at before being used in production." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345943 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:44:47] <wikibugs>	 (03CR) 10Eileen: [V:03+2] Add Engage Summary batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345943 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:45:59] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346128
[19:46:11] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346128 (owner: 10Eileen)
[19:46:31] <wikibugs>	 (03CR) 10Lars SG: [C:03+2] "as for previous patch" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345944 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:46:56] <wikibugs>	 03Fundraising Sprint: Quiz Show Podium, 06Fundraising-Backlog: Sprint Q Priorities - https://phabricator.wikimedia.org/T437306#12376659 (10SBurnett-WMF) 05Open→03Resolved
[19:47:44] <wikibugs>	 (03CR) 10Eileen: [V:03+2] Add Finance batch import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1345944 (https://phabricator.wikimedia.org/T434041) (owner: 10Eileen)
[19:48:50] <wikibugs>	 (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346132
[19:49:12] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346132 (owner: 10Eileen)
[19:49:12] <wikibugs>	 06Fundraising-Backlog, 10FR-Donation-Processing: Direct Mail Activity Import File - September 2026 List - https://phabricator.wikimedia.org/T439463#12376676 (10MDemosWMF) @Eileenmcnaughton Received! Thank you!
[19:49:53] <eileen>	 !log civicrm upgraded from a7d8ba32 to 37e1be22
[19:49:55] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL
[19:50:23] <wikibugs>	 (03PS1) 10Wfan: Add Canceled_Reversal to be handle from paypal ipn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1346134 (https://phabricator.wikimedia.org/T434019)
[19:50:24] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10FR-Donation-Processing: Direct Mail Activity Import File - September 2026 List - https://phabricator.wikimedia.org/T439463#12376680 (10SBurnett-WMF) @MDemosWMF reported that the import was all good. Moving phab to done.
[19:51:26] <eileen>	 !log civicrm upgraded from 37e1be22 to 6144ab57
[19:51:27] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL
[19:55:11] <wikibugs>	 (03PS1) 10Wfan: limit the line to max 30 for all failmail [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1346137 (https://phabricator.wikimedia.org/T438355)
[19:56:19] <wikibugs>	 (03CR) 10Lars SG: "Looks good, but one design detail: I think we should make the horizontal line at the top of the footer match the width, colour, etc of the" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi)
[19:56:20] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Pre payment monthly convert doesn't redirect when you select No Thanks - https://phabricator.wikimedia.org/T438929#12376702 (10AnnWF) a:03AnnWF
[19:57:17] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 10Continuous-Integration-Config: Run CiviCRM tests under trixie / PHP8.4 - https://phabricator.wikimedia.org/T439483#12376719 (10Jdforrester-WMF) To confirm, is this the gerrit CI for the wikimedia/fundraising/crm and wikim...
[20:10:38] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 06Release-Engineering-Team, 10Continuous-Integration-Config: Run CiviCRM tests under trixie / PHP8.4 - https://phabricator.wikimedia.org/T439483#12376810 (10Ejegg) Yes Jdforrester, it would be great to have them both in parallel! Thank you so much.
[20:15:02] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Add more parameters to ResultSwitcher return URL as an encrypted blob - https://phabricator.wikimedia.org/T436952#12376826 (10Laurabarluzzi) @Cstone I think this is 'nice to have' improvement and I'd suggest to move it to post M...
[20:18:29] <wikibugs>	 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Handle fallback currency in ComboWiki - https://phabricator.wikimedia.org/T439255#12376831 (10Laurabarluzzi) @jgleeson @Cstone given our conversations today maybe this phab can be moved to the after MVP column? It looks like tha...
[20:19:28] <wikibugs>	 (03PS1) 10Eileen: Don't abort the whole batch generation run on a vendor mapping failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346148
[20:55:49] <wikibugs>	 (03PS1) 10Wfan: Fix Pre payment monthly convert no path [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346155 (https://phabricator.wikimedia.org/T438929)
[21:13:06] <wikibugs>	 (03PS12) 10Lars SG: Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759)
[21:13:06] <wikibugs>	 (03PS17) 10Lars SG: Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866)
[21:13:06] <wikibugs>	 (03PS1) 10Lars SG: Allow new checksum link messages to set the activity source contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346163 (https://phabricator.wikimedia.org/T433866)
[21:14:13] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG)
[21:14:26] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[21:14:31] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Allow new checksum link messages to set the activity source contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346163 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[21:17:10] <wikibugs>	 (03PS2) 10Lars SG: Allow new checksum link messages to set the activity source contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346163 (https://phabricator.wikimedia.org/T433866)
[21:17:11] <wikibugs>	 (03PS13) 10Lars SG: Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759)
[21:17:11] <wikibugs>	 (03PS18) 10Lars SG: Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866)
[21:18:00] <wikibugs>	 (03Abandoned) 10Lars SG: Add Storage Access permission request for Safari & FireFox [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344414 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG)
[21:18:19] <wikibugs>	 (03CR) 10Lars SG: "That will be on Zendesk and hasn't been done yet. We could set some sandboxing on the iframe, but I'm not sure it helps us much as our mai" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[21:18:31] <wikibugs>	 (03CR) 10Lars SG: "I've addressed this by not allowing GETs with query params and instead POSTing the email." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759) (owner: 10Lars SG)
[21:19:29] <wikibugs>	 (03CR) 10Lars SG: "Also it now disables the buttons after sending the new checksum link, so that should make it clearer that it has happened" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[21:23:43] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10FR-Donor-portal, 10FR-email-preferences: EPC / Donor portal log in links are taking a long time to arrive - https://phabricator.wikimedia.org/T439624#12377114 (10Lars) Turns out this was an easy fix in process-control as it was only running for 1 mi...
[21:27:04] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Logdog should include syslog on civi1002 - https://phabricator.wikimedia.org/T434029#12377116 (10AnnWF) >>! In T434029#12371676, @Lars wrote: > @AnnWF I think the change you've made won't cover the syslog need (as in the...
[21:27:20] <wikibugs>	 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Logdog should include syslog on civi1002 - https://phabricator.wikimedia.org/T434029#12377118 (10AnnWF) a:03AnnWF
[21:32:54] <wikibugs>	 (03CR) 10CI reject: [V:04-1] Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[21:42:31] <wikibugs>	 (03PS14) 10Lars SG: Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759)
[21:42:31] <wikibugs>	 (03PS19) 10Lars SG: Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866)
[21:46:38] <wikibugs>	 (03CR) 10Jdlrobson: [C:03+1] Wait till banner fetched to consult TK enrollment (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[21:57:36] <wikibugs>	 (03CR) 10Ejegg: [C:04-1] "Looks like for the ERROR log case this will only ever log the last 30 events, not the 30 lines before the error. So if there is an error a" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1346137 (https://phabricator.wikimedia.org/T438355) (owner: 10Wfan)
[21:59:13] <wikibugs>	 (03CR) 10Eric Gardner: Wait till banner fetched to consult TK enrollment (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[21:59:38] <wikibugs>	 (03CR) 10Ejegg: Wait till banner fetched to consult TK enrollment (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1342797 (https://phabricator.wikimedia.org/T438057) (owner: 10Ejegg)
[22:08:14] <wikibugs>	 06Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface, 07payments-orchestration: Update to newer Gr4vy SDK - https://phabricator.wikimedia.org/T439156#12377244 (10Ejegg) Looks like it might be cleaner to just drop the SDK dependency and write our own code to send requests directly...
[22:16:35] <wikibugs>	 06Fundraising-Backlog, 06FR-donorrelations: check on Civi ingesting PayPal Resolution Center reversals - https://phabricator.wikimedia.org/T439645 (10MBeat33) 03NEW
[22:29:42] <wikibugs>	 (03PS1) 10Lars SG: Add Mark completed SK action for activities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346181 (https://phabricator.wikimedia.org/T434201)
[22:29:45] <wikibugs>	 (03PS1) 10Lars SG: Default MG Engagement activities to scheduled [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346182 (https://phabricator.wikimedia.org/T434201)
[22:33:05] <wikibugs>	 (03CR) 10Eileen: [C:03+2] Allow new checksum link messages to set the activity source contact [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346163 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)
[22:53:59] <wikibugs>	 06Fundraising-Backlog, 10FR-email-preferences: EPC should be mobile responsive - https://phabricator.wikimedia.org/T439622#12377350 (10Lars)
[23:07:04] <wikibugs>	 (03PS15) 10Lars SG: Add authenticated iframe extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1341365 (https://phabricator.wikimedia.org/T437759)
[23:07:05] <wikibugs>	 (03PS20) 10Lars SG: Add iframe for donor details to be shown in ZD [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1331825 (https://phabricator.wikimedia.org/T433866)
[23:28:15] <wikibugs>	 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Duplicate banking institution soft credit - https://phabricator.wikimedia.org/T435643#12377440 (10Lars) 05Open→03Resolved a:03Lars Seems like this has been handled, closing.
[23:36:40] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12377453 (10Lars) @MDemosWMF @RLewis I think we could handle this alongside the checks we are doing in White...
[23:39:47] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12377470 (10Lars) @NNgu-WMF Is this still something we want?
[23:47:16] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Stop exporting permanent contact hash, use expiring checksum instead - https://phabricator.wikimedia.org/T402462#12377514 (10Lars) @ppenloglou Would you be able to check if we are s...
[23:48:49] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07Unplanned-Sprint-Work: Activity import issues - https://phabricator.wikimedia.org/T399230#12377520 (10Lars) @Jsimmonds is this still an issue or has the new import resolved it?
[23:50:09] <wikibugs>	 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM: Do we want to be able to re-enable WMFDataManagement.ArchiveThankYou - https://phabricator.wikimedia.org/T397102#12377522 (10Lars) 05Open→03Invalid We've decided on a different approach in the parent phab.
[23:50:24] <wikibugs>	 (03CR) 10Dmiranda: [C:03+2] "Thanks @lsandergreen@wikimedia.org! Looks good to me" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346182 (https://phabricator.wikimedia.org/T434201) (owner: 10Lars SG)
[23:51:56] <wikibugs>	 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Add hooks to re-opt-in emails in Acoustic when changed in Civi - https://phabricator.wikimedia.org/T412252#12377533 (10Lars) Check if we can close {T403777} after this is resolved.