[00:03:10] (03Merged) 10jenkins-bot: Also use getMergedTo for contact imports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346808 (https://phabricator.wikimedia.org/T439793) (owner: 10Lars SG) [00:06:48] (03CR) 10CI reject: [V:04-1] Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [00:08:12] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Adding check number field to DAFpay payment method - https://phabricator.wikimedia.org/T429835#12383212 (10Eileenmcnaughton) I did an upstream PR - hopefully it gets merged soon https://github.com... [00:08:58] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346824 [00:20:47] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346824 (owner: 10Lars SG) [00:21:40] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346824 (owner: 10Lars SG) [00:28:28] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12383223 (10Lars) @NNgu-WMF Yes, for give less, so we could only show it conditionally so we wouldn't be suggesti... [00:30:37] !log civicrm upgraded from 3aadfcea to 87705543 [00:30:39] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [00:31:02] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Develop process to prevent direct mail being sent to long-deleted cids - https://phabricator.wikimedia.org/T406771#12383227 (10Lars) @MDemosWMF Fixed! Can you try to import the ones that failed again? [00:32:07] (03CR) 10Lars SG: [C:03+2] Don't abort the whole batch generation run on a vendor mapping failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346148 (owner: 10Eileen) [00:59:03] (03Merged) 10jenkins-bot: Don't abort the whole batch generation run on a vendor mapping failure [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346148 (owner: 10Eileen) [01:11:01] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383249 (10Cstone) [01:11:39] 06Fundraising-Backlog, 07Epic, 07fr-combowiki: [Epic] ComboWiki - Phase 2 - https://phabricator.wikimedia.org/T439799 (10Cstone) 03NEW [01:12:01] 06Fundraising-Backlog, 07Epic, 07fr-combowiki: [Epic] ComboWiki - Phase 2 - https://phabricator.wikimedia.org/T439799#12383260 (10Cstone) [01:12:03] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 06Fundraising-Tech-Roadmap, 07Epic, 07fr-combowiki: Combowiki A/B testing - https://phabricator.wikimedia.org/T427983#12383259 (10Cstone) [01:12:05] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383261 (10Cstone) [01:22:14] (03Abandoned) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1346813 (owner: 10Eileen) [01:27:23] 06Fundraising-Backlog, 07Epic, 07fr-combowiki: [Epic] ComboWiki - Phase 2 - https://phabricator.wikimedia.org/T439799#12383271 (10Cstone) [01:27:24] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 07fr-combowiki: Add dLocal Card Vue Component - https://phabricator.wikimedia.org/T430747#12383270 (10Cstone) [01:27:27] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383272 (10Cstone) [01:28:29] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Fix 3DS redirect, it's currently going to payments - https://phabricator.wikimedia.org/T439623#12383274 (10Cstone) [01:28:33] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383275 (10Cstone) [01:29:11] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Add SEPA - https://phabricator.wikimedia.org/T439597#12383276 (10Cstone) [01:29:12] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383277 (10Cstone) [01:29:50] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: display endowment with utm_medium=endowment - https://phabricator.wikimedia.org/T434233#12383281 (10Cstone) [01:29:55] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383282 (10Cstone) [01:30:25] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 05MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), 13Patch-For-Review: Combowiki: filter payment method by supported country - https://phabricator.wikimedia.org/T437508#12383283 (10Cstone) [01:30:26] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383284 (10Cstone) [01:31:17] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Check for employer selection bug - https://phabricator.wikimedia.org/T438918#12383287 (10Ejegg) Ah, looks like we do need to proactively clear out the model values when a donor blanks the... [01:44:02] (03PS3) 10Eileen: Always populate amount_journaled_to_foundation on batch export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346812 [02:08:11] (03PS2) 10Eileen: Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 [02:25:35] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12383324 (10Lars) @RLewis @MDemosWMF Do we want to exclude Financial Type = Recurring Gift here (i.e. first r... [02:32:57] (03CR) 10CI reject: [V:04-1] Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 (owner: 10Eileen) [02:33:58] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Bulk lookup function for guest lists - https://phabricator.wikimedia.org/T439797#12383347 (10Lars) We might be able to do something in SK with proximity search for this. [02:37:52] (03CR) 10Eileen: [C:03+2] "Claude comments - I don't think they are material" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1344827 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [02:43:01] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Clean up utm_campaign, _medium, _source so we no longer have to do a bunch of regex to categorize gifts - https://phabricator.wikimedia.org/T439802 (10Lars) 03NEW [03:03:37] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 2 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12383374 (10Lars) @RLewis @MDemosWMF Also, do we want to check for a relationship manager on related contacts... [03:31:06] (03PS1) 10Lars SG: WIP: Add MGGO appeal when donor has a relationship manager [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346979 (https://phabricator.wikimedia.org/T406662) [03:33:17] (03PS1) 10Eileen: Fix typo causing no prospect tab [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346980 [03:58:39] (03PS1) 10Lars SG: Automatically generate MGGONN appeals for this year and next year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346988 (https://phabricator.wikimedia.org/T386031) [03:59:47] (03CR) 10CI reject: [V:04-1] Automatically generate MGGONN appeals for this year and next year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346988 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:05:31] (03CR) 10Eileen: "A couple of minor style comments -non blocking." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:06:24] (03PS17) 10Lars SG: Add gift coding for White Mail / empty appeal donations based on MG Engagement, Direct Mail or DAF email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031) [04:09:26] (03CR) 10Eileen: Add gift coding for White Mail / empty appeal donations based on MG Engagement, Direct Mail or DAF email (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:09:27] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Check for employer selection bug - https://phabricator.wikimedia.org/T438918#12383408 (10Cstone) [04:09:29] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383409 (10Cstone) [04:09:51] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: add optional to phone text - https://phabricator.wikimedia.org/T438904#12383410 (10Cstone) [04:09:56] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383411 (10Cstone) [04:10:12] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Render second-stage form in Combowiki for banner donations - https://phabricator.wikimedia.org/T439621#12383412 (10Cstone) [04:10:17] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383413 (10Cstone) [04:11:09] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Update the list of ::fieldNames in data fetched from request and session - https://phabricator.wikimedia.org/T434803#12383415 (10Cstone) [04:11:10] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383416 (10Cstone) [04:11:32] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: variant? where paypal, venmo, apple pay, and google pay buttons are loaded to start - https://phabricator.wikimedia.org/T437335#12383417 (10Cstone) [04:11:37] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383418 (10Cstone) [04:11:50] 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Handle major gift amounts from Donate wiki - https://phabricator.wikimedia.org/T435682#12383419 (10Cstone) [04:11:56] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12383420 (10Cstone) [04:15:12] (03CR) 10Eileen: [C:03+2] "Nothing in my comments / concerns is blocking so let's go ahead with this patch now & follow up with anything else" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:23:03] (03CR) 10Lars SG: [C:03+2] Fix typo causing no prospect tab [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346980 (owner: 10Eileen) [04:24:44] (03PS1) 10Lars SG: Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) [04:25:07] (03PS2) 10Lars SG: Automatically generate MGGONN appeals for this year and next year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346988 (https://phabricator.wikimedia.org/T386031) [04:25:20] (03PS2) 10Lars SG: Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) [04:28:13] (03CR) 10Eileen: [C:03+2] Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:30:19] (03PS4) 10Eileen: Always populate amount_journaled_to_foundation on batch export [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346812 [04:30:19] (03PS3) 10Eileen: Add reverse journal handling for endowment-first gateways [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346816 [04:31:09] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347008 [04:31:59] (03CR) 10Eileen: [C:03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347008 (owner: 10Eileen) [04:34:44] !log civicrm upgraded from 87705543 to a30dfd91 [04:34:45] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [04:39:21] (03Merged) 10jenkins-bot: Add gift coding for White Mail / empty appeal donations based on MG Engagement, Direct Mail or DAF email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1339216 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:47:32] (03CR) 10Eileen: [C:03+2] Automatically generate MGGONN appeals for this year and next year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346988 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [04:47:44] (03PS3) 10Lars SG: Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) [04:50:49] (03Merged) 10jenkins-bot: Fix typo causing no prospect tab [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346980 (owner: 10Eileen) [04:52:11] (03PS1) 10Eileen: Drop ODS support from Finance Spreadsheet import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347140 (https://phabricator.wikimedia.org/T434041) [05:18:04] (03Merged) 10jenkins-bot: Automatically generate MGGONN appeals for this year and next year [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346988 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [06:42:21] (03PS1) 10Dmiranda: Use the country_fields config for the ComboWiki phone field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347240 (https://phabricator.wikimedia.org/T438904) [06:50:17] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: add optional to phone text - https://phabricator.wikimedia.org/T438904#12383625 (10dmiranda) Hi @Cstone! The patch for this ticket is ready for review and can be found here: https://gerrit... [07:37:11] (03CR) 10CI reject: [V:04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347319 (owner: 10L10n-bot) [07:56:47] (03CR) 10Raimond Spekking: [C:03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347319 (owner: 10L10n-bot) [09:40:19] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12384147 (10ppenloglou) This request is gaining traction with the Content and Audiences teams in fr-online faster than I thought. Can we see if it can be slotted for an upcomin... [09:58:04] (03CR) 10Jgleeson: [C:03+1] "Nice extraction. I think we need a vendor submodule update with this patch to ensure prod gets the latest Composer classmap too, per your " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [09:59:29] (03CR) 10Jgleeson: [C:03+2] [Doc] Fix name of legacy impression endpoint [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1345581 (owner: 10Ejegg) [10:02:17] (03Merged) 10jenkins-bot: [Doc] Fix name of legacy impression endpoint [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1345581 (owner: 10Ejegg) [10:03:46] (03PS4) 10Ejegg: Convert AmountHelper to service, rename [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344793 (https://phabricator.wikimedia.org/T439147) [10:24:35] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12384286 (10RLewis) @Lars I think the RM should be on the related contact anyway but I think lets check for... [11:15:23] (03CR) 10Jgleeson: [C:03+2] "This is working for me when testing locally with the donor portal. Thanks" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344793 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [11:18:36] (03Merged) 10jenkins-bot: Convert AmountHelper to service, rename [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344793 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [11:20:50] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki: Render second-stage form in Combowiki for banner donations - https://phabricator.wikimedia.org/T439621#12384459 (10Damilare) a:03Damilare [11:24:06] (03PS4) 10Jgleeson: Validate the ComboWiki session country too [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345607 (https://phabricator.wikimedia.org/T437508) [11:26:51] (03CR) 10Jgleeson: Validate the ComboWiki session country too (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345607 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [11:32:09] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12384498 (10jgleeson) [11:41:07] (03CR) 10Laurabarluzzi: [C:03+2] "LGTM - the removal of skipNormalization() for the country field was discussed and approved at tech talk by the team" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345607 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [11:41:18] thanks larssandergreen ! [11:41:19] oops [11:41:26] thanks laurabar ! [11:41:36] tabcomplete got me [11:42:43] 06Fundraising-Backlog, 07Fundraising-ComboWiki-Dependency, 03Civi RoadMap FY 26-27, 07Epic, and 2 others: [Epic] ComboWiki - Phase 1 - https://phabricator.wikimedia.org/T417039#12384518 (10jgleeson) [11:44:07] (03Merged) 10jenkins-bot: Validate the ComboWiki session country too [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345607 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [11:55:01] (03PS3) 10Laurabarluzzi: Apply new 'internalNames' logic to map wmf_ fields from the request to utm_ fields used internally [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346427 (https://phabricator.wikimedia.org/T437483) [11:55:46] (03CR) 10Laurabarluzzi: Apply new 'internalNames' logic to map wmf_ fields from the request to utm_ fields used internally (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346427 (https://phabricator.wikimedia.org/T437483) (owner: 10Laurabarluzzi) [11:57:20] (03PS1) 10Jgleeson: Add unit tests for DonationAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347541 (https://phabricator.wikimedia.org/T439147) [12:11:38] (03PS1) 10Jgleeson: Use GatewayConfigurationFactory for ComboWiki enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347559 (https://phabricator.wikimedia.org/T439147) [12:16:19] (03PS13) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:17:32] (03PS14) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:19:05] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [12:22:44] (03PS15) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:24:01] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [12:27:32] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Implement 3DS redirect, it's currently going to payments - https://phabricator.wikimedia.org/T439623#12384746 (10jgleeson) [12:34:17] (03PS16) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [12:35:49] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [12:46:01] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: Implement 3DS redirect, it's currently going to payments - https://phabricator.wikimedia.org/T439623#12384833 (10jgleeson) I've recreated this locally. The issue is that it's never been implemented, so I've ren... [12:56:22] cstone: ejegg|away, it looks like it was agreed to rename ComboWiki to "Donate". We're now hitting Special:Donate locally, and if we're sticking with that new name, it makes sense to update the other references before I start working on the ComboWikiResultPage as part of the 3D-Secure work, since we send that URL out during API calls. I'll go ahead and rename the files now to get us in a ready state. Where was that [12:56:23] suggested/agreed, btw? I only found out yesterday after my local CombiWiki stopped working, so I merged and pulled down cstone's config patch to fix it. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1346276 For anyone else who hasn't seen it, pull on fundraising-dev, and it'll fix the broken redirect to Special:ComboWiki [12:57:34] jgleeson: it was mainly for the url only then ejegg|away made the phab for it [12:57:52] I wasn't expecting it to be merged so quickly so sorry for the breaking [13:00:49] cstone: It's a bit confusing going from Special:Donate back to Special:ComboWikiResultPage, so instead of adding more aliases, it probably makes sense to just update the references. Donate is a good name anyway. [13:01:02] I'll do it now [13:09:14] I just added https://phabricator.wikimedia.org/T439854 [13:09:18] 06Fundraising-Backlog: Add jenkins job to automerge +2ed patches on fundraising-dev repo - https://phabricator.wikimedia.org/T439854 (10jgleeson) 03NEW [13:33:22] 06Fundraising-Backlog: Rename ComboWiki to Donate - https://phabricator.wikimedia.org/T439855 (10jgleeson) 03NEW [13:41:39] (03PS1) 10Jgleeson: Use Special:Donate and Special:DonateGatewayResult in payments config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1347613 (https://phabricator.wikimedia.org/T439623) [13:41:49] (03PS17) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [13:42:29] (03PS2) 10Jgleeson: Use Special:Donate and Special:DonateGatewayResult in payments config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1347613 (https://phabricator.wikimedia.org/T439623) [13:44:03] (03PS3) 10Jgleeson: Use Special:Donate and Special:DonateGatewayResult in payments config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1347613 (https://phabricator.wikimedia.org/T439855) [13:44:15] (03PS1) 10Jgleeson: Rename ComboWiki special pages to Donate and DonateGatewayResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347614 (https://phabricator.wikimedia.org/T439855) [13:46:28] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 13Patch-For-Review: Rename ComboWiki to Donate - https://phabricator.wikimedia.org/T439855#12385171 (10jgleeson) [13:46:39] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12385183 (10Lars) @ppenloglou Let's make a decision on scheduling this after the meeting on Monday, just in case we end up wanting something slightly different after that meeti... [13:58:49] woot, renames! [14:02:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New calendar year sum amount field - https://phabricator.wikimedia.org/T438035#12385279 (10ppenloglou) Yes absolutely! I want everyone to be on the same page on what this will be before it's built. [14:10:31] (03PS18) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [14:12:31] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [14:12:45] (03PS19) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [14:13:56] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the CR, I've made the recommended changes." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [14:14:14] (03PS20) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [14:14:14] (03PS7) 10Damilare Adedoyin: WIP: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [14:14:14] (03PS3) 10Damilare Adedoyin: Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) [14:15:59] (03CR) 10CI reject: [V:04-1] WIP: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [14:16:13] (03CR) 10CI reject: [V:04-1] Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [14:23:49] (03PS5) 10Ejegg: Employer autocomplete with cdx-lookup [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346802 (https://phabricator.wikimedia.org/T438918) [14:24:10] ok ^^^ seems to be working for me locally [14:25:39] ah i guess i could look into a test or two [14:25:58] (03PS8) 10Damilare Adedoyin: WIP: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [14:26:57] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12385513 (10Lars) @RLewis The one concern I have about the related contacts thing is that we are potentially... [14:27:26] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki, 13Patch-For-Review: Combowiki: Check for employer selection bug - https://phabricator.wikimedia.org/T438918#12385517 (10Ejegg) OK, latest patch set should clear out previously selected values when the donor changes the... [14:28:01] (03CR) 10CI reject: [V:04-1] WIP: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [14:30:33] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12385539 (10Lars) I'm not entirely clear on which appeal codes we need to include in our checks here. The Sea... [14:32:05] (03PS4) 10Lars SG: Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) [14:32:50] (03CR) 10Ejegg: [C:03+2] "Looks good, implements the suggestions in 3 of those comments." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [14:44:22] (03PS9) 10Damilare Adedoyin: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [14:45:55] (03PS21) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [14:46:12] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [14:48:02] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [14:48:03] (03PS22) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [14:48:31] (03Merged) 10jenkins-bot: Follow up per eileen's comments on b918ca8f7a2fefb9d7656c6d02e6ad4a342158d8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347006 (https://phabricator.wikimedia.org/T386031) (owner: 10Lars SG) [14:49:21] (03CR) 10CI reject: [V:04-1] Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [14:51:01] (03CR) 10Damilare Adedoyin: "Recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 (owner: 10Damilare Adedoyin) [14:52:16] (03PS10) 10Damilare Adedoyin: Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) [14:54:01] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [14:59:21] (03PS10) 10Laurabarluzzi: Create a CustomLogger trait to share setup and getLogMessagePrefix across all ComboWiki included classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831) [14:59:21] (03CR) 10Laurabarluzzi: "@ejegg@ejegg.com I worked on making the logger a service and injected as a combowiki dependency. To make the review comparison easier I ma" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1345631 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [15:06:43] that looks really promising laurabar [15:06:54] (03PS23) 10Damilare Adedoyin: Remove duplicated lines between adapters Apple pay api classes [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1337640 [15:07:34] it's the same DonationDetails object passed around through all the objects that use that logger, so it should seamlessly pick up any order id updates, right? [15:10:18] jgleeson: I really want to merge your rename patches now but I'm wary of causing the rebase pain for laurabar and damilare. in particular if those logger patches are ready I'd like to merge those then do the rename on top. Does that sound alright? [15:10:38] ^-- no problem for me [15:10:40] sounds good ejegg [15:10:48] sounds good to me also [15:10:49] (03CR) 10CI reject: [V:04-1] Add Gravy get payment methods API to enable Apple and Google pay app payments through Gravy [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1342794 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [15:11:04] cool cool, lemme pull those logger patches down and click around a bit [15:11:13] (03CR) 10CI reject: [V:04-1] Create API for submit ApplePay and GooglePay on through the Gravy adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344317 (https://phabricator.wikimedia.org/T438879) (owner: 10Damilare Adedoyin) [15:11:16] (03CR) 10CI reject: [V:04-1] Add fields for payments through Gravy paybybank connector. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344755 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [15:12:43] Yes, I'm trying to fix the ucrrent tests because they are broken with the new patch -- and yes the order_id if it changes in the ComboWiki->donationDetails object it should reflect in the log (at least locally I could see the logs loading empty strings (before reading data from the request and going through the flow) and then the contribution tracking + order_id appeared suggesting indeed that a change of its value is [15:12:43] reflected in the log [15:14:46] OK, that seems consistent with existing logger behavior [15:18:18] do you want any extra eyes on those failing tests laurabar? [15:19:50] No I think I already resolved - they were linked to the added arguments [15:23:59] (03PS1) 10Lars SG: Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) [15:27:15] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 07fr-current-sprint, 13Patch-For-Review: Show iframe with donor details in Zendesk - https://phabricator.wikimedia.org/T433866#12385863 (10krobinson) Thanks, @Lars ! Core folks on the team are going t... [15:27:23] So should I abandon the first patch and we stick with the new one with the service? [15:27:44] If so I merge the commits since I actually built the service patch from the previous patch [15:28:12] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Stop exporting permanent contact hash, use expiring checksum instead - https://phabricator.wikimedia.org/T402462#12385869 (10ppenloglou) Thank you @Ejegg , want to confirm the struc... [15:31:10] laurabar: either way, I'm happy to C+2 the two separate patches [15:38:31] ejegg: before you merge the rename, it would be good to get eyes on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1346106 as that touches a bunch of ComboWiki named stuff [15:38:54] if anyone in fr-tech has review capacity to look at that, I would be happy to do some review exchange :D [15:39:19] it has good unit test coverage and test instructions in the commit [15:39:40] [15:42:55] (03PS4) 10Laurabarluzzi: Inject the logger as a service and create custom ComboWikiLogPrefixProvider class to set a sharable prefix across ComboWiki code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) [15:46:29] ejegg: I picked the service injection version: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1347647/3 [15:46:32] looking jgleeson [15:46:41] thank you damilare ! [15:46:45] it's ready for code review and the tests pass [15:47:01] np, please can you help with this: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1346647 jgleeson [15:47:06] (03PS5) 10Laurabarluzzi: Inject the logger as a service and create custom ComboWikiLogPrefixProvider class to set a sharable prefix across ComboWiki code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) [15:47:09] its a small update to an existing action [15:47:27] sure damilare [15:52:38] (03CR) 10CI reject: [V:04-1] Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [15:56:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Monthly convert thank you email doesn't include frequency - https://phabricator.wikimedia.org/T439890 (10Lars) 03NEW [15:57:33] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891 (10jgleeson) 03NEW [15:58:34] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Stop exporting permanent contact hash, use expiring checksum instead - https://phabricator.wikimedia.org/T402462#12386174 (10Ejegg) Yes @ppenloglou that looks correct [15:59:18] ejegg: Is the fraud ML service in the right place there ^^ The DB is on the same box, right? [16:00:25] https://phabricator.wikimedia.org/F105711822 [16:02:54] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891#12386202 (10jgleeson) We need two new items in the donor traffic lane for Portal and mobile app banners, which send traffic to donate-wiki. [16:04:12] looking jgleeson [16:04:25] but yes, it has its db service on the same box [16:05:38] i see the tk / eventlogging pointing to donatewiki but i don't think there's been any tk experiment on donatewiki yet [16:05:45] i think that's all waiting for the combowiki switch [16:06:01] oh right [16:06:12] hostname for ml is frproto1001 [16:06:43] and the fraud scoring service sends payment attempts and scores to the queues to get them into civi, so you can add another arrow for that [16:07:31] there is some small interaction between tk and centralnotice now, but only for suppressing banners when in certain experiments [16:07:36] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891#12386230 (10jgleeson) ` Elliott Eggleston hostname for ml is frproto1001 5:06 PM and the fraud scoring service sends payment attempts and... [16:08:15] that logic happens on the main cluster when the user's browser is deciding whether to show a banner, not in metawiki [16:08:21] yeah ejegg I spotted all the TK stuff in donut so added a bit for that but I can remove it [16:08:54] ahh yeah, that container is just doing double duty [16:09:17] I guess when donate.wm.org is decommissioned we should just call it the centralNotice image [16:09:37] or even better have it be a simulation of enwiki and make another container to simulate metawiki [16:10:50] (03PS1) 10Lars SG: Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T433866) [16:12:32] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10MediaWiki-extensions-DonationInterface: Stop exporting permanent contact hash, use expiring checksum instead - https://phabricator.wikimedia.org/T402462#12386240 (10ppenloglou) Thanks again @Ejegg , taking this back to my... [16:14:52] jgleeson: oh also, privatebin has been decommissioned - you can remove that bit from the donorwiki box [16:15:16] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891#12386253 (10jgleeson) ` jgleeson: oh also, privatebin has been decommissioned - you can remove that bit from the donorwiki box ` [16:16:13] (03CR) 10Damilare Adedoyin: [C:03+2] "Thanks for all the work on this jgleeson, added a non-blocking comment as the change can be done on a follow on patch. LGTM! Thanks." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [16:16:22] thanks ejegg. just checking damilare's patch but drop any other ideas or corrections onto T439891 and I'll work them in [16:16:23] T439891: Update Fundraising Tech Stack Diagram for 2026 - https://phabricator.wikimedia.org/T439891 [16:16:42] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Monthly convert thank you email doesn't include frequency - https://phabricator.wikimedia.org/T439890#12386258 (10Lars) The only change in code is adding the example and updating the template for dev. [16:17:06] (03PS2) 10Lars SG: Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) [16:17:14] (03CR) 10Jgleeson: Filter ComboWiki payment methods by country (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [16:17:23] Thank you damilare !!! [16:17:27] np! [16:17:30] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Monthly convert thank you email doesn't include frequency - https://phabricator.wikimedia.org/T439890#12386261 (10Lars) Patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/1347680 [16:19:17] (03PS1) 10Lars SG: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347684 [16:20:27] the country list is currently mapping UK to UK instead of GB jgleeson which the adapters do not recognise, so it defaults back to US. I'm looking into it, just thought you should know from my last comment on your patch. [16:20:47] you can test with this link: https://localhost:9001/index.php?title=Special%3ADonate&payment_method=cc&recurring=0&language=en¤cy=USD&amount=35&country=GB&debug=true instead [16:21:10] oh hah we've seen that before damilare [16:21:21] isn't UK actually the ISO code for Ukraine ? [16:21:36] ah no that's UA [16:21:57] (03CR) 10Lars SG: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347684 (owner: 10Lars SG) [16:22:27] damilare: I did see that with cstone actually [16:22:31] and forgot to log it [16:22:35] thanks for picking up on that [16:22:41] oh lol "ISO guidelines historically avoided using letters like 'K' for 'Kingdom' to keep codes stable if a country's governance changes" [16:23:03] lol [16:23:07] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347684 (owner: 10Lars SG) [16:23:19] np jgleeson [16:24:35] (03PS2) 10Lars SG: Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) [16:26:27] !log civicrm upgraded from a30dfd91 to cb812976 [16:26:29] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [16:27:12] jgleeson: there was already a renaming phab ok to merge the one you made into the other? [16:27:47] I think I've tagged the patch against my one cstone [16:27:53] wanna inverse the merge [16:27:58] and update the desc [16:28:02] from the older? [16:28:02] hah my patch was on the other :P [16:28:05] we can just have 2 [16:28:08] oh sry [16:28:16] I didn't realise there was a patch [16:28:37] well how it got renamed in the first place? [16:28:49] oh you mean the config patch on fun-dev [16:29:06] I'm talking about this one https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1347614 [16:29:19] feel free to merge them I can then repoint that patch to yours [16:29:32] sry [16:29:42] hah no sorry not awake and couldnt sleep again [16:29:54] :( [16:30:11] combowiki keeping you up? [16:30:14] @_@ [16:30:15] i was going to leave the Special:combowiki for ramon and co but its fine too to get the full redirect [16:30:18] er [16:30:22] get rid of it fully [16:30:28] but why i did only a small change first [16:32:15] (03CR) 10Jgleeson: "Gerrit is playing tricks on me. Do you see what I see?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [16:36:28] (03PS3) 10Damilare Adedoyin: Add payment service id parameter to migration script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) [16:36:32] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate some Direct Mail white mail coding - https://phabricator.wikimedia.org/T386031#12386356 (10Lars) The main work here has been deployed, at long last! @RL... [16:39:13] (03CR) 10Damilare Adedoyin: "Thanks jgleeson for the spot, I've made the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [16:40:57] (03CR) 10Ejegg: "Heh, nice to know MW didn't completely reinvent the wheel here" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344748 (https://phabricator.wikimedia.org/T439147) (owner: 10Ejegg) [16:47:26] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Add appeal code to DAF donations on import - https://phabricator.wikimedia.org/T434201#12386424 (10Lars) This has also been deployed, still need the SK mentione... [16:49:25] (03CR) 10CI reject: [V:04-1] Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) (owner: 10Lars SG) [16:49:59] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Combowiki: Fix country mapping in URL parameter - https://phabricator.wikimedia.org/T439898 (10Damilare) 03NEW [16:50:10] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog: Combowiki: Fix country mapping in URL parameter - https://phabricator.wikimedia.org/T439898#12386441 (10Damilare) a:03Damilare [16:50:13] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) (owner: 10Lars SG) [16:52:38] (03PS1) 10Damilare Adedoyin: Set country value to url parameter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347697 (https://phabricator.wikimedia.org/T439898) [16:54:12] (03CR) 10CI reject: [V:04-1] Set country value to url parameter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347697 (https://phabricator.wikimedia.org/T439898) (owner: 10Damilare Adedoyin) [16:55:32] (03PS2) 10Damilare Adedoyin: Set country value to url parameter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347697 (https://phabricator.wikimedia.org/T439898) [16:56:23] (03PS1) 10Damilare Adedoyin: Fix eslint warning on combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347699 [16:56:40] (03CR) 10CI reject: [V:04-1] Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [16:58:23] (03CR) 10CI reject: [V:04-1] Fix eslint warning on combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347699 (owner: 10Damilare Adedoyin) [16:58:52] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [17:01:07] (03PS2) 10Damilare Adedoyin: Fix eslint warning on combowiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347699 [17:03:19] (03PS7) 10Laurabarluzzi: Restyle the footer in EmailPreference without the centered gray background box [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) [17:05:03] (03PS8) 10Laurabarluzzi: Restyle the footer in EmailPreference without the centered gray background box [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) [17:06:57] (03CR) 10Laurabarluzzi: "@lsandergreen@wikimedia.org thanks for spotting that. I updated the style and fixed the alignment by setting the line in the top border of" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi) [17:07:47] (03PS2) 10Jgleeson: Add unit tests for DonationAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347541 (https://phabricator.wikimedia.org/T439147) [17:07:49] (03CR) 10Ejegg: [C:03+2] Add unit tests for DonationAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347541 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson) [17:07:54] (03CR) 10CI reject: [V:04-1] Add payment service id parameter to migration script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [17:08:04] (03CR) 10Ejegg: [C:03+2] "Thanks for the coverage!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347541 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson) [17:08:56] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [17:09:04] (03CR) 10Ejegg: [C:03+2] Use GatewayConfigurationFactory for ComboWiki enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347559 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson) [17:09:21] thanks ejegg [17:12:18] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12386612 (10NNgu-WMF) @Lars I'm chatting with Content and Email teams about this, and it seems like not a priorit... [17:13:22] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12386615 (10Lars) OK, I'll stick this in scoping and we can bring it back if needed. Otherwise, it will eventuall... [17:14:12] 06Fundraising-Backlog, 10FR-Smashpig, 10MediaWiki-extensions-DonationInterface, 07payments-orchestration: Update to newer Gr4vy SDK or remove SDK dependency altogether - https://phabricator.wikimedia.org/T439156#12386618 (10Ejegg) [17:15:50] 10fundraising-tech-ops, 10observability: Add astein as a user for Fundraising team in VO/splunk oncall - https://phabricator.wikimedia.org/T439906 (10Dwisehaupt) 03NEW [17:19:26] FIRING: EndpointResponseTimeWarning: Slow response for frdata2002 civiproxy [[ $value }} seconds - https://alerts.wikimedia.org/?q=alertname%3DEndpointResponseTimeWarning [17:19:56] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Create fundraising/REL1_47 branch when REL1_47 is available - https://phabricator.wikimedia.org/T439907 (10Ejegg) 03NEW [17:20:26] FIRING: EndpointResultCritical: Endpoint check for civiproxy on frdata1003 is CRITICAL - https://alerts.wikimedia.org/?q=alertname%3DEndpointResultCritical [17:24:23] 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 06Release-Engineering-Team, 10Continuous-Integration-Config: Create CI jobs for fundraising on MW 1.47 - https://phabricator.wikimedia.org/T439908 (10Ejegg) 03NEW [17:24:26] RESOLVED: EndpointResponseTimeWarning: Slow response for frdata2002 civiproxy [[ $value }} seconds - https://alerts.wikimedia.org/?q=alertname%3DEndpointResponseTimeWarning [17:25:26] RESOLVED: EndpointResultCritical: Endpoint check for civiproxy on frdata1003 is CRITICAL - https://alerts.wikimedia.org/?q=alertname%3DEndpointResultCritical [17:27:32] (03Merged) 10jenkins-bot: Add unit tests for DonationAmountRules [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347541 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson) [17:27:34] (03Merged) 10jenkins-bot: Use GatewayConfigurationFactory for ComboWiki enabled gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347559 (https://phabricator.wikimedia.org/T439147) (owner: 10Jgleeson) [17:28:10] (03CR) 10Jgleeson: "I think the placeholders might need to be bumped up by one. I might be wrong, though, as I'm not 100% sure. Can you take a look?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [17:29:22] damilare: I saw 4 placeholders in the SQL and 3 mentioned in your script so I assumed it was a "php arrays start with 0" thing but now I'm not sure [17:29:26] (03PS4) 10Damilare Adedoyin: Add payment service id parameter to migration script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) [17:29:53] 4 params with 3 placeholders assigned [17:30:16] no you're right, I missed the update, my last change would have overwriting the id I was trying to pass through [17:30:27] overwritten* [17:30:41] oh good [17:30:55] thanks! [17:35:40] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 05MW-1.47-notes (1.47.0-wmf.23; 2026-10-06): Use dependency injection for gateway configuration and routing - https://phabricator.wikimedia.org/T439147#12386744 (10Ejegg) [17:41:40] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12386765 (10NNgu-WMF) From Ramon: So, technically, feels like we could use DC to hide the give less button if the... [17:57:42] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12386830 (10RLewis) @MDemosWMF since your team does the code changing for the MGGO gifts, are you able to adv... [18:01:51] just finished my 1:1 damilare|brb so will finish up reviewing your patch now before I drop off [18:03:32] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12386852 (10RLewis) @Lars For this point -//The one concern I have about the related contacts thing is that w... [18:04:32] (03CR) 10Jgleeson: [C:03+2] "This looks good to me! thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [18:06:23] fr-tech, there's a small CombWiki config one-line update patch here that is blocking the payment methods-by-country patch (which damilare|brb has +2ed). Could someone take a peek if they have a moment? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1346729/1 [18:06:54] looking jgleeson [18:07:13] once they merge, I'll rebase the Combowiki rename patch over those [18:07:15] thanks ejegg [18:07:28] weird that we need that mapping, but I'll C+2 it to unblock [18:07:39] (03PS2) 10Jgleeson: Map the Adyen card option to the cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346729 (https://phabricator.wikimedia.org/T437508) [18:07:43] (03CR) 10Ejegg: [C:03+2] Map the Adyen card option to the cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346729 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [18:08:27] we're not using adyen directly yet, ejegg, but I noticed when doing the payment method in the follow-on patch that it has no mapping config even though we have an adyen card component [18:08:44] thanks! [18:09:36] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG) [18:09:44] (03CR) 10Lars SG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) (owner: 10Lars SG) [18:11:13] (03PS4) 10Laurabarluzzi: Apply new 'internalNames' logic to map wmf_ fields from the request to utm_ fields used internally [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346427 (https://phabricator.wikimedia.org/T437483) [18:11:14] (03CR) 10Ejegg: [C:03+2] Apply new 'internalNames' logic to map wmf_ fields from the request to utm_ fields used internally [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346427 (https://phabricator.wikimedia.org/T437483) (owner: 10Laurabarluzzi) [18:18:41] (03Merged) 10jenkins-bot: Map the Adyen card option to the cc payment method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346729 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [18:18:44] (03Merged) 10jenkins-bot: Apply new 'internalNames' logic to map wmf_ fields from the request to utm_ fields used internally [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346427 (https://phabricator.wikimedia.org/T437483) (owner: 10Laurabarluzzi) [18:19:30] (03PS7) 10Jgleeson: Filter ComboWiki payment methods by country [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) [18:21:35] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 07fr-combowiki, 05MW-1.47-notes (1.47.0-wmf.23; 2026-10-06): Minimize use of 'Combowiki' in code - https://phabricator.wikimedia.org/T437062#12386891 (10jgleeson) [18:21:37] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 13Patch-For-Review: Rename ComboWiki to Donate - https://phabricator.wikimedia.org/T439855#12386889 (10jgleeson) →14Duplicate dup:03T437062 [18:22:17] ejegg: jgleeson this could be my tired brain but would that mapping patch be the reason that we have a lot of older adyen recurrings without a payment submethod in civi? that we fixed that issue on payments wiki? [18:22:52] that patch just added it to the combowiki api call cstone [18:23:29] yeah just if that soudned like whatever issue had caused the adyen one back in the day? [18:23:44] ooh okay no its differnet haha [18:23:49] sorry! i shouldnt be asking questions right now LOL [18:24:05] ha it's fine [18:24:21] I feel bad that your so sleep deprived [18:24:51] hah im gona just double down and caffeine it up now and hopefully just fully crash at like 8pm [18:25:29] (03CR) 10Ejegg: [C:03+2] "The code looks correct, and I think that's the appropriate status. It looks like we are ignoring the corresponding audit lines, so we migh" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1346134 (https://phabricator.wikimedia.org/T434019) (owner: 10Wfan) [18:26:14] I'm gonna step away for a bit and come back later to see if CI merged the patch I wanna rebase over [18:26:29] (03Merged) 10jenkins-bot: Add Canceled_Reversal to be handle from paypal ipn [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/1346134 (https://phabricator.wikimedia.org/T434019) (owner: 10Wfan) [18:34:13] (03Merged) 10jenkins-bot: Add payment service id parameter to migration script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1346647 (https://phabricator.wikimedia.org/T438723) (owner: 10Damilare Adedoyin) [18:37:03] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12386954 (10Lars) @RLewis I think the risk for the missing RM is if a contact has a RM, then they donate via... [18:41:51] thanks jgleeson|away for the CR [18:46:11] (03CR) 10Ejegg: [C:04-1] "Getting an exception in local smoke testing, will try to figure it out." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [18:46:14] (03CR) 10Jgleeson: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1346106 (https://phabricator.wikimedia.org/T437508) (owner: 10Jgleeson) [18:46:50] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347726 [18:48:40] (03CR) 10Damilare Adedoyin: [C:03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347726 (owner: 10Damilare Adedoyin) [18:49:49] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/1347726 (owner: 10Damilare Adedoyin) [18:51:56] !log civicrm upgraded from cb812976 to 40a4588a [18:51:57] Logged the message at https://wikitech.wikimedia.org/wiki/Fundraising/SAL [19:08:32] (03CR) 10Ejegg: [C:04-1] "It's from the call with compact=false" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [19:19:55] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10fundraising-tech-ops, 10DNS, and 4 others: Investigate having combowiki on donate.wikipedia.org - https://phabricator.wikimedia.org/T433108#12387089 (10XenoRyet) We have legal and security sign-off. Jeff and Traffic team have a plan... [19:20:50] (03PS1) 10Ejegg: Downgrade TY timing log lines to debug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347744 [19:21:12] trivial patch to review ^^^ [19:21:33] also we should probably change the logging config for the wmf stream to just log at info or above [19:24:57] (03PS1) 10Damilare Adedoyin: Fix type on MigrateToGravy action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347748 [19:25:21] ejegg: can I get a quick +2 on this as well ^ [19:25:42] (03CR) 10Damilare Adedoyin: [C:03+2] Downgrade TY timing log lines to debug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347744 (owner: 10Ejegg) [19:28:49] looking damilare [19:29:11] (03CR) 10Ejegg: [C:03+2] Fix type on MigrateToGravy action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347748 (owner: 10Damilare Adedoyin) [19:29:41] thanks! [19:32:34] ty too! [19:50:53] (03Merged) 10jenkins-bot: Downgrade TY timing log lines to debug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347744 (owner: 10Ejegg) [20:00:08] (03PS9) 10Laurabarluzzi: Restyle the footer in EmailPreference without the centered gray background box [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) [20:00:51] (03CR) 10CI reject: [V:04-1] Fix type on MigrateToGravy action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347748 (owner: 10Damilare Adedoyin) [20:00:52] (03CR) 10Ejegg: [C:03+2] "Looks good to me now! Not sure if there was something odd locally that was making me see it off before." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi) [20:02:25] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347748 (owner: 10Damilare Adedoyin) [20:03:12] (03Merged) 10jenkins-bot: Restyle the footer in EmailPreference without the centered gray background box [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1344270 (https://phabricator.wikimedia.org/T435963) (owner: 10Laurabarluzzi) [20:14:29] (03PS6) 10Laurabarluzzi: Inject the logger as a service and create custom ComboWikiLogPrefixProvider class to set a sharable prefix across ComboWiki code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) [20:15:36] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 13Patch-For-Review: Make double opt in success page a little nicer - https://phabricator.wikimedia.org/T435963#12387245 (10Lars) Thanks @Laurabarluzzi, appreciate you fixing that issue. [20:16:06] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12387246 (10greg) a:03Ejegg Assigning to Elliott after he st... [20:18:57] (03CR) 10Ejegg: "This looks great! A few comments inline but all fine to do in a follow-up patch" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [20:19:03] (03CR) 10Ejegg: [C:03+2] Inject the logger as a service and create custom ComboWikiLogPrefixProvider class to set a sharable prefix across ComboWiki code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [20:19:51] ok, let's see if I can rebase those rename patches across the top of ^^^ [20:21:09] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 07FR-Audience-Dev: Add token for recurring donation amount in USD - https://phabricator.wikimedia.org/T418279#12387275 (10Lars) @NNgu-WMF So we do want this, but lower priority then? [20:21:34] (03Merged) 10jenkins-bot: Inject the logger as a service and create custom ComboWikiLogPrefixProvider class to set a sharable prefix across ComboWiki code [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347647 (https://phabricator.wikimedia.org/T434831) (owner: 10Laurabarluzzi) [20:23:31] (03CR) 10Ejegg: [C:04-1] "I'm going to try adding a quick refactor patch to lay the groundwork for this one. Feels like it would be a lot simpler to have two functi" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [20:27:39] (03PS2) 10Ejegg: Rename ComboWiki special pages to Donate and DonateGatewayResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347614 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:27:50] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent runaway menu rebuilds - https://phabricator.wikimedia.org/T439924 (10Lars) 03NEW [20:27:58] (03CR) 10Ejegg: "PS2: Manual rebase" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347614 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:28:01] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent runaway menu rebuilds - https://phabricator.wikimedia.org/T439924#12387299 (10Lars) a:03Lars [20:30:47] (03CR) 10Ejegg: [C:03+2] Use Special:Donate and Special:DonateGatewayResult in payments config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1347613 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:31:01] (03CR) 10Ejegg: [V:03+2 C:03+2] Use Special:Donate and Special:DonateGatewayResult in payments config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/1347613 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:33:18] (03CR) 10Ejegg: [C:03+2] "Looks good! Thanks for the update. Let's consider rename the result page to remove 'Gateway'." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347614 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:35:33] (03Merged) 10jenkins-bot: Rename ComboWiki special pages to Donate and DonateGatewayResult [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347614 (https://phabricator.wikimedia.org/T439855) (owner: 10Jgleeson) [20:37:51] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12387336 (10MDemosWMF) @Lars @RLewis The rules were pretty fuzzy around this - basically I would look at the... [21:10:54] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing, and 3 others: Automate - MGGO appeal update - https://phabricator.wikimedia.org/T406662#12387435 (10MDemosWMF) I agree with that! @RLewis How does that look to you? [21:14:00] (03PS3) 10Ejegg: Batch campaign mixin lookup [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [21:14:00] (03PS1) 10Ejegg: Refactor getCampaignMixins for consistent format [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347797 [21:16:38] (03PS4) 10Ejegg: Batch campaign mixin lookup [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [21:19:45] (03CR) 10Ejegg: [C:03+1] "@taavi I added the refactor patch as a parent of this one, and sure enough it made the cause of the exception clear - the new return value" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [21:21:00] (03CR) 10CI reject: [V:04-1] Refactor getCampaignMixins for consistent format [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347797 (owner: 10Ejegg) [21:21:22] (03CR) 10CI reject: [V:04-1] Batch campaign mixin lookup [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [21:22:07] (03PS2) 10Ejegg: Refactor getCampaignMixins for consistent format [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347797 [21:23:56] (03PS5) 10Ejegg: Batch campaign mixin lookup [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1344334 (https://phabricator.wikimedia.org/T439239) (owner: 10Majavah) [21:32:54] 06Fundraising-Backlog, 06Fundraising-Tech-Roadmap, 10Wikimedia-Fundraising-CiviCRM, 10FR-Donation-Processing: Develop process to prevent direct mail being sent to long-deleted cids - https://phabricator.wikimedia.org/T406771#12387499 (10MDemosWMF) @Lars It worked! Thank you! [21:41:19] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Prevent runaway menu rebuilds - https://phabricator.wikimedia.org/T439924#12387536 (10Lars) [[ https://github.com/civicrm/civicrm-core/pull/37194 | Upstream PR ]] We'll get this soon enough through the normal upgrade pro... [21:41:21] (03PS1) 10Ejegg: Fix a FIXME in country sorting [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347813 [21:43:40] (03PS2) 10Ejegg: Fix FIXMEs in choice data sorting [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347813 [21:47:22] (03PS1) 10Ejegg: Also sort regions in choiceData [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/1347819 [21:51:49] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12387547 (10Ejegg) @taavi it looks like your patch combines th... [21:53:09] (03PS3) 10Lars SG: Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) [21:53:54] lol content-dependent tests [22:03:49] 03Fundraising Sprint: Random Posture Generators, 06Fundraising-Backlog, 07fr-combowiki: Combowiki: display endowment with utm_medium=endowment - https://phabricator.wikimedia.org/T434233#12387560 (10dmiranda) a:03dmiranda [22:10:34] 06Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-MGFE: Bulk lookup function for guest lists - https://phabricator.wikimedia.org/T439797#12387574 (10DBautista-WMF) Thanks @Lars following up to share that if you can get a SK working in Q2 that'd be great, but we totally understand if you can't get... [22:36:49] (03PS2) 10Dmiranda: Use the country_fields config for the ComboWiki phone field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/1347240 (https://phabricator.wikimedia.org/T438904) [23:25:07] 06Fundraising Tech - Chaos Crew, 06Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 13Patch-For-Review, and 2 others: CentralNotice must batch campaign mixin lookup & use stampede protection - https://phabricator.wikimedia.org/T439239#12387715 (10taavi) >>! In T439239#12387547, @Ejegg wrote: > @t... [23:38:13] (03CR) 10Cstone: [C:03+2] Fix monthly convert example [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347680 (https://phabricator.wikimedia.org/T439890) (owner: 10Lars SG) [23:38:40] (03CR) 10Cstone: [C:03+2] Add Relationship Manager and WLS to ZD iframe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/1347667 (https://phabricator.wikimedia.org/T433866) (owner: 10Lars SG)